Re: [Qemu-devel] [PATCH v7] docs: add cpu-hotplug.txt

2016-08-22 Thread Dou Liyang
Hi Alexandre, At 08/22/2016 04:56 PM, Alexandre DERUMIER wrote: Hello, I'm looking to implement cpu hotplug, and I have a question about cpu flags currently I have something like -cpu qemu64,+lahf_lm,+sep,+kvm_pv_unhalt,+kvm_pv_eoi,enforce -smp 4,sockets=2,cores=2,maxcpus=4 Does I need to

Re: [Qemu-devel] QEMU XHCI support (FreeBSD)

2016-08-22 Thread Thomas Huth
On 22.08.2016 20:15, Hans Petter Selasky wrote: > Hi, > > I'm currently testing QEMUs XHCI support with FreeBSD and found some > bugs in FreeBSDs XHCI aswell as QEMUs XHCI. > > 1) QEMU falsely reports a remainder of 8 bytes on TR_SETUP. This patch > fixes it. Can it be upstreamed? Hi Hans,

[Qemu-devel] QEMU XHCI support (FreeBSD)

2016-08-22 Thread Hans Petter Selasky
Hi, I'm currently testing QEMUs XHCI support with FreeBSD and found some bugs in FreeBSDs XHCI aswell as QEMUs XHCI. 1) QEMU falsely reports a remainder of 8 bytes on TR_SETUP. This patch fixes it. Can it be upstreamed? --- ./work/qemu-2.3.0/hw/usb/hcd-xhci.c.orig 2016-08-22

[Qemu-devel] [Bug 1615823] [NEW] Windows 10 reports no compatible TPM found yet device manager shows it?

2016-08-22 Thread Kelvin Middleton
Public bug reported: Ubuntu 16.04 with stock kvm, libvirt, ovmf Qemu 2.5 installed from stock ubuntu ppa Qemu 2.6.1 built from tarball. Qemu 2.7.0-rc4 built from tarball. Windows 10 guest reports a TPM device is installed and the driver functional under Device Manager-->Security Devices. TPM

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-22 Thread ronnie sahlberg
It is never too late. I can start working on a patch to add "iser://" URL support to libiscsi right now. It should be a trivial change. I think I would prefer iser:// instead of iscsi+iser:// but it is not religiusly. Let me know if you rather want iscsi+iser. But you would still need some

Re: [Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
On 22 August 2016 at 12:20, Peter Maydell wrote: > > Awkward that this missed rc4 by an hour or two :-( Indeed, and I'm sorry that's the case. It wasn't even in the context of the upcoming release that I tried building and stumbled across this - I'm just back after some

Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field

2016-08-22 Thread Denis V. Lunev
On 08/22/2016 10:00 AM, Denis V. Lunev wrote: On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote: The VirtQueue->inuse field is not always updated correctly. These patches fix it. Originally this series was called "virtio-balloon: fix stats vq migration" but Ladi Prosek posted a nicer fix called

Re: [Qemu-devel] [Qemu-arm] [PATCH] block: m25p80c Fix vmstate structure name

2016-08-22 Thread Paolo Bonzini
On 20/08/2016 00:20, Alistair Francis wrote: >> > Change wrong name of the vmstate structure. Since this breaks >> > compatibility update version and fields to 0. > s/and/set/g > Or more likely: "update the VMState version to 0 and make all fields independent of the VMState version".

[Qemu-devel] [ANNOUNCE] QEMU 2.7.0-rc4 is now available

2016-08-22 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 2.7 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.7.0-rc4.tar.bz2 A note from the

Re: [Qemu-devel] QEMU make: ROM is too large

2016-08-22 Thread Thomas Hanson
On 22 August 2016 at 08:23, Peter Maydell wrote: > PS: just passing --enable-debug to configure should > be sufficient to do a no-optimization debug-symbols > build; do you really need to manually specify > CFLAGS? I wonder whether you're ending up with two >

Re: [Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Peter Maydell
On 22 August 2016 at 15:57, Ed Maste wrote: > Must include "qemu-version.h" for the QEMU_PKGVERSION definition. > > Signed-off-by: Ed Maste > --- > bsd-user/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bsd-user/main.c b/bsd-user/main.c

[Qemu-devel] [PATCH v2 3/9] hw: arm: SMMUv3 emulation model

2016-08-22 Thread Prem Mallappa
Big patch adds SMMUv3 model to Qemu - As per SMMUv3 spec 16.0 - Works with SMMUv3 driver in Linux 4.7rc1 - Only LPAE mode translation supported - BE mode is not supported yet - Stage1, Stage2 and S1+S2 - Suspend/resume not tested Signed-off-by: Prem Mallappa

[Qemu-devel] [PATCH v2 9/9] [optional] arm: smmu-v3: ACPI IORT initial support

2016-08-22 Thread Prem Mallappa
Added ACPI IORT tables, was needed for internal project purpose, but posting here for anyone looking for testing ACPI on ARM platforms. (P.S: Linux side IORT patches are WIP) Signed-off-by: Prem Mallappa --- hw/arm/virt-acpi-build.c| 43 +++

[Qemu-devel] [PATCH v2 2/9] devicetree: Added new APIs to make use of more fdt functions

2016-08-22 Thread Prem Mallappa
SMMUv3 needs device tree entry like below interrupt-names = "gerror", "priq", "eventq", "cmdq-sync"; This patch introduces helper function to add entries like above Signed-off-by: Prem Mallappa --- device_tree.c| 35

[Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

2016-08-22 Thread Prem Mallappa
Signed-off-by: Prem Mallappa --- include/qemu/log.h | 1 + util/log.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/qemu/log.h b/include/qemu/log.h index 234fa81..3dd2131 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -42,6 +42,7

[Qemu-devel] [PATCH v2 7/9] [optional] tests: libqos: generic pci probing helpers

2016-08-22 Thread Prem Mallappa
Current libqos PCI helpers are x86 only, this addes a generic interface. Signed-off-by: Prem Mallappa --- tests/libqos/pci-generic.c | 197 + tests/libqos/pci-generic.h | 58 + 2 files changed, 255

[Qemu-devel] [PATCH v2 5/9] hw: arm: Add SMMUv3 to virt platform, create DTS accordingly

2016-08-22 Thread Prem Mallappa
Default virt platform now creates SMMU device. Default config to build SMMU device along is in previous patches. Signed-off-by: Prem Mallappa --- hw/arm/virt.c | 62 +++ include/hw/arm/smmu.h | 33

[Qemu-devel] [PATCH v2 8/9] [optional] tests: SMMUv3 unit tests

2016-08-22 Thread Prem Mallappa
- initializes SMMU device - initializes Test device - allocates page tables 1:1 mapping va == pa - allocates STE/CD accordingly for S1, S2, S1+S2 - initiates DMA via PCI test device - verifies transfered data Signed-off-by: Prem Mallappa ---

[Qemu-devel] [PATCH v2 0/9] SMMUv3 Emulation support

2016-08-22 Thread Prem Mallappa
v1 -> v2: - Adopted review comments from Eric Auger - Make SMMU_DPRINTF to internally call qemu_log (since translation requests are too many, we need control on the type of log we want) - SMMUTransCfg modified to

[Qemu-devel] [PATCH v2 6/9] [optional] hw: misc: added testdev for smmu

2016-08-22 Thread Prem Mallappa
A simple PCI device which does DMA from 'src' to 'dst' given src_addr, dst_addr and size, and is used by unit test. uses pci_dma_read and pci_dma_write in a crude way but serves the purpose. Signed-off-by: Prem Mallappa --- hw/misc/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v2 4/9] hw: arm: Added SMMUv3 files for build

2016-08-22 Thread Prem Mallappa
Signed-off-by: Prem Mallappa --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/aarch64-softmmu.mak b/default-configs/aarch64-softmmu.mak index 2449483..83a2932

[Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
Must include "qemu-version.h" for the QEMU_PKGVERSION definition. Signed-off-by: Ed Maste --- bsd-user/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index b4a0a00..0fb08e4 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@

Re: [Qemu-devel] [PATCH V6 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-22 Thread Richard Henderson
On 08/22/2016 06:04 AM, Peter Lieven wrote: +static size_t adjust_stack_size(size_t sz) +{ +#ifdef _SC_THREAD_STACK_MIN +/* avoid stacks smaller than _SC_THREAD_STACK_MIN */ +sz = MAX(MAX(sysconf(_SC_THREAD_STACK_MIN), 0), sz); +#endif You need to place the sysconf result into a local

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-22 Thread Peter Maydell
On 22 August 2016 at 16:02, Michael S. Tsirkin wrote: > On Mon, Aug 22, 2016 at 10:23:19AM +0100, Peter Maydell wrote: >> On 19 August 2016 at 18:30, Greg Kurz wrote: >> > Maybe the check can even be made in the top layer then. I should spend >> > more time to

[Qemu-devel] [Bug 1605045] Re: input-linux enter key stuck and/or broken

2016-08-22 Thread nivekuil
I can confirm this bug on Linux 4.7.1 with QEMU 2.6.0. A workaround is to change to a different TTY and then back to the X display, which fixes the enter key for the rest of the QEMU session. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-22 Thread Michael S. Tsirkin
On Mon, Aug 22, 2016 at 10:23:19AM +0100, Peter Maydell wrote: > On 19 August 2016 at 18:30, Greg Kurz wrote: > > Maybe the check can even be made in the top layer then. I should spend > > more time to see which is best. > > > > My main concern now is that, unlike I said on IRC,

Re: [Qemu-devel] [RFC PATCH 3/4] tcg/tests: Move mips test to arch specific folder

2016-08-22 Thread Pranith Kumar
On Mon, Aug 22, 2016 at 5:34 AM, Alex Bennée wrote: > > Pranith Kumar writes: > > You have transposed the tcg/tests in your subject for this particular commit. I messed up the subject. I will fix this and resend. -- Pranith

Re: [Qemu-devel] QEMU make: ROM is too large

2016-08-22 Thread Peter Maydell
On 19 August 2016 at 18:58, Thomas Hanson wrote: > Just pulled top of tree, make clean and make as follows: > CFLAGS="-g3 -O0" ./configure --enable-vhost-net --enable-virtfs > make -j8 > > Build fails with [...] > CCqga/channel-posix.o > Signing

Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field

2016-08-22 Thread Denis V. Lunev
On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote: The VirtQueue->inuse field is not always updated correctly. These patches fix it. Originally this series was called "virtio-balloon: fix stats vq migration" but Ladi Prosek posted a nicer fix called "balloon: Fix failure of updating guest memory

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-22 Thread Michael S. Tsirkin
On Fri, Aug 19, 2016 at 06:03:29PM +0100, Peter Maydell wrote: > On 19 August 2016 at 17:37, Greg Kurz wrote: > > Peter Maydell wrote: > >> If (1) is true and "only single path component" is a protocol > >> requirement then probably we should be

Re: [Qemu-devel] [PATCH 3/7] qemu-img: add more conv= conversions to dd

2016-08-22 Thread Reda Sallahi
On Mon, Aug 22, 2016 at 09:35:26AM -0400, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2016 at 09:55:13AM +0200, Reda Sallahi wrote: > > @@ -4325,20 +4388,43 @@ static int img_dd(int argc, char **argv) > > > > for (out_pos = out.offset * obsz; in_pos < size; block_count++) { > > int

Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] qemu-img: add status option to dd

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:15AM +0200, Reda Sallahi wrote: > struct DdInfo { > unsigned int flags; > int64_t count; > unsigned int conv; > +unsigned status; For consistency please use "unsigned int" like you used for the flags and conv fields above. > in.buf =

Re: [Qemu-devel] [PATCH 5/7] qemu-img: add status option to dd

2016-08-22 Thread Reda Sallahi
I should have checked the previous test suites because : Mon, Aug 22, 2016 at 09:55:15AM +0200, Reda Sallahi wrote: > > if (in.offset > INT64_MAX / ibsz || size < in.offset * ibsz) { > -/* We give a warning if the skip option is bigger than the input > - * size and create

Re: [Qemu-devel] [PATCH 7/7] qemu-img: add a test suite for the count option

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:17AM +0200, Reda Sallahi wrote: > The count option for dd lacked a test suite so this adds one with four test > cases. > > Signed-off-by: Reda Sallahi > --- > tests/qemu-iotests/168 | 75 > ++ >

Re: [Qemu-devel] [PATCH 6/7] qemu-img: clean up dd documentation

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:16AM +0200, Reda Sallahi wrote: > The dd section on qemu-img --help was a bit hard to read since it was not > well aligned. This patch fixes the display problem and also makes the > sentences on the .texi file more consistent with one another (uppercase and >

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] qemu-img: delete not used variable and an unecessary check

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:14AM +0200, Reda Sallahi wrote: > block_count is not used in img_dd() and the C_SKIP check is unecessary so > this patch removes both of them. > > Signed-off-by: Reda Sallahi > --- > qemu-img.c | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [Qemu-devel] [PATCH 3/7] qemu-img: add more conv= conversions to dd

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:13AM +0200, Reda Sallahi wrote: > static int img_dd_conv(const char *arg, > struct DdIo *in, struct DdIo *out, > struct DdInfo *dd) > { > -if (!strcmp(arg, "notrunc")) { > -dd->conv |= C_NOTRUNC; > -

Re: [Qemu-devel] [PATCH 2/7] qemu-img: add iflag and oflag options to dd

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:12AM +0200, Reda Sallahi wrote: > +static int img_dd_oflag(const char *arg, > +struct DdIo *in, struct DdIo *out, > +struct DdInfo *dd) > +{ > +const char *tok; > +char *str, *tmp; > +int ret = 0; > +

Re: [Qemu-devel] [PATCH 1/7] qemu-img: add seek option to dd

2016-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 09:55:11AM +0200, Reda Sallahi wrote: > This patch adds the seek option which allows qemu-img dd to skip a number of > blocks on the output before copying the input. > > A test case was added to test the seek option. > > Signed-off-by: Reda Sallahi >

[Qemu-devel] [PATCH V6 5/6] oslib-posix: add a configure switch to debug stack usage

2016-08-22 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- configure | 19 +++ util/oslib-posix.c | 37 + 2

[Qemu-devel] [PATCH V6 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-08-22 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c

[Qemu-devel] [PATCH V6 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-08-22 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c

[Qemu-devel] [PATCH V6 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-22 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. The memory for the guard page is deductated from stack memory

[Qemu-devel] [PATCH V6 6/6] coroutine: reduce stack size to 64kB

2016-08-22 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added

[Qemu-devel] [PATCH V6 2/6] coroutine: add a macro for the coroutine stack size

2016-08-22 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4

[Qemu-devel] [PATCH V6 0/6] coroutine: mmap stack memory and stack size

2016-08-22 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

Re: [Qemu-devel] [Qemu-block] [PATCH v4] qemu-img: change opening method for the output in dd

2016-08-22 Thread Stefan Hajnoczi
On Sat, Aug 20, 2016 at 05:52:49PM +0200, Reda Sallahi wrote: > +blk2 = blk_new_open(image_opts ? NULL : out.filename, > +NULL, qoptions, BDRV_O_RDWR, NULL); As mentioned in my reply to the previous version, please reuse img_open() to avoid duplicating code. You can

Re: [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd

2016-08-22 Thread Stefan Hajnoczi
On Fri, Aug 19, 2016 at 09:06:08PM +0200, Reda Sallahi wrote: > On Tue, Aug 16, 2016 at 12:09:06PM +0100, Stefan Hajnoczi wrote: > > On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote: > > > +blk2 = blk_new_open(image_opts ? NULL : out.filename, > > > +NULL,

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-22 Thread P J P
Hello Peter, all +-- On Mon, 22 Aug 2016, Peter Maydell wrote --+ | Opinions welcome on whether we need to hold 2.7 for this bug. I'm going through the VirtFS details to figure out a best fix for this issue. Nonetheless, IMO we need not hold 2.7 release for this bug. Thank you. -- Prasad J

Re: [Qemu-devel] [PULL 0/2] Net patches

2016-08-22 Thread Peter Maydell
On 22 August 2016 at 09:09, Jason Wang wrote: > The following changes since commit 5f9f818ea88a013b2464563be354dd2f0f316407: > > test-logging: don't hard-code paths in /tmp (2016-08-19 12:44:11 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] travis builds: failing because of duff data in ccache cache?

2016-08-22 Thread Peter Maydell
On 22 August 2016 at 10:33, Alex Bennée wrote: > FWIW anyone who is a member of the QEMU project on Github should have > the permissions to tweak the Travis caches for the project. I thought about trying that, but Travis wanted a whole pile of Github permissions I wasn't

Re: [Qemu-devel] [RFC PATCH 3/4] tcg/tests: Move mips test to arch specific folder

2016-08-22 Thread Alex Bennée
Pranith Kumar writes: You have transposed the tcg/tests in your subject for this particular commit. > Signed-off-by: Pranith Kumar > --- > tests/tcg/{ => mips}/hello-mips.c | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename

Re: [Qemu-devel] travis builds: failing because of duff data in ccache cache?

2016-08-22 Thread Alex Bennée
Peter Maydell writes: > Hi; since commit 4b887ae travis builds have been persistently > failing on one particular config with the error: > exec.o: could not read symbols: File truncated > trying to link the mipsn32-linux-user binary. > > My theory is that the problem

Re: [Qemu-devel] [PATCH RFC v4 0/4] docker: Support building qemu-user powered docker test images

2016-08-22 Thread no-reply
--- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-22 Thread Peter Maydell
On 19 August 2016 at 18:30, Greg Kurz wrote: > Maybe the check can even be made in the top layer then. I should spend > more time to see which is best. > > My main concern now is that, unlike I said on IRC, I'm afraid I won't be > able to work on this before next Wednesday... :-\

Re: [Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests

2016-08-22 Thread Alex Bennée
Peter Maydell writes: > On 21 August 2016 at 04:46, Pranith Kumar wrote: >> The tests currently fail, so I didn't think it would be appropriate to >> hook them up. If the rearrangement is acceptable and once I fix the >> tests, I will hook up

Re: [Qemu-devel] [PATCH v3 03/10] aspeed-soc: provide a framework to add new SoCs

2016-08-22 Thread Cédric Le Goater
Hello Peter, On 08/12/2016 11:21 AM, Peter Maydell wrote: > On 12 August 2016 at 09:33, Cédric Le Goater wrote: >> On 08/11/2016 12:14 PM, Peter Maydell wrote: >>> board_id 0 means "I am an EBSA110", which this isn't, >>> and your silicon rev values are completely out of range.

Re: [Qemu-devel] [PATCH v7] docs: add cpu-hotplug.txt

2016-08-22 Thread Alexandre DERUMIER
Hello, I'm looking to implement cpu hotplug, and I have a question about cpu flags currently I have something like -cpu qemu64,+lahf_lm,+sep,+kvm_pv_unhalt,+kvm_pv_eoi,enforce -smp 4,sockets=2,cores=2,maxcpus=4 Does I need to define flags like: -smp 2,sockets=2,cores=2,maxcpus=4 -device

Re: [Qemu-devel] [Qemu-block] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-22 Thread Kevin Wolf
Am 21.08.2016 um 23:16 hat Hervé Poussineau geschrieben: > Le 18/08/2016 à 16:24, Kevin Wolf a écrit : > >Hm, which of the paths in cmd_read_cd() does this hit? Is it the one > >that directly calls ide_atapi_cmd_ok() without doing anything? > > This is in ide_atapi_cmd, at line: > if

[Qemu-devel] [PULL 1/2] slirp: fix segv when init failed

2016-08-22 Thread Jason Wang
From: Marc-André Lureau Since commit f6c2e66ae8c8a, slirp uses an exit notifier to call slirp_smb_cleanup. However, if init() failed, the notifier isn't added, and removing it will fail: ==18447== Invalid write of size 8 ==18447==at 0x7EF2B5: notifier_remove

[Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-22 Thread Jason Wang
From: Cao jin Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang

[Qemu-devel] [PULL 0/2] Net patches

2016-08-22 Thread Jason Wang
The following changes since commit 5f9f818ea88a013b2464563be354dd2f0f316407: test-logging: don't hard-code paths in /tmp (2016-08-19 12:44:11 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to

[Qemu-devel] [PATCH 4/7] qemu-img: delete not used variable and an unecessary check

2016-08-22 Thread Reda Sallahi
block_count is not used in img_dd() and the C_SKIP check is unecessary so this patch removes both of them. Signed-off-by: Reda Sallahi --- qemu-img.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index ae3828e..cf78dfe

[Qemu-devel] [PATCH 7/7] qemu-img: add a test suite for the count option

2016-08-22 Thread Reda Sallahi
The count option for dd lacked a test suite so this adds one with four test cases. Signed-off-by: Reda Sallahi --- tests/qemu-iotests/168 | 75 ++ tests/qemu-iotests/168.out | 51 +++

[Qemu-devel] [PATCH 5/7] qemu-img: add status option to dd

2016-08-22 Thread Reda Sallahi
This patch adds the status option to the subcommand dd. With this dd will display by default the number of blocks read/written, the transfer rate, etc. like dd(1). The noxfer and none levels will allow the user to surpress the final transfer statistics and everything except error messages

[Qemu-devel] [PATCH 1/7] qemu-img: add seek option to dd

2016-08-22 Thread Reda Sallahi
This patch adds the seek option which allows qemu-img dd to skip a number of blocks on the output before copying the input. A test case was added to test the seek option. Signed-off-by: Reda Sallahi --- qemu-img-cmds.hx | 4 +-- qemu-img.c | 45

[Qemu-devel] [PATCH 6/7] qemu-img: clean up dd documentation

2016-08-22 Thread Reda Sallahi
The dd section on qemu-img --help was a bit hard to read since it was not well aligned. This patch fixes the display problem and also makes the sentences on the .texi file more consistent with one another (uppercase and conjugasion). Signed-off-by: Reda Sallahi ---

[Qemu-devel] [PATCH 3/7] qemu-img: add more conv= conversions to dd

2016-08-22 Thread Reda Sallahi
This patch adds excl, nocreat, noerror, sync, fsync, fdatasync and sparse to the conversion list. They have the same meaning as the ones on GNU dd(1). Two tests were added to test the conv= option. Signed-off-by: Reda Sallahi --- qemu-img-cmds.hx | 4 +-

[Qemu-devel] [PATCH 2/7] qemu-img: add iflag and oflag options to dd

2016-08-22 Thread Reda Sallahi
This adds the iflag and oflag options which defines the list of flags used for reading and writing respectively. The list is comma-separated. The iflag option supports direct, dsync, sync, count_bytes and skip_bytes and oflag supports direct, dsync, sync and seek_bytes. They are similar to their

[Qemu-devel] [PATCH 0/7] qemu-img dd

2016-08-22 Thread Reda Sallahi
Hi everyone, This patchset adds additional options to qemu-img dd. Depends on: [PATCH v4] qemu-img: change opening method for the output in dd Reda Sallahi (7): qemu-img: add seek option to dd qemu-img: add iflag and oflag options to dd qemu-img: add more conv= conversions to dd