Re: [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add

On Mon, Sep 12, 2016 at 11:17:37AM +1000, David Gibson wrote: [...] > > I think now I understand the point... Then I'd prefer to use David's > > suggestion. A single notify_changed() looks cleaner. To be more > > explicit, I would prefer to rename it to notifier_flag_changed(), > > since

[Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect

tlbie (H_REMOVE, H_PROTECT and H_BULK_REMOVE for pseries) should have a global effect. Introduces TLB_NEED_GLOBAL_FLUSH flag. During delayed flush, once taking care of local flush, check broadcast flush(ptesync, tlbsync, etc) is needed. Depending on the bitmask state of the tlb_need_flush, tlb is

[Qemu-devel] [PATCH v3 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

Signed-off-by: Nikunj A Dadhania --- target-ppc/cpu.h | 1 + target-ppc/helper_regs.h | 4 ++-- target-ppc/mmu-hash64.c | 4 ++-- target-ppc/mmu_helper.c | 6 +++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target-ppc/cpu.h

[Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

The flag will be used to indicate whether broadcast tlb flush is needed or not. Moreover, BookS does both ptesync and tlbsync, so make that a nop for the server and tlbsync would generate a check flush for BookE Signed-off-by: Nikunj A Dadhania ---

[Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush should have global effect

PowerPC targets should do tlb invalidation on other cpus on instructions that expect a global effect. * ptesync for BookS * tlbsync primarily for BookE (for BookS make it a nop, as it always come along with ptesync) * tlbivax for other ppc tragets * H_REMOVE, H_BULK_REMOVE and H_PROTECT hcalls

Re: [Qemu-devel] [PATCH v4 0/4] Introduce error_report_{fatal|abort}

On Fri, Sep 09, 2016 at 07:05:04PM +0200, Markus Armbruster wrote: [...] > You effectively propose to revise this coding rule from error.h: > > * Please don't error_setg(_fatal, ...), use error_report() and > * exit(), because that's more obvious. > * Likewise, don't error_setg(_abort, ...),

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

On Mon, Sep 12, 2016 at 11:26:04AM +1000, David Gibson wrote: > On Thu, Sep 08, 2016 at 05:07:32PM +0800, Peter Xu wrote: > > On Wed, Sep 07, 2016 at 04:41:54PM +1000, David Gibson wrote: > > > On Wed, Sep 07, 2016 at 02:34:19PM +0800, Peter Xu wrote: > > > > On Wed, Sep 07, 2016 at 03:44:19PM

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

On 09/10/2016 03:55 AM, Kirti Wankhede wrote: > On 9/10/2016 12:12 AM, Alex Williamson wrote: >> On Fri, 9 Sep 2016 23:18:45 +0530 >> Kirti Wankhede wrote: >> >>> On 9/8/2016 1:39 PM, Jike Song wrote: On 08/25/2016 11:53 AM, Kirti Wankhede wrote: >>> >

Re: [Qemu-devel] [RFC PATCH v2 0/6] translate: [tcg] Generic translation framework

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 147342618684.13303.1583142856242164602.st...@fimbulvetr.bsc.es Subject: [Qemu-devel] [RFC PATCH v2 0/6] translate: [tcg] Generic translation framework === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v2 3/3] target-ppc: tlbie should have global effect

Benjamin Herrenschmidt writes: > On Fri, 2016-09-09 at 18:44 +0530, Nikunj A Dadhania wrote: >> +static inline void tlb_clear_flag(CPUState *cs) >> +{ >> +    PowerPCCPU *cpu = POWERPC_CPU(cs); >> +    CPUPPCState *env = >env; >> + >> +    env->tlb_need_flush = 0; >> +}

Re: [Qemu-devel] [PATCH v6 3/3] tests: add RTAS command in the protocol

On Thu, Sep 08, 2016 at 09:00:07PM +0200, Laurent Vivier wrote: > Add a first test to validate the protocol: > > - rtas/get-time-of-day compares the time > from the guest with the time from the host. > > Signed-off-by: Laurent Vivier > --- > v6: > - rebase > > v5: > - use

Re: [Qemu-devel] [PATCH v6 2/3] libqos: define SPAPR libqos functions

On Thu, Sep 08, 2016 at 09:00:06PM +0200, Laurent Vivier wrote: > Define spapr_alloc_init()/spapr_alloc_init_flags()/spapr_alloc_uninit() > > to allocate and use SPAPR guest memory > > Define qtest_spapr_vboot()/qtest_spapr_boot()/qtest_spapr_shutdown() > > to start SPAPR guest with

Re: [Qemu-devel] [RFC PATCH v2 0/6] translate: [tcg] Generic translation framework

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 147342618684.13303.1583142856242164602.st...@fimbulvetr.bsc.es Subject: [Qemu-devel] [RFC PATCH v2

Re: [Qemu-devel] [PATCH v2 3/3] target-ppc: tlbie should have global effect

On Sat, Sep 10, 2016 at 09:03:56AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-09-09 at 18:44 +0530, Nikunj A Dadhania wrote: > > +static inline void tlb_clear_flag(CPUState *cs) > > +{ > > +    PowerPCCPU *cpu = POWERPC_CPU(cs); > > +    CPUPPCState *env = >env; > > + > > +   

[Qemu-devel] Pulse audio error on Ubuntu Mate

When I try to run QEMU on Ubuntu Mate, I see these error messages: pulseaudio: set_sink_input_volume() failed pulseaudio: Reason: Invalid argument pulseaudio: set_sink_input_mute() failed pulseaudio: Reason: Invalid argument Trying to play an audio file in the guest fails. The guest freezes for

Re: [Qemu-devel] [RFC PATCH v0] spapr: Introduce sPAPRCPUCoreClass

On Thu, Sep 08, 2016 at 09:56:31AM +0530, Bharata B Rao wrote: > On Thu, Sep 08, 2016 at 11:51:32AM +1000, David Gibson wrote: > > On Fri, Sep 02, 2016 at 03:06:38PM +0530, Bharata B Rao wrote: > > > Each spapr cpu core type defines an instance_init routine which just > > > populates the CPU class

Re: [Qemu-devel] [PATCH v4] ppc: Fix signal delivery in ppc-user and ppc64-user

On Wed, Aug 03, 2016 at 10:38:51PM +1000, Benjamin Herrenschmidt wrote: > There were a number of bugs in the implementation: > > - The structure alignment was wrong for 64-bit. > > - Also 64-bit only does RT signals. > > - On 64-bit, we need to put a pointer to the (aligned) vector registers

[Qemu-devel] [PATCH] virtio-scsi: Report BAD_TARGET if device is not available

Ejected devices cannot complete the IO, so we can fail it early. This is also a fix to a crash for dataplane in that case, since the assert(blk_get_aio_context(d->conf.blk) == s->ctx); below won't hold because blk_get_aio_context will return qemu_aio_ctx for ejected devices, where as s->ctx

Re: [Qemu-devel] [PATCH v6 0/5] POWER9 TCG enablement - part3

On Tue, Sep 06, 2016 at 10:34:05AM +0530, Rajalakshmi Srinivasaraghavan wrote: > This series contains 14 new instructions for POWER9 described in ISA3.0. > > Patches: > 01: Adds vector insert instructions. > vinsertb - Vector Insert Byte > vinserth - Vector Insert

Re: [Qemu-devel] [PATCH] ppc: restrict the use of the rfi instruction

On Thu, Sep 08, 2016 at 09:32:42AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Power ISA 2.x has deleted the rfi instruction and rfid shoud be used > instead on cpus following this instruction set or later. > > This will raise an invalid exception

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

On Fri, Sep 09, 2016 at 02:31:55PM +0200, Laurent Vivier wrote: > > > On 09/09/2016 14:25, Greg Kurz wrote: > > On Thu, 8 Sep 2016 09:50:31 +0200 > > Laurent Vivier wrote: > > > >> On 08/09/2016 04:04, David Gibson wrote: > >>> On Tue, Sep 06, 2016 at 03:17:56PM +0200,

Re: [Qemu-devel] [PATCH RFC 3/4] target-ppc: use atomic_cmpxchg for ld/st reservation

On Wed, Sep 07, 2016 at 08:13:31AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Wed, Sep 07, 2016 at 10:17:42AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > [ Unknown signature status ] > >> > On

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing ppc-related files

On Mon, Sep 05, 2016 at 10:03:36PM +0200, Thomas Huth wrote: > There are some powerpc related files in the QEMU source tree > which are currently not covered by the MAINTAINERS file and > thus not properly classified by the get_maintainer.pl script. > So let's add them to the proper sections. > >

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

On Thu, Sep 08, 2016 at 05:07:32PM +0800, Peter Xu wrote: > On Wed, Sep 07, 2016 at 04:41:54PM +1000, David Gibson wrote: > > On Wed, Sep 07, 2016 at 02:34:19PM +0800, Peter Xu wrote: > > > On Wed, Sep 07, 2016 at 03:44:19PM +1000, David Gibson wrote: > > > > > For "CHANGE", it sounds like a

Re: [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add

On Thu, Sep 08, 2016 at 06:22:40PM +0800, Peter Xu wrote: > On Wed, Sep 07, 2016 at 12:54:23PM +0200, Paolo Bonzini wrote: > > > > > > On 07/09/2016 08:05, David Gibson wrote: > > > On Wed, Sep 07, 2016 at 01:32:23PM +0800, Peter Xu wrote: > > >> Considering that we may have multiple IOMMU

Re: [Qemu-devel] proposal: drop linux-user unicore32 support from QEMU

> On 14 June 2016 at 14:43, Xuetao Guan wrote: >>> On 20 May 2016 at 13:48, Riku Voipio wrote: On torstaina 12. toukokuuta 2016 17.34.42 EEST, Peter Maydell wrote: > We should either fix our unicore32 support to use the real > syscall

Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware

Matthew Garrett wrote on 08/17/2016 03:48:52 PM: > From: Matthew Garrett > To: qemu-devel@nongnu.org > Cc: dgilb...@redhat.com, berra...@redhat.com, Stefan Berger/Watson/ > IBM@IBMUS, Matthew Garrett > Date: 08/17/2016 03:49 PM > Subject:

Re: [Qemu-devel] [V17 0/4] AMD IOMMU

On 2016-09-09 20:20, Michael S. Tsirkin wrote: > On Wed, Aug 31, 2016 at 07:17:39PM +0300, David Kiarie wrote: >> Hi all, >> >> This patchset adds basic AMD IOMMU emulation support to Qemu. > > Jan, Igor, any comments on this one? > I suspect it's time we merged this and followed-up upstream. >

Re: [Qemu-devel] proposal: drop linux-user unicore32 support from QEMU

On 14 June 2016 at 14:43, Xuetao Guan wrote: >> On 20 May 2016 at 13:48, Riku Voipio wrote: >>> On torstaina 12. toukokuuta 2016 17.34.42 EEST, Peter Maydell wrote: We should either fix our unicore32 support to use the real syscall numbers, or

[Qemu-devel] [PATCH v7 5/8] irq: Add a new irq device that allows the ORing of lines

Signed-off-by: Alistair Francis --- As the migration framework is not included in user mode this needs to be a new file. V7: - Use the standard QEMU init/realise functions V6: - Make the OR IRQ device a TYPE_DEVICE - Add vmstate hw/core/Makefile.objs | 1 +

[Qemu-devel] [PATCH v7 4/8] STM32F2xx: Add the SPI device

Add the STM32F2xx SPI device. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V4: - Add VMState - Small fixes V2: - Address Peter C's comments default-configs/arm-softmmu.mak | 1 + hw/ssi/Makefile.objs| 1 +

[Qemu-devel] [PATCH v7 6/8] STM32F205: Connect the ADC devices

Connect the ADC devices to the STM32F205 SoC. Signed-off-by: Alistair Francis --- V7: - Create the new ADC device V5: - Use the new irq ORing function V4: - Connect all the interrupt lines correctly V2: - Fix up the device/devices commit message

[Qemu-devel] [PATCH v7 8/8] MAINTAINERS: Add Alistair to the maintainers list

Add Alistair Francis as the maintainer for the Netduino 2 and SMM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS

[Qemu-devel] [PATCH v7 1/8] STM32F205: Remove the individual device variables

Cleanup the individual DeviceState and SysBusDevice variables to re-use the same variable for each device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/stm32f205_soc.c | 35 +--

[Qemu-devel] [PATCH v7 2/8] STM32F2xx: Display PWM duty cycle from timer

If correctly configured allow the STM32F2xx timer to print out the PWM duty cycle information. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V3: - Use OR instead of + for masking - Improve clarity of print statement

[Qemu-devel] [PATCH v7 7/8] STM32F205: Connect the SPI devices

Connect the SPI devices to the STM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V2: - Fix up the device/devices commit message hw/arm/stm32f205_soc.c | 22 ++

[Qemu-devel] [PATCH v7 3/8] STM32F2xx: Add the ADC device

Add the STM32F2xx ADC device. This device randomly generates values on each read. This also includes creating a hw/adc directory. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V4: - Remove the rand() function - Add VMState -

[Qemu-devel] [PATCH v7 0/8] Update the Netduino 2 Machine

This patchset continues with the Netduino 2 and STM32F205 SoC work. This patch series makes a small change to the STM32F2xx SoC to tidy up the code. Next a feature is added to the STM32F2xx timer to display the PWM duty cycle, when debugging is enabled. Then the STM32F2xx SPI and ADC devices

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section

> get_maintainer.pl now properly recognizes that the file in > include/hw/unicore32/ belongs to UniCore32. > > Signed-off-by: Thomas Huth Looks ok to me. Acked-by: Guan Xuetao > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Qemu-devel] [PATCH] kvm-all: drop kvm_setup_guest_memory

kvm_setup_guest_memory only does "madvise to QEMU_MADV_DONTFORK" and is only called by ram_block_add, which actually is duplicate code. Bonus: add simple comment for kvm_has_sync_mmu to make life easier. Suggested-by: Paolo Bonzini Signed-off-by: Cao jin

Re: [Qemu-devel] [PATCH v2 1/2] virtio: Add function to check whether backend supports VIRTIO_1

On 09/09/2016 08:47 PM, Michael S. Tsirkin wrote: On Fri, Sep 09, 2016 at 08:00:31PM +0300, Marcel Apfelbaum wrote: On 09/09/2016 04:10 PM, Maxime Coquelin wrote: This patch adds virtio_test_backend_virtio_1() function to check whether backend supports VIRTIO_F_VERSION_1 before the negociation

[Qemu-devel] [Bug 905095] Re: qemu-img can't convert vmdk file: Operation not permitted

I retried with ubuntu 16.04, qemu-img version 2.5.0 (Debian 1:2.5+dfsg- 5ubuntu10.4). While the original file (freetz vmdk) is not available (they use .ova now), I got another .vmdk file from http://www.osboxes.org/debian/#debian-8-5-vmware qemu-img convert Debian\ 8.5\ \(64bit\).vmdk -O raw

[Qemu-devel] [Bug 905095] Re: qemu-img can't convert vmdk file: Operation not permitted

** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/905095 Title: qemu-img can't convert vmdk file: Operation not permitted Status in

Re: [Qemu-devel] [PATCH v6 5/8] irq: Add a new irq device that allows the ORing of lines

On Tue, Aug 9, 2016 at 9:42 AM, Peter Maydell wrote: > On 3 August 2016 at 04:10, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> As the migration framework is not included in user mode this needs to be