[Qemu-devel] [PULL 4/4] ide: Fix memory leak in ide_register_restart_cb()

From: Ashijeet Acharya Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote: On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: ... Before enabling anything by default, we should first optimize the 1 slot case. Indeed, micro-benchmark using testpmd in txonly[0] shows ~17% perf regression for 64 bytes

Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

Gerd Hoffmann writes: > Hi, > >> > Hmm, I think the xen core needs better QOM support ... >> > >> > struct XenDevice should have a DeviceState element, so it can be used as >> > device object directly instead of attaching a device object like >> > this ... >> >> Hmm,

[Qemu-devel] [PATCH 1/2] RAMBlocks: Store page size

From: "Dr. David Alan Gilbert" Store the page size in each RAMBlock, we need it later. Signed-off-by: Dr. David Alan Gilbert --- exec.c| 17 +++-- include/exec/cpu-common.h | 1 + include/exec/ram_addr.h | 1 + 3

[Qemu-devel] [PATCH 2/2] migration/postcopy: Explicitly disallow huge pages

From: "Dr. David Alan Gilbert" At the moment postcopy will fail as soon as qemu tries to register userfault on the RAMBlock pages that are backed by hugepages. However, the kernel is going to get userfault support for hugepage at some point, and we've not got the rest of the

[Qemu-devel] [PATCH 0/2] Migration/postcopy disallow huge pages

From: "Dr. David Alan Gilbert" We've not got support for huge pages in postcopy yet, and it will error when it tries to use the userfaultfd on the hugepage, however the kernel is going to gain support for userfault so make sure we fail with a nice error on the new kernel

Re: [Qemu-devel] [PATCH 0/2] net: pcnet: fix infinite loop and source format

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1475175454-3116-1-git-send-email-ppan...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] net: pcnet: fix infinite loop and source format === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH 2/2] net: pcnet: fix source formatting and indentation

From: Prasad J Pandit Fix indentations and source format at few places. Add braces around few 'if' and 'while' statements. Signed-off-by: Prasad J Pandit --- hw/net/pcnet.c | 122 + 1 file

[Qemu-devel] [PATCH 1/2] net: pcnet: check rx/tx descriptor ring length

From: Prasad J Pandit The AMD PC-Net II emulator has set of control and status(CSR) registers. Of these, CSR76 and CSR78 hold receive and transmit descriptor ring length respectively. This ring length could range from 1 to 65535. Setting ring length to zero leads to an

[Qemu-devel] [PATCH 0/2] net: pcnet: fix infinite loop and source format

From: Prasad J Pandit Hello, An infinite loop issue in 'pcnet_rdra_addr' routine, caused by zero receive/transmit descriptor ring length value, was reported by Mr Li Qiang. One of the patches below fixes this issue. And the other one corrects indentation and source

Re: [Qemu-devel] [PULL 0/2] target-mips queue

h 'remotes/bonzini/tags/for-upstream' into > staging (2016-09-28 23:02:56 +0100) > > are available in the git repository at: > > git://github.com/yongbok/upstream-qemu.git tags/mips-20160929 > > for you to fetch changes up to 73bfa8c0e0295df92d5fe61e0149db7b36cdc0c4: &

Re: [Qemu-devel] [PULL 0/8] Tracing patches

On 28 September 2016 at 14:31, Stefan Hajnoczi wrote: > The following changes since commit 25930ed60aad49f1fdd7de05272317c86ce1275b: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into > staging (2016-09-27 23:10:12 +0100) > > are available in

Re: [Qemu-devel] [Qemu-block] block/ssh:Allow blockdev-add for ssh

On Thu, Sep 29, 2016 at 8:32 PM, Kevin Wolf wrote: > Am 29.09.2016 um 16:07 hat Ashijeet Acharya geschrieben: >> Other than that I also asked if I have accidentally missed any other >> important field regarding the structure 'BlockdevOptionsSsh' I >> described in the previous

Re: [Qemu-devel] [PATCH] target-i386: Report known CPUID[EAX=0xD, ECX=0]:EAX bits as migratable

(CCing Richard, sorry I forgot to CC you) Ping? Any objection to this fix? On Wed, Sep 28, 2016 at 01:33:15PM -0300, Eduardo Habkost wrote: > A regression was introduced by commit 96193c22a "target-i386: > Move xsave component mask to features array": all > CPUID[EAX=0xD,ECX=0]:EAX bits were

Re: [Qemu-devel] [Qemu-ppc] How to add my implementation of the fmadds instruction to QEMU

Programmingkid writes: > On Sep 29, 2016, at 12:17 AM, David Gibson wrote: > >> On Tue, Sep 27, 2016 at 09:58:02AM -0700, Peter Maydell wrote: >>> On 27 September 2016 at 09:51, G 3 wrote: The problem with your reasoning is you assume

Re: [Qemu-devel] [PULL 00/18] Block layer patches

On 09/29/2016 02:17 PM, Paolo Bonzini wrote: On 29/09/2016 19:02, John Snow wrote: On 09/29/2016 06:25 AM, Kevin Wolf wrote: John, can you have a look at the IDE code and check whether we can get rid of the deep recursion? It seems that the test issues a large request that is then split

Re: [Qemu-devel] [PULL 00/18] Block layer patches

On 09/29/2016 01:18 PM, Peter Maydell wrote: On 29 September 2016 at 03:25, Kevin Wolf wrote: The series contains a patch that reduces the coroutine stack size, so I guess it's not quite infinite, but pretty deep recursion anyway. I will drop that final patch that reduces

Re: [Qemu-devel] [PULL 00/18] Block layer patches

On 29/09/2016 19:02, John Snow wrote: > > > On 09/29/2016 06:25 AM, Kevin Wolf wrote: >> John, can you have a look at the IDE code and check whether we can get >> rid of the deep recursion? It seems that the test issues a large request >> that is then split into many small requests. But it

Re: [Qemu-devel] [PATCH 1/5] blockjob: fix dead pointer in txn list

On 08/08/2016 02:09 PM, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Though it is not intended to be reached through normal circumstances, > if we do not gracefully deconstruct the transaction QLIST, we may wind > up with stale pointers in the list. > >

Re: [Qemu-devel] qdevification of xen_disk

Hi Kevin, I agree with you, and if you would be so kind to send the patches, even untested, they would be much appreciated. Anthony or I will make sure to test them appropriately and fix them, if they turn out to be incomplete or partially broken. Would that be OK? Cheers, Stefano P.S. FYI Xen

Re: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

On 29/09/2016 19:10, Daniel P. Berrange wrote: >> > >> > -acb->task = malloc(sizeof(struct scsi_task)); >> > +acb->task = g_malloc(sizeof(struct scsi_task)); >> > if (acb->task == NULL) { >> > error_report("iSCSI: Failed to allocate task for scsi command. >> > %s", >> >

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: > > > On 09/28/2016 04:28 AM, Yuanhan Liu wrote: > > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > > On Mon, Sep 26, 2016 at 10:24:55PM

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

That makes perfect sense. I will try and follow this method now onwards. Thanks! On Wed, Sep 28, 2016 at 7:18 PM, Jeff Cody wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source

Re: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

On 29.09.2016 18:57, Annapoornima Koppad wrote: > Signed-off-by: Annapoornima Koppad > --- > block/iscsi.c| 2 +- > bsd-user/elfload.c | 12 ++-- > disas/libvixl/vixl/a64/disasm-a64.cc | 2 +- > disas/m68k.c

Re: [Qemu-devel] [PATCH] This patch looks for uses of malloc and convert them to g_malloc

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1475167353-12851-1-git-send-email-annakop...@gmail.com Subject: [Qemu-devel] [PATCH] This patch looks for uses of malloc and convert them to g_malloc === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1475168226-13194-1-git-send-email-annakop...@gmail.com Subject: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1475168226-13194-1-git-send-email-annakop...@gmail.com Subject: [Qemu-devel] [PATCH] Convert uses of

[Qemu-devel] [PATCH 2/3] qtest: evaluate endianness of the target in qtest_init()

This allows to store it and not have to rescan the list each time we need it. Signed-off-by: Laurent Vivier Reviewed-by: Greg Kurz --- tests/libqos/virtio-pci.c | 2 +- tests/libqtest.c | 96 +--

Re: [Qemu-devel] [PULL 00/18] Block layer patches

On 29 September 2016 at 03:25, Kevin Wolf wrote: > The series contains a patch that reduces the coroutine stack size, so I > guess it's not quite infinite, but pretty deep recursion anyway. I will > drop that final patch that reduces the stack size and hope that the rest > will

[Qemu-devel] [PATCH 3/3] tests: enable virtio tests on SPAPR

but disable MSI-X tests on SPAPR as we can't check the result (the memory region used on PC is not readable on SPAPR). Signed-off-by: Laurent Vivier --- tests/Makefile.include| 3 ++- tests/libqos/virtio-pci.c | 22 -- tests/virtio-9p-test.c| 11

[Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

Signed-off-by: Laurent Vivier --- tests/virtio-9p-test.c | 53 tests/virtio-blk-test.c | 154 +-- tests/virtio-net-test.c | 40 +--- tests/virtio-scsi-test.c | 70 ++--- 4 files

[Qemu-devel] [PATCH 0/3] tests: enable virtio tests on SPAPR

This series enables virtio tests on SPAPR by starting machines using qtest_pc_boot() or qtest_spapr_boot() to use the good libqos PCI framework (pc or spapr). It adds also some byte-swapping in virtio-pci.c as PCI is always little-endian and the endianness of the virtio device depends on the

Re: [Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

On Thu, Sep 29, 2016 at 10:27:06PM +0530, Annapoornima Koppad wrote: > Signed-off-by: Annapoornima Koppad > --- > block/iscsi.c| 2 +- > bsd-user/elfload.c | 12 ++-- > disas/libvixl/vixl/a64/disasm-a64.cc | 2 +- >

Re: [Qemu-devel] [PATCH] Update .gitignore

David Gibson writes: > This adds one generated header, and a couple of testcase binaries to the > .gitignore files, which haven't yet been included. > > Signed-off-by: David Gibson Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [PATCH] This patch looks for uses of malloc and convert them to g_malloc

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1475167353-12851-1-git-send-email-annakop...@gmail.com Subject: [Qemu-devel] [PATCH] This patch

Re: [Qemu-devel] [PATCH] This patch looks for uses of malloc and convert them to g_malloc

Am 29.09.2016 um 18:42 schrieb Annapoornima Koppad: > --- > block/iscsi.c| 2 +- > bsd-user/elfload.c | 12 ++-- > disas/libvixl/vixl/a64/disasm-a64.cc | 2 +- > disas/m68k.c | 2 +- > disas/sparc.c

Re: [Qemu-devel] [PULL 00/18] Block layer patches

On 09/29/2016 06:25 AM, Kevin Wolf wrote: John, can you have a look at the IDE code and check whether we can get rid of the deep recursion? It seems that the test issues a large request that is then split into many small requests. But it should be possible to do this iteratively rather than

[Qemu-devel] [PATCH] Convert uses of malloc to g_malloc

Signed-off-by: Annapoornima Koppad --- block/iscsi.c| 2 +- bsd-user/elfload.c | 12 ++-- disas/libvixl/vixl/a64/disasm-a64.cc | 2 +- disas/m68k.c | 2 +- disas/sparc.c| 4

Re: [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM

2016-09-29 18:06+0200, Igor Mammedov: > On Thu, 29 Sep 2016 15:18:36 +0200 > Paolo Bonzini wrote: >> On 29/09/2016 13:23, Radim Krčmář wrote: >> > Cluster x2APIC cannot work without KVM's x2apic API when the maximal >> > APIC ID is greater than 8 and only KVM's LAPIC can

Re: [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM

On 29/09/2016 18:56, Radim Krčmář wrote: > 2016-09-29 18:06+0200, Igor Mammedov: >> On Thu, 29 Sep 2016 15:18:36 +0200 >> Paolo Bonzini wrote: >>> On 29/09/2016 13:23, Radim Krčmář wrote: Cluster x2APIC cannot work without KVM's x2apic API when the maximal APIC ID

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v4 0/6] migration: ensure hotplug and migration work together

ping On 06/27/2016 09:59 AM, Jianjun Duan wrote: > Hi all, >The previous patches seem to get buried deep somewhere. I am resending them > without RFC tag. Comments are welcome. > > v4: - Introduce a way to set customized instance_id in SaveStateEntry. Use it > to set instance_id for

Re: [Qemu-devel] [Qemu-ppc] How to add my implementation of the fmadds instruction to QEMU

On Sep 29, 2016, at 11:41 AM, Peter Maydell wrote: > On 28 September 2016 at 21:17, David Gibson > wrote: >> I think there is a way you could get both speed and accuracy, but it's >> a huge project: >> >> You'd need to add full float awareness to TCG - so floating

Re: [Qemu-devel] [PATCH v2 7/7] intel-iommu: keep buggy EIM enabled in 2.7 machine type

2016-09-29 15:19+0200, Paolo Bonzini: > On 29/09/2016 13:23, Radim Krčmář wrote: >> QEMU 2.7 allowed EIM even in configurations that were forbidden in the >> last patch because they were not working, like old KVM or userspace >> APIC. In order to keep backward compatibility, we again allow guests

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some ARM related files to the corresponding sections

On 29.09.2016 18:08, Peter Maydell wrote: > On 23 September 2016 at 05:18, Thomas Huth wrote: >> The file hw/misc/arm_integrator_debug.c seems to belong to Integrator >> CP, and hw/cpu/realview_mpcore.c and hw/misc/arm_sysctl.c seem to >> belong to Real View. > > arm_sysctl is

Re: [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types

On 09/29/2016 10:45 AM, Daniel P. Berrange wrote: > There is alot of repeated code in the auth type setup method, s/alot/a lot/ > particularly around checking TLS credential types. Refactor > it to reduce duplication and instead of having one method > do both plain and websockets at once, call

[Qemu-devel] [PATCH] This patch looks for uses of malloc and convert them to g_malloc

--- block/iscsi.c| 2 +- bsd-user/elfload.c | 12 ++-- disas/libvixl/vixl/a64/disasm-a64.cc | 2 +- disas/m68k.c | 2 +- disas/sparc.c| 4 ++-- hw/audio/fmopl.c | 10

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

On Thu, 29 Sep 2016 15:11:27 +0200 Markus Armbruster wrote: > Alex Williamson writes: > > > On Tue, 13 Sep 2016 08:16:20 +0200 > > Markus Armbruster wrote: > > > >> Cc: Alex for device assignment expertise. > >> > >> Cao jin

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some ARM related files to the corresponding sections

On 23 September 2016 at 05:18, Thomas Huth wrote: > The file hw/misc/arm_integrator_debug.c seems to belong to Integrator > CP, and hw/cpu/realview_mpcore.c and hw/misc/arm_sysctl.c seem to > belong to Real View. arm_sysctl is also used in the Versatile PB and Vexpress boards;

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. No objections to having QMP tests, but the ones fixed by PATCH 2 are QMP input visitor bugs, which sneaked through the existing test-qmp-input-visitor.c. Makes me suspect

Re: [Qemu-devel] [PATCH] Update .gitignore

29.09.2016 02:58, David Gibson wrote: This adds one generated header, and a couple of testcase binaries to the .gitignore files, which haven't yet been included. Other people already spotted these omissions in .gitignore. Thank you! /mjt

[Qemu-devel] qdevification of xen_disk

Hi Stefano and all, while working on some part of the QEMU block layer infrastructure that requires going from a BlockBackend to the qdev DeviceState, I noticed that xen_disk is still not qdevified after all the years. It's the last device, and has been for a while, that is blocking the necessary

Re: [Qemu-devel] [PATCH v3 0/4] io: Various fixes around QIOChannel Features

On Thu, Sep 29, 2016 at 08:52:34AM -0700, Felipe Franciosi wrote: > This series include four patches around the utilisation of QIOChannel > features. The first patch actually fixes a bug, while the next two > makes the test/set of features consistent by using helper functions. > The last patch

Re: [Qemu-devel] [PATCHv2] m68k: change default system clock for m5208evb

Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

05.03.2016 16:47, Wei Yang wrote: According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. This patch takes this change and also move them all in header file. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] usb: ehci: fix memory leak in ehci_process_itd

Applied to -trivial with comment fix, thanks! /mjt

Re: [Qemu-devel] [PATCH 1/1] qga: minimal support for fstrim for Windows guests

On 09/29/2016 03:21 PM, Marc-André Lureau wrote: > Hi > > On Thu, Sep 29, 2016 at 2:30 PM Denis V. Lunev wrote: > >> Unfortunately, there is no public Windows API to start trimming the >> filesystem. The only viable way here is to call 'defrag.exe /L' for >> each volume. >> >>

[Qemu-devel] [Bug 1628971] [NEW] -netdev user: guestfwd doesn't work

Public bug reported: Hello! QEMU emulator version 2.6.1 (Debian 1:2.6.1+dfsg-0ubuntu4), Copyright (c) 2003-2008 Fabrice Bellard The IP address 192.168.1.46 is assigned to eth0. qemu-system-x86_64 \ -no-hpet \ -nodefconfig \ -machine accel=kvm \ -cpu host \ -smp 2 \

Re: [Qemu-devel] [PATCH] qapi: make the json schema files more regular.

22.09.2016 07:00, David Anderson wrote: This makes it easier to parse the schema file for tool generation: each paragraph is either a non-docstring comment, or a docstring immediately followed by a Python dict describing an API item. Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH v3 0/4] io: Various fixes around QIOChannel Features

This series include four patches around the utilisation of QIOChannel features. The first patch actually fixes a bug, while the next two makes the test/set of features consistent by using helper functions. The last patch adds a test to verify that the bug has been fixed. Changes from v2: - Add a

Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path

Applied to trivial, with additional commit comment suggested by Marcus, thanks! /mjt

Re: [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM

On Thu, 29 Sep 2016 15:18:36 +0200 Paolo Bonzini wrote: > On 29/09/2016 13:23, Radim Krčmář wrote: > > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > > APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we > > forbid other APICs and

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add some more pattern to recognize all win32 related files

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] exec: remove unused compacted argument

28.09.2016 15:37, Marc-André Lureau wrote: Since commit b35ba30f8f when it was introduced, phys_page_compact() takes an unused compacted argument. ubsan complains about it when launching qemu-x86_64 without arguments: qemu/exec.c:310:5: runtime error: variable length array bound evaluates to

Re: [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM

On Thu, 29 Sep 2016 13:23:28 +0200 Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we > forbid other APICs and also the old KVM case with less than 9, to >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add header files to CRIS section

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 1/1] qemu-nbd: add the option to use pre-created server socket

On 09/29/2016 02:02 PM, Denis V. Lunev wrote: > From: Denis Plotnikov > > Originally NBD server socket was created by qemu-nbd code. This leads to > the race when the management layer starts qemu-nbd server and allows a > client to connect to the server. In this case

[Qemu-devel] [PATCH v3 3/4] io: Introduce a qio_channel_set_feature() helper

Testing QIOChannel feature support can be done with a helper called qio_channel_has_feature(). Setting feature support, however, was done manually with a logical OR. This patch introduces a new helper called qio_channel_set_feature() and makes use of it where applicable. Signed-off-by: Felipe

Re: [Qemu-devel] [PATCH v2 1/7] apic: add global apic_get_class()

2016-09-29 11:53-0300, Eduardo Habkost: > On Thu, Sep 29, 2016 at 01:23:23PM +0200, Radim Krčmář wrote: >> Every configuration has only up to one APIC class and we'll be extending >> the class with a function that can be called without an instanced >> object, so a direct access to the class is

[Qemu-devel] [PATCH 6/9] ui: remove bogus call to graphic_hw_update() in vnc_listen_io

Just before accepting a new client connection the vnc_listen_io method calls graphic_hw_update(). This is bogus because there is a call to this method already in vnc_state_init() and the client doesn't need up2date graphics console before reaching that. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v3 2/4] io: Use qio_channel_has_feature() where applicable

Parts of the code have been testing QIOChannel features directly with a logical AND. This patch makes it all consistent by using the qio_channel_has_feature() function to test if a feature is present. Signed-off-by: Felipe Franciosi --- io/channel-socket.c |3 ++-

[Qemu-devel] [PATCH v3 1/4] io: Fix double shift usages on QIOChannel features

When QIOChannels were introduced in 666a3af9, the feature bits were already defined shifted. However, when using them, the code was shifting them again. The incorrect use was consistent until 74b6ce43, where QIO_CHANNEL_FEATURE_LISTEN was defined shifted but tested unshifted. This patch changes

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more rocker related files

Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 4/9] ui: rename misleading 'VncDisplay' variables

Normally code declares 'VncDisplay *vd' or 'VncState *vs' but there are a bunch of places which misleadingly declare 'VncDisplay *vs'. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 274 --- 1 file changed, 138

[Qemu-devel] [PATCH v3 4/4] io: Add a QIOChannelSocket cleanup test

This patch adds a test to verify that the QIOChannel framework will not unlink a filesystem unix socket unless the _FEATURE_LISTEN bit is set. Due to a bug introduced in 74b6ce43, the framework would unlink the entry if the _FEATURE_SHUTDOWN bit was set, regardless of the presence of

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more files to the virtio section

Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 8/9] ui: move some initialization out of vnc_init_state

Most of the fields in VncState are initialized in the vnc_connect() method, but some are done in vnc_init_state() instead. The purpose of having vnc_init_state() is to delay starting of the VNC wire protocol until after the websockets handshake has completed. As such the vnc_init_state() method

[Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types

There is alot of repeated code in the auth type setup method, particularly around checking TLS credential types. Refactor it to reduce duplication and instead of having one method do both plain and websockets at once, call it separately for each. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] maint: Add module_block.h to .gitignore

23.09.2016 12:36, Fam Zheng wrote: On Fri, 09/23 17:16, Lin Ma wrote: Commit 0c0c1fd9 generated module_block.h automatically, Add it to .gitignore to avoid checking in it by 'git add .'. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] MAINTAINERS: Add some SPARC machine related files

Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 7/9] ui: remove bogus call to reset_keys() in vnc_init_state

The vnc_init_state method calls reset_keys() to reset the modifier key state. This was originally added in commit 53762ddb277c690e486d0e17b10591774248c8cf Author: malc Date: Mon Dec 1 20:57:52 2008 + Reset the key modifiers upon client

[Qemu-devel] [PATCH 2/9] ui: remove 'enabled' and 'ws_enabled' fields from VncState

The 'ws_enabled' field is never used outside of the vnc_display_open method, so can be a local variable. The 'enabled' field is easily replaced by a check for whether 'lsock' is non-NULL. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 23 ++- ui/vnc.h

[Qemu-devel] [PATCH 9/9] ui: rename vnc_init_state to vnc_start_protocol

Rename the vnc_init_state method to reflect what its actual purpose is, to discourage future devs from using it for more general state initialization. Signed-off-by: Daniel P. Berrange --- ui/vnc-ws.c | 2 +- ui/vnc.c| 4 ++-- ui/vnc.h| 2 +- 3 files changed, 4

[Qemu-devel] [PATCH 3/9] ui: remove 'ws_tls' field from VncState

The 'ws_tls' field in VncState is only ever representing the result of 'tlscreds != NULL' and is thus pointless. Replace use of 'ws_tls' with a direct check against 'tlscreds' Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 11 +-- ui/vnc.h | 1 - 2 files changed,

[Qemu-devel] [PATCH 0/9] Misc VNC server code cleanups

This patches series should have no functional change, it is just a series of cleanups I've accumulated for the VNC server. It aims to remove misleading cruft and simplify some parts to make future work I'm experimenting with easier. Daniel P. Berrange (9): ui: remove misleading comment from

[Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_state

The last line in vnc_init_state() says /* vs might be free()ed here */ This was added in commit 198a0039c5fca224a77e9761e2350dd9cc102ad0 Author: Gerd Hoffmann Date: Tue Jun 16 14:19:48 2009 +0200 vnc: rework VncState release workflow. because the

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more files to the HMP section

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/hw/audio/ to audio section

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some ARM related files to the corresponding sections

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v4 2/3] qapi: fix crash when a parameter is missing

Marc-André Lureau writes: > Calling: > > { "execute": "qom-set", > "arguments": { "path": "/machine", "property": "rtc-time" } } > > Will crash with: > > qapi/qapi-visit-core.c:277: visit_type_any: Assertion `!err != !*obj' > failed This is actually a recent

Re: [Qemu-devel] [Qemu-ppc] How to add my implementation of the fmadds instruction to QEMU

On 28 September 2016 at 21:17, David Gibson wrote: > I think there is a way you could get both speed and accuracy, but it's > a huge project: > > You'd need to add full float awareness to TCG - so floating point TCG > values and floating point operations as tcp

Re: [Qemu-devel] [PATCH 0/3] fdc: Use separate qdev device for drives

Am 05.09.2016 um 17:43 hat Kevin Wolf geschrieben: > We have been complaining for a long time about how the floppy controller and > floppy drives are combined in a single qdev device and how this makes the > device awkward to work with because it behaves different from all other block > devices. >

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On 09/28/2016 04:28 AM, Yuanhan Liu wrote: On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen

Re: [Qemu-devel] [PATCH v3 5/8] hcd-xhci: change behaviour of msix switch

On Do, 2016-09-29 at 16:32 +0200, Markus Armbruster wrote: > > Resolve the TODO, msix=auto means msix on; if user specify msix=on, > > then device creation fail on msix_init failure. Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] kvm test warnings

On 29.09.2016 17:16, Laurent Vivier wrote: > > > On 09/09/2016 23:31, Michael S. Tsirkin wrote: >> On Fri, Sep 09, 2016 at 09:24:45PM +0200, Thomas Huth wrote: >>> On 09.09.2016 21:03, Michael S. Tsirkin wrote: I am running make test on a box without kvm, and I am seeing these

Re: [Qemu-devel] [Qemu-ppc] How to add my implementation of the fmadds instruction to QEMU

On Sep 29, 2016, at 12:17 AM, David Gibson wrote: > On Tue, Sep 27, 2016 at 09:58:02AM -0700, Peter Maydell wrote: >> On 27 September 2016 at 09:51, G 3 wrote: >>> The problem with your reasoning is you assume this instruction has to be >>> 100% correctly implemented.

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

Xiao Long Jiang writes: > Hi, > > I have tested this patch on arch s390 system. It works fine. :-) May I credit your help by adding Tested-by: Xiao Long Jiang to the commit message?

Re: [Qemu-devel] [PATCH v3 2/8] hcd-xhci: check & correct param before using it

Hi, > I can take this through my tree if Gerd provides at least his Acked-by, > preferably Reviewed-by. Gerd, if you'd rather take it through yours, > let me know. I'll take this series into my tree then, wait for the > patch to make its way through yours, and rebase. I'm fine with you

Re: [Qemu-devel] kvm test warnings

On 09/09/2016 23:31, Michael S. Tsirkin wrote: > On Fri, Sep 09, 2016 at 09:24:45PM +0200, Thomas Huth wrote: >> On 09.09.2016 21:03, Michael S. Tsirkin wrote: >>> I am running make test on a box without kvm, and I am seeing these warnings: >>> >>> GTESTER check-qtest-ppc64 >>> "kvm" accelerator

Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

Hi, > > Hmm, I think the xen core needs better QOM support ... > > > > struct XenDevice should have a DeviceState element, so it can be used as > > device object directly instead of attaching a device object like > > this ... > > Hmm, interesting idea. The device object could even be added in

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

On 9/29/2016 7:47 AM, Jike Song wrote: > +Guangrong > > On 08/25/2016 11:53 AM, Kirti Wankhede wrote: ... >> +static long vfio_iommu_type1_pin_pages(void *iommu_data, >> + unsigned long *user_pfn, >> + long npage, int prot,

<    1   2   3   4   >