[Qemu-devel] [PATCH v5 14/17] vfio/pci: Conversion to realize

2016-10-06 Thread Eric Auger
This patch converts VFIO PCI to realize function. Also original initfn errors now are propagated using QEMU error objects. All errors are formatted with the same pattern: "vfio: %s: the error description" Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster --- v2 -> v3: - use errp directl

Re: [Qemu-devel] [PULL 00/15] Migration

2016-10-06 Thread Juan Quintela
Peter Maydell wrote: > On 5 October 2016 at 14:44, Juan Quintela wrote: >> From: Juan Quintela >> >> The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' >> into staging (2016-10-04 14:25:08 +0100) >>

[Qemu-devel] [PATCH 5/5] target-tricore: Add updfl instruction

2016-10-06 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/fpu_helper.c | 12 target-tricore/helper.h | 1 + target-tricore/translate.c | 3 +++ 3 files changed, 16 insertions(+) diff --git a/target-tricore/fpu_helper.c b/target-tricore/fpu_helper.c index 32055f3..9720cb8 100644 --

[Qemu-devel] [PATCH v5 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device

2016-10-06 Thread Eric Auger
In case the vfio_init_intp fails we currently do not return an error value. This patch fixes the bug. The returned value is not explicit but in practice the error object is the one used to report the error to the end-user and the actual returned error value is not used. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container

2016-10-06 Thread Eric Auger
The error is currently simply reported in vfio_get_group. Don't bother too much with the prefix which will be handled at upper level, later on. Also return an error value in case container->error is not 0 and the container is teared down. On vfio_spapr_remove_window failure, we also report an err

[Qemu-devel] [PATCH v5 11/17] vfio/platform: Pass an error object to vfio_populate_device

2016-10-06 Thread Eric Auger
Propagate the vfio_populate_device errors up to vfio_base_device_init. The error object also is passed to vfio_init_intp. At the moment we only report the error. Subsequent patches will propagate the error up to the realize function. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster ---

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 18:04, Programmingkid wrote: > 'Save State...' would call something equivalent to the monitor command savevm. > It would display a dialog box asking to give a name to this save. The default > name would probably be "save state mm-dd- - n". The m,d,y stand > for month, day, and y

[Qemu-devel] [PATCH v5 10/17] vfio: Pass an error object to vfio_get_device

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. In vfio platform vfio_base_device_init we currently just report the error. Subsequent patches will propagate the error up to the realize function. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster --- --- hw/vfio/common

[Qemu-devel] [PATCH v5 07/17] vfio/pci: Pass an error object to vfio_pci_igd_opregion_init

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. In vfio_probe_igd_bar4_quirk, simply report the error. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster --- v4 -> v5: - fix indentation at vfio_pci_igd_opregion_init declaration --- hw/vfio/pci-quirks.c | 10 +

Re: [Qemu-devel] QEMU - Security Research Questions

2016-10-06 Thread Eric Blake
On 10/06/2016 03:27 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 06/10/2016 02:10, Joey Connelly wrote: >>> Hey QEMU dev group, >>> I'm a graduate student at Boise State University working on my thesis >>> involving Virtualization/Cloud Computing Security and I wanted to ask a few

[Qemu-devel] [PATCH v5 16/17] vfio/pci: Remove vfio_populate_device returned value

2016-10-06 Thread Eric Auger
The returned value (either -errno or -1) is not used anymore by the caller, vfio_realize, since the error now is stored in the error object. So let's remove it. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster --- --- hw/vfio/pci.c | 23 ++- 1 file changed, 10 inser

[Qemu-devel] [PATCH v5 06/17] vfio/pci: Pass an error object to vfio_add_capabilities

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The error is cascaded downto vfio_add_std_cap and then vfio_msi(x)_setup, vfio_setup_pcie_cap. vfio_add_ext_cap does not return anything else than 0 so let's transform it into a void function. Also use pci_add_capability2 which ta

[Qemu-devel] [PATCH v5 05/17] vfio/pci: Pass an error object to vfio_intx_enable

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The error object is propagated down to vfio_intx_enable_kvm(). The three other callers, vfio_intx_enable_kvm(), vfio_msi_disable_common() and vfio_pci_post_reset() do not propagate the error and simply call error_reportf_err() wit

[Qemu-devel] [PATCH v5 03/17] vfio/pci: Pass an error object to vfio_populate_device

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The returned value will be removed later on. The case where error recovery cannot be enabled is not converted into an error object but directly reported through error_report, as before. Populating an error instead would cause the f

[Qemu-devel] [PATCH v5 09/17] vfio: Pass an error object to vfio_get_group

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. For the time being let's just simply report the error in vfio platform's vfio_base_device_init(). A subsequent patch will duly propagate the error up to vfio_platform_realize. Signed-off-by: Eric Auger Reviewed-by: Markus Armbrus

[Qemu-devel] [PATCH v5 04/17] vfio/pci: Pass an error object to vfio_msix_early_setup

2016-10-06 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The returned value will be removed later on. We now format an error in case of reading failure for - the MSIX flags - the MSIX table, - the MSIX PBA. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster --- v4 -> v5: - test

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 11:49 AM, Paolo Bonzini wrote: > > > On 06/10/2016 17:48, Programmingkid wrote: >> >> On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: >> >>> >>> >>> On 06/10/2016 16:42, Programmingkid wrote: On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > On 6

[Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize

2016-10-06 Thread Eric Auger
This series converts VFIO-PCI to realize. It also aims at improving the error reporting in case of QMP hot-plug. Before the series, a device_add failure would have reported: {"error": {"class": "GenericError", "desc": "Device initialization failed"}}. Now the actual error cause is reported. A si

[Qemu-devel] [PATCH v5 01/17] vfio/pci: Use local error object in vfio_initfn

2016-10-06 Thread Eric Auger
To prepare for migration to realize, let's use a local error object in vfio_initfn. Also let's use the same error prefix for all error messages. On top of the 1-1 conversion, we start using a common error prefix for all error messages. We also introduce a similar warning prefix which will be used

[Qemu-devel] [PATCH v5 02/17] vfio/pci: Pass an error object to vfio_populate_vga

2016-10-06 Thread Eric Auger
Pass an error object to prepare for the same operation in vfio_populate_device. Eventually this contributes to the migration to VFIO-PCI realize. We now report an error on vfio_get_region_info failure. vfio_probe_igd_bar4_quirk is not involved in the migration to realize and simply calls error_re

Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-06 Thread Radim Krčmář
2016-10-06 11:51-0300, Eduardo Habkost: > On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: >> Signed-off-by: Radim Krčmář >> --- >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c >> @@ -2015,6 +2015,7 @@ static Property vtd_properties[] = { >> DEFINE_PROP_UINT32("vers

Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener

2016-10-06 Thread Peter Maydell
On 30 September 2016 at 08:17, Paolo Bonzini wrote: > The only address space where the GIC devices are added is > address_space_memory. There is no need to use a global > MemoryListener. > > This removes the only user of global MemoryListeners. > > Signed-off-by: Paolo Bonzini > --- > target-ar

Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-06 Thread Radim Krčmář
2016-10-06 18:33+0300, Michael S. Tsirkin: > On Thu, Oct 06, 2016 at 11:51:42AM -0300, Eduardo Habkost wrote: >> On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: >> > QEMU 2.7 allowed EIM even in configurations that were forbidden in the >> > last patch because they were not working, l

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: > Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: > > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > > > On Thu, Oct 06, 2016 at 05:10:42PM +0200,

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Laurent Vivier
On 06/10/2016 17:41, Peter Maydell wrote: > On 6 October 2016 at 16:36, Paolo Bonzini wrote: >> >> >> On 06/10/2016 16:11, Greg Kurz wrote: >>> FWIW, Cedric had another proposal which apparently went unnoticed: >>> >>> >>> >>> The idea is to add an optional endianness argument to the read*/writ

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > > > Am 30.09.2016 um 16:45 hat Daniel P. Berr

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 17:48, Programmingkid wrote: > > On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: > >> >> >> On 06/10/2016 16:42, Programmingkid wrote: >>> >>> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: >>> On 6 October 2016 at 15:22, Programmingkid wrote: > Would you acce

Re: [Qemu-devel] vfio/pci: IGD assignment

2016-10-06 Thread Alex Williamson
On Thu, 6 Oct 2016 08:06:24 +0200 nicolas prochazka wrote: > Hello, > Since I upgrade my linux kernel from linux 4.8rc1 to 4.8.0, I can observe > regression with VFIO/PCI IGD Assignment . > All works very well with linux 4.8rc1 ( broadwell/skylake cpu + win10 guest > / Linux Guest ) . > Since lin

[Qemu-devel] [PATCH v2 2/2] linux-user: added support for pwritev() system call.

2016-10-06 Thread Dejan Jovicevic
v1 -> v2: - Using safe_pwritev() instead of calling preadv() directly. This system call performs the same task as the writev system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implemen

Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-10-06 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > > > On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote: > > > > Cao jin writes: > > > >> On 09/29/2016 10:42 PM, Markus Armbruster wrote: > >>> Cao jin writes: > >>> > >> > static int vmxnet3_post_load(void *opaque, int version_id) > >>

[Qemu-devel] [PATCH v2 0/2] linux-user: preadv and pwritev emulation support

2016-10-06 Thread Dejan Jovicevic
v1 -> v2: - Being that both of these system calls are interruptible, in QEMU they should be implemented via the safe_syscall() wrapper. This version implements the preadv() and pwritev() using safe_preadv() and safe_pwritev() for the respective syscalls, as suggeste

[Qemu-devel] [PATCH v2 1/2] linux-user: added support for preadv() system call.

2016-10-06 Thread Dejan Jovicevic
v1 -> v2: - Using safe_preadv() instead of calling preadv() directly. This system call performs the same task as the readv system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implementa

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: > > > On 06/10/2016 16:42, Programmingkid wrote: >> >> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: >> >>> On 6 October 2016 at 15:22, Programmingkid >>> wrote: Would you accept a patch that added "Save State" and "Restore Sta

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 16:42, Programmingkid wrote: > > On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > >> On 6 October 2016 at 15:22, Programmingkid wrote: >>> Would you accept a patch that added "Save State" and >>> "Restore State" menu items to the cocoa interface? They would >>> allow the user

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Cédric Le Goater
On 10/06/2016 05:36 PM, Paolo Bonzini wrote: > > > On 06/10/2016 16:11, Greg Kurz wrote: >> FWIW, Cedric had another proposal which apparently went unnoticed: >> >> >> >> The idea is to add an optional endianness argument to the read*/write* >> commands in the qtest protocol: >> - libqtest then

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 17:44, Cédric Le Goater wrote: > On 10/06/2016 05:36 PM, Paolo Bonzini wrote: >> >> >> On 06/10/2016 16:11, Greg Kurz wrote: >>> FWIW, Cedric had another proposal which apparently went unnoticed: >>> >>> >>> >>> The idea is to add an optional endianness argument to the read*/write*

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > > > Some of the historical command line opts

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > > Some of the historical command line opts that had their > > > keys in in a completely flat namespace are now

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 16:36, Paolo Bonzini wrote: > > > On 06/10/2016 16:11, Greg Kurz wrote: >> FWIW, Cedric had another proposal which apparently went unnoticed: >> >> >> >> The idea is to add an optional endianness argument to the read*/write* >> commands in the qtest protocol: >> - libqtest th

Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-06 Thread Michael S. Tsirkin
On Thu, Oct 06, 2016 at 11:51:42AM -0300, Eduardo Habkost wrote: > On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: > > QEMU 2.7 allowed EIM even in configurations that were forbidden in the > > last patch because they were not working, like old KVM or userspace > > APIC. In order to

Re: [Qemu-devel] [PATCH v2 00/12] virtio migration: simplify vmstate helper

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 14:55, Halil Pasic wrote: > > Let us simplify a couple of things and get rid of some code duplication. > > NOTE: This series is exploring the suggestions of Paolo (I did my best > to do everything as requested). I still think that we are better of with > a macro that with spelling

[Qemu-devel] [PATCH 10/10] qemu-doc: merge qemu-tech and qemu-doc

2016-10-06 Thread Paolo Bonzini
Merge what is left of qemu-tech into the main manual. Signed-off-by: Paolo Bonzini --- .gitignore | 2 -- Makefile | 13 ++--- qemu-doc.texi | 3 +++ qemu-tech.texi | 56 qemu.nsi | 3 --- ui/cocoa.m | 9 --

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 16:11, Greg Kurz wrote: > FWIW, Cedric had another proposal which apparently went unnoticed: > > > > The idea is to add an optional endianness argument to the read*/write* > commands in the qtest protocol: > - libqtest then provides explicit _le and _be APIs > - no extra byteswap

[Qemu-devel] [PATCH 05/10] qemu-tech: document lazy condition code evaluation in cpu.h

2016-10-06 Thread Paolo Bonzini
Unlike the other sections, they are pretty specific to a particular CPU. Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 25 - target-cris/cpu.h | 7 +++ target-i386/cpu.h | 7 +++ target-m68k/cpu.h | 8 target-sparc/cpu.h | 5 + 5 files

[Qemu-devel] [PATCH 07/10] qemu-tech: move TCG test documentation to tests/tcg/README

2016-10-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 35 -- tests/tcg/README | 76 2 files changed, 76 insertions(+), 35 deletions(-) create mode 100644 tests/tcg/README diff --git a/qemu-tech.texi b/qemu-tech.texi

[Qemu-devel] [PATCH 02/10] qemu-doc: replace introduction with the one from the internals manual

2016-10-06 Thread Paolo Bonzini
The user manual has an obsolete introduction, while the one in the internals manual lists QEMU's features quite nicely. Drop the obsolete content and remove generic user-level documentation from qemu-tech. Signed-off-by: Paolo Bonzini --- qemu-doc.texi | 84 +

[Qemu-devel] [PATCH 09/10] qemu-tech: rewrite some parts

2016-10-06 Thread Paolo Bonzini
Drop most the device emulation part and merge the rest into the description of the MMU. Make some bits more up-to-date. Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 124 +++-- 1 file changed, 42 insertions(+), 82 deletions(-) diff --git

[Qemu-devel] [PATCH 08/10] qemu-tech: reorganize content

2016-10-06 Thread Paolo Bonzini
Make the structure more flat, place comparison last, rename "Introduction" to "CPU emulation". Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 171 + 1 file changed, 74 insertions(+), 97 deletions(-) diff --git a/qemu-tech.texi b/qemu-te

[Qemu-devel] [PATCH 03/10] qemu-doc: drop installation and compilation notes

2016-10-06 Thread Paolo Bonzini
These are in README or obsolete, and the detailed version can be on a website instead. Signed-off-by: Paolo Bonzini --- README| 2 - qemu-doc.texi | 249 -- 2 files changed, 251 deletions(-) diff --git a/README b/README index f38

[Qemu-devel] [PATCH 06/10] qemu-tech: move user mode emulation features from qemu-tech

2016-10-06 Thread Paolo Bonzini
These are interesting for users too, since nowadays most qemu-user users are going to be somewhat technical rather than just people that want to run Wine. Some detail is lost, on the other hand some of the information I removed (e.g. basic block unchaining) was obsolete. Signed-off-by: Paolo Bonz

[Qemu-devel] [PATCH 00/10] qemu-tech cleanup

2016-10-06 Thread Paolo Bonzini
qemu-tech is limited to TCG and large parts of it are obsolete or are just fine in qemu-doc. Split it into other sources of documentation, placing what's left in an appendix of qemu-doc. Ultimately we should have a new internals manual built from docs/, and then the "Translator Internals" parts o

[Qemu-devel] [PATCH 04/10] qemu-tech: move text from qemu-tech to tcg/README

2016-10-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 12 ++-- tcg/README | 5 + 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/qemu-tech.texi b/qemu-tech.texi index 2ab7cd4..082b62c 100644 --- a/qemu-tech.texi +++ b/qemu-tech.texi @@ -287,16 +287,8 @@ are very compl

[Qemu-devel] [PATCH 01/10] qemu-tech: drop index

2016-10-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 5 - 1 file changed, 5 deletions(-) diff --git a/qemu-tech.texi b/qemu-tech.texi index 1b048cb..be1c210 100644 --- a/qemu-tech.texi +++ b/qemu-tech.texi @@ -32,7 +32,6 @@ * Introduction:: * QEMU Internals:: * Regression Tests:: -* Index::

Re: [Qemu-devel] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 06/10/2016 13:56, Dr. David Alan Gilbert wrote: > >> > Yes, it's sickening but that's what you do to honor backwards > >> > compatibility. > > Actually, that's not *that* bad an idea. > > > > Lets go with Jianjun's structure for the moment;

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > Some of the historical command line opts that had their > > keys in in a completely flat namespace are now represented > > by QAPI schemas that use a nested structs. When con

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: Update HMP and QObject

2016-10-06 Thread Markus Armbruster
Applied to my qapi-next branch.

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > Some of the historical command line opts that had their > keys in in a completely flat namespace are now represented > by QAPI schemas that use a nested structs. When converting > the QemuOpts to QObject, there is no information about > c

[Qemu-devel] [PATCH] docs: Belatedly update for move of QMP/* to docs/

2016-10-06 Thread Markus Armbruster
Missed in commit 7537fe0 and commit 9b89b6a. Signed-off-by: Markus Armbruster --- docs/qmp-commands.txt | 2 +- docs/writing-qmp-commands.txt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index e0adceb..b289391 1006

Re: [Qemu-devel] [Qemu-block] [PATCH v14 08/21] qapi: allow QObjectInputVisitor to be created with QemuOpts

2016-10-06 Thread Kevin Wolf
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > Instead of requiring all callers to go through the mutli-step > process of turning QemuOpts into a suitable QObject for visiting, > add a new constructor that encapsulates this logic. This will > allow QObjectInputVisitor to be a drop-in

Re: [Qemu-devel] [PATCH v2] qemu_opt_foreach: Fix crasher

2016-10-06 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Oct 06, 2016 at 02:10:17PM +0100, Peter Maydell wrote: >> On 6 October 2016 at 14:02, Peter Maydell wrote: >> > On 6 October 2016 at 13:39, Michal Privoznik wrote: >> >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h >> >> index 0d0465a..df58ef

Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-06 Thread Eduardo Habkost
On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: > QEMU 2.7 allowed EIM even in configurations that were forbidden in the > last patch because they were not working, like old KVM or userspace > APIC. In order to keep backward compatibility, we again allow guests to > misbehave in non-

[Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

2016-10-06 Thread Laurent Vivier
Two minor cleanups: - exit gracefully in case on unsupported target, - put machine command line in a constant to avoid to duplicate it. Signed-off-by: Laurent Vivier --- tests/usb-hcd-uhci-test.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/usb-hcd-

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > On 6 October 2016 at 15:22, Programmingkid wrote: >> Would you accept a patch that added "Save State" and >> "Restore State" menu items to the cocoa interface? They would >> allow the user to save the running state of the emulator. > > If you

[Qemu-devel] [PATCH 0/3] linux-user: preadv and pwritev emulation support

2016-10-06 Thread Dejan Jovicevic
In this series the support for preadv and pwritev system call emulation in linux-user mode is implemented. Also, the configure file is modified to check if both of these system calls are supported on the host. Dejan Jovicevic (3): linux-user: detect pwritev support on configure linux-user: ad

[Qemu-devel] [PATCH] MAINTAINERS: qemu-trivial information

2016-10-06 Thread Laurent Vivier
Information about "qemu-trivial" ML can be found in the wiki: http://wiki.qemu.org/Contribute/TrivialPatches But the first place where a developer looks is the file MAINTAINERS. This also allows the get_maintainer.pl script to display the qemu-trivial ML address when the mail subject contain

Re: [Qemu-devel] [Qemu-block] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests

2016-10-06 Thread Kevin Wolf
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > The input_visitor_test_add() method was accepting an instance > of 'TestInputVisitorData' and passing it as the 'user_data' > parameter to test functions. The main 'TestInputVisitorData' > instance that was actually used, was meanwhile be

Re: [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

2016-10-06 Thread Eduardo Habkost
On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break compilatio

Re: [Qemu-devel] [Qemu-block] [PATCH v14 03/21] qapi: add trace events for visitor

2016-10-06 Thread Kevin Wolf
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > Allow tracing of the operation of visitors > > Signed-off-by: Daniel P. Berrange Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes

2016-10-06 Thread Alberto Garcia
On Wed 05 Oct 2016 05:35:20 PM CEST, Max Reitz wrote: >>> Apart from that, I have to say I think it would be a bit more useful >>> if one would specify the area covered by the metadata caches as an >>> absolute number instead of a relative one (I guess it's generally >>> easier to know what area

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 15:22, Programmingkid wrote: > Would you accept a patch that added "Save State" and > "Restore State" menu items to the cocoa interface? They would > allow the user to save the running state of the emulator. If you can get consensus on first adding those to one of the other U

[Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
Would you accept a patch that added "Save State" and "Restore State" menu items to the cocoa interface? They would allow the user to save the running state of the emulator.

Re: [Qemu-devel] [PATCH v2] qmp: Disable query-cpu-* commands when they're unavailable

2016-10-06 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of requiring clients to actually call the query-cpu-* > commands to find out if they are implemented, remove them from > the output of "query-commands", so clients know they are not > available. > > This is implemented by extending the existing hack at > qmp_unre

Re: [Qemu-devel] [PATCH 2/3] linux-user: added support for preadv() system call.

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 14:59, Dejan Jovicevic wrote: > This system call performs the same task as the readv system call, > with the exception of having the fourth argument, offset, which > specifes the file offset at which the input operation is to be performed. > > This implementation is based on t

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Greg Kurz
On Thu, 6 Oct 2016 12:03:34 +0100 Peter Maydell wrote: > On 6 October 2016 at 04:38, David Gibson wrote: > > On Wed, Oct 05, 2016 at 05:31:07AM -0700, Peter Maydell wrote: > >> On 4 October 2016 at 16:43, David Gibson > >> wrote: > >> > On Tue, Oct 04, 2016 at 01:36:09PM +0100, Peter Mayde

[Qemu-devel] [PATCH 2/3] linux-user: added support for preadv() system call.

2016-10-06 Thread Dejan Jovicevic
This system call performs the same task as the readv system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implementation is based on the existing readv implementation. Signed-off-by: Dejan Jovi

[Qemu-devel] [PATCH 3/3] linux-user: added support for pwritev() system call.

2016-10-06 Thread Dejan Jovicevic
This system call performs the same task as the writev system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implementation is based on the existing writev implementation. Signed-off-by: Dejan Jo

[Qemu-devel] [PATCH 1/3] linux-user: detect pwritev support on configure

2016-10-06 Thread Dejan Jovicevic
Modified the configure file so that, during configuration, a check is performed to determine if the system call pwritev is supported by the host. The check for preadv support already exists. Signed-off-by: Dejan Jovicevic --- configure | 17 + 1 file changed, 17 in

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return 'missing parameter' error

2016-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2016 at 5:48 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi, > > > > 'monitor: use qmp_dispatch()' patch broke some iotests expecting a > > 'missing parameter' error. This series fixes qapi visitors to return > > this error for all types. > > > > This series

Re: [Qemu-devel] [PATCH v2] qemu_opt_foreach: Fix crasher

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 02:10:17PM +0100, Peter Maydell wrote: > On 6 October 2016 at 14:02, Peter Maydell wrote: > > On 6 October 2016 at 13:39, Michal Privoznik wrote: > >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h > >> index 0d0465a..df58ef8 100644 > >> --- a/include/sysemu/ch

Re: [Qemu-devel] [PULL 00/29] ppc-for-2.8 queue 20161006

2016-10-06 Thread Peter Maydell
git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161006 > > for you to fetch changes up to 3daa4a9f9580ffda47df93c7c53371af226bf970: > > hw/ppc/spapr: Use POWER8 by default for the pse

[Qemu-devel] [PATCH 1/3] target-arm: Implement dummy MDCCINT_EL1

2016-10-06 Thread Peter Maydell
MDCCINT_EL1 is part of the DCC debugger communication channel between the CPU and an attached external debugger. QEMU doesn't implement this, but since Linux may try to access this register we need to provide at least a dummy implementation. Signed-off-by: Peter Maydell --- target-arm/helper.c |

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return 'missing parameter' error

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > 'monitor: use qmp_dispatch()' patch broke some iotests expecting a > 'missing parameter' error. This series fixes qapi visitors to return > this error for all types. > > This series should go on top of: > https://lists.gnu.org/archive/html/qemu-devel/2016-09/ms

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> > -snip- >> > >> >> >> >> I'd be willing to take this as is with a suitable TODO comment >> >> explaining where we want to go with this file. Perha

[Qemu-devel] [PATCH] virtio-9p: add reset handler

2016-10-06 Thread Greg Kurz
Virtio devices should implement the VirtIODevice->reset() function to perform necessary cleanup actions and to bring the device to a quiescent state. In the case of the virtio-9p device, this means: - emptying the list of active PDUs (i.e. draining all in-flight I/O) - freeing all fids (i.e. close

Re: [Qemu-devel] [PATCH v4 0/3] Fix some qapi assert()

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > The following series fixes 2 triggerable asserts in qmp code: > - object-add assert() without props > - input visitor may assert() on missing parameter Touched up as discussed, and applied to my qapi-next branch. Thanks!

[Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start()

2016-10-06 Thread Alberto Garcia
When block-commit is launched without the top parameter, it uses internally a mirror block job. In that case all intermediate nodes between the active and base nodes must be blocked as well. Signed-off-by: Alberto Garcia --- block/mirror.c | 8 1 file changed, 8 insertions(+) diff --gi

[Qemu-devel] [PATCH v10 16/16] qemu-iotests: Test streaming to a Quorum child

2016-10-06 Thread Alberto Garcia
Quorum children are special in the sense that they're not directly attached to a block backend but they're not used as backing images either. However the intermediate block streaming code supports streaming to them. This is a test case for that scenario. Signed-off-by: Alberto Garcia --- tests/q

[Qemu-devel] [PATCH 3/3] hw/intc/arm_gicv3: Fix ICC register tracepoints

2016-10-06 Thread Peter Maydell
Fix some problems with the tracepoints for ICC register reads and writes: * tracepoints for ICC_BPR, ICC_APR, ICC_IGRPEN, ICC_EIOR were not printing the that indicated whether the access was to the group 0 or 1 register * the ICC_IGREPEN1_EL3 read function was not actually calling the a

[Qemu-devel] [PATCH 0/3] preliminaries for GICv3 virt support

2016-10-06 Thread Peter Maydell
This set of three straightforward patches is a preliminary for adding virtualization support to the GICv3 emulation: * add a (nop implementation of) MDCCINT_EL1, since KVM will read/write it on worldswitch * fix some bugs in the GICv3 trace events * add trace events for the generic timers

[Qemu-devel] [PATCH v10 10/16] docs: Document how to stream to an intermediate layer

2016-10-06 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- docs/live-block-ops.txt | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt index a257087..014c8c9 100644 --- a/docs/live-block-ops.txt +++ b/docs/live-block-ops.t

Re: [Qemu-devel] [PATCH] linux-user: add kcmp() syscall

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 13:56, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > linux-user/syscall.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index d21d901..a32386e 100644 > --- a/linux-user/syscall.c > +++ b/lin

[Qemu-devel] [PATCH v10 14/16] qemu-iotests: Test block-stream and block-commit in parallel

2016-10-06 Thread Alberto Garcia
As with test_stream_parallel(), we allow mixing block-stream and block-commit operations in the same backing chain as long as there's no overlap among the involved nodes. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 30 ++ tests/qemu-iotests/030.out

[Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job

2016-10-06 Thread Alberto Garcia
qmp_block_commit() checks for op blockers in the active and destination (base) images. However all nodes between top_bs and base are also involved, and they are removed from the chain afterwards. In addition to that, if top_bs is not the active layer then top_bs's overlay also needs to be checked

Re: [Qemu-devel] [PATCH v2] qemu_opt_foreach: Fix crasher

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 14:02, Peter Maydell wrote: > On 6 October 2016 at 13:39, Michal Privoznik wrote: >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h >> index 0d0465a..df58ef8 100644 >> --- a/include/sysemu/char.h >> +++ b/include/sysemu/char.h >> @@ -93,6 +93,7 @@ struct CharDrive

[Qemu-devel] [PATCH 2/3] target-arm: Add trace events for the generic timers

2016-10-06 Thread Peter Maydell
Add some useful trace events for the ARM generic timers (notably the various register writes and the resulting IRQ line state). Signed-off-by: Peter Maydell --- Makefile.objs | 1 + target-arm/helper.c | 20 2 files changed, 17 insertions(+), 4 deletions(-) diff --gi

[Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

2016-10-06 Thread Alberto Garcia
Use block_job_add_bdrv() instead of blocking all operations in backup_start() and unblocking them in backup_run(). Signed-off-by: Alberto Garcia --- block/backup.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/backup.c b/block/backup.c index 582bd0f..3a9cb7f 10064

[Qemu-devel] [PATCH v10 13/16] qemu-iotests: Test overlapping stream and commit operations

2016-10-06 Thread Alberto Garcia
These test cases check that it's not possible to perform two block-stream or block-commit operations if there are nodes involved in both. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 89 ++ tests/qemu-iotests/030.out | 4 +-- 2 files

[Qemu-devel] [PATCH v10 12/16] qemu-iotests: Test block-stream operations in parallel

2016-10-06 Thread Alberto Garcia
This test case checks that it's possible to launch several stream operations in parallel in the same snapshot chain, each one involving a different set of nodes. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 80 ++ tests/qemu-iotests/0

[Qemu-devel] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation

2016-10-06 Thread Alberto Garcia
After a successful block-commit operation all nodes between top and base are removed from the backing chain, and top's overlay needs to be updated to point to base. Because of that we should prevent other block jobs from messing with them. This patch blocks all operations in these nodes in commit_

[Qemu-devel] [PATCH v10 11/16] qemu-iotests: Test streaming to an intermediate layer

2016-10-06 Thread Alberto Garcia
This adds test_stream_intermediate(), similar to test_stream() but streams to the intermediate image instead. It also removes the usage of blkdebug, which is unnecessary for this test. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 21 - tests/qemu-iotests/03

<    1   2   3   4   >