This patch converts VFIO PCI to realize function.
Also original initfn errors now are propagated using QEMU
error objects. All errors are formatted with the same pattern:
"vfio: %s: the error description"
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
v2 -> v3:
- use errp directl
Peter Maydell wrote:
> On 5 October 2016 at 14:44, Juan Quintela wrote:
>> From: Juan Quintela
>>
>> The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d:
>>
>> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream'
>> into staging (2016-10-04 14:25:08 +0100)
>>
Signed-off-by: Bastian Koppelmann
---
target-tricore/fpu_helper.c | 12
target-tricore/helper.h | 1 +
target-tricore/translate.c | 3 +++
3 files changed, 16 insertions(+)
diff --git a/target-tricore/fpu_helper.c b/target-tricore/fpu_helper.c
index 32055f3..9720cb8 100644
--
In case the vfio_init_intp fails we currently do not return an
error value. This patch fixes the bug. The returned value is not
explicit but in practice the error object is the one used to
report the error to the end-user and the actual returned error
value is not used.
Signed-off-by: Eric Auger
The error is currently simply reported in vfio_get_group. Don't
bother too much with the prefix which will be handled at upper level,
later on.
Also return an error value in case container->error is not 0 and
the container is teared down.
On vfio_spapr_remove_window failure, we also report an err
Propagate the vfio_populate_device errors up to vfio_base_device_init.
The error object also is passed to vfio_init_intp. At the moment we
only report the error. Subsequent patches will propagate the error
up to the realize function.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
On 06/10/2016 18:04, Programmingkid wrote:
> 'Save State...' would call something equivalent to the monitor command savevm.
> It would display a dialog box asking to give a name to this save. The default
> name would probably be "save state mm-dd- - n". The m,d,y stand
> for month, day, and y
Pass an error object to prepare for migration to VFIO-PCI realize.
In vfio platform vfio_base_device_init we currently just report the
error. Subsequent patches will propagate the error up to the realize
function.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
---
hw/vfio/common
Pass an error object to prepare for migration to VFIO-PCI realize.
In vfio_probe_igd_bar4_quirk, simply report the error.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
v4 -> v5:
- fix indentation at vfio_pci_igd_opregion_init declaration
---
hw/vfio/pci-quirks.c | 10 +
On 10/06/2016 03:27 AM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 06/10/2016 02:10, Joey Connelly wrote:
>>> Hey QEMU dev group,
>>> I'm a graduate student at Boise State University working on my thesis
>>> involving Virtualization/Cloud Computing Security and I wanted to ask a few
The returned value (either -errno or -1) is not used anymore by the caller,
vfio_realize, since the error now is stored in the error object. So let's
remove it.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
---
hw/vfio/pci.c | 23 ++-
1 file changed, 10 inser
Pass an error object to prepare for migration to VFIO-PCI realize.
The error is cascaded downto vfio_add_std_cap and then vfio_msi(x)_setup,
vfio_setup_pcie_cap.
vfio_add_ext_cap does not return anything else than 0 so let's transform
it into a void function.
Also use pci_add_capability2 which ta
Pass an error object to prepare for migration to VFIO-PCI realize.
The error object is propagated down to vfio_intx_enable_kvm().
The three other callers, vfio_intx_enable_kvm(), vfio_msi_disable_common()
and vfio_pci_post_reset() do not propagate the error and simply call
error_reportf_err() wit
Pass an error object to prepare for migration to VFIO-PCI realize.
The returned value will be removed later on.
The case where error recovery cannot be enabled is not converted into
an error object but directly reported through error_report, as before.
Populating an error instead would cause the f
Pass an error object to prepare for migration to VFIO-PCI realize.
For the time being let's just simply report the error in
vfio platform's vfio_base_device_init(). A subsequent patch will
duly propagate the error up to vfio_platform_realize.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbrus
Pass an error object to prepare for migration to VFIO-PCI realize.
The returned value will be removed later on.
We now format an error in case of reading failure for
- the MSIX flags
- the MSIX table,
- the MSIX PBA.
Signed-off-by: Eric Auger
Reviewed-by: Markus Armbruster
---
v4 -> v5:
- test
On Oct 6, 2016, at 11:49 AM, Paolo Bonzini wrote:
>
>
> On 06/10/2016 17:48, Programmingkid wrote:
>>
>> On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote:
>>
>>>
>>>
>>> On 06/10/2016 16:42, Programmingkid wrote:
On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote:
> On 6
This series converts VFIO-PCI to realize. It also aims at improving
the error reporting in case of QMP hot-plug.
Before the series, a device_add failure would have reported:
{"error": {"class": "GenericError", "desc": "Device initialization
failed"}}.
Now the actual error cause is reported.
A si
To prepare for migration to realize, let's use a local error
object in vfio_initfn. Also let's use the same error prefix for all
error messages.
On top of the 1-1 conversion, we start using a common error prefix for
all error messages. We also introduce a similar warning prefix which will
be used
Pass an error object to prepare for the same operation in
vfio_populate_device. Eventually this contributes to the migration
to VFIO-PCI realize.
We now report an error on vfio_get_region_info failure.
vfio_probe_igd_bar4_quirk is not involved in the migration to realize
and simply calls error_re
2016-10-06 11:51-0300, Eduardo Habkost:
> On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote:
>> Signed-off-by: Radim Krčmář
>> ---
>> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
>> @@ -2015,6 +2015,7 @@ static Property vtd_properties[] = {
>> DEFINE_PROP_UINT32("vers
On 30 September 2016 at 08:17, Paolo Bonzini wrote:
> The only address space where the GIC devices are added is
> address_space_memory. There is no need to use a global
> MemoryListener.
>
> This removes the only user of global MemoryListeners.
>
> Signed-off-by: Paolo Bonzini
> ---
> target-ar
2016-10-06 18:33+0300, Michael S. Tsirkin:
> On Thu, Oct 06, 2016 at 11:51:42AM -0300, Eduardo Habkost wrote:
>> On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote:
>> > QEMU 2.7 allowed EIM even in configurations that were forbidden in the
>> > last patch because they were not working, l
On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote:
> Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben:
> > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote:
> > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben:
> > > > On Thu, Oct 06, 2016 at 05:10:42PM +0200,
On 06/10/2016 17:41, Peter Maydell wrote:
> On 6 October 2016 at 16:36, Paolo Bonzini wrote:
>>
>>
>> On 06/10/2016 16:11, Greg Kurz wrote:
>>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>>
>>>
>>>
>>> The idea is to add an optional endianness argument to the read*/writ
Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben:
> On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote:
> > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben:
> > > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote:
> > > > Am 30.09.2016 um 16:45 hat Daniel P. Berr
On 06/10/2016 17:48, Programmingkid wrote:
>
> On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote:
>
>>
>>
>> On 06/10/2016 16:42, Programmingkid wrote:
>>>
>>> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote:
>>>
On 6 October 2016 at 15:22, Programmingkid
wrote:
> Would you acce
On Thu, 6 Oct 2016 08:06:24 +0200
nicolas prochazka wrote:
> Hello,
> Since I upgrade my linux kernel from linux 4.8rc1 to 4.8.0, I can observe
> regression with VFIO/PCI IGD Assignment .
> All works very well with linux 4.8rc1 ( broadwell/skylake cpu + win10 guest
> / Linux Guest ) .
> Since lin
v1 -> v2:
- Using safe_pwritev() instead of calling preadv() directly.
This system call performs the same task as the writev system call,
with the exception of having the fourth argument, offset, which
specifes the file offset at which the input operation is to be performed.
This implemen
* Dmitry Fleytman (dmi...@daynix.com) wrote:
>
> > On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote:
> >
> > Cao jin writes:
> >
> >> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
> >>> Cao jin writes:
> >>>
> >>
> static int vmxnet3_post_load(void *opaque, int version_id)
> >>
v1 -> v2:
- Being that both of these system calls are interruptible, in QEMU
they should be implemented via the safe_syscall() wrapper. This
version implements the preadv() and pwritev() using safe_preadv()
and safe_pwritev() for the respective syscalls, as suggeste
v1 -> v2:
- Using safe_preadv() instead of calling preadv() directly.
This system call performs the same task as the readv system call,
with the exception of having the fourth argument, offset, which
specifes the file offset at which the input operation is to be performed.
This implementa
On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote:
>
>
> On 06/10/2016 16:42, Programmingkid wrote:
>>
>> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote:
>>
>>> On 6 October 2016 at 15:22, Programmingkid
>>> wrote:
Would you accept a patch that added "Save State" and
"Restore Sta
On 06/10/2016 16:42, Programmingkid wrote:
>
> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote:
>
>> On 6 October 2016 at 15:22, Programmingkid wrote:
>>> Would you accept a patch that added "Save State" and
>>> "Restore State" menu items to the cocoa interface? They would
>>> allow the user
On 10/06/2016 05:36 PM, Paolo Bonzini wrote:
>
>
> On 06/10/2016 16:11, Greg Kurz wrote:
>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>
>>
>>
>> The idea is to add an optional endianness argument to the read*/write*
>> commands in the qtest protocol:
>> - libqtest then
On 06/10/2016 17:44, Cédric Le Goater wrote:
> On 10/06/2016 05:36 PM, Paolo Bonzini wrote:
>>
>>
>> On 06/10/2016 16:11, Greg Kurz wrote:
>>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>>
>>>
>>>
>>> The idea is to add an optional endianness argument to the read*/write*
On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote:
> Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben:
> > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote:
> > > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> > > > Some of the historical command line opts
Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben:
> On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote:
> > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> > > Some of the historical command line opts that had their
> > > keys in in a completely flat namespace are now
On 6 October 2016 at 16:36, Paolo Bonzini wrote:
>
>
> On 06/10/2016 16:11, Greg Kurz wrote:
>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>
>>
>>
>> The idea is to add an optional endianness argument to the read*/write*
>> commands in the qtest protocol:
>> - libqtest th
On Thu, Oct 06, 2016 at 11:51:42AM -0300, Eduardo Habkost wrote:
> On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote:
> > QEMU 2.7 allowed EIM even in configurations that were forbidden in the
> > last patch because they were not working, like old KVM or userspace
> > APIC. In order to
On 06/10/2016 14:55, Halil Pasic wrote:
>
> Let us simplify a couple of things and get rid of some code duplication.
>
> NOTE: This series is exploring the suggestions of Paolo (I did my best
> to do everything as requested). I still think that we are better of with
> a macro that with spelling
Merge what is left of qemu-tech into the main manual.
Signed-off-by: Paolo Bonzini
---
.gitignore | 2 --
Makefile | 13 ++---
qemu-doc.texi | 3 +++
qemu-tech.texi | 56
qemu.nsi | 3 ---
ui/cocoa.m | 9 --
On 06/10/2016 16:11, Greg Kurz wrote:
> FWIW, Cedric had another proposal which apparently went unnoticed:
>
>
>
> The idea is to add an optional endianness argument to the read*/write*
> commands in the qtest protocol:
> - libqtest then provides explicit _le and _be APIs
> - no extra byteswap
Unlike the other sections, they are pretty specific to a particular CPU.
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 25 -
target-cris/cpu.h | 7 +++
target-i386/cpu.h | 7 +++
target-m68k/cpu.h | 8
target-sparc/cpu.h | 5 +
5 files
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 35 --
tests/tcg/README | 76
2 files changed, 76 insertions(+), 35 deletions(-)
create mode 100644 tests/tcg/README
diff --git a/qemu-tech.texi b/qemu-tech.texi
The user manual has an obsolete introduction, while the one in
the internals manual lists QEMU's features quite nicely.
Drop the obsolete content and remove generic user-level
documentation from qemu-tech.
Signed-off-by: Paolo Bonzini
---
qemu-doc.texi | 84 +
Drop most the device emulation part and merge the rest into the description
of the MMU. Make some bits more up-to-date.
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 124 +++--
1 file changed, 42 insertions(+), 82 deletions(-)
diff --git
Make the structure more flat, place comparison last, rename "Introduction"
to "CPU emulation".
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 171 +
1 file changed, 74 insertions(+), 97 deletions(-)
diff --git a/qemu-tech.texi b/qemu-te
These are in README or obsolete, and the detailed version can be on a
website instead.
Signed-off-by: Paolo Bonzini
---
README| 2 -
qemu-doc.texi | 249 --
2 files changed, 251 deletions(-)
diff --git a/README b/README
index f38
These are interesting for users too, since nowadays most
qemu-user users are going to be somewhat technical rather than
just people that want to run Wine. Some detail is lost, on
the other hand some of the information I removed (e.g. basic
block unchaining) was obsolete.
Signed-off-by: Paolo Bonz
qemu-tech is limited to TCG and large parts of it are obsolete or are
just fine in qemu-doc. Split it into other sources of documentation,
placing what's left in an appendix of qemu-doc.
Ultimately we should have a new internals manual built from docs/, and
then the "Translator Internals" parts o
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 12 ++--
tcg/README | 5 +
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/qemu-tech.texi b/qemu-tech.texi
index 2ab7cd4..082b62c 100644
--- a/qemu-tech.texi
+++ b/qemu-tech.texi
@@ -287,16 +287,8 @@ are very compl
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 5 -
1 file changed, 5 deletions(-)
diff --git a/qemu-tech.texi b/qemu-tech.texi
index 1b048cb..be1c210 100644
--- a/qemu-tech.texi
+++ b/qemu-tech.texi
@@ -32,7 +32,6 @@
* Introduction::
* QEMU Internals::
* Regression Tests::
-* Index::
* Paolo Bonzini (pbonz...@redhat.com) wrote:
>
>
> On 06/10/2016 13:56, Dr. David Alan Gilbert wrote:
> >> > Yes, it's sickening but that's what you do to honor backwards
> >> > compatibility.
> > Actually, that's not *that* bad an idea.
> >
> > Lets go with Jianjun's structure for the moment;
On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote:
> Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> > Some of the historical command line opts that had their
> > keys in in a completely flat namespace are now represented
> > by QAPI schemas that use a nested structs. When con
Applied to my qapi-next branch.
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> Some of the historical command line opts that had their
> keys in in a completely flat namespace are now represented
> by QAPI schemas that use a nested structs. When converting
> the QemuOpts to QObject, there is no information about
> c
Missed in commit 7537fe0 and commit 9b89b6a.
Signed-off-by: Markus Armbruster
---
docs/qmp-commands.txt | 2 +-
docs/writing-qmp-commands.txt | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
index e0adceb..b289391 1006
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> Instead of requiring all callers to go through the mutli-step
> process of turning QemuOpts into a suitable QObject for visiting,
> add a new constructor that encapsulates this logic. This will
> allow QObjectInputVisitor to be a drop-in
"Daniel P. Berrange" writes:
> On Thu, Oct 06, 2016 at 02:10:17PM +0100, Peter Maydell wrote:
>> On 6 October 2016 at 14:02, Peter Maydell wrote:
>> > On 6 October 2016 at 13:39, Michal Privoznik wrote:
>> >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h
>> >> index 0d0465a..df58ef
On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote:
> QEMU 2.7 allowed EIM even in configurations that were forbidden in the
> last patch because they were not working, like old KVM or userspace
> APIC. In order to keep backward compatibility, we again allow guests to
> misbehave in non-
Two minor cleanups:
- exit gracefully in case on unsupported target,
- put machine command line in a constant to avoid
to duplicate it.
Signed-off-by: Laurent Vivier
---
tests/usb-hcd-uhci-test.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/usb-hcd-
On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote:
> On 6 October 2016 at 15:22, Programmingkid wrote:
>> Would you accept a patch that added "Save State" and
>> "Restore State" menu items to the cocoa interface? They would
>> allow the user to save the running state of the emulator.
>
> If you
In this series the support for preadv and pwritev system call emulation
in linux-user mode is implemented. Also, the configure file is modified
to check if both of these system calls are supported on the host.
Dejan Jovicevic (3):
linux-user: detect pwritev support on configure
linux-user: ad
Information about "qemu-trivial" ML can be found in the wiki:
http://wiki.qemu.org/Contribute/TrivialPatches
But the first place where a developer looks is the file MAINTAINERS.
This also allows the get_maintainer.pl script to display
the qemu-trivial ML address when the mail subject contain
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> The input_visitor_test_add() method was accepting an instance
> of 'TestInputVisitorData' and passing it as the 'user_data'
> parameter to test functions. The main 'TestInputVisitorData'
> instance that was actually used, was meanwhile be
On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote:
> Every configuration has only up to one APIC class and we'll be extending
> the class with a function that can be called without an instanced
> object, so a direct access to the class is convenient.
>
> This patch will break compilatio
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> Allow tracing of the operation of visitors
>
> Signed-off-by: Daniel P. Berrange
Reviewed-by: Kevin Wolf
On Wed 05 Oct 2016 05:35:20 PM CEST, Max Reitz wrote:
>>> Apart from that, I have to say I think it would be a bit more useful
>>> if one would specify the area covered by the metadata caches as an
>>> absolute number instead of a relative one (I guess it's generally
>>> easier to know what area
On 6 October 2016 at 15:22, Programmingkid wrote:
> Would you accept a patch that added "Save State" and
> "Restore State" menu items to the cocoa interface? They would
> allow the user to save the running state of the emulator.
If you can get consensus on first adding those to one of the other
U
Would you accept a patch that added "Save State" and "Restore State" menu items
to the cocoa interface? They would allow the user to save the running state of
the emulator.
Eduardo Habkost writes:
> Instead of requiring clients to actually call the query-cpu-*
> commands to find out if they are implemented, remove them from
> the output of "query-commands", so clients know they are not
> available.
>
> This is implemented by extending the existing hack at
> qmp_unre
On 6 October 2016 at 14:59, Dejan Jovicevic wrote:
> This system call performs the same task as the readv system call,
> with the exception of having the fourth argument, offset, which
> specifes the file offset at which the input operation is to be performed.
>
> This implementation is based on t
On Thu, 6 Oct 2016 12:03:34 +0100
Peter Maydell wrote:
> On 6 October 2016 at 04:38, David Gibson wrote:
> > On Wed, Oct 05, 2016 at 05:31:07AM -0700, Peter Maydell wrote:
> >> On 4 October 2016 at 16:43, David Gibson
> >> wrote:
> >> > On Tue, Oct 04, 2016 at 01:36:09PM +0100, Peter Mayde
This system call performs the same task as the readv system call,
with the exception of having the fourth argument, offset, which
specifes the file offset at which the input operation is to be performed.
This implementation is based on the existing readv implementation.
Signed-off-by: Dejan Jovi
This system call performs the same task as the writev system call,
with the exception of having the fourth argument, offset, which
specifes the file offset at which the input operation is to be performed.
This implementation is based on the existing writev implementation.
Signed-off-by: Dejan Jo
Modified the configure file so that, during configuration, a check
is performed to determine if the system call pwritev is supported
by the host. The check for preadv support already exists.
Signed-off-by: Dejan Jovicevic
---
configure | 17 +
1 file changed, 17 in
Hi
On Thu, Oct 6, 2016 at 5:48 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi,
> >
> > 'monitor: use qmp_dispatch()' patch broke some iotests expecting a
> > 'missing parameter' error. This series fixes qapi visitors to return
> > this error for all types.
> >
> > This series
On Thu, Oct 06, 2016 at 02:10:17PM +0100, Peter Maydell wrote:
> On 6 October 2016 at 14:02, Peter Maydell wrote:
> > On 6 October 2016 at 13:39, Michal Privoznik wrote:
> >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h
> >> index 0d0465a..df58ef8 100644
> >> --- a/include/sysemu/ch
git repository at:
>
> git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161006
>
> for you to fetch changes up to 3daa4a9f9580ffda47df93c7c53371af226bf970:
>
> hw/ppc/spapr: Use POWER8 by default for the pse
MDCCINT_EL1 is part of the DCC debugger communication
channel between the CPU and an attached external debugger.
QEMU doesn't implement this, but since Linux may try
to access this register we need to provide at least
a dummy implementation.
Signed-off-by: Peter Maydell
---
target-arm/helper.c |
Marc-André Lureau writes:
> Hi,
>
> 'monitor: use qmp_dispatch()' patch broke some iotests expecting a
> 'missing parameter' error. This series fixes qapi visitors to return
> this error for all types.
>
> This series should go on top of:
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/ms
Marc-André Lureau writes:
> Hi
>
> - Original Message -
>> Marc-André Lureau writes:
>>
>> > Hi
>> >
>> > - Original Message -
>> > -snip-
>> >
>> >>
>> >> I'd be willing to take this as is with a suitable TODO comment
>> >> explaining where we want to go with this file. Perha
Virtio devices should implement the VirtIODevice->reset() function to
perform necessary cleanup actions and to bring the device to a quiescent
state.
In the case of the virtio-9p device, this means:
- emptying the list of active PDUs (i.e. draining all in-flight I/O)
- freeing all fids (i.e. close
Marc-André Lureau writes:
> Hi,
>
> The following series fixes 2 triggerable asserts in qmp code:
> - object-add assert() without props
> - input visitor may assert() on missing parameter
Touched up as discussed, and applied to my qapi-next branch. Thanks!
When block-commit is launched without the top parameter, it uses
internally a mirror block job. In that case all intermediate nodes
between the active and base nodes must be blocked as well.
Signed-off-by: Alberto Garcia
---
block/mirror.c | 8
1 file changed, 8 insertions(+)
diff --gi
Quorum children are special in the sense that they're not directly
attached to a block backend but they're not used as backing images
either. However the intermediate block streaming code supports
streaming to them. This is a test case for that scenario.
Signed-off-by: Alberto Garcia
---
tests/q
Fix some problems with the tracepoints for ICC register reads
and writes:
* tracepoints for ICC_BPR, ICC_APR, ICC_IGRPEN,
ICC_EIOR were not printing the that indicated whether
the access was to the group 0 or 1 register
* the ICC_IGREPEN1_EL3 read function was not actually calling
the a
This set of three straightforward patches is a preliminary
for adding virtualization support to the GICv3 emulation:
* add a (nop implementation of) MDCCINT_EL1, since KVM
will read/write it on worldswitch
* fix some bugs in the GICv3 trace events
* add trace events for the generic timers
Signed-off-by: Alberto Garcia
---
docs/live-block-ops.txt | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt
index a257087..014c8c9 100644
--- a/docs/live-block-ops.txt
+++ b/docs/live-block-ops.t
On 6 October 2016 at 13:56, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> linux-user/syscall.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index d21d901..a32386e 100644
> --- a/linux-user/syscall.c
> +++ b/lin
As with test_stream_parallel(), we allow mixing block-stream and
block-commit operations in the same backing chain as long as there's
no overlap among the involved nodes.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 30 ++
tests/qemu-iotests/030.out
qmp_block_commit() checks for op blockers in the active and
destination (base) images. However all nodes between top_bs and base
are also involved, and they are removed from the chain afterwards.
In addition to that, if top_bs is not the active layer then top_bs's
overlay also needs to be checked
On 6 October 2016 at 14:02, Peter Maydell wrote:
> On 6 October 2016 at 13:39, Michal Privoznik wrote:
>> diff --git a/include/sysemu/char.h b/include/sysemu/char.h
>> index 0d0465a..df58ef8 100644
>> --- a/include/sysemu/char.h
>> +++ b/include/sysemu/char.h
>> @@ -93,6 +93,7 @@ struct CharDrive
Add some useful trace events for the ARM generic timers (notably
the various register writes and the resulting IRQ line state).
Signed-off-by: Peter Maydell
---
Makefile.objs | 1 +
target-arm/helper.c | 20
2 files changed, 17 insertions(+), 4 deletions(-)
diff --gi
Use block_job_add_bdrv() instead of blocking all operations in
backup_start() and unblocking them in backup_run().
Signed-off-by: Alberto Garcia
---
block/backup.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 582bd0f..3a9cb7f 10064
These test cases check that it's not possible to perform two
block-stream or block-commit operations if there are nodes involved in
both.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 89 ++
tests/qemu-iotests/030.out | 4 +--
2 files
This test case checks that it's possible to launch several stream
operations in parallel in the same snapshot chain, each one involving
a different set of nodes.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 80 ++
tests/qemu-iotests/0
After a successful block-commit operation all nodes between top and
base are removed from the backing chain, and top's overlay needs to
be updated to point to base. Because of that we should prevent other
block jobs from messing with them.
This patch blocks all operations in these nodes in commit_
This adds test_stream_intermediate(), similar to test_stream() but
streams to the intermediate image instead.
It also removes the usage of blkdebug, which is unnecessary for this
test.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 21 -
tests/qemu-iotests/03
101 - 200 of 337 matches
Mail list logo