[Qemu-devel] [PATCH 1/2] 9pfs: fix information leak in xattr read

From: Li Qiang 9pfs uses g_malloc() to allocate the xattr memory space, if the guest reads this memory before writing to it, this will leak host heap memory to the guest. This patch avoid this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 2 +- 1 file

[Qemu-devel] [PATCH 2/2] 9pfs: fix memory leak about xattr value

From: Li Qiang The 'fs.xattr.value' field in V9fsFidState object doesn't consider the situation that this field has been allocated previously. Every time, it will be allocated directly. This leads a host memory leak issue. This patch fix this. Signed-off-by: Li Qiang

[Qemu-devel] [PATCH 0/2] 9pfs: fix xattr issues

From: Li Qiang Hello, This series fix two security issues, the first issue is caused by uninitialized heap, and the other is caused by no considering free the buffer allocated previously. Li Qiang (2): 9pfs: fix information leak in xattr read 9pfs: fix memory leak about

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

On 2016/10/5 20:13, Amit Shah wrote: On (Fri) 30 Sep 2016 [14:27:26], Hailiang Zhang wrote: On 2016/9/30 13:53, Amit Shah wrote: In the meanwhile, can you check why the autobuilder fails to compile with your patchset? Yes, It was related to the 9th patch, where i used %lu to print value

[Qemu-devel] [PATCH v2] usb: Change *_exitfn return type from int to void

The *_exitfn functions cannot fail and should not be returning int. This also removes the passthru_exitfn since this callback does nothing as of now. This was suggested as a Bite-sized task for code cleanup. Signed-off-by: Akanksha Srivastava ---

Re: [Qemu-devel] [PATCH] clean-up: removed duplicate #includes

On 10/08/2016 06:32 AM, Anand J wrote: > I have replied for the questions inline. Also I'll make changes to the > patch as per the review and send the updated one. > > Thanks, > Anand > > On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote: > >> On 10/07/2016 03:46 AM, Anand J

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >> Even though most put/get have no issues now, when somebody writes a new >> > put, he or she could run into issues if only checking the type >> > signature. It makes the code more readable. > No, it doesn't because one is left wondering what is

Re: [Qemu-devel] Project on Qemu

Ms.kaneez fizza writes: > Dear Sir/Ma'am > > I am working on a project in which i have to annotate the translation > buffer of qemu. I have downloaded the qemu version 2.7.0 Please help me to > locate the code of translation buffer in it. Look at tb_find and follow

Re: [Qemu-devel] [PATCH] net: eepro100: fix memory leak in device uninit

Am 08.10.2016 um 18:19 schrieb Stefan Weil: Am 08.10.2016 um 14:07 schrieb Li Qiang: From: Li Qiang The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid

[Qemu-devel] [Bug 1631625] [NEW] target-mips/dsp_helper.c: two possible bad shifts

Public bug reported: target-mips/dsp_helper.c:3480:1: error: V629 Consider inspecting the '0x01 << (size + 1)' expression. Bit shifting of the 32-bit value with a subsequent expansion to the 64-bit type. Source code is temp = temp & ((0x01 << (size + 1)) - 1); If size >= 32, then

Re: [Qemu-devel] [PATCH] net: eepro100: fix memory leak in device uninit

Am 08.10.2016 um 14:07 schrieb Li Qiang: From: Li Qiang The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid this. Signed-off-by: Li Qiang

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: qemu-trivial information

On 10/08/2016 05:00 AM, Laurent Vivier wrote: > Information about "qemu-trivial" ML can be found in the wiki: > > http://wiki.qemu.org/Contribute/TrivialPatches > > But the first place where a developer looks is the file MAINTAINERS. > > This also allows the get_maintainer.pl script to

[Qemu-devel] Project on Qemu

Dear Sir/Ma'am I am working on a project in which i have to annotate the translation buffer of qemu. I have downloaded the qemu version 2.7.0 Please help me to locate the code of translation buffer in it. Regards Kaneez Fizza MS-R Computer Science and Engineering IIT-ROPAR

[Qemu-devel] [PATCH] net: eepro100: fix memory leak in device uninit

From: Li Qiang The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid this. Signed-off-by: Li Qiang --- hw/net/eepro100.c | 1 + 1 file

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

On 07/10/2016 19:43, Jianjun Duan wrote: > Even though most put/get have no issues now, when somebody writes a new > put, he or she could run into issues if only checking the type > signature. It makes the code more readable. No, it doesn't because one is left wondering what is VMS_LINKED

Re: [Qemu-devel] [PATCH] clean-up: removed duplicate #includes

I have replied for the questions inline. Also I'll make changes to the patch as per the review and send the updated one. Thanks, Anand On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote: > On 10/07/2016 03:46 AM, Anand J wrote: > > Some files contain multiple #includes of the

Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

On Sat, Oct 8, 2016 at 4:24 PM, Richard W.M. Jones wrote: > On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote: >> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to >> support blockdev-add for SSH network protocol driver. Use only 'struct >>

Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. > > +## > +#

[Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh

Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 24

[Qemu-devel] [PULL 01/26] qemu-options.hx: fix -chardev ringbuf typos

From: Stefan Hajnoczi Clean up the documentation for -chardev ringbuf. There is a stray closing parenthesis and the comma is unnecessary. Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-André Lureau Signed-off-by:

[Qemu-devel] [PULL 08/26] MAINTAINERS: Add some more files to the virtio section

From: Thomas Huth Makefile.objs and trace-events in hw/virtio/ were not covered by MAINTAINERS yet. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS

[Qemu-devel] [PULL 24/26] linux-user: include instead of

From: Felix Janda This removes the last usage of in the code base. Signed-off-by: Felix Janda Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2] MAINTAINERS: qemu-trivial information

Information about "qemu-trivial" ML can be found in the wiki: http://wiki.qemu.org/Contribute/TrivialPatches But the first place where a developer looks is the file MAINTAINERS. This also allows the get_maintainer.pl script to display the qemu-trivial ML address when the mail subject

[Qemu-devel] [PATCH] Revert "KVM: MSI: Swap payload to native endianness"

This reverts commit d07cc1f12d8e15c167857852c39190d770763824. Original commit d07cc1f12d8e15c167857852c39190d770763824 should be fixing some endianess issue for power, however at least in latest QEMU I see that all the callers are treating MSIMessage as host endianess already, so now we should

Re: [Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

On Fri, Oct 07, 2016 at 10:40:45AM +0200, Gerd Hoffmann wrote: > On Fr, 2016-10-07 at 10:49 +1100, David Gibson wrote: > > On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote: > > > Two minor cleanups: > > > - exit gracefully in case on unsupported target, > > > - put machine command

[Qemu-devel] [PULL 06/26] MAINTAINERS: Add include/hw/audio/ to audio section

From: Thomas Huth audio.h and pcspk.h are recognized as maintained files now. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PULL 18/26] exec: remove unused compacted argument

From: Marc-André Lureau Since commit b35ba30f8f when it was introduced, phys_page_compact() takes an unused compacted argument. ubsan complains about it when launching qemu-x86_64 without arguments: qemu/exec.c:310:5: runtime error: variable length array bound

[Qemu-devel] [PULL 15/26] maint: Add module_block.h to .gitignore

From: Lin Ma Commit 0c0c1fd9 generated module_block.h automatically, Add it to .gitignore to avoid checking in it by 'git add .'. Signed-off-by: Lin Ma Reviewed-by: Fam Zheng Signed-off-by: Michael Tokarev --- .gitignore | 1 +

[Qemu-devel] [PULL 25/26] virtio: rename the bar index field name in VirtIOPCIProxy

From: Chen Fan the bar index names are much similar to the bar memory regions, distinguish them to improve the code readability. Signed-off-by: Chen Fan Signed-off-by: Michael Tokarev --- hw/display/virtio-vga.c | 4 ++--

[Qemu-devel] [PULL 12/26] MAINTAINERS: Add usermode related config files

From: Thomas Huth The default-configs/*-linux-user.mak belong to Linux usermode emulation, and default-configs/*-bsd-user.mak belong to BSD usermode emulation. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 2

[Qemu-devel] [PULL 04/26] MAINTAINERS: Add files to the Moxie section.

From: Thomas Huth The hw/moxie/ folder and default-configs/moxie-softmmu.mak obviously belong to the Moxie CPU. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 16/17] docs: Add documentation for COLO feature

On 2016/10/5 21:37, Eric Blake wrote: On 09/29/2016 03:46 AM, zhanghailiang wrote: Introduce the design of COLO, and how to test it. Signed-off-by: zhanghailiang --- docs/COLO-FT.txt | 190 +++ 1 file

[Qemu-devel] [PULL 02/26] bt-hci-csr: drop unused argument

From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- hw/arm/nseries.c | 3 +-- hw/bt/hci-csr.c | 2 +- include/hw/bt.h | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 07/26] MAINTAINERS: Add some SPARC machine related files

From: Thomas Huth And while we're at it, remove Blue Swirl from the list of maintainers. Blue has apparently been inactive for quite a while now, so I assume he's unfortunately not available as maintainer anymore. Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 22/26] CODING_STYLE: Fix a typo ("have" vs. "has")

From: Jonathan Neuschäfer Signed-off-by: Jonathan Neuschäfer Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- CODING_STYLE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 23/26] char: fix missing return in error path for chardev TLS init

From: "Daniel P. Berrange" If the qio_channel_tls_new_(server|client) methods fail, we disconnect the client. Unfortunately a missing return means we then go on to try and run the TLS handshake on a NULL I/O channel. This gives predictably segfaulty results. The main way to

[Qemu-devel] [PULL 05/26] MAINTAINERS: Add some more files to the HMP section

From: Thomas Huth The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h files were classified as unmaintained. Let's add them to the HMP section. Signed-off-by: Thomas Huth Reviewed-by: Luiz Capitulino Reviewed-by: Eric

[Qemu-devel] [PULL 20/26] build-sys: fix find-in-path

From: Marc-André Lureau Fix spelling, the GNU make text functions is not called "find-string" but "findstring". Broken in commit 2b2e59e. Fairly harmless: its only use is in tests/tcg/Makefile, where the bug can cause the I386_TESTS not to run when they should.

[Qemu-devel] [PULL 21/26] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

From: Wei Yang According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. This patch takes this change and also move them all in header file. Signed-off-by: Wei Yang

[Qemu-devel] [PULL 09/26] MAINTAINERS: Add header files to CRIS section

From: Thomas Huth etraxfs_dma.h and etraxfs.h in include/hw/cris/ obviously belong to the CRIS section in MAINTAINERS. Signed-off-by: Thomas Huth Reviewed-by: Edgar E. Iglesias Signed-off-by: Michael Tokarev ---

[Qemu-devel] [PULL 19/26] m68k: change default system clock for m5208evb

From: Greg Ungerer The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166.67MHz. The current qemu emulation code for this board is defaulting to 66MHz. This results in time appearing to run way to slowly. So a "sleep 5" in a standard ColdFire

[Qemu-devel] [PULL 11/26] MAINTAINERS: Add some more pattern to recognize all win32 related files

From: Thomas Huth The get_maintainer.pl script currently thinks that the win32 related files in the util and include folders are currently unmaintained. Thus let's add some additional wildcards to match these files. Signed-off-by: Thomas Huth Reviewed-by:

[Qemu-devel] [PULL 03/26] tests: Ignore test executables

From: Eric Blake Commits 9ef8112a and efad6682 introduced new tests, but forgot to ignore the built executables from an in-tree build. Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 26/26] net/filter-mirror: Fix mirror initial check typo

From: Zhang Chen Signed-off-by: Zhang Chen Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- net/filter-mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 16/26] qapi: make the json schema files more regular.

From: David Anderson This makes it easier to parse the schema file for tool generation: each paragraph is either a non-docstring comment, or a docstring immediately followed by a Python dict describing an API item. Signed-off-by: David Anderson Reviewed-by:

[Qemu-devel] [PULL 10/26] MAINTAINERS: Add some more rocker related files

From: Thomas Huth The files in tests/rocker/ and docs/specs/rocker.txt should be listed in the Rocker section of MAINTAINERS. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL 00/26] Trivial patches for 2016-10-08

Hi. Here's another trivial tree pull request. Really trivial stuff all over, and many changes to MAINTAINERS file from Thomas Huth. Please consider applying. Thanks, /mjt The following changes since commit 48f592118ab42f83a1a7561c4bfd2b72a100f241: bsd-user: fix FreeBSD build after

[Qemu-devel] [PULL 14/26] MAINTAINERS: Some updates related to the SH4 machines

From: Thomas Huth hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to the R2D machine, as far as I can see. And concerning the Shix machine, it does not make much sense to have a "M:" entry here and the "S:" set to "Orphan". So I'd like to suggest to use "Odd Fixes"

[Qemu-devel] [PULL 17/26] usb: ehci: fix memory leak in ehci_process_itd

From: Li Qiang While processing isochronous transfer descriptors(iTD), if the page select(PG) field value is out of bands it will return. In this situation the ehci's sg list is not freed thus leading to a memory leak issue. This patch avoid this. Signed-off-by: Li Qiang

[Qemu-devel] [PULL 13/26] MAINTAINERS: Add some more MIPS related files

From: Thomas Huth The MIPS section is missing some related header files, and files in the hw/misc/, hw/intc/ and hw/timer/ folders. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 7 +++ 1 file changed, 7

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

On 10/03/2016 09:48 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:02 +0800 Xiao Guangrong wrote: General design issue in this series is regenerating _FIT data every time inside of _FIT read loop. The issue here is that if FIT data doesn't fit in one page

Re: [Qemu-devel] [PATCH] net/filter-mirror: Fix mirror initial check typo

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] linux-user: include instead of

01.10.2016 02:40, Felix Janda wrote: This removes the last usage of in the code base. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init

30.09.2016 18:02, Daniel P. Berrange wrote: If the qio_channel_tls_new_(server|client) methods fail, we disconnect the client. Unfortunately a missing return means we then go on to try and run the TLS handshake on a NULL I/O channel. This gives predictably segfaulty results. Applied to

Re: [Qemu-devel] [PATCH] virtio: rename the bar index field name in VirtIOPCIProxy

29.09.2016 07:04, Chen Fan wrote: the bar index names are much similar to the bar memory regions, distinguish them to improve the code readability. -vpci_dev->modern_mem_bar = 2; -vpci_dev->msix_bar = 4; +vpci_dev->modern_mem_bar_idx = 2; +vpci_dev->msix_bar_idx = 4; ...

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more MIPS related files

30.09.2016 10:26, Thomas Huth wrote: The MIPS section is missing some related header files, and files in the hw/misc/, hw/intc/ and hw/timer/ folders. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Some updates related to the SH4 machines

30.09.2016 12:32, Thomas Huth wrote: hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to the R2D machine, as far as I can see. And concerning the Shix machine, it does not make much sense to have a "M:" entry here and the "S:" set to "Orphan". So I'd like to suggest to use "Odd Fixes"

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add usermode related config files

30.09.2016 10:07, Thomas Huth wrote: The default-configs/*-linux-user.mak belong to Linux usermode emulation, and default-configs/*-bsd-user.mak belong to BSD usermode emulation. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has")

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

> -原始邮件- > 发件人: "Amit Shah" > 发送时间: 2016年9月30日 星期五 > 收件人: "Chunguang Li" > 抄送: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, > pbonz...@redhat.com, stefa...@redhat.com, quint...@redhat.com > 主题: Re: Re:

Re: [Qemu-devel] [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS

On 10/03/2016 09:21 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:08 +0800 Xiao Guangrong wrote: nvdimm's memory info can not exported via _CRS, instead, it is reported by NFIT/FIT This patch let _CRS return zero for both memory address and memory size

Re: [Qemu-devel] [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback

On 10/03/2016 05:45 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:07 +0800 Xiao Guangrong wrote: We should let nvdimm acpi know which nvdimm device is being unplugged before QEMU interrupts the guest so that nvdimm acpi can update its FIT properly

Re: [Qemu-devel] [PATCH v2 4/8] nvdimm acpi: implement Read FIT function

On 09/30/2016 09:17 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:06 +0800 Xiao Guangrong wrote: Read FIT whose function index is 0x is reserved by QEMU to read the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for detailed info

Re: [Qemu-devel] [PATCH v2 8/8] nvdimm docs: add nvdimm Read FIT function

On 09/30/2016 10:03 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:10 +0800 Xiao Guangrong wrote: Add the specification of Read FIT function should be squashed into 3/8 Okay.

Re: [Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT

On 09/30/2016 09:14 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:05 +0800 Xiao Guangrong wrote: _FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely

Re: [Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM

On Wed, Oct 05, 2016 at 03:06:55PM +0200, Radim Krčmář wrote: [...] > @@ -2472,10 +2473,22 @@ static bool vtd_decide_config(IntelIOMMUState *s, > Error **errp) > } > > if (s->intr_eim == ON_OFF_AUTO_AUTO) { > -s->intr_eim = x86_iommu->intr_supported ? > +s->intr_eim

Re: [Qemu-devel] [PATCH v4 5/8] intel_iommu: add OnOffAuto intr_eim as "eim" property

On Wed, Oct 05, 2016 at 03:06:54PM +0200, Radim Krčmář wrote: > The default (auto) emulates the current behavior. > A user can now control EIM like > -device intel-iommu,intremap=on,eim=off > > Reviewed-by: Igor Mammedov > Signed-off-by: Radim Krčmář

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

On 09/30/2016 07:44 PM, Kirti Wankhede wrote: > On 9/30/2016 8:40 AM, Jike Song wrote: >> On 09/30/2016 10:58 AM, Jike Song wrote: >>> On 09/29/2016 11:06 PM, Kirti Wankhede wrote: On 9/29/2016 7:47 AM, Jike Song wrote: > +Guangrong > > On 08/25/2016 11:53 AM, Kirti

Re: [Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize

On Wed, Oct 05, 2016 at 03:06:53PM +0200, Radim Krčmář wrote: > * there no point in configuring the device if realization is going to > fail, so move the check to the beginning, > * create a separate function for the check, > * use error_setg() instead error_report(). > > Reviewed-by: Igor

Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic

On Wed, Oct 05, 2016 at 03:06:52PM +0200, Radim Krčmář wrote: > The MMIO interface to APIC only allowed 8 bit addresses, which is not > enough for 32 bit addresses from EIM remapping. > Intel stored upper 24 bits in the high MSI address, so use the same > technique. The technique is also used in

Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

On Wed, Oct 05, 2016 at 03:06:51PM +0200, Radim Krčmář wrote: > The MMIO based interface to APIC doesn't work well with MSIs that have > upper address bits set (remapped x2APIC MSIs). A specialized interface > is a quick and dirty way to avoid the shortcoming. > > Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break

Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic

On Sat, Oct 08, 2016 at 02:14:09PM +0800, Peter Xu wrote: > On Fri, Oct 07, 2016 at 06:24:15PM +0200, Radim Krčmář wrote: > > [...] > > > KVM accepts the address in host endianess and QEMU/VTD code also uses > > host endianess for internal representation of memory addresses, so this > > hunk

Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic

On Fri, Oct 07, 2016 at 06:24:15PM +0200, Radim Krčmář wrote: [...] > KVM accepts the address in host endianess and QEMU/VTD code also uses > host endianess for internal representation of memory addresses, so this > hunk should be fine. > > It is confusing, because the VTD is definitely broken