[Qemu-devel] [PATCH for-2.8 0/2] raw_bsd: Fixing use of the 'offset' option without 'size'

The patch set contains two patches related to the use of 'offset' option: - The first patch is purely cosmetic. Although it touches overflow check it only affects what error message is produced. - Second patch lessens the restriction on the size alignment when only 'offset' is specified.

Re: [Qemu-devel] when we add EL2 to QEMU TCG ARM emulation and the virt board, should it default on or off?

Laszlo Ersek writes: > On 11/01/16 18:16, Peter Maydell wrote: >> I'm working on turning on EL2 support in our TCG ARM emulation, >> and one area I'm not sure about is whether it should default to >> on or off. >> >> We have a few precedents: >> >> For EL3 support: >> * the

[Qemu-devel] [PATCH for-2.8 2/2] raw_bsd: don't check size alignment when only offset is set

We make sure that the size is aligned to sector length to prevent any round ups. Otherwise we could end up reading/writing data outside the area specified by user. This is only needed when user supplies the size option to avoid any surprises. It is not necessary when only offset is set. More

[Qemu-devel] [PATCH for-2.8 1/2] raw_bsd: move check to prevent overflow

When only offset is specified but no size and the offset is greater than the real size of the containing device an overflow occurs when parsing the options. This overflow is harmless because we do check for this exact situation little bit later, but it leads to an error message with weird values.

Re: [Qemu-devel] [PATCH v2 01/11] qapi: add qapi2texi script

Marc-André Lureau writes: > Hi > > On Fri, Oct 28, 2016 at 7:45 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > As the name suggests, the qapi2texi script converts JSON QAPI >> > description into a

Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests

Hi Alex, I have a merged branch with these changes but it needs more work. I will post the next version soon(for some definition of soon :) You can find the in-progress branch here: https://github.com/pranith/qemu tcg_test_cleanup_v4 Thanks, On Thu, Nov 3, 2016 at 9:35 AM, Alex Bennée

Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests

Marc-André Lureau writes: > Hi > > On Mon, Sep 19, 2016 at 7:57 PM Pranith Kumar wrote: > >> >> Hi Marc, >> >> Marc-André Lureau writes: >> >> > Hi Pranith >> > >> > On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar >>

Re: [Qemu-devel] [PATCH] target-sh4: add atomic tas

Le 03/11/2016 à 14:29, Paolo Bonzini a écrit : > > > On 03/11/2016 14:12, Laurent Vivier wrote: >> Implement real atomic tas. >> >> As tas is: >> >> When (Rn) = 0, 1 -> T >> Otherwise, 0 -> T >> In both cases, 1 -> MSB of (Rn) >> >> It can't be implemented using cmpxchg(). > > Why

Re: [Qemu-devel] [PATCH] target-sh4: add atomic tas

On 03/11/2016 14:12, Laurent Vivier wrote: > Implement real atomic tas. > > As tas is: > > When (Rn) = 0, 1 -> T > Otherwise, 0 -> T > In both cases, 1 -> MSB of (Rn) > > It can't be implemented using cmpxchg(). Why not? This is essentially movitemp0, 0x80

Re: [Qemu-devel] [PATCH v3 0/6] jobs: fix transactional race condition

Am 02.11.2016 um 18:50 hat John Snow geschrieben: > There are a few problems with transactional job completion right now. > > First, if jobs complete so quickly they complete before remaining jobs > get a chance to join the transaction, the completion mode can leave well > known state and the

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

Acked-by: Dmitry Fleytman > On 3 Nov 2016, at 14:57 PM, Cao jin wrote: > > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin > --- >

Re: [Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

Am 02.11.2016 um 18:50 hat John Snow geschrieben: > Refactor backup_start as backup_job_create, which only creates the job, > but does not automatically start it. The old interface, 'backup_start', > is not kept in favor of limiting the number of nearly-identical interfaces > that would have to be

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 03:30:59PM -0700, Stefano Stabellini wrote: > On Tue, 1 Nov 2016, Eduardo Habkost wrote: > > On Tue, Nov 01, 2016 at 05:44:16PM +, Wei Liu wrote: > > > Introduce this field to control whether ACPI build is enabled by a > > > particular machine or accelerator. > > > > >

[Qemu-devel] [PATCH] target-sh4: add atomic tas

Implement real atomic tas. As tas is: When (Rn) = 0, 1 -> T Otherwise, 0 -> T In both cases, 1 -> MSB of (Rn) It can't be implemented using cmpxchg(). So we use an helper and "parallel_cpus"+cpu_loop_exit_atomic(). Tested with image from:

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On 11/03/2016 09:00 PM, Igor Mammedov wrote: just drop this and describe properly 'len' in spec section i.e. len: length of entire returned data (including the header) Okay, i will change the spec like this: QEMU Writes Output Data (based on the offset in the page): [0x0 - 0x3]:

Re: [Qemu-devel] [PATCH v4 3/3] pc: memhp: enable nvdimm device hotplug

On 11/03/2016 08:51 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 11:51:30 +0800 Xiao Guangrong wrote: _GPE.E04 is dedicated for nvdimm device hotplug Signed-off-by: Xiao Guangrong --- default-configs/mips-softmmu-common.mak

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On Thu, 3 Nov 2016 20:21:05 +0800 Xiao Guangrong wrote: > On 11/03/2016 07:58 PM, Igor Mammedov wrote: > > On Thu, 3 Nov 2016 11:51:29 +0800 > > Xiao Guangrong wrote: > > > >> _FIT is required for hotplug support, guest will

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

On 11/03/2016 02:57 PM, Cao jin wrote: When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET Sorry I forget to commit the amendment

[Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET Sorry I forget to commit the amendment again... hw/net/e1000e.c

[Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin Reviewed-by: Marcel Apfelbaum --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET hw/net/e1000e.c

Re: [Qemu-devel] [PATCH v4 3/3] pc: memhp: enable nvdimm device hotplug

On Thu, 3 Nov 2016 11:51:30 +0800 Xiao Guangrong wrote: > _GPE.E04 is dedicated for nvdimm device hotplug > > Signed-off-by: Xiao Guangrong > --- > default-configs/mips-softmmu-common.mak | 1 + > docs/specs/acpi_nvdimm.txt

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On Thu, 3 Nov 2016 18:08:04 +0800 Xiao Guangrong wrote: > On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: > > On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: > >> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, > >> hwaddr

Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

On Thu, 3 Nov 2016 19:09:35 +0800 Xiao Guangrong wrote: > On 11/03/2016 07:02 PM, Igor Mammedov wrote: > > On Thu, 3 Nov 2016 11:51:28 +0800 > > Xiao Guangrong wrote: > > > >> The buffer is used to save the FIT info for all the

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On 11/03/2016 07:58 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 11:51:29 +0800 Xiao Guangrong wrote: _FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received s/_FIT/_FIT method/ the same

Re: [Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

On 11/02/2016 11:47 AM, Juan Quintela wrote: > Jianjun Duan wrote: >> Add a test for QTAILQ migration to tests/test-vmstate.c. >> >> Signed-off-by: Jianjun Duan > > Reviewed-by: Juan Quintela > Empty QTAILQ seems to

Re: [Qemu-devel] [PATCH v1 1/1] virtio crypto device specification: asymmetric crypto service

Ping Is there any comment for this patch? thanks > -Original Message- > From: Zeng, Xin > Sent: Friday, October 28, 2016 10:52 AM > To: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org > Cc: m...@redhat.com; arei.gong...@huawei.com; Keating, Brian A >

Re: [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

Am 02.11.2016 um 18:50 hat John Snow geschrieben: > Instead of automatically starting jobs at creation time via backup_start > et al, we'd like to return a job object pointer that can be started > manually at later point in time. > > For now, add the block_job_start mechanism and start the jobs >

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On Thu, 3 Nov 2016 11:51:29 +0800 Xiao Guangrong wrote: > _FIT is required for hotplug support, guest will inquire the updated > device info from it if a hotplug event is received s/_FIT/_FIT method/ the same applies to subj. line > > As FIT buffer is not

Re: [Qemu-devel] [PATCH v5 10/10] msi_init: convert assert to return -errno

On 11/03/2016 08:10 AM, Cao jin wrote: According to the disscussion: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html Hi, Intense discussion, but I learned a lot from it. Let leaf function returns reasonable -errno, let caller decide how to handle the return value.

Re: [Qemu-devel] [PATCH v5 03/10] pci: Convert msix_init() to Error and fix callers to check it

On 11/03/2016 06:06 AM, Cao jin wrote: msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. For some devices(like e1000e, vmxnet3) who won't fail because of msix_init's failure, suppress the error

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

On 11/03/2016 12:14 PM, Halil Pasic wrote: > > > On 11/02/2016 05:38 PM, Paolo Bonzini wrote: >> >> >> On 02/11/2016 11:45, Juan Quintela wrote: > +while (qemu_get_byte(f)) { > +elm = g_malloc(size); >>> I think this is not generic enough. We really need to allocate a new

Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

On 11/03/2016 07:02 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 11:51:28 +0800 Xiao Guangrong wrote: The buffer is used to save the FIT info for all the presented nvdimm devices which is updated after the nvdimm device is plugged or unplugged. In the later

Re: [Qemu-devel] [PATCH v2] pcie_aer: Convert pcie_aer_init to Error

On 11/02/2016 02:45 PM, Cao jin wrote: When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- hw/net/e1000e.c| 2 +- hw/pci-bridge/ioh3420.c| 3 ++-

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

On 11/02/2016 05:38 PM, Paolo Bonzini wrote: > > > On 02/11/2016 11:45, Juan Quintela wrote: +while (qemu_get_byte(f)) { +elm = g_malloc(size); >> I think this is not generic enough. We really need to allocate a new >> element, and then fill it with default values. >> >>

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

On 11/02/2016 06:01 PM, Laine Stump wrote: On 11/02/2016 11:16 AM, Marcel Apfelbaum wrote: The shpc component is optional while ACPI hotplug is used for hot-plugging PCI devices into a PCI-PCI bridge. Disabling the shpc by default will make slot 0 usable at boot time and not only for hot-plug,

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

On 11/03/2016 06:18 AM, Michael S. Tsirkin wrote: On Wed, Nov 02, 2016 at 05:16:42PM +0200, Marcel Apfelbaum wrote: The shpc component is optional while ACPI hotplug is used for hot-plugging PCI devices into a PCI-PCI bridge. Disabling the shpc by default will make slot 0 usable at boot time

Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

On Thu, 3 Nov 2016 11:51:28 +0800 Xiao Guangrong wrote: > The buffer is used to save the FIT info for all the presented nvdimm > devices which is updated after the nvdimm device is plugged or > unplugged. In the later patch, it will be used to construct NVDIMM >

Re: [Qemu-devel] [kvm-unit-tests PATCHv7 0/3] ARM PMU tests

echo $SUBJECT | s/PATCHv7/PATCH v7/ (otherwise busts my filters) On Wed, Nov 02, 2016 at 05:22:14PM -0500, Wei Huang wrote: > Changes from v6: > * Add a new pmu testing for KVM mode in config file > * Add additional init code, including setting PMCNTENSET and PMCCFILTR, > before reading

Re: [Qemu-devel] [kvm-unit-tests PATCHv7 3/3] arm: pmu: Add CPI checking

From: Christopher s-o-b: Wei On Wed, Nov 02, 2016 at 05:22:17PM -0500, Wei Huang wrote: > Calculate the numbers of cycles per instruction (CPI) implied by ARM > PMU cycle counter values. > > Signed-off-by: Christopher Covington > --- > arm/pmu.c | 109 >

Re: [Qemu-devel] [kvm-unit-tests PATCHv7 2/3] arm: pmu: Check cycle count increases

On Wed, Nov 02, 2016 at 05:22:16PM -0500, Wei Huang wrote: Missing From: Christopher > Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, > even for the smallest delta of two subsequent reads. > > Signed-off-by: Christopher Covington > Signed-off-by: Wei

Re: [Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

Jianjun Duan wrote: > On 11/02/2016 03:40 AM, Juan Quintela wrote: >> Jianjun Duan wrote: >>> Current migration code cannot handle some data structures such as >>> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >>> in

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr) cpu_physical_memory_write(dsm_mem_addr, , sizeof(out)); } +#define

Re: [Qemu-devel] [kvm-unit-tests PATCHv7 1/3] arm: Add PMU test

On Wed, Nov 02, 2016 at 05:22:15PM -0500, Wei Huang wrote: Missing From: Christopher Covington > Beginning with a simple sanity check of the control register, add > a unit test for the ARM Performance Monitors Unit (PMU). > > Signed-off-by: Christopher Covington

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

> > > > > I think this is "very" wasteful. Assume the workload writes the pages > dirty randomly within the guest address space, and the transfer speed is > constant. Intuitively, I think nearly half of the dirty pages produced in > Iteration 1 is not really dirty. This means the time of Iteration

Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

On 11/03/2016 06:00 PM, Stefan Hajnoczi wrote: On Thu, Nov 03, 2016 at 11:51:28AM +0800, Xiao Guangrong wrote: +static void nvdimm_init_fit_buffer(NvdimmFitBuffer *fit_buf) +{ +fit_buf->fit = g_array_new(false, true /* clear */, 1); +} + +static void

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

> pages will be sent. Before that during the migration setup, the > ioctl(KVM_GET_DIRTY_LOG) is called once, so the kernel begins to produce > the dirty bitmap from this moment. When the pages "that haven't been > sent" are written, the kernel space marks them as dirty. However I don't > think

Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

On Thu, Nov 03, 2016 at 11:51:28AM +0800, Xiao Guangrong wrote: > +static void nvdimm_init_fit_buffer(NvdimmFitBuffer *fit_buf) > +{ > +fit_buf->fit = g_array_new(false, true /* clear */, 1); > +} > + > +static void nvdimm_build_fit_buffer(NvdimmFitBuffer *fit_buf) > +{ > +

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: > @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr > dsm_mem_addr) > cpu_physical_memory_write(dsm_mem_addr, , sizeof(out)); > } > > +#define NVDIMM_DSM_RET_STATUS_SUCCESS0 /* Success */ >

Re: [Qemu-devel] [PATCH V2 00/11] vhost device IOTLB support

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH V2 00/11] vhost device IOTLB support Message-id:

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

Am 02.11.2016 um 18:55 hat Max Reitz geschrieben: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any functionality, and

[Qemu-devel] [PATCH V2 08/11] acpi: add ATSR for q35

This patch provides ATSR which was a requirement for software that wants to enable ATS on endpoint devices behind a Root Port. This is done simply by setting ALL_PORTS which indicates all PCI-Express Root Ports support ATS transactions. Signed-off-by: Jason Wang ---

Re: [Qemu-devel] [PULL 39/47] pc: memhp: enable nvdimm device hotplug

On Thu, 3 Nov 2016 00:00:45 +0800 Xiao Guangrong wrote: > On 11/02/2016 07:19 PM, Igor Mammedov wrote: > > On Sun, 30 Oct 2016 23:25:10 +0200 > > "Michael S. Tsirkin" wrote: > > > >> From: Xiao Guangrong > >> >

[Qemu-devel] [PATCH V2 07/11] virtio-pci: address space translation service (ATS) support

This patches enable the Address Translation Service support for virtio pci devices. This is needed for a guest visible Device IOTLB implementation and will be required by vhost device IOTLB API implementation for intel IOMMU. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang

[Qemu-devel] [PATCH V2 06/11] intel_iommu: support device iotlb descriptor

This patch enables device IOTLB support for intel iommu. The major work is to implement QI device IOTLB descriptor processing and notify the device through iommu notifier. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PATCH V2 02/11] virtio: convert to use DMA api

Currently, all virtio devices bypass IOMMU completely. This is because address_space_memory is assumed and used during DMA emulation. This patch converts the virtio core API to use DMA API. This idea is - introducing a new transport specific helper to query the dma address space. (only pci

[Qemu-devel] [PATCH V2 11/11] vhost_net: device IOTLB support

This patches implements Device IOTLB support for vhost kernel. This is done through: 1) switch to use dma helpers when map/unmap vrings from vhost codes 2) kernel support for Device IOTLB API: - allow vhost-net to query the IOMMU IOTLB entry through eventfd - enable the ability for qemu to

[Qemu-devel] [PATCH V2 05/11] exec: introduce address_space_get_iotlb_entry()

This patch introduces a helper to query the iotlb entry for a possible iova. This will be used by later device IOTLB API to enable the capability for a dataplane (e.g vhost) to query the IOTLB. Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard

[Qemu-devel] [PATCH V2 10/11] memory: handle alias in memory_region_is_iommu()

Signed-off-by: Jason Wang --- include/exec/memory.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index e605de3..ab37499 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -628,6 +628,9 @@ static inline

[Qemu-devel] [PATCH V2 03/11] intel_iommu: name vtd address space with devfn

To avoid duplicated name and ease debugging. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: Peter Xu Signed-off-by: Jason Wang

[Qemu-devel] [PATCH V2 09/11] memory: handle alias for iommu notifier

Cc: Paolo Bonzini Signed-off-by: Jason Wang --- memory.c | 9 + 1 file changed, 9 insertions(+) diff --git a/memory.c b/memory.c index 33110e9..2bfc37f 100644 --- a/memory.c +++ b/memory.c @@ -1603,6 +1603,11 @@ static void

[Qemu-devel] [PATCH V2 04/11] intel_iommu: allocate new key when creating new address space

We use the pointer to stack for key for new address space, this will break hash table searching, fixing by g_malloc() a new key instead. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PATCH V2 00/11] vhost device IOTLB support

Hi all: As the userspace vitio driver became popular, more and more request were received for secure DMA environemt (DMAR). So this series tries to makeDMAR works for virtio/vhost. The idea is let virtio/vhost co-work with userspace iommu implememtation. This is done through: - for virtio, when

[Qemu-devel] [PATCH V2 01/11] intel_iommu: fixing source id during IOTLB hash key calculation

Using uint8_t for source id will lose bus num and get the wrong/invalid IOTLB entry. Fixing by using uint16_t instead and enlarge level shift. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v3 0/4] nvdimm: hotplug support

On Thu, 3 Nov 2016 06:53:33 +0200 "Michael S. Tsirkin" wrote: > On Wed, Nov 02, 2016 at 03:01:33PM +0100, Igor Mammedov wrote: > > On Sat, 29 Oct 2016 00:35:36 +0800 > > Xiao Guangrong wrote: > > > > > It is based on my previous patchset, > >

Re: [Qemu-devel] [PATCH v3 3/4] nvdimm acpi: introduce _FIT

On Wed, 2 Nov 2016 23:54:05 +0800 Xiao Guangrong wrote: > On 11/02/2016 09:56 PM, Igor Mammedov wrote: > > On Sat, 29 Oct 2016 00:35:39 +0800 > > Xiao Guangrong wrote: > > > >> _FIT is required for hotplug support, guest will

Re: [Qemu-devel] [PATCH v3 3/4] nvdimm acpi: introduce _FIT

On Wed, 2 Nov 2016 23:40:56 +0800 Xiao Guangrong wrote: > On 11/02/2016 12:24 AM, Igor Mammedov wrote: > > On Sat, 29 Oct 2016 00:35:39 +0800 > > Xiao Guangrong wrote: > > > >> _FIT is required for hotplug support, guest will

Re: [Qemu-devel] [RFC 2/2] ARM: KVM: Enable in-kernel timers with user space gic

On 11/02/2016 05:19 PM, Christoffer Dall wrote: On Wed, Nov 02, 2016 at 04:40:35PM +0100, Alexander Graf wrote: On 11/01/2016 12:35 PM, Peter Maydell wrote: On 29 October 2016 at 22:10, Alexander Graf wrote: [...] +cpu->timer_irq_level = run->s.regs.timer_irq_level;

[Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

The function undoes the effect of virtqueue_pop and doesn't do anything destructive or irreversible so virtqueue_unpop is a more fitting name. Signed-off-by: Ladi Prosek --- hw/net/virtio-net.c| 2 +- hw/virtio/virtio-balloon.c | 2 +- hw/virtio/virtio.c | 8

[Qemu-devel] [PATCH v2 2/2] virtio: make virtqueue_alloc_element static

The function does not fully initialize the returned VirtQueueElement and should be used only internally from the virtio module. Signed-off-by: Ladi Prosek --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PATCH v2 0/2] virtio: cosmetic tweaks

Just a trivial couple of patches addressing minor style issues. v1 -> v2: * rebased on top of current master Ladi Prosek (2): virtio: rename virtqueue_discard to virtqueue_unpop virtio: make virtqueue_alloc_element static

Re: [Qemu-devel] [RFC 05/17] ppc: Clean up and QOMify hypercall emulation

On 30/10/16 22:11, David Gibson wrote: > The pseries machine type is a bit unusual in that it runs a paravirtualized > guest. The guest expects to interact with a hypervisor, and qemu > emulates the functions of that hypervisor directly, rather than executing > hypervisor code within the emulated

Re: [Qemu-devel] [PATCH v1 1/2] arm_generic_timer: Add the ARM Generic Timer

Le 02/11/2016 à 17:41, Alistair Francis a écrit : Add the ARM generic timer. This allows the guest to poll the timer for values and also supports secure writes only. Signed-off-by: Alistair Francis --- hw/timer/Makefile.objs | 1 +

Re: [Qemu-devel] [PATCH v2] vl.c: move pidfile creation up the line

On 02/11/2016 15:18, Michael Tokarev wrote: > With current code, pid file is open after various > sockets, chardevs, fsdevs and the like. This causes > interesting effects, for example when monitor is a > unix-socket, and another qemu instance is already > running, new qemu first "damages" the

Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars

On 03/11/2016 07:16, Fam Zheng wrote: > On Wed, 11/02 17:24, Paolo Bonzini wrote: >> Unnesting variables spends a lot of time parsing and executing foreach >> and if functions. Because actually very few variables have to be >> saved and restored, a good strategy is to remember what has to be

Re: [Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

> However, QEMU 2.7 shipped with bundled SeaBIOS 1.9.3 binaries. See QEMU > commits 6e03a28e1cee (part of v2.7.0) and 6e99f5741ff1 (not part of any > tagged release yet). > > The fix is probably the following: > - backport SeaBIOS commit 0e21548b15e2 to the stable 1.9 branch, for > release

Re: [Qemu-devel] [RFC 04/17] pseries: Make cpu_update during CAS unconditional

On 30/10/16 22:11, David Gibson wrote: > spapr_h_cas_compose_response() includes a cpu_update parameter which > controls whether it includes updated information on the CPUs in the device > tree fragment returned from the ibm,client-architecture-support (CAS) call. > > Providing the updated

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

> -Original Messages- > From: "Dr. David Alan Gilbert" > Sent Time: Friday, October 14, 2016 > To: "Chunguang Li" > Cc: "Amit Shah" , qemu-devel@nongnu.org, > pbonz...@redhat.com, stefa...@redhat.com,

Re: [Qemu-devel] [RFC 03/17] pseries: Always use core objects for CPU construction

On 30/10/16 22:11, David Gibson wrote: > Currently the pseries machine has two paths for constructing CPUs. On > newer machine type versions, which support cpu hotplug, it constructs > cpu core objects, which in turn construct CPU threads. For older machine > versions it individually constructs

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

Max Reitz writes: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). Care to explain why it works "for very small files" in a bit more detail? PATCH 3 gives a "does not support byte ranges"

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

unfortunately cherry-picking the SeaBIOS 1.10 binary update commit from qemu master (6e99f5741ff1) on top of v2.7.0 does not solve the issue (the only observable change is the version string that is displayed on booting, right when it hangs ;)). I can still give your suggested route a try if you

Re: [Qemu-devel] [PATCH v2] vl.c: move pidfile creation up the line

Michael Tokarev writes: > With current code, pid file is open after various > sockets, chardevs, fsdevs and the like. This causes > interesting effects, for example when monitor is a > unix-socket, and another qemu instance is already > running, new qemu first "damages" the

Re: [Qemu-devel] [PATCH] keyboard: fix qemu load empty keymap

Michael Tokarev writes: > 03.11.2016 08:56, Wang Xin wrote: >> qemu_find_file do not check file is a directory or just a file. >> If qemu start with "-k ''", qemu_find_file get a empty string >> as keymap file name, then, qemu treat the keymap path as keymap >> file, it makes

Re: [Qemu-devel] [PATCH] keyboard: fix qemu load empty keymap

03.11.2016 08:56, Wang Xin wrote: > qemu_find_file do not check file is a directory or just a file. > If qemu start with "-k ''", qemu_find_file get a empty string > as keymap file name, then, qemu treat the keymap path as keymap > file, it makes vnc keyboard input unusable. Do we really care?

Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars

On Wed, 11/02 17:24, Paolo Bonzini wrote: > Unnesting variables spends a lot of time parsing and executing foreach > and if functions. Because actually very few variables have to be > saved and restored, a good strategy is to remember what has to be done > in load-vars, and only iterate the right

Re: [Qemu-devel] [PATCH v5 10/10] msi_init: convert assert to return -errno

Please ignore this one, I forget to commit the amendment... Already send the right one. Cao jin On 11/03/2016 12:06 PM, Cao jin wrote: According to the disscussion: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html Let leaf function returns reasonable -errno, let caller

[Qemu-devel] [PATCH v5 10/10] msi_init: convert assert to return -errno

According to the disscussion: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html Let leaf function returns reasonable -errno, let caller decide how to handle the return value. Suggested-by: Markus Armbruster CC: Markus Armbruster CC:

Re: [Qemu-devel] [PATCH v5 00/10] Convert msix_init() to error

sorry I forget to cc maintainers in cover letter. On 11/03/2016 12:06 PM, Cao jin wrote: v5 changelog: 1. Address to all comments of Markus 2. Add the given R-b to each commit message. Cao jin (10): msix: Follow CODING_STYLE hcd-xhci: check & correct param before using it pci: Convert

<    1   2