Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-14 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 11/14 15:07, Stefan Hajnoczi wrote: >> On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: >> > diff --git a/block/vxhs.c b/block/vxhs.c >> > new file mode 100644 >> > index 000..8913e8f >> > --- /dev/null >> > +++ b/block/vxhs.c >> >

Re: [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING

2016-11-14 Thread Richard Henderson
On 11/15/2016 06:41 AM, Pranith Kumar wrote: Move the asserts in tb_lock/unlock() to DEBUG_LOCKING to avoid the assert checking overhead in normal builds. I know DEBUG_LOCKING already exists in translate-all.c, but I think both this and the old ought to be using CONFIG_DEBUG_TCG, so that it

[Qemu-devel] [PULL V3 3/3] docs: fix COLO architecture diagram

2016-11-14 Thread Jason Wang
From: Zhang Chen Fix COLO-Proxy part of COLO architecture diagram Signed-off-by: Zhang Chen Reviewed-by: zhanghailiang Signed-off-by: Jason Wang --- docs/COLO-FT.txt | 72

[Qemu-devel] [PULL V3 2/3] net: fix sending of data with -net socket, listen backend

2016-11-14 Thread Jason Wang
From: "Daniel P. Berrange" The use of -net socket,listen was broken in the following commit commit 16a3df403b10c4ac347159e39005fd520b2648bb Author: Zhang Chen Date: Fri May 13 15:35:19 2016 +0800 net/net: Add SocketReadState for

[Qemu-devel] [PULL V3 0/3] Net patches

2016-11-14 Thread Jason Wang
The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging (2016-11-14 17:07:16 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

[Qemu-devel] [PULL V3 1/3] net: skip virtio-net config of deleted nic's peers

2016-11-14 Thread Jason Wang
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with multiple queues and Windows RSS-capable guest. If back-end delete requested during virtio-net device initialization, driver still can

Re: [Qemu-devel] [PATCH] docs: fix COLO architecture diagram

2016-11-14 Thread Jason Wang
On 2016年11月01日 11:38, Zhang Chen wrote: Fix COLO-Proxy part of COLO architecture diagram Signed-off-by: Zhang Chen --- docs/COLO-FT.txt | 72 +--- 1 file changed, 37 insertions(+), 35 deletions(-) diff

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Alexey Kardashevskiy
On 15/11/16 17:33, Kirti Wankhede wrote: > > > On 11/15/2016 10:47 AM, Alexey Kardashevskiy wrote: >> On 08/11/16 17:52, Alexey Kardashevskiy wrote: >>> On 05/11/16 08:10, Kirti Wankhede wrote: VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated device

[Qemu-devel] [PATCH v1 13/18] block/pcache: inflight readahead request waiting for aio read

2016-11-14 Thread Pavel Butsykin
If there was a cache hit, but the status of the node is NODE_STATUS_INFLIGHT, then this means that a readahead request for this node is in flight. In this case, we can wait for the completion of the readahead request, and then copy the data. It allows us even more to optimize aio read requests.

[Qemu-devel] [PATCH v1 07/18] block/pcache: skip large aio read

2016-11-14 Thread Pavel Butsykin
This change will allow more efficient use of cache memory and filter the case for which the pcache isn't efficient. We skip requests that are not required in the optimization and thereby reducing the number of unnecessary readaheads. Add pcache-max-aio-size open parameter. Signed-off-by: Pavel

[Qemu-devel] [PATCH v1 04/18] util/rbcache: range-based cache core

2016-11-14 Thread Pavel Butsykin
RBCache provides functionality to cache the data from block devices (basically). The range here is used as the main key for searching and storing data. The cache is based on red-black trees, so basic operations search, insert, delete are performed for O(log n). It is important to note that QEMU

Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-14 Thread Jike Song
On 11/14/2016 11:42 PM, Kirti Wankhede wrote: > Add a notifier calback to parent's ops structure of mdev device so that per > device notifer for vfio module is registered through vfio_mdev module. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Kirti Wankhede
On 11/15/2016 10:47 AM, Alexey Kardashevskiy wrote: > On 08/11/16 17:52, Alexey Kardashevskiy wrote: >> On 05/11/16 08:10, Kirti Wankhede wrote: >>> VFIO IOMMU drivers are designed for the devices which are IOMMU capable. >>> Mediated device only uses IOMMU APIs, the underlying hardware can be

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-11-14 Thread Namhyung Kim
On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > > > + > > > > +/* the

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-14 Thread Hailiang Zhang
On 2016/11/14 21:54, Stefan Hajnoczi wrote: On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote: ping ? Anyone pick this up? The original patch that added these lines went through Amit Shah and David Gilbert. I have CCed them. Great, thanks :) Stefan

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-14 Thread Namhyung Kim
On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > [SNIP] > > > > +struct virtio_pstore_fileinfo { > > > > + __virtio64

Re: [Qemu-devel] [PATCH v12 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-14 Thread Alexey Kardashevskiy
On 15/11/16 02:42, Kirti Wankhede wrote: > Add task structure to vfio_dma structure. > During DMA_UNMAP, same task who mapped it or other task who shares same > address space is allowed to unmap, otherwise unmap fails. > QEMU maps few iova ranges initially, then fork threads and from the child >

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Alexey Kardashevskiy
On 08/11/16 17:52, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> VFIO IOMMU drivers are designed for the devices which are IOMMU capable. >> Mediated device only uses IOMMU APIs, the underlying hardware can be >> managed by an IOMMU domain. >> >> Aim of this change is:

Re: [Qemu-devel] [PATCH] vfio: avoid adding same iommu mr for notify

2016-11-14 Thread Alexey Kardashevskiy
On 15/11/16 11:59, Peter Xu wrote: > When one IOMMU memory region is splitted into multiple memory sections, Out of curiosity - when does this happen? > vfio will register multiple same notifiers to a vIOMMU for the same > region. That's not sensible. What we need is to register one IOMMU >

Re: [Qemu-devel] [PATCH v2 0/4] ppc/pnv: XSCOM fixes and unit tests

2016-11-14 Thread Cédric Le Goater
On 11/15/2016 12:11 AM, David Gibson wrote: > On Mon, Nov 14, 2016 at 10:12:54AM +0100, Cédric Le Goater wrote: >> Hello, >> >> Here is a little serie adding some fixes for the XSCOM registers of >> the POWER9 cores and a unit test. >> >> Changes since v1 : >> >> - fixed pnv_xscom_addr() for

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-14 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > Hi Michael, > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > > The virtio pstore driver provides interface to the pstore subsystem so > > >

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-14 Thread Namhyung Kim
Hi Michael, On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > >

[Qemu-devel] [PULL for-2.8 13/13] mirror: do not flush every time the disks are synced

2016-11-14 Thread Jeff Cody
From: Paolo Bonzini This puts a huge strain on the disks when there are many concurrent migrations. With this patch we only flush twice: just before issuing the event, and just before pivoting to the destination. If management will complete the job close to the

[Qemu-devel] [PULL for-2.8 10/13] block/curl: Fix return value from curl_read_cb

2016-11-14 Thread Jeff Cody
From: Max Reitz While commit 38bbc0a580f9f10570b1d1b5d3e92f0e6feb2970 is correct in that the callback is supposed to return the number of bytes handled; what it does not mention is that libcurl will throw an error if the callback did not "handle" all of the data passed to it.

[Qemu-devel] [PULL for-2.8 12/13] block/curl: Do not wait for data beyond EOF

2016-11-14 Thread Jeff Cody
From: Max Reitz libcurl will only give us as much data as there is, not more. The block layer will deny requests beyond the end of file for us; but since this block driver is still using a sector-based interface, we can still get in trouble if the file size is not a multiple

[Qemu-devel] [PULL for-2.8 05/13] blockjob: refactor backup_start as backup_job_create

2016-11-14 Thread Jeff Cody
From: John Snow Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of nearly-identical interfaces that would have to be edited to keep up

[Qemu-devel] [PULL for-2.8 11/13] block/curl: Remember all sockets

2016-11-14 Thread Jeff Cody
From: Max Reitz For some connection types (like FTP, generally), more than one socket may be used (in FTP's case: control vs. data stream). As of commit 838ef602498b8d1985a231a06f5e328e2946a81d ("curl: Eliminate unnecessary use of curl_multi_socket_all"), we have to remember

[Qemu-devel] [PULL for-2.8 07/13] qemu-iotests: avoid spurious failure on test 109

2016-11-14 Thread Jeff Cody
From: Paolo Bonzini In some cases it is possible that query-io-status is called just before the job is completed, causing -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "src", "len": 31457280,

[Qemu-devel] [PULL for-2.8 09/13] block/curl: Use BDRV_SECTOR_SIZE

2016-11-14 Thread Jeff Cody
From: Max Reitz Currently, curl defines its own constant SECTOR_SIZE. There is no advantage over using the global BDRV_SECTOR_SIZE, so drop it. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Eric Blake Message-id:

[Qemu-devel] [PULL for-2.8 08/13] block/curl: Drop TFTP "support"

2016-11-14 Thread Jeff Cody
From: Max Reitz Because TFTP does not support byte ranges, it was never usable with our curl block driver. Since apparently nobody has ever complained loudly enough for someone to take care of the issue until now, it seems reasonable to assume that nobody has ever actually

[Qemu-devel] [PULL for-2.8 03/13] blockjob: add .start field

2016-11-14 Thread Jeff Cody
From: John Snow Add an explicit start field to specify the entrypoint. We already have ownership of the coroutine itself AND managing the lifetime of the coroutine, let's take control of creation of the coroutine, too. This will allow us to delay creation of the actual

[Qemu-devel] [PULL for-2.8 06/13] iotests: add transactional failure race test

2016-11-14 Thread Jeff Cody
From: John Snow Add a regression test for the case found by Vladimir. Reported-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id:

[Qemu-devel] [PULL for-2.8 04/13] blockjob: add block_job_start

2016-11-14 Thread Jeff Cody
From: John Snow Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the block_job_start mechanism and start the jobs automatically as we have

[Qemu-devel] [PULL for-2.8 01/13] blockjob: fix dead pointer in txn list

2016-11-14 Thread Jeff Cody
From: Vladimir Sementsov-Ogievskiy Though it is not intended to be reached through normal circumstances, if we do not gracefully deconstruct the transaction QLIST, we may wind up with stale pointers in the list. The rest of this series attempts to address the

[Qemu-devel] [PULL for-2.8 02/13] blockjob: add .clean property

2016-11-14 Thread Jeff Cody
From: John Snow Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to enter

[Qemu-devel] [PULL for-2.8 00/13] Block patches for 2.8

2016-11-14 Thread Jeff Cody
The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging (2016-11-14 17:07:16 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request

Re: [Qemu-devel] [PATCH for-2.8] mirror: do not flush every time the disks are synced

2016-11-14 Thread Jeff Cody
On Wed, Nov 09, 2016 at 05:01:31PM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Jeff Cody" > > To: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, qemu-bl...@nongnu.org, js...@redhat.com > > Sent: Wednesday, November 9, 2016

Re: [Qemu-devel] [PATCH 0/4] block/curl: Fix FTP

2016-11-14 Thread Jeff Cody
On Wed, Oct 26, 2016 at 10:44:02AM +0100, Richard W.M. Jones wrote: > As well as testing patch 2 on its own, I also tested all 4 patches > together on top of current qemu from git. > > In summary, it seems to work fine and doesn't break http or https as > far as I can tell. > > Rich. > > $

Re: [Qemu-devel] [PULL V2 0/3] Net patches

2016-11-14 Thread Jason Wang
On 2016年11月15日 00:40, Stefan Hajnoczi wrote: On Mon, Nov 14, 2016 at 10:54:23AM +0800, Jason Wang wrote: Pavel Dovgalyuk (1): record/replay: add network support QEMU is in soft freeze. The policy has changed this release and only bug fixes are being accepted during soft freeze.

Re: [Qemu-devel] [PULL V2 0/3] Net patches

2016-11-14 Thread Jason Wang
On 2016年11月14日 14:46, Zhang Chen wrote: Hi~ Jason~ Can you pick up this patch? [PATCH] docs: fix COLO architecture diagram Thanks Zhang Chen Will have a look at this and pick it. Thanks

[Qemu-devel] [PULL 19/19] boot-serial-test: Add a test for the powernv machine

2016-11-14 Thread David Gibson
From: Thomas Huth The new powernv machine ships with a firmware that outputs some text to the serial console, so we can automatically test this machine type in the boot-serial tester, too. And to get some (very limited) test coverage for the new POWER9 CPU emulation, too, this

[Qemu-devel] [PULL 15/19] ppc/pnv: add a 'xscom_core_base' field to PnvChipClass

2016-11-14 Thread David Gibson
From: Cédric Le Goater The XSCOM addresses for the core registers are encoded in a slightly different way on POWER8 and POWER9. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/pnv.c | 8 +++-

[Qemu-devel] [PULL 18/19] tests: add XSCOM tests for the PowerNV machine

2016-11-14 Thread David Gibson
Add a couple of tests on the XSCOM bus of the PowerNV machine for the the POWER8 and POWER9 CPUs. The first tests reads the CFAM identifier of the chip. The second test goes further in the XSCOM address space and reaches the cores to read their DTS registers. Signed-off-by: Cédric Le Goater

[Qemu-devel] [PULL 10/19] target-ppc: Implement bcdcfz. instruction

2016-11-14 Thread David Gibson
From: Jose Ricardo Ziviani bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses a byte to represent a digit where the most significant nibble is 0x3 or 0xf, depending on the preferred signal. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PULL 11/19] target-ppc: Implement bcdctz. instruction

2016-11-14 Thread David Gibson
From: Jose Ricardo Ziviani bcdctz. converts from BCD to Zoned numeric format. Zoned format uses a byte to represent a digit where the most significant nibble is 0x3 or 0xf, depending on the preferred signal. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PULL 12/19] spapr: Fix migration of PCI host bridges from qemu-2.7

2016-11-14 Thread David Gibson
daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration from qemu-2.7 to the current version. It split the device's MMIO window into two pieces for 32-bit and 64-bit MMIO. The patch included backwards compatibility code to convert the old property into the new format. However, the

[Qemu-devel] [PULL 09/19] target-ppc: Implement bcdctn. instruction

2016-11-14 Thread David Gibson
From: Jose Ricardo Ziviani bcdctn. converts from BCD to National numeric format. National format uses a byte to represent a digit where the most significant nibble is always 0x3 and the least sign. nibbles is the digit itself. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PULL 17/19] ppc/pnv: Fix fatal bug on 32-bit hosts

2016-11-14 Thread David Gibson
If the pnv machine type is compiled on a 32-bit host, the unsigned long (host) type is 32-bit. This means that the hweight_long() used to calculate the number of allowed cores only considers the low 32 bits of the cores_mask variable, and can thus return 0 in some circumstances. This corrects

[Qemu-devel] [PULL 05/19] powernv: CPU compatibility modes don't make sense for powernv

2016-11-14 Thread David Gibson
powernv has some code (derived from the spapr equivalent) used in device tree generation which depends on the CPU's compatibility mode / logical PVR. However, compatibility modes don't make sense on powernv - at least not as a property controlled by the host - because the guest in powernv has

[Qemu-devel] [PULL 06/19] ppc/pnv: fix compile breakage on old gcc

2016-11-14 Thread David Gibson
From: Cédric Le Goater PnvChip is defined twice and this can confuse old compilers : CC ppc64-softmmu/hw/ppc/pnv_xscom.o In file included from qemu.git/hw/ppc/pnv.c:29: qemu.git/include/hw/ppc/pnv.h:60: error: redefinition of typedef ‘PnvChip’

[Qemu-devel] [PULL 08/19] target-ppc: Implement bcdcfn. instruction

2016-11-14 Thread David Gibson
From: Jose Ricardo Ziviani bcdcfn. converts from National numeric format to BCD. National format uses a byte to represent a digit where the most significant nibble is always 0x3 and the least sign. nibbles is the digit itself. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PULL 02/19] target-ppc: add vrldnmi and vrlwmi instructions

2016-11-14 Thread David Gibson
From: "Gautham R. Shenoy" vrldmi: Vector Rotate Left Dword then Mask Insert vrlwmi: Vector Rotate Left Word then Mask Insert Signed-off-by: Gautham R. Shenoy Signed-off-by: Bharata B Rao ( use extract[32,64] and

[Qemu-devel] [PULL 16/19] ppc/pnv: fix xscom address translation for POWER9

2016-11-14 Thread David Gibson
From: Cédric Le Goater High addresses can overflow the uint32_t pcba variable after the 8byte shift. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/pnv_xscom.c | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL 03/19] target-ppc: add vrldnm and vrlwnm instructions

2016-11-14 Thread David Gibson
From: Bharata B Rao vrldnm: Vector Rotate Left Doubleword then AND with Mask vrlwnm: Vector Rotate Left Word then AND with Mask Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania Reviewed-by: David

[Qemu-devel] [PULL 13/19] FU exceptions should carry a cause (IC)

2016-11-14 Thread David Gibson
From: Balbir Singh As per the ISA we need a cause and executing a tabort r9 in libc for example causes a EXCP_FU exception, we don't wire up the IC (cause) when we post the exception. The cause is required for the kernel to do the right thing. The fix applies only to 64

[Qemu-devel] [PULL 14/19] spapr-vty: Fix bad assert() statement

2016-11-14 Thread David Gibson
From: Thomas Huth When using the serial console in the GTK interface of QEMU (and QEMU has been compiled with CONFIG_VTE), it is possible to trigger the assert() statement in vty_receive() in spapr_vty.c by pasting a chunk of text with length > 16 into the QEMU window. Most of

[Qemu-devel] [PULL 07/19] ppc: Remove some stub POWER6 models

2016-11-14 Thread David Gibson
The CPU model table includes stub (commented out) definitions for CPU_POWERPC_POWER6_5 and CPU_POWERPC_POWER6A. These are not real cpu models, but represent the POWER6 in some compatiblity modes. If we ever do implement POWER6 (unlikely), we'll implement its compatibility modes in a different

[Qemu-devel] [PULL 01/19] bitops: fix rol/ror when shift is zero

2016-11-14 Thread David Gibson
From: Nikunj A Dadhania All the variants for rol/ror have a bug in case where the shift == 0. For example rol32, would generate: return (word << 0) | (word >> 32); Which though works, would be flagged as a runtime error on clang's sanitizer. Suggested-by:

[Qemu-devel] [PULL 04/19] target-ppc: add vprtyb[w/d/q] instructions

2016-11-14 Thread David Gibson
From: Ankit Kumar Add following POWER ISA 3.0 instructions. vprtybw: Vector Parity Byte Word vprtybd: Vector Parity Byte Double Word vprtybq: Vector Parity Byte Quad Word Signed-off-by: Ankit Kumar Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PULL 00/19] ppc-for-2.8 queue 20161115

2016-11-14 Thread David Gibson
The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging (2016-11-14 17:07:16 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161115 for you to

[Qemu-devel] [PATCH v2 3/3] 9pfs: add cleanup operation for proxy backend driver

2016-11-14 Thread Li Qiang
In the init operation of proxy backend dirver, it allocates a V9fsProxy struct and some other resources. We should free these resources when the 9pfs device is unrealized. This is what this patch does. Signed-off-by: Li Qiang --- hw/9pfs/9p-proxy.c | 10 ++ 1 file

[Qemu-devel] [PATCH v2 1/3] 9pfs: add cleanup operation in FileOperations

2016-11-14 Thread Li Qiang
Currently, the backend of VirtFS doesn't have a cleanup function. This will lead resource leak issues if the backed driver allocates resources. This patch addresses this issue. Signed-off-by: Li Qiang --- Changes since the v1: -move the cleanup stuff above calls to g_free -add

[Qemu-devel] [PATCH v2 0/3] 9pfs: add cleanup operation in handle/proxy backend

2016-11-14 Thread Li Qiang
Currently, the backend of VirtFS doesn't have a cleanup function. This will leak some resources in handle and proxy backend driver. This patchset addresses this issue. Li Qiang (3): 9pfs: add cleanup operation in FileOperations 9pfs: add cleanup operation for handle backend driver 9pfs: add

[Qemu-devel] [PATCH v2 2/3] 9pfs: add cleanup operation for handle backend driver

2016-11-14 Thread Li Qiang
In the init operation of handle backend dirver, it allocates a handle_data struct and opens a mount file. We should free these resources when the 9pfs device is unrealized. This is what this patch does. Signed-off-by: Li Qiang --- hw/9pfs/9p-handle.c | 8 1 file

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-14 Thread Fam Zheng
On Mon, 11/14 13:06, Eric Blake wrote: > So I guess you have to determine if libqnio is something that should > compile completely independent from qemu, or whether it is so closely > tied to the rest of qemu that it should follow qemu conventions. The question is on include directives in

Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of not_legacy_32bit

2016-11-14 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Zhuangyanying > Sent: Monday, November 14, 2016 8:35 PM > To: pbonz...@redhat.com; arm...@redhat.com > Cc: qemu-devel@nongnu.org; Gonglei (Arei); Huangweidong (C); > Zhuangyanying > Subject: [PATCH] hw/misc/ivshmem:fix misconfig of

[Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

2016-11-14 Thread Laszlo Ersek
The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before

[Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize

2016-11-14 Thread Li Qiang
From: Li Qiang Unrealize should undo things that were set during realize in reverse order. This is what this patch does. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c

Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-11-14 Thread Andrew Jeffery
On Mon, 2016-11-14 at 08:14 +0100, Cédric Le Goater wrote: > > Given the starting point of the tmp105 code the patch looks okay, but I > > was a bit thrown by the use of the 'len' member as what I'd consider an > > index. For instance we reset len to zero in tmp421_event() after > > populating

Re: [Qemu-devel] [PATCH] vfio: avoid adding same iommu mr for notify

2016-11-14 Thread Peter Xu
On Mon, Nov 14, 2016 at 07:59:28PM -0500, Peter Xu wrote: > When one IOMMU memory region is splitted into multiple memory sections, > vfio will register multiple same notifiers to a vIOMMU for the same > region. That's not sensible. What we need is to register one IOMMU > notifier for each IOMMU

[Qemu-devel] [PATCH] vfio: avoid adding same iommu mr for notify

2016-11-14 Thread Peter Xu
When one IOMMU memory region is splitted into multiple memory sections, vfio will register multiple same notifiers to a vIOMMU for the same region. That's not sensible. What we need is to register one IOMMU notifier for each IOMMU region, not per section. Solution is simple - we traverse the

Re: [Qemu-devel] [PATCH 04/21] tests: add hbitmap iter test

2016-11-14 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by:

Re: [Qemu-devel] [PATCH v12 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 21:12:25 +0530 Kirti Wankhede wrote: > Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers > about DMA_UNMAP. > Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). > Notifier should be registered, if external

Re: [Qemu-devel] [PATCH 03/21] hbitmap: improve dirty iter

2016-11-14 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/qemu/hbitmap.h | 25

Re: [Qemu-devel] [PATCH v2 0/4] ppc/pnv: XSCOM fixes and unit tests

2016-11-14 Thread David Gibson
On Mon, Nov 14, 2016 at 10:12:54AM +0100, Cédric Le Goater wrote: > Hello, > > Here is a little serie adding some fixes for the XSCOM registers of > the POWER9 cores and a unit test. > > Changes since v1 : > > - fixed pnv_xscom_addr() for 32bit host systems > - replace hweight_long() by

Re: [Qemu-devel] [PATCH v12 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 21:12:24 +0530 Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-14 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 08:54:36PM +0800, Cao jin wrote: > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin > Reviewed-by: Marcel Apfelbaum I'll review and

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke Pls remember to ping after release. > Test: > 1.

Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:52:58PM +, Stefan Hajnoczi wrote: > On Fri, Nov 11, 2016 at 08:09:58PM +0200, Michael S. Tsirkin wrote: > > libvhost-user is the only thing that might be controvertial here, but it's > > only > > affecting contrib/ and tests so I think it's still fair game, and

[Qemu-devel] [kvm-unit-tests PATCH v6 07/11] arm/arm64: gicv2: add an IPI test

2016-11-14 Thread Andrew Jones
Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v6: move the spurious check to its own check_ function [drew] v5: use modern registers [Andre] v4: properly mask irqnr in ipi_handler v2: add more details in the output if a test fails, report

[Qemu-devel] [kvm-unit-tests PATCH v6 06/11] arm/arm64: add initial gicv2 support

2016-11-14 Thread Andrew Jones
Add some gicv2 support. This just adds init and enable functions, allowing unit tests to start messing with it. Reviewed-by: Andre Przywara Signed-off-by: Andrew Jones --- v6: added comments (register offset headers) [Alex] v5: share/use only the

[Qemu-devel] [kvm-unit-tests PATCH v6 09/11] arm/arm64: add initial gicv3 support

2016-11-14 Thread Andrew Jones
Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones --- v6: - added comments [Alex] - added stride parameter to gicv3_set_redist_base [Andre] - redist-wait s/rwp/uwp/ and comment [Andre] - removed unnecessary wait-for-rwps [Andre] v5: use modern

[Qemu-devel] [kvm-unit-tests PATCH v6 04/11] arm/arm64: add some delay routines

2016-11-14 Thread Andrew Jones
Allow a thread to wait some specified amount of time. Can specify in cycles, usecs, and msecs. Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 19 +++

[Qemu-devel] [kvm-unit-tests PATCH v6 11/11] arm/arm64: gic: don't just use zero

2016-11-14 Thread Andrew Jones
Allow user to select who sends ipis and with which irq, rather than just always sending irq=0 from cpu0. Signed-off-by: Andrew Jones --- v6: - make sender/irq names more future-proof [drew] - sanity check inputs [drew] - introduce check_sender/irq and bad_sender/irq to

[Qemu-devel] [kvm-unit-tests PATCH v6 10/11] arm/arm64: gicv3: add an IPI test

2016-11-14 Thread Andrew Jones
Signed-off-by: Andrew Jones --- v6: move most gicv2/gicv3 wrappers to common code [Alex] v5: - fix copy+paste error in gicv3_write_eoir [drew] - use modern register names [Andre] v4: - heavily comment gicv3_ipi_send_tlist() [Eric] - changes needed for gicv2 iar/irqstat

[Qemu-devel] [kvm-unit-tests PATCH v6 08/11] libcflat: add IS_ALIGNED() macro, and page sizes

2016-11-14 Thread Andrew Jones
From: Peter Xu These macros will be useful to do page alignment checks. Reviewed-by: Andre Przywara Signed-off-by: Peter Xu [drew: also added SZ_64K and changed to shifts] Signed-off-by: Andrew Jones --- v6:

[Qemu-devel] [kvm-unit-tests PATCH v6 05/11] arm/arm64: irq enable/disable

2016-11-14 Thread Andrew Jones
Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 10 ++ lib/arm64/asm/processor.h | 10 ++ 2 files changed, 20 insertions(+) diff --git

[Qemu-devel] [kvm-unit-tests PATCH v6 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit

2016-11-14 Thread Andrew Jones
mrs is always 64bit, so we should always use a 64bit register. Sometimes we'll only want to return the lower 32, but not for MPIDR, as that does define fields in the upper 32. Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew

[Qemu-devel] [kvm-unit-tests PATCH v6 00/11] arm/arm64: add gic framework

2016-11-14 Thread Andrew Jones
v6: - rebased to latest master - several other changes thanks to Andre and Alex, changes in individual patch change logs - some code cleanups v5: - fix arm32/gicv3 compile [drew] - use modern register names [Andre] - one Andre r-b v4: - Eric's r-b's - Andre's suggestion to only take

[Qemu-devel] [kvm-unit-tests PATCH v6 03/11] arm/arm64: smp: support more than 8 cpus

2016-11-14 Thread Andrew Jones
By adding support for launching with gicv3 we can break the 8 vcpu limit. This patch adds support to smp code and also selects the vgic model corresponding to the host. The vgic model may also be manually selected by adding e.g. -machine gic-version=3 to extra_params. Reviewed-by: Alex Bennée

[Qemu-devel] [kvm-unit-tests PATCH v6 01/11] lib: xstr: allow multiple args

2016-11-14 Thread Andrew Jones
Make implementation equivalent to Linux's include/linux/stringify.h Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/libcflat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libcflat.h b/lib/libcflat.h index

[Qemu-devel] [PATCH 3/3] migration: Don't create decompression threads if not enabled

2016-11-14 Thread Juan Quintela
Signed-off-by: Juan Quintela -- I removed the [HACK] part because previous patch just check that compression pages are not received. Signed-off-by: Juan Quintela --- migration/ram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH 2/3] migration: Test for disabled features on reception

2016-11-14 Thread Juan Quintela
Right now, if we receive a compressed page or a xbzrle page while this features are disabled, Bad Things (TM) can happen. Just add a test for them. Signed-off-by: Juan Quintela --- migration/ram.c | 23 ++- 1 file changed, 22 insertions(+), 1

[Qemu-devel] [PATCH 0/3] Migration fixes

2016-11-14 Thread Juan Quintela
Hi This are the fixes that were of the multifd patches. The most important one is the second patch, that one that checks for valid flags on reception. Please, review. Juan Quintela (3): migration: create Migration Incoming State at init time migration: Test for disabled features on

[Qemu-devel] [PATCH 1/3] migration: create Migration Incoming State at init time

2016-11-14 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 38 +- migration/savevm.c| 4 ++-- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-14 Thread Stefan Hajnoczi
I hit a failure running "make check" on ppc64 for the first time. Ideas? Stefan commit 682df581c65ed2c1b9e77093e332214ecaa1ee93 GTESTER check-qtest-ppc64 Memory content inconsistency at 5af4000 first_byte = 1b last_byte = 1a current = 7c hit_edge = 1 Memory content inconsistency at 5af5000

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 21:12, Karl Rister wrote: > 25646,929 > 51235,627 >1,02446,477 >2,00035,247 >2,04846,322 >4,00046,540 >4,09646,368 >8,000

Re: [Qemu-devel] [PATCH 4/4] q35: introduce q35-lite

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 04:06:02PM +0800, Chao Peng wrote: > On Mon, 2016-11-07 at 18:09 +0100, Paolo Bonzini wrote: > > > > On 06/11/2016 08:06, Michael S. Tsirkin wrote: > > > > > > On Sat, Nov 05, 2016 at 03:19:51AM -0400, Chao Peng wrote: > > > > > > > > > > > > > > This patch introduces a

Re: [Qemu-devel] [PATCH for-2.8 0/2] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-14 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 04:21:10PM +0100, Igor Mammedov wrote: > > Commit 080ac219cc7d9c55adf925c3545b7450055ad625 >pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs > > added "etc/boot-cpus" fw_cfg file durung 2.8 merge window, however > QEMU alredy had similar legacy

Re: [Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL] slirp: Fix access to freed memory Message-id: 20161114202030.17685-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

  1   2   3   >