Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-15 Thread Namhyung Kim
Hi, On Tue, Nov 15, 2016 at 11:38 PM, Paolo Bonzini wrote: > > > On 15/11/2016 15:36, Namhyung Kim wrote: >> Hi, >> >> On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: >>> >>> >>> On 15/11/2016 06:06, Michael S. Tsirkin wrote: On Tue, Nov 15, 2016 at

Re: [Qemu-devel] [PATCH v13 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-15 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-15 20:59:55 +0530]: Hi Kirti, [...] > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index ffc36758cb84..4fc63db38829 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -24,6

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Hervé Poussineau
Le 16/11/2016 à 07:29, P J P a écrit : +-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ | I don't have any datasheet for this device either, so I tested with real | programs. Those initialize itr field to either 0 or to 9, so your mask | doesn't change anything. | | Tested-by: Hervé

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread P J P
+-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ | I don't have any datasheet for this device either, so I tested with real | programs. Those initialize itr field to either 0 or to 9, so your mask | doesn't change anything. | | Tested-by: Hervé Poussineau Thank you

Re: [Qemu-devel] [PATCH v13 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-15 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-15 20:59:52 +0530]: Hi Kirti, [...] diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > @@ -331,13 +338,16 @@ static long vfio_pin_pages_remote(unsigned long vaddr, > long npage, > } > > if (!rsvd) > -

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload > value > > Hi, > > Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : > > > > > > On 10/11/2016 06:56, Gonglei (Arei) wrote: > >> Any ideas about this fix? > > > > It seems sensible, but perhaps the field is even smaller.

Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-15 Thread Jike Song
On 11/15/2016 11:19 PM, Alex Williamson wrote: > On Tue, 15 Nov 2016 14:45:42 +0800 > Jike Song wrote: > >> On 11/14/2016 11:42 PM, Kirti Wankhede wrote: >>> Add a notifier calback to parent's ops structure of mdev device so that per >>> device notifer for vfio module is

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Hervé Poussineau
Hi, Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : On 10/11/2016 06:56, Gonglei (Arei) wrote: Any ideas about this fix? It seems sensible, but perhaps the field is even smaller. Let's CC Hervé and Aurelien as I don't have a datasheet for this device. Sorry for the delay... I don't have

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Alex Williamson
On Wed, 16 Nov 2016 09:46:20 +0530 Kirti Wankhede wrote: > On 11/16/2016 9:28 AM, Alex Williamson wrote: > > On Wed, 16 Nov 2016 09:13:37 +0530 > > Kirti Wankhede wrote: > > > >> On 11/16/2016 8:55 AM, Alex Williamson wrote: > >>> On Tue, 15 Nov

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Kirti Wankhede
On 11/16/2016 9:28 AM, Alex Williamson wrote: > On Wed, 16 Nov 2016 09:13:37 +0530 > Kirti Wankhede wrote: > >> On 11/16/2016 8:55 AM, Alex Williamson wrote: >>> On Tue, 15 Nov 2016 20:16:12 -0700 >>> Alex Williamson wrote: >>> On Wed,

Re: [Qemu-devel] [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers

2016-11-15 Thread Alexey Kardashevskiy
On 11/11/16 01:45, Christian Borntraeger wrote: > On 11/09/2016 01:44 PM, Felipe Franciosi wrote: >> Following the recent refactor of virtio notfiers [1], more specifically >> the patch that uses virtio_bus_set_host_notifier [2] by default, core >> virtio code requires 'ioeventfd_started' to be

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Alex Williamson
On Wed, 16 Nov 2016 09:13:37 +0530 Kirti Wankhede wrote: > On 11/16/2016 8:55 AM, Alex Williamson wrote: > > On Tue, 15 Nov 2016 20:16:12 -0700 > > Alex Williamson wrote: > > > >> On Wed, 16 Nov 2016 08:16:15 +0530 > >> Kirti Wankhede

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Kirti Wankhede
On 11/16/2016 8:55 AM, Alex Williamson wrote: > On Tue, 15 Nov 2016 20:16:12 -0700 > Alex Williamson wrote: > >> On Wed, 16 Nov 2016 08:16:15 +0530 >> Kirti Wankhede wrote: >> >>> On 11/16/2016 3:49 AM, Alex Williamson wrote: On Tue, 15

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Alex Williamson
On Tue, 15 Nov 2016 20:16:12 -0700 Alex Williamson wrote: > On Wed, 16 Nov 2016 08:16:15 +0530 > Kirti Wankhede wrote: > > > On 11/16/2016 3:49 AM, Alex Williamson wrote: > > > On Tue, 15 Nov 2016 20:59:54 +0530 > > > Kirti Wankhede

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Alex Williamson
On Wed, 16 Nov 2016 08:16:15 +0530 Kirti Wankhede wrote: > On 11/16/2016 3:49 AM, Alex Williamson wrote: > > On Tue, 15 Nov 2016 20:59:54 +0530 > > Kirti Wankhede wrote: > > > ... > > >> @@ -854,7 +857,28 @@ static int vfio_dma_do_unmap(struct

Re: [Qemu-devel] [PATCH v13 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-15 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-15 20:59:48 +0530]: Hi Kirti, > Added APIs for pining and unpining set of pages. These call back into > backend iommu module to actually pin and unpin pages. > Added two new callback functions to struct vfio_iommu_driver_ops. Backend > IOMMU

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Kirti Wankhede
On 11/16/2016 3:49 AM, Alex Williamson wrote: > On Tue, 15 Nov 2016 20:59:54 +0530 > Kirti Wankhede wrote: > ... >> @@ -854,7 +857,28 @@ static int vfio_dma_do_unmap(struct vfio_iommu *iommu, >> */ >> if (dma->task->mm != current->mm) >>

Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support

2016-11-15 Thread Dave Young
On 11/14/16 at 10:47am, Andrew Jones wrote: > On Mon, Nov 14, 2016 at 01:32:56PM +0800, Dave Young wrote: > > On 11/09/16 at 04:38pm, Laszlo Ersek wrote: > > > On 11/09/16 15:47, Daniel P. Berrange wrote: > > > > On Wed, Nov 09, 2016 at 01:20:51PM +0100, Andrew Jones wrote: > > > >> On Wed, Nov

Re: [Qemu-devel] [PATCH] tcg/mips: Add support for mips64el backend

2016-11-15 Thread Jin Guojie
Richard, I am ready to participate in testing your v2 patch on Loongson. The work of updating the patch against master can also be done by us if you don't have time. I think the tcg/MIPS code between Feb 2016 and now has not significant difference. However, Loongson only implements

Re: [Qemu-devel] [PATCH v13 02/22] vfio: VFIO based driver for Mediated devices

2016-11-15 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-15 20:59:45 +0530]: Hi Kirti, > vfio_mdev driver registers with mdev core driver. > mdev core driver creates mediated device and calls probe routine of > vfio_mdev driver for each device. > Probe routine of vfio_mdev driver adds mediated device to

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Thomas Huth
On 15.11.2016 21:02, Greg Kurz wrote: > On Tue, 15 Nov 2016 19:24:24 +0100 > Laurent Vivier wrote: > >> On 15/11/2016 19:01, Greg Kurz wrote: >>> On Tue, 15 Nov 2016 16:07:40 +0100 >>> Laurent Vivier wrote: >>> On 15/11/2016 16:03, Greg Kurz

[Qemu-devel] [ANNOUNCE] QEMU 2.8.0-rc0 is now available

2016-11-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.8 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.8.0-rc0.tar.bz2 You can help

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: set not_legacy_32bit to 1 for ivshmem_doorbell and ivshmem-plain

2016-11-15 Thread Gonglei (Arei)
> > Subject: [PATCH v2 2/2] ivshmem: set not_legacy_32bit to 1 for > ivshmem_doorbell and ivshmem-plain > > From: ZhuangYanying > > Signed-off-by: Zhuang Yanying > --- > hw/misc/ivshmem.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [Qemu-devel] [QEMU PATCH v5 1/6] migration: alternative way to set instance_id in SaveStateEntry

2016-11-15 Thread Michael Roth
Quoting David Gibson (2016-10-06 21:54:42) > On Wed, Oct 05, 2016 at 09:44:57AM -0700, Jianjun Duan wrote: > > Please see comments below: > > > > On 10/05/2016 03:12 AM, Dr. David Alan Gilbert wrote: > > > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > >> In QOM(QEMU Object Model) migrated

Re: [Qemu-devel] [PULL 24/27] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-11-15 Thread Eric Blake
On 10/31/2016 09:37 AM, Paolo Bonzini wrote: > From: Eric Blake > > Upstream NBD protocol recently added the ability to efficiently > write zeroes without having to send the zeroes over the wire, > along with a flag to control whether the client wants a hole. > > The generic

[Qemu-devel] [PATCH for-2.9 2/2] test-hbitmap: Add hbitmap_is_serializable() calls

2016-11-15 Thread Max Reitz
Add calls to hbitmap_is_serializable() (asserting that it returns true) where necessary (i.e. before every series of (de-)serialization function invocations). Signed-off-by: Max Reitz --- tests/test-hbitmap.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Qemu-devel] [PATCH for-2.9 1/2] hbitmap: Add hbitmap_is_serializable()

2016-11-15 Thread Max Reitz
Bitmaps with a granularity of 58 or above can be neither serialized nor deserialized (see the comment in the function added in this series for an explanation). This patch adds a function so that we can check whether a bitmap actually can be (de-)serialized at all, thus avoiding failing the

[Qemu-devel] [PATCH for-2.9 0/2] hbitmap: Add hbitmap_is_serializable()

2016-11-15 Thread Max Reitz
This series is a follow-up for "hbitmap: Fix shifts of constants by granularity". So far, adding the assertion in hbitmap_serialization_granularity() (as done by said previous patch) is enough and we know that it will always hold true since bitmaps are only serialized as part of a test for now.

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 2/3] arm: pmu: Check cycle count increases

2016-11-15 Thread Wei Huang
On 11/14/2016 09:12 AM, Christopher Covington wrote: > Hi Drew, Wei, > > On 11/14/2016 05:05 AM, Andrew Jones wrote: >> On Fri, Nov 11, 2016 at 01:55:49PM -0600, Wei Huang wrote: >>> >>> >>> On 11/11/2016 01:43 AM, Andrew Jones wrote: On Tue, Nov 08, 2016 at 12:17:14PM -0600, Wei Huang

[Qemu-devel] [PATCH for-2.8 v2] hbitmap: Fix shifts of constants by granularity

2016-11-15 Thread Max Reitz
An hbitmap's granularity may be anything from 0 to 63, so when shifting constants by its value, they should not be plain ints. Even having changed the types, hbitmap_serialization_granularity() still tries to shift 64 to the right by the granularity. This operation is undefined if the granularity

Re: [Qemu-devel] [PATCH 07/21] qcow2: add dirty bitmaps extension

2016-11-15 Thread John Snow
On 11/15/2016 05:39 PM, Eric Blake wrote: On 11/15/2016 03:42 PM, John Snow wrote: On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Add dirty bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For

Re: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling

2016-11-15 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling Message-id: 1479248275-18889-1-git-send-email-da...@gibson.dropbear.id.au === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 07/21] qcow2: add dirty bitmaps extension

2016-11-15 Thread Eric Blake
On 11/15/2016 03:42 PM, John Snow wrote: > > > On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: >> Add dirty bitmap extension as specified in docs/specs/qcow2.txt. >> For now, just mirror extension header into Qcow2 state and check >> constraints. >> >> For now, disable image resize

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread ashish mittal
Hi Stefan On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > > Review of .bdrv_open() and .bdrv_aio_writev() code paths. > > The big issues I see in this driver and libqnio: > > 1. Showstoppers like

[Qemu-devel] [RFCv2 12/12] ppc: Rework CPU compatibility testing across migration

2016-11-15 Thread David Gibson
Migrating between different CPU versions is quite complicated for ppc. A long time ago, we ensure identical CPU versions at either end by checking the PVR had the same value. However, this breaks under KVM HV, because we always have to use the host's PVR - it's not virtualized. That would mean

[Qemu-devel] [RFCv2 08/12] pseries: Rewrite CAS PVR compatibility logic

2016-11-15 Thread David Gibson
During boot, PAPR guests negotiate CPU model support with the ibm,client-architecture-support mechanism. The logic to implement this in qemu is very convoluted. This cleans it up to be cleaner, using the new ppc_check_compat() call. The new logic for choosing a compatibility mode is: 1.

[Qemu-devel] [RFCv2 05/12] ppc: Rewrite ppc_set_compat()

2016-11-15 Thread David Gibson
This rewrites the ppc_set_compat() function so that instead of open coding the various compatibility modes, it reads the relevant data from a table. This is a first step in consolidating the information on compatibility modes scattered across the code into a single place. It also makes one change

[Qemu-devel] [RFCv2 11/12] pseries: Reset CPU compatibility mode

2016-11-15 Thread David Gibson
Currently, the CPU compatibility mode is set when the cpu is initialized, then again when the guest negotiates features. This means if a guest negotiates a compatibility mode, then reboots, that compatibility mode will be retained across the reset. Usually that will get overridden when features

[Qemu-devel] [RFCv2 04/12] ppc: Rename cpu_version to compat_pvr

2016-11-15 Thread David Gibson
The 'cpu_version' field in PowerPCCPU is badly named. It's named after the 'cpu-version' device tree property where it is advertised, but that meaning may not be obvious in most places it appears. Worse, it doesn't even really correspond to that device tree property. The property contains

[Qemu-devel] [RFCv2 10/12] pseries: Move CPU compatibility property to machine

2016-11-15 Thread David Gibson
Server class POWER CPUs have a "compat" property, which is used to set the backwards compatibility mode for the processor. However, this only makes sense for machine types which don't give the guest access to hypervisor privilege - otherwise the compatibility level is under the guest's control.

[Qemu-devel] [RFCv2 01/12] pseries: Always use core objects for CPU construction

2016-11-15 Thread David Gibson
Currently the pseries machine has two paths for constructing CPUs. On newer machine type versions, which support cpu hotplug, it constructs cpu core objects, which in turn construct CPU threads. For older machine versions it individually constructs the CPU threads. This division is going to

Re: [Qemu-devel] [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-15 Thread Alex Williamson
On Tue, 15 Nov 2016 20:59:54 +0530 Kirti Wankhede wrote: > Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers > about DMA_UNMAP. > Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). > Notifier should be registered, if external

[Qemu-devel] [RFCv2 03/12] ppc: Clean up and QOMify hypercall emulation

2016-11-15 Thread David Gibson
The pseries machine type is a bit unusual in that it runs a paravirtualized guest. The guest expects to interact with a hypervisor, and qemu emulates the functions of that hypervisor directly, rather than executing hypervisor code within the emulated system. To implement this in TCG, we need to

[Qemu-devel] [RFCv2 06/12] ppc: Rewrite ppc_get_compat_smt_threads()

2016-11-15 Thread David Gibson
To continue consolidation of compatibility mode information, this rewrites the ppc_get_compat_smt_threads() function using the table of compatiblity modes in target-ppc/compat.c. It's not a direct replacement, the new ppc_compat_max_threads() function has simpler semantics - it just returns the

[Qemu-devel] [RFCv2 02/12] pseries: Make cpu_update during CAS unconditional

2016-11-15 Thread David Gibson
spapr_h_cas_compose_response() includes a cpu_update parameter which controls whether it includes updated information on the CPUs in the device tree fragment returned from the ibm,client-architecture-support (CAS) call. Providing the updated information is essential when CAS has negotiated

[Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling

2016-11-15 Thread David Gibson
This series is a significant rework to how we handle CPU compatibility modes on ppc. * Information about compatibility modes was previously open coded and scattered across a number of functions in both target-ppc and spapr code. It's now brought together into a common table of

[Qemu-devel] [RFCv2 07/12] ppc: Validate compatibility modes when setting

2016-11-15 Thread David Gibson
Current ppc_set_compat() will attempt to set any compatiblity mode specified, regardless of whether it's available on the CPU. The caller is expected to make sure it is setting a possible mode, which is awkwward because most of the information to make that decision is at the CPU level. This

[Qemu-devel] [RFCv2 09/12] ppc: Add ppc_set_compat_all()

2016-11-15 Thread David Gibson
Once a compatiblity mode is negotiated with the guest, h_client_architecture_support() uses run_on_cpu() to update each CPU to the new mode. We're going to want this logic somewhere else shortly, so make a helper function to do this global update. We put it in target-ppc/compat.c - it makes as

[Qemu-devel] [PATCH] target-m68k: free TCG variables that are not

2016-11-15 Thread Laurent Vivier
This is a cleanup patch. It adds call to tcg_temp_free() when it is missing. Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/target-m68k/translate.c

Re: [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits

2016-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 09:35:34PM +0100, Greg Kurz wrote: > On Tue, 15 Nov 2016 21:22:31 +0200 > "Michael S. Tsirkin" wrote: > > > From: Greg Kurz > > > > The legacy vring layout is not used anymore as we use the separate > > mappings even for legacy devices.

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Andreas Schwab
On Nov 15 2016, Richard Henderson wrote: > On 11/15/2016 10:12 PM, Laurent Vivier wrote: >> Le 15/11/2016 à 22:07, Laurent Vivier a écrit : >>> Le 15/11/2016 à 21:44, Richard Henderson a écrit : @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env)

Re: [Qemu-devel] [PATCH v3 2/2] usb-mtp: added object properties

2016-11-15 Thread Bandan Das
Gerd Hoffmann writes: > Hi, > >> and object properties. Most object properties are data that we already >> have, except for the unique persistant object identifier. Windows > >> +case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER: >> +/* Should be persistant between

Re: [Qemu-devel] [PATCH 07/21] qcow2: add dirty bitmaps extension

2016-11-15 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Add dirty bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by:

Re: [Qemu-devel] [PATCH] tcg/mips: Add support for mips64el backend

2016-11-15 Thread Richard Henderson
On 11/14/2016 10:33 AM, Jin Guojie wrote: I want listen to your advice. Should I test your v2 patch on Loongson and use it? Or whether it is worth modifying my patch and resubmit it according to your review comments? I would like very much if you would test my patch on Loongson (or a

[Qemu-devel] [Bug 1642011] [NEW] Mouse wheel events not forwarded to guest using GTK display

2016-11-15 Thread Nathan
Public bug reported: Using QEMU 2.7.0 with KVM enabled, when I launch the guest without options (using the default of gtk), the mouse wheel events are not propagated to the guest. When I start qemu using -display sdk, mouse wheel events are properly forwarded. I can determine that the guest is

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 22:21, Richard Henderson a écrit : > On 11/15/2016 10:07 PM, Laurent Vivier wrote: >> Le 15/11/2016 à 21:44, Richard Henderson a écrit : >>> Signed-off-by: Richard Henderson >>> --- >>> >>> I've started a glibc test run with this, but I don't expect overmuch. >>>

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
On 11/15/2016 10:07 PM, Laurent Vivier wrote: Le 15/11/2016 à 21:44, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- I've started a glibc test run with this, but I don't expect overmuch. The only applications I can see are "bfffo *,0,32,dN" which isn't

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
On 11/15/2016 10:12 PM, Laurent Vivier wrote: Le 15/11/2016 à 22:07, Laurent Vivier a écrit : Le 15/11/2016 à 21:44, Richard Henderson a écrit : @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env) INSN(bfop_reg, eac0, fff8, BITFIELD); /* bfchg */ INSN(bfop_mem, ecc0,

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 22:07, Laurent Vivier a écrit : > Le 15/11/2016 à 21:44, Richard Henderson a écrit : >> @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env) >> INSN(bfop_reg, eac0, fff8, BITFIELD); /* bfchg */ >> INSN(bfop_mem, ecc0, ffc0, BITFIELD); /* bfclr */ >>

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 21:44, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > > I've started a glibc test run with this, but I don't expect overmuch. > The only applications I can see are "bfffo *,0,32,dN" which isn't > exactly exhaustive. Probably better to

Re: [Qemu-devel] [PATCH v13 10/22] vfio iommu type1: Add support for mediated devices

2016-11-15 Thread Alex Williamson
On Tue, 15 Nov 2016 20:59:53 +0530 Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread ashish mittal
Thank you. Will work with this. On Tue, Nov 15, 2016 at 12:48 PM, Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: >> I had replied to the QEMUBH suggestion in the email below. >> >> Regards, >> Ashish >> >> On Tue, Aug 23, 2016 at 3:22

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread ashish mittal
On Mon, Nov 14, 2016 at 7:07 AM, Stefan Hajnoczi wrote: > On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >> >> Sample command line

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: > I had replied to the QEMUBH suggestion in the email below. > > Regards, > Ashish > > On Tue, Aug 23, 2016 at 3:22 PM, ashish mittal wrote: > > Thanks Stefan, I will look at block/quorum.c. > > > > I have sent

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Laurent Vivier
On 15/11/2016 21:44, Laurent Vivier wrote: > > > On 15/11/2016 21:39, Laurent Vivier wrote: >> >> >> On 15/11/2016 20:00, Eric Blake wrote: >>> On 11/15/2016 12:48 PM, Thomas Huth wrote: >>> > Even for Power, I'd prefer to keep KVM since the problem only happens with > KVM PR which

[Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- I've started a glibc test run with this, but I don't expect overmuch. The only applications I can see are "bfffo *,0,32,dN" which isn't exactly exhaustive. Probably better to hand craft some tests vs real hardware. Considering the

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Laurent Vivier
On 15/11/2016 21:39, Laurent Vivier wrote: > > > On 15/11/2016 20:00, Eric Blake wrote: >> On 11/15/2016 12:48 PM, Thomas Huth wrote: >> Even for Power, I'd prefer to keep KVM since the problem only happens with KVM PR which isn't the preferred way to do KVM on bare metal... until

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 8:39 PM, ashish mittal wrote: > Thanks for concluding on this. > > I will rearrange the qnio_api.h header accordingly as follows: > > +#include "qemu/osdep.h" > +#include<=== after osdep.h > +#include "block/block_int.h" > +#include

Re: [Qemu-devel] [PATCH] HACKING: document #include order

2016-11-15 Thread Eric Blake
On 11/15/2016 02:29 PM, Stefan Hajnoczi wrote: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread ashish mittal
Thanks for concluding on this. I will rearrange the qnio_api.h header accordingly as follows: +#include "qemu/osdep.h" +#include<=== after osdep.h +#include "block/block_int.h" +#include "qapi/qmp/qerror.h" +#include "qapi/qmp/qdict.h" +#include "qapi/qmp/qstring.h" +#include "trace.h"

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Laurent Vivier
On 15/11/2016 20:00, Eric Blake wrote: > On 11/15/2016 12:48 PM, Thomas Huth wrote: > >>> Even for Power, I'd prefer to keep KVM since the problem only happens with >>> KVM PR which isn't the preferred way to do KVM on bare metal... until this >>> get fixed, I'd rather suggest people to run

Re: [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 21:22:31 +0200 "Michael S. Tsirkin" wrote: > From: Greg Kurz > > The legacy vring layout is not used anymore as we use the separate > mappings even for legacy devices. > This patch simply removes it. > > This also fixes a bug with virtio 1

[Qemu-devel] [PATCH] HACKING: document #include order

2016-11-15 Thread Stefan Hajnoczi
It was not obvious to me why "qemu/osdep.h" must be the first #include. This documents the rationale and the overall #include order. Cc: Fam Zheng Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 19:48:20 +0100 Thomas Huth wrote: > On 15.11.2016 19:13, Greg Kurz wrote: > > On Tue, 15 Nov 2016 17:43:39 + > > "Dr. David Alan Gilbert" wrote: > > > >> * Thomas Huth (th...@redhat.com) wrote: > >>> On 15.11.2016 16:18, Stefan

Re: [Qemu-devel] [RFC 1/3] aio-posix: add aio_set_poll_handler()

2016-11-15 Thread Fam Zheng
On Wed, 11/09 17:13, Stefan Hajnoczi wrote: > +struct AioPollHandler { > +QLIST_ENTRY(AioPollHandler) node; > + > +AioPollFn *poll_fn; /* check whether to invoke io_fn() */ > +IOHandler *io_fn; /* handler callback */ > +void *opaque; /* user-defined argument to

[Qemu-devel] [PULL v3 28/28] docs: add PCIe devices placement guidelines

2016-11-15 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Proposes best practices on how to use PCI Express/PCI device in PCI Express based machines and explain the reasoning behind them. Reviewed-by: Laszlo Ersek Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S.

[Qemu-devel] [PULL v3 25/28] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout

2016-11-15 Thread Michael S. Tsirkin
From: Greg Kurz With virtio 1, the vring layout is split in 3 separate regions of contiguous memory for the descriptor table, the available ring and the used ring, as opposed with legacy virtio which uses a single region. In case of memory re-mapping, the code ensures it doesn't

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 19:24:24 +0100 Laurent Vivier wrote: > On 15/11/2016 19:01, Greg Kurz wrote: > > On Tue, 15 Nov 2016 16:07:40 +0100 > > Laurent Vivier wrote: > > > >> On 15/11/2016 16:03, Greg Kurz wrote: > >>> On Tue, 15 Nov 2016 14:48:30 +

[Qemu-devel] [PULL v3 24/28] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong and use it to replace the raw number Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 23/28] nvdimm acpi: use aml_name_decl to define named object

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong to make the code more clearer Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 19/28] nvdimm acpi: rename nvdimm_acpi_hotplug

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong Rename it to nvdimm_plug() Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 18/28] nvdimm acpi: cleanup nvdimm_build_fit

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong inline buf_size to refine the code a bit Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 3/3] virtio: set ISR on dataplane notifications

2016-11-15 Thread Alex Williamson
On Tue, 15 Nov 2016 21:17:56 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 15, 2016 at 11:21:55AM -0700, Alex Williamson wrote: > > On Tue, 15 Nov 2016 19:58:52 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Nov 15, 2016 at 10:48:15AM -0700, Alex

Re: [Qemu-devel] [PULL v3 00/28] virtio, vhost, pc, pci: documentation, fixes and cleanups

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 09:20:47PM +0200, Michael S. Tsirkin wrote: > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6: > > MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +) > > are available in the git repository at: > >

[Qemu-devel] [PULL v3 16/28] docs: improve the doc of Read FIT method

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong Improve the description and clearly document the length field Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v3 27/28] virtio: drop virtio_queue_get_ring_{size, addr}()

2016-11-15 Thread Michael S. Tsirkin
From: Greg Kurz These are not used anymore. Signed-off-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 2

[Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits

2016-11-15 Thread Michael S. Tsirkin
From: Greg Kurz The legacy vring layout is not used anymore as we use the separate mappings even for legacy devices. This patch simply removes it. This also fixes a bug with virtio 1 devices when the vring descriptor table is mapped at a higher address than the used vring

[Qemu-devel] [PULL v3 14/28] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong as it is never called when nvdimm hotplug happens Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL v3 21/28] nvdimm acpi: fix two comments

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong fixed the English issue and code-style issue Suggested-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL v3 13/28] pc: memhp: move nvdimm hotplug out of memory hotplug

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong as they use completely different way to handle hotplug event Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v3 10/28] vhost: migration blocker only if shared log is used

2016-11-15 Thread Michael S. Tsirkin
From: Rafael David Tinoco Commit 31190ed7 added a migration blocker in vhost_dev_init() to check if memfd would succeed. It is better if this blocker first checks if vhost backend requires shared log. This will avoid a situation where a blocker is added

[Qemu-devel] [PULL v3 20/28] nvdimm acpi: define DSM return codes

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong and use these codes to refine the code Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 22/28] nvdimm acpi: rename nvdimm_dsm_reserved_root

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong Rename it to nvdimm_dsm_handle_reserved_root_method Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL v3 07/28] acpi: fix DMAR device scope for IOAPIC

2016-11-15 Thread Michael S. Tsirkin
From: Peter Xu We should not use cpu_to_le16() here, instead each of device/function value is stored in a 8 byte field. Signed-off-by: Peter Xu Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 08/28] virtio: allow per-device-class legacy features

2016-11-15 Thread Michael S. Tsirkin
Legacy features are those that transitional devices only expose on the legacy interface. Allow different ones per device class. Cc: qemu-sta...@nongnu.org # dependency for the next patch Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck ---

[Qemu-devel] [PULL v3 15/28] nvdimm acpi: clean up nvdimm_build_acpi

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong To make the code more clearer, we 1) check ram_slots first, and build ssdt & nfit only when it is available 2) use nvdimm_get_plugged_device_list() to check if there is nvdimm device plugged Suggested-by: Igor Mammedov

[Qemu-devel] [PULL v3 17/28] nvdimm acpi: rename nvdimm_plugged_device_list

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong Its behavior has been changed as the nvdimm device which is being realized also will be handled in this function, so rename it to reflect the fact Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong

[Qemu-devel] [PULL v3 05/28] intel_iommu: fix several incorrect endianess and bit fields

2016-11-15 Thread Michael S. Tsirkin
From: Peter Xu Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 9 - hw/i386/intel_iommu.c | 2 +- 2 files changed, 5

[Qemu-devel] [PULL v3 06/28] intel_iommu: fix incorrect assert

2016-11-15 Thread Michael S. Tsirkin
From: Peter Xu Reported-by: Michael S. Tsirkin Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PULL v3 12/28] nvdimm acpi: drop the lock of fit buffer

2016-11-15 Thread Michael S. Tsirkin
From: Xiao Guangrong as there is a global lock to protect vm-exit handlers and QMP/monitor, this lock can be dropped Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin

  1   2   3   >