Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Wed, Nov 16, 2016 at 08:12:41AM +, Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 10:38 PM, ashish mittal wrote: > > On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi wrote: > >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > >>

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

On 16-11-17 02:34 PM, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 10:58:04PM +0100, Maxime Coquelin wrote: >> This series implements Virtio spec update from Aaron Conole which >> defines a way for the host to expose its max MTU to the guest. >> >> Changes since RFC v1: >>

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Fri, Nov 18, 2016 at 12:32:06PM +0900, Namhyung Kim wrote: > Btw I prefer using the kvmtool for my kernel work since it's much more > simpler.. > > Thanks, > Namhyung Up to you but then you should extend that to support 1.0 spec. I strongly object to adding to the list of legacy interfaces we

Re: [Qemu-devel] Testing PowerPC floating point instructions

On Thu, Nov 17, 2016 at 10:57:41AM -0500, G 3 wrote: > Is there an official way to test any of the PowerPC floating point > instructions in QEMU? Don't think so. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you.

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi, Thanks for your detailed information, On Wed, Nov 16, 2016 at 07:10:36AM -0500, Paolo Bonzini wrote: > > Not sure how independent ERST is from ACPI and other specs. It looks > > like referencing UEFI spec at least. > > It is just the format of error records that comes from the UEFI spec >

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

* Alex Williamson [2016-11-17 16:51:45 -0700]: > On Thu, 17 Nov 2016 23:29:38 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, November 18, 2016 5:25 AM > > > > > > On Thu, 17

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

On 11/18/2016 10:00 AM, Kirti Wankhede wrote: > On 11/18/2016 3:35 AM, Neo Jia wrote: >> On Thu, Nov 17, 2016 at 02:25:15PM -0700, Alex Williamson wrote: >>> On Thu, 17 Nov 2016 02:16:12 +0530 >>> Kirti Wankhede wrote: Documentation/ABI/testing/sysfs-bus-vfio-mdev

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

On 11/18/2016 3:35 AM, Neo Jia wrote: > On Thu, Nov 17, 2016 at 02:25:15PM -0700, Alex Williamson wrote: >> On Thu, 17 Nov 2016 02:16:12 +0530 >> Kirti Wankhede wrote: >>> >>> Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++ >>>

Re: [Qemu-devel] [PATCH for-2.8 0/3] spapr: fix breakage of memory unplug after migration

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH for-2.8 0/3] spapr: fix breakage of memory unplug after migration Type: series Message-id: 1479433227-29238-1-git-send-email-mdr...@linux.vnet.ibm.com === TEST SCRIPT

[Qemu-devel] [PATCH for-2.8 2/3] migration: spapr_drc: defined VMStateDescription struct

From: Jianjun Duan To manage hotplug/unplug of dynamic resources such as PCI cards, memory, and CPU on sPAPR guests, a firmware abstraction known as a Dynamic Resource Connector (DRC) is used to assign a particular dynamic resource to the guest, and provide an interface

[Qemu-devel] [PATCH for-2.8 1/3] migration: alternative way to set instance_id in SaveStateEntry

From: Jianjun Duan Currently migrated Devices are identified with an idstr which is calculated automatically using their path in the QOM composition tree. In some cases these Devices may have a more reliable identifier that may be preferable in situations where there's

[Qemu-devel] [PATCH for-2.8 3/3] spapr: migration support for CAS-negotiated option vectors

With the additional of the OV5_HP_EVT option vector, we now have certain functionality (namely, memory unplug) that checks at run-time for whether or not the guest negotiated the option via CAS. Because we don't currently migrate these negotiated values, we are unable to unplug memory from a guest

[Qemu-devel] [PATCH for-2.8 0/3] spapr: fix breakage of memory unplug after migration

These patches are based on David's ppc-for-2.8 tree, and are also available from: https://github.com/mdroth/qemu/commits/spapr-cas-migration Currently, memory hotplugged to a pseries guest cannot be removed after the guest has been migrated. This is due to 2 issues: 1) The coldplugged state

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

On 11/17/2016 05:42 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> Use blkdebug's new geometry constraints to emulate setups that >> have caused recent regression fixes: write zeroes asserting >> when running through a loopback block device with max-transfer >> smaller than

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

On 11/17/2016 05:19 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> Use blkdebug's new geometry constraints to emulate setups that >> have caused recent regression fixes: write zeroes asserting >> when running through a loopback block device with max-transfer >> smaller than

Re: [Qemu-devel] [PATCH v2 7/9] blkdebug: Add pass-through write_zero and discard support

On 11/17/2016 05:27 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> In order to test the effects of artificial geometry constraints >> on operations like write zero or discard, we first need blkdebug >> to manage these actions. Ideally, it would be nice to let these >> operations

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

On 11/17/2016 05:44 PM, Max Reitz wrote: >> >> Since the SCSI specification says nothing about a minimum >> discard granularity, and only documents the preferred >> alignment, it is best if the block layer gives the driver >> every bit of information about discard requests, rather than >> rounding

[Qemu-devel] [PATCH] ppc: add appropriate warning message for qemu_find_file() NULL return

Add check for qemu_find_file() NULL return and throw a warning message can provide better visibility to the upcoming error message if any. Signed-off-by: Anand J --- hw/ppc/e500.c | 3 +++ hw/ppc/mac_newworld.c | 3 +++ hw/ppc/mac_oldworld.c | 3 +++

Re: [Qemu-devel] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support

On Thu, 2016-11-17 at 09:29 +0100, Cédric Le Goater wrote: On 11/17/2016 05:36 AM, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > This patch adds support for the Epson RX8900 RTC chip. > > It would be nice to have a short list of the features this  > chip

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

On Thu, 17 Nov 2016 23:29:38 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, November 18, 2016 5:25 AM > > > > On Thu, 17 Nov 2016 02:16:12 +0530 > > Kirti Wankhede wrote: > > > > > >

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

On 17.11.2016 21:13, Eric Blake wrote: > Discard is advisory, so rounding the requests to alignment > boundaries is never semantically wrong from the data that > the guest sees. But at least the Dell Equallogic iSCSI SANs > has an interesting property that its advertised discard > alignment is

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

On 17.11.2016 21:14, Eric Blake wrote: > Use blkdebug's new geometry constraints to emulate setups that > have caused recent regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away requests >

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, November 18, 2016 5:25 AM > > On Thu, 17 Nov 2016 02:16:12 +0530 > Kirti Wankhede wrote: > > > > Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++ > > Documentation/vfio-mediated-device.txt

Re: [Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

On Thu, Nov 17, 2016 at 03:31:48PM -0200, jos...@linux.vnet.ibm.com wrote: > Hello David, > > Thank you for your review. I have just one question below, could you > help me to address it please? > > Thank you! > > Ziviani > > On Thu, Nov 17, 2016 at 02:42:43PM +1100, David Gibson wrote: > > On

Re: [Qemu-devel] [PATCH v2 7/9] blkdebug: Add pass-through write_zero and discard support

On 17.11.2016 21:14, Eric Blake wrote: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. Ideally, it would be nice to let these > operations also react to injected errors like

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

On 17.11.2016 21:14, Eric Blake wrote: > Use blkdebug's new geometry constraints to emulate setups that > have caused recent regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away requests >

Re: [Qemu-devel] [PATCH 16/25] tcg/i386: Handle ctz and clz opcodes

On 11/17/2016 11:09 PM, Bastian Koppelmann wrote: On 11/17/2016 08:59 PM, Richard Henderson wrote: On 11/17/2016 08:53 PM, Richard Henderson wrote: On 11/17/2016 05:50 PM, Bastian Koppelmann wrote: On 11/16/2016 08:25 PM, Richard Henderson wrote: + +OP_32_64(clz): +if

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

On 18.11.2016 00:01, Eric Blake wrote: > On 11/17/2016 04:26 PM, Max Reitz wrote: >> On 17.11.2016 21:13, Eric Blake wrote: >>> Discard is advisory, so rounding the requests to alignment >>> boundaries is never semantically wrong from the data that >>> the guest sees. But at least the Dell

Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

On 17.11.2016 21:14, Eric Blake wrote: > Make it easier to simulate the Dell Equallogic iSCSI with its Somehow I feel bad putting company and product names into commit messages... > unusual 15M preferred and maximum unmap and write zero sizing, > or to simulate Linux loopback block devices

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

On 11/17/2016 04:26 PM, Max Reitz wrote: > On 17.11.2016 21:13, Eric Blake wrote: >> Discard is advisory, so rounding the requests to alignment >> boundaries is never semantically wrong from the data that >> the guest sees. But at least the Dell Equallogic iSCSI SANs >> has an interesting

Re: [Qemu-devel] [PATCH v2 7/9] blkdebug: Add pass-through write_zero and discard support

On 17.11.2016 21:14, Eric Blake wrote: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. Ideally, it would be nice to let these > operations also react to injected errors like

Re: [Qemu-devel] [RFC v2 2/3] vhost-net: Add new MTU feature support

On Thu, Nov 17, 2016 at 10:58:06PM +0100, Maxime Coquelin wrote: > If VHOST_USER_F_MTU feature is negociated, vhost-net makes the negotiated > advised MTU available to virtio-net through a vhost_net_get_mtu() > call. > > Cc: Michael S. Tsirkin > Cc: Aaron Conole

Re: [Qemu-devel] [RFC v2 3/3] virtio-net: Add MTU feature support

On Thu, Nov 17, 2016 at 10:58:07PM +0100, Maxime Coquelin wrote: > If negotiated, virtio-net gets the advised MTU from vhost-net, > and provides it to the guest through a new virtio_net_config > entry. > > Cc: Michael S. Tsirkin > Cc: Aaron Conole

Re: [Qemu-devel] [PATCH v2 6/9] blkdebug: Sanity check block layer guarantees

On 17.11.2016 21:13, Eric Blake wrote: > Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment > any I/O to fit within device boundaries. Additionally, when using a > minimum alignment of 4k, we want to ensure the block layer does proper > read-modify-write rather than requesting

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

On Thu, Nov 17, 2016 at 10:58:04PM +0100, Maxime Coquelin wrote: > This series implements Virtio spec update from Aaron Conole which > defines a way for the host to expose its max MTU to the guest. > > Changes since RFC v1: > - > - Rebased on top of v2.8.0-rc0 (2.7.90) > -

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

On Thu, Nov 17, 2016 at 02:49:58PM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Michael S. Tsirkin" > > To: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, "alex williamson" , > >

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

On 17.11.2016 21:13, Eric Blake wrote: > Discard is advisory, so rounding the requests to alignment > boundaries is never semantically wrong from the data that > the guest sees. But at least the Dell Equallogic iSCSI SANs > has an interesting property that its advertised discard > alignment is

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

On Thu, Nov 17, 2016 at 02:25:15PM -0700, Alex Williamson wrote: > On Thu, 17 Nov 2016 02:16:12 +0530 > Kirti Wankhede wrote: > > > > Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++ > > Documentation/vfio-mediated-device.txt| 399 +++ > > MAINTAINERS

Re: [Qemu-devel] [PATCH 16/25] tcg/i386: Handle ctz and clz opcodes

On 11/17/2016 08:59 PM, Richard Henderson wrote: > On 11/17/2016 08:53 PM, Richard Henderson wrote: >> On 11/17/2016 05:50 PM, Bastian Koppelmann wrote: >>> On 11/16/2016 08:25 PM, Richard Henderson wrote: + +OP_32_64(clz): +if (const_args[2]) { +

[Qemu-devel] [RFC v2 3/3] virtio-net: Add MTU feature support

If negotiated, virtio-net gets the advised MTU from vhost-net, and provides it to the guest through a new virtio_net_config entry. Cc: Michael S. Tsirkin Cc: Aaron Conole --- hw/net/virtio-net.c

Re: [Qemu-devel] [PATCH v2 4/9] block: Return -ENOTSUP rather than assert on unaligned discards

On 17.11.2016 21:13, Eric Blake wrote: > Right now, the block layer rounds discard requests, so that > individual drivers are able to assert that discard requests > will never be unaligned. But there are some ISCSI devices > that track and coalesce multiple unaligned requests, turning it > into

[Qemu-devel] [RFC v2 1/3] vhost-user: Add new protocol feature MTU

This patch adds VHOST_USER_PROTOCOL_F_MTU protocol feature. If supported, QEMU sends VHOST_USER_GET_MTU request to the client, and expects a u64 reply containing the MTU advised for the guest. Cc: Michael S. Tsirkin Cc: Aaron Conole Signed-off-by: Maxime

[Qemu-devel] [RFC v2 2/3] vhost-net: Add new MTU feature support

If VHOST_USER_F_MTU feature is negociated, vhost-net makes the advised MTU available to virtio-net through a vhost_net_get_mtu() call. Cc: Michael S. Tsirkin Cc: Aaron Conole Signed-off-by: Maxime Coquelin --- hw/net/vhost_net.c

[Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

This series implements Virtio spec update from Aaron Conole which defines a way for the host to expose its max MTU to the guest. Changes since RFC v1: - - Rebased on top of v2.8.0-rc0 (2.7.90) - Write MTU unconditionnaly in netcfg to avoid memory leak (Paolo) - Add host_mtu

Re: [Qemu-devel] [PATCH v3 3/9] block: Let write zeroes fallback work even with small max_transfer

On 17.11.2016 21:13, Eric Blake wrote: > Commit 443668ca rewrote the write_zeroes logic to guarantee that > an unaligned request never crosses a cluster boundary. But > in the rewrite, the new code assumed that at most one iteration > would be needed to get to an alignment boundary. > > However,

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

On Thu, 17 Nov 2016 02:16:12 +0530 Kirti Wankhede wrote: > > Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++ > Documentation/vfio-mediated-device.txt| 399 +++ > MAINTAINERS |9 + > drivers/vfio/Kconfig

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Inform block layer about discard boundaries

On 17.11.2016 21:13, Eric Blake wrote: > At the qcow2 layer, discard is only possible on a per-cluster > basis; at the moment, qcow2 silently rounds any unaligned > requests to this granularity. However, an upcoming patch will > fix a regression in the block layer ignoring too much of an >

Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

On 11/17/2016 03:10 PM, Max Reitz wrote: > On 17.11.2016 21:13, Eric Blake wrote: >> Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, >> but forgot to inform the block layer that FUA unmapping of zeroes is >> supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, >>

Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

On 17.11.2016 21:13, Eric Blake wrote: > Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, > but forgot to inform the block layer that FUA unmapping of zeroes is > supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, > the block layer will always insist on the NBD

Re: [Qemu-devel] [PATCH] tests/postcopy: Use KVM on ppc64 only if it is KVM-HV

On 16/11/2016 15:17, Greg Kurz wrote: > On Wed, 16 Nov 2016 14:17:47 +0100 > Thomas Huth wrote: > >> On 16.11.2016 13:37, Greg Kurz wrote: >>> On Wed, 16 Nov 2016 12:24:50 + >>> "Dr. David Alan Gilbert" wrote: >>> * Greg Kurz (gr...@kaod.org)

[Qemu-devel] [PATCH v2 7/9] blkdebug: Add pass-through write_zero and discard support

In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. Ideally, it would be nice to let these operations also react to injected errors like read/write/flush, but it is not trivial to turn bdrv_aio

[Qemu-devel] [PATCH v2 6/9] blkdebug: Sanity check block layer guarantees

Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that

[Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away requests that were not aligned to power-of-two boundaries.

[Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

Make it easier to simulate the Dell Equallogic iSCSI with its unusual 15M preferred and maximum unmap and write zero sizing, or to simulate Linux loopback block devices enforcing a small max_transfer of 64k, by allowing blkdebug to wrap any other device with further restrictions on various

[Qemu-devel] [PATCH v2 2/9] qcow2: Inform block layer about discard boundaries

At the qcow2 layer, discard is only possible on a per-cluster basis; at the moment, qcow2 silently rounds any unaligned requests to this granularity. However, an upcoming patch will fix a regression in the block layer ignoring too much of an unaligned discard request, by changing the block layer

[Qemu-devel] [PATCH v2 4/9] block: Return -ENOTSUP rather than assert on unaligned discards

Right now, the block layer rounds discard requests, so that individual drivers are able to assert that discard requests will never be unaligned. But there are some ISCSI devices that track and coalesce multiple unaligned requests, turning it into an actual discard if the requests eventually cover

[Qemu-devel] [PATCH v2 for-2.8* 0/9] Fix block regressions, add blkdebug tests

The first 5 patches are candidates for inclusion in 2.8, since they fix regressions and/or bugs exposed by the second half. The last 4 patches are a new feature in blkdebug, and as such, probably belong better in 2.9. However, I wrote the patches by swapping the order (last four patches first,

[Qemu-devel] [PATCH v3 3/9] block: Let write zeroes fallback work even with small max_transfer

Commit 443668ca rewrote the write_zeroes logic to guarantee that an unaligned request never crosses a cluster boundary. But in the rewrite, the new code assumed that at most one iteration would be needed to get to an alignment boundary. However, it is easy to trigger an assertion failure: the

[Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, but forgot to inform the block layer that FUA unmapping of zeroes is supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, the block layer will always insist on the NBD layer passing NBD_CMD_FLAG_NO_HOLE, resulting in

[Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

Discard is advisory, so rounding the requests to alignment boundaries is never semantically wrong from the data that the guest sees. But at least the Dell Equallogic iSCSI SANs has an interesting property that its advertised discard alignment is 15M, yet documents that discarding a sequence of 1M

Re: [Qemu-devel] [PATCH 16/25] tcg/i386: Handle ctz and clz opcodes

On 11/17/2016 08:53 PM, Richard Henderson wrote: On 11/17/2016 05:50 PM, Bastian Koppelmann wrote: On 11/16/2016 08:25 PM, Richard Henderson wrote: + +OP_32_64(clz): +if (const_args[2]) { +tcg_debug_assert(have_bmi1); +tcg_debug_assert(args[2] == (rexw ? 64

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

On Thu, Nov 17, 2016 at 05:15:13PM -0200, Marcelo Tosatti wrote: > On Thu, Nov 17, 2016 at 04:16:09PM -0200, Eduardo Habkost wrote: > > On Thu, Nov 17, 2016 at 03:15:35PM -0200, Marcelo Tosatti wrote: > > > On Thu, Nov 17, 2016 at 12:11:26PM -0200, Eduardo Habkost wrote: > > > > On Thu, Nov 17,

Re: [Qemu-devel] [PATCH 16/25] tcg/i386: Handle ctz and clz opcodes

On 11/17/2016 05:50 PM, Bastian Koppelmann wrote: On 11/16/2016 08:25 PM, Richard Henderson wrote: + +OP_32_64(clz): +if (const_args[2]) { +tcg_debug_assert(have_bmi1); +tcg_debug_assert(args[2] == (rexw ? 64 : 32)); +tcg_out_modrm(s, OPC_LZCNT +

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

- Original Message - > From: "Michael S. Tsirkin" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "alex williamson" , > borntrae...@de.ibm.com, fel...@nutanix.com > Sent: Thursday, November 17, 2016 6:55:50 PM >

Re: [Qemu-devel] [PATCH v5 01/17] qapi: improve device_add schema

On 11/17/2016 09:54 AM, Marc-André Lureau wrote: > 'device_add' is still incomplete for now, but we can fix a few > arguments: > - 'bus' is a common argument, regardless of the device > - 'id' is an optionnal argument s/optionnal/optional/ > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] ppc: BOOK3E: nothing should be done when MSR:PR is set

On Thu, 2016-11-17 at 14:49 +0100, Vladimir Svoboda wrote: > The server architecture (BOOK3S) specifies that any instruction that > sets MSR:PR will also set MSR:EE, IR and DR. > However there is no such behavior specification for the embedded > architecture (BOOK3E). > > Signed-off-by: Vladimir

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

On Thu, Nov 17, 2016 at 04:16:09PM -0200, Eduardo Habkost wrote: > On Thu, Nov 17, 2016 at 03:15:35PM -0200, Marcelo Tosatti wrote: > > On Thu, Nov 17, 2016 at 12:11:26PM -0200, Eduardo Habkost wrote: > > > On Thu, Nov 17, 2016 at 11:24:13AM -0200, Marcelo Tosatti wrote: > > > > Check for

Re: [Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

On 11/17/16 18:46, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 02:16:35PM +0100, Laszlo Ersek wrote: >> On 11/16/16 21:27, Michael S. Tsirkin wrote: >>> On Wed, Nov 16, 2016 at 07:03:27PM +0100, Laszlo Ersek wrote: On 11/16/16 15:05, Paolo Bonzini wrote: > > > On

[Qemu-devel] [kvm-unit-tests PATCH 0/4] kvm-unit-tests: add first GIC MMIO tests

The GIC spec mandates certain constraints on how to acccess the MMIO mapped registers, both in terms of which registers are available and also in terms of which bits within a register should be masked, for instance. Since we went through some lengths in the KVM emulation to implement this, it's

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

On Thu, Nov 17, 2016 at 03:15:35PM -0200, Marcelo Tosatti wrote: > On Thu, Nov 17, 2016 at 12:11:26PM -0200, Eduardo Habkost wrote: > > On Thu, Nov 17, 2016 at 11:24:13AM -0200, Marcelo Tosatti wrote: > > > Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which > > > indicates that

Re: [Qemu-devel] [PATCH v5 10/17] qapi: improve TransactionAction doc

Marc-André Lureau writes: > TransactionAction is a flat union, document 'type' versions > exhaustively, and sort list. "and sort the members". > > Signed-off-by: Marc-André Lureau With that Reviewed-by: Markus Armbruster

[Qemu-devel] [kvm-unit-tests PATCH 3/4] arm/arm64: GICv2: add GICD_ITARGETSR testing

Some tests for the ITARGETS registers. Bits corresponding to non-existent CPUs must be RAZ/WI. These registers must be byte-accessible, also check that accesses beyond the implemented IRQ limit are actually read-as-zero/write-ignore. Signed-off-by: Andre Przywara ---

Re: [Qemu-devel] [PATCH v5 08/17] qapi: add missing colon-ending for section name

Marc-André Lureau writes: > The documentation parser we are going to add expects a section name to > end with ':', otherwise the comment is treated as free-form text body. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus

Re: [Qemu-devel] [qemu patch V2 2/2] kvmclock: reduce kvmclock difference on migration

On Thu, Nov 17, 2016 at 02:30:52PM -0200, Marcelo Tosatti wrote: > On Thu, Nov 17, 2016 at 03:15:03PM +0100, Paolo Bonzini wrote: > > On 17/11/2016 15:11, Eduardo Habkost wrote: > > > On Thu, Nov 17, 2016 at 11:24:13AM -0200, Marcelo Tosatti wrote: [...] > > > What exactly ensures

Re: [Qemu-devel] [PATCH v5 06/17] qapi: fix various symbols mismatch in documentation

Marc-André Lureau writes: > There are various mismatch: > - invalid symbols > - section and member symbols mismatch > - enum or union values vs 'type' > > The documentation parser catches all these cases. > > Signed-off-by: Marc-André Lureau

[Qemu-devel] [kvm-unit-tests PATCH 2/4] arm/arm64: GICv2: add GICD_IPRIORITYR testing

Some tests for the IPRIORITY registers. The significant number of bits is IMPLEMENTATION DEFINED, but should be the same for every IRQ. Also these registers must be byte-accessible. Check that accesses beyond the implemented IRQ limit are actually read-as-zero/write-ignore. Signed-off-by: Andre

Re: [Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

On Thu, Nov 17, 2016 at 02:16:35PM +0100, Laszlo Ersek wrote: > On 11/16/16 21:27, Michael S. Tsirkin wrote: > > On Wed, Nov 16, 2016 at 07:03:27PM +0100, Laszlo Ersek wrote: > >> On 11/16/16 15:05, Paolo Bonzini wrote: > >>> > >>> > >>> On 16/11/2016 14:18, Michael S. Tsirkin wrote: > > - we

[Qemu-devel] [kvm-unit-tests PATCH 4/4] arm/arm64: GICv3: add TYPER test

Add a simple test for the GICv3 TYPER test, which does only one basic check to ensure we have actually enough interrupt IDs if we support LPIs. Allow a GICv3 guest to do the common MMIO checks as well, where the register semantics are shared with a GICv2. Signed-off-by: Andre Przywara

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

On Wed, Nov 16, 2016 at 07:05:50PM +0100, Paolo Bonzini wrote: > @@ -1318,10 +1318,18 @@ void virtio_del_queue(VirtIODevice *vdev, int n) > vdev->vq[n].vring.num_default = 0; > } > > +static void virtio_set_isr(VirtIODevice *vdev, int value) > +{ > +uint8_t old = atomic_read(>isr); > +

Re: [Qemu-devel] [PATCH v5 05/17] qapi: fix missing symbol @prefix

Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster

[Qemu-devel] [kvm-unit-tests PATCH 1/4] arm/arm64: GIC: basic GICv2 MMIO tests

This adds an MMIO subtest to the GIC test. It accesses some generic GICv2 registers and does some sanity tests, like checking for some of them being read-only. Signed-off-by: Andre Przywara --- arm/gic.c | 99

Re: [Qemu-devel] [PATCH v5 09/17] qapi: add some sections in docs

Marc-André Lureau writes: > Add some more section titles to organize the produced documents. Either move this after the doc generator gets added, or say something like "to organize the documentation we're going to generate". > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v5 07/17] qapi: use one symbol per line

Marc-André Lureau writes: > The documentation parser we are going to add only handles a single > symbol per line. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

On Thu, Nov 17, 2016 at 01:27:49PM +, Stefan Hajnoczi wrote: > On Thu, Nov 17, 2016 at 12:17:57AM +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 16, 2016 at 09:53:06PM +, Stefan Hajnoczi wrote: > > > Disabling notifications during virtqueue processing reduces the number of > > > exits.

Re: [Qemu-devel] [PATCH v5 04/17] qapi: fix schema symbol sections

Marc-André Lureau writes: > According to docs/qapi-code-gen.txt, there needs to be '##' to start a > and end a symbol section, that's also what the documentation parser > expects. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v5 02/17] qga/schema: fix double-return in doc

Marc-André Lureau writes: > guest-get-memory-block-info documentation should have only one > "Returns:". > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v5 01/17] qapi: improve device_add schema

Marc-André Lureau writes: > 'device_add' is still incomplete for now, but we can fix a few > arguments: > - 'bus' is a common argument, regardless of the device > - 'id' is an optionnal argument > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v4 03/15] qga/schema: improve guest-set-vcpus Returns: section

Markus Armbruster writes: > Marc-André Lureau writes: > >> The documentation parser we are going to add finishes a section after an >> empty line. > > Is this still true? Wrong thread, please ignore.

Re: [Qemu-devel] [PATCH v5 03/17] qga/schema: improve guest-set-vcpus Returns: section

Marc-André Lureau writes: > The documentation parser we are going to add finishes a section after an > empty line. Is this still true? > Fix the Returns: section of guest-set-vcpus, and itemize the possible > return values. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v4 05/15] qapi: fix missing symbol @prefix

Markus Armbruster writes: > Marc-André Lureau writes: > >> Signed-off-by: Marc-André Lureau >> Reviewed-by: Eric Blake > > Reviewed-by: Markus Armbruster Wrong thread, please

Re: [Qemu-devel] [PATCH v4 06/15] qapi: fix various symbols mismatch in documentation

Markus Armbruster writes: > Marc-André Lureau writes: > >> There are various mismatch: >> - invalid symbols >> - section and member symbols mismatch >> - enum or union values vs 'type' >> >> The documentation parser catches all these cases. >> >>

Re: [Qemu-devel] [PATCH v4 02/15] qga/schema: fix double-return in doc

Markus Armbruster writes: > Marc-André Lureau writes: > >> guest-get-memory-block-info documentation should have only one >> "Returns:". >> >> Signed-off-by: Marc-André Lureau >> Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v4 04/15] qapi: fix schema symbol sections

Markus Armbruster writes: > Marc-André Lureau writes: > >> According to docs/qapi-code-gen.txt, there needs to be '##' to start a >> and end a symbol section, that's also what the documentation parser >> expects. >> >> Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH v4 01/15] qapi: improve device_add schema

Markus Armbruster writes: > Marc-André Lureau writes: > >> 'device_add' is still incomplete for now, but we can fix a few >> arguments: >> - 'bus' is a common argument, regardless of the device >> - 'id' is an optionnal argument >> >>

Re: [Qemu-devel] QMP event on reboot when -no-reboot is set

On 11/17/2016 03:17 AM, Dirk Braunschweiger wrote: On 2016-11-16 17:29, John Snow wrote: On 11/16/2016 09:01 AM, Dirk Braunschweiger wrote: Hey Guys, I want to get a qmp event when the qemu does a shutdown due to the -no-reboot flag. Looking at the code I realized that the -no-reboot flag

Re: [Qemu-devel] [PATCH v4 06/15] qapi: fix various symbols mismatch in documentation

Marc-André Lureau writes: > There are various mismatch: > - invalid symbols > - section and member symbols mismatch > - enum or union values vs 'type' > > The documentation parser catches all these cases. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

On Thu, Nov 17, 2016 at 05:49:36PM +0800, Yuanhan Liu wrote: > On Thu, Nov 17, 2016 at 09:47:09AM +0100, Maxime Coquelin wrote: > > > > > > On 11/17/2016 09:29 AM, Yuanhan Liu wrote: > > >As usaual, sorry for late response :/ > > > > > >On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S.

Re: [Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

Hello David, Thank you for your review. I have just one question below, could you help me to address it please? Thank you! Ziviani On Thu, Nov 17, 2016 at 02:42:43PM +1100, David Gibson wrote: > On Wed, Nov 16, 2016 at 06:07:27PM -0200, Jose Ricardo Ziviani wrote: > > bcdcfsq.: Decimal convert

Re: [Qemu-devel] [PATCH v4 04/15] qapi: fix schema symbol sections

Marc-André Lureau writes: > According to docs/qapi-code-gen.txt, there needs to be '##' to start a > and end a symbol section, that's also what the documentation parser > expects. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v4 05/15] qapi: fix missing symbol @prefix

Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster

  1   2   3   >