Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On 11/30/16 16:41, Eric Blake wrote: > On 11/30/2016 04:08 AM, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. (In >> older releases, the -O option had to be specified on the command line, >> or in aliases, for the same effect, which was quite

[Qemu-devel] [PATCH 23/36] qtest: Avoid dynamic JSON in virtio-blk-test

As argued elsewhere, it's less code to maintain if we convert from a dynamic string passed to qobject_from_jsonv() to instead use a hand-built QDict. Signed-off-by: Eric Blake --- tests/virtio-blk-test.c | 22 -- 1 file changed, 16 insertions(+), 6

[Qemu-devel] [PATCH 24/36] qtest: Drop unused qmp_fdv()

Now that no more clients are passing variadic arguments, we can simplify the testsuite by requiring that qmp_fd() be given the final string to pass over the wire, rather than a dynamic JSON string that has to be parsed into QObject and back out again. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH 28/36] qapi: Factor out JSON string escaping

Pull out a new qstring_append_json_string() helper, so that all JSON output producers can use the same output escaping rules. While it appears that vmstate's use of the simpler qjson.c formatter is not currently encountering any string that needs escapes to be valid JSON, it is better to be safe

Re: [Qemu-devel] [PATCH 00/36] Rip out dynamic JSON parsing

On 11/30/2016 01:44 PM, Eric Blake wrote: > Followup series to conversation about PRId64 and MacOS: > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg04226.html > And I meant to add: Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git qapi-dynamic-json-v1 on top of

[Qemu-devel] [PATCH 17/36] qtest: Avoid dynamic JSON in ahci-test

As argued elsewhere, it's less code to maintain if we convert from a dynamic string passed to qobject_from_jsonv() to instead use a hand-built QDict. Rather than build up a QDict by manual qdict_put*() calls, we can let QAPI do the work for us. The result is more lines of code to initialize the

[Qemu-devel] [PATCH 19/36] qtest: Change qmp_discard_response() to drop varargs

Now that no more clients are passing variadic arguments, we can update the contract to state that we will be using normal JSON parsing rather than dynamic JSON for any client using this wrapper. Signed-off-by: Eric Blake --- tests/libqtest.h | 18 --

[Qemu-devel] [PATCH 22/36] qtest: Avoid dynamic JSON in pc-cpu-test

As argued elsewhere, it's less code to maintain if we convert from a dynamic string passed to qobject_from_jsonv() to instead use a hand-built QDict. Signed-off-by: Eric Blake --- tests/pc-cpu-test.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 06/36] qobject-input-visitor: Avoid dynamic JSON in tests

As argued elsewhere, we want to get rid of the pseudo-printf dynamic JSON parsing of qobject_from_jsonv(). In the qobject-input visitor tests, it is trivial to convert to using the direct qobject_from_json() or a hand-built QObject. While at it, wrap some long lines noticed while auditing

[Qemu-devel] [PATCH 30/36] qtest: Avoid dynamic JSON in qmp_fd_sendv()

The only format specifier left in any client of qmp() and friends is %s. Rather than having to make our JSON parser support varargs, and use a conversion from string to QObject and back to string, we can instead just directly build the string and substitute %s ourselves. With this, the final

[Qemu-devel] [PATCH 20/36] qtest: Avoid dynamic JSON in device-introspect-test

As argued elsewhere, it's less code to maintain if we convert from a dynamic string passed to qobject_from_jsonv() to instead use a hand-built QDict. Signed-off-by: Eric Blake --- tests/device-introspect-test.c | 15 +-- 1 file changed, 9 insertions(+), 6

[Qemu-devel] [PATCH 12/36] nbd: Use simpler QAPI_TO_QOBJECT()

Use the new macro to avoid some boilerplate. Signed-off-by: Eric Blake --- block/nbd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 334748d..a1dfd86 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -503,7 +503,6 @@

[Qemu-devel] [PATCH 14/36] qapi: Use simpler QAPI_TO_QOBJECT()

Use the new macro to avoid some boilerplate. Signed-off-by: Eric Blake --- block/qapi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index a62e862..802a372 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -691,15 +691,13

[Qemu-devel] [PATCH 25/36] qtest: Change qmp_fd_send() to drop varags

No external clients were using qmp_fd_sendv(). Making it static lets us refactor the public qmp_fd_send() to take the final string to send over the wire, rather than a dynamic JSON string that has to be parsed into QObject and back out again. Note that the refactoring switches roles: previously,

[Qemu-devel] [PATCH 13/36] nfs: Use simpler QAPI_TO_QOBJECT()

Use the new macro to avoid some boilerplate. Signed-off-by: Eric Blake --- block/nfs.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index f8ba5cc..71cc746 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -766,7 +766,6 @@

[Qemu-devel] [PATCH 26/36] qtest: Drop unused qtest_qmp_async()

There were no external clients of qtest_qmp_async(); delete this wrapper for one less varargs call in the chain. Signed-off-by: Eric Blake --- tests/libqtest.h | 19 --- tests/libqtest.c | 18 ++ 2 files changed, 2 insertions(+), 35

[Qemu-devel] [PATCH 09/36] qtest: Add a new helper qmp_cmd() and friends

The qobject_from_jsonv() function implements a pseudo-printf language for creating a QObject through the extension of dynamic JSON; however, it is hard-coded to only parse a subset of formats understood by -Wformat and is not a straight synonym to bare printf(). During a recent cleanup due to

[Qemu-devel] [PATCH 16/36] qapi: Promote blockdev-change-medium arguments to QAPI type

Having a named rather than anonymous C type will make it easier to improve the testsuite in a later patch. No semantic change, to any of the existing code or to the introspection output. Signed-off-by: Eric Blake --- qapi/block-core.json | 11 ++- 1 file changed, 10

[Qemu-devel] [PATCH 10/36] qtest: Avoid dynamic JSON in libqtest

The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject through the extension of dynamic JSON; however, it is hard-coded to only parse a subset of formats understood by -Wformat and is not a straight synonym to bare printf(). During a recent cleanup due to

[Qemu-devel] [PATCH 01/36] pci: Use struct instead of QDict to pass back parameters

It's simpler to just use a C struct than it is to bundle things into a QDict in one function just to pull them back out in the caller. Plus, doing this gets rid of one more user of dynamic JSON through qobject_from_jsonf(). Signed-off-by: Eric Blake --- hw/pci/pcie_aer.c |

[Qemu-devel] [PATCH 11/36] qapi: Add QAPI_TO_QOBJECT() convenience macro

We have several callers that want to convert a QAPI C type into a QObject; right now all of them have to copy the same boilerplate of creating a visitor. A convenience macro makes this paradigm easier to type. Signed-off-by: Eric Blake ---

[Qemu-devel] [PATCH 04/36] qmp-event: Avoid dynamic JSON

The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject through the extension of dynamic JSON; however, it is hard-coded to only parse a subset of formats understood by -Wformat and is not a straight synonym to bare printf(). During a recent cleanup due to

[Qemu-devel] [PATCH 05/36] qmp-dispatch: Avoid dynamic JSON

The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject through the extension of dynamic JSON; however, it is hard-coded to only parse a subset of formats understood by -Wformat and is not a straight synonym to bare printf(). During a recent cleanup due to

[Qemu-devel] [PATCH 08/36] test-qga: Actually test 0xff sync bytes

Commit 62c39b3 introduced test-qga, and at face value, appears to be testing the 'guest-sync' behavior that is recommended for guests in sending 0xff to QGA to force the parser to reset. But this aspect of the test has never actually done anything: the qmp_fd() call chain converts its string

[Qemu-devel] [PATCH 03/36] qlist: Add convenience helpers for wrapped appends

Similar to the qdict additions of the previous patch, although this time there are not as many clients. Signed-off-by: Eric Blake --- include/qapi/qmp/qlist.h | 8 tests/check-qdict.c | 10 +- tests/check-qlist.c | 2 +- 3 files changed, 14

[Qemu-devel] [PATCH 07/36] fdc-test: Avoid deprecated 'change' command

Use the preferred blockdev-change-medium command instead. Signed-off-by: Eric Blake --- tests/fdc-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 738c6b4..f5ff68d 100644 --- a/tests/fdc-test.c +++

[Qemu-devel] [PATCH 00/36] Rip out dynamic JSON parsing

Followup series to conversation about PRId64 and MacOS: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg04226.html We have relatively few users of dynamic JSON (the ability to pass varargs plus a format string with % sequences embedded in the JSON, to create a final QObject dynamically).

Re: [Qemu-devel] [PATCH v3 00/11] tcg mips64 and mips r6 improvements

On 2016-12-01 02:33, Jin Guojie wrote: > Thanks for Aurelien's first test results. > I submitted v4 patch as a feedback to Richard's and your review comments on > v3. > Since v4 contains functional code change, should we do this test again on v4? > Really sorry for this burden. Oops sorry, I

Re: [Qemu-devel] [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info

On 11/30/2016 12:43 AM, Liang Li wrote: > +static void send_unused_pages_info(struct virtio_balloon *vb, > + unsigned long req_id) > +{ > + struct scatterlist sg_in; > + unsigned long pos = 0; > + struct virtqueue *vq = vb->req_vq; > + struct

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

Yesterday I successfully got in touch with a Debian developer from imgtec. Welcome Su Yunqiang. V4 patch can be tested on mips64 be hosts now. The following guests on a mips64 big-endian host is OK: - Debian i386 with qemu-system-i386 - Debian i386 with qemu-system-x86_64 However, Debian

Re: [Qemu-devel] [PATCH v3 00/11] tcg mips64 and mips r6 improvements

Thanks for Aurelien's first test results. I submitted v4 patch as a feedback to Richard's and your review comments on v3. Since v4 contains functional code change, should we do this test again on v4? Really sorry for this burden. Jin Guojie ---Original--- From: "Aurelien

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On Wed, Nov 30, 2016 at 04:26:14PM +0100, Laszlo Ersek wrote: > On 11/30/16 16:08, Michael S. Tsirkin wrote: > > On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: > >> Recent git releases support the diff.orderFile permanent setting. (In > >> older releases, the -O option had to be

Re: [Qemu-devel] [RFC for-2.9 00/11] Move target-* CPU file into a target/ folder

On 11/30/2016 04:01 AM, Christian Borntraeger wrote: >> So please provide some feedback: Is this a good idea? Or do you >> consider this rather just as unnecessary code churn instead? > > Given the low amount of manpower for the stable work, I think this will > cause more harm than it helps. So

Re: [Qemu-devel] [RFC for-2.9 00/11] Move target-* CPU file into a target/ folder

On 11/30/2016 11:37 AM, Richard Henderson wrote: > On 11/30/2016 01:47 AM, Thomas Huth wrote: >> The first patch is the most important one here, it prepares the >> build system to be able to deal with both, target-xxx and target/xxx >> folders. Once that has been applied, each target architecture

Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

Richard Henderson writes: > On 11/30/2016 08:55 AM, Alex Bennée wrote: >> >> Nikunj A Dadhania writes: >> >>> Hi, >>> >>> I was writing one instruction and hit following issue: >>> >>> [snip]/qemu/tcg/tcg.c:2039: tcg fatal error >>> qemu-ppc64le:

Re: [Qemu-devel] [PATCH v4 10/10] tcg-mips: Adjust qemu_ld/st for mips64

On 2016-11-30 09:42, Richard Henderson wrote: > On 11/30/2016 09:22 AM, Aurelien Jarno wrote: > > On 2016-11-29 14:07, Jin Guojie wrote: > >> @@ -1312,7 +1340,12 @@ static void tcg_out_qemu_ld_slow_path(TCGContext > >> *s, TCGLabelQemuLdst *l) > >> reloc_pc16(s->code_ptr, l->raddr); > >>

Re: [Qemu-devel] [PATCH v4 10/10] tcg-mips: Adjust qemu_ld/st for mips64

On 11/30/2016 09:22 AM, Aurelien Jarno wrote: > On 2016-11-29 14:07, Jin Guojie wrote: >> @@ -1312,7 +1340,12 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, >> TCGLabelQemuLdst *l) >> reloc_pc16(s->code_ptr, l->raddr); >> tcg_out_opc_br(s, OPC_BEQ, TCG_REG_ZERO, TCG_REG_ZERO);

Re: [Qemu-devel] Linux kernel polling for QEMU

On 11/29/2016 12:45 PM, Stefan Hajnoczi wrote: On Mon, Nov 28, 2016 at 04:41:13PM +0100, Paolo Bonzini wrote: On 28/11/2016 16:29, Stefan Hajnoczi wrote: Thanks for sharing the link. I'll let you know before embarking on an effort to make epoll support busy_loop. At the moment I'm still

Re: [Qemu-devel] [RFC for-2.9 00/11] Move target-* CPU file into a target/ folder

On 11/30/2016 01:47 AM, Thomas Huth wrote: > The first patch is the most important one here, it prepares the > build system to be able to deal with both, target-xxx and target/xxx > folders. Once that has been applied, each target architecture > could be moved to the target/ folder when it is

Re: [Qemu-devel] [PATCH v4 10/10] tcg-mips: Adjust qemu_ld/st for mips64

On 2016-11-29 14:07, Jin Guojie wrote: > @@ -1312,7 +1340,12 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, > TCGLabelQemuLdst *l) > reloc_pc16(s->code_ptr, l->raddr); > tcg_out_opc_br(s, OPC_BEQ, TCG_REG_ZERO, TCG_REG_ZERO); > /* delay slot */ > -tcg_out_mov(s,

Re: [Qemu-devel] [PATCH v3 00/11] tcg mips64 and mips r6 improvements

On 2016-11-25 11:31, Jin Guojie wrote: > Changes since v2: > * Update against master(v2.8.0-rc1) > * Tested on Loongson as mips32r2(el) and mips64r2(el) hosts. > Loongson only implements little-endian mips32/mips64 ISA. > * Fully work for 32-bit and 64-bit guests. > Fix two

Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

On 11/29/2016 11:56 PM, Nikunj A Dadhania wrote: > Lets bring full example here. > > TCGv nb = tcg_temp_new(); > tcg_gen_andi_tl(nb, cpu_gpr[rB(ctx->opcode)], 0xFF); > tcg_gen_brcondi_tl(TCG_COND_EQ, nb, 0, l1); > > /* do something */ > gen_set_access_type(ctx, ACCESS_INT); >

Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

On 11/30/2016 08:55 AM, Alex Bennée wrote: > > Nikunj A Dadhania writes: > >> Hi, >> >> I was writing one instruction and hit following issue: >> >> [snip]/qemu/tcg/tcg.c:2039: tcg fatal error >> qemu-ppc64le: [snip]/qemu/translate-all.c:175: tb_lock: Assertion >>

Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

Nikunj A Dadhania writes: > Hi, > > I was writing one instruction and hit following issue: > > [snip]/qemu/tcg/tcg.c:2039: tcg fatal error > qemu-ppc64le: [snip]/qemu/translate-all.c:175: tb_lock: Assertion > `!have_tb_lock' failed. > Segmentation fault (core dumped)

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

On 30 November 2016 at 16:23, Vijay Kilari wrote: > On Mon, Nov 28, 2016 at 10:05 PM, Peter Maydell > wrote: >> Still I would prefer it if we did this with the same >> mechanism for both TCG and KVM. A generic mechanism for >> "let the CPU reset

[Qemu-devel] [Bug 1027525] Re: Unable to insert cd media located on ro nfs mount

Can you still reproduce this problem with the latest version of QEMU? If so, could you please refresh your patch and send it to the qemu-devel mailing list? (we do not accept patches from the bug tracker) ** Changed in: qemu Status: New => Incomplete -- You received this bug notification

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

So can we close this bug now, or is there still something left to do here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902413 Title:

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

If I've got comment 27 right, the issue has also been fixed upstream, so I'm setting the status now to "Fix released". If there's still something left to do here, feel free to change it again. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because

[Qemu-devel] [PATCH] target-mips: fix bad shifts in {dextp|dextpdp}

Fixed issues in the MIPSDSP64 instructions dextp and dextpdp. Shifting can go out of 32 bit range. https://bugs.launchpad.net/qemu/+bug/1631625 Reported-by: Thomas Huth Reported-by: Jia Liu Signed-off-by: Yongbok Kim ---

Re: [Qemu-devel] [PATCH for-2.9 26/30] aspeed/smc: use flash model option

On 11/29/2016 04:44 PM, Cédric Le Goater wrote: > so that we can change the flash model from the command line. After kevin input on this topic, we should drop patch 25 and 26. Thanks, C. > Signed-off-by: Cédric Le Goater > Reviewed-by: Joel Stanley > --- >

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

On Mon, Nov 28, 2016 at 10:05 PM, Peter Maydell wrote: > On 28 November 2016 at 16:01, Vijay Kilari wrote: >> On Mon, Nov 28, 2016 at 6:31 PM, Peter Maydell >> wrote: >>> On 23 November 2016 at 12:39,

Re: [Qemu-devel] [PATCH v5 09/17] qapi: add some sections in docs

Hi - Original Message - > Second thoughts... > > Marc-André Lureau writes: > > > Add some more section titles to organize the produced documents. > > > > Signed-off-by: Marc-André Lureau > > --- > > qapi-schema.json | 4

Re: [Qemu-devel] [PATCH v5 13/17] qapi: add qapi2texi script

Marc-André Lureau writes: > As the name suggests, the qapi2texi script converts JSON QAPI > description into a texi file suitable for different target > formats (info/man/txt/pdf/html...). > > It parses the following kind of blocks: > > Free-form: > > ## > # =

Re: [Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

Am 30.11.2016 um 16:09 hat Cédric Le Goater geschrieben: > On 11/29/2016 07:08 PM, Kevin Wolf wrote: > > Am 29.11.2016 um 18:30 hat Cédric Le Goater geschrieben: > >> On 11/29/2016 04:44 PM, Cédric Le Goater wrote: > >>> This could be used to define the flash model to use on some boards > >>>

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On 11/30/2016 04:08 AM, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From > git-diff(1): > >-O >

[Qemu-devel] QEMU 2.8 release approaching

Dear QEMU community, QEMU 2.8.0-rc3 will be tagged on December 6th. If there are no pending issues -rc3 will become the QEMU 2.8 final release on December 13th. Let's make this tag a good one! If you are currently looking into pending issues or have bug fixes needing attention from maintainers,

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On Wed, Nov 30, 2016 at 10:08 AM, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From >

Re: [Qemu-devel] [PATCH v5 09/17] qapi: add some sections in docs

Second thoughts... Marc-André Lureau writes: > Add some more section titles to organize the produced documents. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 4 > qapi/block-core.json | 6 -- >

Re: [Qemu-devel] [PATCH v3 0/2] Qemu: gdbstub: fix vCont

Hi Paolo, I was wondering if you had seen this new version of the vCont patchset, which I sent around last month -- is there any more work to do or things to fix? or is it going to be upstreamed after 2.8? (btw I just rebased it on 2.8.0-rc2 and it applied cleanly) please don't keep me in

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On 11/30/16 13:29, Gerd Hoffmann wrote: > Hi, > >>> Want sent a patch? >> >> What file for? :) > > create something like scripts/git.orderfile, so people have just to run > "git config diff.orderfile scripts/git.orderfile" to enable it, and we > can refine the config without having everybody

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On 11/30/16 16:08, Michael S. Tsirkin wrote: > On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. (In >> older releases, the -O option had to be specified on the command line, >> or in aliases, for the same effect,

[Qemu-devel] [Bug 1163065] Re: target-i386 cpu_get_phys_page_debug checks bits in wrong order

Can you still reproduce this problem with the latest version of QEMU? If so, could you please send a refreshed patch to the qemu-devel mailing list? We do not pick up patches from the bug tracker. Thanks! ** Changed in: qemu Status: New => Incomplete -- You received this bug notification

[Qemu-devel] [Bug 1336194] Re: Errors reporting in do_delvm caused a crash

Looks like this had been fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=ba2b22888c43f ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Linux kernel polling for QEMU

On Wed, Nov 30, 2016 at 06:50:09PM +0800, Fam Zheng wrote: > On Wed, 11/30 09:38, Stefan Hajnoczi wrote: > > On Wed, Nov 30, 2016 at 01:42:14PM +0800, Fam Zheng wrote: > > > On Tue, 11/29 20:43, Stefan Hajnoczi wrote: > > > > On Tue, Nov 29, 2016 at 1:24 PM, Fam Zheng wrote: > >

Re: [Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

On 11/29/2016 07:08 PM, Kevin Wolf wrote: > Am 29.11.2016 um 18:30 hat Cédric Le Goater geschrieben: >> On 11/29/2016 04:44 PM, Cédric Le Goater wrote: >>> This could be used to define the flash model to use on some boards >>> definitions. >> >> As this patch was part of a larger set, I did not

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On Wed, Nov 30, 2016 at 11:08:27AM +0100, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From > git-diff(1): >

[Qemu-devel] [Bug 1186935] Re: [1.5] QEMU monitor gets overlapped by GTK menu bar

Can you still reproduce this issue with the latest version of QEMU / the latest version of gtk? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Linux kernel polling for QEMU

On 30/11/2016 10:46, Peter Maydell wrote: >> > The problem is indeed with the scheduling. The way it currently works >> > is to depend on the iothread to kick a reschedule once in a while, or >> > a cpu to issue an instruction that does so (wfe/wfi). However if >> > there's no io and a cpu never

Re: [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature

On Wed, Nov 30, 2016 at 01:16:59PM +0100, Maxime Coquelin wrote: > > > On 11/30/2016 12:23 PM, Jason Wang wrote: > > > > > > On 2016年11月30日 18:10, Maxime Coquelin wrote: > > > This series implements Virtio spec update from Aaron Conole which > > > defines a way for the host to expose its max

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

On 30/11/2016 14:31, Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 12:47:03PM +0100, Paolo Bonzini wrote: >> @@ -272,22 +275,32 @@ bool aio_prepare(AioContext *ctx) >> bool aio_pending(AioContext *ctx) >> { >> AioHandler *node; >> +bool result = false; >> >> -

Re: [Qemu-devel] [PATCH 05/10] aio: tweak walking in dispatch phase

On Tue, Nov 29, 2016 at 12:47:02PM +0100, Paolo Bonzini wrote: > Preparing for the following patch, use QLIST_FOREACH_SAFE and > modify the placement of walking_handlers increment/decrement. > > Signed-off-by: Paolo Bonzini > --- > aio-posix.c | 27

Re: [Qemu-devel] [Qemu-block] [PATCH 10/10] async: optimize aio_bh_poll

On Tue, Nov 29, 2016 at 12:47:07PM +0100, Paolo Bonzini wrote: > Avoid entering the slow path of qemu_lockcnt_dec_and_lock if > no bottom half has to be deleted. > > Signed-off-by: Paolo Bonzini > --- > async.c | 10 +- > 1 file changed, 9 insertions(+), 1

Re: [Qemu-devel] [Qemu-block] [PATCH 09/10] aio: push aio_context_acquire/release down to dispatching

On Tue, Nov 29, 2016 at 12:47:06PM +0100, Paolo Bonzini wrote: > The AioContext data structures are now protected by list_lock and/or > they are walked with FOREACH_RCU primitives. There is no need anymore > to acquire the AioContext for the entire duration of aio_dispatch. > Instead, just

Re: [Qemu-devel] [Qemu-block] [PATCH 08/10] aio: document locking

On Tue, Nov 29, 2016 at 12:47:05PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/multiple-iothreads.txt | 5 ++--- > include/block/aio.h | 32 > 2 files changed, 18 insertions(+), 19 deletions(-)

Re: [Qemu-devel] [PATCH 07/10] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock

On Tue, Nov 29, 2016 at 12:47:04PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > aio-win32.c | 82 > + > 1 file changed, 50 insertions(+), 32 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

On Tue, Nov 29, 2016 at 12:47:03PM +0100, Paolo Bonzini wrote: > @@ -272,22 +275,32 @@ bool aio_prepare(AioContext *ctx) > bool aio_pending(AioContext *ctx) > { > AioHandler *node; > +bool result = false; > > -QLIST_FOREACH(node, >aio_handlers, node) { > +/* > + * We have

Re: [Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

On Tue, Nov 29, 2016 at 12:47:01PM +0100, Paolo Bonzini wrote: > diff --git a/include/qemu/futex.h b/include/qemu/futex.h > new file mode 100644 > index 000..c3d1089 > --- /dev/null > +++ b/include/qemu/futex.h > @@ -0,0 +1,36 @@ > +/* > + * Wrappers around Linux futex syscall > + * > + *

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

On Tue, Nov 29, 2016 at 09:54:29PM -0200, Marcelo Tosatti wrote: > On Tue, Nov 29, 2016 at 10:34:05AM -0200, Eduardo Habkost wrote: > > On Tue, Nov 29, 2016 at 08:56:00AM -0200, Marcelo Tosatti wrote: > > > On Mon, Nov 28, 2016 at 03:12:01PM -0200, Eduardo Habkost wrote: > > > > On Mon, Nov 28,

Re: [Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

On Tue, Nov 29, 2016 at 12:46:59PM +0100, Paolo Bonzini wrote: > A QemuLockCnt comprises a counter and a mutex, with primitives > to increment and decrement the counter, and to take and release the > mutex. It can be used to do lock-free visits to a data structure > whenever mutexes would be too

Re: [Qemu-devel] [PATCH 03/10] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh

On Tue, Nov 29, 2016 at 12:47:00PM +0100, Paolo Bonzini wrote: > This will make it possible to walk the list of bottom halves without > holding the AioContext lock---and in turn to call bottom half > handlers without holding the lock. > > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] qemu-system-sh4 vs qemu-system-arm/i386 default behavior

On Wed, Nov 30, 2016 at 10:12:09AM +0100, Thomas Huth wrote: > On 30.11.2016 09:02, Aurelien Jarno wrote: > > On 2016-11-30 08:33, Thomas Huth wrote: > >> On 30.11.2016 02:01, Tom Rini wrote: > >>> Hey all, > >>> > >>> I'm trying to make use of the r2d platform for U-Boot testing via QEMU. > >>>

Re: [Qemu-devel] [PATCH 01/10] aio: rename bh_lock to list_lock

On Tue, Nov 29, 2016 at 12:46:58PM +0100, Paolo Bonzini wrote: > diff --git a/include/block/aio.h b/include/block/aio.h > index c7ae27c..eee3139 100644 > --- a/include/block/aio.h > +++ b/include/block/aio.h > @@ -90,7 +90,7 @@ struct AioContext { > uint32_t notify_me; > > /* lock to

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

Hi, > > Want sent a patch? > > What file for? :) create something like scripts/git.orderfile, so people have just to run "git config diff.orderfile scripts/git.orderfile" to enable it, and we can refine the config without having everybody update the orderfile manually? > I've considered

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On Wed, 11/30 13:03, Laszlo Ersek wrote: > On 11/30/16 11:55, Gerd Hoffmann wrote: > > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: > >> Recent git releases support the diff.orderFile permanent setting. > > > > Cool. > > > >> configure > >> *Makefile* > >> *.json > >> *.txt > >> *.h >

Re: [Qemu-devel] [RFC v3 3/3] virtio-net: Add MTU feature support

On 11/30/2016 12:24 PM, Jason Wang wrote: On 2016年11月30日 18:10, Maxime Coquelin wrote: This patch allows advising guest with host MTU's by setting host_mtu parameter. If VIRTIO_NET_F_MTU has been successfully negotiated, MTU value is passed to the backend. Cc: Michael S. Tsirkin

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On 11/30/16 11:55, Gerd Hoffmann wrote: > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: >> Recent git releases support the diff.orderFile permanent setting. > > Cool. > >> configure >> *Makefile* >> *.json >> *.txt >> *.h >> *.c > > I'd put *.txt to the head so doc updates come first.

Re: [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature

On 11/30/2016 12:23 PM, Jason Wang wrote: On 2016年11月30日 18:10, Maxime Coquelin wrote: This series implements Virtio spec update from Aaron Conole which defines a way for the host to expose its max MTU to the guest. This third version re-desings how MTU value is provided to QEMU. Now,

Re: [Qemu-devel] [RFC v3 1/3] vhost-user: Add MTU protocol feature and op

On 11/30/2016 11:25 AM, Yuanhan Liu wrote: On Wed, Nov 30, 2016 at 11:10:15AM +0100, Maxime Coquelin wrote: +#define VHOST_USER_PROTOCOL_F_MTU4 Message types - @@ -470,6 +471,18 @@ Message types The first 6 bytes of the payload contain the mac address of the

[Qemu-devel] Question about open() in qemu

Hello I am studnet studying QEMU. I have a question open in QEMU. In function handle_aiocb_rw_linear() in block/raw-posix.c, i tried to open my device driver(mydev). this driver was confirmed safe operation by test program. But in qemu, this driver was not opened returning -1. errno is 1.

Re: [Qemu-devel] Question about open() in qemu

On Wed, 11/30 19:11, morgenlette madeBy wrote: > Hello > > I am studnet studying QEMU. > > I have a question open in QEMU. > > In function handle_aiocb_rw_linear() in block/raw-posix.c, > > i tried to open my device driver(mydev). > > this driver was confirmed safe operation by test program.

Re: [Qemu-devel] [PATCH v2 0/6] Add support for the Epson RX8900 RTC to the aspeed board

On Wed, 2016-11-30 at 16:36 +1100, Alastair D'Silva wrote: > > This patch series adds support for the Epson RX8900 RTC to the > Aspeed board. > > The tests use the existing imx25 infrastructure, and some minor > changes have been made to uniquely identify the I2C buses. > > A NULL check have

Re: [Qemu-devel] [PATCH v2 4/5] slirp: VMStatify socket level

* Samuel Thibault (samuel.thiba...@gnu.org) wrote: > Hello, > > Dr. David Alan Gilbert, on Mon 28 Nov 2016 09:08:16 +, wrote: > > Hmm, I don't really know IPv6 but I'm thinking this code will become > > something like > > the following (says he not knowing whether a scope-id or a flowinfo >

Re: [Qemu-devel] [RFC v3 3/3] virtio-net: Add MTU feature support

On 2016年11月30日 18:10, Maxime Coquelin wrote: This patch allows advising guest with host MTU's by setting host_mtu parameter. If VIRTIO_NET_F_MTU has been successfully negotiated, MTU value is passed to the backend. Cc: Michael S. Tsirkin Cc: Aaron Conole

Re: [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature

On 2016年11月30日 18:10, Maxime Coquelin wrote: This series implements Virtio spec update from Aaron Conole which defines a way for the host to expose its max MTU to the guest. This third version re-desings how MTU value is provided to QEMU. Now, host_mtu parameter is added to provide QEMU with

Re: [Qemu-devel] [PATCH 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年11月30日 16:55, Wei Xu wrote: On 2016年11月24日 12:17, Jason Wang wrote: On 2016年11月01日 01:41, w...@redhat.com wrote: From: Wei Xu All the data packets in a tcp connection are cached to a single buffer in every receive interval, and will be sent out via a timer, the

Re: [Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > new file mode 100644 > index 000..08b077f > --- /dev/null > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c > @@ -0,0 +1,518 @@

Re: [Qemu-devel] [PATCH] virtio-scsi: introduce virtio_scsi_acquire/release

On Tue, Nov 29, 2016 at 04:37:01PM +0100, Paolo Bonzini wrote: > These will be used more as soon as the acquire/release is pushed down to > the ioeventfd handlers. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/virtio-scsi.c | 27 ++- > 1 file

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

Hi, Wouter! > Actually, come to think of that. What is the exact use case for this thing? I > understand you're trying to create incremental backups of things, which would > imply you don't write from the client that is getting the ? > block status thingies, right? Overall, the most desired

Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. Cool. > configure > *Makefile* > *.json > *.txt > *.h > *.c I'd put *.txt to the head so doc updates come first. Otherwise the order looks good to me. Want sent a patch?

Re: [Qemu-devel] Linux kernel polling for QEMU

On Wed, 11/30 09:38, Stefan Hajnoczi wrote: > On Wed, Nov 30, 2016 at 01:42:14PM +0800, Fam Zheng wrote: > > On Tue, 11/29 20:43, Stefan Hajnoczi wrote: > > > On Tue, Nov 29, 2016 at 1:24 PM, Fam Zheng wrote: > > > > On Tue, 11/29 12:17, Paolo Bonzini wrote: > > > >> On

<    1   2   3   >