Re: [Qemu-devel] [PATCH v2] bugfix: vm halt when in reset looping

2016-12-15 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2] bugfix: vm halt when in reset looping Message-id: 20161216073557.2688-1-hangaoh...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v2] bugfix: vm halt when in reset looping

2016-12-15 Thread hangaohuai
reset mc146818rtc device when RESET event happens. Fix the problem: 1. Guest boot the second cpu, set CMOS_RESET_CODE 0x0a to protect selfboot; 2. VM being reset by others, hmp_system_reset; 3. seabios resume check the CMOS_RESET_CODE, if 0x0a, jump to the BDA resume execution by jump

Re: [Qemu-devel] [PATCH v2 2/2] cputlb: drop flush_global flag from tlb_flush

2016-12-15 Thread David Gibson
On Thu, Dec 15, 2016 at 12:36:56PM +, Alex Bennée wrote: > We have never has the concept of global TLB entries which would avoid > the flush so we never actually use this flag. Drop it and make clear > that tlb_flush is the sledge-hammer it has always been. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/6] target-ppc: implement xxextractuw instruction

2016-12-15 Thread David Gibson
On Wed, Dec 14, 2016 at 02:14:26PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Mon, Dec 12, 2016 at 09:31:11AM +0530, Nikunj Dadhania wrote: > >> On 12 December 2016 at 06:00, David Gibson

Re: [Qemu-devel] [PATCH v2 1/2] qom/cpu: move tlb_flush to cpu_common_reset

2016-12-15 Thread David Gibson
On Thu, Dec 15, 2016 at 12:36:55PM +, Alex Bennée wrote: > It is a common thing amongst the various cpu reset functions want to > flush the SoftMMU's TLB entries. This is done either by calling > tlb_flush directly or by way of a general memset of the CPU > structure (sometimes both). > >

[Qemu-devel] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-12-15 Thread QingFeng Hao
The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But later vmdk_read_extent read it and converted it

[Qemu-devel] [PATCH v3 0/1] qemu: fix the bug reported by qemu-iotests case 055

2016-12-15 Thread QingFeng Hao
Hi all, v3 doesn't have code change but got the reviewed-by from Fam Zheng(thanks to Fam). v2 includes changes due to review comments by Kevin Wolf(thanks to Kevin). v3: * Got reviewed-by from Fam Zheng. * Based on master's commit: 6a928d25b6: Update version for v2.8.0-rc4 release v2: * Add

Re: [Qemu-devel] [PATCH V3 02/10] intel_iommu: name vtd address space with devfn

2016-12-15 Thread Jason Wang
On 2016年12月16日 10:53, Peter Xu wrote: On Mon, Nov 07, 2016 at 03:09:47PM +0800, Jason Wang wrote: To avoid duplicated name and ease debugging. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

Re: [Qemu-devel] [PATCH V3 02/10] intel_iommu: name vtd address space with devfn

2016-12-15 Thread Peter Xu
On Mon, Nov 07, 2016 at 03:09:47PM +0800, Jason Wang wrote: > To avoid duplicated name and ease debugging. > > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Acked-by:

[Qemu-devel] [PATCH for-2.9 V4 1/2] Add a new qmp command to start/stop replication

2016-12-15 Thread Zhang Chen
We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 18 ++ migration/colo.c | 23

[Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

2016-12-15 Thread Zhang Chen
Xen COLO depend on qemu COLO replication function. So, We need new qmp commands for Xen to use qemu replication. Corresponding libxl patches already in xen.git. Commit ID: ed37ef1f91c20f0ab162ce60f8c38400b917fa64 COLO: introduce new API to prepare/start/do/get_error/stop replication

[Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-15 Thread Zhang Chen
We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 migration/colo.c | 10

Re: [Qemu-devel] [PATCH v3 1/2] intel_iommu: check validity for GAW bits in CE

2016-12-15 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, December 14, 2016 10:54 AM > > On Wed, Dec 14, 2016 at 04:48:42AM +0200, Michael S. Tsirkin wrote: > > On Wed, Dec 14, 2016 at 10:09:04AM +0800, Peter Xu wrote: > > > Currently vt-d Context Entry (CE) only allows 39/48 bits address

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Li, Liang Z
> On 12/15/2016 05:38 PM, Li, Liang Z wrote: > > > > Use 52 bits for 'pfn', 12 bits for 'length', when the 12 bits is not long > > enough > for the 'length' > > Set the 'length' to a special value to indicate the "actual length in next 8 > bytes". > > > > That will be much more simple. Right? >

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-12-15 Thread Buddhi Madhav
Hi, Does this authentication scheme works? 1) Pass the encrypted password to qemu-kvm as follows: # . /qemu-io --object secret,id=secmaster0,format=base64,file=key.b64 --object secret,id=password-secret,keyid=secmaster0,file=pw.aes,iv=$(

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Dave Hansen
On 12/15/2016 05:38 PM, Li, Liang Z wrote: > > Use 52 bits for 'pfn', 12 bits for 'length', when the 12 bits is not long > enough for the 'length' > Set the 'length' to a special value to indicate the "actual length in next 8 > bytes". > > That will be much more simple. Right? Sounds fine to

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Li, Liang Z
> On 12/15/2016 04:48 PM, Li, Liang Z wrote: > >>> It seems we leave too many bit for the pfn, and the bits leave for > >>> length is not enough, How about keep 45 bits for the pfn and 19 bits > >>> for length, 45 bits for pfn can cover 57 bits physical address, that > >>> should be > >> enough

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Li, Liang Z
> On Thu, Dec 15, 2016 at 07:34:33AM -0800, Dave Hansen wrote: > > On 12/14/2016 12:59 AM, Li, Liang Z wrote: > > >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend > > >> virtio-balloon for fast (de)inflating & fast live migration > > >> > > >> On 12/08/2016 08:45 PM, Li, Liang Z wrote: >

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Dave Hansen
On 12/15/2016 04:48 PM, Li, Liang Z wrote: >>> It seems we leave too many bit for the pfn, and the bits leave for >>> length is not enough, How about keep 45 bits for the pfn and 19 bits >>> for length, 45 bits for pfn can cover 57 bits physical address, that should >>> be >> enough in the near

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Li, Liang Z
> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for > fast (de)inflating & fast live migration > > On 12/14/2016 12:59 AM, Li, Liang Z wrote: > >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon > >> for fast (de)inflating & fast live migration > >> >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-15 Thread Gonglei (Arei)
Hi Michael, > > > > > > > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver > > > > > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: > > > < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c > > > < >

[Qemu-devel] vfio/pci: host error recovery proposal

2016-12-15 Thread Michael S. Tsirkin
On Fri, Dec 16, 2016 at 01:02:14AM +0200, Michael S. Tsirkin wrote: > > > 1) We need to do the right thing for the guest, I don't think we > > should be presuming that different reset types are equivalent, > > leaving gaps where we expect the guest/host to do a reset and don't > >

Re: [Qemu-devel] [RFC] PCI/migration merge vmstate_pci_device and vmstate_pcie_device

2016-12-15 Thread Michael S. Tsirkin
On Wed, Dec 14, 2016 at 07:58:29PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The vmstate_pci_device and vmstate_pcie_devices differ > just in the size of one buffer; combine the two using a _TEST > macro. > > I think this is safe as

[Qemu-devel] vfio/pci: guest error recovery proposal

2016-12-15 Thread Michael S. Tsirkin
> 1) We need to do the right thing for the guest, I don't think we > should be presuming that different reset types are equivalent, > leaving gaps where we expect the guest/host to do a reset and don't > follow through on other reset requests, and we need to notify the > guest

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: > Hi, > > > > > > The problem always reproduces for me: > > > > > - start qemu with -sdl > > > > > - wait for guest to boot > > > > > - click anywhere within guest screen > > > > > - message "press ctrl+alt to exit capture" appears

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2016-12-15 Thread Askar Safin
The bug still exists in qemu 2.7 (version present in my debian stretch). I was not able reproduce the bug with booting kernel directly with 2.7 (-kernel ...), but booting disk image causes the bug. So, I have debian gnu/linux stretch amd64. debian package qemu- system-x86 1:2.7+dfsg-3+b1. I run

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2016-12-15 Thread Askar Safin
And this is Screenshot_20161216_005917.png . Here (after grub) we see "recovering journal" on top of seabios string ** Attachment added: "Screenshot_20161216_005917.png" https://bugs.launchpad.net/qemu/+bug/922076/+attachment/4792206/+files/Screenshot_20161216_005917.png -- You received

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2016-12-15 Thread Askar Safin
This is Screenshot_20161216_005859.png , screenshot with grub ** Attachment added: "Screenshot_20161216_005859.png" https://bugs.launchpad.net/qemu/+bug/922076/+attachment/4792205/+files/Screenshot_20161216_005859.png -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-15 Thread Benjamin Herrenschmidt
On Wed, 2016-12-14 at 20:26 +0200, Marcel Apfelbaum wrote: > > > The Root complex includes the PCI bus, some configuration > > > registers if > > > needed, provides access to the configuration space, translates > > > relevant CPU > > > reads/writes to PCI(e) transactions... > > > > Do those

[Qemu-devel] [PATCH 1/2] vmxnet3: Convert ring values to uint32_t's

2016-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The index's in the Vmxnet3Ring were migrated as 32bit ints yet are declared as size_t's. They appear to be derived from 32bit values loaded from guest memory, so actually store them as that. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 2/2] vmxnet3: VMStatify rx/tx q_descr and int_state

2016-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Fairly simple mechanical conversion of all fields. TODO The problem is vmxnet3-ring size/cell_size/next are declared as size_t but written as 32bit. Signed-off-by: Dr. David Alan Gilbert --- hw/net/vmxnet3.c | 272

[Qemu-devel] [PATCH 0/2] Vmxnet3 VMStatification

2016-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This patchset converts most of vmxnet3 to VMState; the only bit remaining is the msix section (which is what I'm actually interested in cleaning up since it's one of the last few users of register_savevm - but it'll have to wait). Note a

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 15 December 2016 at 19:03, Dr. David Alan Gilbert > wrote: > > One thing we'd have to do if we did that would be to > > add another flag to devices to declare that they might > > sometime in the future call the

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-15 Thread Eduardo Habkost
On Thu, Dec 15, 2016 at 02:15:51PM -0500, Laine Stump wrote: > On 12/15/2016 05:12 AM, Marcel Apfelbaum wrote: > > On 12/14/2016 10:10 PM, Laine Stump wrote: > > > On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: > > > > Be aware that 1 slot doesn't necessarily refer to only one device, > > > > we

Re: [Qemu-devel] [RFC v2] qmp: query-device-slots command

2016-12-15 Thread Eduardo Habkost
On Thu, Dec 15, 2016 at 01:39:30PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > This adds a new command to QMP: query-device-slots. It will allow > > management software to query possible slots where devices can be > > plugged. > > > > This implementation

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Peter Maydell
On 15 December 2016 at 19:03, Dr. David Alan Gilbert wrote: > One thing we'd have to do if we did that would be to > add another flag to devices to declare that they might > sometime in the future call the migrate_add_blocker. ...do you have a third-party library to suggest

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 09:15:27PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > > > The problem always reproduces for me: > > > > > > - start qemu with -sdl > > > > > > - wait for guest to boot > > > > > > - click anywhere

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-15 Thread Laine Stump
On 12/15/2016 05:12 AM, Marcel Apfelbaum wrote: On 12/14/2016 10:10 PM, Laine Stump wrote: On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: Be aware that 1 slot doesn't necessarily refer to only one device, we can have a multi-function device. Is that a fixed thing? I mean, is it always

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: > Hi, > > > > > > The problem always reproduces for me: > > > > > - start qemu with -sdl > > > > > - wait for guest to boot > > > > > - click anywhere within guest screen > > > > > - message "press ctrl+alt to exit capture" appears

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-15 Thread Eduardo Habkost
On Wed, Dec 14, 2016 at 09:11:10PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, Dec 13, 2016 at 08:51:34PM +0100,

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 15, 2016 at 04:07:41PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, Dec 15, 2016 at 12:36:59AM +0530, Ashijeet Acharya wrote: > > > > This series adds a new command line option

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 04:07:41PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Dec 15, 2016 at 12:36:59AM +0530, Ashijeet Acharya wrote: > > > This series adds a new command line option "--only-migratable" which will > > > only > > > allow

[Qemu-devel] [PATCH 1/1] virtio: avoid using guest_notifier_mask in vhost-user mode

2016-12-15 Thread Wei Huang
Because guest mask notifier cannot be used in vhost-user mode, a boolean flag "use_guest_notifier_mask" was added in commit 5669655aafd to disable the use of guest mask notifier under virtio-pci. However this flag wasn't checked in other virtio devices, such as virtio-mmio. In our tests, it caused

[Qemu-devel] [Bug 912983] Re: Unable to install OS/2 Warp v3 past disk 2

2016-12-15 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 938945] Re: Slirp cannot be forward and makes segmentation faults

2016-12-15 Thread Thomas Huth
Which version of QEMU did you use? Can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 907063] Re: Error reading VMDK4 with footer instead of header

2016-12-15 Thread Thomas Huth
Looks like something similar has been commited here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=65bd155c7356d448ffee7 So is this problem fixed nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 11:21 PM, John Snow wrote: > > > On 12/15/2016 12:11 PM, Dr. David Alan Gilbert wrote: >> if (virtio_gpu_virgl_enabled(g->conf)) { >> +error_setg(>migration_blocker, "virgl is not yet migratable"); >> +ret =

[Qemu-devel] [Bug 922355] Re: qemu crashes when invoked on Pandaboard

2016-12-15 Thread Thomas Huth
QEMU 0.14 is pretty much outdated nowadays ... Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 947273] Re: launchpad homepage url is out of date

2016-12-15 Thread Thomas Huth
As far as I can see, the "home page" link is now set to http://wiki .qemu-project.org/ - so it seems this has been fixed. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2016-12-15 Thread Thomas Huth
Does this problem still exist with the latest version of QEMU? Which interface type are you using (SDL, gtk, ...)? Can you please provide your full command line and build options? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member

[Qemu-devel] [Bug 906221] Re: USBDEVFS_CLEAR_HALT stall with USB-CDROM qemu-1.0

2016-12-15 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce this problem with the latest version of QEMU and the latest version of libusb? If so, could you please also provide the command line options that you used to start QEMU? ** Changed in: qemu Status: New => Incomplete -- You received

[Qemu-devel] [Bug 906864] Re: Always mouse grabbing with -usbdevice tablet

2016-12-15 Thread Thomas Huth
Seems to work for me with the latest version of QEMU. Can you still reproduce it with the latest version? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC v2] qmp: query-device-slots command

2016-12-15 Thread Eduardo Habkost
On Thu, Dec 15, 2016 at 10:36:17AM +0100, Igor Mammedov wrote: > On Wed, 14 Dec 2016 17:39:08 -0200 > Eduardo Habkost wrote: > > > This adds a new command to QMP: query-device-slots. It will allow > > management software to query possible slots where devices can be > >

Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread John Snow
On 12/15/2016 12:11 PM, Dr. David Alan Gilbert wrote: > if (virtio_gpu_virgl_enabled(g->conf)) { > +error_setg(>migration_blocker, "virgl is not yet migratable"); > +ret = migrate_add_blocker(g->migration_blocker, errp); > +if (ret) { > +if (ret > 0) { >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-15 Thread Alex Bligh
> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > >> Because the namespaces and leaf-names are already restricted to >> non-whitespace characters. I thought having tabs, line feeds, >> returns, em-space, en-space etc. was not particularly useful. >> I could be persuaded to

[Qemu-devel] [PATCH 2/2] monitor: fix object_del for command-line-created objects

2016-12-15 Thread Michael Roth
Currently objects specified on the command-line are only partially cleaned up when 'object_del' is issued in either HMP or QMP: the object itself is fully finalized, but the QemuOpts are not removed. This results in the following behavior: x86_64-softmmu/qemu-system-x86_64 -monitor stdio \

[Qemu-devel] [PATCH v4 0/2] Fixes/tests for hmp_object_del()

2016-12-15 Thread Michael Roth
hmp_object_del() followed by a subsequent hmp_object_add() can trigger a duplicate ID error if the previous object shared the same ID and was added via the command-line. Please see patch 2/2 for more details. This patchset fixes the issue in question and adds some general unit tests for object

[Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: add checks for cmdline-created objects

2016-12-15 Thread Michael Roth
check-qom-proplist originally added tests for verifying that object-creation helpers object_new_with_{props,propv} behaved in similar fashion to the "traditional" method involving setting each individual property separately after object creation rather than via a single call. Another similar

Re: [Qemu-devel] [PATCH v3 2/2] monitor: fix object_del for command-line-created objects

2016-12-15 Thread Michael Roth
Quoting Markus Armbruster (2016-12-12 09:53:20) > Michael Roth writes: > > > Currently objects specified on the command-line are only partially > > cleaned up when 'object_del' is issued in either HMP or QMP: the > > object itself is fully finalized, but the QemuOpts

Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Also, it should fail if the '--only-migratable' option was specified > and the device in use should not be able to

Re: [Qemu-devel] [PATCH v1 00/30] target-sparc: add niagara OpenSPARC T1 sun4v emulation

2016-12-15 Thread Artyom Tarasenko
Ping? Richard & Mark, can you please review the patches 04, 05, 08, 10, 11,12, 14, 15, 16, 18-23 and 25-28? Hope I haven't missed anything from the v0 review. It would be nice to get it into the 2.9 release. On Fri, Nov 4, 2016 at 9:50 PM, Artyom Tarasenko wrote: > This

Re: [Qemu-devel] [PATCH 1/3] migration: Add a new option to enable only-migratable

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > On Thu, Dec 15, 2016 at 8:59 PM, Dr. David Alan Gilbert > wrote: > > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > >> Add a new option "--only-migratable" in qemu which will allow to add > >> only those devices

Re: [Qemu-devel] [PATCH 1/3] migration: Add a new option to enable only-migratable

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 8:59 PM, Dr. David Alan Gilbert wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Add a new option "--only-migratable" in qemu which will allow to add >> only those devices which will not fail qemu after migration. Devices >> set with

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-15 Thread Wouter Verhelst
On Thu, Dec 15, 2016 at 04:32:23PM +, Alex Bligh wrote: > Wouter, > > > This reads a bit awkward. I would do: > > > > s/save that:/except as explained below/ > > Possibly a British English thing. Will fix. It's mostly that the "save that:" suggests to me that the exception follows

Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 01:08:51AM +, Gonglei (Arei) wrote: > > > > > Regards, > -Gonglei > > > > -Original Message- > > From: Zeng, Xin [mailto:xin.z...@intel.com] > > Sent: Thursday, December 15, 2016 8:59 AM > > To: Gonglei (Arei); Halil Pasic; linux-ker...@vger.kernel.org; >

Re: [Qemu-devel] [PATCH] vnc: track LED state separately

2016-12-15 Thread Gerd Hoffmann
On Do, 2016-12-15 at 14:16 +0100, Pierre Ossman wrote: > Piggy-backing on the modifier state array made it difficult to send > out updates at the proper times. So keep track of the LED state in > a separate variable. > > This also moves the handling up a layer in to the VNC Display object > since

Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-15 Thread Alberto Garcia
On Wed 30 Nov 2016 02:18:33 AM CET, Max Reitz wrote: > int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, > const char *bdref_key, Error **errp) > { > -char *backing_filename = g_malloc0(PATH_MAX); > +char *backing_filename = NULL; >

Re: [Qemu-devel] [PATCH 00/11] Remove VirtGuestInfo

2016-12-15 Thread Michael S. Tsirkin
On Tue, Dec 13, 2016 at 10:45:11PM +0100, Andrew Jones wrote: > This series is based on Peter's qemu-arm gicv3-virt branch. It's > main goal (patches 04-10), which was suggested by Eduardo, is to > remove an unnecessary structure, VirtGuestInfo, which is a > maintenance burden, as it requires

Re: [Qemu-devel] [PATCH 2/3] migration: Allow "device add" options to only add migratable devices

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 9:49 PM, Dr. David Alan Gilbert wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> On Thu, Dec 15, 2016 at 9:35 PM, Dr. David Alan Gilbert >> wrote: >> > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> >>

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-15 Thread Alex Bligh
Wouter, > This reads a bit awkward. I would do: > > s/save that:/except as explained below/ Possibly a British English thing. Will fix. >>If one or more queries are sent, then the server MUST return >>those metadata contexts that are available to the client to >>select on the given

Re: [Qemu-devel] [PATCH 2/3] migration: Allow "device add" options to only add migratable devices

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 9:35 PM, Dr. David Alan Gilbert wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Introduce checks for the unmigratable flag in the VMStateDescription >> structs of respective devices when user attempts to add them. If the >>

Re: [Qemu-devel] [PATCH v3 01/25] block/mirror: Small absolute-paths simplification

2016-12-15 Thread Alberto Garcia
On Wed 30 Nov 2016 02:18:27 AM CET, Max Reitz wrote: > When invoking drive-mirror in absolute-paths mode, the target's backing > BDS is assigned to it in mirror_complete(). The current logic only does > so if the target does not have that backing BDS already; but it actually > cannot have a

Re: [Qemu-devel] [PATCH 09/11] hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState

2016-12-15 Thread Andrew Jones
On Thu, Dec 15, 2016 at 04:08:22PM +0100, Igor Mammedov wrote: > On Tue, 13 Dec 2016 22:45:20 +0100 > Andrew Jones wrote: > > > We can get to VirtMachineState without the need for saving a pointer > > on AcpiBuildState. This is the mach-virt equivalent to "acpi: Don't save >

Re: [Qemu-devel] [PATCH v3 06/25] block: bdrv_get_full_backing_filename_from_...'s ret. val.

2016-12-15 Thread Alberto Garcia
On Wed 30 Nov 2016 02:18:32 AM CET, Max Reitz wrote: > Make bdrv_get_full_backing_filename_from_filename() return an allocated > string instead of placing the result in a caller-provided buffer. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2016-12-15 Thread Thomas Huth
This does not sound like a QEMU bug, so let's remove it from the QEMU bug tracker ** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Halil Pasic
On 12/15/2016 02:37 PM, Paolo Bonzini wrote: > > > On 15/12/2016 12:32, Halil Pasic wrote: >> static inline uint16_t vring_avail_idx(VirtQueue *vq) >> { >> hwaddr pa; >> pa = vq->vring.avail + offsetof(VRingAvail, idx); >> vq->shadow_avail_idx = virtio_lduw_phys(vq->vdev, pa); >>

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 15, 2016 at 12:36:59AM +0530, Ashijeet Acharya wrote: > > This series adds a new command line option "--only-migratable" which will > > only > > allow addition of those devices to a QEMU instance which are migratable and > > do > > not

[Qemu-devel] [Bug 810588] Re: Unexpected crash of qemu-kvm with SCSI disk emulation.

2016-12-15 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/810588 Title: Unexpected crash of qemu-kvm with SCSI disk emulation. Status in QEMU:

[Qemu-devel] [Bug 897750] Re: libvirt/kvm problem with disk attach/detach/reattach on running virt

2016-12-15 Thread Thomas Huth
Is here still a problem left with upstream QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/897750 Title: libvirt/kvm problem with disk

Re: [Qemu-devel] [PATCH 2/3] migration: Allow "device add" options to only add migratable devices

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > On Thu, Dec 15, 2016 at 9:35 PM, Dr. David Alan Gilbert > wrote: > > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > >> Introduce checks for the unmigratable flag in the VMStateDescription > >> structs of

Re: [Qemu-devel] [PATCH 10/11] hw/arm/virt: remove VirtGuestInfo

2016-12-15 Thread Andrew Jones
On Thu, Dec 15, 2016 at 03:59:35PM +0100, Igor Mammedov wrote: > On Tue, 13 Dec 2016 22:45:21 +0100 > Andrew Jones wrote: > > > by moving VirtGuestInfo.fw_cfg to VirtMachineState. This is the > > mach-virt equivalent of "pc: Move PcGuestInfo.fw_cfg to > > PCMachineState" and

Re: [Qemu-devel] [PATCH 07/11] hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo

2016-12-15 Thread Andrew Jones
On Thu, Dec 15, 2016 at 03:45:55PM +0100, Igor Mammedov wrote: > On Tue, 13 Dec 2016 22:45:18 +0100 > Andrew Jones wrote: > > > Only two functions take VirtGuestInfo parameters. Now that guest-info > > is part of VirtMachineState, and VirtMachineState is defined in the > >

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Gerd Hoffmann
Hi, > BTW I note that on f23, build of 2.7 fails since it uses > deprecated APIs from gtk. Easy to work around with --disable-werror, > but I wonder whether we should add --disable-werror in release tarballs > generally. That is the case already. configure checks you are building from a git

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 9:37 PM, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: >> On Thu, Dec 15, 2016 at 12:36:59AM +0530, Ashijeet Acharya wrote: >> > This series adds a new command line option "--only-migratable" which will >> > only >> >

Re: [Qemu-devel] [PATCH 2/3] migration: Allow "device add" options to only add migratable devices

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > Introduce checks for the unmigratable flag in the VMStateDescription > structs of respective devices when user attempts to add them. If the > "--only-migratable" was specified, all unmigratable devices will > rightly fail to add. This feature

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Gerd Hoffmann
Hi, > > > > The problem always reproduces for me: > > > > - start qemu with -sdl > > > > - wait for guest to boot > > > > - click anywhere within guest screen > > > > - message "press ctrl+alt to exit capture" appears on screen, > > > > but pressing that immediately restarts capture again [

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Weiwei Jia
I will try it later on. Thank you. Best, Weiwei Jia On Thu, Dec 15, 2016 at 7:13 AM, Paolo Bonzini wrote: > > > On 15/12/2016 09:04, Stefan Hajnoczi wrote: >>> Does this feature only work for VirtIO? Does it work for SCSI or IDE? >> This only works for virtio-blk and

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Weiwei Jia
On Thu, Dec 15, 2016 at 3:06 AM, Stefan Hajnoczi wrote: > On Thu, Dec 15, 2016 at 12:17:09AM -0500, Weiwei Jia wrote: >> BTW, do we have an example to show users how to config following >> virtio-blk dataplane commands into XML configuration file? >> >> qemu -object

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2016-12-15 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU, with the latest version of SDL? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 12:36:59AM +0530, Ashijeet Acharya wrote: > This series adds a new command line option "--only-migratable" which will only > allow addition of those devices to a QEMU instance which are migratable and do > not abruptly fail QEMU after migration. > > Patch 1 adds the new

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 07:34:33AM -0800, Dave Hansen wrote: > On 12/14/2016 12:59 AM, Li, Liang Z wrote: > >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for > >> fast (de)inflating & fast live migration > >> > >> On 12/08/2016 08:45 PM, Li, Liang Z wrote: > >>> What's

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Weiwei Jia
On Thu, Dec 15, 2016 at 3:04 AM, Stefan Hajnoczi wrote: > On Wed, Dec 14, 2016 at 08:06:10PM -0500, Weiwei Jia wrote: >> Hi Stefan, >> >> Thanks for your reply. Please see the inline replies. >> >> On Wed, Dec 14, 2016 at 2:31 PM, Stefan Hajnoczi wrote: >>

[Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-15 Thread Halil Pasic
Correct recalculation of vring->inuse after migration for the corner case where the avail_idx has already wrapped but used_idx not yet. Signed-off-by: Halil Pasic Fixes: bccdef6b ("virtio: recalculate vq->inuse after migration") CC: qemu-sta...@nongnu.org --- I think

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-15 Thread Dave Hansen
On 12/14/2016 12:59 AM, Li, Liang Z wrote: >> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for >> fast (de)inflating & fast live migration >> >> On 12/08/2016 08:45 PM, Li, Liang Z wrote: >>> What's the conclusion of your discussion? It seems you want some >>> statistic

Re: [Qemu-devel] [PATCH 1/3] migration: Add a new option to enable only-migratable

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > Add a new option "--only-migratable" in qemu which will allow to add > only those devices which will not fail qemu after migration. Devices > set with the flag 'unmigratable' cannot be added when this option will > be used. > >

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 10:17:59AM +0100, Gerd Hoffmann wrote: > On Do, 2016-12-15 at 07:50 +, Stefan Hajnoczi wrote: > > On Thu, Dec 15, 2016 at 06:35:39AM +0200, Michael S. Tsirkin wrote: > > > The problem always reproduces for me: > > > - start qemu with -sdl > > > - wait for guest to boot

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 10:17:59AM +0100, Gerd Hoffmann wrote: > On Do, 2016-12-15 at 07:50 +, Stefan Hajnoczi wrote: > > On Thu, Dec 15, 2016 at 06:35:39AM +0200, Michael S. Tsirkin wrote: > > > The problem always reproduces for me: > > > - start qemu with -sdl > > > - wait for guest to boot

Re: [Qemu-devel] [PATCH 10/11] hw/arm/virt: remove VirtGuestInfo

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:21 +0100 Andrew Jones wrote: > by moving VirtGuestInfo.fw_cfg to VirtMachineState. This is the > mach-virt equivalent of "pc: Move PcGuestInfo.fw_cfg to > PCMachineState" and "pc: Eliminate PcGuestInfo struct" combined. > > Signed-off-by: Andrew

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-15 Thread Wouter Verhelst
Hi Alex, On Thu, Dec 15, 2016 at 10:04:05AM +, Alex Bligh wrote: > > > On 14 Dec 2016, at 20:18, Wouter Verhelst wrote: > > > >> +* the server MAY return a context consisting of a namespace and > >> + a colon only (i.e. omitting the leaf-name) to indicate that > >> +

[Qemu-devel] Measure virtio-vsock speed

2016-12-15 Thread Zhang Shuaiyi
I used kernel 4.8 and qemu v2.8.0-rc3. Qemu command line: -device vhost-vsock-pci,id=vhost-vsock-pci0,guest-cid=3 I try to use nc-vsock to test vsock speed. 1. In host: # modprobe vhost-vsock # ./nc-vsock -l 1234 > /dev/null 2. In guest: a. use pv and nc-vsock, speed is about 62MB/s.

  1   2   >