Re: [Qemu-devel] [PATCH 09/11] hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:20 +0100 Andrew Jones wrote: > We can get to VirtMachineState without the need for saving a pointer > on AcpiBuildState. This is the mach-virt equivalent to "acpi: Don't save > PcGuestInfo on AcpiBuildState" > > Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH 08/11] hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:19 +0100 Andrew Jones wrote: > Now that we pass VirtMachineState, and guest-info is just part of > that state, we can remove all the redundant members and access > the VirtMachineState directly. > > Signed-off-by: Andrew Jones

[Qemu-devel] Network unreachable on IPv6 network using qemu-kvm-2.7

2016-12-15 Thread SAL
Hello, using qemu-2.7 there are network unreachable problems when using user networking on network with IPv4 and IPv6 support. With qemu 2.6 from Fedora 24 works well, but after update to qemu-2.7 from Fedora 25 unable to connect. Looks like DNS returns IPv6 address, which is not reachable from

Re: [Qemu-devel] [PATCH 06/11] hw/arm/virt: move VirtMachineState/Class to virt.h

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:17 +0100 Andrew Jones wrote: > In preparation to share more Virt machine state than just guest-info > with other mach-virt source files, move the State and Class structures > to virt.h > > Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH 07/11] hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:18 +0100 Andrew Jones wrote: > Only two functions take VirtGuestInfo parameters. Now that guest-info > is part of VirtMachineState, and VirtMachineState is defined in the > virt header, pass that instead. > > Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH 05/11] hw/arm/virt: remove include/hw/arm/virt-acpi-build.h

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:16 +0100 Andrew Jones wrote: > include/hw/arm/virt-acpi-build.h is only used for VirtGuestInfo, > which doesn't even necessarily have to be ACPI specific. Move > VirtGuestInfo to include/hw/arm/virt.h, allowing us to remove >

[Qemu-devel] [PATCH v3] target-arm: Add VBAR support to ARM1176 CPUs

2016-12-15 Thread Cédric Le Goater
ARM1176 CPUs have TrustZone support and can use the Vector Base Address Register, but currently, qemu only adds VBAR support to ARMv7 CPUs. Fix this by adding a new feature ARM_FEATURE_VBAR which can used for ARMv7 and ARM1176 CPUs. The VBAR feature is always set for ARMv7 because some legacy

[Qemu-devel] [ANNOUNCE] QEMU 2.8.0-rc4 is now available

2016-12-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 2.8 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.8.0-rc4.tar.bz2 Barring the

Re: [Qemu-devel] [PATCH] hw/block/pflash_cfi*.c: fix confusing assert fail message

2016-12-15 Thread Paolo Bonzini
On 15/12/2016 15:04, skiver.cloud@gmail.com wrote: > From: Ziyue Yang > > The patch is to fix the confusing assert fail message caused by > un-initialized device structure (from bite sized tasks). > > The bug can be reproduced by > > ./qemu-system-x86_64 -nographic

Re: [Qemu-devel] [PATCH 04/11] hw/arm/virt: eliminate struct VirtGuestInfoState

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:15 +0100 Andrew Jones wrote: > Instead of allocating a new struct just for VirtGuestInfo and the > machine_done Notifier, place them inside VirtMachineState. This > is the mach-virt equivalent of "pc: Eliminate struct > PcGuestInfoState" > >

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 11:32 AM, Halil Pasic wrote: > On 12/15/2016 11:52 AM, Dr. David Alan Gilbert wrote: >>> We got a bugreport with this log for a live migration target. >>> >>> 2016-12-13T18:59:03.647309Z qemu-system-s390x: VQ 1 size 0x100 < >>> last_avail_idx

[Qemu-devel] [PATCH] hw/block/pflash_cfi*.c: fix confusing assert fail message

2016-12-15 Thread skiver . cloud . yzy
From: Ziyue Yang The patch is to fix the confusing assert fail message caused by un-initialized device structure (from bite sized tasks). The bug can be reproduced by ./qemu-system-x86_64 -nographic -device cfi.pflash01 The CFI hardware is dynamically loaded by QOM

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-15 Thread Paolo Bonzini
On 14/12/2016 18:47, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 14/12/2016 14:48, Eduardo Habkost wrote: How do you find all abstract TypeInfo in the source? The uninitiated might grep for .abstract = true, and be misled. The initiated will be

Re: [Qemu-devel] [PATCH for-2.9 14/30] aspeed/smc: rework the prototype of the AspeedSMCFlash helper routines

2016-12-15 Thread Cédric Le Goater
On 12/14/2016 06:09 PM, Peter Maydell wrote: > On 29 November 2016 at 15:43, Cédric Le Goater wrote: >> Change the routines prototype to use a 'AspeedSMCFlash *' instead of >> 'AspeedSMCState *'. The result will help in making future changes >> clearer. >> >> Signed-off-by: Cédric

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Paolo Bonzini
On 15/12/2016 12:32, Halil Pasic wrote: > static inline uint16_t vring_avail_idx(VirtQueue *vq) > { > hwaddr pa; > pa = vq->vring.avail + offsetof(VRingAvail, idx); > vq->shadow_avail_idx = virtio_lduw_phys(vq->vdev, pa); > > we should have an endiannes handling here before

Re: [Qemu-devel] [RFC PATCH v2 0/8] VMS_ARRAY_OF_POINTER with null pointers

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Make VMS_ARRAY_OF_POINTER cope with null pointers. Currently the reward > for trying to migrate an array with some null pointers in it is an > illegal memory access, that is a swift and painless death of the > process. Let's make vmstate cope with

Re: [Qemu-devel] [RFC PATCH v2 6/8] migration/vmstate: split up vmstate_base_addr

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Currently vmstate_base_addr does several things: it pinpoints the field > within the struct, possibly allocates memory and possibly does the first > pointer dereference. Obviously allocation is needed only for load. > > Let us split up the

[Qemu-devel] [PATCH] vnc: track LED state separately

2016-12-15 Thread Pierre Ossman
Piggy-backing on the modifier state array made it difficult to send out updates at the proper times. So keep track of the LED state in a separate variable. This also moves the handling up a layer in to the VNC Display object since the state is global, and also makes sure the state is readily

Re: [Qemu-devel] [RFC PATCH v2 8/8] tests/test-vmstate.c: add array of pointers to struct with NULL

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Increase coverage by testing VMSTATE_ARRAY_OF_POINTER_TO_STRUCT > with an array containing some NULL pointer. > > Signed-off-by: Halil Pasic > --- > tests/test-vmstate.c | 41 + >

Re: [Qemu-devel] [RFC v2] qmp: query-device-slots command

2016-12-15 Thread Markus Armbruster
Eduardo Habkost writes: > This adds a new command to QMP: query-device-slots. It will allow > management software to query possible slots where devices can be > plugged. > > This implementation of the command will return: > > * Multiple PCI slots per bus, in the case of PCI

[Qemu-devel] [PATCH v2 2/2] cputlb: drop flush_global flag from tlb_flush

2016-12-15 Thread Alex Bennée
We have never has the concept of global TLB entries which would avoid the flush so we never actually use this flag. Drop it and make clear that tlb_flush is the sledge-hammer it has always been. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v2 0/2] Clean-up tlb_flush and cpu reset functions

2016-12-15 Thread Alex Bennée
Hi Richard, Nothing much changed in this except: - one minor patchew checkpatch.pl fix - added your r-b So I reckon this is ready to go in once the tree re-opens? Alex Bennée (2): qom/cpu: move tlb_flush to cpu_common_reset cputlb: drop flush_global flag from tlb_flush cputlb.c

[Qemu-devel] [PATCH v2 1/2] qom/cpu: move tlb_flush to cpu_common_reset

2016-12-15 Thread Alex Bennée
It is a common thing amongst the various cpu reset functions want to flush the SoftMMU's TLB entries. This is done either by calling tlb_flush directly or by way of a general memset of the CPU structure (sometimes both). This moves the tlb_flush call to the common reset function and additionally

[Qemu-devel] [PATCHv3] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
get_opt_value() truncates the value at the first comma Use memcpy() instead Unescape the module filename and parameters with get_opt_value() before calling mb_add_cmdline() Signed-off-by: Vlad Lungu --- hw/i386/multiboot.c | 19 +-- 1 file changed, 9

Re: [Qemu-devel] [RFC PATCH v2 7/8] migration/vmstate: fix array of pointers to struct

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the reward > for trying to migrate an array with some null pointers in it was an > illegal memory access, that is a swift and painless death of the process. > Let's make vmstate cope

Re: [Qemu-devel] [PATCH for-2.9 v2] qapi: add explicit null to string input and output visitors

2016-12-15 Thread David Gibson
On Thu, Dec 15, 2016 at 10:44:02AM +0100, Markus Armbruster wrote: > Greg Kurz writes: > > > This may be used for deprecated object properties that are kept for > > backwards compatibility. > > > > Signed-off-by: Greg Kurz > > --- > > v2: - input visitor to

Re: [Qemu-devel] [PATCHv2] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
On 12/15/2016 02:29 PM, Paolo Bonzini wrote: > > On 15/12/2016 12:34, Vlad Lungu wrote: >> >> On 12/15/2016 12:56 PM, Paolo Bonzini wrote: >>> On 15/12/2016 11:03, Vlad Lungu wrote: if (initrd_filename) { -char *next_initrd, not_last; +char

Re: [Qemu-devel] [PATCHv2] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Paolo Bonzini
On 15/12/2016 12:34, Vlad Lungu wrote: > > > On 12/15/2016 12:56 PM, Paolo Bonzini wrote: >> >> On 15/12/2016 11:03, Vlad Lungu wrote: >>> >>> if (initrd_filename) { >>> -char *next_initrd, not_last; >>> +char *next_initrd, not_last, tmpbuf[strlen(initrd_filename) + 1];

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Paolo Bonzini
On 15/12/2016 09:04, Stefan Hajnoczi wrote: >> Does this feature only work for VirtIO? Does it work for SCSI or IDE? > This only works for virtio-blk and virtio-scsi. The virtio-scsi > dataplane support is more recent and I don't remember if it is complete. > I've CCed Fam and Paolo who worked

Re: [Qemu-devel] [PATCH 03/11] hw/arm/virt: use VirtMachineState.smp_cpus

2016-12-15 Thread Andrew Jones
On Thu, Dec 15, 2016 at 11:37:06AM +0100, Igor Mammedov wrote: > On Tue, 13 Dec 2016 22:45:14 +0100 > Andrew Jones wrote: > > > Most places we need smp_cpus we use vms->smp_cpus already. This > > cleanup makes sure we do everywhere, preparing for the removal > > of the global

Re: [Qemu-devel] [RFC PATCH v2 5/8] migration/vmstate: renames in (load|save)_state

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > The vmstate_(load|save)_state start out with an a void *opaque pointing > to some struct, and manipulate one or more elements of one field within > that struct. > > First the field within the struct is pinpointed as opaque + offset, then > if this

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc/spapr: Fix boot path of usb-host storage devices

2016-12-15 Thread BALATON Zoltan
On Wed, 14 Dec 2016, Thomas Huth wrote: in it? Certainly not SLOF. Maybe OpenBIOS? Does OpenBIOS support USB storage devices? No it doesn't. Only keyboard HID devices. Regards, BALATON Zoltan

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 12/15/2016 11:52 AM, Dr. David Alan Gilbert wrote: > >> We got a bugreport with this log for a live migration target. > >> > >> 2016-12-13T18:59:03.647309Z qemu-system-s390x: VQ 1 size 0x100 < > >> last_avail_idx 0x2f76 - used_idx 0x762f

Re: [Qemu-devel] [PATCHv2] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
On 12/15/2016 12:56 PM, Paolo Bonzini wrote: > > On 15/12/2016 11:03, Vlad Lungu wrote: >> >> if (initrd_filename) { >> -char *next_initrd, not_last; >> +char *next_initrd, not_last, tmpbuf[strlen(initrd_filename) + 1]; >> >> mbs.offset_mods = mbs.mb_buf_size;

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Halil Pasic
On 12/15/2016 11:52 AM, Dr. David Alan Gilbert wrote: >> We got a bugreport with this log for a live migration target. >> >> 2016-12-13T18:59:03.647309Z qemu-system-s390x: VQ 1 size 0x100 < >> last_avail_idx 0x2f76 - used_idx 0x762f > Is this actually an endian problem - 2f76 vs 762f ? > >

[Qemu-devel] [PATCH] linux-user: fix build with musl on aarch64

2016-12-15 Thread Natanael Copa
Use the standard uint64_t instead of internal __u64. This fixes compiler error with musl libc on aarch64: .../qemu-2.7.0/linux-user/host/aarch64/hostdep.h:28:5: error: unknown type name '__u64' __u64 *pcreg = >uc_mcontext.pc; ^ Signed-off-by: Natanael Copa

Re: [Qemu-devel] [PATCH v3] virtio-pci: Fix cross-version migration with older machines

2016-12-15 Thread Maxime Coquelin
On 12/15/2016 11:31 AM, Stefan Hajnoczi wrote: On Thu, Dec 15, 2016 at 09:26:56AM +0100, Cornelia Huck wrote: On Thu, 15 Dec 2016 07:38:09 + Stefan Hajnoczi wrote: On Wed, Dec 14, 2016 at 05:30:35PM +0100, Maxime Coquelin wrote: This patch fixes a cross-version

Re: [Qemu-devel] [PATCHv2] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Paolo Bonzini
On 15/12/2016 11:03, Vlad Lungu wrote: > > if (initrd_filename) { > -char *next_initrd, not_last; > +char *next_initrd, not_last, tmpbuf[strlen(initrd_filename) + 1]; > > mbs.offset_mods = mbs.mb_buf_size; > > @@ -299,22 +299,24 @@ int

Re: [Qemu-devel] [PATCH for-2.9 v2] qapi: add explicit null to string input and output visitors

2016-12-15 Thread Greg Kurz
On Thu, 15 Dec 2016 10:44:02 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > This may be used for deprecated object properties that are kept for > > backwards compatibility. > > > > Signed-off-by: Greg Kurz > > --- > > v2: - input

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > We have a migration problem, which is in my opinion caused by a > deficiency in how vq->inuse is calculated after the migration (commit > bccdef6b "virtio: recalculate vq->inuse after migration" to > blame). > > > We got a bugreport with this

Re: [Qemu-devel] [PATCH 03/11] hw/arm/virt: use VirtMachineState.smp_cpus

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:14 +0100 Andrew Jones wrote: > Most places we need smp_cpus we use vms->smp_cpus already. This > cleanup makes sure we do everywhere, preparing for the removal > of the global smp_cpus someday. I'm not sure it's good idea to make/have smp_cpus as ARM

Re: [Qemu-devel] [PATCH v3] virtio-pci: Fix cross-version migration with older machines

2016-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 09:26:56AM +0100, Cornelia Huck wrote: > On Thu, 15 Dec 2016 07:38:09 + > Stefan Hajnoczi wrote: > > > On Wed, Dec 14, 2016 at 05:30:35PM +0100, Maxime Coquelin wrote: > > > This patch fixes a cross-version migration regression introduced > > > by

Re: [Qemu-devel] [PATCH 02/11] hw/arm/virt: use VirtMachineState.gic_version

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:13 +0100 Andrew Jones wrote: > machvirt_init may need to probe for the gic version. If so, then > make sure the result is written to VirtMachineState. With the > state up to date, use it instead of a local variable. This is a > cleanup that prepares

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-15 Thread Marcel Apfelbaum
On 12/14/2016 10:10 PM, Laine Stump wrote: On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: On 12/13/2016 06:00 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100,

[Qemu-devel] [Bug 1650175] Re: wrong version in 2.8.0-rc03

2016-12-15 Thread Stefan Hajnoczi
This is intentional and is the way that QEMU release candidates are versioned. The versioning scheme is MAJOR.MINOR.PATCH where: 0 >= PATCH < 90 is a stable release PATCH = 90 is the development window for the next MINOR release 91 >= PATCH <= 99 is a release candidate for the next MINOR release

[Qemu-devel] [Bug 1650175] Re: wrong version in 2.8.0-rc03

2016-12-15 Thread Stefan Hajnoczi
Not a bug. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1650175 Title: wrong version in 2.8.0-rc03 Status in QEMU: Invalid Bug description:

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-15 Thread Alex Bligh
> On 14 Dec 2016, at 20:18, Wouter Verhelst wrote: > >> +* the server MAY return a context consisting of a namespace and >> + a colon only (i.e. omitting the leaf-name) to indicate that >> + the namespace contains a large number of possible contexts >> + within

[Qemu-devel] [PATCHv2] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
get_opt_value() truncates the value at the first comma Use memcpy() instead Unescape the module filename and parameters with get_opt_value() before calling mb_add_cmdline() Signed-off-by: Vlad Lungu --- hw/i386/multiboot.c | 18 ++ 1 file changed, 10

Re: [Qemu-devel] [PATCH] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
Sorry about replying to myself, I only had one coffee today. There is no need for mb_add_modstring(), we can simply do get_opt_value(tmpbuf,..) then mb_add_cmdline(, tmpbuf) Regards, Vlad On 12/15/2016 11:45 AM, Vlad Lungu wrote: > get_opt_value() truncates the value at the first comma >

Re: [Qemu-devel] question about qemu IO process

2016-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 02:50:41PM +0800, ous...@sina.com wrote: > I recently try to figure out the the whole IO process in qemu, I have traced > most parts of this process, but I'm still confused about how guest OS notify > qemu to handle virtqueue > I traced to virtio_queue_host_notifier_read

Re: [Qemu-devel] [PATCH 01/11] hw/arm/virt: parameter passing cleanups

2016-12-15 Thread Igor Mammedov
On Tue, 13 Dec 2016 22:45:12 +0100 Andrew Jones wrote: > Some simple cleanups made possible by "hw/arm/virt: Merge > VirtBoardInfo and VirtMachineState" > > Signed-off-by: Andrew Jones Reviewed-by: Igor Mammedov > --- >

Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault

2016-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 09:47:38AM +0100, Kevin Wolf wrote: > Am 14.12.2016 um 23:49 hat Michael S. Tsirkin geschrieben: > > On Wed, Dec 14, 2016 at 02:25:18PM +, Stefan Hajnoczi wrote: > > > The "Copy" menu item copies VTE terminal text to the clipboard. This > > > only works with VTE

[Qemu-devel] [PATCH] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-15 Thread Vlad Lungu
get_opt_value() truncates the value at the first comma Rename mb_add_cmdline() to mb_add_modstring() Unescape filename too Add new mb_add_cmdline() using memcpy() Signed-off-by: Vlad Lungu --- hw/i386/multiboot.c | 23 +-- 1 file changed, 17

Re: [Qemu-devel] [PATCH] multiboot: copy the cmdline verbatim

2016-12-15 Thread Vlad Lungu
On 12/15/2016 12:32 AM, Paolo Bonzini wrote: In other words: this fixes the mb_add_cmdline(kcmdline) case, and doesn't break comma escaping on the initrd case (because it was already broken). I don't see a problem with this patch. >>> ... there is one case of comma escaping that

Re: [Qemu-devel] [PATCH for-2.9 v2] qapi: add explicit null to string input and output visitors

2016-12-15 Thread Markus Armbruster
Greg Kurz writes: > This may be used for deprecated object properties that are kept for > backwards compatibility. > > Signed-off-by: Greg Kurz > --- > v2: - input visitor to reject non-empty strings > > This is needed for David's patch to work: > > [RFCv2 10/12]

Re: [Qemu-devel] [RFC v2] qmp: query-device-slots command

2016-12-15 Thread Igor Mammedov
On Wed, 14 Dec 2016 17:39:08 -0200 Eduardo Habkost wrote: > This adds a new command to QMP: query-device-slots. It will allow > management software to query possible slots where devices can be > plugged. > > This implementation of the command will return: > > * Multiple

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix boot path of usb-host storage devices

2016-12-15 Thread Gerd Hoffmann
Hi, > That's true for the default case, but for the pseries machine, there is > already code that changes the boot path for virtual usb-storage devices, > see the function spapr_get_fw_dev_path() : > > ... else if (usb) { > /* > * We use SRP luns of the form

Re: [Qemu-devel] Making TCG configurable in system mode

2016-12-15 Thread Laurent Vivier
On 14/12/2016 20:30, Alvise Rigo wrote: > Hi all, > > I am looking at the possibility to add a new QEMU configuration option > to make TCG optional (in qemu-system-*). What I am exploring is a way > to exclude any of the TCG code not needed by KVM from the QEMU binary. > There has been a

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-15 Thread Gerd Hoffmann
On Do, 2016-12-15 at 07:50 +, Stefan Hajnoczi wrote: > On Thu, Dec 15, 2016 at 06:35:39AM +0200, Michael S. Tsirkin wrote: > > The problem always reproduces for me: > > - start qemu with -sdl > > - wait for guest to boot > > - click anywhere within guest screen > > - message "press ctrl+alt to

Re: [Qemu-devel] [PATCH v3] qom: Make all interface types abstract

2016-12-15 Thread Markus Armbruster
Eduardo Habkost writes: > "qom-list-types abstract=false" currently returns all interface > types, as if they were not abstract. Fix this by making sure all > interface types are abstract. > > All interface types have instance_size == 0, so we can use > it to set

[Qemu-devel] [Bug 1650175] [NEW] wrong version in 2.8.0-rc03

2016-12-15 Thread Giuseppe Mastrangelo
Public bug reported: When you compile qemu the version still 2.7.93 instead 2.8.0-rc03 build/config-host.mak:VERSION=2.7.93 ** Affects: qemu Importance: Undecided Status: New ** Tags: version -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault

2016-12-15 Thread Kevin Wolf
Am 14.12.2016 um 23:49 hat Michael S. Tsirkin geschrieben: > On Wed, Dec 14, 2016 at 02:25:18PM +, Stefan Hajnoczi wrote: > > The "Copy" menu item copies VTE terminal text to the clipboard. This > > only works with VTE terminals, not with graphics consoles. > > > > Disable the menu item when

Re: [Qemu-devel] [PATCH for-2.9 V3 1/3] Migration: Don't load vmdesc when xen is enabled

2016-12-15 Thread Zhang Chen
On 12/15/2016 02:46 PM, Zhang Chen wrote: On 12/14/2016 09:00 AM, Stefano Stabellini wrote: On Fri, 9 Dec 2016, Zhang Chen wrote: Xen doesn't need this. Could you please elaborate a bit more on what is the problem exactly, and why we don't have any issues with migration with Xen today

[Qemu-devel] question about qemu IO process

2016-12-15 Thread ousuju
Hello, I'm a newbie of Qemu. sorry about my stupid question. I recently try to figure out the the whole IO process in qemu, I have traced most parts of this process, but I'm still confused about how guest OS notify qemu to handle virtqueue I traced to virtio_queue_host_notifier_read ->

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

2016-12-15 Thread Rowan Potgieter
I can confirm that this issue is still present with: QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.6) Kernel: 4.4.0-53-generic I am using Packer and the QEMU builder and only the \ key was working in a Windows Guest. I had created folder called "common" to host all the Windows

Re: [Qemu-devel] [PATCH v3] virtio-pci: Fix cross-version migration with older machines

2016-12-15 Thread Cornelia Huck
On Thu, 15 Dec 2016 07:38:09 + Stefan Hajnoczi wrote: > On Wed, Dec 14, 2016 at 05:30:35PM +0100, Maxime Coquelin wrote: > > This patch fixes a cross-version migration regression introduced > > by commit d1b4259f ("virtio-bus: Plug devices after features are > >

Re: [Qemu-devel] commit virtio: recalculate vq->inuse after migration might cause last_avail_idx vs. used_idx failure

2016-12-15 Thread Stefan Hajnoczi
On Wed, Dec 14, 2016 at 08:12:17PM +0100, Halil Pasic wrote: > We have a migration problem, which is in my opinion caused by a > deficiency in how vq->inuse is calculated after the migration (commit > bccdef6b "virtio: recalculate vq->inuse after migration" to > blame). > > > We got a bugreport

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 12:17:09AM -0500, Weiwei Jia wrote: > BTW, do we have an example to show users how to config following > virtio-blk dataplane commands into XML configuration file? > > qemu -object iothread,id=iothread0 \ > -drive if=none,id=drive0,file=test.img,format=raw,cache=none

Re: [Qemu-devel] Lock contention in QEMU

2016-12-15 Thread Stefan Hajnoczi
On Wed, Dec 14, 2016 at 08:06:10PM -0500, Weiwei Jia wrote: > Hi Stefan, > > Thanks for your reply. Please see the inline replies. > > On Wed, Dec 14, 2016 at 2:31 PM, Stefan Hajnoczi wrote: > > On Wed, Dec 14, 2016 at 12:58:11AM -0500, Weiwei Jia wrote: > >> I find the

<    1   2