Re: [Qemu-devel] [PATCH v5 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types

2017-01-12 Thread Laszlo Ersek
On 01/12/17 13:40, Eduardo Habkost wrote: > On Wed, Jan 11, 2017 at 06:35:28PM +0100, Laszlo Ersek wrote: >> Cc: "Michael S. Tsirkin" >> Cc: Eduardo Habkost >> Cc: Gerd Hoffmann >> Cc: Igor Mammedov >> Cc: Paolo Bonzini >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> v5: >> - re

[Qemu-devel] [PATCH 6/7] target-ppc: Add xvtstdc[sp, dp] instructions

2017-01-12 Thread Nikunj A Dadhania
xvtstdcsp: VSX Vector Test Data Class Single-Precision xvtstdcdp: VSX Vector Test Data Class Double-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 50 + target/ppc/helper.h | 2 ++ target/ppc/internal.h

Re: [Qemu-devel] [PATCH v5 wave 1 0/4] fw-cfg: support writeable blobs and more files

2017-01-12 Thread Laszlo Ersek
On 01/12/17 15:30, Michael S. Tsirkin wrote: > On Wed, Jan 11, 2017 at 06:34:53PM +0100, Laszlo Ersek wrote: >> This is the first (fw_cfg) half of the v5 iteration of the series posted >> here: >> . >> >> In this version, the fw

Re: [Qemu-devel] [PATCH v3 2/3] cpu_common_reset: wrap TCG specific code in tcg_enabled()

2017-01-12 Thread Richard Henderson
On 01/12/2017 07:47 AM, Alex Bennée wrote: Both the cpu->tb_jmp_cache and SoftMMU TLB structures are only used when running TCG code so we might as well skip them for anything else. Signed-off-by: Alex Bennée --- qom/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Revi

[Qemu-devel] [PATCH 0/7] POWER9 TCG enablements - part12

2017-01-12 Thread Nikunj A Dadhania
This series contains 11 new instructions for POWER9 ISA3.0 VSX Scalar Test Data Class VSX Vector Test Data Class VSX Vector Convert HP/SP VSX Scalar Multiply/Divide VSX Scalar Convert Unsigned/Signed Doubleword Bharata B Rao (4): target-ppc: Use ppc_vsr_t.f128 in xscmp[o,u,ex

Re: [Qemu-devel] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread Michael Roth
Quoting Laine Stump (2017-01-12 08:52:10) > On 01/12/2017 05:31 AM, Andrea Bolognani wrote: > > On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote: > * To allow for hotplugged devices, libvirt should also add a number > of additional, empty vPHBs (the PAPR spec allows for hot

Re: [Qemu-devel] [PATCH v2] vfio/pci: Support error recovery

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 09:53:25AM +0800, Cao jin wrote: > > > On 01/10/2017 11:11 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 10, 2017 at 07:46:17PM +0800, Cao jin wrote: > >> > >> > >> On 01/10/2017 07:04 AM, Michael S. Tsirkin wrote: > >>> On Sat, Dec 31, 2016 at 05:15:36PM +0800, Cao jin wr

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-12 Thread Marcel Apfelbaum
On 01/12/2017 06:20 PM, Michael S. Tsirkin wrote: On Thu, Jan 12, 2017 at 06:05:20PM +0200, Marcel Apfelbaum wrote: On 01/12/2017 05:56 PM, Michael S. Tsirkin wrote: On Wed, Jan 11, 2017 at 02:18:53PM +0200, Marcel Apfelbaum wrote: v1 -> v2: - Rebased on master. The Generic Root Port behaves

[Qemu-devel] [PATCH 4/7] target-ppc: Add xsmulqp instruction

2017-01-12 Thread Nikunj A Dadhania
From: Bharata B Rao xsmulqp: VSX Scalar Multiply Quad-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 35 +++ target/ppc/helper.h | 1 + target/ppc/translate/vsx-impl.inc.c | 1

Re: [Qemu-devel] [PATCH v5 wave 1 2/4] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2017-01-12 Thread Laszlo Ersek
On 01/12/17 15:29, Michael S. Tsirkin wrote: > On Wed, Jan 11, 2017 at 06:34:55PM +0100, Laszlo Ersek wrote: >> We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could >> lead to problems with backward migration: a more recent QEMU (running an >> older machine type) would allow th

[Qemu-devel] [PATCH 3/7] target-ppc: Add xsdivqp instruction

2017-01-12 Thread Nikunj A Dadhania
From: Bharata B Rao xsdivqp: VSX Scalar Divide Quad-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 36 target/ppc/helper.h | 1 + target/ppc/translate/vsx-impl.inc.c | 1 +

Re: [Qemu-devel] [PATCH] linux-user: Use *at functions instead of caching interp_prefix contents

2017-01-12 Thread Richard Henderson
On 01/12/2017 02:35 AM, Peter Maydell wrote: On 12 January 2017 at 04:05, Richard Henderson wrote: If the interp_prefix is a complete chroot, it may have a *lot* of files. Setting up the cache for this is quite expensive. Instead, use the *at versions of various syscalls to attempt the operati

[Qemu-devel] [PATCH 7/7] target-ppc: Add xststdc[sp, dp, qp] instructions

2017-01-12 Thread Nikunj A Dadhania
xststdcsp: VSX Scalar Test Data Class Single-Precision xststdcdp: VSX Scalar Test Data Class Double-Precision xststdcqp: VSX Scalar Test Data Class Quad-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 76 + target/ppc/helpe

[Qemu-devel] [PATCH 2/7] target-ppc: Add xscvsdqp and xscvudqp instructions

2017-01-12 Thread Nikunj A Dadhania
From: Bharata B Rao xscvsdqp: VSX Scalar Convert Signed Doubleword format to Quad-Precision format xscvudqp: VSX Scalar Convert Unsigned Doubleword format to Quad-Precision format Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c

[Qemu-devel] [PATCH 5/7] target-ppc: Add xvcv[hpsp, sphp] instructions

2017-01-12 Thread Nikunj A Dadhania
xvcvhpsp: VSX Vector Convert Half Precision to Single Precision xvcvsphp: VSX Vector Convert Single Precision to Half Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 27 ++- target/ppc/helper.h | 2 ++ target/ppc/trans

Re: [Qemu-devel] [PATCH] ide: avoid unbounded recursion

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 15:11, Stefan Hajnoczi wrote: > On Thu, Jan 12, 2017 at 11:51:32AM +0100, Paolo Bonzini wrote: >> The end_transfer_func can call ide_transfer_start immediately, before >> returning, and unbounded recursion can happen at least for >> ide_atapi_cmd_reply_end. Use a bottom half to def

[Qemu-devel] [PATCH 1/7] target-ppc: Use ppc_vsr_t.f128 in xscmp[o, u, exp]qp

2017-01-12 Thread Nikunj A Dadhania
From: Bharata B Rao xscmpoqp, xscmpuqp & xscmpexpqp were added before f128 field was introduced in ppc_vsr_t. Now that we have it, use it instead of generating the 128 bit float using two 64bit fields. Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c |

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Markus Armbruster
Thomas Huth writes: > When running certain HMP commands ("info registers", "info cpustats", > "nmi", "memsave" or dumping virtual memory) with the "none" machine, > QEMU crashes with a segmentation fault. This happens because the "none" > machine does not have any CPUs by default, but these HMP c

Re: [Qemu-devel] [PATCH 16/40] char: get rid of CharDriver

2017-01-12 Thread Marc-André Lureau
Hi - Original Message - > On 01/11/2017 11:29 AM, Marc-André Lureau wrote: > > qemu_chr_new_from_opts() is modified to not need CharDriver backend[] > > array, but uses instead objectified qmp_query_chardev_backends() and > > char_get_class(). The alias field is moved outside in a ChardevA

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-12 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 06:05:20PM +0200, Marcel Apfelbaum wrote: > On 01/12/2017 05:56 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 11, 2017 at 02:18:53PM +0200, Marcel Apfelbaum wrote: > > > v1 -> v2: > > > - Rebased on master. > > > > > > The Generic Root Port behaves the same as the > > > In

Re: [Qemu-devel] [PATCH v5 0/4] Introduce a new --only-migratable option

2017-01-12 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 0/4] Introduce a new --only-migratable option Message-id: 1484236354-9640-1-git-send-email-ashijeetacha...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v3 3/3] cputlb: drop flush_global flag from tlb_flush

2017-01-12 Thread Alex Bennée
Alex Bennée writes: > We have never has the concept of global TLB entries which would avoid > the flush so we never actually use this flag. Drop it and make clear > that tlb_flush is the sledge-hammer it has always been. > And I immediately realise I missed out: > Signed-off-by: Alex Bennée >

Re: [Qemu-devel] [PULL 00/65] tcg 2.9 patch queue

2017-01-12 Thread Peter Maydell
On 11 January 2017 at 02:17, Richard Henderson wrote: > There are minimal changes since v5, mostly to handle conflicts > with the tcg mips64 patch set merged a few days ago. > > Thanks to Alex for reviewing the arm bits; and to Mark, Bastian, > David, and Yongbok for reviews of their respective cp

Re: [Qemu-devel] [PATCH] ide: avoid unbounded recursion

2017-01-12 Thread John Snow
On 01/12/2017 09:11 AM, Stefan Hajnoczi wrote: > On Thu, Jan 12, 2017 at 11:51:32AM +0100, Paolo Bonzini wrote: >> The end_transfer_func can call ide_transfer_start immediately, before >> returning, and unbounded recursion can happen at least for >> ide_atapi_cmd_reply_end. Use a bottom half to

Re: [Qemu-devel] [PATCH v5 wave 2 0/3] q35: add negotiable broadcast SMI

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 06:35:25PM +0100, Laszlo Ersek wrote: > This is the second (ICH9-LPC) half of the v5 iteration of the series > posted here: > . > > In this version, the ICH9-LPC patches have been separated into a > stan

Re: [Qemu-devel] [PATCH] ide: avoid unbounded recursion

2017-01-12 Thread John Snow
On 01/12/2017 05:51 AM, Paolo Bonzini wrote: > The end_transfer_func can call ide_transfer_start immediately, before > returning, and unbounded recursion can happen at least for > ide_atapi_cmd_reply_end. Use a bottom half to defer the call and > limit stack usage. > > Cc: Peter Lieven > Cc: J

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-12 Thread Marcel Apfelbaum
On 01/12/2017 05:56 PM, Michael S. Tsirkin wrote: On Wed, Jan 11, 2017 at 02:18:53PM +0200, Marcel Apfelbaum wrote: v1 -> v2: - Rebased on master. The Generic Root Port behaves the same as the Intel's IOH device with id 3420, without having Intel specific attributes. The device has two purpos

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 02:18:53PM +0200, Marcel Apfelbaum wrote: > v1 -> v2: > - Rebased on master. > > The Generic Root Port behaves the same as the > Intel's IOH device with id 3420, without having > Intel specific attributes. > > The device has two purposes: > (1) Can be used on both X86 an

[Qemu-devel] [PATCH v5 3/4] migration: disallow migrate_add_blocker during migration

2017-01-12 Thread Ashijeet Acharya
If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Add an errp parameter and a retcode return value to migrate_add_blocker. Signed-off-by: John Snow Signed-off-by: Ashijeet Acharya --- block/qcow.c | 7 ++- bl

[Qemu-devel] [PATCH v5 4/4] migration: Fail migration blocker for --only-migratable

2017-01-12 Thread Ashijeet Acharya
migrate_add_blocker should rightly fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Make migrate_add_blocker return -EACCES in this case. Signed-off-by: Ashijeet Acharya --- migration/migrati

[Qemu-devel] [PATCH v5 0/4] Introduce a new --only-migratable option

2017-01-12 Thread Ashijeet Acharya
Previously posted series patches: http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg01277.html http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg00320.html http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg02391.html http://lists.nongnu.org/archive/html/qemu-devel/2016-12

[Qemu-devel] [PATCH v5 2/4] migration: Allow "device add" options to only add migratable devices

2017-01-12 Thread Ashijeet Acharya
Introduce checks for the unmigratable flag in the VMStateDescription structs of respective devices when user attempts to add them. If the "--only-migratable" was specified, all unmigratable devices will rightly fail to add. This feature is made compatible for both "-device" and "-usbdevice" command

Re: [Qemu-devel] [PULL v2 05/11] sdl2: set window ID

2017-01-12 Thread Gerd Hoffmann
On Do, 2017-01-12 at 16:10 +0100, Stefan Weil wrote: > This commit breaks builds for Windows. See below for details. > Windows does not use X11. gcc fails: > > CC ui/sdl2.o > /qemu/ui/sdl2.c: In function ‘sdl_display_init’: > /qemu/ui/sdl2.c:821:54: error: ‘union ’ has no member named ‘x11

Re: [Qemu-devel] [PATCH V2 1/3] hw/pcie: Introduce a base class for PCI Express Root Ports

2017-01-12 Thread Marcel Apfelbaum
On 01/12/2017 05:36 PM, Michael S. Tsirkin wrote: On Wed, Jan 11, 2017 at 02:18:54PM +0200, Marcel Apfelbaum wrote: The 'base' PCI Express Root Port includes the common code to be re-used for all Root Ports implementations. Most of the code was taken from the current implementation of Intel's IO

[Qemu-devel] [PATCH v5 1/4] migration: Add a new option to enable only-migratable

2017-01-12 Thread Ashijeet Acharya
Add a new option "--only-migratable" in qemu which will allow to add only those devices which will not fail qemu after migration. Devices set with the flag 'unmigratable' cannot be added when this option will be used. Signed-off-by: Ashijeet Acharya Reviewed-by: Dr. David Alan Gilbert --- inclu

[Qemu-devel] [PATCH v3 1/3] qom/cpu: move tlb_flush to cpu_common_reset

2017-01-12 Thread Alex Bennée
It is a common thing amongst the various cpu reset functions want to flush the SoftMMU's TLB entries. This is done either by calling tlb_flush directly or by way of a general memset of the CPU structure (sometimes both). This moves the tlb_flush call to the common reset function and additionally e

[Qemu-devel] [PATCH v3 2/3] cpu_common_reset: wrap TCG specific code in tcg_enabled()

2017-01-12 Thread Alex Bennée
Both the cpu->tb_jmp_cache and SoftMMU TLB structures are only used when running TCG code so we might as well skip them for anything else. Signed-off-by: Alex Bennée --- qom/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qom/cpu.c b/qom/cpu.c index cc51de2a8

[Qemu-devel] [PATCH v3 3/3] cputlb: drop flush_global flag from tlb_flush

2017-01-12 Thread Alex Bennée
We have never has the concept of global TLB entries which would avoid the flush so we never actually use this flag. Drop it and make clear that tlb_flush is the sledge-hammer it has always been. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cputlb.c | 2

[Qemu-devel] [PATCH v3 0/3] Clean-up tlb_flush and cpu reset functions

2017-01-12 Thread Alex Bennée
Hi Richard, One minor change as suggested by Eduardo Habkost, I've split the tcg_enabled() change into a new patch. Otherwise I reckon this series is ready to go. Alex Bennée (3): qom/cpu: move tlb_flush to cpu_common_reset cpu_common_reset: wrap TCG specific code in tcg_enabled() cputlb: d

Re: [Qemu-devel] [Nbd] How to online resize qemu disk with nbd protocol?

2017-01-12 Thread Alex Bligh
> On 12 Jan 2017, at 14:43, Eric Blake wrote: > > That's because the NBD protocol lacks a resize command. You'd have to > first get that proposed as an NBD extension before qemu could support it. Actually the NBD protocol lacks a 'make a disk with size X' command, let alone a resize command. T

Re: [Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 14:34, Fam Zheng wrote: >> + */ >> +while ((*val & QEMU_LOCKCNT_STATE_MASK) != QEMU_LOCKCNT_STATE_FREE) { >> +if ((*val & QEMU_LOCKCNT_STATE_MASK) == QEMU_LOCKCNT_STATE_LOCKED) { >> +int expected = *val; >> +int new = expected - QEMU_LOCKCNT_S

Re: [Qemu-devel] [PATCH 3/3] object: make some funcs static

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 11:48, Michael Tokarev wrote: > 12.12.2016 20:31, Marc-André Lureau wrote: >> There is no need to have those functions as public API. > > Were "some" being object_initialize_with_type() and > object_new_with_type(). > > I'm applying this to -trivial, and Cc'ing Andreas, maybe > he

Re: [Qemu-devel] [PATCH V2 1/3] hw/pcie: Introduce a base class for PCI Express Root Ports

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 02:18:54PM +0200, Marcel Apfelbaum wrote: > The 'base' PCI Express Root Port includes > the common code to be re-used for all > Root Ports implementations. Most of the code > was taken from the current implementation > of Intel's IOH 3420 Root Port. > > Signed-off-by: Marce

Re: [Qemu-devel] [PATCH 12/40] char-win: do not override chr_free

2017-01-12 Thread Marc-André Lureau
- Original Message - > On 01/11/2017 11:29 AM, Marc-André Lureau wrote: > > For some unclear reason to me, char-file does not have chr_free on > > win32. Since we want to switch to instance finalizer instead of class > > chr_free, we should be able to run the base WinChardev class finaliz

Re: [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify

2017-01-12 Thread Marc-André Lureau
Hi - Original Message - > On 01/10/2017 11:48 AM, Marc-André Lureau wrote: > > Turn Chardev into Object. > > > > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It > > will call qemu_char_open() to open/intialize the chardev with the > > ChardevCommon *backend settings

Re: [Qemu-devel] [PULL v2 05/11] sdl2: set window ID

2017-01-12 Thread Stefan Weil
This commit breaks builds for Windows. See below for details. Regards Stefan Am 09.01.2017 um 14:09 schrieb Gerd Hoffmann: > From: Samuel Thibault > > This uses the console API to record the window ID of the SDL2 windows. > > Signed-off-by: Samuel Thibault > Message-id: 20161221003806.22412-4

Re: [Qemu-devel] [PATCH v7 03/10] pci: Convert msix_init() to Error and fix callers to check it

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 10:55:24AM +0100, Markus Armbruster wrote: > I guess some of the later patches are follow-up cleanups that could be > merged separately. Might require reordering, then re-review. But would > this really be worth the trouble? Merging through another tree is no > pixie dust

Re: [Qemu-devel] [PATCH v5 wave 1 2/4] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 06:34:55PM +0100, Laszlo Ersek wrote: > We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could > lead to problems with backward migration: a more recent QEMU (running an > older machine type) would allow the guest, in fw_cfg_select(), to select a > high ke

Re: [Qemu-devel] [PATCH v7 03/10] pci: Convert msix_init() to Error and fix callers to check it

2017-01-12 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:33PM +0800, Cao jin wrote: > msix_init() reports errors with error_report(), which is wrong when > it's used in realize(). The same issue was fixed for msi_init() in > commit 1108b2f. Is there some way to trigger this? Markus says "QMP is broken" so surely one can ma

Re: [Qemu-devel] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread Laine Stump
On 01/12/2017 05:31 AM, Andrea Bolognani wrote: On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote: * To allow for hotplugged devices, libvirt should also add a number of additional, empty vPHBs (the PAPR spec allows for hotplug of PHBs, but this is not yet implemented in qemu

Re: [Qemu-devel] [PATCH v2] qga: add systemd socket activation support

2017-01-12 Thread Stefan Hajnoczi
On Fri, Jan 06, 2017 at 03:29:30PM +, Stefan Hajnoczi wrote: > AF_UNIX and AF_VSOCK listen sockets can be passed in by systemd on > startup. This allows systemd to manage the listen socket until the > first client connects and between restarts. Advantages of socket > activation are that paral

Re: [Qemu-devel] How to online resize qemu disk with nbd protocol?

2017-01-12 Thread Eric Blake
On 01/12/2017 04:22 AM, Bob Chen wrote: > Hi, > > > My qemu runs on a 3rd party distributed block storage, and the disk backend > protocol is nbd. > > I notices that there are differences between default qcow2 local disk and > my nbd disk, in terms of resizing the disk on the fly. > > Local qco

Re: [Qemu-devel] [Qemu-block] NBD handshake may block qemu main thread when socket delays or has packet loss

2017-01-12 Thread Stefan Hajnoczi
On Wed, Jan 04, 2017 at 02:44:53PM -0600, Eric Blake wrote: > On 01/04/2017 02:45 AM, Fangyi (C) wrote: > > As we all know, socket is in blocking mode when nbd is negotiating > > with the other end. If the network is poor because of delay or packet > > loss, socket read or write will return ver

Re: [Qemu-devel] [PATCH v2 1/6] Add cfgend parameter for ARM CPU selection.

2017-01-12 Thread Julian Brown
On Wed, 11 Jan 2017 12:35:52 + Julian Brown wrote: > I'm a little confused, I think -- these changes seemed to be necessary > to allow the parsing of the command-line syntax you suggested earlier > (-mcpu=foo,cfgend=bar): > [...] > Can the existing properties be set like that via the command

Re: [Qemu-devel] [PATCH v5 wave 1 0/4] fw-cfg: support writeable blobs and more files

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 06:34:53PM +0100, Laszlo Ersek wrote: > This is the first (fw_cfg) half of the v5 iteration of the series posted > here: > . > > In this version, the fw_cfg patches have been separated into a > standalon

Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

2017-01-12 Thread Daniel P. Berrange
On Thu, Jan 12, 2017 at 09:48:20AM +0100, Paolo Bonzini wrote: > > > On 12/01/2017 02:02, Lluís Vilanova wrote: > > Paolo Bonzini writes: > > [...] > >> A weird idea: what about doing > > > >> -DGENERATED_TRACERS_H=\"hw/scsi/generated-tracers.h\" > > > >> and then having > > > >> #ifd

Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

2017-01-12 Thread Lluís Vilanova
Paolo Bonzini writes: > On 12/01/2017 02:02, Lluís Vilanova wrote: >> Paolo Bonzini writes: >> [...] >>> A weird idea: what about doing >> >>> -DGENERATED_TRACERS_H=\"hw/scsi/generated-tracers.h\" >> >>> and then having >> >>> #ifdef GENERATED_TRACE_H >>> #include GENERATED_TRACE_H >>> #endif >

Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property

2017-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 10:22:12AM +0800, Fam Zheng wrote: > On Thu, 01/12 09:22, Yang Zhang wrote: > > On 2017/1/4 22:44, Stefan Hajnoczi wrote: > > > On Tue, Jan 03, 2017 at 10:53:06AM -0600, Eric Blake wrote: > > > > On 12/29/2016 08:41 PM, Junkang Fu wrote: > > > > > >From 74e913fc41ea98d1dde69

Re: [Qemu-devel] [PATCH RFC v2 00/17] VT-d: vfio enablement and misc enhances

2017-01-12 Thread Michael S. Tsirkin
On Tue, Jan 03, 2017 at 03:29:37PM +0800, Peter Xu wrote: > (I renamed the title for this RFC v2, since starting from this version > the series will be based on master, also I picked up some more fixes > for vt-d into this series) > > v2: > - change comment for "end" parameter in vtd_page_walk()

Re: [Qemu-devel] [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > >> Hi, > >> > >>> > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > >>> [...] > + > +static struct crypto_alg virt

Re: [Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-12 Thread Stefan Hajnoczi
On Wed, Jan 11, 2017 at 09:58:35PM -, Jignasha wrote: > When tried zlib-flate -uncompress < cirros-0.3.4-x86_64-disk.img, > getting below error > > data: incorrect header check QEMU image compression uses the compression feature available in some disk image formats (like qcow2). This is not

Re: [Qemu-devel] [PATCH V4 net-next] vhost_net: device IOTLB support

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 12:32:12PM +0800, Jason Wang wrote: > This patches implements Device IOTLB support for vhost kernel. This is > done through: > > 1) switch to use dma helpers when map/unmap vrings from vhost codes > 2) introduce a set of VhostOps to: >- setting up device IOTLB request c

Re: [Qemu-devel] [PATCH v2 01/26] armv7m: MRS/MSR handle unprivileged access

2017-01-12 Thread Peter Maydell
On 17 December 2015 at 13:10, Peter Maydell wrote: > On 3 December 2015 at 00:18, Michael Davidsaver wrote: >> The MRS and MSR instruction handling isn't checking >> the current permission level. >> >> Prevent privlaged from changing writing EPSR fields. >> Access to unknown/undefined special reg

[Qemu-devel] [PATCH V12] fsdev: add IO throttle support to fsdev devices

2017-01-12 Thread Pradeep Jagadeesh
Signed-off-by: Pradeep Jagadeesh --- fsdev/Makefile.objs | 2 +- fsdev/file-op-9p.h | 3 ++ fsdev/qemu-fsdev-opts.c | 77 - fsdev/qemu-fsdev-throttle.c | 118 fsdev/qemu-fsdev-throttle.h | 39 +

Re: [Qemu-devel] Question about io mode & cache mode

2017-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 01:25:35PM +0900, morgenlette madeBy wrote: > I sent mail for question about io mode and cache mode. > > When I set VM to I/O mode = native and cache mode = none, > > Vm cannot boot and vm is turn off automatically. > > Why cannot VM boot? You didn't provide enough infor

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file

2017-01-12 Thread Peter Xu
On Thu, Jan 12, 2017 at 01:55:48PM +0100, Paolo Bonzini wrote: [...] > > diff --git a/scripts/functions.bash b/scripts/common.bash > > similarity index 75% > > rename from scripts/functions.bash > > rename to scripts/common.bash > > index ee9143c..2dd7360 100644 > > --- a/scripts/functions.bash >

Re: [Qemu-devel] [PATCH] ide: avoid unbounded recursion

2017-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 11:51:32AM +0100, Paolo Bonzini wrote: > The end_transfer_func can call ide_transfer_start immediately, before > returning, and unbounded recursion can happen at least for > ide_atapi_cmd_reply_end. Use a bottom half to defer the call and > limit stack usage. > > Cc: Peter

Re: [Qemu-devel] [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Christian Borntraeger
On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: >> Hi, >> >>> >>> On 12/15/2016 03:03 AM, Gonglei wrote: >>> [...] + +static struct crypto_alg virtio_crypto_algs[] = { { + .cra_name = "cbc(aes)", + .cra_driver_name = "virtio

Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"

2017-01-12 Thread Eduardo Habkost
On Thu, Jan 12, 2017 at 02:47:37PM +0100, Vincent Palatin wrote: > On Thu, Jan 12, 2017 at 2:25 PM, Eduardo Habkost wrote: > > On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote: > >> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4. > >> > >> The error "Failed to execut

[Qemu-devel] [PATCH v3 1/2] memory: tune mtree_print_mr() to dump mr type

2017-01-12 Thread Peter Xu
We were dumping RW bits for each memory region, that might be confusing. It'll make more sense to dump the memory region type directly rather than the RW bits since that's how the bits are derived. Meanwhile, with some slight cleanup in the function. Signed-off-by: Peter Xu --- memory.c | 48 ++

[Qemu-devel] [PATCH v3 0/2] memory: extend "info mtree" with flat view dump

2017-01-12 Thread Peter Xu
v3: - rather than dump flatview directly in "info mtree", provide a new parameter "-f" for it. [Paolo] - replace "RW" chars with the type of memory region [Paolo] - (cc dave as well since it touches HMP interface) v2: - fix a size error in patch 2 - add r-b for Marc-André in patch 1 Each addres

[Qemu-devel] [PATCH v3 2/2] memory: hmp: add "-f" for "info mtree"

2017-01-12 Thread Peter Xu
Adding one more option "-f" for "info mtree" to dump the flat views of all the address spaces. This will be useful to debug the memory rendering logic, also it'll be much easier with it to know what memory region is handling what address range. Signed-off-by: Peter Xu --- hmp-commands-info.hx

Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"

2017-01-12 Thread Vincent Palatin
On Thu, Jan 12, 2017 at 2:25 PM, Eduardo Habkost wrote: > On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote: >> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4. >> >> The error "Failed to execute helper program (No such file or directory)" >> is due to broken glib inst

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-12 Thread Artyom Tarasenko
On Thu, Jan 12, 2017 at 1:57 PM, Hervé Poussineau wrote: > Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >> >> Hi Hervé, >> >> nice work! >> >> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >> wrote: >>> >>> Hi, >>> >>> This patchset adds the emulation of the IBM RS/6000 7020 (40p). The

Re: [Qemu-devel] [PATCH v2 0/3] fix query-memdev not repporting IDs of memory backends

2017-01-12 Thread Eduardo Habkost
On Tue, Jan 10, 2017 at 01:53:12PM +0100, Igor Mammedov wrote: > > Changelog: > since v1: > * fix mistakes in commit messages/change them as suggested > * extend 3/3 commit message to explain why it's ok to use 'id' > * 3/3 set 'id' property directly instead of injectin

Re: [Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

2017-01-12 Thread Fam Zheng
On Wed, 01/04 14:26, Paolo Bonzini wrote: > diff --git a/include/qemu/futex.h b/include/qemu/futex.h > new file mode 100644 > index 000..852d612 > --- /dev/null > +++ b/include/qemu/futex.h > @@ -0,0 +1,36 @@ > +/* > + * Wrappers around Linux futex syscall > + * > + * Copyright Red Hat, Inc. 20

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 3/3] run_tests: allow run tests in parallel

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 12:42, Andrew Jones wrote: > On Thu, Jan 12, 2017 at 11:36:22AM +0800, Peter Xu wrote: >> run_task.sh is getting slow. This patch is trying to make it faster by >> running the tests concurrently. >> >> We provide a new parameter "-j" for the run_tests.sh, which can be used >> to spe

Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote: > This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4. > > The error "Failed to execute helper program (No such file or directory)" > is due to broken glib installation, missing windows gspawn helpers. > > Signed-off-by:

[Qemu-devel] [PATCH 1/2] Revert "virtio: turn vq->notification into a nested counter"

2017-01-12 Thread Stefan Hajnoczi
This reverts commit aff8fd18f1786fc5af259a9bc0077727222f51ca. Both virtio-net and virtio-crypto do not balance virtio_queue_set_notification() enable and disable calls. This makes the notifications_disabled counter unreliable and Doug Goldstein reported the following assertion failure: #3 0x0

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer

2017-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 11:18:25AM +0800, Xiao Guangrong wrote: > > > On 01/11/2017 05:36 PM, Stefan Hajnoczi wrote: > > Unlike g_free(), g_array_free() does not accept a NULL pointer argument. > > The following error is logged when an nvdimm device is realized: > > > > GLib-CRITICAL **: g_arr

[Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-12 Thread Stefan Hajnoczi
The virtio_queue_set_notification() nesting introduced for AioContext polling raised an assertion with virtio-net (even in non-polling mode). Converting virtio-net and virtio-crypto to use virtio_queue_set_notification() in a nesting fashion would be invasive and isn't worth it. Patch 1 contains

[Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded

2017-01-12 Thread Stefan Hajnoczi
While AioContext is in polling mode virtqueue notifications are not necessary. Some device virtqueue handlers enable notifications. Make sure they stay disabled to avoid unnecessary vmexits. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 3 +++ 1 file changed, 3 insertions(+) diff --

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer

2017-01-12 Thread Stefan Hajnoczi
On Wed, Jan 11, 2017 at 09:44:43AM +, Stefan Hajnoczi wrote: > Unlike g_free(), g_array_free() does not accept a NULL pointer argument. > The following error is logged when an nvdimm device is realized: > > GLib-CRITICAL **: g_array_free: assertion 'array' failed > > Cc: Xiao Guangrong > S

Re: [Qemu-devel] [PATCH v7 15/21] qapi: add qapi2texi script

2017-01-12 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > As the name suggests, the qapi2texi script converts JSON QAPI >> > description into a texi file suitable for different target >> > formats (info/man/txt/pdf/html...). >> > >> > It parses the fol

[Qemu-devel] [PULL 2/2] travis: add Trusty with clang stable build

2017-01-12 Thread Alex Bennée
Although we've reduced the matrix to avoid repeating clang builds we can still add an additional clang build to use the latest stable version of clang which will typically be available on current distros. Signed-off-by: Alex Bennée --- .travis.yml | 20 1 file changed, 20 in

[Qemu-devel] [PULL 0/2] Travis updates

2017-01-12 Thread Alex Bennée
The following changes since commit b44486dfb9447c88e4b216e730adcc780190852c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20170110-1' into staging (2017-01-10 14:52:34 +) are available in the git repository at: https://github.com/stsquad/qemu.git tags/pull-travi

[Qemu-devel] [PULL 1/2] travis: trim out most clang builds

2017-01-12 Thread Alex Bennée
From: "Daniel P. Berrange" We test with both gcc and clang in order to detect cases where clang issues warnings that gcc misses. To achieve this though we don't need to build QEMU in multiple different configurations. Just a single clang-on-linux build will be sufficient, if we have an "all enabl

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-12 Thread Alex Bligh
> On 12 Jan 2017, at 11:43, Vladimir Sementsov-Ogievskiy > wrote: > > From "NBD_OPT_LIST_META_CONTEXT (9)": >> The server MUST either reply with an error (for instance EINVAL if the >> option is not supported), or reply with a list of NBD_REP_META_CONTEXT >> replies followed by NBD_REP_ACK.:

Re: [Qemu-devel] [PATCH v5 wave 1 2/4] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 11, 2017 at 06:34:55PM +0100, Laszlo Ersek wrote: [...] > static Property fw_cfg_io_properties[] = { > DEFINE_PROP_UINT32("iobase", FWCfgIoState, iobase, -1), > DEFINE_PROP_UINT32("dma_iobase", FWCfgIoState, dma_iobase, -1), > DEFINE_PROP_BOOL("dma_enabled", FWCfgIoState

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-12 Thread Alex Bligh
> On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy > wrote: > > Yes this is better. But is it actually needed to force contexts have some > safe default? If context wants it may define such default without this > requirement.. So, should it be requirement at all? I've changed this to:

Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()

2017-01-12 Thread Peter Xu
On Thu, Jan 12, 2017 at 12:19:21PM +0100, Paolo Bonzini wrote: > > > On 12/01/2017 10:46, Peter Xu wrote: > > Yes, above suggestion makes sense to me, since after all the RW > > permissions are derived from the type of memory regions, and the type > > itself tells more things than the RW bits. So

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Eduardo Habkost
On Thu, Jan 12, 2017 at 12:38:00PM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > A recent glibc commit[1] added a blacklis

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-12 Thread Hervé Poussineau
Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : Hi Hervé, nice work! On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau wrote: Hi, This patchset adds the emulation of the IBM RS/6000 7020 (40p). The real machine is able to run AIX (up to 4.3.3), Windows NT (up to 4.0 SP1), the beta of OS/

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 04:36, Peter Xu wrote: > We were using test.log before to keep all the test logs. This patch > creates one log file per test case under logs/ directory with name > "TESTNAME.log". Meanwhile, we will keep the last time log into > logs.old/. > > Renaming scripts/functions.bash into s

Re: [Qemu-devel] [PATCH v5 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 11, 2017 at 06:35:28PM +0100, Laszlo Ersek wrote: > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Paolo Bonzini > Signed-off-by: Laszlo Ersek > --- > > Notes: > v5: > - replace the v4 patch "hw/i386/pc_q35: advertise broadcas

[Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes with a segmentation fault. This happens because the "none" machine does not have any CPUs by default, but these HMP commands did not check for a va

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > A recent glibc commit[1] added a blacklist to ensure it won't use > > > TSX on hosts that are known to have a broken TSX

Re: [Qemu-devel] [PATCH 4/5] pc: Add 2.9 machine-types

2017-01-12 Thread Eduardo Habkost
On Tue, Jan 10, 2017 at 06:06:33AM +0200, Michael S. Tsirkin wrote: > On Sun, Jan 08, 2017 at 05:40:40PM -0200, Eduardo Habkost wrote: > > Cc: "Michael S. Tsirkin" > > Cc: Laszlo Ersek > > Cc: Igor Mammedov > > Signed-off-by: Eduardo Habkost > > Do I understand it correctly that you are mergin

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Eduardo Habkost
On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > A recent glibc commit[1] added a blacklist to ensure it won't use > > TSX on hosts that are known to have a broken TSX implementation. > > > > Our existing Haswell CPU model

Re: [Qemu-devel] [PATCH v2] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
On 12.01.2017 13:19, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> When running certain HMP commands ("info registers", "info cpustats", >> "nmi", "memsave" or dumping virtual memory) with the "none" machine, >> QEMU crashes with a segmentation fault. This happens becau

<    1   2   3   4   >