Re: [Qemu-devel] [PATCH] net: Mark 'vlan' parameter as deprecated

On 25.01.2017 08:50, Jason Wang wrote: > > > On 2017年01月24日 17:42, Thomas Huth wrote: >> The 'vlan' parameter is a continuous source of confusion for the users, >> many people mix it up with the more common term VLAN (the link layer >> packet encapsulation), and even if they realize that the

Re: [Qemu-devel] [PATCH] net: Mark 'vlan' parameter as deprecated

On 2017年01月24日 17:42, Thomas Huth wrote: The 'vlan' parameter is a continuous source of confusion for the users, many people mix it up with the more common term VLAN (the link layer packet encapsulation), and even if they realize that the QEMU 'vlan' is rather some kind of network hub

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

On 2017年01月25日 14:44, Peter Xu wrote: On Wed, Jan 25, 2017 at 06:37:23AM +, Tian, Kevin wrote: From: Peter Xu [mailto:pet...@redhat.com] Sent: Wednesday, January 25, 2017 11:46 AM On Wed, Jan 25, 2017 at 11:09:39AM +0800, Jason Wang wrote: On 2017年01月24日 12:52, Peter Xu wrote: On Mon,

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

On 2017年01月25日 09:31, Alex Williamson wrote: On Wed, 25 Jan 2017 09:19:25 +0800 Jason Wang wrote: On 2017年01月24日 03:40, Alex Williamson wrote: On Mon, 23 Jan 2017 18:23:44 +0800 Jason Wang wrote: On 2017年01月23日 11:34, Peter Xu wrote: On Mon,

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

On Tue, 24 Jan 2017 11:18:07 + Peter Maydell wrote: > So my issue with this is that currently linux-user is pretty > well maintained and tested, but bsd-user is basically unmaintained > and not even compile tested. I can say it compiles. I've tried to build it on

Re: [Qemu-devel] [RFC PATCH 3/3] Introduce libtcg infrastructure

On Tue, 24 Jan 2017 10:08:56 + Marc-André Lureau wrote: > > > * If there's at least a *-libtcg, compile everything as position > > independent code. > > why not limit it to libtcg code? > At least we have to enable it on "common" object files (those compiled

Re: [Qemu-devel] [RFC PATCH 2/3] *-user targets object files decoupling

On Tue, 24 Jan 2017 10:09:25 + Marc-André Lureau wrote: > > diff --git a/exec.c b/exec.c > index 47835c1dc1..66f8187281 100644 > --- a/exec.c > +++ b/exec.c > @@ -672,9 +672,11 @@ void cpu_exec_unrealizefn(CPUState *cpu) > if (cc->vmsd != NULL) { >

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

On Tue, 24 Jan 2017 10:10:08 + Marc-André Lureau wrote: > > Looks good. Probably worth to mention that the main difference is in > commit 658f2dc970996d547a641b5685e384ebe6f2648e not being applied to > bsd-user. > Yeah, I'll rebase my next patches on master.

Re: [Qemu-devel] [PATCH v2] qmp: Fix argument name in error message of device-list-properties

Lin Ma writes: > The argument is called "typename", not "name". > > [Thanks to Markus for correcting the commit message] > > Signed-off-by: Lin Ma > --- > qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qmp.c b/qmp.c > index

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

Hi, > > I have read all the discuss, very long and useful, but I think I still > > need some > > time to get a full understand. So I think one of you can provide the > > formal patch to > > describe the issue in more detail. > > Your patch is almost correct. New version out for review. >

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

Hi, > > The negative pitch means (I think) that "addr" points to the lower > > left corner of the rectangle. > > > > The second part guarantees that the last blitted byte fits (lower > > right corner). > > To which Gerd responded "upper left". In retrospect I don't understand > why we didn't

[Qemu-devel] [PATCH] cirrus: fix oob access issue (CVE-2017-TODO)

From: Li Qiang When doing bitblt copy in backward mode, we should minus the blt width first just like the adding in the forward mode. This can avoid the oob access of the front of vga's vram. Signed-off-by: Li Qiang Message-id:

[Qemu-devel] [PATCH 2/2] savevm: Add new helpers to process the different stages of loadvm/savevm

There are several stages during loadvm/savevm process. In different stage, migration incoming processes different types of sections. We want to control these stages more accuracy, it will benefit COLO performance, we don't have to save type of QEMU_VM_SECTION_START sections everytime while do

[Qemu-devel] [PATCH 1/2] savevm: split save/find loadvm_handlers entry into two helper functions

COLO's checkpoint process is based on migration process, everytime we do checkpoint we will repeat the process of savevm and loadvm. So we will call qemu_loadvm_section_start_full() repeatedly, It will add all migration sections information into loadvm_handlers list everytime, which will lead to

[Qemu-devel] [PATCH 0/2] savevm: some improvements benefit COLO's later optimization

Hi, This series is split from previous COLO frame version which i post long time ago. These two patches are prerequisite for the later COLO optimization. Since it is independent, I'd like to post it as a single series. Both of them have been reviewed by Dave before, compared with old version, I

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

On Wed, Jan 25, 2017 at 06:37:23AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Wednesday, January 25, 2017 11:46 AM > > > > On Wed, Jan 25, 2017 at 11:09:39AM +0800, Jason Wang wrote: > > > > > > > > > On 2017年01月24日 12:52, Peter Xu wrote: > > > >On Mon, Jan

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, January 25, 2017 11:46 AM > > On Wed, Jan 25, 2017 at 11:09:39AM +0800, Jason Wang wrote: > > > > > > On 2017年01月24日 12:52, Peter Xu wrote: > > >On Mon, Jan 23, 2017 at 06:36:17PM +0800, Jason Wang wrote: > > >> > > >>On 2017年01月20日

Re: [Qemu-devel] [PATCH v4 3/9] docs: VM Generation ID device description

On 01/25/17 02:43, b...@skyportsystems.com wrote: > From: Ben Warren > > This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) (1) This commit msg line is too long; please wrap it at 74 chars. > > Signed-off-by: Gal Hammer

[Qemu-devel] [PATCH v2] qmp: Fix argument name in error message of device-list-properties

The argument is called "typename", not "name". [Thanks to Markus for correcting the commit message] Signed-off-by: Lin Ma --- qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index 0028f0b..886059e 100644 --- a/qmp.c +++ b/qmp.c @@

Re: [Qemu-devel] [for 2.9] migration/tracing: Add tracing on save

On (Mon) 12 Dec 2016 [12:58:38], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add some tracing to vmstate_subsection_save and vmstate_save_state > to help in debugging when you're not sure if a conditional piece > of data is being saved. > > In

Re: [Qemu-devel] [PATCH v5 00/18] VT-d: vfio enablement and misc enhances

On Tue, Jan 24, 2017 at 04:48:49PM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 07:49:10PM +0800, Peter Xu wrote: > > On Tue, Jan 24, 2017 at 06:25:53PM +0800, Peter Xu wrote: > > > This is v5 of vt-d vfio enablement series. > > > > > > Most of the changes in v5 is not functionally,

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

On Tue, Jan 24, 2017 at 09:29:05AM -0700, Alex Williamson wrote: > On Tue, 24 Jan 2017 18:25:55 +0800 > Peter Xu wrote: > > > A cleanup for vfio_iommu_map_notify(). Should have no functional change, > > just to make the function shorter and easier to understand. > > > >

Re: [Qemu-devel] [PATCH v4 2/9] linker-loader: Add new 'allocate and return address' cmd

On 01/25/17 02:43, b...@skyportsystems.com wrote: > From: Ben Warren > > This adds a new linker-loader command to instruct the guest to allocate > memory for a fw_cfg file and write the address back into another > writeable fw_cfg file. Knowing this address, QEMU can

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

On Wed, Jan 25, 2017 at 11:11:30AM +0800, Jason Wang wrote: > > > On 2017年01月24日 15:31, Peter Xu wrote: > >On Mon, Jan 23, 2017 at 06:40:12PM +0800, Jason Wang wrote: > >>On 2017年01月20日 21:08, Peter Xu wrote: > >>> static int vtd_replay_hook(IOMMUTLBEntry *entry, void *private) > >>> { > >>>

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

On Tue, Jan 24, 2017 at 09:24:29AM -0700, Alex Williamson wrote: [...] > > I see. Then this will be an strict requirement that we cannot do > > coalescing during page walk, at least for mappings. > > > > I didn't notice this before, but luckily current series is following > > the rule above -

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

Hi Ben, sorry about being late to reviewing this series. I hope I can now spend more time on it. - Please do not try to address my comments immediately. It's very possible (even likely) that Igor, MST and myself could have different opinions on things, so first please await agreement between

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

On Wed, Jan 25, 2017 at 11:09:39AM +0800, Jason Wang wrote: > > > On 2017年01月24日 12:52, Peter Xu wrote: > >On Mon, Jan 23, 2017 at 06:36:17PM +0800, Jason Wang wrote: > >> > >>On 2017年01月20日 21:08, Peter Xu wrote: > >>>Before this one we only invalidate context cache when we receive context >

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

On 01/25/17 02:18, Li Qiang wrote: > > > 2017-01-25 0:12 GMT+08:00 Laszlo Ersek >: > > On 01/24/17 16:31, Wolfgang Bumiller wrote: > > On Tue, Jan 24, 2017 at 01:29:58PM +0100, Gerd Hoffmann wrote: > >> if (pitch < 0) { >

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

On 2017年01月24日 15:31, Peter Xu wrote: On Mon, Jan 23, 2017 at 06:40:12PM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: static int vtd_replay_hook(IOMMUTLBEntry *entry, void *private) { memory_region_notify_one((IOMMUNotifier *)private, entry); @@ -2711,13 +2768,16

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

On 2017年01月24日 12:52, Peter Xu wrote: On Mon, Jan 23, 2017 at 06:36:17PM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a

[Qemu-devel] [PATCH v4 9/9] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. * test that changing the GUID at runtime via the monitor is reflected in the guest. * test that the "auto" argument to the GUID generates a

[Qemu-devel] [PATCH v4 7/9] PC: Support dynamic sysbus on pc_i440fx

From: Ben Warren This allows pc_i440fx-based machines to add new devices such as VM Generation ID directly to the sysbus. Signed-off-by: Ben Warren --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c

[Qemu-devel] [PATCH v4 2/9] linker-loader: Add new 'allocate and return address' cmd

From: Ben Warren This adds a new linker-loader command to instruct the guest to allocate memory for a fw_cfg file and write the address back into another writeable fw_cfg file. Knowing this address, QEMU can then write into guest memory at runtime. Signed-off-by: Ben

[Qemu-devel] [PATCH v4 0/9] Add support for VM Generation ID

From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This patch set has dependencies on new guest

[Qemu-devel] [PATCH v4 4/9] ACPI: Add Virtual Machine Generation ID support

From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, and ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

[Qemu-devel] [PATCH v4 3/9] docs: VM Generation ID device description

From: Ben Warren This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) Signed-off-by: Gal Hammer Signed-off-by: Ben Warren --- docs/specs/vmgenid.txt | 40 1

[Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

From: Ben Warren This is initially used to patch a 64-bit address into the VM Generation ID SSDT Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 4 2 files

[Qemu-devel] [PATCH v4 8/9] tests: Move reusable ACPI macros into a new header file

From: Ben Warren Also usable by upcoming VM Generation ID tests Signed-off-by: Ben Warren --- tests/acpi-utils.h | 75 tests/bios-tables-test.c | 72

[Qemu-devel] [PATCH v4 6/9] qmp/hmp: add set-vm-generation-id commands

From: Igor Mammedov Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } } HMP

[Qemu-devel] [PATCH v4 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

On Wed, 25 Jan 2017 09:19:25 +0800 Jason Wang wrote: > On 2017年01月24日 03:40, Alex Williamson wrote: > > On Mon, 23 Jan 2017 18:23:44 +0800 > > Jason Wang wrote: > > > >> On 2017年01月23日 11:34, Peter Xu wrote: > >>> On Mon, Jan 23, 2017 at 09:55:39AM

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

On 2017年01月24日 03:40, Alex Williamson wrote: On Mon, 23 Jan 2017 18:23:44 +0800 Jason Wang wrote: On 2017年01月23日 11:34, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

2017-01-25 0:12 GMT+08:00 Laszlo Ersek : > On 01/24/17 16:31, Wolfgang Bumiller wrote: > > On Tue, Jan 24, 2017 at 01:29:58PM +0100, Gerd Hoffmann wrote: > >> if (pitch < 0) { > >> int64_t min = addr > >> -+

[Qemu-devel] [PULL 00/14] target/xtensa updates

at: git://github.com/OSLL/qemu-xtensa.git tags/20170124-xtensa for you to fetch changes up to 3a3c9dc4ca2eaa612cbd5d4c85d674b15eadfb02: target-xtensa: implement RER/WER instructions (2017-01-16 19:19:03 -0800) target/xtensa

Re: [Qemu-devel] update-linux-headers.sh fails on clean kernel dir

On Tue, Jan 24, 2017 at 10:32:36AM +, Marc-André Lureau wrote: > Hi > > On Tue, Jan 24, 2017 at 8:41 AM Sam Bobroff wrote: > > > Hi QEMU developers, > > > > If I run scripts/update-linux-headers.sh from a clean checkout of QEMU > > and point it at a clean checkout

[Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

Adopted from a previous patch posting: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg02079.html CC: Allan Wirth CC: Peter Maydell Signed-off-by: Pranith Kumar --- linux-user/signal.c | 264

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

On Tue, 24 Jan 2017 14:24:23 -0800 (PST) Stefano Stabellini wrote: > On Tue, 24 Jan 2017, Greg Kurz wrote: > > On Mon, 23 Jan 2017 12:20:57 -0800 (PST) > > Stefano Stabellini wrote: > > > > > On Sat, 21 Jan 2017, Greg Kurz wrote: > > > > The

Re: [Qemu-devel] [PATCH v2] 9pfs: fix offset error in v9fs_xattr_read()

On Wed, 25 Jan 2017, Greg Kurz wrote: > The current code tries to copy `read_count' bytes starting at offset > `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to > fail with ENOBUFS. > > Since the PDU iovec is already partially filled with `offset' bytes, > let's skip them when

Re: [Qemu-devel] [PATCH v2 3/3] xen-platform: add missing disk unplug option

On Tue, 24 Jan 2017, Paul Durrant wrote: > The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to > request unplug of 'aux' disks (which is stated to mean all IDE disks, > except the primary master). This patch adds support for that unplug request. > > NOTE: The semantics of

Re: [Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

On Tue, 24 Jan 2017, Paul Durrant wrote: > ...not just IDE and SCSI. > > This patch allows the Xen tool-stack to fully support of NVMe as an > emulated disk type. > > Signed-off-by: Paul Durrant Please update docs/misc/hvm-emulated-unplug.markdown in the Xen repository

Re: [Qemu-devel] [PATCH v2 1/3] xen-platform: re-structure unplug_disks

On Tue, 24 Jan 2017, Paul Durrant wrote: > The current code is poorly structured and potentially leads to multiple > config space reads when one is sufficient. Also the UNPLUG_ALL_IDE_DISKS > flag is mis-named since it also results in SCSI disks being unplugged. > > This patch renames the flag

[Qemu-devel] [PATCH v2] 9pfs: fix offset error in v9fs_xattr_read()

The current code tries to copy `read_count' bytes starting at offset `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to fail with ENOBUFS. Since the PDU iovec is already partially filled with `offset' bytes, let's skip them when creating `qiov_full' and have v9fs_pack() to copy

[Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS

It works well on my side with the patch. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1658634 Title: Can't get correct display with latest QEMU and OVMF BIOS Status in QEMU: Confirmed

[Qemu-devel] [PULL 15/16] vhost: skip ROM sections

vhost does not support RO protections on memory at the moment - adding ROMs would mean that e.g. a buggy guest might change them in-memory - a condition from which guest reset does not recover. Not nice. We also definitely don't want to try logging writes into ROMs - in particular guests set very

[Qemu-devel] [PULL 14/16] virtio: make virtio_should_notify static

From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 1 -

[Qemu-devel] [PULL 13/16] pci: Convert msix_init() to Error and fix callers

From: Cao jin msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. In order to make the API change as small as possible, leave the return value check to later patch. For

[Qemu-devel] [PULL 08/16] hw/ioh3420: derive from PCI Express Root Port base class

From: Marcel Apfelbaum Preserve only Intel specific details. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/ioh3420.c | 121

[Qemu-devel] [PULL 10/16] hw/i386: check if nvdimm is enabled before plugging

From: Haozhong Zhang The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. The behavior of NVDIMM on unsupported platform (HW/FW) is vendor specific.

[Qemu-devel] [PULL 16/16] vhost-user: delete chardev on cleanup

From: Marc-André Lureau Remove the chardev implicitly when cleaning up the netdev. This prevents from reusing the chardev since it would be in an incorrect state with the slave. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1256618 Signed-off-by: Marc-André

[Qemu-devel] [PULL 05/16] pci: mark ROMs read-only

Looks like we didn't mark PCI ROMs as RO allowing mischief such as guests writing there. Further, e.g. vhost gets confused trying to allocate enough space to log writes there. Fix it up. Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PULL 09/16] hw/pcie: Introduce Generic PCI Express Root Port

From: Marcel Apfelbaum The Generic Root Port behaves almost the same as the Intel's IOH device with id 3420, without having Intel specific attributes. The device has two purposes: (1) Can be used on both X86 and ARM machines. (2) It will allow us to tweak the behaviour

[Qemu-devel] [PULL 11/16] msix: Follow CODING_STYLE

From: Cao jin CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Acked-by: Marcel Apfelbaum Signed-off-by: Cao jin

[Qemu-devel] [PULL 06/16] intel_iommu: fix and simplify size calculation in process_device_iotlb_desc()

From: Jason Wang We don't use 1ULL which is wrong during size calculation. Fix it, and while at it, switch to use cto64() and adds a comments to make it simpler and easier to be understood. Reported-by: Paolo Bonzini Cc: Paolo Bonzini

[Qemu-devel] [PULL 12/16] hcd-xhci: check & correct param before using it

From: Cao jin usb_xhci_realize() corrects invalid values of property "intrs" automatically, but the uncorrected value is passed to msi_init(), which chokes on invalid values. Delay that until after the correction. Resources allocated by usb_xhci_init() are leaked when

[Qemu-devel] [PULL 04/16] ARRAY_SIZE: check that argument is an array

It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring changes the argument from an array to a pointer to a dynamically allocated buffer. Code keeps compiling but any ARRAY_SIZE calls now return the size of the pointer divided by element size. Let's add build time checks to

[Qemu-devel] [PULL 07/16] hw/pcie: Introduce a base class for PCI Express Root Ports

From: Marcel Apfelbaum The 'base' PCI Express Root Port includes the common code to be re-used for all Root Ports implementations. Most of the code was taken from the current implementation of Intel's IOH 3420 Root Port. Signed-off-by: Marcel Apfelbaum

[Qemu-devel] [PULL 01/16] compiler: drop ; after BUILD_BUG_ON

All users include the trailing ; anyway, let's require that - it seems cleaner. Signed-off-by: Michael S. Tsirkin Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- include/qemu/compiler.h | 3 ++- 1 file changed, 2 insertions(+),

[Qemu-devel] [PULL 02/16] compiler: rework BUG_ON using a struct

There are theoretical concerns that some compilers might not trigger build failures on attempts to define an array of size (x ? -1 : 1) where x is a variable and make it a variable sized array instead. Let rewrite using a struct with a negative bit field size instead as there are no dynamic bit

[Qemu-devel] [PULL 03/16] compiler: expression version of QEMU_BUILD_BUG_ON

QEMU_BUILD_BUG_ON uses a typedef in order to be safe to use outside functions, but sometimes it's useful to have a version that can be used within an expression. Following what Linux does, introduce QEMU_BUILD_BUG_ON_ZERO that return zero after checking condition at build time. Signed-off-by:

[Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

The following changes since commit a9e404600a9bd1e6a26431fc89e5069092e67f14: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170124' into staging (2017-01-24 17:26:26 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

On Tue, 24 Jan 2017, Greg Kurz wrote: > On Mon, 23 Jan 2017 12:20:57 -0800 (PST) > Stefano Stabellini wrote: > > > On Sat, 21 Jan 2017, Greg Kurz wrote: > > > The current code tries to copy `read_count' bytes starting at offset > > > `offset' from a `read_count`-sized

[Qemu-devel] QEMU websockets support is laggy?

We've been considering switching over to using qemu's built in websockets support (to avoid the overhead of needing websockify running). We've been seeing very poor performance after the switch (it takes the console 4-5 seconds to update after pressing a key). So far, I haven't been able to

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: MMU compatibility check.

On Tue, 24 Jan 2017, Thomas Huth wrote: Date: Tue, 24 Jan 2017 21:32:44 +0100 From: Thomas Huth To: Valentin Plotkin , qemu-triv...@nongnu.org Cc: qemu-...@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-ppc] [PATCH] PPC: MMU compatibility check. On

Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

On Tue, 24 Jan 2017, Stefano Stabellini wrote: > On Tue, 24 Jan 2017, Roger Pau Monné wrote: > > Hello, > > > > The following commit: > > > > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 > > Author: Juergen Gross > > Date: Tue Nov 22 07:10:58 2016 +0100 > > > > xen:

Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

On Tue, 24 Jan 2017, Roger Pau Monné wrote: > Hello, > > The following commit: > > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 > Author: Juergen Gross > Date: Tue Nov 22 07:10:58 2016 +0100 > > xen: create qdev for each backend device > > Prevents me from running QEMU

[Qemu-devel] [PULL v2 0/7] Nios2 architecture support

in the git repository at: git://github.com/rth7680/qemu.git tags/pull-nios-20170124 for you to fetch changes up to e671711c9a8c1de540f035095e18458bc03968de: nios2: Add support for Nios-II R1 (2017-01-24 13:10:36 -0800) nios2 target

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/7] add blkdebug tests

ping On 12/20/2016 01:19 PM, Eric Blake wrote: > [oops, I forgot cc's on the cover letter, even though the rest of the > series was properly broadcast] > > On 12/20/2016 01:15 PM, Eric Blake wrote: >> Based on Kevin's block-next branch: >>

Re: [Qemu-devel] [PATCH v7 05/27] tcg: add options for enabling MTTCG

On 01/24/2017 12:25 PM, Alex Bennée wrote: > We are talking about doing the necessary annotation to all a givens > targets loads and stores? I figured this code would morph and be tweaked > when (if?) we get there. Fair enough. r~

Re: [Qemu-devel] [PATCH v7 18/27] cputlb: introduce tlb_flush_*_all_cpus

On 01/24/2017 12:34 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 01/19/2017 09:04 AM, Alex Bennée wrote: >>> +/* flush_all_helper: run fn across all cpus >>> + * >>> + * If the wait flag is set then the src cpu's helper will be queued as >>> + * "safe" work and

Re: [Qemu-devel] [PATCH v7 16/27] cputlb: add tlb_flush_by_mmuidx async routines

On 01/24/2017 12:31 PM, Alex Bennée wrote: >> Why don't we just pass in this bitmap in the first place? It's much better >> than having to use varargs in tlb_flush_by_mmuidx... > > We could. By not messing with the API it leaves the door open to having > other non-MTTCG architectures that have

Re: [Qemu-devel] [PATCH v7 18/27] cputlb: introduce tlb_flush_*_all_cpus

Richard Henderson writes: > On 01/19/2017 09:04 AM, Alex Bennée wrote: >> +/* flush_all_helper: run fn across all cpus >> + * >> + * If the wait flag is set then the src cpu's helper will be queued as >> + * "safe" work and the loop exited creating a synchronisation point >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: MMU compatibility check.

On 24.01.2017 19:56, Valentin Plotkin wrote: > > Hi everyone, > > I looked at the "qemu-system-ppc -nographic -cpu G2leGP3 -M ppce500" on > the BiteSizedTasks page. The segfault was caused by machine > initialization code which expected a certain MMU model, checked, so > unused SPR were read,

Re: [Qemu-devel] [PATCH v7 16/27] cputlb: add tlb_flush_by_mmuidx async routines

Richard Henderson writes: > On 01/19/2017 09:04 AM, Alex Bennée wrote: >> +/* Helper function to slurp va_args list into a bitmap >> + */ >> +static inline unsigned long make_mmu_index_bitmap(va_list args) >> +{ >> +unsigned long bitmap = 0; >> +int mmu_index =

[Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24

a9e404600a9bd1e6a26431fc89e5069092e67f14: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170124' into staging (2017-01-24 17:26:26 +) are available in the git repository at: git://git.corpit.ru/qemu.git tags/trivial-patches-fetch for you to fetch changes up

Re: [Qemu-devel] [PATCH v7 05/27] tcg: add options for enabling MTTCG

Richard Henderson writes: > On 01/19/2017 09:04 AM, Alex Bennée wrote: >> +void qemu_tcg_configure(QemuOpts *opts, Error **errp) >> +{ >> +const char *t = qemu_opt_get(opts, "thread"); >> +if (t) { >> +if (strcmp(t, "multi") == 0) { >> +if

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

Quoting Daniel P. Berrange (2017-01-24 11:36:19) > On Tue, Jan 24, 2017 at 09:44:33AM -0600, David Dai wrote: > > Using libvirt to do live migration over RDMA via ip v6 address failed. > > For example: > > # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ > >

Re: [Qemu-devel] [PATCH v3 1/8] make: move top level dir to end of include search path

On 01/24/2017 05:01 AM, Daniel P. Berrange wrote: > Currently the search path is > > 1. source dir corresponding to input file (implicit by compiler) > 2. top level build dir > 3. top level source dir > 4. top level source include/ dir > 5. source dir corresponding to input file > 6.

[Qemu-devel] [PATCH v2 1/2] niagara: fail if a firmware file is missing

fail if a firmware file is missing and not qtest_enabled(), the later is necessary to allow some basic tests if firmware is not available Suggested-by: Peter Maydell Signed-off-by: Artyom Tarasenko --- hw/sparc64/niagara.c | 26

[Qemu-devel] [PATCH v2 2/2] niagara: check if a serial port is available

Reported-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: Artyom Tarasenko --- hw/sparc64/niagara.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/sparc64/niagara.c

[Qemu-devel] [PATCH v2 0/2] niagara fixes

niagara fixes Artyom Tarasenko (2): niagara: fail if a firmware file is missing niagara: check if a serial port is available hw/sparc64/niagara.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) -- 2.7.2

Re: [Qemu-devel] [PATCH 03/17] migration: split common postcopy out of ram postcopy

* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 24.01.2017 12:24, Juan Quintela wrote: > > Vladimir Sementsov-Ogievskiy wrote: > > > Split common postcopy staff from ram postcopy staff. > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v2 0/8] virtio: use MemoryRegionCache for descriptors and rings

On Tue, Jan 24, 2017 at 10:26:27AM -0800, no-re...@patchew.org wrote: > qemu-system-x86_64: /tmp/qemu-test/src/exec.c:3180: > address_space_translate_cached: Assertion `addr < cache->len && *plen <= > cache->len - addr' failed. > make: *** [check-tests/test-qga] Error 1 > make: *** Waiting for

Re: [Qemu-devel] [PATCH 05/10] armv7m: honour CCR.STACKALIGN on exception entry

On 24 January 2017 at 19:33, Richard Henderson wrote: > On 01/24/2017 11:16 AM, Peter Maydell wrote: >> The CCR.STACKALIGN bit controls whether the CPU is supposed to force >> 8-alignment of the stack pointer on entry to the exception handler. > > 8... > >> +/* Align stack

Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value

On Tue, Jan 24, 2017 at 07:18:14PM +0100, Paolo Bonzini wrote: > > > On 17/01/2017 17:01, Michael S. Tsirkin wrote: > >>> Doesn't do it for megasas & hcd-xhci, later patches will fix them. > >>> > >>> Signed-off-by: Cao jin > > I don't like this one, frankly. That's a

[Qemu-devel] [PATCH 06/10] armv7m: set CFSR.UNDEFINSTR on undefined instructions

From: Michael Davidsaver When we take an exception for an undefined instruction, set the appropriate CFSR bit. Signed-off-by: Michael Davidsaver [PMM: tweaked commit message, comment] Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PATCH 05/10] armv7m: honour CCR.STACKALIGN on exception entry

On 01/24/2017 11:16 AM, Peter Maydell wrote: > The CCR.STACKALIGN bit controls whether the CPU is supposed to force > 8-alignment of the stack pointer on entry to the exception handler. 8... > +/* Align stack pointer if the guest wants that */ > +if ((env->regs[13] & 4) && (env->v7m.ccr

Re: [Qemu-devel] [PULL 0/2] s390x fixes

> > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20170124 > > for you to fetch changes up to 0cf4d747cb8d053e6a6161aadfd3531fa1a62be1: > > s390x/kvm: fix cmma reset for KVM (2017-01-24 15:47:31 +0100) > >

Re: [Qemu-devel] [PATCHv2] vhost-user: delete chardev on cleanup

On 01/24/2017 01:02 PM, Marc-André Lureau wrote: > Remove the chardev implicitely when cleaning up the netdev. This s/implicitely/implicitly/ > prevents from reusing the chardev since it would be in an incorrect > state with the slave. > > Fixes: >

[Qemu-devel] [PATCH 03/10] armv7m: add state for v7M CCR, CFSR, HFSR, DFSR, MMFAR, BFAR

Add the structure fields, VMState fields, reset code and macros for the v7M system control registers CCR, CFSR, HFSR, DFSR, MMFAR and BFAR. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 54 target/arm/cpu.c

[Qemu-devel] [PATCH] PPC: MMU compatibility check.

Hi everyone, I looked at the "qemu-system-ppc -nographic -cpu G2leGP3 -M ppce500" on the BiteSizedTasks page. The segfault was caused by machine initialization code which expected a certain MMU model, checked, so unused SPR were read, returning zeros. bamboo and virtex machines are affected

  1   2   3   4   5   >