Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

On 24/01/2017 15:44, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 10:25:00AM +0100, Paolo Bonzini wrote: >> >> >> On 23/01/2017 18:04, Michael S. Tsirkin wrote: For virtio-blk, my patch moved the setting of ISR from virtio_queue_guest_notifier_read to virtio_notify_irqfd. This

[Qemu-devel] [PATCH v2 00/17] Convert QCow[2] to QCryptoBlock & add LUKS support

This series is a continuation of previous work to support LUKS in QEMU. The existing merged code supports LUKS as a standalone driver which can be layered over/under any other QEMU block device driver. This works well when using LUKS over protocol drivers (file, rbd, iscsi, etc, etc), but has some

[Qemu-devel] [PATCH v2 07/17] iotests: fix 097 when run with qcow

The previous commit: commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd Author: Eric Blake Date: Mon Dec 5 09:49:34 2016 -0600 qcow2: Don't strand clusters near 2G intervals during commit extended the 097 test case so that it did two passes, once with an internal

[Qemu-devel] [PATCH v2 08/17] qcow: make encrypt_sectors encrypt in place

Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller uses the same buffer for input/output already and the other two callers are easily converted to do so. Signed-off-by: Daniel

[Qemu-devel] [PATCH v2 17/17] block: remove all encryption handling APIs

Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying

[Qemu-devel] [PATCH v2 11/17] qcow2: convert QCow2 to use QCryptoBlock for encryption

This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.

[Qemu-devel] [PATCH v2 05/17] iotests: skip 042 with qcow which dosn't support zero sized images

Test 042 is designed to verify operation with zero sized images. Such images are not supported with qcow (v1), so this test has always failed. Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/042 | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH v2 09/17] qcow: convert QCow to use QCryptoBlock for encryption

This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead. With this change it is now required to use the

[Qemu-devel] [PATCH v2 10/17] qcow2: make qcow2_encrypt_sectors encrypt in place

Instead of requiring separate input/output buffers for encrypting data, change qcow2_encrypt_sectors() to assume use of a single buffer, encrypting in place. The current callers all used the same buffer for input/output already. Reviewed-by: Eric Blake Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH v2 12/17] qcow2: extend specification to cover LUKS encryption

Update the qcow2 specification to describe how the LUKS header is placed inside a qcow2 file, when using LUKS encryption for the qcow2 payload instead of the legacy AES-CBC encryption Signed-off-by: Daniel P. Berrange --- docs/specs/qcow2.txt | 96

[Qemu-devel] [PATCH v2 04/17] qcow: require image size to be > 1 for new images

The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- block/qcow.c | 6

[Qemu-devel] [PATCH v2 03/17] qcow: document another weakness of qcow AES encryption

Document that use of guest virtual sector numbers as the basis for the initialization vectors is a potential weakness, when combined with internal snapshots or multiple images using the same passphrase. This fixes the formatting of the itemized list too. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v2 06/17] iotests: skip 048 with qcow which doesn't support resize

Test 048 is designed to verify data preservation during an image resize. The qcow (v1) format impl has never supported resize so always fails. Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/048 | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH v2 02/17] block: add ability to set a prefix for opt names

When integrating the crypto support with qcow/qcow2, we don't want to use the bare LUKS option names "hash-alg", "key-secret", etc. We want to namespace them "luks-hash-alg", "luks-key-secret" so that they don't clash with any general qcow options at a later date. Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v2 01/17] block: expose crypto option names / defs to other drivers

The block/crypto.c defines a set of QemuOpts that provide parameters for encryption. This will also be needed by the qcow/qcow2 integration, so expose the relevant pieces in a new block/crypto.h header. Reviewed-by: Max Reitz Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH] s390x/kvm: include hw_accel.h instead of kvm.h

On Tue, 24 Jan 2017 13:41:32 +0100 Vincent Palatin wrote: > On Tue, Jan 24, 2017 at 10:28 AM, Cornelia Huck > wrote: > > > > Commit b394662 ("kvm: move cpu synchronization code") switched > > to hw_accel.h instead of kvm.h, but missed s390x,

Re: [Qemu-devel] [PATCH v5 00/18] VT-d: vfio enablement and misc enhances

On Tue, Jan 24, 2017 at 07:49:10PM +0800, Peter Xu wrote: > On Tue, Jan 24, 2017 at 06:25:53PM +0800, Peter Xu wrote: > > This is v5 of vt-d vfio enablement series. > > > > Most of the changes in v5 is not functionally, but related to > > comments, error_report()s, debugging, squashing patches,

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

On Tue, Jan 24, 2017 at 10:25:00AM +0100, Paolo Bonzini wrote: > > > On 23/01/2017 18:04, Michael S. Tsirkin wrote: > >> For virtio-blk, my patch moved the setting of ISR from > >> virtio_queue_guest_notifier_read to virtio_notify_irqfd. This is > >> because the irqfd emulation only needs to

[Qemu-devel] need help

hi im an embedded systems engineer and i need help for my educational project implementation of inqstruction trace on qemu  can you help me by documentation or advices ?

[Qemu-devel] [PATCH v2 2/7] .travis.yml: split VM based builds

The Trusty based builds run a little slower than the main container based ones. This is also true for the latest version of Clang. The builds are getting very close (and occasionally run over) the 50 minute timeout. Rather than partitioning by target I just split them into linux-user and system

[Qemu-devel] [PATCH v2 7/7] qemu-options: remove stray space

Signed-off-by: Alex Bennée --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 80df52651a..55c68cecbb 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1705,7 +1705,7 @@ DEF("net", HAS_ARG,

[Qemu-devel] [PATCH v2 5/7] new debian-multiarch-cross.docker: a cross-compiling docker guest

This provides a basic Debian install with access to the emdebian cross compilers for armhf, arm64, mipsel and ppc64el. On its own it provides the basic cross build essentials for building any of those architectures. More complex cross-compilations would need to install library dependencies on top

[Qemu-devel] [PATCH v2 3/7] .travis.yml: DEBUG MacOSX build

Currently the MacOSX build is failing. Dump some information to help with figuring out what has gone wrong. Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 9008a796f0..a9ce215f42 100644 ---

[Qemu-devel] [PATCH v2 6/7] .shippable.yml: new CI provider

Ostensibly Shippable offers a similar set of services as Travis. However they are focused on Container based work-flows so we can use our existing containers to run a few extra builds - in this case a bunch of cross-compiled targets on a Debian multiarch system. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v2 1/7] .travis.yml: don't specify CONFIG twice

Signed-off-by: Alex Bennée --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index d83e2d493b..3dc1e6439d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -104,8 +104,7 @@ matrix: - wget -O -

[Qemu-devel] [PATCH v2 4/7] tests/docker: add basic user mapping support

Currently all docker builds are done by exporting a tarball to the docker container and running the build as the containers root user. Other use cases are possible however and it is possible to map a part of users file-system to the container. This is useful for example for doing cross-builds of

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On Tue 24 Jan 2017 10:53:50 AM CET, Stefan Hajnoczi wrote: > AioHandlers marked ->is_external must be skipped when aio_node_check() > fails. bdrv_drained_begin() needs this to prevent dataplane from > submitting new I/O requests while another thread accesses the device and > relies on it being

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

On Mon, 23 Jan 2017, Richard Henderson wrote: > On 01/23/2017 02:30 AM, Kirill Batuzov wrote: > > Because 4 adds on 4 i32 registers work good only when the size of > > vector elements matches the size of scalar variables we use for > > representation of a vector. add_i16x8 will not be that great

Re: [Qemu-devel] [PATCH] Makefile: Add qemu-doc.txt to distclean and dependencies

Hi On Tue, Jan 24, 2017 at 6:05 PM Peter Maydell wrote: > When qemu-doc.txt was added as a new output format in > commit f8bab10b4c3f, it was not added to either the > list of files to remove in distclean or to the dependency > line that forces qemu-options.texi to be

[Qemu-devel] [PATCH v2 3/3] xen-platform: add missing disk unplug option

The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to request unplug of 'aux' disks (which is stated to mean all IDE disks, except the primary master). This patch adds support for that unplug request. NOTE: The semantics of what happens if unplug of all disks and 'aux' disks

[Qemu-devel] [PATCH v2 0/3] xen-platform: disk unplug modifications

These patches modify the implementation of Xen HVM disk unplug. Paul Durrant (3): xen-platform: re-structure unplug_disks xen-platform: add support for unplugging NVMe disks... xen-platform: add missing disk unplug option hw/i386/xen/xen_platform.c | 50

[Qemu-devel] [PATCH v2 1/3] xen-platform: re-structure unplug_disks

The current code is poorly structured and potentially leads to multiple config space reads when one is sufficient. Also the UNPLUG_ALL_IDE_DISKS flag is mis-named since it also results in SCSI disks being unplugged. This patch renames the flag and re-structures the code to be more efficient, and

[Qemu-devel] [PATCH 2/3] colo-compare: add API to flush all queued packets while do checkpoint

From: Zhang Chen While COLO does checkpoint, we need to flush all queued packets of COLO proxy, use a new API to do these things, and export it which will be used by COLO frame. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang

[Qemu-devel] KVM call for 2017-01-31

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details:

[Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

...not just IDE and SCSI. This patch allows the Xen tool-stack to fully support of NVMe as an emulated disk type. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: "Michael S. Tsirkin"

[Qemu-devel] [PATCH 3/3] colo-compare: use notifier to notify inconsistent packets comparing

It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 24 ++-- net/colo-compare.h | 2 ++ 2

[Qemu-devel] [PATCH 0/3] colo-compare: Preparing work for combining with COLO frame

Hi, This series is some preparing works for integrating colo-compare into COLO frame. It is based on patch '[PATCH] colo-compare: sort TCP packet queue by sequence number' http://patchwork.ozlabs.org/patch/718955/ Please review and any commits are welcomed. Cc: Juan Quintela

[Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing To make it clearer, we rename 'timer_check_lock' to 'conn_list_lock' which is used

[Qemu-devel] [PATCH] Makefile: Add qemu-doc.txt to distclean and dependencies

When qemu-doc.txt was added as a new output format in commit f8bab10b4c3f, it was not added to either the list of files to remove in distclean or to the dependency line that forces qemu-options.texi to be built before attempting to build qemu-doc.*. In particular, the missing dependency meant

Re: [Qemu-devel] [PATCH v1 12/15] qcow2: add support for LUKS encryption format

On Sat, Jan 21, 2017 at 07:57:45PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > This adds support for using LUKS as an encryption format > > with the qcow2 file. The use of the existing 'encryption=on' > > parameter is replaced by a new parameter 'encryption-format'

Re: [Qemu-devel] [PATCH v2 00/20] chardev: qom-ify

On 10/01/2017 18:47, Marc-André Lureau wrote: > qemu-char.c is quite a large file (~130k, 5000 loc) with many chardev > and a lot of #ifdef. It doesn't use qemu Object. Using qemu Object > hopefully brings cleaner, more consitent code base. It helps to split > the various backends in different

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

On 24/01/2017 13:56, Markus Armbruster wrote: > So, what do we want to deprecate? > > I think the onboard SCSI HBA adopting if=scsi drives should stay, > because it matches what we do for other interface types. Unless we > wanted to deprecate interface types other than none entirely. Yes, of

Re: [Qemu-devel] [PATCH 0/3] xen-platform: disk unplug modifications

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/3] xen-platform: disk unplug modifications Message-id: 1485257020-18542-1-git-send-email-paul.durr...@citrix.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] s390x/kvm: include hw_accel.h instead of kvm.h

On Tue, Jan 24, 2017 at 10:28 AM, Cornelia Huck wrote: > > Commit b394662 ("kvm: move cpu synchronization code") switched > to hw_accel.h instead of kvm.h, but missed s390x, resulting in > > CC s390x-softmmu/target/s390x/kvm.o >

Re: [Qemu-devel] [RFC PATCH 0/6] iscsi: Add blockdev-add support

On Tue, Jan 24, 2017 at 11:35:12AM +, Daniel P. Berrange wrote: > On Thu, Dec 08, 2016 at 02:23:05PM +0100, Kevin Wolf wrote: > > This adds blockdev-add support to the iscsi block driver. > > > > Note that this is only compile tested at this point. Jeff is going to > > take over from here and

Re: [Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair

On Tue, Jan 03, 2017 at 11:08:39AM -0600, Eric Blake wrote: > On 01/03/2017 10:05 AM, Daniel P. Berrange wrote: > > The 'check' program records timings for each test that > > is run. These timings are only valid, however, for a > > particular format/protocol combination. So if frequently > >

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On Tue, 01/24 09:53, Stefan Hajnoczi wrote: > AioHandlers marked ->is_external must be skipped when aio_node_check() > fails. bdrv_drained_begin() needs this to prevent dataplane from > submitting new I/O requests while another thread accesses the device and > relies on it being quiesced. > >

Re: [Qemu-devel] [PATCH 4/7] virtio: use MemoryRegionCache to access descriptors

On Fri, Jan 20, 2017 at 06:07:54PM +0100, Paolo Bonzini wrote: > For now, the cache is created on every virtqueue_pop. Later on, > direct descriptors will be able to reuse it. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 91 >

Re: [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23)

On 24 January 2017 at 13:24, Peter Maydell wrote: > I get a failure in the docs on OSX: > GEN qemu-doc.txt > CC qapi/qapi-visit-core.o > /Users/pm215/src/qemu-for-merges/qemu-doc.texi:7: warning: > unrecognized encoding name `UTF-8'. > GEN

Re: [Qemu-devel] [for 2.9] migration/tracing: Add tracing on save

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Add some tracing to vmstate_subsection_save and vmstate_save_state > to help in debugging when you're not sure if a conditional piece > of data is being saved. > > In

Re: [Qemu-devel] [PATCH 3/7] virtio: use address_space_map/unmap to access descriptors

On Fri, Jan 20, 2017 at 06:07:53PM +0100, Paolo Bonzini wrote: > @@ -455,10 +455,18 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned > int *in_bytes, > goto err; > } > > -desc_pa = vq->vring.desc; > -vring_desc_read(vdev, , desc_pa, i); > +

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

Cc'ing in sPAPR maintainers... Paolo Bonzini writes: > On 23/01/2017 20:16, Markus Armbruster wrote: >>> Could we change >>> those messages to errors >> >> Fine with me, but when it comes to arguing for backward

Re: [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23)

On 23 January 2017 at 23:27, Eduardo Habkost wrote: > The following changes since commit 3879284d6517dc22529395bdb259f4183b589127: > > Merge remote-tracking branch 'remotes/berrange/tags/pull-qio-2017-01-23-2' > into staging (2017-01-23 15:59:09 +) > > are available in

Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

On 24/01/2017 13:49, Peter Lieven wrote: > +#ifdef CONFIG_LIBISCSI The #ifdef is not needed here. Paolo > +static QemuOptsList qemu_iscsi_opts = { > +.name = "iscsi", > +.head = QTAILQ_HEAD_INITIALIZER(qemu_iscsi_opts.head), > +.desc = { > +{ > +.name = "user",

Re: [Qemu-devel] [PATCH v2] console: fix console resize

On 01/24/17 12:10, Gerd Hoffmann wrote: > Only skip surface reallocation in case the old surface was created using > qemu_alloc_display (via qemu_create_displaysurface) too, otherwise we > might end up with a DisplaySurface with the wrong backing storage. > > Cc: 1658...@bugs.launchpad.net >

Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24 Message-id: cover.1485250702.git@msgid.tls.msk.ru === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

commit f57b4b5f moved qemu_iscsi_opts into vl.c. This made them invisible for qemu-img, qemu-nbd etc. Fixes: f57b4b5fb127b60e1aade2684a8b16bc4f630b29 Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- MAINTAINERS | 1 + block/Makefile.objs | 1 +

Re: [Qemu-devel] [Qemu-block] [PATCH v2] migration: re-active images while migration been canceled after inactive them

On Tue, Jan 24, 2017 at 03:59:52PM +0800, zhanghailiang wrote: > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > which migration aborted QEMU because it didn't regain the control > of images while some errors happened. > > Actually, there are another two cases can trigger the same

Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

On 24/01/2017 13:53, Peter Lieven wrote: > Am 24.01.2017 um 13:52 schrieb Paolo Bonzini: >> >> On 24/01/2017 13:49, Peter Lieven wrote: >>> +#ifdef CONFIG_LIBISCSI >> The #ifdef is not needed here. > > Right, can you drop it or shall I send a V2? Can do. Paolo > Peter > >> >> Paolo >> >>>

Re: [Qemu-devel] [PATCH v1 15/15] block: remove all encryption handling APIs

On Sat, Jan 21, 2017 at 08:22:53PM +0100, Max Reitz wrote: > On 03.01.2017 19:28, Daniel P. Berrange wrote: > > Now that all encryption keys must be provided upfront via > > the QCryptoSecret API and associated block driver properties > > there is no need for any explicit encryption handling APIs

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On 24/01/2017 13:47, Fam Zheng wrote: >> I'm not sure I understand why this is related. aio_poll() only tries >> poll mode once, so bdrv_flush would only spin until the fsync is complete. > > Right, I was confused. The problematic ones are "drain" style ones that > tracks > a inflight

Re: [Qemu-devel] [PATCH v1 03/15] qcow: document another weakness of qcow AES encryption

On Mon, Jan 16, 2017 at 08:37:57PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > Document that use of guest virtual sector numbers as the basis for > > the initialization vectors is a potential weakness, when combined > > with internal snapshots or multiple images

Re: [Qemu-devel] [PATCH 1/7] virtio: make virtio_should_notify static

On Fri, Jan 20, 2017 at 06:07:51PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 2 +- > include/hw/virtio/virtio.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On Tue, 01/24 13:15, Paolo Bonzini wrote: > > > On 24/01/2017 13:04, Fam Zheng wrote: > > > > All in all I think we should skip external handlers regardless of > > aio_disable_external(), or even skip try_poll_mode, in nested aio_poll()'s. > > The > > reasons are 1) many nested aio_poll()'s

Re: [Qemu-devel] [PATCH RFC] vfio error recovery: kernel support

On 01/21/2017 01:01 AM, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 06:13:22PM +0800, Cao jin wrote: >> >> >> On 01/20/2017 04:16 AM, Michael S. Tsirkin wrote: >>> This is a design and an initial patch for kernel side for AER >>> support in VFIO. >>> >>> 0. What happens now (PCIE AER

[Qemu-devel] [PULL 10/31] object: make some funcs static

From: Marc-André Lureau There is no need to have those functions as public API. Signed-off-by: Marc-André Lureau Signed-off-by: Michael Tokarev --- include/qom/object.h | 24 qom/object.c

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

> >>> if (pitch < 0) { > >>> int64_t min = addr > >>> -+ ((int64_t)s->cirrus_blt_height-1) * pitch; > >>> ++ ((int64_t)s->cirrus_blt_height-1) * pitch > >>> +- s->cirrus_blt_width; > >>> int32_t max = addr > >>> +

Re: [Qemu-devel] [PATCH 2/7] virtio: add virtio_*_phys_cached

On Fri, Jan 20, 2017 at 06:07:52PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/hw/virtio/virtio-access.h | 52 > +++ > 1 file changed, 52 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

Am 24.01.2017 um 13:52 schrieb Paolo Bonzini: On 24/01/2017 13:49, Peter Lieven wrote: +#ifdef CONFIG_LIBISCSI The #ifdef is not needed here. Right, can you drop it or shall I send a V2? Peter Paolo +static QemuOptsList qemu_iscsi_opts = { +.name = "iscsi", +.head =

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On Tue, 01/24 09:53, Stefan Hajnoczi wrote: > AioHandlers marked ->is_external must be skipped when aio_node_check() > fails. bdrv_drained_begin() needs this to prevent dataplane from > submitting new I/O requests while another thread accesses the device and > relies on it being quiesced. > >

Re: [Qemu-devel] [PATCH 7/7] virtio: use VRingMemoryRegionCaches for avail and used rings

On Fri, Jan 20, 2017 at 06:07:57PM +0100, Paolo Bonzini wrote: > The virtio-net change is necessary because it uses virtqueue_fill > and virtqueue_flush instead of the more convenient virtqueue_push. > > Signed-off-by: Paolo Bonzini > --- > hw/net/virtio-net.c | 14 +-

Re: [Qemu-devel] [PATCH v1 08/15] qcow: make encrypt_sectors encrypt in place

On Mon, Jan 16, 2017 at 09:25:55PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > Instead of requiring separate input/output buffers for > > encrypting data, change encrypt_sectors() to assume > > use of a single buffer, encrypting in place. One current > > caller all

Re: [Qemu-devel] [PATCH v2] migration: Change name of live migration thread

* Pankaj Gupta (pagu...@redhat.com) wrote: > Change the name of live migration thread from 'migration' > to 'live_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. > > > Signed-off-by: Pankaj

Re: [Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for descriptor ring

On Fri, Jan 20, 2017 at 06:07:56PM +0100, Paolo Bonzini wrote: > @@ -762,15 +761,14 @@ void *virtqueue_pop(VirtQueue *vq, size_t sz) > > i = head; > > -len = address_space_cache_init(_desc_cache, vdev->dma_as, > - vq->vring.desc, max *

Re: [Qemu-devel] [PATCH 5/7] virtio: add MemoryListener to cache ring translations

On Fri, Jan 20, 2017 at 06:07:55PM +0100, Paolo Bonzini wrote: > +static void virtio_init_region_cache(VirtIODevice *vdev, int n) > +{ > +VirtQueue *vq = >vq[n]; > +VRingMemoryRegionCaches *old = vq->vring.caches; > +VRingMemoryRegionCaches *new = g_new0(VRingMemoryRegionCaches, 1); >

Re: [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

On 01/24/2017 07:09 AM, Fam Zheng wrote: On Tue, 01/24 12:23, Paolo Bonzini wrote: On 22/01/2017 15:29, Fam Zheng wrote: On Fri, 01/20 17:25, Eric Farman wrote: Changes: v2->v3: - Move byte/sector conversions to patch 2 [Fam Zheng] - Rename "max_sectors" when holding a byte value

[Qemu-devel] [PATCH v3 1/5] iotests: skip 159 & 170 with luks format

While the qemu-img dd command does accept --image-opts this is not sufficient to make it work with the LUKS image yet. This is because bdrv_create() still always requires the non-image-opts syntax. Thus we must skip 159/170 with luks for now Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v1 11/15] qcow2: convert QCow2 to use QCryptoBlock for encryption

On Sat, Jan 21, 2017 at 08:07:57PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > This converts the qcow2 driver to make use of the QCryptoBlock > > APIs for encrypting image content, using the legacyy QCow2 AES > > scheme. > > > > With this change it is now required

Re: [Qemu-devel] [PATCH v1 02/15] block: add ability to set a prefix for opt names

On Mon, Jan 16, 2017 at 08:31:55PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > When integrating the crypto support with qcow/qcow2, we don't > > want to use the bare LUKS option names "hash-alg", "key-secret", > > etc. We want to namespace them "luks-hash-alg",

Re: [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

On Tue, 01/24 12:23, Paolo Bonzini wrote: > > > On 22/01/2017 15:29, Fam Zheng wrote: > > On Fri, 01/20 17:25, Eric Farman wrote: > >> Changes: > >> v2->v3: > >> - Move byte/sector conversions to patch 2 [Fam Zheng] > >> - Rename "max_sectors" when holding a byte value [Fam Zheng] > >>

Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_

* Eric Blake (ebl...@redhat.com) wrote: > On 01/23/2017 03:32 PM, Juan Quintela wrote: > > In the subject: s/remained/remaining/ > > > So we can remove DPRINTF() macro > > > > Signed-off-by: Juan Quintela > > --- > > migration/ram.c| 18 -- > >

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > - Original Message - > > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > > Hi, > > > > CCing Jeff Cody and John Snow, who have been working on generalizing > > Block Job APIs to generic background

[Qemu-devel] [PULL 20/31] docs: sync pci-ids.txt

From: Gerd Hoffmann Three commits allocated pci ids in include/hw/pci/pci.h without also updating docs/specs/pci-ids.txt: bf439db pci: Allocate PCIe host bridge PCI ID 40d14be hw/pci: introduce PCI Expander Bridge (PXB) 02b0743 hw/pxb: introduce pxb-pcie expander for

Re: [Qemu-devel] [PATCH v1 04/15] qcow: require image size to be > 1 for new images

On Mon, Jan 16, 2017 at 08:41:15PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > The qcow driver refuses to open images which are less than > > 2 bytes in size, but will happily create such images. Add > > a check in the create path to avoid this discrepancy. > > >

Re: [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling

On 24/01/2017 13:04, Fam Zheng wrote: > > All in all I think we should skip external handlers regardless of > aio_disable_external(), or even skip try_poll_mode, in nested aio_poll()'s. > The > reasons are 1) many nested aio_poll()'s don't have bdrv_drained_begin, so this > check is not

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

On 24/01/2017 12:40, Peter Lieven wrote: > Am 24.01.2017 um 12:29 schrieb Paolo Bonzini: >> >> On 24/01/2017 12:25, Peter Lieven wrote: >>> Am 24.01.2017 um 12:24 schrieb Paolo Bonzini: On 19/01/2017 18:03, Daniel P. Berrange wrote: >>> Move the iscsi option registration out of vl.c and

Re: [Qemu-devel] [PATCH v2 0/3] x86-kvm: Fix Mac guest timekeeping by exposing TSC frequency in CPUID

On 20/01/2017 15:11, Phil Dennis-Jordan wrote: > Darwin/OS X/macOS for x86-64 uses the TSC for timekeeping; it normally > calibrates this by querying various clock frequency scaling MSRs. Details > depend on the exact CPU model detected. The local APIC timer frequency is > extracted from

Re: [Qemu-devel] [RFC] PCI/migration merge vmstate_pci_device and vmstate_pcie_device

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Dec 14, 2016 at 07:58:29PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The vmstate_pci_device and vmstate_pcie_devices differ > > just in the size of one buffer; combine the two

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

Am 24.01.2017 um 12:24 schrieb Paolo Bonzini: On 19/01/2017 18:03, Daniel P. Berrange wrote: Move the iscsi option registration out of vl.c and back into a shared file in block/ such that all programs see the options, not just the emulators. Any preference which file? It seems no other block

[Qemu-devel] [PATCH v3 5/5] iotests: chown LUKS device before qemu-io launches

On some distros, whenever you close a block device file descriptor there is a udev rule that resets the file permissions. This can race with the test script when we run qemu-io multiple times against the same block device. Occasionally the second qemu-io invocation will find udev has reset the

[Qemu-devel] [PULL 14/31] block: remove dead check

From: Paolo Bonzini options must be non-NULL here, because a NULL value is replaced with qdict_new earlier in the function. Reported by Coverity. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev

[Qemu-devel] [PATCH v3 3/5] iotests: reduce PBKDF iterations when testing LUKS

By default the PBKDF algorithm used with LUKS is tuned based on the number of iterations to produce 1 second of running time. This makes running the I/O test with the LUKS format orders of magnitude slower than with qcow2/raw formats. When creating LUKS images, set the iteration time to a 10ms to

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

On 01/24/17 12:17, Laszlo Ersek wrote: > On 01/24/17 11:48, Gerd Hoffmann wrote: diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 379910d..7ddd289 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -277,7 +277,8 @@ static bool

[Qemu-devel] [PATCH v3 0/5] Improve I/O tests coverage of LUKS

The main goal of this series is to get the I/O tests passing 100% with LUKS when run with './check -luks'. It also adds a few more combinations to the LUKS/dmcrypt interoperability test. To make LUKS testing not quite as slow, we drop the PBKDF iteration count down to a very small value. This

[Qemu-devel] [PULL 26/31] Drop duplicate display option documentation

From: Samuel Thibault The curses and none possibilities are already documented on a separate line, so documenting it on the sdl line was both unneeded and confusing. Introduced in commit f04ec5afbb7d60a56863add800fd90ceee66f362 Signed-off-by: Samuel Thibault

[Qemu-devel] [PATCH v3 2/5] iotests: fix remainining tests to work with LUKS

The tests 033, 120, 140, 145 and 157 were all broken when run with LUKS, since they did not correctly use the required image opts args syntax to specify the decryption secret. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH 1/3] xen-platform: re-structure unplug_disks

The current code is poorly structured and potentially leads to multiple config space reads when one is sufficient. Also the UNPLUG_ALL_IDE_DISKS flag is mis-named since it also results in SCSI disks being unplugged. This patch renames the flag and re-structures the code to be more efficient, and

[Qemu-devel] [PULL 24/31] win32: use glib gpoll if glib >= 2.50

From: Marc-André Lureau A fix has been committed in upstream glib commit 210a9796f78eb90f76f1bd6a304e9fea05e97617. (See also related bug https://bugzilla.gnome.org/show_bug.cgi?id=764415) It is desirable to use the glib version instead of qemu copy, since it

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

Thanks Christian! Will do!! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create fallback mechanism change for security drivers Status in Ubuntu Cloud Archive: Invalid

Re: [Qemu-devel] [PATCH] console: fix console resize

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] console: fix console resize Message-id:

<    1   2   3   4   5   >