[Qemu-devel] [RFC 0/3] generalize parsing of cpu_model

2017-02-17 Thread Igor Mammedov
Some callers call CPUClass->parse_features manually to convert '-cpu cpufoo,featurestr' string to cpu type and featurestr into a set of global properties. And theni do controlled cpu creation with setting properties and completing it with realize. That's a lot of code duplication as they are

Re: [Qemu-devel] [PATCH] Add missing fp_access_check() to aarch64 crypto instructions

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 17:58, Nick Reilly wrote: > The aarch64 crypto instructions for AES and SHA are missing the > check for if the FPU is enabled. > > Signed-off-by: Nick Reilly Oops, nice catch. Applied to target-arm.next, thanks. -- PMM

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread John Snow
On 02/17/2017 10:34 AM, Eric Blake wrote: > On 02/17/2017 03:28 AM, Peter Maydell wrote: >> On 17 February 2017 at 06:43, Fam Zheng wrote: >>> But your point is taken, we should make the first (or a one-shot) >>> contribution as easy as possible. >> >> Yes; we could do with

[Qemu-devel] [PATCH] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-17 Thread Daniel Henrique Barboza
The previous error message was displaying the values in miliseconds, being misleading with the command that accepts the value in seconds: { "execute": "migrate_set_downtime", "arguments": {"value": 3000}} {"error": {"class": "GenericError", "desc": "Parameter 'downtime_limit' expects an integer

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Denis V. Lunev
On 02/17/2017 04:34 PM, Kevin Wolf wrote: > Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: >> On 02/17/2017 03:48 PM, Kevin Wolf wrote: >>> Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: 17.02.2017 15:09, Kevin Wolf wrote: > Am 17.02.2017 um 12:46 hat

Re: [Qemu-devel] [PATCH v12 21/24] target-arm: don't generate WFE/YIELD calls for MTTCG

2017-02-17 Thread Pranith Kumar
On Mon, Feb 13, 2017 at 7:10 AM, Alex Bennée wrote: > The WFE and YIELD instructions are really only hints and in TCG's case > they were useful to move the scheduling on from one vCPU to the next. In > the parallel context (MTTCG) this just causes an unnecessary cpu_exit >

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 16:54, Chad Joan wrote: > so if we can test and > approve even /some/ of the more popular mail clients (ex: gmail, > thunderbird, outlook, etc) for use, it would help newbies A LOT. Pretty sure we've seen mangled emails from all of those. The problem is

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Chad Joan
How wonderful! Problem solved. Now I think that just having an example could kill the misconception forever ;) On Fri, Feb 17, 2017 at 11:57 AM, Paolo Bonzini wrote: > > > On 17/02/2017 17:54, Chad Joan wrote: > > Regarding the signature: IIRC, setting up certificates on

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 11:20, Paolo Bonzini wrote: > > > On 17/02/2017 11:18, Peter Maydell wrote: >> Defining _XOPEN_SOURCE is easy enough, and I think we should >> do it unconditionally. We should check what effect this has >> on the BSD hosts though I guess. (You could

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Paolo Bonzini
On 17/02/2017 17:54, Chad Joan wrote: > Regarding the signature: IIRC, setting up certificates on a machine > using gpg can be quite time consuming and learning-intensive if you've > never needed to do it before. Having that example will go a long way to > help with this. There is still a

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Chad Joan
Wow, that is some quick turn-around. Well done! My thoughts: - I find this summary info very helpful! On behalf of the N people trying to heal paper cuts: thank you! - I still recommend an example snippet for shell/bash interaction that demonstrates the workflow you expect from a

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-17 Thread Andrea Arcangeli
Hello Alexey, On Tue, Feb 14, 2017 at 05:48:25PM +0300, Alexey Perevalov wrote: > On Mon, Feb 13, 2017 at 06:57:22PM +0100, Andrea Arcangeli wrote: > > Hello, > > > > On Mon, Feb 13, 2017 at 08:11:06PM +0300, Alexey Perevalov wrote: > > > Another one request. > > > QEMU could use mem_path in

[Qemu-devel] [PATCH 1/2] block/nfs: convert to preadv / pwritev

2017-02-17 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/nfs.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 689eaa7..ab5dcc2 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -256,9 +256,9 @@ nfs_co_generic_cb(int

[Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

2017-02-17 Thread Peter Lieven
if the passed qiov contains exactly one iov we can pass the buffer directly. Signed-off-by: Peter Lieven --- block/nfs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index ab5dcc2..bb4b75f 100644 ---

[Qemu-devel] [PATCH 0/2] block/nfs optimizations

2017-02-17 Thread Peter Lieven
Peter Lieven (2): block/nfs: convert to preadv / pwritev block/nfs: try to avoid the bounce buffer in pwritev block/nfs.c | 50 -- 1 file changed, 28 insertions(+), 22 deletions(-) -- 1.9.1

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 16:33, Ben Warren wrote: > >> On Feb 17, 2017, at 2:43 AM, Igor Mammedov > > wrote: >> >> On Thu, 16 Feb 2017 15:15:36 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren

[Qemu-devel] [RFC PATCH V4] qemu-img: make convert async

2017-02-17 Thread Peter Lieven
this is something I have been thinking about for almost 2 years now. we heavily have the following two use cases when using qemu-img convert. a) reading from NFS and writing to iSCSI for deploying templates b) reading from iSCSI and writing to NFS for backups In both processes we use libiscsi

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Eric Blake
On 02/17/2017 09:52 AM, Peter Maydell wrote: >>> Makefile | 17 ++--- >>> docs/qemu-ga-ref.texi | 2 ++ >>> docs/qemu-qmp-ref.texi | 2 ++ >>> 3 files changed, 14 insertions(+), 7 deletions(-) >> >> Missing a change to .gitignore for version.texi. > > Should be >

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 15:50, Eric Blake wrote: > On 02/17/2017 09:12 AM, Peter Maydell wrote: >> Unfortunately some older versions of makeinfo don't correctly >> handle the -D command line option and fail to set the variable. >> This then causes them to complain >>

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Eric Blake
On 02/17/2017 09:12 AM, Peter Maydell wrote: > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by

Re: [Qemu-devel] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

2017-02-17 Thread Eric Blake
On 02/17/2017 04:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 17:21, Kevin Wolf wrote: >> Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Add detailed error messages. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Why not merge

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Marc-André Lureau
Hi - Original Message - > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by doing as the

[Qemu-devel] [PATCH RESEND] aarch64: Change ext type to TCGType to fix warnings

2017-02-17 Thread Pranith Kumar
To fix the following warnings: In file included from /users/pranith/qemu/tcg/tcg.c:255: /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:879:24: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumeration type 'TCGType' (aka 'enum TCGType')

Re: [Qemu-devel] [PATCH v2] target-arm: Implement BCM2835 hardware RNG

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 12:54, Peter Maydell wrote: > On 10 February 2017 at 21:08, Marcin Chojnacki wrote: >> Recent vanilla Raspberry Pi kernels started to make use of >> the hardware random number generator in BCM2835 SoC. As a >> result, those

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Eric Blake
On 02/17/2017 03:28 AM, Peter Maydell wrote: > On 17 February 2017 at 06:43, Fam Zheng wrote: >> But your point is taken, we should make the first (or a one-shot) >> contribution as easy as possible. > > Yes; we could do with providing a "This page seems very long..." >

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 2:43 AM, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cpu object reference leak

2017-02-17 Thread Igor Mammedov
On Fri, 17 Feb 2017 13:32:15 + Peter Maydell wrote: > On 16 February 2017 at 15:11, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 14:18:05 + > > Peter Maydell wrote: > >> I've always found the object reference

[Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Peter Maydell
Unfortunately some older versions of makeinfo don't correctly handle the -D command line option and fail to set the variable. This then causes them to complain docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION Work around this by doing as the autotools do, and writing the information

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
17.02.2017 17:24, Kevin Wolf wrote: Am 17.02.2017 um 14:48 hat Denis V. Lunev geschrieben: On 02/17/2017 04:34 PM, Kevin Wolf wrote: Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: But for sure this is bad from the downtime point of view. On migrate you will have to write to the image

[Qemu-devel] [PATCH v2] hw/arm/virt: Add a user option to disallow ITS instantiation

2017-02-17 Thread Eric Auger
In 2.9 ITS will block save/restore and migration use cases. As such let's introduce a user option that disallows its instantiation along with the GICv3. With no-its option turned true, migration will be possible, obviously at the expense of MSI support (with GICv3). Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben: > On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: > >> Add tests for creating raw image with and without the preallocation > >> option. > >> > >> Signed-off-by: Nir

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 14:48 hat Denis V. Lunev geschrieben: > On 02/17/2017 04:34 PM, Kevin Wolf wrote: > > Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: > >> But for sure this is bad from the downtime point of view. > >> On migrate you will have to write to the image and re-read > >> it again

Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

2017-02-17 Thread Nir Soffer
On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: >> Add tests for creating raw image with and without the preallocation >> option. >> >> Signed-off-by: Nir Soffer > > Looks good, but 175 is already

Re: [Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand()

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 14:05, Daniel P. Berrange wrote: > On Fri, Feb 17, 2017 at 12:22:39PM +, Peter Maydell wrote: >> We should probably improve crypto/random-platform.c to use >> getentropy() if available, which would fix the "BSD or OSX >> host and not using gcrypt or

Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2017-02-17 Thread Fam Zheng
On Wed, 01/25 12:42, Jeff Cody wrote: > From: Kevin Wolf > > This splits the logic in the old parse_chap() function into a part that > parses the -iscsi options into the new driver-specific options, and > another part that actually applies those options (called apply_chap() >

Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2017-02-17 Thread Fam Zheng
On Fri, 02/17 14:26, Kevin Wolf wrote: > It is the one that it put into the QDict by iscsi_parse_iscsi_option(), > which is supposed to be the value from -iscsi. OK! This is what I was missing. :) Fam

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

2017-02-17 Thread Fam Zheng
On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: > 17.02.2017 15:21, Fam Zheng wrote: > > On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > > > 16.02.2017 16:48, Fam Zheng wrote: > > > > On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > > > > > When testing migration,

Re: [Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand()

2017-02-17 Thread Daniel P. Berrange
On Fri, Feb 17, 2017 at 12:22:39PM +, Peter Maydell wrote: > Switch to using qcrypto_random_bytes() rather than rand() as > our source of randomness for the BCM2835 RNG. > > If qcrypto_random_bytes() fails, we don't want to return the guest a > non-random value in case they're really using it

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add a user option to disallow ITS instantiation

2017-02-17 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] hw/arm/virt: Add a user option to disallow ITS instantiation Message-id:

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Denis V. Lunev
On 02/17/2017 03:48 PM, Kevin Wolf wrote: > Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 17.02.2017 15:09, Kevin Wolf wrote: >>> Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 14:49, Kevin Wolf wrote: > Am 16.02.2017 um 12:25 hat

Re: [Qemu-devel] [PATCH v8 2/5] hw/intc/arm_gicv3_kvm: Add ICC_SRE_EL1 register to vmstate

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 06:31, wrote: > From: Vijaya Kumar K > > To Save and Restore ICC_SRE_EL1 register introduce vmstate > subsection and load only if non-zero. > Also initialize icc_sre_el1 with to 0x7 in pre_load > function. > >

[Qemu-devel] [PATCH] hw/arm/virt: Add a user option to disallow ITS instantiation

2017-02-17 Thread Eric Auger
In 2.9 ITS will block save/restore and migration use cases. As such let's introduce a user option that disallows its instantiation along with the GICv3. With no-its option turned true, migration will be possible, obviously at the expense of MSI support (with GICv3). Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH v8 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 06:31, wrote: > From: Vijaya Kumar K > > Reset CPU interface registers of GICv3 when CPU is reset. > For this, ARMCPRegInfo struct is registered with one ICC > register whose resetfn is called when cpu is reset. > > All the

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 14:05, Igor Mammedov wrote: > On Fri, 17 Feb 2017 13:50:40 +0100 > Laszlo Ersek wrote: > >> CC Dave >> >> On 02/17/17 11:43, Igor Mammedov wrote: >>> On Thu, 16 Feb 2017 15:15:36 -0800 >>> b...@skyportsystems.com wrote: >>> From: Ben Warren

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: > On 02/17/2017 03:48 PM, Kevin Wolf wrote: > > Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 17.02.2017 15:09, Kevin Wolf wrote: > >>> Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: >

Re: [Qemu-devel] [PATCH v8 4/5] target-arm: Add GICv3CPUState in CPUARMState struct

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 06:31, wrote: > From: Vijaya Kumar K > > Add gicv3state void pointer to CPUARMState struct > to store GICv3CPUState. > > In case of usecase like CPU reset, we need to reset > GICv3CPUState of the CPU. In such scenario, this

[Qemu-devel] [PATCH v6 2/2] spapr: generate DT node names

2017-02-17 Thread Laurent Vivier
When DT node names for PCI devices are generated by SLOF, they are generated according to the type of the device (for instance, ethernet for virtio-net-pci device). Node name for hotplugged devices is generated by QEMU. This patch adds the mechanic to QEMU to create the node name according to the

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
17.02.2017 15:21, Fam Zheng wrote: On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: 16.02.2017 16:48, Fam Zheng wrote: On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: When testing migration, auto-generated by qemu node-names differs in source and destination qemu and

[Qemu-devel] [PATCH v6 1/2] PCI: add missing classes in pci_ids.h to build device tree

2017-02-17 Thread Laurent Vivier
To allow QEMU to add PCI entries in device tree, we must have a more exhaustive list of PCI class IDs. This patch synchronizes as much as possible with pci_ids.h and add some missing IDs from SLOF. Signed-off-by: Laurent Vivier Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cpu object reference leak

2017-02-17 Thread Peter Maydell
On 16 February 2017 at 15:11, Igor Mammedov wrote: > On Thu, 16 Feb 2017 14:18:05 + > Peter Maydell wrote: >> I've always found the object reference semantics somewhat >> confusing (why does realizing a device add a reference, >> for instance?).

[Qemu-devel] [PATCH v6 0/2] spapr: generate DT node names

2017-02-17 Thread Laurent Vivier
This series is a rebased series from September 2015, it has been reviewed but has never reached the master branch. When DT node names for PCI devices are generated by SLOF, they are generated according to the type of the device (for instance, ethernet for virtio-net-pci device). Node name for

Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2017-02-17 Thread Kevin Wolf
Am 07.02.2017 um 11:13 hat Fam Zheng geschrieben: > On Wed, 01/25 12:42, Jeff Cody wrote: > > From: Kevin Wolf > > > > This splits the logic in the old parse_chap() function into a part that > > parses the -iscsi options into the new driver-specific options, and > > another

Re: [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

2017-02-17 Thread Peter Maydell
On 14 February 2017 at 18:52, P J P wrote: > From: Prasad J Pandit > > Hello, > > In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode > register is used to control 's->blkcnt' value. This bit is not relevant > in single block

Re: [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

2017-02-17 Thread Peter Maydell
On 15 February 2017 at 04:58, P J P wrote: > Hello Alistair, > > +-- On Tue, 14 Feb 2017, Alistair Francis wrote --+ > | On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: > | > From: Prasad J Pandit > | > > | > In the SDHCI

Re: [Qemu-devel] [PATCH v12 23/24] hw/misc/imx6_src: defer clearing of SRC_SCR reset bits

2017-02-17 Thread Peter Maydell
On 13 February 2017 at 12:10, Alex Bennée wrote: > The arm_reset_cpu/set_cpu_on/set_cpu_off() functions do their work > asynchronously in the target vCPUs context. As a result we need to > ensure the SRC_SCR reset bits correctly report the reset status at the > right time.

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Igor Mammedov
On Fri, 17 Feb 2017 13:50:40 +0100 Laszlo Ersek wrote: > CC Dave > > On 02/17/17 11:43, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This implements the VM

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 13:55 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.02.2017 15:21, Kevin Wolf wrote: > > Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 16.02.2017 15:47, Kevin Wolf wrote: > > Sorry, this was sent too early. Next attempt...

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-17 Thread Peter Lieven
Am 03.02.2017 um 19:31 schrieb Paolo Bonzini: > > On 03/02/2017 00:20, Peter Lieven wrote: >> Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >>> On 31/01/2017 07:36, Peter Lieven wrote: the current implementation fails if we try to freeze an already frozen filesystem. This can happen if a

Re: [Qemu-devel] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 13:24 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 17:08, Kevin Wolf wrote: > >Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>Realize block bitmap storing interface, to allow qcow2 images store > >>persistent bitmaps. > >> > >>Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
17.02.2017 15:21, Kevin Wolf wrote: Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 15:47, Kevin Wolf wrote: Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir

Re: [Qemu-devel] [PATCH v2] target-arm: Implement BCM2835 hardware RNG

2017-02-17 Thread Peter Maydell
On 10 February 2017 at 21:08, Marcin Chojnacki wrote: > Recent vanilla Raspberry Pi kernels started to make use of > the hardware random number generator in BCM2835 SoC. As a > result, those kernels wouldn't work anymore under QEMU > but rather just freeze during the boot

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Alberto Garcia
On Fri 17 Feb 2017 01:30:09 PM CET, Pankaj Gupta wrote: > I think 'posix_madvise' was added for systems which didnot have > 'madvise' [...] For the systems which don't have madvise call > 'posix_madvise' is called which as per discussion is not right thing > for 'DONTNEED' option. It will not give

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
CC Dave On 02/17/17 11:43, Igor Mammedov wrote: > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.02.2017 15:09, Kevin Wolf wrote: > >Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>16.02.2017 14:49, Kevin Wolf wrote: > >>>Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > Am 15.02.2017 um

Re: [Qemu-devel] Interconnect two qemu (Stellaris LM3S6965EVB) instances via I2C

2017-02-17 Thread Paolo Bonzini
On 17/02/2017 13:27, Richard Peters wrote: > Hi Community, > > The Qemu target 'LM3S6965EVB' supports I2C. > I have two firmware versions for a LM3S6965EVB chip that i want to test > with qemu. One is the master and the other is slave. > They use I2C drivers for the LM3S6965EVB chip. There is

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
17.02.2017 15:09, Kevin Wolf wrote: Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 14:49, Kevin Wolf wrote: Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Auto loading bitmaps are

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Alberto Garcia
On Fri 17 Feb 2017 12:30:28 PM CET, Pankaj Gupta wrote: >> > To maintain consistency at all the places use qemu_madvise wrapper >> > inplace of madvise call. >> >> > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); >> > +qemu_madvise((uint8_t *) t + offset, length,

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Pankaj Gupta
> > * Pankaj Gupta (pagu...@redhat.com) wrote: > > > > Thanks for your comments. I have below query. > > > > > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > > > To maintain consistency at all the places use qemu_madvise wrapper > > > > inplace of madvise call. > > > > > > >

[Qemu-devel] Interconnect two qemu (Stellaris LM3S6965EVB) instances via I2C

2017-02-17 Thread Richard Peters
Hi Community, The Qemu target 'LM3S6965EVB' supports I2C. I have two firmware versions for a LM3S6965EVB chip that i want to test with qemu. One is the master and the other is slave. They use I2C drivers for the LM3S6965EVB chip. How can i connect these two instances? I didn't found a simple

Re: [Qemu-devel] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
16.02.2017 17:08, Kevin Wolf wrote: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz

[Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand()

2017-02-17 Thread Peter Maydell
Switch to using qcrypto_random_bytes() rather than rand() as our source of randomness for the BCM2835 RNG. If qcrypto_random_bytes() fails, we don't want to return the guest a non-random value in case they're really using it for cryptographic purposes, so the best we can do is a fatal error.

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 15:47, Kevin Wolf wrote: > >Sorry, this was sent too early. Next attempt... > > > >Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: > >>Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>>Auto

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

2017-02-17 Thread Fam Zheng
On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 16:48, Fam Zheng wrote: > > On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > > > When testing migration, auto-generated by qemu node-names differs in > > > source and destination qemu and migration fails. After this

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 14:49, Kevin Wolf wrote: > >Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > >>Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>>Auto loading bitmaps are bitmaps stored in the disk image,

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
16.02.2017 15:47, Kevin Wolf wrote: Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Chad Joan
Sure. I'll see your -O2 and raise you a -c ;) It went like this: $ gcc -c first.c -O2 $ gcc -c second.c -O2 $ gcc -c third.c -O2 No complaints from gcc whatsoever (unless I drop the -c, then ld complains about the undefined reference to main, which I think we all expect). Just incase you

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Dr. David Alan Gilbert
* Pankaj Gupta (pagu...@redhat.com) wrote: > > Thanks for your comments. I have below query. > > > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > > To maintain consistency at all the places use qemu_madvise wrapper > > > inplace of madvise call. > > > > > if (length > 0) {

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Pankaj Gupta
Thanks for your comments. I have below query. > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > if (length > 0) { > > -madvise((uint8_t *) t + offset, length,

Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

2017-02-17 Thread Paolo Bonzini
On 16/02/2017 02:31, Gonglei (Arei) wrote: > And the below patch works for me, I can support max 255 vcpus for WS2012 > with hyper-v enlightenments. > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 27fd050..efe3cbc 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Paolo Bonzini
On 17/02/2017 11:18, Peter Maydell wrote: > Defining _XOPEN_SOURCE is easy enough, and I think we should > do it unconditionally. We should check what effect this has > on the BSD hosts though I guess. (You could argue that we > should be defining _XOPEN_SOURCE anyway for the benefit of > the

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Paolo Bonzini
On 17/02/2017 10:17, Laszlo Ersek wrote: > Of course, *if* that other C library, and the Curses implementation, > claim compatibility with glibc as far as _GNU_SOURCE goes, *then* I > fully agree with you. (IOW, it depends on the condition that you > formulated above, "if musl wants to support

Re: [Qemu-devel] [PATCH 0/3] usb-ccid: improve sanity checks

2017-02-17 Thread Marc-André Lureau
On Thu, Feb 16, 2017 at 5:14 PM Gerd Hoffmann wrote: > Hi, > > Small ccid series which improves the ccid_handle_bulk_out sanity checks. > > looks good, Reviewed-by: Marc-André Lureau > > cheers, > Gerd > > Gerd Hoffmann (3): > usb-ccid:

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
16.02.2017 16:48, Fam Zheng wrote: On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: When testing migration, auto-generated by qemu node-names differs in source and destination qemu and migration fails. After this patch, auto-generated by iotest nodenames will be the same. What should

Re: [Qemu-devel] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

2017-02-17 Thread Vladimir Sementsov-Ogievskiy
16.02.2017 17:21, Kevin Wolf wrote: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Add detailed error messages. Signed-off-by: Vladimir Sementsov-Ogievskiy Why not merge this patch into the one that originally introduced the function? Just to

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 08:56, Paolo Bonzini wrote: > So I do think that if musl wants to support _GNU_SOURCE, it should also > auto-define; > however it doesn't, see > https://git.musl-libc.org/cgit/musl/tree/include/features.h. Yes, I agree that this looks like a musl

[Qemu-devel] [PATCH v8 2/2] mach-virt: Provide sample configuration files

2017-02-17 Thread Andrea Bolognani
These are very much like the sample configuration files for q35, and can be used both as documentation and as a starting point for creating your own guest. Two sample configuration files are provided: * mach-virt-graphical.cfg can be used to start a fully-featured (USB, graphical console,

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Fam Zheng
On Fri, 02/17 09:00, Franklin "Snaipe" Mathieu wrote: > Ignore this patch, this was sent again by mistake. Hi Franklin, thanks for the re-submission. Next time please send consecutive versions as top-level threads instead of replies to previous versions, with proper 'v2", "v3" tags in the

[Qemu-devel] [PATCH v8 0/2] docs: Improve sample configuration files

2017-02-17 Thread Andrea Bolognani
Changes since [v7] * Paperwork: - add missing Signed-off-by tags; - pick up Reviewed-by tags from v7. Changes since [v6] * Address review comments: - re-introduce optical media support; - rename PCIe Root Ports from pci.* to pcie.*; - remove reference to GTK+. Changes

[Qemu-devel] [PATCH v8 1/2] q35: Improve sample configuration files

2017-02-17 Thread Andrea Bolognani
Instead of having a single sample configuration file, we now have several: * q35-emulated.cfg documents the default devices QEMU adds to a q35 guest and the additional devices that are pretty much guaranteed to be present in a physical q35-based machine; *

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Fam Zheng
On Fri, 02/17 10:23, Laszlo Ersek wrote: > On 02/17/17 07:43, Fam Zheng wrote: > > On Thu, 02/16 12:47, Chad Joan wrote: > >> I am glad others are chiming in and might provide better solutions. > >> > >> Honestly, following the instructions at > >>

Re: [Qemu-devel] [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Alberto Garcia
On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > To maintain consistency at all the places use qemu_madvise wrapper > inplace of madvise call. > if (length > 0) { > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); > +qemu_madvise((uint8_t *) t + offset,

Re: [Qemu-devel] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > > Signed-off-by: Pankaj Gupta > > Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH] qapi2texi: replace quotation by bold section name

2017-02-17 Thread Marc-André Lureau
When we build qemu-qmp-ref.txt this causes texinfo to complain several times: "Negative repeat count does nothing at /usr/share/texinfo/Texinfo/Convert/Line.pm line 124." It also doesn't display correctly, because the "Notes" text disappears entirely in the HTML version because it thinks there's

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Laszlo Ersek
On 02/17/17 07:43, Fam Zheng wrote: > On Thu, 02/16 12:47, Chad Joan wrote: >> I am glad others are chiming in and might provide better solutions. >> >> Honestly, following the instructions at >> http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite >> daunting to me, just to

Re: [Qemu-devel] [PATCH v3 15/16] target-m68k: add more FPU instructions

2017-02-17 Thread Andreas Schwab
On Feb 17 2017, Richard Henderson wrote: > On 02/16/2017 09:18 PM, Andreas Schwab wrote: >> There is no guarantee that the host long double has the same range and >> precision as floatx80. > > Indeed not. However, do you have another plan for implementing the > trancendentals?

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 06:43, Fam Zheng wrote: > But your point is taken, we should make the first (or a one-shot) > contribution as easy as possible. Yes; we could do with providing a "This page seems very long..." introduction section. The absolute bare minimum requirements

Re: [Qemu-devel] [PATCH v7 RESEND 2/5] hw/intc/arm_gicv3_kvm: Add ICC_SRE_EL1 register to vmstate

2017-02-17 Thread Auger Eric
Hi Vijaya, On 13/02/2017 13:17, Vijay Kilari wrote: > On Tue, Feb 7, 2017 at 8:09 PM, Peter Maydell > wrote: >> On 31 January 2017 at 16:22, wrote: >>> From: Vijaya Kumar K >>> >>> To Save and Restore ICC_SRE_EL1

[Qemu-devel] [PATCH v2] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Franklin Snaipe Mathieu
From: "Franklin \"Snaipe\" Mathieu" The current implementation of the mincore(2) syscall sets errno to EFAULT when the region identified by the first two parameters is invalid. This goes against the man page specification, where mincore(2) should only fail with EFAULT when

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-17 Thread Laszlo Ersek
On 02/17/17 09:56, Paolo Bonzini wrote: > > > On 16/02/2017 18:23, Laszlo Ersek wrote: >> On 02/16/17 17:58, Paolo Bonzini wrote: >>> >>> >>> On 16/02/2017 17:30, Chad Joan wrote: Hello, This is a one-line patch to the configure script that will allow QEMU to be built on

[Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Franklin Snaipe Mathieu
From: "Franklin \"Snaipe\" Mathieu" The current implementation of the mincore(2) syscall sets errno to EFAULT when the region identified by the first two parameters is invalid. This goes against the man page specification, where mincore(2) should only fail with EFAULT when

<    1   2   3   >