Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Daniel P. Berrange" writes: > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: >> > Some of the migration parameters are strings, which default to NULL, >> > eg tls_hostname and tls_creds. >> > >> > The mgmt

Re: [Qemu-devel] [PATCH V2 2/3] COLO-compare: Optimize compare_common and compare_tcp

On 2017年02月28日 14:11, Zhang Chen wrote: OK, How about this? +/* + * Because of ppkt and spkt are both in the same connection, + * The ppkt's src ip, dst ip, src port, dst port, ip_proto all are + * same with spkt. In addition, IP header's Identification is a random +

Re: [Qemu-devel] [PATCH] virtio: unbreak virtio-pci with IOMMU after caching ring translations

On 2017年03月02日 13:10, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 12:10:40PM +0800, Jason Wang wrote: Commit c611c76417f5 ("virtio: add MemoryListener to cache ring translations") registers a memory listener to dma_as. This may not work when IOMMU is enabled: dma_as(bus_master_as) were

Re: [Qemu-devel] [PATCH] Removed header qemu-common.h from path.c

Copying . Suramya Shah writes: > Signed-off-by: Suramya Shah > --- > util/path.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/util/path.c b/util/path.c > index 5479f76..46a6098 100644 > ---

[Qemu-devel] [PULL 08/15] virtio: check for vring setup in virtio_queue_empty

From: Paolo Bonzini If the vring has not been set up, there is nothing in the virtqueue. virtio_queue_host_notifier_aio_poll calls virtio_queue_empty even in this case; we have to filter it out just like virtio_queue_notify_aio_vq. Reported-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v3] intel_iommu: check misordered init when realize

On 03/02/2017 07:13 AM, Michael S. Tsirkin wrote: On Thu, Mar 02, 2017 at 11:32:18AM +0800, Peter Xu wrote: Intel vIOMMU devices are created with "-device" parameter, while here actually we need to make sure the dmar device be created before other PCI devices (like vfio-pci, virtio-pci ones) so

Re: [Qemu-devel] [PATCH V2 0/4] hw/virtio: fix several PCI Express compliance issues

On 02/20/2017 10:43 PM, Marcel Apfelbaum wrote: v1 -> v2: - Added compat properties (Michael S. Tsirkin) - Rebased on latest master - Regarding the patch 1/4, we don't need to init the PCI "standard" config capabilities to 0 since they are "protected" by the Capabilities List bit

[Qemu-devel] [PULL 06/15] tests: Move reusable ACPI code into a utility file

From: Ben Warren Also usable by upcoming VM Generation ID tests Signed-off-by: Ben Warren Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov ---

[Qemu-devel] [PULL 14/15] tests/acpi: update DSDT after last patch

Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/q35/DSDT| Bin 7860 -> 7824 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 7877 -> 7841 bytes tests/acpi-test-data/q35/DSDT.cphp | Bin 8323 -> 8287 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 7935 ->

[Qemu-devel] [PULL 13/15] acpi: simplify _OSC

Our _OSC method has a bunch of unused code loading data into external CTRL and SUPP fields which are then never used. Drop this in favor of a single local variable. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 15/15] hw/pxb-pcie: fix PCI Express hotplug support

From: Marcel Apfelbaum Add the missing osc method for pxb-pcie devices as APCI spec recommends, see 6.2.9.1 OSC Implementation Example for PCI Host Bridge Devices, ACPI 3.0a: It is recommended that a machine with multiple host bridge devices should report the same

[Qemu-devel] [PULL 07/15] MAINTAINERS: Add VM Generation ID entries

From: Ben Warren Signed-off-by: Ben Warren Reviewed-by: Laszlo Ersek Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov ---

[Qemu-devel] [PULL 12/15] virtio: unbreak virtio-pci with IOMMU after caching ring translations

From: Jason Wang Commit c611c76417f5 ("virtio: add MemoryListener to cache ring translations") registers a memory listener to dma_as. This may not work when IOMMU is enabled: dma_as(bus_master_as) were initialized in pcibus_machine_done() after virtio_realize(). This will

[Qemu-devel] [PULL 11/15] virtio: add missing region cache init in virtio_load()

From: Stefan Hajnoczi Commit 97cd965c070152bc626c7507df9fb356bbe1cd81 ("virtio: use VRingMemoryRegionCaches for avail and used rings") switched to a memory region cache to avoid repeated map/unmap operations. The virtio_load() process is a little tricky because vring

[Qemu-devel] [PULL 10/15] virtio: invalidate memory in vring_set_avail_event()

From: Stefan Hajnoczi Remember to invalidate the avail event field so the memory pages are marked dirty. Cc: Paolo Bonzini Signed-off-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 04/15] ACPI: Add Virtual Machine Generation ID support

From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

[Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake

[Qemu-devel] [PULL 09/15] virtio: guard vring access when setting notification

From: Cornelia Huck Switching to vring caches exposed an existing bug in virtio_queue_set_notification(): We can't access vring structures if they have not been set up yet. This may happen, for example, for virtio-blk devices with multiple queues: The code will try to

[Qemu-devel] [PULL 01/15] linker-loader: Add new 'write pointer' command

From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren

[Qemu-devel] [PULL 00/15] virtio, pc: fixes, features

The following changes since commit 1e0addb682c3c552fd97480037d4f8ff18e2b87e: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170228-tag' into staging (2017-03-01 20:33:47 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

From: Ben Warren This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) Requirements section, ASCII diagrams and overall help provided by Laszlo Ersek (ler...@redhat.com) Signed-off-by: Gal Hammer Signed-off-by: Ben Warren

[Qemu-devel] [PULL 03/15] ACPI: Add vmgenid blob storage to the build tables

From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid_guid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() ->

Re: [Qemu-devel] [PATCH v3] intel_iommu: check misordered init when realize

On Thu, Mar 02, 2017 at 01:20:53PM +0800, Peter Xu wrote: > On Thu, Mar 02, 2017 at 07:13:08AM +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 02, 2017 at 11:32:18AM +0800, Peter Xu wrote: > > > Intel vIOMMU devices are created with "-device" parameter, while here > > > actually we need to make

Re: [Qemu-devel] [PATCH v3] intel_iommu: check misordered init when realize

On Thu, Mar 02, 2017 at 07:13:08AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 02, 2017 at 11:32:18AM +0800, Peter Xu wrote: > > Intel vIOMMU devices are created with "-device" parameter, while here > > actually we need to make sure the dmar device be created before other > > PCI devices (like

Re: [Qemu-devel] [PATCH v3] intel_iommu: check misordered init when realize

On Thu, Mar 02, 2017 at 11:32:18AM +0800, Peter Xu wrote: > Intel vIOMMU devices are created with "-device" parameter, while here > actually we need to make sure the dmar device be created before other > PCI devices (like vfio-pci, virtio-pci ones) so that we know iommu_fn > will be setup

Re: [Qemu-devel] [PATCH] virtio: unbreak virtio-pci with IOMMU after caching ring translations

On Wed, Mar 01, 2017 at 12:10:40PM +0800, Jason Wang wrote: > Commit c611c76417f5 ("virtio: add MemoryListener to cache ring > translations") registers a memory listener to dma_as. This may not > work when IOMMU is enabled: dma_as(bus_master_as) were initialized in > pcibus_machine_done() after

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On 02-Mar-2017 8:07 AM, "Richard Henderson" wrote: > > On 03/02/2017 02:24 AM, Nikunj A Dadhania wrote: > >> +static void float64_madd_set_vxisi(CPUPPCState *env, float64 a, float64 >> b, >> + float64 c, unsigned int flags) >> { >> +float64

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

Oh, some gmail issues, resending: > On 02-Mar-2017 7:53 AM, "Richard Henderson" wrote: > > On 03/02/2017 11:29 AM, David Gibson wrote: > >> On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: >> >>> Use the softfloat api for fused multiply-add. Also, generate

Re: [Qemu-devel] [PATCH] spapr_pci: allow control of BAR alignment through SLOF

Quoting David Gibson (2017-02-28 20:56:44) > On Tue, Feb 28, 2017 at 06:56:47PM -0600, Michael Roth wrote: > > In certain cases, such as PCI-passthrough with VFIO, we cannot offload > > MMIO accesses to KVM unless the BAR alignment matches the host. This > > patch, in conjunction with a separately

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On 02-Mar-2017 8:07 AM, "Richard Henderson" wrote: On 03/02/2017 02:24 AM, Nikunj A Dadhania wrote: > +static void float64_madd_set_vxisi(CPUPPCState *env, float64 a, float64 > b, > + float64 c, unsigned int flags) > { > +float64 f =

[Qemu-devel] Patch causes Mac OS X to print dead controller messages

commit 95ed56939eb2eaa4e2f349fe6dcd13ca4edfd8fb usb: ohci: limit the number of link eds This patch causes Mac OS X to continuously print this message: USBF: 35.508 AppleUSBOHCI[0x1187000] Watchdog detected dead controller (hcca #: 0, hc#: 863) I used git bisect to find this patch. None of the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On 02-Mar-2017 7:53 AM, "Richard Henderson" wrote: On 03/02/2017 11:29 AM, David Gibson wrote: > On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: > >> Use the softfloat api for fused multiply-add. Also, generate VXISI using >> a helper function by computing

[Qemu-devel] [PATCH] net/filter-mirror: Follow CODING_STYLE

Signed-off-by: Zhang Chen --- net/filter-mirror.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/filter-mirror.c b/net/filter-mirror.c index aa0aa98..72fa7c2 100644 --- a/net/filter-mirror.c +++ b/net/filter-mirror.c @@ -49,7 +49,7

Re: [Qemu-devel] [PATCH] linux-user: fix inotify

On 03/01/2017 09:54 PM, Laurent Vivier wrote: When a fd is opened using inotify_init(), a read provides one or more inotify_event structures: struct inotify_event { int wd; uint32_t mask; uint32_t cookie; uint32_t len; char name[]; };

[Qemu-devel] [PULL v3 3/5] block/rbd: parse all options via bdrv_parse_filename

Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename. This simplifies a lot of the parsing as well, as we can treat everything a bit simpler since nonexistent options are simply NULL pointers instead of empty strings. An important item to note: Ceph has many extra option values that can

Re: [Qemu-devel] [PULL v2 0/5] Block patches for 2.9

On Wed, Mar 01, 2017 at 04:30:55PM +, Peter Maydell wrote: > On 28 February 2017 at 16:34, Jeff Cody wrote: > > The following changes since commit c8c0a1a784cdf70ecea50e93213137c6c89337a7: > > > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into >

[Qemu-devel] [PULL v3 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI

This adds support for three additional options that may be specified by QAPI in blockdev-add: server: host, port auth method: either 'cephx' or 'none' The "server" and "auth-supported" QAPI parameters are arrays. To conform with the rados API, the array items are join as a single string

[Qemu-devel] [PULL v3 4/5] block/rbd: add blockdev-add support

Reviewed-by: Eric Blake Signed-off-by: Jeff Cody --- qapi/block-core.json | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index cf24c04..803edc3 100644 ---

[Qemu-devel] [PULL v3 0/5] Block patches for 2.9

The following changes since commit c8c0a1a784cdf70ecea50e93213137c6c89337a7: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2017-02-28 13:41:03 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

[Qemu-devel] [PULL v3 1/5] block/rbd: don't copy strings in qemu_rbd_next_tok()

This patch is prep work for parsing options for .bdrv_parse_filename, and using QDict options. The function qemu_rbd_next_tok() searched for various key/value pairs, and copied them into buffers. This will soon be an unnecessary extra step, so we will now return found strings by reference only,

[Qemu-devel] [PULL v3 2/5] block/rbd: add all the currently supported runtime_opts

This adds all the currently supported runtime opts, which are the options as parsed from the filename. All of these options are explicitly checked for during during runtime, with an exception to the "keyvalue-pairs" option. This option contains all the key/value pairs that the QEMU rbd driver

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Wed, Mar 01, 2017 at 02:32:34PM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 11:59 AM, Peter Xu wrote: > >On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: > >>On 03/01/2017 11:18 AM, Peter Xu wrote: > >>>On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: >

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Wed, Mar 01, 2017 at 12:14:21PM +0800, Jason Wang wrote: > On 2017年03月01日 11:23, Michael S. Tsirkin wrote: [...] > >While I agree this fixes the specific problem, we have the ordering > >issue in many other places. > > Yes, just post a fix for virtio-pci with IOMMU. With this fix, we meet

[Qemu-devel] [PATCH v3] intel_iommu: check misordered init when realize

Intel vIOMMU devices are created with "-device" parameter, while here actually we need to make sure the dmar device be created before other PCI devices (like vfio-pci, virtio-pci ones) so that we know iommu_fn will be setup correctly before realizations of those PCI devices (it is legal that PCI

[Qemu-devel] [Bug 1617114] Re: Qemu 2.6.0 freezes with windows guests

More narrowed now, :-) With 2.8.0 qemu keeps freezing bad, when used with "-display sdl". However when used with "-display gtk" or "-display none", then it doesn't freeze. So it seems "-display sdl" is the one totally breaking windows guest on qemu. Notice that if I don't try other displays,

Re: [Qemu-devel] [PATCH qemu v4] exec, kvm, target-ppc: Move getrampagesize() to common code

iy <a...@ozlabs.ru> Applied, thanks. > --- > Changes: > v4: > * removed numa.h from kvm.c as it is not needed there anymore > > v3: > * in exec.c, moved "include numa.h" under #ifndef CONFIG_USER_ONLY to > fix linux-user target build > > v2: > * rebased on t

Re: [Qemu-devel] [PATCH 0/6] target/s390x patches

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170302024110.3978-1-...@twiddle.net Type: series Subject: [Qemu-devel] [PATCH 0/6] target/s390x patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH 5/6] target/s390x: Use atomic operations for COMPARE SWAP

Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/mem_helper.c | 39 ++ target/s390x/translate.c | 83 +-- 3 files changed, 55 insertions(+), 68 deletions(-) diff --git

[Qemu-devel] [PATCH 3/6] target/s390x: Diagnose specification exception for atomics

All of the interlocked access facility instructions raise a specification exception for unaligned accesses. Do this by using the (previously unused) unaligned_access hook. Signed-off-by: Richard Henderson --- target/s390x/cpu.c| 1 + target/s390x/cpu.h| 3 +++

[Qemu-devel] [PATCH 4/6] target/s390x: Implement LOAD PAIR DISJOINT

From: Eric Bischoff Signed-off-by: Eric Bischoff Message-Id: <20170228120134.7921-1-ebisch...@suse.com> [rth: Combine the two via insn->data; free the address temps.] Signed-off-by: Richard Henderson --- target/s390x/insn-data.def |

[Qemu-devel] [PATCH 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

At the same time, improve STORE FACILITIES LIST so that we don't hard-code the list for all cpus. Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/misc_helper.c | 41

[Qemu-devel] [PATCH 6/6] target/s390x: Use atomic operations for LOAD AND OP

Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 20 ++-- target/s390x/translate.c | 78 +- 2 files changed, 60 insertions(+), 38 deletions(-) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH 2/6] target/s390x: Implement LOAD PROGRAM PARAMETER

From: Miroslav Benes Linux arch/s390/kernel/head(64).S uses LPP instruction if it is available in facilities list provided by stfl/stfle instruction. This is the case of newer z/System generations and their qemu definition. The description of LPP is at

[Qemu-devel] [PATCH 0/6] target/s390x patches

Herein find my 3 year old STFLE patch, two of the patches that were posted this week for LPP and LPD, and three patches to convert the atomic operations in the s390 frontend to actually be atomic. r~ Eric Bischoff (1): target/s390x: Implement LOAD PAIR DISJOINT Miroslav Benes (1):

Re: [Qemu-devel] [PATCH qemu] target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64

On 09/01/17 13:53, David Gibson wrote: > On Mon, Jan 09, 2017 at 01:38:26PM +1100, Alexey Kardashevskiy wrote: >> On 03/01/17 13:26, David Gibson wrote: >>> On Thu, Dec 22, 2016 at 12:13:12PM +1100, Alexey Kardashevskiy wrote: KVM_CAP_SPAPR_TCE capability allows creating TCE tables in KVM

Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On 03/02/2017 02:24 AM, Nikunj A Dadhania wrote: +static void float64_madd_set_vxisi(CPUPPCState *env, float64 a, float64 b, + float64 c, unsigned int flags) { +float64 f = float64_mul(a, b, >fp_status); What is the point of this multiply? +/* a*b =

[Qemu-devel] [PATCH qemu v4] exec, kvm, target-ppc: Move getrampagesize() to common code

ma.h" under #ifndef CONFIG_USER_ONLY to fix linux-user target build v2: * rebased on top of ppc-for-2.9-20170301 --- include/exec/ram_addr.h | 1 + include/qemu/mmap-alloc.h | 2 + exec.c| 82 ++ target/ppc/kvm.

Re: [Qemu-devel] [PATCH qemu v3] exec, kvm, target-ppc: Move getrampagesize() to common code

h from kvm.c > > Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> > --- > Changes: > v3: > * in exec.c, moved "include numa.h" under #ifndef CONFIG_USER_ONLY to > fix linux-user target build > > v2: > * rebased on top of ppc-for-2.9-20170301 &

Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On 03/02/2017 11:29 AM, David Gibson wrote: On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: Use the softfloat api for fused multiply-add. Also, generate VXISI using a helper function by computing intermediate result. Um.. I really need some information on why this is a good

[Qemu-devel] [PATCH qemu v3] exec, kvm, target-ppc: Move getrampagesize() to common code

target build v2: * rebased on top of ppc-for-2.9-20170301 --- include/exec/ram_addr.h | 1 + include/qemu/mmap-alloc.h | 2 + exec.c| 82 +++ target/ppc/kvm.c | 108 +++--- util/mmap-alloc

Re: [Qemu-devel] [PATCH 5/5] xen: use libxendevicemodel when available

On Thu, 23 Feb 2017, Paul Durrant wrote: > This patch modifies the wrapper functions in xen_common.h to use the > new xendevicemodel interface if it is available along with compatibility > code to use the old libxenctrl interface if it is not. > > Signed-off-by: Paul Durrant

Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: > Use the softfloat api for fused multiply-add. Also, generate VXISI using > a helper function by computing intermediate result. Um.. I really need some information on why this is a good thing to do. Is it a bugfix? Enhancement?

[Qemu-devel] [PATCH] linux-user: fix inotify

When a fd is opened using inotify_init(), a read provides one or more inotify_event structures: struct inotify_event { int wd; uint32_t mask; uint32_t cookie; uint32_t len; char name[]; }; The integer fields must be byte-swapped to the

[Qemu-devel] [PATCH] linux-user: fix fadvise64_64() on ppc

On ppc, advice is arg2, not arg6: long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low, u32 len_high, u32 len_low) Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Thu, Mar 02, 2017 at 01:36:25AM +0200, Michael S. Tsirkin wrote: > libtpms seems to be packaged and used outside QEMU, I don't say we need > to have that in tree. I thought we were discussing swtpm cuse thing. In any case, I'd like to stress that my comments aren't absolute. I merely

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 01, 2017 at 02:24:20PM -0500, Stefan Berger wrote: > > > Anyway, having it in a separate process locked down by SELinux means that > > > even > > > if it does go horribly wrong it won't break qemu. > > > > > > Dave > > Since qemu does blocking ioctls on it and doesn't validate

Re: [Qemu-devel] [PATCH v4] backup: allow target without .bdrv_get_info

On 02/28/2017 01:33 PM, Vladimir Sementsov-Ogievskiy wrote: > Currently backup to nbd target is broken, as nbd doesn't have > .bdrv_get_info realization. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v4: use error_report() > add article > > v3: fix

Re: [Qemu-devel] [PULL 0/2] tags/xen-20170228-tag

On 28 February 2017 at 19:15, Stefano Stabellini wrote: > The following changes since commit 7d1730b7d9d8272a13245adfc9b0405e5a4bd0c2: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2017-02-28 16:22:41 +) > > are available

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

On Thu, Feb 16, 2017 at 09=33=16AM +, Daniel P. Berrange wrote: > On Thu, Feb 16, 2017 at 12:36:51AM +0100, Eduardo Otubo wrote: > > On Wed, Feb 15, 2017 at 06=27=32PM +, Daniel P. Berrange wrote: [...] > > > > > > There is a reasonable easily identifiable set of syscalls that QEMU

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 01, 2017 at 06:56:17PM +, Daniel P. Berrange wrote: > On Wed, Mar 01, 2017 at 06:32:19PM +, Marc-André Lureau wrote: > > Hi > > > > On Wed, Mar 1, 2017 at 10:20 PM Michael S. Tsirkin wrote: > > > > > > > > > You're also tieing the code > > > > into the QEMU

Re: [Qemu-devel] [PATCH] qmp-shell: add persistent command history

On 03/01/2017 05:01 PM, Nir Soffer wrote: > On Wed, Mar 1, 2017 at 9:44 PM, John Snow wrote: >> >> Use the existing readline history function we are utilizing >> to provide persistent command history across instances of qmp-shell. >> >> This assists entering debug commands

[Qemu-devel] -rtc clock=vm with -icount 1, sleep=off does not appear to keep the rtc aligned with the virtual clock

I'm having trouble with this patch http://web.ornl.gov/~1qn/adevs/qqq.patch which worked until I checked out the newest working copy of qemu from the main branch. The problem manifests itself when the elapsed time between virtual clock events and the time reported by, say, a call to 'date' in

Re: [Qemu-devel] [PATCH] qmp-shell: add persistent command history

On Wed, Mar 1, 2017 at 9:44 PM, John Snow wrote: > > Use the existing readline history function we are utilizing > to provide persistent command history across instances of qmp-shell. > > This assists entering debug commands across sessions that may be > interrupted by QEMU

Re: [Qemu-devel] [RFC Design Doc v3] Enable Shared Virtual Memory feature in pass-through scenarios

On Wed, Mar 01, 2017 at 04:09:38PM -0500, Konrad Rzeszutek Wilk wrote: > .snip.. > > > > No. SVM is purely about sharing CPU address space with device. Command > > submission is still through kernel driver which controls rings (with SVM > > then > > you can put VA into those commands). There are

Re: [Qemu-devel] [PATCH v3 1/3] qemu-options: explain disk I/O throttling options

On Wed, 1 Mar 2017 11:50:24 + Stefan Hajnoczi wrote: > The disk I/O throttling options have been listed for a long time but > never explained on the QEMU man page. > > Suggested-by: Nini Gu > Cc: Alberto Garcia > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation

On Wed, 1 Mar 2017 11:50:23 + Stefan Hajnoczi wrote: > v3: > * Added Patch 2 to fix invalid test parameters > * Switched to nicer max < avg check [Berto] > v2: > * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto] > * Rephrased warning about guest hangs and

Re: [Qemu-devel] [RFC Design Doc v3] Enable Shared Virtual Memory feature in pass-through scenarios

.snip.. > > > Shared Virtual Memory feature in pass-through scenarios is actually SVM > > > virtualization. It is to let application programs(running in guest)share > > > their > > > virtual address with assigned device(e.g. graphics processors or > > > accelerators). > > > > I think I am

Re: [Qemu-devel] xtensa failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

On 1 March 2017 at 20:32, Alex Bennée wrote: > However I ran into another problem. Code generation leads to a tlb_fill > which runs afoul of a nested tb_lock(). I'm pretty sure the front-end is > using the wrong thing to fetch code: Isn't that the expected (if admittedly

Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28

On 28 February 2017 at 19:06, Markus Armbruster wrote: > The following changes since commit 7d1730b7d9d8272a13245adfc9b0405e5a4bd0c2: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2017-02-28 16:22:41 +) > > are available in the

Re: [Qemu-devel] xtensa failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Thomas Huth writes: > On 01.03.2017 12:36, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> I got a make check failure on aarch64 host running a sparc64 test: >>> >>> >>> TEST: tests/prom-env-test... (pid=13573) >>> /sparc64/prom-env/sun4u:

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

On 02/28/2017 08:03 PM, Li Qiang wrote: > Hello John, Paolo, > > 2017-03-01 8:47 GMT+08:00 John Snow >: > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

On 01.03.2017 20:30, Richard Henderson wrote: > On 03/01/2017 07:00 PM, Thomas Huth wrote: >>> Primarily, it does not raise an exception for error. >> >> Protection and page faults should be generated properly via >> trigger_access_exception() there ... or did I miss something? > > So why does

Re: [Qemu-devel] [PATCH v2 03/21] xen: use a better chardev type check

On 02/27/2017 07:41 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > xen-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/xen-common.c b/xen-common.c > index

[Qemu-devel] [PULL] target/sparc: Restore ldstub of odd asis

Fixes the booting of ss20 roms. Cc: qemu-sta...@nongnu.org Reported-by: Michael Russo Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 27 +-- 1 file

[Qemu-devel] [PULL] target/sparc queued patch

This one has been languishing for a few weeks. r~ The following changes since commit b28f9db1a7ce4d537ce2fae6fbce5e5e37dc265b: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170228-1' into staging (2017-03-01 17:58:54 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On 01/03/2017 17:08, Halil Pasic wrote: > applied I do not see the problem any more. I will most likely > turn this into a patch tomorrow. I would like to give it some more testing and > thinking (see questions below) until tomorrow. > > I should probably cc stable, or? Yes, please do! > >

Re: [Qemu-devel] [PATCH v2 02/21] mux: simplfy muxes_realize_done

On 02/27/2017 07:41 AM, Marc-André Lureau wrote: > mux_chr_event() already send events to all backends, rename it, > export it, and use it from muxes_realize_done. This should help abstract > away mux implementation. > > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PATCH] qmp-shell: add persistent command history

Use the existing readline history function we are utilizing to provide persistent command history across instances of qmp-shell. This assists entering debug commands across sessions that may be interrupted by QEMU sessions terminating, where the qmp-shell has to be relaunched. Signed-off-by:

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

On 03/01/2017 07:00 PM, Thomas Huth wrote: Primarily, it does not raise an exception for error. Protection and page faults should be generated properly via trigger_access_exception() there ... or did I miss something? So why does s390_cpu_virt_mem_rw document that it returns non-zero if

Re: [Qemu-devel] [PULL 00/21] target-arm queue

On 28 February 2017 at 17:15, Peter Maydell wrote: > Second lot of ARM changes to sneak in before freeze: > * fixed version of the raspi2 sd controller patches > * GICv3 save/restore > * v7M QOMify > > I've also included the Linux header update patches stolen > from

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On 03/01/2017 01:30 PM, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 06:18:01PM +, Dr. David Alan Gilbert wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: On Wed, Mar 01, 2017 at 06:06:02PM +, Dr. David Alan Gilbert wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: On

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 1, 2017 at 10:56 PM Daniel P. Berrange wrote: > On Wed, Mar 01, 2017 at 06:32:19PM +, Marc-André Lureau wrote: > > Hi > > > > On Wed, Mar 1, 2017 at 10:20 PM Michael S. Tsirkin > wrote: > > > > > > > > > You're also tieing the code > > > >

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 01, 2017 at 06:32:19PM +, Marc-André Lureau wrote: > Hi > > On Wed, Mar 1, 2017 at 10:20 PM Michael S. Tsirkin wrote: > > > > > > You're also tieing the code > > > into the QEMU release cycle, again for no tangible benefit. > > > > No need for ABI stability

Re: [Qemu-devel] xtensa failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

On 01.03.2017 12:36, Alex Bennée wrote: > > Peter Maydell writes: > >> I got a make check failure on aarch64 host running a sparc64 test: >> >> >> TEST: tests/prom-env-test... (pid=13573) >> /sparc64/prom-env/sun4u: ** >>

Re: [Qemu-devel] s390x failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Thomas Huth writes: > On 01.03.2017 12:36, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> I got a make check failure on aarch64 host running a sparc64 test: >>> >>> >>> TEST: tests/prom-env-test... (pid=13573) >>> /sparc64/prom-env/sun4u:

Re: [Qemu-devel] [RFC 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170301182618.22395-1-k...@kernel.org Type: series Subject: [Qemu-devel] [RFC 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Mark Cave-Ayland writes: > On 01/03/17 15:19, Alex Bennée wrote: > >> Actually looking at where cpu_check_irq is I've pushed the BQL wraps >> higher up: >> >> >> https://github.com/stsquad/qemu/commit/f52e01bf4d3415ce4fad54cbb491f6c30a8e1903 >> >> The reasoning

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

Hi On Wed, Mar 1, 2017 at 10:20 PM Michael S. Tsirkin wrote: > > > You're also tieing the code > > into the QEMU release cycle, again for no tangible benefit. > > No need for ABI stability would be the benefit. > We are talking about the control channel ABI (the data channel

[Qemu-devel] [PATCH 3/5] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines

Statements under 'case' were in some places wrongly indented bringing confusion and making the code less readable. Remove also few unneeded blank lines. No functional changes. Signed-off-by: Krzysztof Kozlowski --- hw/timer/exynos4210_mct.c | 45

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 01, 2017 at 06:18:01PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Mar 01, 2017 at 06:06:02PM +, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Wed, Mar 01, 2017 at 05:38:23PM +,

  1   2   3   >