Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 18:08, Daniel P. Berrange wrote: > On Wed, Mar 15, 2017 at 06:00:40PM +, Peter Maydell wrote: >> On 15 March 2017 at 17:46, Simon wrote: >> > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the >> > same behavior. >> > >> > SIGQUIT is reserved for core

Re: [Qemu-devel] [PATCH for 2.9] migration: use "" as the default for tls-creds/hostname

2017-03-15 Thread Eric Blake
On 03/15/2017 11:16 AM, Daniel P. Berrange wrote: > The tls-creds parameter has a default value of NULL indicating > that TLS should not be used. Setting it to non-NULL enables > use of TLS. Once tls-creds are set to a non-NULL value via the > monitor, it isn't possible to set them back to NULL aga

Re: [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property

2017-03-15 Thread Stefano Stabellini
On Wed, 15 Mar 2017, Paolo Bonzini wrote: > On 14/03/2017 21:23, Stefano Stabellini wrote: > > On Tue, 14 Mar 2017, Stefano Stabellini wrote: > >>> Then you add to Makefile: > >>> > >>> CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y) > >>> CONFIG_USER_ONLY := $(if $(filter %-user,$(T

Re: [Qemu-devel] [PULL 0/2] Miscellaneous patches for 2017-03-15

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 13:18, Markus Armbruster wrote: > The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: > > Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-mi

Re: [Qemu-devel] [PATCH v2 2/9] xen: import ring.h from xen

2017-03-15 Thread Stefano Stabellini
On Wed, 15 Mar 2017, Greg Kurz wrote: > On Mon, 13 Mar 2017 16:55:53 -0700 > Stefano Stabellini wrote: > > > Do not use the ring.h header installed on the system. Instead, import > > the header into the QEMU codebase. This avoids problems when QEMU is > > built against a Xen version too old to pr

[Qemu-devel] [PATCH] Default to GSSAPI (Kerberos) instead of DIGEST-MD5 for SASL

2017-03-15 Thread Daniel P. Berrange
RFC 6331 documents a number of serious security weaknesses in the SASL DIGEST-MD5 mechanism. As such, QEMU should not be using or recommending it as a default mechanism for VNC auth with SASL. GSSAPI (Kerberos) is the only other viable SASL mechanism that can provide secure session encryption so e

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 06:00:40PM +, Peter Maydell wrote: > On 15 March 2017 at 17:46, Simon wrote: > > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the > > same behavior. > > > > SIGQUIT is reserved for core files generation. > > > > SIGUSR1 is already used in 'util/qe

[Qemu-devel] [PULL 7/7] virtio-pci: reset modern vq meta data

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if a driver enable the vq without setting vq address after reset. The old addresses were leaked. Fixing this by resetting modern vq meta data during device reset. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason

[Qemu-devel] [PULL 4/7] virtio: validate address space cache during init

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang We don't check the return value of address_space_cache_init(), this may lead buggy driver use incorrect region caches. Instead of triggering an assert, catch and warn this early in virtio_init_region_cache(). Cc: Cornelia Huck Cc: Paolo Bonzini Reviewed-by: Cornelia Huck Sign

[Qemu-devel] [PULL 3/7] virtio: destroy region cache during reset

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting to use the device. Fix this by destroy the region cache during reset and validate it before trying to see them.

[Qemu-devel] [PULL 6/7] Revert "virtio: unbreak virtio-pci with IOMMU after caching ring translations"

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang This reverts commit 96a8821d21411f10d77ea994af369c6e5c35a2cc. Previous patch is a better solution which does not require a strict order between virtio and IOMMU. CC: Paolo Bonzini Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PULL 1/7] Bugfix: Handle error if VM Generation ID device not present

2017-03-15 Thread Michael S. Tsirkin
From: Ben Warren This was crashing due to NULL-pointer dereference QMP Test case: == (QEMU) query-vm-generation-id {"error": {"class": "GenericError", "desc": "VM Generation ID device not found"}} HMP Test case: == virsh # qemu-monitor-command --hmp 3 info vm-generation

[Qemu-devel] [PULL 5/7] pci: introduce a bus master container

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring translations") tries to make IOMMU works with virtio memory region cache, but it requires IOMMU to be created before any virtio devices. This is sub optimal, fixing this by introduce a bus master container to

[Qemu-devel] [PULL 0/7] virtio, pc: fixes

2017-03-15 Thread Michael S. Tsirkin
The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 60a8d802

[Qemu-devel] [PULL 2/7] virtio: guard against NULL pfn

2017-03-15 Thread Michael S. Tsirkin
From: Jason Wang To avoid access stale memory region cache after reset, this patch check the existence of virtqueue pfn for all exported virtqueue access helpers before trying to use them. Cc: Cornelia Huck Cc: Paolo Bonzini Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: M

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 17:46, Simon wrote: > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the > same behavior. > > SIGQUIT is reserved for core files generation. > > SIGUSR1 is already used in 'util/qemu-progress.c' to trigger a report > on ongoing jobs, so it does not seem usa

Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 05:06, Stefan Hajnoczi wrote: > The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: > > Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-p

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Simon
Daniel P. Berrange: While I understand your motivation this creates a semantic change for existing users of QEMU. IOW anyone who is currently relying on use of SIGHUP will experiance a regression when upgrading QEMU. So if we want to signal to generate a clean shutdown, we need to pick one that

Re: [Qemu-devel] [PATCH v2] migration/block: Avoid invoking blk_drain too frequently

2017-03-15 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Wed, 03/15 11:37, Lidong Chen wrote: > > Increase bmds->cur_dirty after submit io, so reduce the frequency > > involve into blk_drain, and improve the performance obviously > > when block migration. > > > > The performance test result of this patch: > > >

Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Fix acquire/release in dataplane handlers

2017-03-15 Thread Ed Swierk
On Tue, Mar 14, 2017 at 8:36 AM, Fam Zheng wrote: > After the AioContext lock push down, there is a race between > virtio_scsi_dataplane_start and those "assert(s->ctx && > s->dataplane_started)", because the latter doesn't isn't wrapped in > aio_context_acquire. > > Reproducer is simply booting a

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-15 Thread Jeff Cody
On Wed, Mar 15, 2017 at 04:51:07PM +, Peter Maydell wrote: > On 15 March 2017 at 15:30, James Hanley wrote: > > It would appear that the HTTP versions of the repo URLs are /not/ > > referencing the same backend > > > > jim@jim-VirtualBox:~$ git ls-remote http://git.qemu-project.org/git/dtc

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 15:30, James Hanley wrote: > It would appear that the HTTP versions of the repo URLs are /not/ > referencing the same backend > > jim@jim-VirtualBox:~$ git ls-remote http://git.qemu-project.org/git/dtc.git > 3b9c97093d6e1067f4d24d2bff32f3dd24e0751e HEAD > 827ac8eca016c39b13

Re: [Qemu-devel] [PATCH v2] Change the method to calculate dirty-pages-rate

2017-03-15 Thread Juan Quintela
Chao Fan wrote: > In function cpu_physical_memory_sync_dirty_bitmap, file > include/exec/ram_addr.h: > > if (src[idx][offset]) { > unsigned long bits = atomic_xchg(&src[idx][offset], 0); > unsigned long new_dirty; > new_dirty = ~dest[k]; > dest[k] |= bits; > new_dirty &= bits;

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

2017-03-15 Thread Krzysztof Kozlowski
On Wed, Mar 15, 2017 at 08:05:56AM +, Alex Bennée wrote: > > Krzysztof Kozlowski writes: > > > On Tue, Mar 14, 2017 at 06:24:33PM +, Alex Bennée wrote: > >> That means you're on a pre-mttcg tree so that's not the reason. > > > > I managed to build it on current master (v2.8.0-2182-g5e2fb

Re: [Qemu-devel] [PATCH for 2.9] migration: use "" as the default for tls-creds/hostname

2017-03-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > The tls-creds parameter has a default value of NULL indicating > that TLS should not be used. Setting it to non-NULL enables > use of TLS. Once tls-creds are set to a non-NULL value via the > monitor, it isn't possible to set them back to NULL aga

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add myself as openrisc maintainer

2017-03-15 Thread Alex Bennée
Stafford Horne writes: > Jia has claimed he is no longer able to maintain. I have fixing bugs here > and there and getting familiar with the code base. Orignal thread from Jia: > > https://lists.librecores.org/pipermail/openrisc/2017-January/000321.html > > Signed-off-by: Stafford Horne Revi

Re: [Qemu-devel] KVM call for 2017-03-14

2017-03-15 Thread Greg Kurz
On Wed, 15 Mar 2017 12:25:38 +0100 Laurent Vivier wrote: > Le 15/03/2017 à 11:29, Greg Kurz a écrit : > > On Tue, 14 Mar 2017 11:56:36 +0100 > > Peter Maydell wrote: > > > >> On 14 March 2017 at 09:59, Juan Quintela wrote: > >>> Peter Maydell wrote: > On 14 March 2017 at 09:13, S

[Qemu-devel] need help

2017-03-15 Thread oussema ben khedher
hi i m using the log in_asm to get the assembly code of TB so when i searched inside qemu i find that the function "log_target_disas its the responsible to display assembly instruction but the problem that i did not find how really it works because i need to get all the branch address  thank you

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-15 Thread Alex Bennée
Gerd Hoffmann writes: > Hi, > >> Instead of having MMIO register spaces we use the dirty tracking >> mechanism. Here regions are marked as for dirty tracking and when the >> SoftMMU helper first comes to this bit of memory it will follow the slow >> path and mark region as visited. > > visited

[Qemu-devel] [Bug 1673130] Re: qemu 2.7.0 receives SIGABRT in qemu_coroutine_enter()

2017-03-15 Thread Mohammed Gamal
Another stack trace: -- (gdb) bt #0 0x7f2f34690067 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f2f34691448 in __GI_abort () at abort.c:89 #2 0x5629b8260b6c in qemu_corout

[Qemu-devel] [Bug 1673130] Re: qemu 2.7.0 receives SIGABRT in qemu_coroutine_enter()

2017-03-15 Thread Mohammed Gamal
Third stack trace: -- #0 0x7f4d5ad6a067 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x7f4d5ad6b448 in abort () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x562a4c582b6c in qemu_coroutine_enter (co=0x7f4b1bf

[Qemu-devel] [Bug 1673130] [NEW] qemu 2.7.0 receives SIGABRT in qemu_coroutine_enter()

2017-03-15 Thread Mohammed Gamal
Public bug reported: I've been experiencing frequent SIGABRTs (in addition to segfaults in #1671876) lately with qemu 2.7.0 running Ubuntu 16.04 guests. The crash usually happens in qemu_coroutine_enter(). I haven't seen this so far with any other guests or distros. Here is one stack trace I obta

[Qemu-devel] [PATCH for 2.9] migration: use "" as the default for tls-creds/hostname

2017-03-15 Thread Daniel P. Berrange
The tls-creds parameter has a default value of NULL indicating that TLS should not be used. Setting it to non-NULL enables use of TLS. Once tls-creds are set to a non-NULL value via the monitor, it isn't possible to set them back to NULL again, due to current implementation limitations. The empty s

[Qemu-devel] [Bug 1217339] Re: SIGQUIT to send ACPI-shutdown to Guest

2017-03-15 Thread WhiteWinterWolf
Sorry Thomas, I was not aware of this page. I checked the CODING_STYLE file present in Qemu source before submitting this, maybe it could be useful to include this URL there. Meanwhile, for reference the discussion continues there: https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg03039.

[Qemu-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-15 Thread Igor Druzhinin
Saving/restoring the physmap to/from xenstore was introduced to QEMU majorly in order to cover up the VRAM region restore issue. The sequence of restore operations implies that we should know the effective guest VRAM address *before* we have the VRAM region restored (which happens later). Unfortuna

Re: [Qemu-devel] Obsolete QEMU host environments

2017-03-15 Thread Aurelien Jarno
On 2017-03-15 07:09, Richard Henderson wrote: > On 03/15/2017 03:07 AM, Peter Maydell wrote: > > On 14 March 2017 at 17:54, Thomas Huth wrote: > > > Our ia64 host backend in QEMU (tcg/ia64) is still marked as maintained > > > ... so it's maybe not as dead as you think? Or should we rather get rid

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-15 Thread Gerd Hoffmann
Hi, > Instead of having MMIO register spaces we use the dirty tracking > mechanism. Here regions are marked as for dirty tracking and when the > SoftMMU helper first comes to this bit of memory it will follow the slow > path and mark region as visited. visited? Do you mean dirty bit is set for

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-15 Thread James Hanley
It would appear that the HTTP versions of the repo URLs are /not/ referencing the same backend jim@jim-VirtualBox:~$ git ls-remote http://git.qemu-project.org/git/dtc.git 3b9c97093d6e1067f4d24d2bff32f3dd24e0751e HEAD 827ac8eca016c39b13fc916bbdb16f9f2fe3c34c refs/heads/expressions 3b9c97093d6e1

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Kevin Wolf
Am 15.03.2017 um 16:09 hat Paolo Bonzini geschrieben: > There should be a policy on which BB sets AioContext on the BDS (e.g. > only the device does it), but apart from that, it should not be an issue. > >>> > >>> We don't know which BBs are going to be attached. We don't necessarily > >>

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-15 Thread G 3
On Mar 15, 2017, at 10:25 AM, qemu-devel-requ...@nongnu.org wrote: On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: This updates the FADT generated for x86/64 machine types from Revision 1 to 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to mak

Re: [Qemu-devel] [PATCH v2 for-2.9 02/47] qapi: Make doc comments optional where we don't need them

2017-03-15 Thread Eric Blake
On 03/15/2017 10:13 AM, Markus Armbruster wrote: >>> +Pragma's scope is currently the complete schema. Setting it to >> >> You can do: >> >> { 'pragma': { 'doc-required': true } } >> { 'pragma': { 'whitelist': [...] } } >> >> what you can't do is: >> >> { 'pragma': { 'doc-required': true } } >> {

Re: [Qemu-devel] [PATCH v2 for-2.9 02/47] qapi: Make doc comments optional where we don't need them

2017-03-15 Thread Markus Armbruster
Eric Blake writes: > On 03/15/2017 07:56 AM, Markus Armbruster wrote: >> Since we added the documentation generator in commit 3313b61, doc >> comments are mandatory. That's a very good idea for a schema that >> needs to be documented, but has proven to be annoying for testing. >> >> Make doc co

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Paolo Bonzini
On 15/03/2017 16:02, Kevin Wolf wrote: > Am 15.03.2017 um 15:43 hat Paolo Bonzini geschrieben: >> On 15/03/2017 15:30, Kevin Wolf wrote: >>> Am 15.03.2017 um 14:39 hat Paolo Bonzini geschrieben: On 15/03/2017 12:03, Kevin Wolf wrote: > But we discussed this earlier, and while I'm not com

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Kevin Wolf
Am 15.03.2017 um 15:43 hat Paolo Bonzini geschrieben: > On 15/03/2017 15:30, Kevin Wolf wrote: > > Am 15.03.2017 um 14:39 hat Paolo Bonzini geschrieben: > >> On 15/03/2017 12:03, Kevin Wolf wrote: > >>> But we discussed this earlier, and while I'm not completely sure any > >>> more about the detail

Re: [Qemu-devel] [PATCH v2 for-2.9 31/47] qapi: Fix detection of doc / expression mismatch

2017-03-15 Thread Eric Blake
On 03/15/2017 07:57 AM, Markus Armbruster wrote: > This fixes the errors uncovered by the previous commit. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > def check_freeform_doc(doc): > -if doc.symbol: > -raise QAPISemError(doc.info, > -

Re: [Qemu-devel] [PATCH v2 for-2.9 30/47] tests/qapi-schema: Improve doc / expression mismatch coverage

2017-03-15 Thread Eric Blake
On 03/15/2017 07:57 AM, Markus Armbruster wrote: > New tests doc-before-include.json and doc-before-pragma.json show we > fail to reject a misplaced expression comment. > > New test doc-no-symbol.json shows a bad error message. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake

[Qemu-devel] [Bug 1671876] Re: qemu 2.7.0 segfaults in qemu_co_queue_run_restart()

2017-03-15 Thread Mohammed Gamal
Unfortunately it'd not be possible to use another version at the moment. Is it possible that someone takes a look at the stack traces? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1671876 Title: q

Re: [Qemu-devel] [PATCH v2 for-2.9 06/47] qapi: Have each QAPI schema declare its name rule violations

2017-03-15 Thread Eric Blake
On 03/15/2017 07:56 AM, Markus Armbruster wrote: > qapi.py has a hardcoded white-list of type names that may violate the > rule on use of upper and lower case. Add a new pragma directive > 'name-case-whitelist', and use it to replace the hard-coded > white-list. > > Signed-off-by: Markus Armbrust

[Qemu-devel] [RFC PATCH] ui/console: ensure graphic updates don't race with TCG vCPUs

2017-03-15 Thread Alex Bennée
Commit 8d04fb55.. tcg: drop global lock during TCG code execution ..broke the assumption that updates to the GUI couldn't happen at the same time as TCG vCPUs where running. As a result the TCG vCPU could still be updating a directly mapped frame-buffer while the display side was updating. This

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Paolo Bonzini
On 15/03/2017 15:30, Kevin Wolf wrote: > Am 15.03.2017 um 14:39 hat Paolo Bonzini geschrieben: >> On 15/03/2017 12:03, Kevin Wolf wrote: >>> But we discussed this earlier, and while I'm not completely sure any >>> more about the details, I seem to remeber that Paolo said something >>> along the l

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Fam Zheng
On Wed, 03/15 17:04, Vladimir Sementsov-Ogievskiy wrote: > 15.03.2017 16:13, Fam Zheng wrote: > > On Wed, 03/15 13:06, Kevin Wolf wrote: > > > > > Stefan, Paolo, do you remember the details why we didn't even do a > > > > > simple fix like the one below? I think there were some patches on the > > >

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 02:45:57PM +0100, Simon wrote: > Hello, > > Here is a short patch answering to Qemu wish-list issue 1217339. > > It makes Qemu to cleanly power off the guest when receiving a SIGHUP > signal, thus without requiring any monitor

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Kevin Wolf
Am 15.03.2017 um 14:39 hat Paolo Bonzini geschrieben: > On 15/03/2017 12:03, Kevin Wolf wrote: > > But we discussed this earlier, and while I'm not completely sure any > > more about the details, I seem to remeber that Paolo said something > > along the lines that AioContext is going away anyway an

Re: [Qemu-devel] [PATCH 00/31] Creating RAMState for migration

2017-03-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170315135021.6978-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH 00/31] Creating RAMState for migration === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v2 for-2.9 05/47] qapi: Have each QAPI schema declare its returns white-list

2017-03-15 Thread Eric Blake
On 03/15/2017 07:56 AM, Markus Armbruster wrote: > qapi.py has a hardcoded white-list of command names that may violate > the rules on permitted return types. Add a new pragma directive > 'returns-whitelist', and use it to replace the hard-coded white-list. > > Signed-off-by: Markus Armbruster >

[Qemu-devel] [PATCH v2] MAINTAINERS: Add myself as openrisc maintainer

2017-03-15 Thread Stafford Horne
Jia has claimed he is no longer able to maintain. I have fixing bugs here and there and getting familiar with the code base. Orignal thread from Jia: https://lists.librecores.org/pipermail/openrisc/2017-January/000321.html Signed-off-by: Stafford Horne --- Changes in v2 - fix typo Off/Odd M

[Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Simon
Hello, Here is a short patch answering to Qemu wish-list issue 1217339. It makes Qemu to cleanly power off the guest when receiving a SIGHUP signal, thus without requiring any monitor access which is currently impossible (AFAIK). The original issue

Re: [Qemu-devel] [PATCH v2 for-2.9 02/47] qapi: Make doc comments optional where we don't need them

2017-03-15 Thread Eric Blake
On 03/15/2017 07:56 AM, Markus Armbruster wrote: > Since we added the documentation generator in commit 3313b61, doc > comments are mandatory. That's a very good idea for a schema that > needs to be documented, but has proven to be annoying for testing. > > Make doc comments optional again, but a

Re: [Qemu-devel] [PULL 0/1] Fix global property and -cpu handling bug

2017-03-15 Thread Peter Maydell
On 14 March 2017 at 20:06, Eduardo Habkost wrote: > The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: > > Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) > > are available in the git repository at: > > git://github.com/ehabkost/qemu.git tags/machine

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-15 Thread Alex Bennée
Mark Cave-Ayland writes: > On 15/03/17 11:14, Alex Bennée wrote: > >> BALATON Zoltan writes: >> >>> On Tue, 14 Mar 2017, Alex Bennée wrote: So from a single-threaded -smp guest case there should be no difference in behaviour. >> However this shouldn't affect anything in the

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as openrisc maintainer

2017-03-15 Thread Stafford Horne
On Wed, Mar 15, 2017 at 02:15:27PM +, Daniel P. Berrange wrote: > On Wed, Mar 15, 2017 at 11:08:16PM +0900, Stafford Horne wrote: > > Jia has claimed he is no longer able to maintain. I have fixing bugs here > > and there and getting familiar with the code base. Orignal thread from Jia: > > >

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from Revision 1 to > 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to > make running macOS/OS X guests smoother. With a Rev1 FADT, rebooting s

Re: [Qemu-devel] [PATCH] blk: fix aio context loss on media change

2017-03-15 Thread Vladimir Sementsov-Ogievskiy
15.03.2017 16:13, Fam Zheng wrote: On Wed, 03/15 13:06, Kevin Wolf wrote: Stefan, Paolo, do you remember the details why we didn't even do a simple fix like the one below? I think there were some patches on the list, no? ISTM the concern was mostly "what about other BB in the graph?" Should th

[Qemu-devel] [PATCH] MAINTAINERS: Add myself as openrisc maintainer

2017-03-15 Thread Stafford Horne
Jia has claimed he is no longer able to maintain. I have fixing bugs here and there and getting familiar with the code base. Orignal thread from Jia: https://lists.librecores.org/pipermail/openrisc/2017-January/000321.html Signed-off-by: Stafford Horne --- MAINTAINERS | 4 ++-- 1 file changed

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-15 Thread Alex Bennée
Mark Cave-Ayland writes: > On 14/03/17 15:41, Alex Bennée wrote: > >> BALATON Zoltan writes: >> >>> On Tue, 14 Mar 2017, Mark Cave-Ayland wrote: On 14/03/17 10:00, Alex Bennée wrote: > Mark Cave-Ayland writes: > >> I've recently noticed some video artifacts appearing in the fo

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as openrisc maintainer

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 11:08:16PM +0900, Stafford Horne wrote: > Jia has claimed he is no longer able to maintain. I have fixing bugs here > and there and getting familiar with the code base. Orignal thread from Jia: > > https://lists.librecores.org/pipermail/openrisc/2017-January/000321.html >

[Qemu-devel] [PATCH 20/31] ram: move migration_dirty_pages to RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 75ad17f..606e836 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -176,6 +176,8 @@ struct RAMS

[Qemu-devel] [PATCH 27/31] ram: Move last_req_rb to RAMState

2017-03-15 Thread Juan Quintela
It was on MigrationState when it is only used inside ram.c for postcopy. Problem is that we need to access it without being able to pass it RAMState directly. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 -- migration/migration.c | 1 - migration/ram.c

[Qemu-devel] [PATCH 31/31] ram: move postcopy_requests into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 3 +-- migration/migration.c | 3 +-- migration/ram.c | 9 - 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 43bdf86..

[Qemu-devel] [PATCH 29/31] ram: Remove dirty_bytes_rate

2017-03-15 Thread Juan Quintela
It can be recalculated from dirty_pages_rate. Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 5 ++--- migration/ram.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/migration/migration.h b/include

[Qemu-devel] [PATCH 16/31] ram: Move xbzrle_pages into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 02bbe53..ce703e5 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -168,6 +168,8 @@ struct RAMState { uint64_t iterations;

[Qemu-devel] [PATCH 30/31] ram: move dirty_pages_rate to RAMState

2017-03-15 Thread Juan Quintela
Treat it like the rest of ram stats counters. Export its value the same way. As an added bonus, no more MigrationState used in migration_bitmap_sync(); Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 +- migration/migration.c | 7 +++ migration/ram.c

[Qemu-devel] [PATCH 11/31] ram: Remove unused pages_skiped variable

2017-03-15 Thread Juan Quintela
For compatibility, we need to still send a value, but just specify it and comment the fact. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 -- migration/migration.c | 3 ++- migration/ram.c | 11 --- 3 files changed, 2 insertions(+), 14 deletio

[Qemu-devel] [PATCH 23/31] ram: Move migration_bitmap_rcu into RAMState

2017-03-15 Thread Juan Quintela
Once there, rename the type to be shorter. Signed-off-by: Juan Quintela --- migration/ram.c | 79 ++--- 1 file changed, 42 insertions(+), 37 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c14293c..d39d185 100644 --- a/migrat

[Qemu-devel] [PATCH 14/31] ram: Move iterations into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 8caeb4f..234bdba 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -164,6 +164,8 @@ struct RAMState { uint64_t zero_pa

[Qemu-devel] [PATCH 25/31] ram: Use the RAMState bytes_transferred parameter

2017-03-15 Thread Juan Quintela
Somewhere it was passed by reference, just use it from RAMState. Signed-off-by: Juan Quintela --- migration/ram.c | 77 - 1 file changed, 27 insertions(+), 50 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f9933b2..9c953

Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation

2017-03-15 Thread Marc-André Lureau
Hi On Tue, Mar 14, 2017 at 8:14 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Mon, Mar 13, 2017 at 5:12 PM Markus Armbruster > wrote: > > > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Mon, Mar 13, 2017 at 4:14 PM Markus Armbruster > wrote: > >>

[Qemu-devel] [PATCH 19/31] ram: move xbzrle_overflows into RAMState

2017-03-15 Thread Juan Quintela
Once there, remove the now unused AccountingInfo struct and var. Signed-off-by: Juan Quintela --- migration/ram.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 23a7317..75ad17f 100644 --- a/migration/ram.c +++ b

[Qemu-devel] [PATCH 22/31] ram: move migration_bitmap_mutex into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 7f56b5f..c14293c 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -178,6 +178,8 @@ struct RAMState { uint64_t xbzrl

[Qemu-devel] [PATCH 28/31] ram: Create ram_dirty_sync_count()

2017-03-15 Thread Juan Quintela
This is a ram field that was inside MigrationState. Move it to RAMState and make it the same that the other ram stats. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 +- migration/migration.c | 3 +-- migration/ram.c | 6 +- 3 files changed, 7 inser

[Qemu-devel] [PATCH 24/31] ram: Move bytes_transferred into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index d39d185..f9933b2 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -191,6 +191,8 @@ struct RAMStat

[Qemu-devel] [PATCH 18/31] ram: move xbzrle_cache_miss_rate into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 8470db0..23a7317 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -172,6 +172,8 @@ struct RAMState { uint64_t xbzrle_pages

[Qemu-devel] [PATCH 21/31] ram: Everything was init to zero, so use memset

2017-03-15 Thread Juan Quintela
And then init only things that are not zero by default. Signed-off-by: Juan Quintela --- migration/ram.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 606e836..7f56b5f 100644 --- a/migration/ram.c +++ b/migr

[Qemu-devel] [PATCH 26/31] ram: Remove ram_save_remaining

2017-03-15 Thread Juan Quintela
Just unfold it. Move ram_bytes_remaining() with the rest of exported functions. Signed-off-by: Juan Quintela --- migration/ram.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9c9533d..e7db39c 100644 --- a/migrati

[Qemu-devel] [PATCH 15/31] ram: Move xbzrle_bytes into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 234bdba..02bbe53 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -166,6 +166,8 @@ struct RAMState { uint64_t norm_pages;

[Qemu-devel] [PATCH 13/31] ram: Remove norm_mig_bytes_transferred

2017-03-15 Thread Juan Quintela
Its value can be calculated by other exported. Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 3 ++- migration/ram.c | 5 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/migration/migration.h b/incl

[Qemu-devel] [PATCH 17/31] ram: Move xbzrle_cache_miss into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index ce703e5..8470db0 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -170,6 +170,8 @@ struct RAMState { uint64_t xbzrle_

[Qemu-devel] [PATCH 07/31] ram: Move xbzrle_cache_miss_prev into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b13d2d5..ae077c5 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -155,6 +155,8 @@ struct RAMState { int64_t bytes_xfer_p

[Qemu-devel] [PATCH 12/31] ram: Move norm_pages to RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 468f042..58c7dc7 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -162,6 +162,8 @@ struct RAMState {

[Qemu-devel] [PATCH 09/31] ram: Move dup_pages into RAMState

2017-03-15 Thread Juan Quintela
Once there rename it to its actual meaning, zero_pages. Signed-off-by: Juan Quintela --- migration/ram.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 6cdad06..059e9f1 100644 --- a/migration/ram.c +++ b/mi

[Qemu-devel] [PATCH 08/31] ram: Move iterations_prev into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index ae077c5..6cdad06 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -157,6 +157,8 @@ struct RAMState { int64_t num_dir

[Qemu-devel] [PATCH 05/31] ram: Move bytes_xfer_prev into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f6ac503..2d288cc 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -151,6 +151,8 @@ struct RAMState { /* this variabl

[Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState

2017-03-15 Thread Juan Quintela
last_seen_block, last_sent_block, last_offset, last_version and ram_bulk_stage are globals that are really related together. Signed-off-by: Juan Quintela --- migration/ram.c | 136 1 file changed, 79 insertions(+), 57 deletions(-) diff --

[Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/ram.c | 5 - 2 files changed, 6 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 5720c88..3e6bb68 100644 --- a/include/migration/migration.h +++ b/includ

[Qemu-devel] [PATCH 06/31] ram: Move num_dirty_pages_period into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 2d288cc..b13d2d5 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -153,6 +153,8 @@ struct RAMState { int64_t start_t

[Qemu-devel] [PATCH 02/31] ram: Add dirty_rate_high_cnt to RAMState

2017-03-15 Thread Juan Quintela
We need to add a parameter to several functions to make this work. Signed-off-by: Juan Quintela --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c20a539..9120755 100644 --- a/migration/ram.c

[Qemu-devel] [PATCH 04/31] ram: Move start time into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c0bee94..f6ac503 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -148,6 +148,9 @@ struct RAMState { int dir

[Qemu-devel] [PATCH 00/31] Creating RAMState for migration

2017-03-15 Thread Juan Quintela
Hi Currently, we have several places where we store informaticon about ram for migration pruposes: - global variables on migration/ram.c - inside the accounting_info struct in migration/ram.c notice that not all the accounting vars are inside there - some stuff is in MigrationState, althought it

[Qemu-devel] [PATCH 03/31] ram: move bitmap_sync_count into RAMState

2017-03-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9120755..c0bee94 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -45,8 +45,6 @@ #include "qemu/rcu_queue.h"

Re: [Qemu-devel] Dual userfaultfd behavior

2017-03-15 Thread Alexey Perevalov
Hi Andrea, thank you for so perfect design description, the main question who will do RFC patches, you or Mike or if you not against I could try. On 03/14/2017 12:46 AM, Andrea Arcangeli wrote: Hello, On Mon, Mar 13, 2017 at 10:53:39AM +, Dr. David Alan Gilbert wrote: * Alexey Perevalov

<    1   2   3   4   >