Re: [Qemu-devel] [PATCH 0/3] Add COLO-proxy virtio-net support

On 03/21/2017 11:39 AM, Jason Wang wrote: On 2017年03月16日 17:52, Zhang Chen wrote: If user use -device virtio-net-pci, virtio-net driver will add a header to raw net packet that colo-proxy can't handle it. COLO-proxy just focus on the packet payload, so we skip the virtio-net header to

[Qemu-devel] [PATCH] MAINTAINERS: update mail address for NVDIMM

From: Xiao Guangrong My Intel mail account will be disabled soon, update the mail info to my private mail Signed-off-by: Xiao Guangrong --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

On 17/03/17 19:33, Stefano Stabellini wrote: > On Fri, 17 Mar 2017, Juergen Gross wrote: >> On 16/03/17 21:20, Stefano Stabellini wrote: >>> On Thu, 16 Mar 2017, Juergen Gross wrote: Instead of trying to guess the Xen version to use by compiling various test programs first just ask the

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

On Fri, 03/17 09:55, Ed Swierk wrote: > I'm running into the same problem taking an external snapshot with a > virtio-blk drive with iothread, so it's not specific to virtio-scsi. > Run a Linux guest on qemu master > > qemu-system-x86_64 -nographic -enable-kvm -monitor >

Re: [Qemu-devel] [Bug 1673722] [NEW] Reading register at offset. It is not fully implemented warning make VM impossible to use

On 2017年03月20日 22:58, Peter Maydell wrote: On 20 March 2017 at 14:20, Stefan Hajnoczi wrote: On Fri, Mar 17, 2017 at 09:47:14AM -, Julien Duponchelle wrote: Hi, Since this commit: https://github.com/qemu/qemu/commit/bc0f0674f037a01f2ce0870ad6270a356a7a8347 We can

Re: [Qemu-devel] [PATCH] vfio pci: kernel support of error recovery only for non fatal error

On Mon, 20 Mar 2017 16:32:33 +0200 "Michael S. Tsirkin" wrote: > On Mon, Mar 20, 2017 at 08:50:39PM +0800, Cao jin wrote: > > Sorry for late. > > > > On 03/14/2017 06:06 AM, Alex Williamson wrote: > > > On Mon, 27 Feb 2017 15:28:43 +0800 > > > Cao jin

Re: [Qemu-devel] [PATCH 2/2] qapi: Fix QemuOpts visitor regression on unvisited input

Quoting Eric Blake (2017-03-20 22:17:05) > An off-by-one in commit 15c2f669e meant that we were failing to > check for unparsed input in all QemuOpts visitors. Recent testsuite > additions show that fixing the obvious bug with bogus fields will > also fix the case of an incomplete list visit;

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

Quoting Eric Blake (2017-03-20 22:17:04) > Commit 15c2f669e broke the ability of the QemuOpts visitor to > flag extra input parameters, but the regression went unnoticed > because of missing testsuite coverage. Add a test to cover this. > > Signed-off-by: Eric Blake

[Qemu-devel] [Bug 618533] Re: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm-9999 (GIT)

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/618533 Title: OpenSolaris

[Qemu-devel] [Bug 665743] Re: Cocoa video corruption when guest uses RGB565 mode

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/665743 Title: Cocoa video

Re: [Qemu-devel] [PATCH 0/3] Add COLO-proxy virtio-net support

On 2017年03月16日 17:52, Zhang Chen wrote: If user use -device virtio-net-pci, virtio-net driver will add a header to raw net packet that colo-proxy can't handle it. COLO-proxy just focus on the packet payload, so we skip the virtio-net header to compare the sent packet that primary guest's to

Re: [Qemu-devel] [BUG/RFC] INIT IPI lost when VM starts

Let me clarify it more clearly. Time sequence is that qemu handles ‘query-cpus’ qmp command, vcpu 1 (and vcpu 0) got registers from kvm-kmod (qmp_query_cpus-> cpu_synchronize_state-> kvm_cpu_synchronize_state-> > do_kvm_cpu_synchronize_state-> kvm_arch_get_registers), then vcpu 0 (BSP) sends

[Qemu-devel] [PATCH RFC 15/16] mirror: Lazily request aio context change permission on target

What's done in the source's context change notifier is moving the target's context to follow the new one, so we request this permission here. Signed-off-by: Fam Zheng --- block/mirror.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/mirror.c b/block/mirror.c index

[Qemu-devel] [PATCH RFC 14/16] block: Add perm assertion on blk_set_aio_context

Now that all BB users comply with the BLK_PERM_AIO_CONTEXT_CHANGE rule, we can assert it. Signed-off-by: Fam Zheng --- block/block-backend.c | 4 1 file changed, 4 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ec8747f..8284b83 100644 ---

[Qemu-devel] [PATCH RFC 13/16] nbd: Allow BLK_PERM_AIO_CONTEXT_CHANGE on BB

This is safe because of the aio context notifier we'll register on this node. So allow it. Signed-off-by: Fam Zheng --- nbd/server.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 924a1fe..a8f58fb 100644 ---

[Qemu-devel] [PATCH RFC 09/16] mirror: Do initial aio context move of target via BB interface

While blockdev-backup tried to verify before moving target's aio context, the same is missing for blockdev-mirror. Now that we have the right interface, fix this as well. As a bounus, the aio context move is now conditional, which avoids unnecessary operations in bdrv_set_aio_context.

[Qemu-devel] [PATCH RFC 16/16] Revert "mirror: Request aio context change permission on target"

This reverts commit bee8490438adfb30785cd5256019e8cba9fb3a07. Signed-off-by: Fam Zheng --- block/mirror.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 168cf60..240da19 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1187,7

[Qemu-devel] [PATCH RFC 10/16] virtio-scsi: Request BLK_PERM_AIO_CONTEXT_CHANGE for dataplane

blk_set_aio_context is audited by perm API, so follow the protocol and request for permission first. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 1dbc4bc..6a48356

[Qemu-devel] [PATCH RFC 12/16] blk: fix aio context loss on media change

From: Vladimir Sementsov-Ogievskiy If we have separate iothread for cdrom, we lose connection to it on qmp_blockdev_change_medium, as aio_context is on bds which is dropped and switched with new one. As an example result, after such media change we have crash on

[Qemu-devel] [PATCH RFC 04/16] block: Propagate BLK_PERM_AIO_CONTEXT_CHANGE down the graph

bdrv_set_aio_context can take care of children recursively, so it is okay to pass down the perm. Signed-off-by: Fam Zheng --- block.c | 18 ++ block/vvfat.c | 2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH RFC 08/16] commit: Allow aio context change on s->base

The block job has the aio context change notifier, we should allow it here as well. Signed-off-by: Fam Zheng --- block/commit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/commit.c b/block/commit.c index 2832482..a1805c2 100644 ---

[Qemu-devel] [PATCH RFC 11/16] virtio-blk: Request BLK_PERM_AIO_CONTEXT_CHANGE for dataplane

blk_set_aio_context is audited by perm API, so follow the protocol and request for permission first. Previously the return code in error path is hardcoded as -EPERM, but returning 'r' is more meaningful here both for the new error and existing errors. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH RFC 07/16] mirror: Request aio context change permission on target

What's done in the source's context change notifier is moving the target's context to follow the new one, so we request this permission here. Signed-off-by: Fam Zheng --- block/mirror.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/mirror.c b/block/mirror.c index

[Qemu-devel] [PATCH RFC 03/16] blockjob: Add BLK_PERM_AIO_CONTEXT_CHANGE shared perm on bs

Signed-off-by: Fam Zheng --- blockjob.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockjob.c b/blockjob.c index 69126af..3fd84b7 100644 --- a/blockjob.c +++ b/blockjob.c @@ -197,6 +197,9 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver,

[Qemu-devel] [PATCH RFC 06/16] backup: Do initial aio context move of target via BB interface

The old aio context check is hacky because when it was added we didn't have the permission system to enforce a general rule. It only checks if the target BDS has a BB, which is in fact insufficient because there may be other BBs in the graph that cannot handle the aio context change. Do this

[Qemu-devel] [PATCH RFC 05/16] backup: Request BLK_PERM_AIO_CONTEXT_CHANGE on target

What's done in the source's context change notifier is moving the target's context to follow the new one, so we request this permission here. Signed-off-by: Fam Zheng --- block/backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c

[Qemu-devel] [PATCH 2/2] qapi: Fix QemuOpts visitor regression on unvisited input

An off-by-one in commit 15c2f669e meant that we were failing to check for unparsed input in all QemuOpts visitors. Recent testsuite additions show that fixing the obvious bug with bogus fields will also fix the case of an incomplete list visit; update the tests to match the new behavior. Simple

[Qemu-devel] [PATCH for-2.9 0/2] Fix QemuOpts regression on bogus keys

Reported to me off-list by Laurent Vivier, who found the problem while working on https://bugzilla.redhat.com/1433193 Broken since 2.7, but the fix is a one-liner (pointing out my embarrassing mistake of mis-converting a pre-decrement operator); as a bug fix, it still qualifies for 2.9 in spite of

[Qemu-devel] [PATCH RFC 02/16] block-backend: Add blk_request_perm

This function tries to request, if not granted yet, for the given permissions. Signed-off-by: Fam Zheng --- block/block-backend.c | 12 include/sysemu/block-backend.h | 1 + 2 files changed, 13 insertions(+) diff --git a/block/block-backend.c

[Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this. Signed-off-by: Eric Blake --- tests/test-opts-visitor.c | 20 1

[Qemu-devel] [PATCH RFC 00/16] block: Protect AIO context change with perm API

Eject / change of scsi-cd on a virtio-scsi dataplane bus causes abort() because the new BDS doesn't get proper bdrv_set_aio_context(). Store the AioContext in BB and do it in blk_insert_bs. That is done by Vladimir's patch. Other patches are to make sure such a bdrv_set_aio_context() doesn't

[Qemu-devel] [PATCH RFC 01/16] block: Define BLK_PERM_AIO_CONTEXT_CHANGE

Signed-off-by: Fam Zheng --- block.c | 2 ++ include/block/block.h | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 6e906ec..ae9327b 100644 --- a/block.c +++ b/block.c @@ -1547,6 +1547,8 @@ static char

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

On 03/21/2017 11:05 AM, Eric Blake wrote: On 03/20/2017 07:26 PM, wangguang wrote: Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: -- View this message in context:

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

On 03/20/2017 07:26 PM, wangguang wrote: > Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error > in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: > -- > View this message in context: http://qemu.11.n7.nabble.com/ Nabble may be a fine platform

Re: [Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

Hi~~ Wang. This is a doc typo, but I found we forgot to update command in this doc, Recently COLO use this command: {'execute': 'nbd-server-add', 'arguments': {'device': 'colo-disk0', 'writable': true } } You can see it in http://wiki.qemu-project.org/Features/COLO. So I think this patch is

Re: [Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

On 03/20/2017 09:49 PM, wangguang wrote: > This is an error in COLO-FT.txt. > secondeary-disk0 should be secondary-disk0. > > Signed-off-by: Guang Wang This is now version 6 of a patch, but failed to include that information in the subject line. 'git send-email -v6'

[Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..bec7547 100644 ---

[Qemu-devel] [PATCH v2] Add page-size to output in 'info migrate'

The number of dirty pages outputed in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian --- v2: fix the grammar in qapi-schema.json [Eric

Re: [Qemu-devel] [PATCH v5]COLO:Fix spell error in Colo doc

On 03/20/2017 08:39 PM, wangguang wrote: > Subject: [PATCH]COLO:Fix spell error in Colo doc I added qemu-trivial in v4; you should keep it in the loop. Still missing a space after ':' in the subject line, and still the awkward duplication of the subject line in the body of the commit message. >

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

On Fri, Mar 17, 2017 at 12:27 PM, Paolo Bonzini wrote: > And this is a fix, but I have no idea why/how it works and what else it > may break. > > Patches 1 and 2 are pretty obvious and would be the first step towards > eliminating aio_disable/enable_external altogether. > >

Re: [Qemu-devel] [PATCH v2] numa, spapr: align default numa node memory size to 256MB

On Mon, Mar 20, 2017 at 04:11:14PM -0300, Eduardo Habkost wrote: > On Mon, Mar 20, 2017 at 03:12:44PM +0100, Laurent Vivier wrote: > > Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node > > memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). > > > > But when "-numa"

Re: [Qemu-devel] [PATCH fixup 2/2] vhost: genearlize iommu memory region

On Mon, Mar 20, 2017 at 08:21:44PM -0500, Eric Blake wrote: > On 03/20/2017 08:12 PM, Michael S. Tsirkin wrote: > > >> > >> Since this patchset depends on vtd vfio series and fixes its breakage > >> to vhost, I'll pick them up for consistency for next post of vtd vfio > >> series as well. > >> >

[Qemu-devel] [PATCH v5]COLO:Fix spell error in Colo doc

Subject: [PATCH]COLO:Fix spell error in Colo doc This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt

Re: [Qemu-devel] [PATCH 00/81] Patch Round-up for stable 2.8.1, freeze on 2017-03-27

On 03/21/2017 09:07 AM, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v2.8.1: https://github.com/mdroth/qemu/commits/stable-2.8-staging The release is planned for 2017-03-30: http://wiki.qemu.org/Planning/2.8 Please respond here or CC

Re: [Qemu-devel] [PATCH fixup 2/2] vhost: genearlize iommu memory region

On 03/20/2017 08:12 PM, Michael S. Tsirkin wrote: >> >> Since this patchset depends on vtd vfio series and fixes its breakage >> to vhost, I'll pick them up for consistency for next post of vtd vfio >> series as well. >> >> Thanks, >> >> -- peterx > > Sounds good. It's best to order patches in a

Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

On 2017年03月20日 19:38, Paolo Bonzini wrote: > Fair enough, though I'd be worried about increasing the attack surface > of the hypervisor. For KVM, for example, IOMMU emulation requires using > the "split irqchip" feature to move the PIC and IOAPIC out of the kernel > and back to QEMU. Yes, just

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: > This patchset enables qmp interfaces for the 9pfs > devices (fsdev).This provides two interfaces one Space between English sentences, after '.' > for querying all the 9pfs devices info. The second one > to set the IO limits for the required

Re: [Qemu-devel] [PATCH fixup 2/2] vhost: genearlize iommu memory region

On Mon, Mar 20, 2017 at 05:07:34PM +0800, Peter Xu wrote: > On Mon, Mar 20, 2017 at 11:36:39AM +0800, Jason Wang wrote: > > We assumes the iommu_ops were attached to the root region of address > > space. This may not true for all kinds of IOMMU implementation. So fix > > this by not assume

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[adding qemu-trivial] On 03/20/2017 07:27 PM, wangguang wrote: > Subject: [PATCH] Fix Colo doc secondeary should be secondary This line feels redundant compared to the overall mail's subject line. In turn, that subject could use a space after colon. > This is an error in COLO-FT.txt. >

Re: [Qemu-devel] [PATCH 00/81] Patch Round-up for stable 2.8.1, freeze on 2017-03-27

On 03/20/2017 06:07 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.8.1: > > https://github.com/mdroth/qemu/commits/stable-2.8-staging > > The release is planned for 2017-03-30: > > http://wiki.qemu.org/Planning/2.8 > > Please respond

Re: [Qemu-devel] [RFC PATCH 1/4] I440: Allow adding sysbus devices with -device on I440

Hi Eduardo: Thanks for your review. On 2017年03月21日 03:49, Eduardo Habkost wrote: > On Fri, Mar 17, 2017 at 07:29:14PM +0800, Lan Tianyu wrote: >> From: Chao Gao >> >> xen-viommu will be a sysbus device and the device model will >> be enabled via "-device" parameter. >>

[Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt

Re: [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device

Thanks Laszlo! > On Mar 20, 2017, at 10:05 AM, Laszlo Ersek wrote: > > A system with multiple VMGENID devices is undefined in the VMGENID spec by > omission. > > Cc: "Michael S. Tsirkin" > Cc: Ben Warren > Cc: Igor Mammedov

[Qemu-devel] [Bug 877498] Re: qemu does not pass sector size from physical devices to virtual devices

QEMU 0.12 is pretty much outdated ... can you still reproduce this issue with the latest version of QEMU, or can we close this bug nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [PATCH 07/81] 9pfs: local: lgetxattr: don't follow symlinks

From: Greg Kurz The local_lgetxattr() callback is vulnerable to symlink attacks because it calls lgetxattr() which follows symbolic links in all path elements but the rightmost one. This patch introduces a helper to emulate the non-existing fgetxattrat() function: it is

[Qemu-devel] [PATCH 74/81] NetRxPkt: Fix memory corruption on VLAN header stripping

From: Dmitry Fleytman This patch fixed a problem that was introduced in commit eb700029. When net_rx_pkt_attach_iovec() calls eth_strip_vlan() this can result in pkt->ehdr_buf being overflowed, because ehdr_buf is only sizeof(struct eth_header) bytes large but

[Qemu-devel] [PATCH 78/81] scsi: mptsas: fix the wrong reading size in fetch request

From: Li Qiang When fetching request, it should read sizeof(*hdr), not the pointer hdr. Signed-off-by: Li Qiang Message-Id: <1489488980-130668-1-git-send-email-liqiang...@360.cn> Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 08/81] 9pfs: local: llistxattr: don't follow symlinks

From: Greg Kurz The local_llistxattr() callback is vulnerable to symlink attacks because it calls llistxattr() which follows symbolic links in all path elements but the rightmost one. This patch introduces a helper to emulate the non-existing flistxattrat() function: it is

[Qemu-devel] [PATCH 81/81] thread-pool: add missing qemu_bh_cancel in completion function

From: Peter Lieven commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. However, the rescheduling of the completion BH introcuded unnecessary spinning in the main-loop. On very fast file backends this can even lead to the "WARNING: I/O thread spun for 1000

[Qemu-devel] [PATCH 71/81] hmp: fix block_set_io_throttle

From: Eric Blake Commit 7a9877a made the 'device' parameter to BlockIOThrottle optional, favoring 'id' instead. But it forgot to update the HMP usage to set has_device, which makes all attempts to change throttling via HMP fail with "Need exactly one of 'device' and 'id'"

[Qemu-devel] [PATCH 79/81] virtio-pci: reset modern vq meta data

From: Jason Wang We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if a driver enable the vq without setting vq address after reset. The old addresses were leaked. Fixing this by resetting modern vq meta data during device reset. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH 06/81] 9pfs: local: open/opendir: don't follow symlinks

From: Greg Kurz The local_open() and local_opendir() callbacks are vulnerable to symlink attacks because they call: (1) open(O_NOFOLLOW) which follows symbolic links in all path elements but the rightmost one (2) opendir() which follows symbolic links in all path elements

[Qemu-devel] [PATCH 70/81] qga: ignore EBUSY when freezing a filesystem

From: Peter Lieven the current implementation fails if we try to freeze an already frozen filesystem. This can happen if a filesystem is mounted more than once (e.g. with a bind mount). Suggested-by: Christian Theune Cc: qemu-sta...@nongnu.org Signed-off-by:

[Qemu-devel] [PATCH 69/81] target-i386: correctly propagate retaddr into SVM helpers

From: Paolo Bonzini Commit 2afbdf8 ("target-i386: exception handling for memory helpers", 2015-09-15) changed tlb_fill's cpu_restore_state+raise_exception_err to raise_exception_err_ra. After this change, the cpu_restore_state and raise_exception_err's cpu_loop_exit are

[Qemu-devel] [PATCH 80/81] s390x/css: reassign subchannel if schid is changed after migration

From: Dong Jia Shi The subchannel is a means to access a device. While the device number is assigned by the administrator, the subchannel number is assigned by the channel subsystem in an ascending order on cold and hot plug. When doing unplug and replug operations,

Re: [Qemu-devel] [PATCH 1/2] acpi_piix4: fix migration of gpe fields

On Mon, Mar 20, 2017 at 01:02:10PM +0100, Philipp Hahn wrote: > Hello Marcelo, cc:qemu, > > Sorry for re-using this old thread, but I have a problem loading some > saved state from qemu-kvm-1.1.2, which fails for piix4_pm. > > You following patch was committed as >

[Qemu-devel] [PATCH 73/81] eth: Extend vlan stripping functions

From: Dmitry Fleytman Make VLAN stripping functions return number of bytes copied to given Ethernet header buffer. This information should be used to re-compose packet IOV after VLAN stripping. Cc: qemu-sta...@nongnu.org Signed-off-by: Dmitry Fleytman

[Qemu-devel] [PATCH 77/81] e1000e: correctly tear down MSI-X memory regions

From: Paolo Bonzini MSI-X has been disabled by the time the e1000e device is unrealized, hence msix_uninit is never called. This causes the object to be leaked, which shows up as a RAMBlock with empty name when attempting migration. Reported-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 75/81] NetRxPkt: Do not try to pull more data than present

From: Dmitry Fleytman In case of VLAN stripping, ETH header put into a separate buffer, therefore amont of data copied from original IOV should be smaller. Cc: qemu-sta...@nongnu.org Signed-off-by: Dmitry Fleytman Signed-off-by: Jason Wang

[Qemu-devel] [Bug 888150] Re: qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

The URL that you've mentioned in the description is not valid anymore ... can you still reproduce this problem with the latest version of QEMU, or can we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a

[Qemu-devel] [PATCH 64/81] vnc: do not disconnect on EAGAIN

From: Michael Tokarev When qemu vnc server is trying to send large update to clients, there might be a situation when system responds with something like EAGAIN, indicating that there's no system memory to send that much data (depending on the network speed, client and server

[Qemu-devel] [PATCH 72/81] cirrus: add blit_is_unsafe call to cirrus_bitblt_cputovideo (CVE-2017-2620)

From: Gerd Hoffmann CIRRUS_BLTMODE_MEMSYSSRC blits do NOT check blit destination and blit width, at all. Oops. Fix it. Security impact: high. The missing blit destination check allows to write to host memory. Basically same as CVE-2014-8106 for the other blit variants.

[Qemu-devel] [PATCH 65/81] target-ppc, tcg: fix usermode segfault with pthread_create()

From: Sam Bobroff Programs run under qemu-ppc64 on an x86_64 host currently segfault if they use pthread_create() due to the adjustment made to the NIP in commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9. This patch changes cpu_loop() to set the NIP back to the

[Qemu-devel] [PATCH 59/81] target/s390x: use "qemu" cpu model in user mode

From: David Hildenbrand "any" does not exist, therefore resulting in a misleading error message. Reported-by: Stefan Weil Signed-off-by: David Hildenbrand Message-Id: <20170130145025.26475-1-da...@redhat.com> Reviewed-by: Stefan Weil

[Qemu-devel] [PATCH 66/81] block/vmdk: Fix the endian problem of buf_len and lba

From: QingFeng Hao The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But

[Qemu-devel] [PATCH 76/81] NetRxPkt: Account buffer with ETH header in IOV length

From: Dmitry Fleytman In case of VLAN stripping ETH header is stored in a separate chunk and length of IOV should take this into account. This patch fixes checksum validation for RX packets with VLAN header. Devices affected by this problem: e1000e and vmxnet3. Cc:

[Qemu-devel] [PATCH 57/81] cpu-exec: fix icount out-of-bounds access

From: Paolo Bonzini When icount is active, tb_add_jump is surprisingly called with an out of bounds basic block index. I have no idea how that can work, but it does not seem like a good idea. Clear *last_tb for all TB_EXIT_ICOUNT_EXPIRED cases, even when all you have to do

[Qemu-devel] [PATCH 54/81] block/iscsi: avoid data corruption with cache=writeback

From: Peter Lieven nb_cls_shrunk in iscsi_allocmap_update can become -1 if the request starts and ends within the same cluster. This results in passing -1 to bitmap_set and bitmap_clear and they don't handle negative values properly. In the end this leads to data corruption.

[Qemu-devel] [PATCH 63/81] sd: sdhci: check data length during dma_memory_read

From: Prasad J Pandit While doing multi block SDMA transfer in routine 'sdhci_sdma_transfer_multi_blocks', the 's->fifo_buffer' starting index 'begin' and data length 's->data_count' could end up to be same. This could lead to an OOB access issue. Correct transfer data

[Qemu-devel] [PATCH 52/81] ui: use evdev keymap when running under wayland

From: "Daniel P. Berrange" Wayland always uses evdev as its input source, so QEMU can use the existing evdev keymap data Signed-off-by: Daniel P. Berrange Tested-by: Stefan Hajnoczi Message-id:

[Qemu-devel] [PATCH 45/81] virtio-crypto: fix possible integer and heap overflow

From: Gonglei Because the 'size_t' type is 4 bytes in 32-bit platform, which is the same with 'int'. It's easy to make 'max_len' to zero when integer overflow and then cause heap overflow if 'max_len' is zero. Using uint_64 instead of size_t to avoid the integer

[Qemu-devel] [PATCH 05/81] 9pfs: local: keep a file descriptor on the shared folder

From: Greg Kurz This patch opens the shared folder and caches the file descriptor, so that it can be used to do symlink-safe path walk. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi (cherry picked from commit

[Qemu-devel] [PATCH 67/81] target/sparc: Restore ldstub of odd asis

From: Richard Henderson Fixes the booting of ss20 roms. Cc: qemu-sta...@nongnu.org Reported-by: Michael Russo Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson (cherry picked from commit

[Qemu-devel] [PATCH 51/81] tcg/aarch64: Fix tcg_out_movi

From: Richard Henderson There were some patterns, like 0x___00ff, for which we would select to begin a multi-insn sequence with MOVN, but would fail to set the 0x lane back from 0x. Signed-off-by: Richard Henderson Message-Id:

[Qemu-devel] [PATCH 68/81] apic: reset apic_delivered global variable on machine reset

From: Pavel Dovgalyuk This patch adds call to apic_reset_irq_delivered when the virtual machine is reset. Signed-off-by: Pavel Dovgalyuk Message-Id: <20170131114054.276.62201.stgit@PASHA-ISP> Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo

[Qemu-devel] [PATCH 58/81] ahci: advertise HOST_CAP_64

From: Ladi Prosek The AHCI emulation code supports 64-bit addressing and should advertise this fact in the Host Capabilities register. Both Linux and Windows drivers test this bit to decide if the upper 32 bits of various registers may be written to, and at least some

[Qemu-devel] [PATCH 39/81] 9pfs: fix crash when fsdev is missing

From: Greg Kurz If the user passes -device virtio-9p without the corresponding -fsdev, QEMU dereferences a NULL pointer and crashes. This is a 2.8 regression introduced by commit 702dbcc274e2c. Signed-off-by: Greg Kurz Reviewed-by: Li Qiang

[Qemu-devel] [PATCH 62/81] block/nfs: fix naming of runtime opts

From: Peter Lieven commit 94d6a7a accidentally left the naming of runtime opts and QAPI scheme inconsistent. As one consequence passing of parameters in the URI is broken. Sync the naming of the runtime opts to the QAPI scheme. Please note that this is technically backwards

[Qemu-devel] [PATCH 49/81] char: fix ctrl-a b not working

From: Marc-André Lureau CharDriverState.be should be updated to point to the current associated backend. Fix the regression introduced in the "mux" chardev from commit a4afa548fc6dd9842ed86639b4d37d4d1c4ad480. https://bugs.launchpad.net/bugs/1654137 Signed-off-by:

[Qemu-devel] [PATCH 61/81] block/nfs: fix NULL pointer dereference in URI parsing

From: Peter Lieven parse_uint_full wants to put the parsed value into the variable passed via its second argument which is NULL. Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Eric Blake

[Qemu-devel] [PATCH 60/81] s390x/kvm: fix small race reboot vs. cmma

From: Christian Borntraeger Right now we reset all devices before we reset the cmma states. This can result in the host kernel discarding guest pages that were previously in the unused state but already contain a bios or a -kernel file before the cmma reset has finished.

[Qemu-devel] [PATCH 31/81] 9pfs: fail local_statfs() earlier

From: Greg Kurz If we cannot open the given path, we can return right away instead of passing -1 to fstatfs() and close(). This will make Coverity happy. (Coverity issue CID1371729) Signed-off-by: Greg Kurz Reviewed-by: Daniel P. berrange

[Qemu-devel] [PATCH 48/81] x86: ioapic: fix fail migration when irqchip=split

From: Peter Xu Split irqchip works based on the fact that we kept the first 24 gsi routing entries inside KVM for userspace ioapic's use. When system boot, we'll reserve these MSI routing entries before hand. However, after migration, we forgot to re-configure it up in the

[Qemu-devel] [PATCH 53/81] virtio: fix up max size checks

From: "Michael S. Tsirkin" Coverity reports that ARRAY_SIZE(elem->out_sg) (and all the others too) is wrong because elem->out_sg is a pointer. However, the check is not in the right place and the max_size argument of virtqueue_map_iovec can be removed. The check on

[Qemu-devel] [PATCH 02/81] 9pfs: remove side-effects in local_init()

From: Greg Kurz If this function fails, it should not modify *ctx. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi (cherry picked from commit 00c90bd1c2ff6aabb9ca948a254ba044a403e399) Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH 03/81] 9pfs: remove side-effects in local_open() and local_opendir()

From: Greg Kurz If these functions fail, they should not change *fs. Let's use local variables to fix this. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi (cherry picked from commit 21328e1e57f526e3f0c2fcd00f10c8aa6e7bc07f)

[Qemu-devel] [PATCH 28/81] 9pfs: local: drop unused code

From: Greg Kurz Now that the all callbacks have been converted to use "at" syscalls, we can drop this code. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi (cherry picked from commit c23d5f1d5bc0e23aeb845b1af8f996f16783ce98)

[Qemu-devel] [PATCH 44/81] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create()

From: Caoxinhua QEMU will crash with the follow backtrace if the new created thread exited before we call qemu_thread_set_name() for it. (gdb) bt #0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1

[Qemu-devel] [PATCH 38/81] virtio: fix vq->inuse recalc after migr

From: Halil Pasic Correct recalculation of vq->inuse after migration for the corner case where the avail_idx has already wrapped but used_idx not yet. Also change the type of the VirtQueue.inuse to unsigned int. This is done to be consistent with other members

  1   2   3   4   >