Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of checkpoint

On 2017年02月22日 17:31, Zhang Chen wrote: On 02/22/2017 11:42 AM, zhanghailiang wrote: While do checkpoint, we need to flush all the unhandled packets, By using the filter notifier mechanism, we can easily to notify every compare object to do this process, which runs inside of compare threads

Re: [Qemu-devel] [PATCH v1 2/3] cpus: dump TLB flush counts as trace event

On 11/04/2017 18:50, Alex Bennée wrote: > This can be pre-processed later from the trace file. What about skipping this patch, and instead adding five trace points trace_tlb_flush_self(int vcpu) trace_tlb_flush_async_schedule(int from, int to) trace_tlb_flush_async_work(int vcpu)

Re: [Qemu-devel] [PATCH 09/10] target/i386: optimize indirect branches with TCG's jr op

> Any other instructions I should look into? Perhaps lret/lret im? Possibly (for completeness), but they are extremely rare in 32- and 64-bit code. You also didn't cover any of syscall/sysret and sysenter/sysexit in your patch, which would be on a relatively slow path but not _that_ slow. But

Re: [Qemu-devel] [PATCH 0/5] mc146818rtc: fix Windows VM clock faster

On 13/04/2017 16:52, Xiao Guangrong wrote: > On 04/13/2017 04:39 PM, Xiao Guangrong wrote: >> On 04/13/2017 02:37 PM, Paolo Bonzini wrote: >>> However, I think that the above should be exactly how the RTC should >>> work. The original RTC circuit had 22 divider stages (see page 13 of >>> the

[Qemu-devel] [PATCH] char: Fix removing wrong GSource that be found by fd_in_tag

We use fd_in_tag to find a GSource, fd_in_tag is return value of g_source_attach(GSource *source, GMainContext *context), the return value is unique only in the same context, so we may get the same values with different 'context' parameters. It is no problem to find the right fd_in_tag by using

Re: [Qemu-devel] [PATCH v9 3/5] mm: function to offer a page block on the free list

On Fri, Apr 14, 2017 at 10:30:27AM +0800, Wei Wang wrote: > OK. What do you think if we add this: > > #if defined(CONFIG_VIRTIO_BALLOON) || defined(CONFIG_VIRTIO_BALLOON_MODULE) That's spelled "IS_ENABLED(CONFIG_VIRTIO_BALLOON)", FYI.

Re: [Qemu-devel] [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

On Fri, Apr 14, 2017 at 10:28:32AM +0800, Wei Wang wrote: > On 04/14/2017 09:50 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 01:44:11PM -0700, Matthew Wilcox wrote: > > > On Thu, Apr 13, 2017 at 05:35:03PM +0800, Wei Wang wrote: > > > > 2) transfer the guest unused pages to the host

Re: [Qemu-devel] ARM virt machine boots fail with 14 ioh3420

Hi Laszlo, Thanks a lot for your reply:) On 2017/4/14 1:09, Laszlo Ersek wrote: > Adding Andrea, Ard, Drew and Marcel; and the main qemu list > > On 04/13/17 09:37, Shannon Zhao wrote: >> Hi, >> >> I'm testing the PCIe devices hotplug for ARM virt machine and using >> ioh3420 as root port. I

Re: [Qemu-devel] vmbus bridge: machine property or device?

On Thu, Apr 13, 2017 at 01:44:57PM -0300, Eduardo Habkost wrote: > On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: > > Can you (or anybody else) please help me decide if I need > > TYPE_SYS_BUS_DEVICE? Logically the VMBus bridge is "attached directly > > to the main system bus" as

Re: [Qemu-devel] [PATCH v9 3/5] mm: function to offer a page block on the free list

On 04/14/2017 04:02 AM, Andrew Morton wrote: On Thu, 13 Apr 2017 17:35:06 +0800 Wei Wang wrote: Add a function to find a page block on the free list specified by the caller. Pages from the page block may be used immediately after the function returns. The caller is

Re: [Qemu-devel] [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

On 04/14/2017 09:50 AM, Michael S. Tsirkin wrote: On Thu, Apr 13, 2017 at 01:44:11PM -0700, Matthew Wilcox wrote: On Thu, Apr 13, 2017 at 05:35:03PM +0800, Wei Wang wrote: 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. I don't

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/3] block: Backdoor to skip image locking in qemu-io/qemu-img

On Thu, 04/13 21:14, John Snow wrote: > > > On 03/13/2017 10:39 PM, Fam Zheng wrote: > > Hi Kevin, > > > > This tries to capture your idea to add a explicit command option in qemu-io > > and > > qemu-img for user to specify "expect inconsistent data when reading image". > > It's stored as a

Re: [Qemu-devel] [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

On Thu, Apr 13, 2017 at 01:44:11PM -0700, Matthew Wilcox wrote: > On Thu, Apr 13, 2017 at 05:35:03PM +0800, Wei Wang wrote: > > 2) transfer the guest unused pages to the host so that they > > can be skipped to migrate in live migration. > > I don't understand this second bit. You leave the pages

Re: [Qemu-devel] vmbus bridge: machine property or device?

On Thu, Apr 13, 2017 at 05:58:51PM +0100, Peter Maydell wrote: > On 13 April 2017 at 17:44, Eduardo Habkost wrote: > > On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: > >> Can you (or anybody else) please help me decide if I need > >> TYPE_SYS_BUS_DEVICE?

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/3] block: Backdoor to skip image locking in qemu-io/qemu-img

On 03/13/2017 10:39 PM, Fam Zheng wrote: > Hi Kevin, > > This tries to capture your idea to add a explicit command option in qemu-io > and > qemu-img for user to specify "expect inconsistent data when reading image". > It's stored as a BDRV_O_ flag internally, I don't know if there is a

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] Revert "block/io: Comment out permission assertions"

On 04/13/2017 10:34 AM, Max Reitz wrote: > On 13.04.2017 15:28, Stefan Hajnoczi wrote: >> On Tue, Apr 11, 2017 at 05:52:26PM +0200, Max Reitz wrote: >>> This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74. >>> >>> This commit was necessary for the 2.9 release because we were unable to

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 06:19 AM, Denis V. Lunev wrote: > On 04/13/2017 12:44 PM, Kevin Wolf wrote: >> Am 12.04.2017 um 21:02 hat Denis V. Lunev geschrieben: >>> On 04/12/2017 09:20 PM, Eric Blake wrote: On 04/12/2017 12:55 PM, Denis V. Lunev wrote: > Let me rephrase a bit. > > The

Re: [Qemu-devel] [PATCH v6] migration/block: use blk_pwrite_zeroes for each zero cluster

On Thu, Apr 13, 2017 at 10:16 PM, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 10:34:28AM +0800, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, >> this may cause the qcow2

Re: [Qemu-devel] [Xen-devel][PATCH] configure: introduce --enable-xen-fb-backend

On Tue, 11 Apr 2017, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > For some use cases when Xen framebuffer/input backend > is not a part of Qemu it is required to disable it, > because of conflicting access to input/display devices. >

[Qemu-devel] [Bug 1682681] [NEW] qemu 2.5 network model rtl8139 collisions Ubuntu 16.04.2 LTS

Public bug reported: When I use NIC model rtl8139, I have a lot collisions and very low transfer. I tested that with brctl and Open vSwitch, because I thought that was a vSwitch issue. When I change NIC model to virtio all works as expect. Host: Ubuntu 16.04.2 LTS Guest: Ubuntu 14.04.5 LTS -

Re: [Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

On 04/12/2017 03:51 AM, Michał Kępień wrote: > $ tail -20 qemu.log > > == ide_cancel_dma_sync == > > ATA Registers: > cmd 0x06 > feature 0x01 > error 0x00 > nsector 0x0001 > sector0x00 > lcyl 0x00 > hcyl 0x00 >

Re: [Qemu-devel] [PATCH v4 1/1] qga: Add 'guest-get-users' command

Quoting Vinzenz 'evilissimo' Feenstra (2017-04-13 05:41:17) > From: Vinzenz Feenstra > > A command that will list all currently logged in users, and the time > since when they are logged in. > > Examples: > > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users"

Re: [Qemu-devel] vmbus bridge: machine property or device?

On 13 April 2017 at 19:15, Eduardo Habkost wrote: > I can't say it's a good idea, but it looks like there are devices > that do that (probably they are machine-specific, so they know > which machine they are being connected to?). > > I looked for realize functions that call

[Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

Hello- I posted this question on stack overflow and got no response. Stefan recommended asking the question here. I’ve included a summary of the problem here in this email but more details can be found here:

Re: [Qemu-devel] [PATCH v4 1/1] qga: Add 'guest-get-users' command

Quoting Michael Roth (2017-04-13 15:30:06) > Quoting Vinzenz 'evilissimo' Feenstra (2017-04-13 05:41:17) > > From: Vinzenz Feenstra > > > > A command that will list all currently logged in users, and the time > > since when they are logged in. > > > > Examples: > > > >

Re: [Qemu-devel] [PATCH v2 1/1] qga: Add 'guest-get-host-name' command

Quoting Vinzenz 'evilissimo' Feenstra (2017-04-04 01:46:31) > From: Vinzenz Feenstra > > Retrieving the guest host name is a very useful feature for virtual management > systems. This information can help to have more user friendly VM access > details, instead of an IP there

Re: [Qemu-devel] [PATCH for-2.10 3/3] qemu-img/convert: Move bs_n > 1 && -B check down

On 04/13/2017 03:34 PM, Max Reitz wrote: > It does not make much sense to use a backing image for the target when > you concatenate multiple images (because then there is no correspondence > between the source images' backing files and the target's); but it was > still possible to give one by

Re: [Qemu-devel] [PATCH for-2.10 2/3] qemu-img/convert: Use @opts for one thing only

On 04/13/2017 03:34 PM, Max Reitz wrote: > After storing the creation options for the new image into @opts, we > fetch some things for our own information, like the backing file name, > or whether to use encryption or preallocation. > > With the -n parameter, there will not be any creation

Re: [Qemu-devel] [Qemu-block] [PATCH] progress: Show current progress on SIGINFO

On 04/13/2017 04:38 PM, Max Reitz wrote: > On 08.02.2017 00:57, Max Reitz wrote: >> Currently we only print progress information on retrieval of SIGUSR1. >> Some systems have a dedicated SIGINFO for this, however, so it should be >> handled appropriately if it is available. >> >> Buglink:

Re: [Qemu-devel] [PATCH for-2.10 1/3] qemu-img/convert: Always set ret < 0 on error

On 04/13/2017 03:33 PM, Max Reitz wrote: > Otherwise the qemu-img process will exit with EXIT_SUCCESS instead of > EXIT_FAILURE. > > Cc: qemu-stable > Signed-off-by: Max Reitz > --- > qemu-img.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PATCH 0/3 for 2.10] migration/i386 cleanup

On Wed, Apr 05, 2017 at 08:00:21PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This removes some qemu_get_ and qemu_put_ use from i386/machine.c > and cleans out some very old code. > It breaks migration compatibility from prior

Re: [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg

On Wed, Apr 05, 2017 at 08:00:23PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Convert the fpreg save/restore to use VMSTATE_ macros rather than > .get/.put. > > Signed-off-by: Dr. David Alan Gilbert Nice!

Re: [Qemu-devel] [PATCH 3/3] migration/i386: Remove support for pre-0.12 formats

On Wed, Apr 05, 2017 at 08:00:24PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Remove support for versions of the CPU state prior to 11 > which is the version used in qemu 0.12 - you'd be pretty > lucky if you got a migration stream to

Re: [Qemu-devel] [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

On Thu, Apr 13, 2017 at 05:35:03PM +0800, Wei Wang wrote: > 2) transfer the guest unused pages to the host so that they > can be skipped to migrate in live migration. I don't understand this second bit. You leave the pages on the free list, and tell the host they're free. What's preventing

Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO

On 08.02.2017 00:57, Max Reitz wrote: > Currently we only print progress information on retrieval of SIGUSR1. > Some systems have a dedicated SIGINFO for this, however, so it should be > handled appropriately if it is available. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1662468 >

[Qemu-devel] [PATCH for-2.10 3/3] qemu-img/convert: Move bs_n > 1 && -B check down

It does not make much sense to use a backing image for the target when you concatenate multiple images (because then there is no correspondence between the source images' backing files and the target's); but it was still possible to give one by using -o backing_file=X instead of -B X. Fix this by

[Qemu-devel] [PATCH for-2.10 0/3] qemu-img/convert: Some small fixes

This series fixes some small issues I found in qemu-img's convert subcommand while reviewing Dan's convert/dd series. Nothing serious at all, so all for 2.10. Max Reitz (3): qemu-img/convert: Always set ret < 0 on error qemu-img/convert: Use @opts for one thing only qemu-img/convert: Move

[Qemu-devel] [PATCH for-2.10 2/3] qemu-img/convert: Use @opts for one thing only

After storing the creation options for the new image into @opts, we fetch some things for our own information, like the backing file name, or whether to use encryption or preallocation. With the -n parameter, there will not be any creation options; this is not too bad because this just means that

[Qemu-devel] [PATCH for-2.10 1/3] qemu-img/convert: Always set ret < 0 on error

Otherwise the qemu-img process will exit with EXIT_SUCCESS instead of EXIT_FAILURE. Cc: qemu-stable Signed-off-by: Max Reitz --- qemu-img.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 37c2894678..f2809e1ab4

Re: [Qemu-devel] [PATCH v4 1/1] qga: Add 'guest-get-users' command

Quoting Vinzenz 'evilissimo' Feenstra (2017-04-13 05:41:17) > From: Vinzenz Feenstra > > A command that will list all currently logged in users, and the time > since when they are logged in. > > Examples: > > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users"

Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations

Quoting Marc-André Lureau (2017-04-03 04:54:38) > Some users find the fsfreeze behaviour confusing. Add some notes about > invalid mount points and Windows usage. > > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=1436976 > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v9 3/5] mm: function to offer a page block on the free list

On Thu, 13 Apr 2017 17:35:06 +0800 Wei Wang wrote: > Add a function to find a page block on the free list specified by the > caller. Pages from the page block may be used immediately after the > function returns. The caller is responsible for detecting or preventing > the

Re: [Qemu-devel] [PATCH v4 4/4] qemu-img: copy *key-secret opts when opening newly created files

On 12.04.2017 18:44, Daniel P. Berrange wrote: > The qemu-img dd/convert commands will create a image file and > then try to open it. Historically it has been possible to open > new files without passing any options. With encrypted files > though, the *key-secret options are mandatory, so we need

Re: [Qemu-devel] [PATCH v4 3/4] qemu-img: introduce --target-image-opts for 'convert' command

On 12.04.2017 18:44, Daniel P. Berrange wrote: > The '--image-opts' flags indicates whether the source filename > includes options. The target filename has to remain in the > plain filename format though, since it needs to be passed to > bdrv_create(). When using --skip-create though, it would be

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 04:05 PM, Kevin Wolf wrote: > Am 13.04.2017 um 14:44 hat Denis V. Lunev geschrieben: >> On 04/13/2017 02:58 PM, Alberto Garcia wrote: >>> On Wed 12 Apr 2017 06:54:50 PM CEST, Denis V. Lunev wrote: My opinion about this approach is very negative as the problem could be

Re: [Qemu-devel] [PATCH v4 1/4] qemu-img: add support for --object with 'dd' command

On 12.04.2017 18:44, Daniel P. Berrange wrote: > The qemu-img dd command added --image-opts support, but missed > the corresponding --object support. This prevented passing > secrets (eg auth passwords) needed by certain disk images. > > Reviewed-by: Eric Blake >

Re: [Qemu-devel] [PATCH for 2.10 0/2] block: simple changes

On 05.04.2017 17:18, Denis V. Lunev wrote: > First patch here is one we have agreed on during the initial discussion > about truncate() in parallels format driver, another one is simple > coding style change spotted by my student. > > Signed-off-by: Denis V. Lunev > CC: Kevin

Re: [Qemu-devel] [PATCH 2/2] block: assert no image modification under BDRV_O_INACTIVE

On 05.04.2017 17:18, Denis V. Lunev wrote: > As long as BDRV_O_INACTIVE is set, the image file is only opened so we > have a file descriptor for it. We're definitely not supposed to modify > the image, it's still owned by the migration source. > > This commit is an addition to 09e0c771 but the

Re: [Qemu-devel] [PATCH 1/2] block: fix obvious coding style mitakes in block_int.h

On 05.04.2017 17:35, Eric Blake wrote: > On 04/05/2017 10:18 AM, Denis V. Lunev wrote: >> From: Klim Kireev > > s/mitakes/mistakes/ in the subject > > A blank commit message body doesn't help - the subject says what was > changed but not why (for example, output of

Re: [Qemu-devel] [PATCH v2] qga-win: Fix Event Viewer errors caused by qemu-ga

Quoting Sameeh Jubran (2017-04-05 07:01:06) > When the command "guest-fsfreeze-freeze" is executed it causes > the VSS service to log the error below in the Event Viewer. This > error is caused by an issue in the function "CommitSnapshots" in > provider.cpp: > > * When VSS_TIMEOUT_MSEC expires

Re: [Qemu-devel] [PATCH v3] qga-win: Fix a bug where qemu-ga service is stuck during stop operation

Quoting Sameeh Jubran (2017-04-11 02:50:36) > After triggering a freeze command without any following thaw command, > qemu-ga will not respond to stop operation. This behaviour is wanted on Linux > as there is no time limit for a freeze command and we want to prevent > quitting in the middle of

Re: [Qemu-devel] [PATCH] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply

Quoting Sameeh Jubran (2017-04-11 07:52:05) > The QGA schema states: > > @can-offline: Whether offlining the VCPU is possible. This member >is always filled in by the guest agent when the structure >is returned, and always ignored on input (hence it can be >

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 12:44 PM, Kevin Wolf wrote: > Am 12.04.2017 um 21:02 hat Denis V. Lunev geschrieben: >> On 04/12/2017 09:20 PM, Eric Blake wrote: >>> On 04/12/2017 12:55 PM, Denis V. Lunev wrote: Let me rephrase a bit. The proposal is looking very close to the following case: -

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration

On 04/13/2017 12:23 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/181 | 117 > + > tests/qemu-iotests/181.out | 38 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 156

Re: [Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

Am 13.04.2017 um 20:03 hat Eric Blake geschrieben: > On 04/13/2017 12:54 PM, Kevin Wolf wrote: > > Am 13.04.2017 um 19:39 hat Eric Blake geschrieben: > >> On 04/13/2017 12:23 PM, Kevin Wolf wrote: > >>> Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming > >>> migration') added

Re: [Qemu-devel] vmbus bridge: machine property or device?

On Thu, Apr 13, 2017 at 05:58:51PM +0100, Peter Maydell wrote: > On 13 April 2017 at 17:44, Eduardo Habkost wrote: > > On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: > >> Can you (or anybody else) please help me decide if I need > >> TYPE_SYS_BUS_DEVICE?

Re: [Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

On 04/13/2017 12:54 PM, Kevin Wolf wrote: > Am 13.04.2017 um 19:39 hat Eric Blake geschrieben: >> On 04/13/2017 12:23 PM, Kevin Wolf wrote: >>> Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming >>> migration') added blk_resume_after_migration() to the precopy migration >>>

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 04:21 PM, Alberto Garcia wrote: > On Thu 13 Apr 2017 02:44:51 PM CEST, Denis V. Lunev wrote: 1) current L2 cache management seems very wrong to me. Each cache miss means that we have to read entire L2 cache block. This means that in the worst case (when dataset

Re: [Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

Am 13.04.2017 um 19:39 hat Eric Blake geschrieben: > On 04/13/2017 12:23 PM, Kevin Wolf wrote: > > Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming > > migration') added blk_resume_after_migration() to the precopy migration > > path, but neglected to add it to the duplicated

Re: [Qemu-devel] vmbus bridge: machine property or device?

On Wed, Apr 12, 2017 at 05:07:20PM -0300, Eduardo Habkost wrote: > On Wed, Apr 12, 2017 at 05:18:51PM +0200, Markus Armbruster wrote: > > Roman Kagan writes: > > > VMBus is provided by a vmbus bridge; it appears the most natural to have > > > it subclassed from SysBusDevice.

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters

On 04/13/2017 12:38 PM, Eric Blake wrote: > On 04/13/2017 12:23 PM, Kevin Wolf wrote: >> The only thing the escape characters achieve is making the reference >> output unreadable and lines that are potentially so long that git >> doesn't want to put them into an email any more. Let's filter them

Re: [Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

On 04/13/2017 12:23 PM, Kevin Wolf wrote: > Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming > migration') added blk_resume_after_migration() to the precopy migration > path, but neglected to add it to the duplicated code that is used for > postcopy migration. This means that

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters

On 04/13/2017 12:23 PM, Kevin Wolf wrote: > The only thing the escape characters achieve is making the reference > output unreadable and lines that are potentially so long that git > doesn't want to put them into an email any more. Let's filter them out. Hear! Hear! > > Signed-off-by: Kevin

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

On Tue, Mar 28, 2017 at 01:27:06PM +0200, Alexander Graf wrote: > KVM has a feature bitmap of CPUID bits that it knows works for guests. > QEMU removes bits that are not part of that bitmap automatically on VM > start. > > However, some times we just don't list features in that list because >

Re: [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

On 04/13/2017 04:08 PM, Samuel Thibault wrote: > Hello, > > Philippe Mathieu-Daudé, on jeu. 13 avril 2017 08:45:23 -0300, wrote: >>> The NCSI header file comes from mainline Linux > > Please mention within the file which file it comes from exactly. OK. >>> +case NCSI_PKT_CMD_SMA: >>> +

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/181 | 117 + tests/qemu-iotests/181.out | 38 +++ tests/qemu-iotests/group | 1 + 3 files changed, 156 insertions(+) create mode 100755 tests/qemu-iotests/181

[Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters

The only thing the escape characters achieve is making the reference output unreadable and lines that are potentially so long that git doesn't want to put them into an email any more. Let's filter them out. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/028.out | 2 +-

[Qemu-devel] [PATCH 0/3] migration: Call blk_resume_after_migration() for postcopy

This fixes one of the bugs that made us disable the op blocker assertions for the 2.9 release. Kevin Wolf (3): migration: Call blk_resume_after_migration() for postcopy qemu-iotests: Filter HMP readline escape characters qemu-iotests: Test postcopy migration migration/savevm.c

[Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy

Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming migration') added blk_resume_after_migration() to the precopy migration path, but neglected to add it to the duplicated code that is used for postcopy migration. This means that the guest device doesn't request the necessary

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

On Tue, Mar 28, 2017 at 09:31:05AM -0300, Eduardo Habkost wrote: > On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: > > On 03/28/2017 02:41 AM, Eduardo Habkost wrote: > > > On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > > > > KVM has a feature bitmap of CPUID bits

Re: [Qemu-devel] [Qemu-block] [RFC] Proposed qcow2 extension: subcluster allocation

On Thu, Apr 13, 2017 at 04:27:35PM +0200, Kevin Wolf wrote: > Am 13.04.2017 um 16:15 hat Alberto Garcia geschrieben: > > On Thu 13 Apr 2017 03:51:55 PM CEST, Kevin Wolf wrote: > > >> This invariant is already broken by the very design of the qcow2 > > >> format, subclusters don't really add

Re: [Qemu-devel] ARM virt machine boots fail with 14 ioh3420

Adding Andrea, Ard, Drew and Marcel; and the main qemu list On 04/13/17 09:37, Shannon Zhao wrote: > Hi, > > I'm testing the PCIe devices hotplug for ARM virt machine and using > ioh3420 as root port. I found that below command line could work. > > qemu-system-aarch64 -machine

Re: [Qemu-devel] [PATCH v9 5/5] virtio-balloon: VIRTIO_BALLOON_F_MISC_VQ

On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > Add a new vq, miscq, to handle miscellaneous requests between the device > and the driver. > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES implements > request sent from the device. Commands are sent from host

Re: [Qemu-devel] [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

On Thu, Apr 13, 2017 at 07:34:19PM +0300, Michael S. Tsirkin wrote: > So we don't need the bitmap to talk to host, it is just > a data structure we chose to maintain lists of pages, right? > OK as far as it goes but you need much better isolation for it. > Build a data structure with APIs such as

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On 04/13/2017 11:02 AM, Jeff Cody wrote: > On Thu, Apr 13, 2017 at 03:39:59PM +0100, Stefan Hajnoczi wrote: >> On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: >>> >>> >>> On 13/04/2017 09:11, Jeff Cody wrote: > It didn't make it into 2.9-rc4 because of limited time. :( >

Re: [Qemu-devel] vmbus bridge: machine property or device?

On 13 April 2017 at 17:44, Eduardo Habkost wrote: > On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: >> Can you (or anybody else) please help me decide if I need >> TYPE_SYS_BUS_DEVICE? Logically the VMBus bridge is "attached directly >> to the main system bus"

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

On 04/13/2017 05:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2017 02:40, John Snow wrote: >> >> On 04/12/2017 07:36 PM, Eric Blake wrote: >>> On 04/12/2017 05:47 PM, John Snow wrote: On 04/12/2017 01:49 PM, Eric Blake wrote: > We had several functions that no one was using,

Re: [Qemu-devel] vmbus bridge: machine property or device?

On Thu, Apr 13, 2017 at 06:15:34PM +0300, Roman Kagan wrote: > On Wed, Apr 12, 2017 at 05:07:20PM -0300, Eduardo Habkost wrote: > > On Wed, Apr 12, 2017 at 05:18:51PM +0200, Markus Armbruster wrote: > > > Roman Kagan writes: > > > > VMBus is provided by a vmbus bridge; it

Re: [Qemu-devel] [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The

Re: [Qemu-devel] [PATCH for-2.9?] block: Do not unref bs->file on error in BD's open

On 04/13/2017 10:43 AM, Max Reitz wrote: > The block layer takes care of removing the bs->file child if the block > driver's bdrv_open()/bdrv_file_open() implementation fails. The block > driver therefore does not need to do so, and indeed should not unless it > sets bs->file to NULL afterwards --

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 0/2] block: An empty filename counts as no filename

On 04/13/2017 11:06 AM, Max Reitz wrote: > See patch 1 for what is happening when you try "qemu-img info ''" and > for the fix. > > (Patch 2 just adds a simple test.) > > > Max Reitz (2): > block: An empty filename counts as no filename > iotests/051: Add test for empty filename

[Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend()

Signed-off-by: Max Reitz --- util/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/error.c b/util/error.c index 9c40b1f458..020b86b9f0 100644 --- a/util/error.c +++ b/util/error.c @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list

Re: [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend

On 04/13/2017 01:45 PM, Philippe Mathieu-Daudé wrote: > > > On 04/13/2017 06:41 AM, Cédric Le Goater wrote: >> NC-SI (Network Controller Sideband Interface) enables a BMC to manage >> a set of NICs on a system. This model takes the simplest approach and >> reverses the NC-SI packets to pretend a

[Qemu-devel] [PATCH for-2.10 2/2] iotests/051: Add test for empty filename

Signed-off-by: Max Reitz --- tests/qemu-iotests/051| 1 + tests/qemu-iotests/051.out| 3 +++ tests/qemu-iotests/051.pc.out | 3 +++ 3 files changed, 7 insertions(+) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 630cb7a114..4fe676019b 100755

[Qemu-devel] [PATCH for-2.10 1/2] block: An empty filename counts as no filename

Reproducer: $ ./qemu-img info '' qemu-img: ./block.c:1008: bdrv_open_driver: Assertion `!drv->bdrv_needs_filename || bs->filename[0]' failed. [1]26105 abort (core dumped) ./qemu-img info '' This patch fixes this to be: $ ./qemu-img info '' qemu-img: Could not open

[Qemu-devel] [PATCH for-2.10 0/2] block: An empty filename counts as no filename

See patch 1 for what is happening when you try "qemu-img info ''" and for the fix. (Patch 2 just adds a simple test.) Max Reitz (2): block: An empty filename counts as no filename iotests/051: Add test for empty filename block.c | 2 +- tests/qemu-iotests/051

[Qemu-devel] [PATCH for-2.10?] block: Do not unref bs->file on error in BD's open

The block layer takes care of removing the bs->file child if the block driver's bdrv_open()/bdrv_file_open() implementation fails. The block driver therefore does not need to do so, and indeed should not unless it sets bs->file to NULL afterwards -- because if this is not done, the

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 06:04 PM, Alberto Garcia wrote: > On Thu 13 Apr 2017 03:30:43 PM CEST, Denis V. Lunev wrote: >> Yes, block size should be increased. I perfectly in agreement with >> your. But I think that we could do that by plain increase of the >> cluster size without any further dances.

Re: [Qemu-devel] [Qemu-block] Regression from 2.8: stuck in bdrv_drain()

On Thu, Apr 13, 2017 at 6:45 AM, Paolo Bonzini wrote: > On 13/04/2017 09:11, Jeff Cody wrote: >>> It didn't make it into 2.9-rc4 because of limited time. :( >>> >>> Looks like there is no -rc5, we'll have to document this as a known issue. >>> Users should

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On Thu 13 Apr 2017 03:30:43 PM CEST, Denis V. Lunev wrote: > Yes, block size should be increased. I perfectly in agreement with > your. But I think that we could do that by plain increase of the > cluster size without any further dances. Sub-clusters as sub-clusters > will help if we are able to

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On Thu, Apr 13, 2017 at 03:39:59PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > > > > > > On 13/04/2017 09:11, Jeff Cody wrote: > > >> It didn't make it into 2.9-rc4 because of limited time. :( > > >> > > >> Looks like there is no -rc5, we'll

Re: [Qemu-devel] [PATCH 1/3] migration/i386: Remove old non-softfloat 64bit FP support

On Wed, Apr 05, 2017 at 08:00:22PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Long long ago, we used to support storing the x86 FP registers in > a 64bit format. > > Then c31da136a0bf8caad70c348f5ffc283206e9c7fc in v0.14-rc0 removed >

Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations

Reviewed-by: Vinzenz Feenstra > > On Apr 3, 2017, at 11:54 AM, Marc-André Lureau > wrote: > > Some users find the fsfreeze behaviour confusing. Add some notes about > invalid mount points and Windows usage.

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On 13 April 2017 at 15:33, Eric Blake wrote: > On 04/13/2017 04:48 AM, Peter Maydell wrote: >> Well, we *hope* there is no -rc5, but if the bug is genuinely >> a "we can't release like this" bug we will obviously have to >> do another rc. Basically you all as the block

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On Thu, Apr 13, 2017 at 09:45:49AM -0500, Eric Blake wrote: > On 04/13/2017 09:39 AM, Stefan Hajnoczi wrote: > > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > >> > >> > >> On 13/04/2017 09:11, Jeff Cody wrote: > It didn't make it into 2.9-rc4 because of limited time. :( >

Re: [Qemu-devel] [PATCH v2 0/2] migration: fix virtio-rng

On Wed, Apr 12, 2017 at 03:53:10PM +0200, Laurent Vivier wrote: > When post-copy migration is enabled, the destination > guest can ask for memory from the source when the > vmstate is restored. > > In the case of virtio, a part of the virtqueue > is migrated by the vmstate structure

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On 04/13/2017 09:39 AM, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: >> >> >> On 13/04/2017 09:11, Jeff Cody wrote: It didn't make it into 2.9-rc4 because of limited time. :( Looks like there is no -rc5, we'll have to document this as a

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 04:51 PM, Kevin Wolf wrote: > Am 13.04.2017 um 15:21 hat Alberto Garcia geschrieben: >> This invariant is already broken by the very design of the qcow2 format, >> subclusters don't really add anything new there. For any given cluster >> size you can write 4k in every odd cluster,

Re: [Qemu-devel] Regression from 2.8: stuck in bdrv_drain()

On Thu, Apr 13, 2017 at 01:45:55PM +0800, Paolo Bonzini wrote: > > > On 13/04/2017 09:11, Jeff Cody wrote: > >> It didn't make it into 2.9-rc4 because of limited time. :( > >> > >> Looks like there is no -rc5, we'll have to document this as a known issue. > >> Users should

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

On 04/13/2017 04:36 PM, Alberto Garcia wrote: > On Thu 13 Apr 2017 03:09:53 PM CEST, Denis V. Lunev wrote: For nowadays SSD we are facing problems somewhere else. Right now I can achieve only 100k IOPSes on SSD capable of 350-550k. 1 Mb block with preallocation and fragmented L2

  1   2   >