Re: [Qemu-devel] [PATCH v11 0/9] add blkdebug tests

On 29.04.2017 21:14, Eric Blake wrote: > Available as a tag at: > git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v11 > > Prerequisites: Kevin's block pull request: > https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05799.html > > v10 was: >

Re: [Qemu-devel] [PATCH v11 7/9] blkdebug: Simplify override logic

On 05/03/2017 01:59 PM, Max Reitz wrote: > On 29.04.2017 21:14, Eric Blake wrote: >> Rather than store into a local variable, then copy to the struct >> if the value is valid, then reporting errors otherwise, it is >> simpler to just store into the struct and report errors if the >> value is

Re: [Qemu-devel] [PATCH v11 7/9] blkdebug: Simplify override logic

On 03.05.2017 20:59, Max Reitz wrote: > On 29.04.2017 21:14, Eric Blake wrote: >> Rather than store into a local variable, then copy to the struct >> if the value is valid, then reporting errors otherwise, it is >> simpler to just store into the struct and report errors if the >> value is invalid.

Re: [Qemu-devel] [PATCH v11 7/9] blkdebug: Simplify override logic

On 29.04.2017 21:14, Eric Blake wrote: > Rather than store into a local variable, then copy to the struct > if the value is valid, then reporting errors otherwise, it is > simpler to just store into the struct and report errors if the > value is invalid. This however requires that the struct

Re: [Qemu-devel] [PATCH v11 3/9] qemu-io: Switch 'map' output to byte-based reporting

On 29.04.2017 21:14, Eric Blake wrote: > Mixing byte offset and sector allocation counts is a bit > confusing. Also, reporting n/m sectors, where m decreases > according to the remaining size of the file, isn't really > adding any useful information; and reporting an offset at > both the front

Re: [Qemu-devel] [PATCH v11 2/9] qemu-io: Switch 'alloc' command to byte-based length

On 29.04.2017 21:14, Eric Blake wrote: > For the 'alloc' command, accepting an offset in bytes but a length > in sectors, and reporting output in sectors, is confusing. Do > everything in bytes, and adjust the expected output accordingly. > > Signed-off-by: Eric Blake > >

Re: [Qemu-devel] [PATCH 1/5] MAINTAINERS: Add "R:" tag for self-appointed reviewers

On 03/05/2017 20:23, John Snow wrote: >> >> Seriously: the purpose here is a bit different from the Linux kernel. >> While Linux uses "R" to designate non-maintainers for reviewing patches >> in a given area, in QEMU I would also like to use "R" so that people can >> delegate sending pull

Re: [Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

On 29.04.2017 21:14, Eric Blake wrote: > Several copy-and-pasted alignment checks exist in qemu-io, which > could use some minor improvements: > > - Manual comparison against 0x1ff is not as clean as using our > alignment macros (QEMU_IS_ALIGNED) from osdep.h. > > - The error messages aren't

Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later.

Hi Samuel, Should I add an assert for ih_x1? It sounds like a bug that caller set up a right src and dst address and without set right ih_x1. On Thu, Apr 27, 2017 at 6:21 AM, Samuel Thibault wrote: > Hello, > > Thomas Huth, on lun. 24 avril 2017 11:15:56 +0200,

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

On Wed, May 03, 2017 at 06:07:43PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > When parsing alternates from a string, there are some limitations in > > what we can do, but it is a valid use case in some situations. We can > > support booleans, integer

Re: [Qemu-devel] [PATCH v10 11/17] qcow2: Discard/zero clusters by byte count

On 27.04.2017 03:46, Eric Blake wrote: > Passing a byte offset, but sector count, when we ultimately > want to operate on cluster granularity, is madness. Clean up > the external interfaces to take both offset and count as bytes, > while still keeping the assertion added previously that the >

Re: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

On Wed, May 03, 2017 at 09:27:54 -0700, Richard Henderson wrote: > On 05/03/2017 08:51 AM, Emilio G. Cota wrote: > >On Tue, May 02, 2017 at 20:36:52 -0700, Richard Henderson wrote: > >>On 05/02/2017 12:22 PM, Richard Henderson wrote: > >>>Changes since v5: > >>... > >>> * Alpha frontend patch

Re: [Qemu-devel] [PATCH 1/5] MAINTAINERS: Add "R:" tag for self-appointed reviewers

On 05/03/2017 05:43 AM, Paolo Bonzini wrote: > From: "Paul E. McKenney" > > Some people are not content with the amount of mail they get, and would > like to be CCed on patches for areas they do not maintain. Let them > satisfy their own appetite for qemu-devel

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

On 05/03/2017 02:29 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: >>> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: > "Denis V.

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g.

Re: [Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

On 05/03/2017 01:09 PM, Dr. David Alan Gilbert wrote: * Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: static void realize(DeviceState *d, Error **errp) { sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(d); @@ -540,6 +598,8 @@ static void realize(DeviceState *d, Error

Re: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling

On Thu, 27 Apr 2017 17:28:39 +1000 David Gibson wrote: > This is a rebased and revised version of my patches revising CPU > compatiblity mode handling on ppc, last posted in November. Since > then, many of the patches have already been merged (some for 2.9, some >

Re: [Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

On Wed, May 03, 2017 at 02:38:41PM -0300, Eduardo Habkost wrote: > On Wed, May 03, 2017 at 11:39:10AM -0500, Eric Blake wrote: > > On 05/03/2017 11:35 AM, Eduardo Habkost wrote: > > > > >> + > > >> +memset(, 0, sizeof(cpu)); > > >> +cpu.has_node_id = object->u.cpu.has_node_id; > >

Re: [Qemu-devel] [PATCH v10 10/17] qcow2: Assert that cluster operations are aligned

On 27.04.2017 03:46, Eric Blake wrote: > We already audited (in commit 0c1bd469) that qcow2_discard_clusters() > is only passed cluster-aligned start values; but we can further > tighten the assertion that the only unaligned end value is at EOF. > > Recent commits have taken advantage of an

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Wed, May 03, 2017 at 10:20:59AM -0700, Stefano Stabellini wrote: > On Wed, 3 May 2017, Anthony PERARD wrote: > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > > I think xencall should be part of the base xen_stable_libs

Re: [Qemu-devel] [PATCH v2] libvhost-user: fix crash when rings aren't ready

* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Calling libvhost-user functions like vu_queue_get_avail_bytes() when the > queue doesn't yet have addresses will result in the crashes like the > following: > > Program received signal SIGSEGV, Segmentation fault. > 0x55c414112ce4 in

Re: [Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

On Wed, May 03, 2017 at 11:39:10AM -0500, Eric Blake wrote: > On 05/03/2017 11:35 AM, Eduardo Habkost wrote: > > >> + > >> +memset(, 0, sizeof(cpu)); > >> +cpu.has_node_id = object->u.cpu.has_node_id; > >> +cpu.node_id = object->u.cpu.node_id; > >> +

Re: [Qemu-devel] [PATCH v2 09/24] numa: add check that board supports cpu_index to node mapping

On Wed, May 03, 2017 at 06:19:50PM +0200, Igor Mammedov wrote: > On Wed, 3 May 2017 12:04:29 -0300 > Eduardo Habkost wrote: > > > On Wed, May 03, 2017 at 02:57:03PM +0200, Igor Mammedov wrote: > > > Default node mapping initialization already checks that board > > > supports

Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

On Tue, 2 May 2017 17:15:02 -0500 Eric Blake wrote: > On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > > This patchset factor out the duplicate qmp throttle interface code > > that was present in both block and fsdev device files. > > Instead of adding the duplicate code

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Wed, 3 May 2017, Anthony PERARD wrote: > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > Yes, you are right. However I noticed that -lxencall needs

Re: [Qemu-devel] [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

On 04/22/2017 08:23 AM, Gonglei wrote: > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. > > In this patch, CIPHER, MAC, HASH, AEAD services

Re: [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure

On Wed, 3 May 2017 16:19:20 +0200 Pradeep Jagadeesh wrote: > On 5/3/2017 8:22 AM, Greg Kurz wrote: > > s/Throttle/throttle > > > > On Tue, 2 May 2017 10:29:43 -0400 > > Pradeep Jagadeesh wrote: > > > >> This patchset introduces a new

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Wed, May 03, 2017 at 05:52:07PM +0100, Wei Liu wrote: > On Wed, May 03, 2017 at 05:48:38PM +0100, Anthony PERARD wrote: > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > > I think xencall should be part of the base

[Qemu-devel] [PATCH v2] libvhost-user: fix crash when rings aren't ready

Calling libvhost-user functions like vu_queue_get_avail_bytes() when the queue doesn't yet have addresses will result in the crashes like the following: Program received signal SIGSEGV, Segmentation fault. 0x55c414112ce4 in vring_avail_idx (vq=0x55c41582fd68, vq=0x55c41582fd68) at

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 03 May 2017 17:49 > To: Stefano Stabellini > Cc: Paul Durrant ; qemu-devel@nongnu.org; Wei > Liu ; xen-de...@lists.xenproject.org >

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Wed, May 03, 2017 at 05:48:38PM +0100, Anthony PERARD wrote: > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > Yes, you are right. However I noticed

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > On Thu, 20 Apr 2017, Paul Durrant wrote: > > I think xencall should be part of the base xen_stable_libs anyway. > > Yes, you are right. However I noticed that -lxencall needs to come after > -lxendevicemodel. So, I'll have to

Re: [Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

On 05/03/2017 11:35 AM, Eduardo Habkost wrote: >> + >> +memset(, 0, sizeof(cpu)); >> +cpu.has_node_id = object->u.cpu.has_node_id; >> +cpu.node_id = object->u.cpu.node_id; >> +cpu.has_socket_id = object->u.cpu.has_socket_id; >> +cpu.socket_id =

Re: [Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

On Wed, May 03, 2017 at 02:57:17PM +0200, Igor Mammedov wrote: [...] > diff --git a/numa.c b/numa.c > index 40e9f44..61521f5 100644 > --- a/numa.c > +++ b/numa.c > @@ -227,6 +227,7 @@ static int parse_numa(void *opaque, QemuOpts *opts, Error > **errp) > NumaOptions *object = NULL; >

Re: [Qemu-devel] [PATCH v3 2/4] fsdev: QMP interface for throttling

On 05/03/2017 10:40 AM, Pradeep Jagadeesh wrote: > On 5/3/2017 12:13 AM, Eric Blake wrote: >> On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: >>> This patchset enables qmp interfaces for the fsdev >>> devices. This provides two interfaces one >>> for querying info of all the fsdev devices. The

Re: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

On 05/03/2017 08:51 AM, Emilio G. Cota wrote: On Tue, May 02, 2017 at 20:36:52 -0700, Richard Henderson wrote: On 05/02/2017 12:22 PM, Richard Henderson wrote: Changes since v5: ... * Alpha frontend patch rewritten; the former patch appears to drop clock interrupts, not exiting the

Re: [Qemu-devel] [PATCH v2 09/24] numa: add check that board supports cpu_index to node mapping

On Wed, 3 May 2017 12:04:29 -0300 Eduardo Habkost wrote: > On Wed, May 03, 2017 at 02:57:03PM +0200, Igor Mammedov wrote: > > Default node mapping initialization already checks that board > > supports cpu_index to node mapping and refuses to start if > > it's not supported.

Re: [Qemu-devel] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, 3 May 2017 11:59:35 -0300 Eduardo Habkost wrote: > On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote: > [...] > > @@ -378,14 +379,16 @@ void parse_numa_opts(MachineClass *mc) > > * rule grouping VCPUs by socket so that VCPUs from the same socket

Re: [Qemu-devel] [PATCH v2 06/24] spapr: add node-id property to sPAPR core

On Wed, 3 May 2017 11:46:44 -0300 Eduardo Habkost wrote: > On Wed, May 03, 2017 at 02:57:00PM +0200, Igor Mammedov wrote: > > it will allow switching from cpu_index to core based numa > > mapping in follow up patches. > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On 03/05/2017 17:55, Richard W.M. Jones wrote: > On Wed, May 03, 2017 at 05:46:49PM +0200, Paolo Bonzini wrote: >> Please test this: >> >> diff --git a/block/curl.c b/block/curl.c >> index 2708d57c2f..cfe02bfd79 100644 >> --- a/block/curl.c >> +++ b/block/curl.c >> @@ -467,7 +467,9 @@ static

Re: [Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

* Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: > static void realize(DeviceState *d, Error **errp) > { > sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(d); > @@ -540,6 +598,8 @@ static void realize(DeviceState *d, Error **errp) > object_unref(OBJECT(drc)); > } >

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

Eduardo Habkost writes: > When parsing alternates from a string, there are some limitations in > what we can do, but it is a valid use case in some situations. We can > support booleans, integer types, and enums. > > This will be used to support 'feature=force' in -cpu

Re: [Qemu-devel] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, 3 May 2017 11:42:40 -0300 Eduardo Habkost wrote: > On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote: > > Originally CPU threads were by default assigned in > > round-robin fashion. However it was causing issues in > > guest since CPU threads from the

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On Wed, May 03, 2017 at 05:46:49PM +0200, Paolo Bonzini wrote: > Please test this: > > diff --git a/block/curl.c b/block/curl.c > index 2708d57c2f..cfe02bfd79 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -467,7 +467,9 @@ static CURLState *curl_init_state(BlockDriverState > *bs,

Re: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

On Tue, May 02, 2017 at 20:36:52 -0700, Richard Henderson wrote: > On 05/02/2017 12:22 PM, Richard Henderson wrote: > >Changes since v5: > ... > > * Alpha frontend patch rewritten; the former patch appears to > > drop clock interrupts, not exiting the kernel's idle loop. > > I never

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On 03/05/2017 17:34, Richard W.M. Jones wrote: > Thread 1 (Thread 0x7f1d5a4e2c00 (LWP 29947)): > #0 0x7f1d57f861bd in __lll_lock_wait () > at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 > #1 0x7f1d57f81d02 in _L_lock_791 () at /lib64/libpthread.so.0 > #2

Re: [Qemu-devel] [PATCH 1/4] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

Eduardo Habkost writes: > On Tue, May 02, 2017 at 04:29:32PM -0500, Eric Blake wrote: >> On 05/02/2017 03:31 PM, Eduardo Habkost wrote: >> > This will allow visitors to make decisions based on the supported qtypes >> > of a given alternate type. The new parameter can replace

Re: [Qemu-devel] [PATCH 1/5] mc146818rtc: update periodic timer only if it is needed

On 12/04/2017 11:51, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Currently, the timer is updated whenever RegA or RegB is written > even if the periodic timer related configuration is not changed > > This patch optimizes it slightly to make the update

Re: [Qemu-devel] [PATCH v3 2/4] fsdev: QMP interface for throttling

On 5/3/2017 12:13 AM, Eric Blake wrote: On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: This patchset enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device.

Re: [Qemu-devel] [PATCH 4/5] mc146818rtc: move x86 specific code out of periodic_timer_update

On 12/04/2017 11:51, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Move the x86 specific code in periodic_timer_update() to a common place, > the actual logic is not changed > > Signed-off-by: Xiao Guangrong > --- >

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

Same backtrace, but with some more symbols: __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 135 2: movl %edx, %eax (gdb) t a a bt Thread 3 (Thread 0x7f1d49967700 (LWP 29949)): #0 0x7f1d53a39bf9 in syscall () at

Re: [Qemu-devel] [PATCH 3/5] mc146818rtc: properly count the time for the next interrupt

On 12/04/2017 11:51, guangrong.x...@gmail.com wrote: > +#ifdef TARGET_I386 > +/* > + * if more than period clocks were passed, i.e, the timer > interrupt > + * has been lost, we should catch up the time. > + */ > +if (s->lost_tick_policy

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On Wed, May 03, 2017 at 04:59:22PM +0200, Paolo Bonzini wrote: > Maybe there is, can you grab an all-threads backtrace via gdb? Program received signal SIGINT, Interrupt. 0x7f1d57f861bd in __lll_lock_wait () from /lib64/libpthread.so.0 (gdb) t a a bt Thread 9 (Thread 0x7f1d49967700 (LWP

Re: [Qemu-devel] [PATCH v2 10/24] numa: mirror cpu to node mapping in MachineState::possible_cpus

On Wed, May 03, 2017 at 02:57:04PM +0200, Igor Mammedov wrote: > Introduce machine_set_cpu_numa_node() helper that stores > node mapping for CPU in MachineState::possible_cpus. > CPU and node it belongs to is specified by 'props' argument. > > Patch doesn't remove old way of storing mapping in >

Re: [Qemu-devel] [PATCH 2/5] mc146818rtc: fix clock lost after scaling coalesced irq

On 12/04/2017 11:51, guangrong.x...@gmail.com wrote: > +int current_irq_coalesced = s->irq_coalesced; > + > +s->irq_coalesced = (current_irq_coalesced * s->period) / period; > + > +/* > + * calculate the lost clock after it is scaled which should

Re: [Qemu-devel] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote: [...] > diff --git a/numa.c b/numa.c > index 6fc2393..ab1661d 100644 > --- a/numa.c > +++ b/numa.c > @@ -294,9 +294,10 @@ static void validate_numa_cpus(void) > g_free(seen_cpus); > } > > -void parse_numa_opts(MachineClass *mc)

Re: [Qemu-devel] [PATCH v2 09/24] numa: add check that board supports cpu_index to node mapping

On Wed, May 03, 2017 at 02:57:03PM +0200, Igor Mammedov wrote: > Default node mapping initialization already checks that board > supports cpu_index to node mapping and refuses to start if > it's not supported. Do the same for explicitly provided > mapping "-numa node,cpus=..." > > Signed-off-by:

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On 03/05/2017 16:54, Richard W.M. Jones wrote: > On Mon, Feb 27, 2017 at 04:34:44PM +, Stefan Hajnoczi wrote: >> From: Paolo Bonzini >> >> Now that all bottom halves and callbacks take care of taking the >> AioContext lock, we can migrate some users away from it and to

Re: [Qemu-devel] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote: [...] > @@ -378,14 +379,16 @@ void parse_numa_opts(MachineClass *mc) > * rule grouping VCPUs by socket so that VCPUs from the same socket > * would be on the same node. > */ > +if

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

On 03/05/2017 16:50, Xiao Guangrong wrote: > Furthermore, userspace has no knowledge about if PML is enable (it > can be required from sysfs, but it is a good way in QEMU), so it is > difficult for the usespace to know when to use write-protect-all. > Maybe we can make

Re: [Qemu-devel] [PATCH 1/2] libvhost-user: fix vu_queue_get_avail_bytes() crash

* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Calling vu_queue_get_avail_bytes() when the queue doesn't yet have > addresses will result in the following crash: > > Program received signal SIGSEGV, Segmentation fault. > 0x55c414112ce4 in vring_avail_idx (vq=0x55c41582fd68,

Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release

On Mon, Feb 27, 2017 at 04:34:44PM +, Stefan Hajnoczi wrote: > From: Paolo Bonzini > > Now that all bottom halves and callbacks take care of taking the > AioContext lock, we can migrate some users away from it and to a > specific QemuMutex or CoMutex. > > Protect

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

On 05/03/2017 08:28 PM, Paolo Bonzini wrote: So if I understand correctly this relies on userspace doing: 1) KVM_GET_DIRTY_LOG without write protect 2) KVM_WRITE_PROTECT_ALL_MEM Writes may happen between 1 and 2; they are not represented in the live dirty bitmap but

Re: [Qemu-devel] [PATCH v2 06/24] spapr: add node-id property to sPAPR core

On Wed, May 03, 2017 at 02:57:00PM +0200, Igor Mammedov wrote: > it will allow switching from cpu_index to core based numa > mapping in follow up patches. > > Signed-off-by: Igor Mammedov > Reviewed-by: David Gibson Have you considered adding

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

On 05/03/2017 07:29 AM, Daniel P. Berrange wrote: On Wed, May 03, 2017 at 11:24:42AM +, Marc-André Lureau wrote: Hi On Wed, May 3, 2017 at 3:17 PM Dr. David Alan Gilbert wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Tue, May 02, 2017 at 03:35:48PM

Re: [Qemu-devel] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote: > Originally CPU threads were by default assigned in > round-robin fashion. However it was causing issues in > guest since CPU threads from the same socket/core could > be placed on different NUMA nodes. > Commit fb43b73b (pc: fix

Re: [Qemu-devel] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

On 30/04/2017 19:25, Daniel Henrique Barboza wrote: > Following up the previous detach_cb change, this patch removes the > detach_cb_opaque entirely from the code. > > The reason is that the drc->detach_cb_opaque object can't be > restored in the post load of the upcoming DRC migration and no

Re: [Qemu-devel] [PATCH v2 01/24] tests: add CPUs to numa node mapping test

On Wed, May 03, 2017 at 02:56:55PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > Reviewed-by: David Gibson Reviewed-by: Eduardo Habkost -- Eduardo

[Qemu-devel] Dummy Panel.

Hi I have created a new fork on GitHub https://github.com/flypie/flypie-pi-qemu and an associated project https://github.com/flypie/GDummyPanel the idea as well as getting the Original PI emulation working is to add some facility for simulated IO. This is a demonstration of the latest version,

Re: [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure

On 5/3/2017 8:22 AM, Greg Kurz wrote: s/Throttle/throttle On Tue, 2 May 2017 10:29:43 -0400 Pradeep Jagadeesh wrote: This patchset introduces a new io throttle structure. This will be s/patchset/patch OK used in both block and fsdev devices. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

On 05/03/2017 02:35 PM, Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Update paths for AioContext implementation

On 03/05/2017 12:30, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 46cf4870f9..62d62a6675 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS

Re: [Qemu-devel] [PULL 14/34] iotests: Launch qemu-nbd with -e 42

Am 29.04.2017 um 00:08 hat Eric Blake geschrieben: > On 04/28/2017 03:33 PM, Kevin Wolf wrote: > > From: Max Reitz > > > > There is no reason for the qemu-nbd server used for tests not to accept > > an arbitrary number of clients. In fact, test 181 will require it to > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update paths for main loop

On 03/05/2017 13:59, Paolo Bonzini wrote: > Moved by c2b38b2 ("block: move AioContext, QEMUTimer, main-loop to > libqemuutil"), let's update MAINTAINERS too. > > Reported-by: Laurent Vivier > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 4 ++-- >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update paths for main loop

Paolo Bonzini writes: > Moved by c2b38b2 ("block: move AioContext, QEMUTimer, main-loop to > libqemuutil"), let's update MAINTAINERS too. > > Reported-by: Laurent Vivier > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation

On Fri, Apr 28, 2017 at 01:24:43PM +0100, Daniel P. Berrange wrote: > At the 2016 summit it was suggested that we delete the GThread > coroutine impl since it is not fully functional, and you can > debug the ucontext impl with our GDB helper script. > > I don't recall the subject being raised

Re: [Qemu-devel] [PATCH 1/5] hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new

On 30/04/2017 19:25, Daniel Henrique Barboza wrote: > The idea of moving the detach callback functions to the constructor > of the dr_connector is to set them statically at init time, avoiding > any post-load hooks to restore it (after a migration, for example). > > Summary of changes: > > -

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

On 05/03/2017 12:26 AM, Bharata B Rao wrote: On Tue, May 2, 2017 at 1:13 PM, Daniel Henrique Barboza > wrote: On 05/02/2017 12:40 AM, Bharata B Rao wrote: On Sun, Apr 30, 2017 at 10:55 PM, Daniel Henrique Barboza

Re: [Qemu-devel] [PATCH] trace: disallow more than 10 arguments per trace event

On Wed, Apr 26, 2017 at 04:39:00PM +0100, Daniel P. Berrange wrote: > The UST trace backend can only cope with upto 10 arguments. To ensure we > don't exceed the limit when UST is not compiled in, disallow more than > 10 arguments upfront. > > This prevents the case where: > > commit

Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf

Paolo Bonzini writes: > On 03/05/2017 14:56, Markus Armbruster wrote: >>> snprintf writes at most 2 bytes here including the terminating NUL, so >>> the result is truncated". >> >> You're right; I forgot that snprintf() always adds a NUL. So this *is* >> broken: we write

Re: [Qemu-devel] [PATCH v2 0/3] migration: Call blk_resume_after_migration() for postcopy

On Wed, Apr 19, 2017 at 05:15:59PM +0200, Kevin Wolf wrote: > This fixes one of the bugs that made us disable the op blocker > assertions for the 2.9 release. > > v2: > - Filter HMP output not only for common.qemu users, but for all test > cases that had an escape character in their reference

Re: [Qemu-devel] [Qemu-block] [PATCH v3] migration/block:limit the time used for block migration

On Wed, May 3, 2017 at 11:44 AM, 858585 jemmy wrote: > On Mon, Apr 10, 2017 at 9:52 PM, Stefan Hajnoczi wrote: >> On Sat, Apr 08, 2017 at 09:17:58PM +0800, 858585 jemmy wrote: >>> On Fri, Apr 7, 2017 at 7:34 PM, Stefan Hajnoczi

[Qemu-devel] [Bug 1687653] Re: QEMU-KVM / detect_zeroes causes KVM to start unlimited number of threads on Guest-Sided High-IO with big Blocksize

After further investigation on IRC the following points were raised: 1. Non-vcpu threads in QEMU weren't being isolated. Libvirt can do this using the domain XML element. The guest can create a high load if some QEMU threads are unconstrained. 2. The wait% CPU stat was causing

[Qemu-devel] [PATCH v2 24/24] tests: check -numa node, cpu=props_list usecase

Signed-off-by: Igor Mammedov --- tests/numa-test.c | 151 ++ 1 file changed, 151 insertions(+) diff --git a/tests/numa-test.c b/tests/numa-test.c index 2722687..c3475d6 100644 --- a/tests/numa-test.c +++

[Qemu-devel] [PATCH v2 22/24] numa: remove node_cpu bitmaps as they are no longer used

Postfactum "CPU(s) present in multiple NUMA nodes" check was the last user of node_cpu bitmaps, but it's not need as machine_set_cpu_numa_node() does the similar check at the time mapping is set for cpus (i.e. when -numa cpus= is parsed) and ensures that cpu can be mapped only to one node. Remove

[Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

legacy cpu to node mapping is using cpu index values to map VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' option. However cpu index is internal concept and QEMU users have to guess /reimplement qemu's logic/ to map it to a concrete cpu socket/core/thread to make sane CPUs placement

[Qemu-devel] migration: add incremental drive-mirror and blockdev-mirror with dirtymap

Hi all, this patch adds possibility to start mirroring since specific dirtyblock bitmap. The use-case is, for live migrations with ZFS volume used as block device: 1. make dirtyblock bitmap in qemu 2. make ZFS volume snapshot 3. zfs send/receive the snapshot to target machine 4. start mirroring

[Qemu-devel] [PATCH v2 20/24] machine: call machine init from wrapper

add machine_run_board_init() wrapper that calls machine init for now but in follow up patches it will be used to run generic machine code that should run before machine init. Signed-off-by: Igor Mammedov --- include/hw/boards.h | 1 + hw/core/machine.c | 6 ++ vl.c

[Qemu-devel] [PATCH v2 16/24] QMP: include CpuInstanceProperties into query_cpus output output

if board supports CpuInstanceProperties, report them for each CPU thread listed. Main motivation for this is to provide these properties introspection via QMP interface for using in test cases to verify numa node to cpu mapping, which includes not only boards that support cpu hotplug and have this

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

** Changed in: qemu (Ubuntu Xenial) Assignee: (unassigned) => Marc Deslauriers (mdeslaur) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581936 Title: Frozen Windows 7 VMs with VGA

[Qemu-devel] [PATCH v2 15/24] virt-arm: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu()

Signed-off-by: Igor Mammedov --- v2: use numa_[has_]node_id() wrappers (Drew) --- hw/arm/virt-acpi-build.c | 19 +++ hw/arm/virt.c| 13 +++-- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/hw/arm/virt-acpi-build.c

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

** Changed in: qemu (Ubuntu Trusty) Assignee: (unassigned) => Marc Deslauriers (mdeslaur) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581936 Title: Frozen Windows 7 VMs with VGA

[Qemu-devel] [PATCH v2 13/24] pc: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu()

Signed-off-by: Igor Mammedov --- v2: use numa_[has_]node_id() wrappers (Drew) --- hw/acpi/cpu.c| 7 +++ hw/i386/acpi-build.c | 11 --- hw/i386/pc.c | 18 ++ 3 files changed, 17 insertions(+), 19 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf

On 03/05/2017 14:56, Markus Armbruster wrote: >> snprintf writes at most 2 bytes here including the terminating NUL, so >> the result is truncated". > > You're right; I forgot that snprintf() always adds a NUL. So this *is* > broken: we write NUL instead of the second digit. Mentioning this in

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

Discussed with the Security Team, this will very likely be in the next round of updates that will follow soon. I'll additionally ping the release team to get the blocking ongoing SRU processed faster. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v2 11/24] numa: do default mapping based on possible_cpus instead of node_cpu bitmaps

Signed-off-by: Igor Mammedov Reviewed-by: David Gibson --- numa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/numa.c b/numa.c index 5ff1212..c7e3e0a 100644 --- a/numa.c +++ b/numa.c @@ -309,6 +309,7

Re: [Qemu-devel] [PATCH] tests: acpi: extend cphp and memhp testcase with numa distance check

On Wed, 3 May 2017 17:17:16 +0800 He Chen wrote: > Signed-off-by: He Chen Reviewed-by: Igor Mammedov Eduardo, could you take it through your tree as well and add as part of this patch SLIT tables blobs for piix4/q35 that

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

I checked and this is in 2.6.1 via a backport as [1] not as the original [2]. But that means >=Yakkety is good and Xenial/Trusty are bad since the related Security SRUs. Updating bug tasks accordingly. [1]: http://git.qemu.org/?p=qemu.git;a=commit;h=7ff5dc445d6bb392f9fb3d0a254ef9071304780b

[Qemu-devel] [PATCH v2 10/24] numa: mirror cpu to node mapping in MachineState::possible_cpus

Introduce machine_set_cpu_numa_node() helper that stores node mapping for CPU in MachineState::possible_cpus. CPU and node it belongs to is specified by 'props' argument. Patch doesn't remove old way of storing mapping in numa_info[X].node_cpu as removing it at the same time makes patch rather

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

Hi, thanks for marking Qemu(Ubuntu) so I could see it - and thanks for the prework on the patches. We need to clear a few in progress SRUs before that but other than that things look nice. We can work on the patches a bit until that happened. We will need somewhat proper Dep3 headers in [1] the

<    1   2   3   4   >