Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c

2017-05-08 Thread Thomas Huth
On 08.05.2017 22:57, Eduardo Habkost wrote: > There's no reason to keep the soundhw table in arch_init.c. Move > that code to a new hw/audio/soundhw.c file. > > While moving the code, trivial coding style issues were fixed. > > Signed-off-by: Eduardo Habkost > --- > Changes

Re: [Qemu-devel] [PATCH] spapr: Don't accidentally advertise HTM support on POWER9

2017-05-08 Thread Thomas Huth
On 09.05.2017 07:04, David Gibson wrote: > Logic in spapr_populate_pa_features() enables the bit advertising > Hardware Transactional Memory (HTM) in the guest's device tree only when > KVM advertises its availability with the KVM_CAP_PPC_HTM feature. > > However, this assumes that the HTM bit is

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Jason Wang
On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang

Re: [Qemu-devel] [PATCH] Revert "target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce"

2017-05-08 Thread David Gibson
On Tue, May 09, 2017 at 07:25:51AM +1000, Alexey Kardashevskiy wrote: > On 09/05/17 06:17, Jose Ricardo Ziviani wrote: > > This reverts commit 3dc410ae83e6cb76c81ea30a05d62596092b3165. > > > > Booting a radix guest in Power9 with that commit throws a host kernel > > oops: > > > >

Re: [Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub

2017-05-08 Thread Thomas Huth
On 09.05.2017 01:39, Philippe Mathieu-Daudé wrote: > This field is accessed in hw/intc/arm_gicv[23*].c default-configs/arm-softmmu.mak sets CONFIG_PCI, so this should not be necessary, I think. Otherwise, you should extend your patch description, to elaborate on what you're trying to do here.

[Qemu-devel] [PATCH] spapr: Don't accidentally advertise HTM support on POWER9

2017-05-08 Thread David Gibson
Logic in spapr_populate_pa_features() enables the bit advertising Hardware Transactional Memory (HTM) in the guest's device tree only when KVM advertises its availability with the KVM_CAP_PPC_HTM feature. However, this assumes that the HTM bit is off in the base template used for the device tree

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Avoid printing wrong aliases in CPU help text

2017-05-08 Thread Thomas Huth
On 08.03.2017 20:05, Thomas Huth wrote: > When running with KVM, we update the "family" CPU alias to point > to the right host CPU type, so that it is for example possible to > use "-cpu POWER8" on a POWER8NVL host. However, the function for > printing the list of available CPU models is called

Re: [Qemu-devel] [PATCH 0/3] kvm: irqchip: skip msi update when msi disabled

2017-05-08 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH 0/3] kvm: irqchip: skip msi update when msi disabled Type: series Message-id:

Re: [Qemu-devel] [PATCH v3 2/3] audio: Rename audio_init() to soundhw_init()

2017-05-08 Thread Hervé Poussineau
Le 08/05/2017 à 22:57, Eduardo Habkost a écrit : To make it consistent with the remaining soundhw.c functions and avoid confusion with the audio_init() function in audio/audio.c, rename audio_init() to soundhw_init(). Signed-off-by: Eduardo Habkost You should probably

Re: [Qemu-devel] [PATCH] target/ppc: Allow workarounds for POWER9 DD1

2017-05-08 Thread Thomas Huth
On 09.05.2017 05:45, David Gibson wrote: > POWER9 DD1 silicon has some bugs which mean it a) isn't really compliant > with the ISA v3.00 and b) require a number of special workarounds in the > kernel. > > At the moment, qemu isn't aware of DD1. For TCG we don't really want it to > be (why bother

Re: [Qemu-devel] [PATCH v3 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h

2017-05-08 Thread Hervé Poussineau
Le 08/05/2017 à 22:57, Eduardo Habkost a écrit : All the functions in hw/audio/audio.h are called "soundhw_*()" and live in hw/audio/audiohw.c. Rename the header file for consistency. Signed-off-by: Eduardo Habkost Reviewed-by: Hervé Poussineau

[Qemu-devel] timer configure for QEMU versatilepb

2017-05-08 Thread heavybird
Hi Peter and qemu-devel, I am trying to port one simple RTOS to QEMU versatilepb, however, i found the SIC address(actually PIC) is different from the PIC in the integratorcp.c even though they are same arm926, besides, the PIC register bit definition is some different between versatilepb and

[Qemu-devel] [PATCH 3/3] kvm: irqchip: skip update msi when disabled

2017-05-08 Thread Peter Xu
It's possible that one device kept its irqfd/virq there even when MSI/MSIX was disabled globally for that device. One example is virtio-net-pci (see commit f1d0f15a6 and virtio_pci_vq_vector_mask()). It is used as a fast path to avoid allocate/release irqfd/virq frequently when guest

[Qemu-devel] [PATCH 1/3] kvm: irqchip: trace changes on msi add/remove

2017-05-08 Thread Peter Xu
It'll be nice to know which virq belongs to which device/vector when adding msi routes, so adding two more parameters for the add trace. Meanwhile, releasing virq has no tracing before. Add one for it. Signed-off-by: Peter Xu --- kvm-all.c| 4 +++- trace-events | 3 ++-

[Qemu-devel] [PATCH 0/3] kvm: irqchip: skip msi update when msi disabled

2017-05-08 Thread Peter Xu
First two patches are new traces, please collect them if needed. The third patch is a fix to a qemu crash reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1448813 Please see its commit message for more information. Please review. Thanks. Peter Xu (3): kvm: irqchip: trace changes

[Qemu-devel] [PATCH 2/3] msix: trace control bit write op

2017-05-08 Thread Peter Xu
Meanwhile, abstract a function to detect msix masked bit. Signed-off-by: Peter Xu --- hw/pci/msix.c | 11 +-- hw/pci/trace-events | 3 +++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index bb54e8b..fc5fe51

Re: [Qemu-devel] [PATCH v3] aio: add missing aio_notify() to aio_enable_external()

2017-05-08 Thread Fam Zheng
On Mon, 05/08 14:07, Stefan Hajnoczi wrote: > The main loop uses aio_disable_external()/aio_enable_external() to > temporarily disable processing of external AioContext clients like > device emulation. > > This allows monitor commands to quiesce I/O and prevent the guest from > submitting new

Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base

2017-05-08 Thread Fam Zheng
On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: > - install common/basic tools at once > - use eatmydata and remove apt cache to save space > - add bison and flex and git > - create deb-src entry and setup Emdebian in the same layer > > Signed-off-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Zhang Chen
On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add

Re: [Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command

2017-05-08 Thread Fam Zheng
On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 3 ++- > tests/docker/docker.py| 5 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tests/docker/Makefile.include

[Qemu-devel] [PATCH] target/ppc: Allow workarounds for POWER9 DD1

2017-05-08 Thread David Gibson
POWER9 DD1 silicon has some bugs which mean it a) isn't really compliant with the ISA v3.00 and b) require a number of special workarounds in the kernel. At the moment, qemu isn't aware of DD1. For TCG we don't really want it to be (why bother emulating buggy silicon). But with KVM, the guest

Re: [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c

2017-05-08 Thread Eduardo Habkost
On Mon, May 08, 2017 at 03:54:18PM -0700, no-re...@patchew.org wrote: [...] > === OUTPUT BEGIN === > Checking PATCH 1/3: audio: Move arch_init audio code to hw/audio/soundhw.c... > ERROR: suspect code indent for conditional statements (8, 13) > #240: FILE: hw/audio/soundhw.c:76: > +if

Re: [Qemu-devel] [PATCH v3 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h

2017-05-08 Thread David Gibson
On Mon, May 08, 2017 at 05:57:35PM -0300, Eduardo Habkost wrote: > All the functions in hw/audio/audio.h are called "soundhw_*()" > and live in hw/audio/audiohw.c. Rename the header file for > consistency. > > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH v3 2/3] audio: Rename audio_init() to soundhw_init()

2017-05-08 Thread David Gibson
On Mon, May 08, 2017 at 05:57:34PM -0300, Eduardo Habkost wrote: > To make it consistent with the remaining soundhw.c functions and > avoid confusion with the audio_init() function in audio/audio.c, > rename audio_init() to soundhw_init(). > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v3 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c

2017-05-08 Thread David Gibson
On Mon, May 08, 2017 at 05:57:33PM -0300, Eduardo Habkost wrote: > There's no reason to keep the soundhw table in arch_init.c. Move > that code to a new hw/audio/soundhw.c file. > > While moving the code, trivial coding style issues were fixed. > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again

2017-05-08 Thread Jason Wang
On 2017年05月06日 03:36, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again Message-id:

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-05-08 Thread Wei Wang
On 05/09/2017 01:40 AM, Michael S. Tsirkin wrote: On Sun, May 07, 2017 at 04:19:28AM +, Wang, Wei W wrote: On 05/06/2017 06:26 AM, Michael S. Tsirkin wrote: On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: On Wed, Apr 26, 2017 at

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-08 Thread Jason Wang
On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState.

Re: [Qemu-devel] Future of SoftFloat use in QEMU

2017-05-08 Thread Richard Henderson
On 05/08/2017 07:58 AM, Alex Bennée wrote: Hi, We've got a task coming up to implement half-precision floating point (FP16) for ARMv8.2. As you know pretty much all our floating point in QEMU is handled by our internal fork of John R. Hauser's BSD SoftFloat library. Our current implementation

Re: [Qemu-devel] [PATCH v7 13/13] MAINTAINERS: Add vfio-ccw maintainer

2017-05-08 Thread Dong Jia Shi
* Cornelia Huck [2017-05-08 11:09:27 +0200]: > On Mon, 8 May 2017 13:29:27 +0800 > Dong Jia Shi wrote: > > > * Cornelia Huck [2017-05-05 14:20:14 +0200]: > > > > > On Fri, 5 May 2017 04:03:52 +0200 > > > Dong

Re: [Qemu-devel] [PATCH v7 05/13] s390x/css: realize css_create_sch

2017-05-08 Thread Dong Jia Shi
* Cornelia Huck [2017-05-08 12:50:40 +0200]: > On Mon, 8 May 2017 13:18:22 +0800 > Dong Jia Shi wrote: > > > * Cornelia Huck [2017-05-05 14:11:53 +0200]: > > > > > On Fri, 5 May 2017 04:03:44 +0200 > > > Dong

Re: [Qemu-devel] [PATCH v2 0/4] Convert non-blocking connect and fix its error reporting

2017-05-08 Thread Mao Zhongyi
On 05/06/2017 12:39 AM, Daniel P. Berrange wrote: On Wed, Apr 26, 2017 at 04:04:14PM +0800, Mao Zhongyi wrote: v2: * PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report() in the function called by net_socket_*_init() to Error. Also add many error handling

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

2017-05-08 Thread Philippe Mathieu-Daudé
On 05/08/2017 08:56 PM, Eric Blake wrote: On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index

Re: [Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments

2017-05-08 Thread Philippe Mathieu-Daudé
On 05/08/2017 09:00 PM, Eric Blake wrote: On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: invalid since 96df2bc99f9 Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/ldst_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 10/11] register: display register prefix (name) since it is available

2017-05-08 Thread Alistair Francis
On Mon, May 8, 2017 at 4:39 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Thanks, Alistair > --- > hw/core/register.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments

2017-05-08 Thread Eric Blake
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: > invalid since 96df2bc99f9 > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/sparc/ldst_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/sparc/ldst_helper.c

Re: [Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes

2017-05-08 Thread Eric Blake
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: > qemu/include/hw/ide/ahci.h:260:16: error: field ‘sglist’ has incomplete type > QEMUSGList sglist; > ^~ What are you doing to get this compilation error (configure options, platform, compiler, etc)? I can't reproduce

Re: [Qemu-devel] [PATCH v2 6/6] target/s390x: Use atomic operations for LOAD AND OP

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 08:17, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 20 ++-- > target/s390x/translate.c | 78 > +- > 2 files changed, 60 insertions(+), 38 deletions(-)

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

2017-05-08 Thread Eric Blake
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/unimp.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h > index 3462d85836..353ee19abf 100644 >

Re: [Qemu-devel] [PATCH v2 4/6] target/s390x: Implement LOAD PAIR DISJOINT

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 08:17, Richard Henderson wrote: > From: Eric Bischoff > > Signed-off-by: Eric Bischoff > Message-Id: <20170228120134.7921-1-ebisch...@suse.com> > [rth: Combine the two via insn->data; free the address temps.] > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v2 5/6] target/s390x: Use atomic operations for COMPARE SWAP

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 08:17, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 1 + > target/s390x/mem_helper.c | 39 ++ > target/s390x/translate.c | 83 > +-- > 3 files

Re: [Qemu-devel] [PATCH v2 2/6] target/s390x: Implement LOAD PROGRAM PARAMETER

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 08:17, Richard Henderson wrote: > From: Miroslav Benes > > Linux arch/s390/kernel/head(64).S uses LPP instruction if it is > available in facilities list provided by stfl/stfle instruction. > This is the case of newer z/System generations and their qemu >

Re: [Qemu-devel] [PATCH v2 3/6] target/s390x: Diagnose specification exception for atomics

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 08:17, Richard Henderson wrote: > All of the interlocked access facility instructions raise a > specification exception for unaligned accesses. Do this by > using the (previously unused) unaligned_access hook. > > Signed-off-by: Richard Henderson > --- >

Re: [Qemu-devel] [PATCH 05/11] hw/mips: add missing include

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 20:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/mips/mips.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/hw/mips/mips.h b/include/hw/mips/mips.h > index e0065ce808..16412dc150 100644 > ---

[Qemu-devel] [PATCH 10/11] register: display register prefix (name) since it is available

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/core/register.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/core/register.c b/hw/core/register.c index dc335a79a9..b5988c9cc3 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -195,8 +195,8

[Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments

2017-05-08 Thread Philippe Mathieu-Daudé
invalid since 96df2bc99f9 Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/ldst_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 57968d9143..aa83a49a88 100644 ---

[Qemu-devel] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc64/sun4u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d347b6616d..525d6f44a0 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -214,7 +214,7 @@

[Qemu-devel] [PATCH 11/11] MAINTAINERS: self-appoint me as reviewer of the Register API

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index efdec47319..de32165059 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1431,6 +1431,7 @@ T: git git://repo.or.cz/qemu/armbru.git qapi-next

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread G 3
Here is version two of the floating point test program: / ** * File: main.c * Date: 4-30-2017 * Description: Implement a test program for various floating point instructions. * Note: tests made to work

[Qemu-devel] [PATCH 05/11] hw/mips: add missing include

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mips/mips.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/mips/mips.h b/include/hw/mips/mips.h index e0065ce808..16412dc150 100644 --- a/include/hw/mips/mips.h +++ b/include/hw/mips/mips.h @@ -6,6 +6,7 @@

[Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

2017-05-08 Thread Philippe Mathieu-Daudé
"exec/memory.h" already includes it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h index a3f79d3379..b9c11d3fb8 100644 --- a/include/hw/arm/arm.h +++

[Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes

2017-05-08 Thread Philippe Mathieu-Daudé
qemu/include/hw/ide/ahci.h:260:16: error: field ‘sglist’ has incomplete type QEMUSGList sglist; ^~ /qemu/include/hw/ide/ahci.h:272:5: error: unknown type name ‘IDEDMA’ IDEDMA dma; ^~ qemu/include/hw/ide/ahci.h:273:5: error: unknown type name ‘IDEBus’

[Qemu-devel] [PATCH 01/11] hw/net: removed obsolete comments

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/net/pcnet-pci.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 0acf8a4879..bdb533436e 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -38,14 +38,6 @@

[Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub

2017-05-08 Thread Philippe Mathieu-Daudé
This field is accessed in hw/intc/arm_gicv[23*].c Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/pci-stub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index 36d2c430c5..ecad664946 100644 --- a/hw/pci/pci-stub.c +++

[Qemu-devel] [PATCH 00/11] various easy cleanups

2017-05-08 Thread Philippe Mathieu-Daudé
various easy patchs added while coding around: - remove old comments - add/remove includes - use TYPE_ names when available - use ARRAY_SIZE() macro Philippe Mathieu-Daudé (11): hw/net: removed obsolete comments hw/pci: define msi_nonbroken in pci-stub hw/misc: add missing includes

[Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index 3462d85836..353ee19abf 100644 --- a/include/hw/misc/unimp.h +++ b/include/hw/misc/unimp.h @@ -8,6 +8,9

Re: [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c

2017-05-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c Type: series Message-id: 20170508205735.23444-1-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 0/5] 9pfs: local: fix metadata of mapped-file security mode

2017-05-08 Thread Leo Gaspard
Greg, I just tested on 2.9.0 with the 5 patches applied, and it appears to work on my setup, thanks! Just a side note: .virtfs_metadata_root is set as u=rwx on the host file system (the "ret = fchmod(map_fd, 0700);" line in patch 4 I guess), while u=rw would be more appropriate, I think. Thank

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 18:36, G 3 wrote: > > On May 8, 2017, at 6:13 PM, Aurelien Jarno wrote: > > > On 2017-05-07 17:48, G 3 wrote: > > > I made a diagnostic program for the floating point unit. It will test > > > various PowerPC floating point instructions for compatibility with > > > the > > > PowerPC

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread G 3
On May 8, 2017, at 6:13 PM, Aurelien Jarno wrote: On 2017-05-07 17:48, G 3 wrote: I made a diagnostic program for the floating point unit. It will test various PowerPC floating point instructions for compatibility with the PowerPC G3 processor. It was tested on a PowerPC G3 and G5 system.

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 18:09, G 3 wrote: > > On May 8, 2017, at 5:54 PM, Aurelien Jarno wrote: > > > On 2017-05-07 17:48, G 3 wrote: > > > I made a diagnostic program for the floating point unit. It will test > > > various PowerPC floating point instructions for compatibility with > > > the > > > PowerPC

[Qemu-devel] [PATCH v2 21/21] MAINTAINERS: self-appoint me as reviewer in build/test automation

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6d0770fdd0..d61380837a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1827,6 +1827,7 @@

[Qemu-devel] [PATCH v2 17/21] shippable: add armeb-linux-user target

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index fe360f85cb..2070c4d827 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -6,7 +6,7 @@ env: - LC_ALL=C

[Qemu-devel] [PATCH v2 20/21] MAINTAINERS: add Shippable automation platform URL

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index efdec47319..6d0770fdd0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1833,6 +1833,7 @@ F:

[Qemu-devel] [PATCH v2 15/21] shippable: do not initialize submodules automatically

2017-05-08 Thread Philippe Mathieu-Daudé
instead do it in the 'ci' target when needed. for mips64el-softmmu target: use dtc submodule if distrib packages are too old. example with outdated libfdt on mips64el-softmmu target (required is >= 1.4.2): # dpkg-query --showformat='${Version}\n' --show libfdt-dev 1.4.0+dfsg-1 shippable

[Qemu-devel] [PATCH v2 12/21] docker: add powerpc build target

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 2 ++ .../docker/dockerfiles/debian-powerpc-cross.docker | 31 ++ 2 files changed, 33 insertions(+) create mode 100644

[Qemu-devel] [PATCH v2 18/21] shippable: add powerpc target

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 2070c4d827..aad66ec5ec 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -11,6 +11,8 @@ env:

[Qemu-devel] [PATCH v2 14/21] shippable: build using all available cpus

2017-05-08 Thread Philippe Mathieu-Daudé
As of this commit: $ echo "container proc:" `getconf _NPROCESSORS_ONLN` `getconf _NPROCESSORS_CONF` container proc: 2 2 Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml

[Qemu-devel] [PATCH v2 19/21] shippable: add mipsel target

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index aad66ec5ec..75c2895a21 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -13,6 +13,9 @@ env:

[Qemu-devel] [PATCH v2 08/21] docker: add extra libs to armhf target to extend codebase coverage

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-armhf-cross.docker | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker b/tests/docker/dockerfiles/debian-armhf-cross.docker index

[Qemu-devel] [PATCH v2 10/21] docker: add extra libs to s390x target to extend codebase coverage

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-s390x-cross.docker | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker b/tests/docker/dockerfiles/debian-s390x-cross.docker index

[Qemu-devel] [PATCH v2 13/21] shippable: use C locale to simplify console output

2017-05-08 Thread Philippe Mathieu-Daudé
remove this noise: perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = "en_US.UTF-8", LC_CTYPE = "en_US.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. Signed-off-by: Philippe

[Qemu-devel] [PATCH v2 16/21] shippable: be verbose while building docker images

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index 46adfa030f..fe360f85cb 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -13,7 +13,7 @@ env:

[Qemu-devel] [PATCH v2 06/21] docker: compact debian armhf

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-armhf-cross.docker | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker b/tests/docker/dockerfiles/debian-armhf-cross.docker

[Qemu-devel] [PATCH v2 04/21] docker: install ca-certificates package in base image

2017-05-08 Thread Philippe Mathieu-Daudé
Resolve SSL verification issue at shippable container's git_sync stage: shippable logs: -- git_sync - ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu' Identity added: /tmp/ssh/01_deploy (rsa w/o comment)

[Qemu-devel] [PATCH v2 11/21] docker: add mipsel build target

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 3 +++ .../docker/dockerfiles/debian-mipsel-cross.docker | 31 ++ 2 files changed, 34 insertions(+) create mode 100644

[Qemu-devel] [PATCH v2 05/21] docker: compact debian base

2017-05-08 Thread Philippe Mathieu-Daudé
- install common/basic tools at once - use eatmydata and remove apt cache to save space - add bison and flex and git - create deb-src entry and setup Emdebian in the same layer Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian.docker | 26

[Qemu-devel] [PATCH v2 03/21] docker: add 'apt-fake' script which generate fake debian packages

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-apt-fake.sh | 46 + 1 file changed, 46 insertions(+) create mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh diff --git a/tests/docker/dockerfiles/debian-apt-fake.sh

[Qemu-devel] [PATCH v2 09/21] docker: add extra libs to arm64 target to extend codebase coverage

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-arm64-cross.docker | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/tests/docker/dockerfiles/debian-arm64-cross.docker index

[Qemu-devel] [PATCH v2 07/21] docker: compact debian arm64

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-arm64-cross.docker | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/tests/docker/dockerfiles/debian-arm64-cross.docker

[Qemu-devel] [PATCH v2 00/21] docker/shippable: cross-build mipsel and powerpc targets

2017-05-08 Thread Philippe Mathieu-Daudé
This patchset add 2 more architectures to the cross-build farm. There is still some issue trying to cross-build mips64el-softmmu, it seems the cross tools use the system outdated libfdt instead of the one checkouted in the dtc submodule. I disabled this target for now. The branch

[Qemu-devel] [PATCH v2 01/21] docker: let _copy_with_mkdir() sub_path argument be optional

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 8747f6a440..6ddc6e4c2a 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@

[Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command

2017-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 3 ++- tests/docker/docker.py| 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 03eda37bf4..c99ce702ea

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread Aurelien Jarno
On 2017-05-07 17:48, G 3 wrote: > I made a diagnostic program for the floating point unit. It will test > various PowerPC floating point instructions for compatibility with the > PowerPC G3 processor. It was tested on a PowerPC G3 and G5 system. The > results of the program in qemu-system-ppc were

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread G 3
On May 8, 2017, at 5:54 PM, Aurelien Jarno wrote: On 2017-05-07 17:48, G 3 wrote: I made a diagnostic program for the floating point unit. It will test various PowerPC floating point instructions for compatibility with the PowerPC G3 processor. It was tested on a PowerPC G3 and G5 system.

Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Eric Blake
On 05/08/2017 05:00 PM, Stefano Stabellini wrote: >>> Directly calling fcntl(F_SETFD) without first reading fcntl(F_GETFD) is >>> (theoretically) incorrect. Better might be using qemu_set_cloexec() >>> instead of open-coding something. >> >> Makes sense but the unchecked return of fcntl,

Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Stefano Stabellini
On Mon, 8 May 2017, Stefano Stabellini wrote: > On Mon, 8 May 2017, Eric Blake wrote: > > On 05/08/2017 03:45 PM, Stefano Stabellini wrote: > > > Fix two resource leaks on error paths, discovered by Coverity. > > > Check for errors returned by fcntl, also found by Coverity. > > > > > >

Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Stefano Stabellini
On Mon, 8 May 2017, Eric Blake wrote: > On 05/08/2017 03:45 PM, Stefano Stabellini wrote: > > Fix two resource leaks on error paths, discovered by Coverity. > > Check for errors returned by fcntl, also found by Coverity. > > > > CID:1374836 > > CID:1374831 > > > > > @@ -378,7 +380,10 @@ static

Re: [Qemu-devel] Floating point unit bugs

2017-05-08 Thread Aurelien Jarno
On 2017-05-07 17:48, G 3 wrote: > I made a diagnostic program for the floating point unit. It will test > various PowerPC floating point instructions for compatibility with the > PowerPC G3 processor. It was tested on a PowerPC G3 and G5 system. The > results of the program in qemu-system-ppc were

Re: [Qemu-devel] Future of SoftFloat use in QEMU

2017-05-08 Thread Aurelien Jarno
On 2017-05-08 17:58, Thomas Huth wrote: > On 08.05.2017 17:36, Aurelien Jarno wrote: > > Hi, > > > > On 2017-05-08 15:58, Alex Bennée wrote: > >> Hi, > >> > >> We've got a task coming up to implement half-precision floating point > >> (FP16) for ARMv8.2. As you know pretty much all our floating

Re: [Qemu-devel] [PATCH 6/6] prep: add IBM RS/6000 7020 (40p) machine emulation

2017-05-08 Thread Hervé Poussineau
Le 08/05/2017 à 22:49, Eduardo Habkost a écrit : Hi, I stumbled upon this code while working on arch_init.c cleanups: On Thu, Dec 29, 2016 at 11:12:16PM +0100, Hervé Poussineau wrote: [...] +static void ibm_40p_init(MachineState *machine) +{ [...] +/* initialize audio subsystem */ +

Re: [Qemu-devel] [PATCH v6 4/9] qcow2: make refcount size calculation conservative

2017-05-08 Thread Max Reitz
On 08.05.2017 16:15, Stefan Hajnoczi wrote: > The refcount metadata size calculation is inaccurate and can produce > numbers that are too small. This is bad because we should calculate a > conservative number - one that is guaranteed to be large enough. > > This patch switches the approach to a

Re: [Qemu-devel] [PATCH] Revert "target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce"

2017-05-08 Thread Alexey Kardashevskiy
On 09/05/17 06:17, Jose Ricardo Ziviani wrote: > This reverts commit 3dc410ae83e6cb76c81ea30a05d62596092b3165. > > Booting a radix guest in Power9 with that commit throws a host kernel > oops: > > [17582052553.360178] Unable to handle kernel paging request for data at > address

[Qemu-devel] [PATCH v7 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

2017-05-08 Thread Eric Blake
Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() was already able to give different output to stderr based on whether a shutdown was triggered by a host

[Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-08 Thread Eric Blake
Time to wire up all the call sites that request a shutdown or reset to use the enum added in the previous patch. It would have been less churn to keep the common case with no arguments as meaning guest-triggered, and only modified the host-triggered code paths, via a wrapper function, but then

[Qemu-devel] [PATCH v7 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-05-08 Thread Eric Blake
We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

[Qemu-devel] [PATCH v7 4/5] shutdown: Preserve shutdown cause through replay

2017-05-08 Thread Eric Blake
With the recent addition of ShutdownCause, we want to be able to pass a cause through any shutdown request, and then faithfully replay that cause when later replaying the same sequence. The easiest way is to expand the reply event mechanism to track a series of values for EVENT_SHUTDOWN, one

[Qemu-devel] [PATCH v7 0/5] event: Add source information to SHUTDOWN

2017-05-08 Thread Eric Blake
v6 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01380.html Since then: - another simplification to qemu_system_reset() - minor tweaks suggested by Markus 001/5:[] [--] 'shutdown: Simplify shutdown_signal' 002/5:[0038] [FC] 'shutdown: Prepare for use of an enum in

[Qemu-devel] [PATCH v7 1/5] shutdown: Simplify shutdown_signal

2017-05-08 Thread Eric Blake
There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] migration/block: optimize the performance by coalescing the same write type

2017-05-08 Thread Stefan Hajnoczi
On Mon, Apr 24, 2017 at 09:55:40PM +0800, jemmy858...@gmail.com wrote: > From: Lidong Chen > > This patch optimizes the performance by coalescing the same write type. > When the zero/non-zero state changes, perform the write for the accumulated > cluster count. > >

  1   2   3   4   >