[Qemu-devel] [PATCH v5 4/5] iotests: add more LUKS hash combination tests

Add tests for sha224, sha512, sha384 and ripemd160 hash algorithms. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/149 | 10 +- tests/qemu-iotests/149.out | 482 - 2 files

[Qemu-devel] [PATCH v5 1/5] iotests: skip 159 & 170 with luks format

While the qemu-img dd command does accept --image-opts this is not sufficient to make it work with the LUKS image yet. This is because bdrv_create() still always requires the non-image-opts syntax. Thus we must skip 159/170 with luks for now Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v5 0/5] Improve I/O tests coverage of LUKS

The main goal of this series is to get the I/O tests passing 100% with LUKS when run with './check -luks'. It also adds a few more combinations to the LUKS/dmcrypt interoperability test. To make LUKS testing not quite as slow, we drop the PBKDF iteration count down to a very small value. This

Re: [Qemu-devel] [PATCH 09/10] s390x/css: turn on channel subsystem migration

On 05/08/2017 08:37 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 07:27 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: Turn on migration for the channel subsystem and the new scheme for

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

On 05/09/2017 12:20 PM, Philippe Mathieu-Daudé wrote: > What about the other include, "hw/sysbus.h"? > The inlined function create_unimplemented_device() calls > sysbus_mmio_map_overlap(). Anyone willing to use "hw/misc/unimp.h" will > get a compilation failure if he does not include

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

Hi Eric, On 05/08/2017 09:56 PM, Philippe Mathieu-Daudé wrote: On 05/08/2017 08:56 PM, Eric Blake wrote: On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Qemu-devel] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume

On Mon, May 08, 2017 at 04:13:05PM +0200, Paolo Bonzini wrote: > Outside blockjob.c, the block_job_iostatus_reset function is used once > in the monitor and once in BlockBackend. When we introduce the block > job mutex, block_job_iostatus_reset's client is going to be the block > layer (for which

Re: [Qemu-devel] [PATCH 05/11] blockjob: separate monitor and blockjob APIs

On Mon, May 08, 2017 at 04:13:04PM +0200, Paolo Bonzini wrote: > We have two different headers for block job operations, blockjob.h > and blockjob_int.h. The former contains APIs called by the monitor, > the latter contains APIs called by the block job drivers and the > block layer itself. > >

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/08/2017 06:55 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> Let us use the freshly introduced vmstate migration helpers instead of >> saving/loading the config manually. >> >> To achieve this we need to hack the config_vector which is a common >>

Re: [Qemu-devel] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all

On Mon, May 08, 2017 at 04:13:03PM +0200, Paolo Bonzini wrote: > Remove use of block_job_pause/resume from outside blockjob.c, thus > making them static. The new functions are used by the block layer, > so place them in blockjob_int.h. > > Reviewed-by: Stefan Hajnoczi >

[Qemu-devel] [Qemu-devel PATCH 4/5] msf2: Add Smartfusion2 SoC.

Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 2 +-

Re: [Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub

Hi Thomas, On 05/09/2017 02:19 AM, Thomas Huth wrote: On 09.05.2017 01:39, Philippe Mathieu-Daudé wrote: This field is accessed in hw/intc/arm_gicv[23*].c default-configs/arm-softmmu.mak sets CONFIG_PCI, so this should not be necessary, I think. Otherwise, you should extend your patch

[Qemu-devel] [Qemu-devel PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep --- hw/arm/Makefile.objs | 1 + hw/arm/msf2-som.c| 67 2 files changed, 68 insertions(+) create mode 100644

[Qemu-devel] [Qemu-devel PATCH 3/5] msf2: Add Smartfusion2 SPI controller

Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep --- hw/ssi/Makefile.objs | 1 + hw/ssi/msf2-spi.c | 378 ++ include/hw/ssi/msf2-spi.h | 105 + 3 files changed, 484

[Qemu-devel] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion2 System timer

Modelled System Timer in Microsemi's Smartfusion2 Soc. Timer has two 32bit down counters and two interrupts. Signed-off-by: Subbaraya Sundeep --- hw/timer/Makefile.objs| 1 + hw/timer/msf2-timer.c | 252 ++

[Qemu-devel] [Qemu-devel PATCH 0/5] Add support for Smartfusion2 SoC

Hi Qemu-devel, I am trying to add Smartfusion2 SoC. SoC is from Microsemi and System on Module(SOM) board is from Emcraft systems. Smartfusion2 has hardened Microcontroller(Cortex-M3)based Sub System and FPGA fabric. At the moment only system timer, sysreg and SPI controller are modelled.

[Qemu-devel] [Qemu-devel PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block.

Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep --- hw/misc/Makefile.objs | 1 + hw/misc/msf2-sysreg.c | 131 ++

Re: [Qemu-devel] [PATCH 03/11] blockjob: introduce block_job_early_fail

On Mon, May 08, 2017 at 04:13:02PM +0200, Paolo Bonzini wrote: > Outside blockjob.c, block_job_unref is only used when a block job fails > to start, and block_job_ref is not used at all. The reference counting > thus is pretty well hidden. Introduce a separate function to be used > by block

Re: [Qemu-devel] [PATCH v2 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

On 05/09/2017 08:17 AM, Aurelien Jarno wrote: Ok, thanks for the detailed explanations. Then I guess you should fold the following patch to correctly set the zArch active bit as done in s390_fill_feat_block: --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -693,6 +693,11 @@

Re: [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback

On Mon, May 08, 2017 at 04:13:01PM +0200, Paolo Bonzini wrote: > This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus", > 2016-05-19). > > Reviewed-by: Stefan Hajnoczi > Reviewed-by: John Snow > Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check

On Mon, May 08, 2017 at 04:13:00PM +0200, Paolo Bonzini wrote: > !job is always checked prior to the call, drop it from here. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > blockjob.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 0/4] curl: locking cleanups and fixes

On Tue, May 09, 2017 at 12:03:30PM -0400, Jeff Cody wrote: > On Tue, May 09, 2017 at 11:15:06AM +0100, Richard W.M. Jones wrote: > > > > No I'm afraid this patch series does not fix the bug. > > > > The stack trace is below. > > > > Rich. > > > > I'm looking through qemu-defel, and I'm not

Re: [Qemu-devel] [PATCH 0/4] curl: locking cleanups and fixes

On 09/05/2017 18:03, Jeff Cody wrote: > On Tue, May 09, 2017 at 11:15:06AM +0100, Richard W.M. Jones wrote: >> >> No I'm afraid this patch series does not fix the bug. >> >> The stack trace is below. >> >> Rich. >> > > I'm looking through qemu-defel, and I'm not finding a reference to the bug >

Re: [Qemu-devel] [PATCH 0/4] curl: locking cleanups and fixes

On Tue, May 09, 2017 at 11:15:06AM +0100, Richard W.M. Jones wrote: > > No I'm afraid this patch series does not fix the bug. > > The stack trace is below. > > Rich. > I'm looking through qemu-defel, and I'm not finding a reference to the bug mentioned. Maybe I'm just missing it... can you

Re: [Qemu-devel] [Qemu-block] [PATCH v4] migration/block: move bdrv_is_allocated() into bb's AioContext

On 08/05/2017 22:54, Stefan Hajnoczi wrote: > On Fri, May 05, 2017 at 04:03:49PM +0800, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> when block migration with high-speed, mig_save_device_bulk hold the >> BQL and invoke bdrv_is_allocated frequently. This patch

Re: [Qemu-devel] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping

On Mon, 8 May 2017 15:40:04 +1000 David Gibson wrote: > On Wed, May 03, 2017 at 02:57:17PM +0200, Igor Mammedov wrote: > > legacy cpu to node mapping is using cpu index values to map > > VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' > > option.

Re: [Qemu-devel] Strange location of the "qemu-ga Invocation" chapter in the qemu-doc

On 09/05/2017 16:29, Thomas Huth wrote: > Hi all, > > I noticed that the "qemu-ga Invocation" chapter in the QEMU doc is in a > strange location - it's a sub-chapter of the "Disk images" chapter. > Since the guest agent is not directly related to the handling of disk > images, that sounds

[Qemu-devel] [Bug 1689499] Re: copy-storage-all/inc does not easily converge with load going on

Ok, I found an hour to set up a test environment. I already had all the bisect script written until the systems were ready, but unfortunately it is not reproducible enough with my build from git as of today's master - out of 8 tries it showed as less of a slowdown once, and never to the hours

[Qemu-devel] [Bug 1689499] Re: copy-storage-all/inc does not easily converge with load going on

I'm "incompleting" myself until I was able to provide more :-/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1689499 Title: copy-storage-all/inc does not easily converge with load going on Status

Re: [Qemu-devel] [PULL 0/8] pci, virtio, vhost: fixes

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/8] pci, virtio, vhost: fixes Type: series Message-id: 1494330527-24163-1-git-send-email-...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [Qemu-block] [PATCH] block: curl: Allow passing cookies via QCryptoSecret

On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote: > Since cookies can contain sensitive data (session ID, etc ...) it is > desired to hide them from the prying eyes of users. Add a possibility to > pass them via the secret infrastructure. > > Resolves:

Re: [Qemu-devel] [PATCH v6 1/9] block: add bdrv_measure() API

On Mon, May 08, 2017 at 09:50:06AM -0500, Eric Blake wrote: > On 05/08/2017 09:15 AM, Stefan Hajnoczi wrote: > > bdrv_measure() provides a conservative maximum for the size of a new > > image. This information is handy if storage needs to be allocated (e.g. > > a SAN or an LVM volume) ahead of

Re: [Qemu-devel] [PATCH v6 4/9] qcow2: make refcount size calculation conservative

On Mon, May 08, 2017 at 11:26:18PM +0200, Max Reitz wrote: > On 08.05.2017 16:15, Stefan Hajnoczi wrote: > > The refcount metadata size calculation is inaccurate and can produce > > numbers that are too small. This is bad because we should calculate a > > conservative number - one that is

Re: [Qemu-devel] [PATCH v2] nvme: Implement Write Zeroes

Am 09.05.2017 um 17:09 hat Keith Busch geschrieben: > On Tue, May 09, 2017 at 05:01:04PM +0200, Kevin Wolf wrote: > > Am 05.05.2017 um 11:58 hat Christoph Hellwig geschrieben: > > > Signed-off-by: Keith Busch > > > [hch: ported over from qemu-nvme.git to mainline] > > >

Re: [Qemu-devel] [PATCH v3 1/1] qemu-img: wait for convert coroutines to complete

Am 26.04.2017 um 10:33 hat Anton Nefedov geschrieben: > On error path (like i/o error in one of the coroutines), it's required to > - wait for coroutines completion before cleaning the common structures > - reenter dependent coroutines so they ever finish > > Introduced in 2d9187bc65. > >

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

On Tue, May 09, 2017 at 10:40:34AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, May 08, 2017 at 12:08:07PM +0300, Alexey wrote: > > > On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote: > > > > On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey

Re: [Qemu-devel] [PATCH v4 0/5] Improve I/O tests coverage of LUKS

Am 02.05.2017 um 17:54 hat Daniel P. Berrange geschrieben: > The main goal of this series is to get the I/O tests passing > 100% with LUKS when run with './check -luks'. It also adds a > few more combinations to the LUKS/dmcrypt interoperability > test. > > To make LUKS testing not quite as slow,

Re: [Qemu-devel] [PATCH v2 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

On 2017-05-09 07:51, Richard Henderson wrote: > On 05/09/2017 01:14 AM, Aurelien Jarno wrote: > > > +/* The maximum bit defined at the moment is 129. */ > > > +#define MAX_STFL_WORDS 3 > > > > Could it be computed from S390_FEAT_MAX? in gen-features.c, > > S390_FEAT_MAX / 64 + 1 is used. > >

Re: [Qemu-devel] [PATCH v3] aio: add missing aio_notify() to aio_enable_external()

On Mon, May 08, 2017 at 02:07:05PM -0400, Stefan Hajnoczi wrote: > The main loop uses aio_disable_external()/aio_enable_external() to > temporarily disable processing of external AioContext clients like > device emulation. > > This allows monitor commands to quiesce I/O and prevent the guest from

Re: [Qemu-devel] [PATCH v2 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

On 05/09/2017 07:51 AM, Richard Henderson wrote: I'm pleased to see this appears to have been dropped at some point; I cannot see it present in linux 4.11. However, this still applies to the kernels supplied by the shipping distributions. More accurately, it has been moved to

Re: [Qemu-devel] [Qemu-block] [PATCH] block: curl: Allow passing cookies via QCryptoSecret

Am 04.05.2017 um 16:00 hat Peter Krempa geschrieben: > Since cookies can contain sensitive data (session ID, etc ...) it is > desired to hide them from the prying eyes of users. Add a possibility to > pass them via the secret infrastructure. > > Resolves:

Re: [Qemu-devel] [PATCH v7 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

Eric Blake writes: > On 05/09/2017 07:07 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Libvirt would like to be able to distinguish between a SHUTDOWN >>> event triggered solely by guest request and one triggered by a >>> SIGTERM or other

Re: [Qemu-devel] [PATCH v2] nvme: Implement Write Zeroes

On Tue, May 09, 2017 at 05:01:04PM +0200, Kevin Wolf wrote: > Am 05.05.2017 um 11:58 hat Christoph Hellwig geschrieben: > > Signed-off-by: Keith Busch > > [hch: ported over from qemu-nvme.git to mainline] > > Signed-off-by: Christoph Hellwig > > Keith, can

Re: [Qemu-devel] [PATCH v2] nvme: Implement Write Zeroes

Am 05.05.2017 um 11:58 hat Christoph Hellwig geschrieben: > Signed-off-by: Keith Busch > [hch: ported over from qemu-nvme.git to mainline] > Signed-off-by: Christoph Hellwig Keith, can you give an Acked-by for this one? (I see that the code is originally from

Re: [Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images

Am 04.05.2017 um 18:52 hat Kevin Wolf geschrieben: > Fam's image locking series introduced some special-casing in the file-posix > driver that avoids taking locks when the image is inactive. While this works, > it really isn't the job of the file-posix driver, but the core block layer > should

Re: [Qemu-devel] [PATCH v2 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

On 05/09/2017 01:14 AM, Aurelien Jarno wrote: +/* The maximum bit defined at the moment is 129. */ +#define MAX_STFL_WORDS 3 Could it be computed from S390_FEAT_MAX? in gen-features.c, S390_FEAT_MAX / 64 + 1 is used. No, because the features list in cpu_features_def.h bears no relation to

Re: [Qemu-devel] [PATCH v5 2/3] utils: provide size_to_str()

Peter Xu writes: > I stole the algorithm from print_type_size(). I didn't generalize it > since that's using [KM...]iB while here we need [KM...]B to finally > be able to stands for page sizes (and even more general). Can you explain why we need units without the 'i' here? >

Re: [Qemu-devel] migration: add incremental drive-mirror and blockdev-mirror with dirtymap

On 05/09/2017 03:35 AM, Daniel Kučera wrote: > > > Hm, I suppose that's right, pending cache issues, perhaps? > > (1) Write occurs; cached > (2) Bitmap is added > (3) Write occurs, cached > (4) ZFS snapshot is taken > (5) Data is flushed to backing storage. > >

Re: [Qemu-devel] [Qemu-block] [PATCH v4] migration/block: move bdrv_is_allocated() into bb's AioContext

On Tue, May 09, 2017 at 08:59:30PM +0800, 858585 jemmy wrote: > On Tue, May 9, 2017 at 4:54 AM, Stefan Hajnoczi wrote: > > On Fri, May 05, 2017 at 04:03:49PM +0800, jemmy858...@gmail.com wrote: > >> From: Lidong Chen > >> > >> when block migration with

Re: [Qemu-devel] [PATCH] block: Simplify BDRV_BLOCK_RAW recursion

On Thu, May 04, 2017 at 12:37:45PM -0500, Eric Blake wrote: > Since we are already in coroutine context during the body of > bdrv_co_get_block_status(), we can shave off a few layers of > wrappers when recursing to query the protocol when a format driver > returned BDRV_BLOCK_RAW. > > Note that

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

Resending because first send didn't get through to some recipients... Eric Blake writes: > Time to wire up all the call sites that request a shutdown or > reset to use the enum added in the previous patch. > > It would have been less churn to keep the common case with no >

Re: [Qemu-devel] [PATCH 1/3] target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK

On Tue, 9 May 2017 10:27:58 +0200 Aurelien Jarno wrote: > For that move the definition from kvm.c to cpu.h > > Signed-off-by: Aurelien Jarno > --- > target/s390x/cpu.h | 3 +++ > target/s390x/kvm.c | 2 -- >

[Qemu-devel] Strange location of the "qemu-ga Invocation" chapter in the qemu-doc

Hi all, I noticed that the "qemu-ga Invocation" chapter in the QEMU doc is in a strange location - it's a sub-chapter of the "Disk images" chapter. Since the guest agent is not directly related to the handling of disk images, that sounds somewhat wrong to me - or do I miss something? Does

Re: [Qemu-devel] [PATCH] vhost-user: fix watcher need be removed when vhost-user hotplug

On Tue, May 9, 2017 at 5:04 PM Yunjian Wang wrote: > From: w00273186 > > "nc" is freed after hotplug vhost-user, but the watcher don't be removed. > > The QEMU crash when the watcher access the "nc" on socket disconnect. > > Do you have a

Re: [Qemu-devel] [PATCH v7 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

On 05/09/2017 07:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Libvirt would like to be able to distinguish between a SHUTDOWN >> event triggered solely by guest request and one triggered by a >> SIGTERM or other action on the host. While qemu_kill_report() was >>

Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

On Tue, May 9, 2017 at 4:02 PM, Gerd Hoffmann wrote: > Hi, > >> #4 cpu_physical_memory_snapshot_get_dirty (snap=0x56a3b3d0, >> start=2148532224, length=511) > > https://patchwork.ozlabs.org/patch/760013/ Awesome, thanks! > cheers, > Gerd

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

On 05/09/2017 07:13 AM, Richard W.M. Jones wrote: On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: Daniel P. Berrange (2): i386: rewrite way CPUID index is validated i386: expose "TCGTCGTCGTCG" in the 0x4000 CPUID leaf I probably should have commented earlier

Re: [Qemu-devel] [PATCH 3/3] target/s390x: implement serialization in BRANCH CONDITION

On 05/09/2017 01:28 AM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index c58c27f8e9..2f07ce2be9 100644 ---

Re: [Qemu-devel] [PATCH 1/3] target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK

On 05/09/2017 01:27 AM, Aurelien Jarno wrote: For that move the definition from kvm.c to cpu.h Signed-off-by: Aurelien Jarno --- target/s390x/cpu.h | 3 +++ target/s390x/kvm.c | 2 -- target/s390x/misc_helper.c | 3 +-- 3 files changed, 4

Re: [Qemu-devel] [PATCH 2/3] target/s390x: fix SIGNAL PROCESSOR return value

On 05/09/2017 01:27 AM, Aurelien Jarno wrote: The SIGNAL PROCESSOR helper returns its value through the CC register. set_cc_static should be called just after the helper. Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 0/2] docs: Minor updates around ide-drive

On 05/09/2017 05:41 AM, Markus Armbruster wrote: > Markus Armbruster (2): > docs qemu-doc: Avoid ide-drive, it's deprecated > docs/qdev-device-use.txt: update section Default Devices > > docs/bootindex.txt | 2 +- > docs/qdev-device-use.txt | 13 +++-- > qemu-options.hx

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: > On 05/09/2017 06:27 AM, Daniel P. Berrange wrote: > >This enables report of a signature in CPUID for the TCG > >interpretor. > > > >Changed in v4: > > > > - Report 0x4001 in EAX for 0x4000 index (Eduardo) > > - Report

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: > On 05/09/2017 06:27 AM, Daniel P. Berrange wrote: > > This enables report of a signature in CPUID for the TCG > > interpretor. > > > > Changed in v4: > > > > - Report 0x4001 in EAX for 0x4000 index (Eduardo) > > -

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

On 05/09/2017 06:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Time to wire up all the call sites that request a shutdown or >> reset to use the enum added in the previous patch. >> >> It would have been less churn to keep the common case with no >> arguments as

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

On 05/09/2017 06:27 AM, Daniel P. Berrange wrote: This enables report of a signature in CPUID for the TCG interpretor. Changed in v4: - Report 0x4001 in EAX for 0x4000 index (Eduardo) - Report all zeros for 0x4001 index (Eduardo) - Make code style consistent when checking

Re: [Qemu-devel] [PATCH v6 13/18] qcow2: add support for LUKS encryption format

On Wed, Apr 26, 2017 at 12:46:18PM -0500, Eric Blake wrote: > On 04/25/2017 10:38 AM, Daniel P. Berrange wrote: > > This adds support for using LUKS as an encryption format > > with the qcow2 file, using the new encrypt.format parameter > > to request "luks" format. e.g. > > > > # qemu-img

[Qemu-devel] [PATCH] vhost-user: fix watcher need be removed when vhost-user hotplug

From: w00273186 "nc" is freed after hotplug vhost-user, but the watcher don't be removed. The QEMU crash when the watcher access the "nc" on socket disconnect. Call Trace: #0 object_get_class (obj=obj@entry=0x2) at qom/object.c:751 #1 0x7fc031c79f41 in

Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

Hi, > #4 cpu_physical_memory_snapshot_get_dirty (snap=0x56a3b3d0, > start=2148532224, length=511) https://patchwork.ozlabs.org/patch/760013/ cheers, Gerd

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

On May 9, 2017, at 5:55 AM, BALATON Zoltan wrote: On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] | if ((fpscr >> i) & 0x1 == 1) { |

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

On Mon, 8 May 2017 16:19:51 -0500 Eric Blake wrote: > Time to wire up all the call sites that request a shutdown or > reset to use the enum added in the previous patch. > > It would have been less churn to keep the common case with no > arguments as meaning guest-triggered,

Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events

On 09/05/2017 15:50, Alex Bennée wrote: >> No, it doesn't. I would make the trace event take const char * and pass >> in the string. > It would be nice to avoid having the string for non-trace builds. It can help with gdb as well (e.g. having gdb printers that print the name of a mutex), and

Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events

Stefan Hajnoczi writes: > On Fri, May 05, 2017 at 04:59:58PM +0100, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >> > On 05/05/2017 12:38, Alex Bennée wrote: >> >> Signed-off-by: Alex Bennée >> > >> > Can you look at the

[Qemu-devel] [PULL v1 4/4] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs

From: Geert Martin Ijewski If no crypto library is included in the build, QEMU uses qcrypto_random_bytes() to generate random data. That function tried to open /dev/urandom or /dev/random and if opening both files failed it errored out. Those files obviously do not exist on

Re: [Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes

On 05/08/2017 07:58 PM, Eric Blake wrote: > On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: >> qemu/include/hw/ide/ahci.h:260:16: error: field ‘sglist’ has incomplete type >> QEMUSGList sglist; >> ^~ > > What are you doing to get this compilation error (configure

[Qemu-devel] [PULL v1 2/4] List SASL config file under the cryptography maintainer's realm

No one is listed as maintainer for qemu.sasl. It is used by the VNC server for SASL auth, but since it is cryptography related, list it under the crytography maintainer's realm, rather than under the UI maintainer. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL v1 0/4] Merge qcrypto 2017/05/07

The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d: Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request' into staging (2017-05-05 17:07:55 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2017-05-09-1

[Qemu-devel] [PULL v1 3/4] crypto: move 'opaque' parameter to (nearly) the end of parameter list

Previous commit moved 'opaque' to be the 2nd parameter in the list: commit 375092332eeaa6e47561ce47fd36144cdaf964d0 Author: Fam Zheng Date: Fri Apr 21 20:27:02 2017 +0800 crypto: Make errp the last parameter of functions Move opaque to 2nd instead of the 2nd to

[Qemu-devel] [PULL v1 1/4] Default to GSSAPI (Kerberos) instead of DIGEST-MD5 for SASL

RFC 6331 documents a number of serious security weaknesses in the SASL DIGEST-MD5 mechanism. As such, QEMU should not be using or recommending it as a default mechanism for VNC auth with SASL. GSSAPI (Kerberos) is the only other viable SASL mechanism that can provide secure session encryption so

[Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

Change the nested if statements into a flat format, to make it clearer what validation / capping is being performed on different CPUID index values. NB this changes behaviour when "index > env->cpuid_xlevel2". This won't have any guest-visible effect because no there is no CPUID[0xC001]

[Qemu-devel] [PATCH v4 2/2] i386: expose "TCGTCGTCGTCG" in the 0x40000000 CPUID leaf

Currently when running KVM, we expose "KVMKVMKVM\0\0\0" in the 0x4000 CPUID leaf. Other hypervisors (VMWare, HyperV, Xen, BHyve) all do the same thing, which leaves TCG as the odd one out. The CPUID signature is used by software to detect which virtual environment they are running in and

[Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

This enables report of a signature in CPUID for the TCG interpretor. Changed in v4: - Report 0x4001 in EAX for 0x4000 index (Eduardo) - Report all zeros for 0x4001 index (Eduardo) - Make code style consistent when checking limits (Eduardo) Changed in v3: - Simplify CPU limit

[Qemu-devel] [PULL 3/8] hw/virtio: fix vhost user fails to startup when MQ

From: Zhiyong Yang Qemu2.7~2.9 and vhost user for dpdk 17.02 release work together to cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK

[Qemu-devel] [PULL 2/8] hw/arm/virt: generate 64-bit addressable ACPI objects

From: Ard Biesheuvel Our current ACPI table generation code limits the placement of ACPI tables to 32-bit addressable memory, in order to be able to emit the root pointer (RSDP) and root table (RSDT) using table types from the ACPI 1.0 days. Since ARM was not

[Qemu-devel] [PULL 6/8] pc: add 2.10 machine type

From: Peter Xu CC: "Michael S. Tsirkin" CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost Signed-off-by: Peter Xu Reviewed-by: Eduardo Habkost

[Qemu-devel] [PULL 8/8] ACPI: don't call acpi_pcihp_device_plug_cb on xen

From: Bruce Rogers Commit f0c9d64a exposed the issue that with a xenfv machine using pci passthrough, acpi pci hotplug code was being executed by mistake. Guard calls to acpi_pcihp_device_plug_cb (and corresponding acpi_pcihp_device_unplug_cb) with a check for xen_enabled().

[Qemu-devel] [PULL 4/8] libvhost-user: fix crash when rings aren't ready

From: Marc-André Lureau Calling libvhost-user functions like vu_queue_get_avail_bytes() when the queue doesn't yet have addresses will result in the crashes like the following: Program received signal SIGSEGV, Segmentation fault. 0x55c414112ce4 in

[Qemu-devel] [PULL 0/8] pci, virtio, vhost: fixes

The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d: Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request' into staging (2017-05-05 17:07:55 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 7/8] iommu: Don't crash if machine is not PC_MACHINE

From: Eduardo Habkost Currently it's possible to crash QEMU using "-device *-iommu" and "-machine none": $ qemu-system-x86_64 -machine none -device amd-iommu qemu/hw/i386/amd_iommu.c:1140:amdvi_realize: Object 0x55627dafbc90 is not an instance of type

[Qemu-devel] [PULL 5/8] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

From: Igor Mammedov Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) regressed migration during firmware exection time by abusing fwcfg.dma_enabled property to decide loading dma version of option rom AND by mistake disabling DMA for 2.6 and

[Qemu-devel] [PULL 1/8] hw/acpi-defs: replace leading X with x_ in FADT field names

From: Ard Biesheuvel At the request of Michael, replace the leading capital X in the FADT field name Xfacs and Xdsdt with lower case x + underscore. Cc: Michael S. Tsirkin Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo

Re: [Qemu-devel] [PATCH v2 07/24] pc: add node-id property to CPU

On Fri, 5 May 2017 17:29:23 -0300 Eduardo Habkost wrote: > On Wed, May 03, 2017 at 02:57:01PM +0200, Igor Mammedov wrote: > > it will allow switching from cpu_index to property based > > numa mapping in follow up patches. > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [Qemu-block] [PATCH v4] migration/block: move bdrv_is_allocated() into bb's AioContext

On Tue, May 9, 2017 at 4:54 AM, Stefan Hajnoczi wrote: > On Fri, May 05, 2017 at 04:03:49PM +0800, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> when block migration with high-speed, mig_save_device_bulk hold the >> BQL and invoke

Re: [Qemu-devel] [PATCH 09/13] char: generalize qemu_chr_write_all()

Hi Marc-André, On 05/09/2017 08:33 AM, Marc-André Lureau wrote: qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write all with a chardev backend. Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all' argument. If false, handle 'partial' write the way

Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

Hi Gerd, On Fri, Apr 21, 2017 at 11:16 AM, Gerd Hoffmann wrote: > The vga code clears the dirty bits *after* reading the framebuffer > memory. So if the guest framebuffer updates hits the race window > between vga reading the framebuffer and vga clearing the dirty bits > vga

Re: [Qemu-devel] [PATCH 01/13] char-win: simplify win_chr_read()

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: win_chr_read_poll() is always used before win_chr_read(). We can easily fold win_chr_readfile() too. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-win.h

Re: [Qemu-devel] KVM call for 2017-05-09

Juan Quintela wrote: > Hi As there are no topics, call is cancelled. Later, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After

[Qemu-devel] KVM call for 2017-05-23

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details:

Re: [Qemu-devel] [PATCH 03/13] char-win: rename win_chr_init/poll win_chr_serial_init/poll

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: Those 2 functions are specific to serial chardev, make it more clear. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-win.h| 2 +-

Re: [Qemu-devel] [PATCH 12/13] char: rename functions that are not part of fe

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: There is no clear reason to have those functions associated with frontend. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char.c | 15 +++ 1 file

Re: [Qemu-devel] [PATCH 04/13] char-win: rename hcom->file

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: hcom is the name of the file handle, regardless of the actual chardev driver (serial, file, console etc..). Rename it to be more explicit. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé

<    1   2   3   4   >