Re: [Qemu-devel] [PATCH v3 3/3] migration: Remove section_id parameter from vmstate_load

On Wed, May 31, 2017 at 12:39:25PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > Everything else assumes that we always load a device from its own > > savevm handler. > > Except for the title (it's the version_id you're removing not > section_id) but now

Re: [Qemu-devel] [Qemu-ppc] [PATCHv4 3/5] pseries: Move CPU compatibility property to machine

On Fri, 2017-05-26 at 15:23 +1000, David Gibson wrote: > Server class POWER CPUs have a "compat" property, which is used to > set the > backwards compatibility mode for the processor.  However, this only > makes > sense for machine types which don't give the guest access to > hypervisor >

Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

On Wed, May 31, 2017 at 11:25:41PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2017-05-31 23:06:46) > > On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote: > > > The code managing DRCs[0] has quite a few things that are more > > > complicated than they need to be. In particular

Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory.

Wed, May 31, 2017 at 02:54:05PM +0200, Paolo Bonzini wrote: > > > On 31/05/2017 08:28, Yang Zhong wrote: > > Move the tcg related files into tcg/ subdirectory, which will make > > the code more clean in qemu. Next step, we will base on those changes > > to disable tcg. > > You should also

Re: [Qemu-devel] [PATCH v4 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

On Wed, May 31, 2017 at 04:56:44PM +0530, Bharata B Rao wrote: > Add a "no HPT" encoding (using value -1) to the HTAB migration > stream (in the place of HPT size) when the guest doesn't allocate HPT. > This will help the target side to match target HPT with the source HPT > and thus enable

Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

On Thu, Jun 01, 2017 at 09:36:46AM +0530, Bharata B Rao wrote: > On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote: > > The code managing DRCs[0] has quite a few things that are more > > complicated than they need to be. In particular the object > > representing a DRC has a bunch of

Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

Quoting Bharata B Rao (2017-05-31 23:06:46) > On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote: > > The code managing DRCs[0] has quite a few things that are more > > complicated than they need to be. In particular the object > > representing a DRC has a bunch of method pointers,

Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote: > The code managing DRCs[0] has quite a few things that are more > complicated than they need to be. In particular the object > representing a DRC has a bunch of method pointers, despite the fact > that there are currently no

Re: [Qemu-devel] [PATCH] edu: fix memory leak on msi_broken platforms

On Wed, May 31, 2017 at 02:57:46PM +0200, Paolo Bonzini wrote: > If msi_init fails, the thread has already been created and the > mutex/condvar are not destroyed. Initialize everything only > after the point where pci_edu_realize cannot fail. > > Reported-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 0/2] Edu leak fix series

On Wed, May 31, 2017 at 02:55:59PM +0200, Paolo Bonzini wrote: > > > On 31/05/2017 11:50, Peter Xu wrote: > > On Wed, May 31, 2017 at 05:42:34PM +0800, Peter Xu wrote: > >> A whitelist for it does not really makes sense. Let's remove it and > >> then we can introduce a blacklist when really

[Qemu-devel] [PATCH v2] migration: isolate return path on src

There are some places that binded "return path" with postcopy. Let's be prepared for its usage even without postcopy. This patch mainly did this on source side. Signed-off-by: Peter Xu --- v2 - s/s->to_dst_file/s->rp_state.from_dst_file/, also add some comment for it [Dave]

Re: [Qemu-devel] [PATCH] pci: Fix unreasonable return value check

Hi, Markus On 05/31/2017 07:07 PM, Markus Armbruster wrote: This is cleanup, not a bug fix, so: pci: Clean up error checking in pci_add_capability() Mao Zhongyi writes: The return value of pci_add_capability2() is only 2 cases, positive on success, nagetive

Re: [Qemu-devel] [RFC 0/6] Refine IGD stolen memory support in VFIO

> From: Wang, Zhi A > Sent: Tuesday, May 30, 2017 1:31 AM > > This patch series are aim to refine the IGD stolen memory support in QEMU. > > Some features of Intel HW relies on the stolen memory to work, but some of > registers used to indicate the base address of stolen memory can only be >

Re: [Qemu-devel] [PATCH] migration: isolate return path on src

On Wed, May 31, 2017 at 08:33:01PM +0200, Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: > > * Peter Xu (pet...@redhat.com) wrote: > >> There are some places that binded "return path" with postcopy. Let's be > >> prepared for its usage even without postcopy. This

[Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into spapr_drc.c

Currently implementations of the RTAS calls related to DRCs are in spapr_rtas.c. They belong better in spapr_drc.c - that way they're closer to related code, and we'll be able to make some more things local. spapr_rtas.c was intended to contain the RTAS infrastructure and core calls that don't

[Qemu-devel] [PATCH 2/4] spapr: Abolish DRC get_fdt method

The DRConnectorClass includes a get_fdt method. However * There's only one implementation, and there's only likely to ever be one * Both callers are local to spapr_drc * Each caller only uses one half of the actual implementation So abolish get_fdt() entirely, and just open-code what we

[Qemu-devel] [PATCH 4/4] spapr: Make DRC get_index and get_type methods into plain functions

These two methods only have one implementation, and the spec they're implementing means any other implementation is unlikely, verging on impossible. So replace them with simple functions. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 13 +++---

[Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

The code managing DRCs[0] has quite a few things that are more complicated than they need to be. In particular the object representing a DRC has a bunch of method pointers, despite the fact that there are currently no subclasses, and even if there were the method implementations would be unlikely

[Qemu-devel] [PATCH 3/4] spapr: Abolish DRC set_configured method

DRConnectorClass has a set_configured method, however: * There is only one implementation, and only ever likely to be one * There's exactly one caller, and that's (now) local * The implementation is very straightforward So abolish the method entirely, and just open-code what we need. We

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 05/30/2017 04:17 AM, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 05/19/2017 07:02 PM, John Snow wrote: > > > On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: >> It will be needed in following commits for persistent bitmaps. >> If bitmap is loaded from read-only storage (and we can't mark it >> "in use" in this storage) corresponding

[Qemu-devel] [PATCH v3 19/30] target/s390x: fix adj_len_to_page

adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 2 +- 1 file changed,

Re: [Qemu-devel] [RFC 0/6] Refine IGD stolen memory support in VFIO

Ping. -Original Message- From: Qemu-devel [mailto:qemu-devel-bounces+zhi.a.wang=intel@nongnu.org] On Behalf Of Zhi Wang Sent: Monday, May 29, 2017 4:29 PM To: qemu-devel@nongnu.org Cc: Tian, Kevin ; daniel.vet...@ffwll.ch; joonas.lahti...@linux.intel.com;

[Qemu-devel] [PATCH v3 03/30] target/s390x: implement local-TLB-clearing in IPTE

And at the same time make IPTE SMP aware. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 21 +

[Qemu-devel] [PATCH v3 10/30] target/s390x: implement MOVE INVERSE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 8 4 files changed, 23

[Qemu-devel] [PATCH v3 05/30] target/s390x: implement TEST ADDRESSING MODE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PATCH v3 08/30] target/s390x: implement STORE PAIR TO QUADWORD

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 6 ++ 4 files changed, 21 insertions(+) diff --git a/target/s390x/helper.h

[Qemu-devel] [PATCH v3 12/30] target/s390x: implement MOVE WITH OFFSET

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/mem_helper.c | 31 +++ target/s390x/translate.c | 8 4 files

[Qemu-devel] [PATCH v3 09/30] target/s390x: implement COMPARE AND SIGNAL

These functions differ from COMPARE by generating an exception for a QNaN input. Use the non quiet version of floatXX_compare. Signed-off-by: Aurelien Jarno --- target/s390x/fpu_helper.c | 27 +++ target/s390x/helper.h | 3 +++

[Qemu-devel] [PATCH v3 07/30] target/s390x: implement LOAD PAIR FROM QUADWORD

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 7 +++ 4 files changed, 23 insertions(+) diff --git a/target/s390x/helper.h

[Qemu-devel] [PATCH v3 06/30] target/s390x: implement PACK

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 5 + target/s390x/mem_helper.c | 37 + target/s390x/translate.c | 8 4

[Qemu-devel] [PATCH v3 17/30] target/s390x: fix COMPARE LOGICAL LONG EXTENDED

There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after reaching the end of this operand. These values

[Qemu-devel] [PATCH v3 20/30] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno

[Qemu-devel] [PATCH v3 11/30] target/s390x: implement MOVE NUMERICS

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 8 4 files changed, 24

[Qemu-devel] [PATCH v3 14/30] target/s390x: improve 24-bit and 31-bit addresses read

Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function. Rename get_address_31fix into get_address.

[Qemu-devel] [PATCH v3 13/30] target/s390x: implement MOVE ZONES

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 8 4 files changed, 24

[Qemu-devel] [PATCH v3 00/30] target/s390x: fix, improve and implement some more instructions

This patchset tries to improve the s390x emulation by fixing and improving some instructions. It implement some more instructions, from the zArchitecture base or from the Extended-Translation Facility 2. The last patch updates the maximum TCG CPU to z800, as the ETF2 and Long-Displacement Facility

[Qemu-devel] [PATCH v3 01/30] target/s390x: remove dead code in translate.c

Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/s390x/translate.c

[Qemu-devel] [PATCH v3 02/30] target/s390x: remove some Linux assumptions from IPTE

Signed-off-by: Aurelien Jarno --- target/s390x/cpu.h| 2 ++ target/s390x/mem_helper.c | 17 ++--- target/s390x/mmu_helper.c | 2 -- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index

[Qemu-devel] [PATCH v3 23/30] target/s390x: implement PACK ASCII

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 35 +++ target/s390x/translate.c | 16

[Qemu-devel] [PATCH v3 18/30] target/s390x: implement COMPARE LOGICAL LONG

As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 +

[Qemu-devel] [PATCH v3 30/30] target/s390x: update maximum TCG model to z800

At the same time fix the TCG version of get_max_cpu_model to return the maximum model like on KVM. Remove the ETF2 and long-displacement facilities from the additional features as it is included in the z800. Signed-off-by: Aurelien Jarno --- target/s390x/cpu_models.c | 13

[Qemu-devel] [PATCH v3 26/30] target/s390x: implement UNPACK UNICODE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 49 -- target/s390x/translate.c | 18

[Qemu-devel] [PATCH v3 21/30] target/s390x: implement COMPARE LOGICAL LONG UNICODE

For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno ---

[Qemu-devel] [PATCH v3 04/30] target/s390x: implement TEST AND SET

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PATCH v3 15/30] target/s390x: improve 24-bit and 31-bit addresses write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v3 16/30] target/s390x: improve 24-bit and 31-bit lengths read/write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 47 +-- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v3 28/30] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 9 + target/s390x/mem_helper.c | 45 + target/s390x/translate.c | 30 ++ 4 files changed, 85

[Qemu-devel] [PATCH v3 27/30] target/s390x: implement TEST DECIMAL

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 3 +++ target/s390x/mem_helper.c | 23 +++ target/s390x/translate.c | 9 + 4 files changed,

[Qemu-devel] [PATCH v3 22/30] target/s390x: implement MOVE LONG UNICODE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 47 -- target/s390x/translate.c | 21

[Qemu-devel] [PATCH v3 29/30] target/s390x: mark ETF2 and ETF2-ENH facilities as available

Signed-off-by: Aurelien Jarno --- target/s390x/cpu_models.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index e5e005a430..fc3cb25cc3 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@

[Qemu-devel] [PATCH v3 24/30] target/s390x: implement PACK UNICODE

Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++

[Qemu-devel] [PATCH v3 25/30] target/s390x: implement UNPACK ASCII

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 51 ++ target/s390x/translate.c | 17

Re: [Qemu-devel] Doubts about Kvm architecture

On 05/31/2017 11:56 AM, Maurício Almeida wrote: > The Traffic of Virtio was 956 MB/s while e1000 Emulated Driver was 192 > MB/s, both using Packet size of 1518 Bytes. The quick answer - yes, that's the expected results, because paravirt is SOOO much more direct than fully-emulated. Everything

[Qemu-devel] [Bug 1694808] [NEW] Passthrough USB Host Keyboard doesn't work on Q35 platform on boot-up

Public bug reported: Using qemu-kvm as shipped with Ubuntu 16.04, I cannot get a passed- through USB Host Keyboard to work at boot-up using the Q35 platform. My minimal example to verify this bug is the following: qemu-system-x86_64 -M q35 -m 128 -cdrom mini.iso -usb -usbdevice host:04ca:005a

Re: [Qemu-devel] Doubts about Kvm architecture

On Wed, 2017-05-31 at 14:09 -0300, Maurício Almeida wrote: > My name is Maurício, we are making a study about Kvm Paravirtualized > and Full virtualized at our University, we are from University Federal > of Santa Maria. > Can you give us some papers about how the Kvm or Qemu executes the I/O >

[Qemu-devel] Doubts about Kvm architecture

Hello Guys! My name is Maurício, we are making a study about Kvm Paravirtualized and Full virtualized at our University, we are from University Federal of Santa Maria. Can you give us some papers about how the Kvm or Qemu executes the I/O Network with one emulated Device? We executed some tests

Re: [Qemu-devel] [PATCH 06/11] nbd: make it thread-safe

On 05/31/2017 04:43 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/nbd-client.c | 30 +- > 1 file changed, 9 insertions(+), 21 deletions(-) > > diff --git a/block/nbd-client.c b/block/nbd-client.c > index

Re: [Qemu-devel] [PATCH v3] gluster: add support for PREALLOC_MODE_FALLOC

On Sun, May 28, 2017 at 12:01:14PM +0530, Niels de Vos wrote: > Add missing support for "preallocation=falloc" to the Gluster block > driver. This change bases its logic on that of block/file-posix.c and > removed the gluster_supports_zerofill() and qemu_gluster_zerofill() > functions in favour of

Re: [Qemu-devel] [PATCH 05/11] vvfat: make it thread-safe

On 05/31/2017 04:43 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/vvfat.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [PATCH 04/11] vpc: make it thread-safe

On 05/31/2017 04:43 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/vpc.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > @@ -705,10 +700,13 @@ static int64_t coroutine_fn > vpc_co_get_block_status(BlockDriverState

Re: [Qemu-devel] [PATCH 03/11] vdi: make it thread-safe

On 05/31/2017 04:43 AM, Paolo Bonzini wrote: > The VirtualBox driver is using a mutex to order all allocating writes, > but it is not protecting accesses to the bitmap because they implicitly > happen under the AioContext mutex. Change this to use a CoRwlock > explicitly. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 02/11] coroutine-lock: add qemu_co_rwlock_downgrade and qemu_co_rwlock_upgrade

On 05/31/2017 04:43 AM, Paolo Bonzini wrote: > These functions are more efficient in the presence of contention. > qemu_co_rwlock_downgrade also guarantees not to block, which may > be useful in some algorithms too. > > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170531135709.345-1-marcandre.lur...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] ide-test: check return of fwrite

On Wed, May 31, 2017 at 03:28:36PM -0400, John Snow wrote: > To quiet patchew, add an assert for fwrite's return value. > > Signed-off-by: John Snow > --- > tests/ide-test.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tests/ide-test.c

[Qemu-devel] [PATCH v1 0/2] s390x cpu model improvements for KVM

We should properly forward the CPUID format bit. CPU model detection on systems without IBC might select a model with a wrong CPU type (esp. selecting the business class (BC) model on an enterprise class (EC) machine). So let's improve that, too. I am also preparing a patch to properly indicate

[Qemu-devel] [PATCH v1 1/2] s390x/cpumodel: take care of the cpuid format bit for KVM

Let's also properly forward that bit. It should always be set. I verified it under z/VM, it seems to be always set there. For now, zKVM guests never get that bit set when the CPU model is active. The PoP mentiones, that z800 + z900 (HW generation 7) always set this bit to 0, so let's take care of

[Qemu-devel] [PATCH v1 2/2] s390x/cpumodel: improve defintion search without an IBC

Currently, under z/VM on a 0x2827, QEMU will detect a 0x2828 if no IBC value is provided. QEMU will simply take the last model of that HW generation, which happens to be the BC version. Let's improve our search for that case by selecting the latest CPU definition that matches the CPU type. This

[Qemu-devel] [PATCH] ide-test: check return of fwrite

To quiet patchew, add an assert for fwrite's return value. Signed-off-by: John Snow --- tests/ide-test.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 139ebc0..bfd79dd 100644 --- a/tests/ide-test.c +++

Re: [Qemu-devel] [PATCH V6 07/10] migration: add bitmap for copied page

* Peter Xu (pet...@redhat.com) wrote: > On Thu, May 25, 2017 at 09:28:57AM +0300, Alexey Perevalov wrote: > > On 05/25/2017 02:30 AM, Peter Xu wrote: > > >On Wed, May 24, 2017 at 03:16:23PM +0300, Alexey Perevalov wrote: > > >>On 05/24/2017 03:01 PM, Peter Xu wrote: > > >>>On Wed, May 24, 2017 at

Re: [Qemu-devel] [PATCH v3 09/13] test-char: add hotswap test

Hi On Tue, May 30, 2017 at 6:15 PM Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > tests/test-char.c | 68 > +++ > 1 file changed, 68 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v3 08/13] test-char: split char_file_test

On Tue, May 30, 2017 at 6:15 PM Anton Nefedov wrote: > makes it possible to test the existing chardev-file > > Signed-off-by: Anton Nefedov > --- > tests/test-char.c | 127 > +- > 1

Re: [Qemu-devel] [PATCH v3 07/13] test-char: split char_udp_test

On Tue, May 30, 2017 at 6:02 PM Anton Nefedov wrote: > makes it possible to test the existing chardev-udp > > Signed-off-by: Anton Nefedov > Reviewed-by: Marc-André Lureau > --- > tests/test-char.c | 58 >

Re: [Qemu-devel] [PATCH v3 05/13] char: avoid chardevice direct access

On Tue, May 30, 2017 at 5:59 PM Anton Nefedov wrote: > frontends should avoid accessing CharDriver struct where possible > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy >

Re: [Qemu-devel] [PATCH v3 06/13] test-char: unref chardev-udp after test

On Tue, May 30, 2017 at 6:06 PM Anton Nefedov wrote: > this is only not a problem if the test is last in a suite, > otherwise it makes the following main_loop() calls to fail > > Signed-off-by: Anton Nefedov > Reviewed-by: Marc-André

Re: [Qemu-devel] [PATCH v3 04/13] char: forbid direct chardevice access for hotswap devices

On Tue, May 30, 2017 at 6:13 PM Anton Nefedov wrote: > qemu_chr_fe_get_driver() is unsafe, frontends with hotswap support > should not access CharDriver ptr directly as CharDriver might change. > > Signed-off-by: Anton Nefedov >

Re: [Qemu-devel] [PATCH v3 03/13] char: chardevice hotswap

Hi On Tue, May 30, 2017 at 6:12 PM Anton Nefedov wrote: > This patch adds a possibility to change a char device without a frontend > removal. > > 1. Ideally, it would have to happen transparently to a frontend, i.e. > frontend would continue its regular operation. >

Re: [Qemu-devel] [PATCH v3 01/13] char: move QemuOpts->ChardevBackend translation to a separate func

On Tue, May 30, 2017 at 6:09 PM Anton Nefedov wrote: > parse function will be used by the following patch > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Marc-André

Re: [Qemu-devel] [PATCH V6 04/10] migration: split ufd_version_check onto receive/request features part

* Alexey Perevalov (a.pereva...@samsung.com) wrote: > On 05/24/2017 02:33 PM, Peter Xu wrote: > > On Wed, May 24, 2017 at 09:45:48AM +0300, Alexey wrote: > > > > [...] > > > > > > > return false; > > > > > } > > > > > -ioctl_mask = (__u64)1 << _UFFDIO_REGISTER | > > > > > -

Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory.

On 31/05/2017 18:24, Laurent Desnogues wrote: > All source files have an explicit BSD license except tcg-runtime.h > which has none and aarch64 files which are licensed under GPL. So we > are already not following the rule expressed in LICENSE. > > tcg-runtime.c is BSD > tci.c is GPL >

Re: [Qemu-devel] [PATCH v2 4/7] s390x/css: add missing css state conditionally

Halil Pasic wrote: > Although we have recently vmstatified the migration of some css > infrastructure, for some css entities there is still state to be > migrated left, because the focus was keeping migration stream > compatibility (that is basically everything as-is).

Re: [Qemu-devel] [PATCH 03/12] nbd/server: get rid of nbd_negotiate_read and friends

On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: > Functions nbd_negotiate_{read,write,drop_sync} were introduced in > 1a6245a5b, when nbd_rwv (was nbd_wr_sync) was working through > qemu_co_sendv_recvv (the path is nbd_wr_sync -> qemu_co_{recv/send} -> > qemu_co_send_recv ->

Re: [Qemu-devel] [PATCH 02/12] nbd: make nbd_drop public

On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: > Following commit will reuse it for nbd server too. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 26 -- > nbd/common.c | 26

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename > nbd_wr_syncv -> nbd_rwv > read_sync -> nbd_read > read_sync_eof -> nbd_read_eof > write_sync -> nbd_write > drop_sync -> nbd_drop > > 1. nbd_ prefix >read_sync and write_sync are already shared, so it is good to

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: don't fail on vCont; C04:0; c packets

On Wed, 31 May 2017 19:40:46 +0200 Claudio Imbrenda wrote: > On Wed, 31 May 2017 19:06:29 +0200 > Greg Kurz wrote: > > > On Wed, 31 May 2017 18:51:06 +0200 > > Claudio Imbrenda wrote: > > [...] > > > > > > > > > >

Re: [Qemu-devel] [PATCH] migration: isolate return path on src

"Dr. David Alan Gilbert" wrote: > * Peter Xu (pet...@redhat.com) wrote: >> There are some places that binded "return path" with postcopy. Let's be >> prepared for its usage even without postcopy. This patch mainly did this >> on source side. >> >> Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: don't fail on vCont; C04:0; c packets

Claudio Imbrenda writes: > On Wed, 31 May 2017 19:06:29 +0200 > Greg Kurz wrote: > >> On Wed, 31 May 2017 18:51:06 +0200 >> Claudio Imbrenda wrote: >> [...] >> > > > >> > > > This is strange. cpu_index() is defined as:

Re: [Qemu-devel] [PATCH 1/1] s390x: vmstatify config migration for virtio-ccw

Halil Pasic wrote: > Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for > flexibility (extending using subsections) and for fun. > > To achieve this we need to hack the config_vector, which is VirtIODevice > (that is common virtio) state, in the middle

Re: [Qemu-devel] [PATCH V6 02/10] migration: pass MigrationIncomingState* into migration check functions

* Alexey Perevalov (a.pereva...@samsung.com) wrote: > That tiny refactoring is necessary to be able to set > UFFD_FEATURE_THREAD_ID while requesting features, and then > to create downtime context in case when kernel supports it. > > Signed-off-by: Alexey Perevalov > ---

Re: [Qemu-devel] [PATCH v2 3/3] scripts: Test script to look for -device crashes

On Mon, May 29, 2017 at 11:25:03AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > On Tue, May 23, 2017 at 04:52:47PM +0200, Markus Armbruster wrote: [...] > >> > +ERROR_WHITELIST = [ > >> > + # Machines that won't work out of the box: > >> > + #

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: don't fail on vCont; C04:0; c packets

On Wed, 31 May 2017 19:06:29 +0200 Greg Kurz wrote: > On Wed, 31 May 2017 18:51:06 +0200 > Claudio Imbrenda wrote: > [...] > > > > > > > > This is strange. cpu_index() is defined as: > > > > > > > > static inline int cpu_index(CPUState *cpu) > > >

Re: [Qemu-devel] [PATCH 0/2] Add reduce image for qcow2

On 31.05.2017 19:10, Richard W.M. Jones wrote: On Wed, May 31, 2017 at 06:54:33PM +0300, Pavel Butsykin wrote: It is assumed that the user has already made a preparatory with the image: 1. freeing space at the end of the image 2. reducing the last partition on the disk 3. rebuilding fs Only

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: don't fail on vCont; C04:0; c packets

Claudio Imbrenda writes: > On Wed, 31 May 2017 18:33:24 +0200 > Greg Kurz wrote: > >> On Wed, 31 May 2017 18:17:37 +0200 >> Claudio Imbrenda wrote: >> >> > On Wed, 31 May 2017 16:09:33 +0100 >> > Alex Bennée

[Qemu-devel] [PULL 3/4] tests/qapi-schema: Avoid 'str' in alternate test cases

The next commit is going to make alternate members of type 'str' conflict with other scalar types. Would break a few test cases that don't actually require 'str'. Flip them from 'str' to 'bool' or 'EnumOne'. Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [PULL 1/4] qobject-input-visitor: Reject non-finite numbers with keyval

The QObject input visitor can produce only finite numbers when its input comes out of the JSON parser, because the the JSON parser implements RFC 7159, which provides no syntax for infinity and NaN. However, it can produce infinity and NaN when its input comes out of keyval_parse(), because we

[Qemu-devel] [PULL 4/4] qapi: Reject alternates that can't work with keyval_parse()

Alternates are sum types like unions, but use the JSON type on the wire / QType in QObject instead of an explicit tag. That's why we require alternate members to have distinct QTypes. The recently introduced keyval_parse() (commit d454dbe) can only produce string scalars. The

[Qemu-devel] [PULL 2/4] qapi: Document visit_type_any() issues with keyval input

It's already documented in keyval.c (commit 0ee9ae7), but visitor.h can use a note, too. Signed-off-by: Markus Armbruster Message-Id: <1495471335-23707-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: don't fail on vCont; C04:0; c packets

On Wed, 31 May 2017 18:51:06 +0200 Claudio Imbrenda wrote: [...] > > > > > > This is strange. cpu_index() is defined as: > > > > > > static inline int cpu_index(CPUState *cpu) > > > { > > > #if defined(CONFIG_USER_ONLY) > > > return cpu->host_tid; > > > #else >

Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: add checks for cmdline-created objects

Markus Armbruster writes: > "Dr. David Alan Gilbert" writes: > >> I notice this pair of patches doesn't seem to have gone anywhere. >> WHile it's labelled as a monitor fix, it's all QOM stuff, so I don't >> think it should be going via me. > > It's

Re: [Qemu-devel] [PATCH] migration: isolate return path on src

* Peter Xu (pet...@redhat.com) wrote: > There are some places that binded "return path" with postcopy. Let's be > prepared for its usage even without postcopy. This patch mainly did this > on source side. > > Signed-off-by: Peter Xu > --- > standalone patch isolated from the

  1   2   3   4   5   >