[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1662050 Title: qemu-img

Re: [Qemu-devel] call flow to hit get_pci_config_device() during live migration

On 06/09/2017 02:00 PM, Chris Friesen wrote: I think what I end up with is that byte 0x20 (ie 32) of the PCI config for the virtio-blk device is 0 in the data coming over the wire, and 0xC in the local copy. Since cmask is 0xff we need to check all the bits in the byte, and both wmask and

Re: [Qemu-devel] [RFC DEBUG PATCH 3/3] translate-a64: fix lookup_tb_ptr hang (DEBUG!)

On 06/09/2017 10:01 AM, Alex Bennée wrote: THIS IS A DEBUG PATCH DO NOT MERGE I include all the comments to show my working. I was trying to isolate which instructions cause the problem. It turns out it is the RET instruction. I don't understand why because AFAICT it is a pretty much a BR

Re: [Qemu-devel] [PATCH v2 1/2] target/s390x: specification exceptions are suppressing

On 06/09/2017 06:34 AM, David Hildenbrand wrote: The PSW in the old PSW has to point at the next instruction, as specification exceptions are defined to be "suppressing or completed", but not nullified. Signed-off-by: David Hildenbrand --- target/s390x/helper.c | 2 +- 1

Re: [Qemu-devel] [PATCH v2 2/2] s390x/cpumodel: wire up cpu type + id for TCG

On 06/09/2017 06:34 AM, David Hildenbrand wrote: Let's properly expose the CPU type (machine-type number) via "STORE CPU ID" and "STORE SUBSYSTEM INFORMATION". As TCG emulates basic mode, the CPU identification number has the format "An", whereby A is the CPU address, and n are parts of the

Re: [Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

On 06/09/2017 01:04 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Ensure the format strings are always preprocessed, so any problem get reported. Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed review feedback from Alex Bennée No

Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

On 06/09/2017 10:06 AM, Philippe Mathieu-Daudé wrote: > inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > > v2: Addressed review feedback from Eric Blake > > include/hw/misc/unimp.h | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

I intended to send those 3 patches as separate since unrelated, but failed again, sorry :S On 06/09/2017 12:06 PM, Philippe Mathieu-Daudé wrote: inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed

Re: [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

On 05/23/2017 11:58 AM, Michael Tokarev wrote: 09.05.2017 02:39, Philippe Mathieu-Daudé wrote: "exec/memory.h" already includes it. I think this sort of include cleanups isn't really necessary. Some are useful ;) For a regular include file, it's better to include it if the .c file in

Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.e0862272629975a2a7296103cf5d5f8de70abc01.1497035841.git-series.knut.om...@oracle.com Subject: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of

Re: [Qemu-devel] [RFC DEBUG PATCH 0/3] debug patch for lookup-ptr hang

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170609170100.3599-1-alex.ben...@linaro.org Type: series Subject: [Qemu-devel] [RFC DEBUG PATCH 0/3] debug patch for lookup-ptr hang === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: cover.e0862272629975a2a7296103cf5d5f8de70abc01.1497035841.git-series.knut.om...@oracle.com Subject: [Qemu-devel]

Re: [Qemu-devel] [PATCH v1 0/2] PGM injection fix/rework

On 06/09/2017 07:21 AM, David Hildenbrand wrote: We have various places where we inject suppressing PGM exceptions, but don't forward the PSW. Let's fix that by detecting whether to forward the PSW using the interception code. We can now get rid of ILEN_LATER/ILEN_LATER_INC and replace it by

Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate

On Fri, Jun 09, 2017 at 12:58:17 -0700, Richard Henderson wrote: > >>=== OUTPUT BEGIN === > >>Checking PATCH 1/7: util: add cacheinfo... > >>ERROR: do not initialise globals to 0 or NULL > >>#149: FILE: util/cacheinfo.c:11: > >>+int qemu_icache_linesize = 0; > >> > >>ERROR: do not initialise

Re: [Qemu-devel] [PATCH] q35/mch: implement extended TSEG sizes

On Fri, 2017-06-09 at 13:40 +0200, Paolo Bonzini wrote: > > On 08/06/2017 21:55, Michael S. Tsirkin wrote: > > We don't have room anywhere in PCI config space. Laszlo makes > > argument > > why it's safe for this device based on spec but it's anyone's guess > > whether current and future software

Re: [Qemu-devel] call flow to hit get_pci_config_device() during live migration

On 06/09/2017 09:42 AM, Chris Friesen wrote: Hi, I'm investigating an issue seen over a live migration from a modified qemu-kvm-ev-2.3.0-31.el7_2.7.1 to a modified qemu-kvm-ev-2.6.0-28.el7_3.9.1. We hit an issue down in get_pci_config_device() that caused the migration to fail. The qemu logs

Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate

On 06/09/2017 12:52 PM, Emilio G. Cota wrote: On Thu, Jun 08, 2017 at 22:37:12 -0700, Richard Henderson wrote: This is a follow-up to Emilio's patch set. My primary changes to Emilio's patches are to the first patch, in merging the existing implementations from tcg/ppc/tcg-target.inc.c into

[Qemu-devel] [PATCH] translate-all: consolidate tb init in tb_gen_code

We are partially initializing tb in tb_alloc. Instead, fully initialize it in tb_gen_code, which is tb_alloc's only caller. This saves an unnecessary write to tb->cflags. Signed-off-by: Emilio G. Cota --- translate-all.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate

On Thu, Jun 08, 2017 at 22:37:12 -0700, Richard Henderson wrote: > This is a follow-up to Emilio's patch set. > > My primary changes to Emilio's patches are to the first patch, in > merging the existing implementations from tcg/ppc/tcg-target.inc.c > into util/cacheinfo.c. > > Then I've a few

Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

On 06/09/2017 02:19 PM, Knut Omang wrote: > This series contains: > * a unit test that exposes a race condition which causes QEMU to fail > to find a port even when there is plenty of available ports. > * a refactor of the qemu-sockets inet_listen_saddr() function > to better handle this

Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: cover.e0862272629975a2a7296103cf5d5f8de70abc01.1497035841.git-series.knut.om...@oracle.com Subject: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s

[Qemu-devel] [PATCH 2/2] socket: Handle race condition between binds to the same port

If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid a failure. This

[Qemu-devel] [PATCH 1/2] Add test-listen - a stress test for QEMU socket listen

There's a potential race condition between multiple bind()'s attempting to bind to the same port, which occasionally allows more than one bind to succeed against the same port. When a subsequent listen() call is made with the same socket only one will succeed. The current QEMU code does however

[Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

This series contains: * a unit test that exposes a race condition which causes QEMU to fail to find a port even when there is plenty of available ports. * a refactor of the qemu-sockets inet_listen_saddr() function to better handle this situation. Thanks, Knut Knut Omang (2): Add

Re: [Qemu-devel] [PATCH] q35/mch: implement extended TSEG sizes

On 06/09/17 02:19, Michael S. Tsirkin wrote: > On Fri, Jun 09, 2017 at 01:01:54AM +0200, Laszlo Ersek wrote: >> On 06/08/17 21:55, Michael S. Tsirkin wrote: >>> On Thu, Jun 08, 2017 at 09:48:53PM +0200, Gerd Hoffmann wrote: Hi, > I really dislike negotiation being re-invented for

Re: [Qemu-devel] [PATCH v2 3/6] migration: move global_state.optional out

Eduardo Habkost wrote: D> On Fri, Jun 09, 2017 at 11:48:59AM +0800, Peter Xu wrote: >> Put it into MigrationState then we can use the properties to specify >> whether to enable storing global state. >> >> Removing global_state_set_optional() since now we can use

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

Markus Armbruster wrote: > Test compile gripes: > > hw/xen/xen-common.c: In function ‘xen_init’: > hw/xen/xen-common.c:147:5: warning: implicit declaration of function > ‘register_compat_prop’ [-Wimplicit-function-declaration] >

[Qemu-devel] [PATCH] vfio: Test realized when using VFIOGroup.device_list iterator

VFIOGroup.device_list is effectively our reference tracking mechanism such that we can teardown a group when all of the device references are removed. However, we also use this list from our machine reset handler for processing resets that affect multiple devices. Generally device removals are

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

On 06/09/2017 10:55 AM, Kevin Wolf wrote: >> >> These belong in comments in the test proper, because it is not obvious >> otherwise. But with comments added (so someone debugging a theoretical >> test failure down the road knows what they are up against), > > # Note that the reference output

[Qemu-devel] [RFC DEBUG PATCH 3/3] translate-a64: fix lookup_tb_ptr hang (DEBUG!)

THIS IS A DEBUG PATCH DO NOT MERGE I include all the comments to show my working. I was trying to isolate which instructions cause the problem. It turns out it is the RET instruction. I don't understand why because AFAICT it is a pretty much a BR instruction. Signed-off-by: Alex Bennée

[Qemu-devel] [RFC DEBUG PATCH 2/3] tcg-runtime: light re-factor of lookup_tb_ptr

Just a little precursor re-factoring before I was going to add a trace point: - single return point, defaulting to tcg_ctx.code_gen_epilogue - move cs_base, pc and flags inside the jump cache hit scope - calculate the tb_jmp_cache hash once Signed-off-by: Alex Bennée

[Qemu-devel] [RFC DEBUG PATCH 1/3] vl: Fix broken thread=xxx option of the --accel parameter

From: Thomas Huth Commit bde4d9205 ("Fix the -accel parameter and the documentation for 'hax'") introduced a regression by adding a new local accel_opts variable which shadows the variable with the same name that is declared at the beginning of the main() scope. This causes the

[Qemu-devel] [RFC DEBUG PATCH 0/3] debug patch for lookup-ptr hang

Hi, These are debug patches only but represent how much I have narrowed down the problem so far. I've included Thomas' patch to fix the thread=single|multi option as that is currently broken upstream. So far it seems though the problem is unrelated to multi-threading. As discussed in the other

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

On Fri, Jun 09, 2017 at 03:42:41PM +0200, Alberto Garcia wrote: Hey Manos, thanks for your proposal and for the good work :) On Thu 08 Jun 2017 08:21:13 PM CEST, Manos Pitsidianakis wrote: As part of my GSoC project, IO throttling is moved to a block filter driver, which means multiple filter

Re: [Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

Philippe Mathieu-Daudé writes: > Ensure the format strings are always preprocessed, so any problem get > reported. > > Signed-off-by: Philippe Mathieu-Daudé > --- > > v2: Addressed review feedback from Alex Bennée > No changes in *printf() calls but using

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

Am 09.06.2017 um 16:16 hat Eric Blake geschrieben: > On 06/09/2017 07:58 AM, Kevin Wolf wrote: > > Am 09.06.2017 um 14:14 hat Eric Blake geschrieben: > >> On 06/09/2017 06:50 AM, Kevin Wolf wrote: > >>> When qemu is exited, all running jobs should be cancelled successfully. > >>> This adds a test

[Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Allow save/restore

We change the restoration priority of both the GICv3 and ITS. The GICv3 must be restored before the ITS and the ITS needs to be restored before PCIe devices since it translates their MSI transactions. Signed-off-by: Eric Auger Reviewed-by: Juan Quintela

Re: [Qemu-devel] [RFC v5 2/4] hw/intc/arm_gicv3_its: Implement state save/restore

Hi Shannon, On 09/06/2017 03:28, Shannon Zhao wrote: > > > On 2017/4/14 20:46, Eric Auger wrote: > [...] >> @@ -43,6 +50,7 @@ struct GICv3ITSState { >> >> /* Registers */ >> uint32_t ctlr; >> +uint32_t iidr; > I think this should reset in gicv3_its_common_reset Done. Thanks!

[Qemu-devel] [PATCH v6 2/4] hw/intc/arm_gicv3_its: Implement state save/restore

We need to handle both registers and ITS tables. While register handling is standard, ITS table handling is more challenging since the kernel API is devised so that the tables are flushed into guest RAM and not in vmstate buffers. Flushing the ITS tables on device pre_save() is too late since the

[Qemu-devel] [PATCH v6 3/4] hw/intc/arm_gicv3_kvm: Implement pending table save

This patch adds the flush of the LPI pending bits into the redistributor pending tables. This happens on VM stop. There is no explicit restore as the tables are implicitly sync'ed on ITS table restore and on LPI enable at redistributor level. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access

In some circumstances, we don't want to abort if the kvm_device_access fails. This will be the case during ITS migration, in case the ITS table save/restore fails because the guest did not program the vITS correctly. So let's pass an error object to the function and return the ioctl value. New

[Qemu-devel] [PATCH v6 0/4] vITS save/restore

This series allows ITS save/restore and migration use cases. ITS tables are flushed into guest RAM on VM stop while registers are save on pre_save() callback. Tables and registers are restored on ITS post_load(). Redistributor pending tables also are flushed on VM stop, independently on ITS

[Qemu-devel] call flow to hit get_pci_config_device() during live migration

Hi, I'm investigating an issue seen over a live migration from a modified qemu-kvm-ev-2.3.0-31.el7_2.7.1 to a modified qemu-kvm-ev-2.6.0-28.el7_3.9.1. We hit an issue down in get_pci_config_device() that caused the migration to fail. The qemu logs on the destination are included below. I'm

Re: [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak

On 06/09/2017 10:34 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 06/09/2017 08:33 AM, Marc-André Lureau wrote: >>> user_creatable_add_opts() returns a reference (the other reference is >>> for the root parent/child link). >>> >>> Leak introduced in commit

Re: [Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

On 06/09/2017 10:28 AM, Marc-André Lureau wrote: > sadly, coccinelle is unabarebly slow on my machine, Odd. It's pretty fast for this series: $ time spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h --dir . --in-place 2>/dev/null real0m2.136s

Re: [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 Type: series Message-id: 1497016045-6009-1-git-send-email-arm...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

On Fri, Jun 9, 2017 at 7:33 PM Eric Blake wrote: > On 06/09/2017 10:28 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Jun 9, 2017 at 7:20 PM Eric Blake wrote: > > > >> A recent patch submission was about to use qobject_decref(QOBJECT(E)), > >> even

Re: [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak

Eric Blake writes: > On 06/09/2017 08:33 AM, Marc-André Lureau wrote: >> user_creatable_add_opts() returns a reference (the other reference is >> for the root parent/child link). >> >> Leak introduced in commit a1af255f065cc. >> >> Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

On Fri, Jun 09, 2017 at 04:16:15PM +0100, Stefan Hajnoczi wrote: > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > nvdimm is enabled before plugging") introduced a check to reject nvdimm > hotplug if -machine pc,nvdimm=on was not given. > > This check executes after

Re: [Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

On 06/09/2017 10:28 AM, Marc-André Lureau wrote: > Hi > > On Fri, Jun 9, 2017 at 7:20 PM Eric Blake wrote: > >> A recent patch submission was about to use qobject_decref(QOBJECT(E)), >> even though we already have QDECREF(E) for that purpose. While our >> tree is currently

Re: [Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

On Fri, Jun 9, 2017 at 7:28 PM Marc-André Lureau wrote: > Hi > > On Fri, Jun 9, 2017 at 7:20 PM Eric Blake wrote: > >> A recent patch submission was about to use qobject_decref(QOBJECT(E)), >> even though we already have QDECREF(E) for that

Re: [Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

Hi On Fri, Jun 9, 2017 at 7:20 PM Eric Blake wrote: > A recent patch submission was about to use qobject_decref(QOBJECT(E)), > even though we already have QDECREF(E) for that purpose. While our > tree is currently free from the longhand form, we might as well update > Oh?

[Qemu-devel] [PATCH 2/2] qobject: Catch another straggler for use of qdict_put_str()

Dan's addition of key-secret improvements in commit 29cf9336 was developed prior to the addition of QDict scalar insertion macros, but merged after the general cleanup in commit 46f5ac20. Patch created mechanically by rerunning: spatch --sp-file scripts/coccinelle/qobject.cocci \

[Qemu-devel] [PATCH 0/2] qobject coccinelle followups

Inspired by https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02505.html Surprisingly, the updated script didn't find any existing longhand use as candidates for QDECREF() (our last such use was cleaned up as a side effect, in commit b72fe9e), but it DID find another straggler missed in

[Qemu-devel] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF

A recent patch submission was about to use qobject_decref(QOBJECT(E)), even though we already have QDECREF(E) for that purpose. While our tree is currently free from the longhand form, we might as well update our coccinelle script to catch any future relapses. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if nvdimm is enabled before plugging") introduced a check to reject nvdimm hotplug if -machine pc,nvdimm=on was not given. This check executes after pc_dimm_memory_plug() has already completed and does not reverse the effect of this

Re: [Qemu-devel] [PATCH v4 0/6] spapr/xics: fix migration of older machine types

On Fri, 9 Jun 2017 20:28:32 +1000 David Gibson wrote: > On Fri, Jun 09, 2017 at 11:36:31AM +0200, Greg Kurz wrote: > > On Fri, 9 Jun 2017 12:28:13 +1000 > > David Gibson wrote: > > > > > On Thu, Jun 08, 2017 at 03:42:32PM +0200, Greg

[Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

Ensure the format strings are always preprocessed, so any problem get reported. Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed review feedback from Alex Bennée No changes in *printf() calls but using qemu_log_mask() is an option. hw/net/pcnet-pci.c | 13

[Qemu-devel] [RFC PATCH 2/2] ide/ahci: add missing includes

CC arm-softmmu/hw/arm/highbank.o In file included from qemu/hw/arm/highbank.c:34:0: qemu/include/hw/ide/ahci.h:260:16: error: field ‘sglist’ has incomplete type QEMUSGList sglist; ^~ /qemu/include/hw/ide/ahci.h:272:5: error: unknown type name ‘IDEDMA’ IDEDMA

[Qemu-devel] [PATCH v2] hw/misc: add missing includes

inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed review feedback from Eric Blake include/hw/misc/unimp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/misc/unimp.h

[Qemu-devel] [RFC PATCH 0/2] ide/ahci: add missing includes

Hi Eric, John. The patch 07/11 "hw/arm: use defined type name instead of hard-coded string." triggered this problem. I split the previous series to only include the 2 commits involved to reproduce. As you will see, calxeda_init() from highbank.c uses the sysbus type name "sysbus-ahci" which is

[Qemu-devel] [PATCH v2] hw/pci: define msi_nonbroken in pci-stub

The kludged field 'msi_nonbroken' is declared in "hw/pci/msi.h" and defined in hw/pci/msi.c. When using an ARM config with CONFIG_PCI disabled, hw/pci/msi.c is not included. Without being PCI-related, the files hw/intc/arm_gicv[23*].c do access this field (to enable the kludge if PCI is enabled).

[Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/highbank.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index d209b97dee..dd809b404b 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -31,6 +31,7 @@ #include

Re: [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 Message-id: 1497016045-6009-1-git-send-email-arm...@redhat.com

[Qemu-devel] [PATCH v2] ui/cocoa.m: add Speed menu

Programs running inside of QEMU can sometimes use more CPU time than is really needed. To solve this problem, we just need to throttle the virtual CPU. This feature will stop laptops from burning up. This patch adds a menu called Speed that has menu items from 100% to 1% that represent the speed

Re: [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak

On 06/09/2017 08:33 AM, Marc-André Lureau wrote: > user_creatable_add_opts() returns a reference (the other reference is > for the root parent/child link). > > Leak introduced in commit a1af255f065cc. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH v3 03/13] char: chardevice hotswap

On Thu, Jun 1, 2017 at 3:23 PM Anton Nefedov wrote: > > > On 05/31/2017 10:20 PM, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 30, 2017 at 6:12 PM Anton Nefedov > > > > wrote: > > > > This

Re: [Qemu-devel] [PATCH v2 4/7] qcow2: Split do_perform_cow() into _read(), _encrypt() and _write()

On 06/07/2017 09:08 AM, Alberto Garcia wrote: > This patch splits do_perform_cow() into three separate functions to > read, encrypt and write the COW regions. > > perform_cow() can now read both regions first, then encrypt them and > finally write them to disk. The memory allocation is also done

Re: [Qemu-devel] [PATCH v3 43/43] qobject: move dump_qobject() from block/ to qobject/

On 2017-06-08 19:43, Markus Armbruster wrote: > Marc-André Lureau writes: > >> The dump functions could be generally useful for any qobject user or for >> debugging etc. >> >> Signed-off-by: Marc-André Lureau >> --- >>

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

Am 09.06.2017 um 16:10 hat Max Reitz geschrieben: > On 2017-06-09 13:50, Kevin Wolf wrote: > > When qemu is exited, all running jobs should be cancelled successfully. > > This adds a test for this for all types of block jobs that currently > > exist in qemu. > > > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

On 2017-06-09 13:50, Kevin Wolf wrote: > When qemu is exited, all running jobs should be cancelled successfully. > This adds a test for this for all types of block jobs that currently > exist in qemu. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/185 | 189 >

Re: [Qemu-devel] [PATCH v20 30/30] block: release persistent bitmaps on inactivate

On 2017-06-02 13:21, Vladimir Sementsov-Ogievskiy wrote: > We should release them here to reload on invalidate cache. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 4 > block/dirty-bitmap.c | 29

Re: [Qemu-devel] [Qemu-block] [PATCH 2/3] qemu-iotests: Allow starting new qemu after cleanup

On 2017-06-09 13:50, Kevin Wolf wrote: > After _cleanup_qemu(), test cases should be able to start the next qemu > process and call _cleanup_qemu() for that one as well. For this to work > cleanly, we need to improve the cleanup so that the second invocation > doesn't try to kill the qemu

[Qemu-devel] [PATCH v1 1/2] target/s390x: correctly indicate PER nullification

Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index 75fd13e..9f51af3 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -671,6

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] commit: Fix completion with extra reference

On 2017-06-09 13:50, Kevin Wolf wrote: > commit_complete() can't assume that after its block_job_completed() the > job is actually immediately freed; someone else may still be holding > references. In this case, the op blockers on the intermediate nodes make > the graph reconfiguration in the

[Qemu-devel] [PATCH v2 1/3] intel_iommu: switching the rest DPRINTF to trace

We have converted many of the DPRINTF() into traces. This patch does the last 100+ ones. To debug VT-d when error happens, let's try enable: -trace enable="vtd_err*" This should works just like the old GENERAL but of course better, since we don't need to recompile. Similar rules apply to the

[Qemu-devel] [PATCH v1 2/2] target/s390x: rework PGM interrupt psw.addr handling

We can tell from the program interrupt code, whether a program interrupt has to forward the address in the PGM new PSW (suppressing/terminated/completed) to point at the next instruction, or if it is nullifying and the PSW address does not have to be incremented. So let's not modify the PSW

[Qemu-devel] [PATCH v2 3/3] intel_iommu: cleanup vtd_interrupt_remap_msi()

Move the memcpy upper into where needed, then share the trace so that we trace every correct remapping. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

On 06/09/2017 07:58 AM, Kevin Wolf wrote: > Am 09.06.2017 um 14:14 hat Eric Blake geschrieben: >> On 06/09/2017 06:50 AM, Kevin Wolf wrote: >>> When qemu is exited, all running jobs should be cancelled successfully. >>> This adds a test for this for all types of block jobs that currently >>> exist

[Qemu-devel] [PATCH v1 0/2] PGM injection fix/rework

We have various places where we inject suppressing PGM exceptions, but don't forward the PSW. Let's fix that by detecting whether to forward the PSW using the interception code. We can now get rid of ILEN_LATER/ILEN_LATER_INC and replace it by ILEN_AUTO, to automatically detect the instruction

[Qemu-devel] [PATCH v2 2/3] intel_iommu: cleanup vtd_{do_}iommu_translate()

First, let vtd_do_iommu_translate() return a status, so that we explicitly knows whether error occured. Meanwhile, we make sure that IOMMUTLBEntry is filled in in that. Then, cleanup vtd_iommu_translate a bit. So even with PT we'll get a log now. Also, remove useless assignments. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

Test compile gripes: hw/xen/xen-common.c: In function ‘xen_init’: hw/xen/xen-common.c:147:5: warning: implicit declaration of function ‘register_compat_prop’ [-Wimplicit-function-declaration] register_compat_prop("migration", "store-global-state", "off");

[Qemu-devel] [PATCH v2 0/3] VT-d: convert the rest of DPRINTF()s

v2: - fix the issue that patchew reported - further refactor patch 2 to make it better Mainly I am doing the translation and then we can get rid of that. Finally we won't need to recompile for its debugging any more. I did spend some time on considering which DPRINTF to remove, which one to

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Remove superfluous call to soundhw_init()

On Fri, Jun 09, 2017 at 08:53:17AM +0200, Thomas Huth wrote: > When using the 40p machine, soundhw_init() is currently called twice, > one time from vl.c and one time from ibm_40p_init(). The call in > ibm_40p_init() was likely just a copy-and-paste from a old version > of the prep machine - but

Re: [Qemu-devel] [PATCHv5 2/4] pseries: Move CPU compatibility property to machine

On Fri, 2 Jun 2017 13:15:05 +1000 David Gibson wrote: > Server class POWER CPUs have a "compat" property, which is used to set the > backwards compatibility mode for the processor. However, this only makes > sense for machine types which don't give the guest access

[Qemu-devel] [PULL 06/41] qapi: merge QInt and QFloat in QNum

From: Marc-André Lureau We would like to use a same QObject type to represent numbers, whether they are int, uint, or floats. Getters will allow some compatibility between the various types if the number fits other representations. Add a few more tests while at it.

[Qemu-devel] [PULL 40/41] console: use get_uint() for "head" property

From: Marc-André Lureau TYPE_QEMU_CONSOLE property "head" is defined with object_property_add_uint*_ptr(). Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-41-marcandre.lur...@redhat.com> Signed-off-by: Markus

Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2()

On Fri, Jun 09, 2017 at 07:24:40PM +0800, Mao Zhongyi wrote: > After the patch 'Make errp the last parameter of pci_add_capability()', > pci_add_capability() and pci_add_capability2() now do exactly the same. > So drop the wrapper pci_add_capability() of pci_add_capability2(), then > replace the

[Qemu-devel] [PULL 39/41] i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties

From: Marc-André Lureau These are properties of TYPE_X86_CPU, defined with DEFINE_PROP_UINT32() Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-40-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 32/41] pc: use get_uint() for "hpet-intcap" property

From: Marc-André Lureau TYPE_HPET's property HPET_INTCAP is defined with DEFINE_PROP_UINT32(). Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-33-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 05/45] qdev: remove PropertyInfo.qtype field

Markus Armbruster writes: > Peter Maydell writes: > >> On 7 June 2017 at 14:09, Markus Armbruster wrote: >>> Peter Maydell writes: So how should I obtain those semantics with this cleanup in place ?

Re: [Qemu-devel] [PATCH v20 20/30] qcow2: store bitmaps on reopening image as read-only

On 2017-06-02 13:21, Vladimir Sementsov-Ogievskiy wrote: > Store bitmaps and mark them read-only on reopening image as read-only. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 22 ++ > block/qcow2.c| 5 +

[Qemu-devel] [PULL 22/41] pc-dimm: make "size" property uint64

From: Marc-André Lureau This carries the memory_region_size() value without implicit cast. Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-23-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 37/41] pnv-core: use get_uint() for "core-pir" property

From: Marc-André Lureau This is an alias of TYPE_PNV_CORE's property "pir", which is defined with DEFINE_PROP_UINT32() Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-38-marcandre.lur...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 15/41] qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED()

From: Marc-André Lureau The rename prepares for the patch after next's DEFINE_PROP_UNSIGNED(). Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-16-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL 19/41] qdev: Use appropriate getter/setters type

From: Marc-André Lureau Based on the underlying type of the data accessed, use the appropriate getters/setters: * AcpiPmInfo members s3_disabled, s4_disabled are bool, member s4_val is an uint8_t * Property ACPI_PCIHP_IO_PROP is defined with

[Qemu-devel] [PULL 14/41] object: use more specific property type names

From: Marc-André Lureau Use the actual unsigned integer type name. The type name change impacts the following externally visible area: * vl.c's machine_help_func() puts it in help for -machine NAME,help. * QMP command qom-list exposes it in ObjectPropertyInfo

[Qemu-devel] [PULL 23/41] pcihp: use get_uint() for "bsel" property

From: Marc-André Lureau The property is defined with object_property_add_uint32_ptr() Signed-off-by: Marc-André Lureau Message-Id: <20170607163635.17635-24-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 41/41] tests/qdict: check more get_try_int() cases

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Message-Id: <20170607163635.17635-42-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 17/41] qdev: avoid type casts between signed and unsigned

From: Marc-André Lureau Modify the unsigned type for various properties to use QNUM_U64, to avoid type casts. There are a few empty lines added to improve code reading/style. Signed-off-by: Marc-André Lureau Message-Id:

  1   2   3   >