Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

2017-06-12 Thread Knut Omang
On Fri, 2017-06-09 at 14:04 -0700, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Message-id: > cover.e0862272629975a2a7296103c

Re: [Qemu-devel] [PATCH v5 0/1] qemu-ga: add guest-get-osinfo command

2017-06-12 Thread Tomáš Golembiovský
Hi, anyone got a chance to look at it already? Thanks, Tomas On Wed, 7 Jun 2017 14:02:05 +0200 Tomáš Golembiovský wrote: > v5: > - fixed build failure with older glib > - fixed coding style issues > - fixed one log string > > This is a continuation of the work started by Vinzenz Feenstr

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Jason Wang
On 2017年06月13日 14:13, Wei Wang wrote: On 06/13/2017 11:59 AM, Jason Wang wrote: On 2017年06月13日 11:55, Jason Wang wrote: The issue is what if there's a mismatch of max #sgs between qemu and vhost? When the vhost backend is used, QEMU is not involved in the data path. The vhost backend direc

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Jason Wang
On 2017年06月13日 14:08, Wei Wang wrote: On 06/13/2017 11:55 AM, Jason Wang wrote: On 2017年06月13日 11:51, Wei Wang wrote: On 06/13/2017 11:19 AM, Jason Wang wrote: On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800

Re: [Qemu-devel] [PATCH v8 07/11] migration: add bitmap for copied page

2017-06-12 Thread Peter Xu
On Tue, Jun 13, 2017 at 09:10:46AM +0300, Alexey Perevalov wrote: > On 06/13/2017 08:59 AM, Peter Xu wrote: > >On Wed, Jun 07, 2017 at 12:46:34PM +0300, Alexey Perevalov wrote: > >>This patch adds ability to track down already copied > >>pages, it's necessary for calculation vCPU block time in > >>

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Wei Wang
On 06/13/2017 11:59 AM, Jason Wang wrote: On 2017年06月13日 11:55, Jason Wang wrote: The issue is what if there's a mismatch of max #sgs between qemu and vhost? When the vhost backend is used, QEMU is not involved in the data path. The vhost backend directly gets what is offered by the guest fro

Re: [Qemu-devel] [PATCH v8 07/11] migration: add bitmap for copied page

2017-06-12 Thread Alexey Perevalov
On 06/13/2017 08:59 AM, Peter Xu wrote: On Wed, Jun 07, 2017 at 12:46:34PM +0300, Alexey Perevalov wrote: This patch adds ability to track down already copied pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure.

Re: [Qemu-devel] Status of q35-lite?

2017-06-12 Thread Chao Peng
On Wed, 2017-05-24 at 16:07 +0100, Stefan Hajnoczi wrote: > Hi Chao, > Last year there was an effort to make "built-in" hardware optional so > that VMs can be launched with a minimal set of devices.  You made > SATA, > PIT, and SMBus optional. > > What is the current status of this work? > > Are

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Wei Wang
On 06/13/2017 11:55 AM, Jason Wang wrote: On 2017年06月13日 11:51, Wei Wang wrote: On 06/13/2017 11:19 AM, Jason Wang wrote: On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, tha

Re: [Qemu-devel] [PATCH v8 07/11] migration: add bitmap for copied page

2017-06-12 Thread Peter Xu
On Wed, Jun 07, 2017 at 12:46:34PM +0300, Alexey Perevalov wrote: > This patch adds ability to track down already copied > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shar

Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

2017-06-12 Thread Knut Omang
On Fri, 2017-06-09 at 14:39 -0500, Eric Blake wrote: > On 06/09/2017 02:19 PM, Knut Omang wrote: > > This series contains: > > * a unit test that exposes a race condition which causes QEMU to fail > >   to find a port even when there is plenty of available ports. > > * a refactor of the qemu-socket

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-12 Thread Cédric Le Goater
On 06/13/2017 06:37 AM, Andrew Jeffery wrote: > On Fri, 2017-06-09 at 07:40 +0200, Cédric Le Goater wrote: >> On 06/09/2017 04:26 AM, Andrew Jeffery wrote: >>> On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: When a timer is enabled before a reload value is set, the controller w

Re: [Qemu-devel] [PULL 0/7] ui patch queue

2017-06-12 Thread Thomas Huth
On 12.06.2017 20:08, Peter Maydell wrote: > On 12 June 2017 at 19:00, Peter Maydell wrote: >> This causes configure to barf warnings in my build logs on half >> my build machines: >> >> WARNING: Support for gtk2 will be dropped in future releases. >> WARNING: Please consider using gtk3 instead. >>

Re: [Qemu-devel] [PATCH v6 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-06-12 Thread Bharata B Rao
On Mon, Jun 12, 2017 at 05:10:44PM +0800, David Gibson wrote: > On Mon, Jun 12, 2017 at 11:02:34AM +0530, Bharata B Rao wrote: > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > stream (in the place of HPT size) when the guest doesn't allocate HPT. > > This will help the target

Re: [Qemu-devel] [PATCH v4 5/7] target-m68k: use floatx80 internally

2017-06-12 Thread Thomas Huth
On 12.06.2017 01:16, Laurent Vivier wrote: > Coldfire uses float64, but 680x0 use floatx80. > This patch introduces the use of floatx80 internally > and enables 680x0 80bits FPU. > > Signed-off-by: Laurent Vivier > --- > target/m68k/cpu.c| 9 +- > target/m68k/cpu.h| 6 +- > t

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-12 Thread Andrew Jeffery
On Fri, 2017-06-09 at 07:40 +0200, Cédric Le Goater wrote: > On 06/09/2017 04:26 AM, Andrew Jeffery wrote: > > On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: > > > When a timer is enabled before a reload value is set, the controller > > > waits for a reload value to be set before starti

Re: [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access

2017-06-12 Thread Peter Xu
On Fri, Jun 09, 2017 at 05:52:30PM +0200, Eric Auger wrote: > In some circumstances, we don't want to abort if the > kvm_device_access fails. This will be the case during ITS > migration, in case the ITS table save/restore fails because > the guest did not program the vITS correctly. So let's pass

[Qemu-devel] [PATCH] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-12 Thread Samuel Brian
Some USB devices have sparse interface numbering which is not able to be passthroughed. For example, the Sierra Wireless MC7455/MC7430: # lsusb -D /dev/bus/usb/003/003 | egrep '1199|9071|bNumInterfaces|bInterfaceNumber' Device: ID 1199:9071 Sierra Wireless, Inc. idVendor 0x11

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Jason Wang
On 2017年06月13日 11:55, Jason Wang wrote: On 2017年06月13日 11:51, Wei Wang wrote: On 06/13/2017 11:19 AM, Jason Wang wrote: On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, t

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Jason Wang
On 2017年06月13日 11:51, Wei Wang wrote: On 06/13/2017 11:19 AM, Jason Wang wrote: On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, thanks. This was only posted a week ago, mi

Re: [Qemu-devel] [PATCH v2 2/6] migration: let MigrationState be a qdev

2017-06-12 Thread Peter Xu
On Mon, Jun 12, 2017 at 01:13:49PM -0300, Eduardo Habkost wrote: > On Mon, Jun 12, 2017 at 12:46:09PM +0800, Peter Xu wrote: > > On Fri, Jun 09, 2017 at 03:39:24PM +0200, Markus Armbruster wrote: > > > Peter Xu writes: > > > > > > > Let the old man "MigrationState" join the object family. Direct

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Wei Wang
On 06/13/2017 11:19 AM, Jason Wang wrote: On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, thanks. This was only posted a week ago, might be a bit too short for some people.

Re: [Qemu-devel] [PATCH v2 3/6] migration: move global_state.optional out

2017-06-12 Thread Peter Xu
On Mon, Jun 12, 2017 at 04:18:06PM +0800, Peter Xu wrote: > On Fri, Jun 09, 2017 at 10:40:10AM -0300, Eduardo Habkost wrote: > > On Fri, Jun 09, 2017 at 11:48:59AM +0800, Peter Xu wrote: > > > Put it into MigrationState then we can use the properties to specify > > > whether to enable storing globa

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Jason Wang
On 2017年06月13日 11:10, Wei Wang wrote: On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, thanks. This was only posted a week ago, might be a bit too short for some people. OK, sorry for the push. A couple of weeks

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Wei Wang
On 06/13/2017 04:43 AM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: Ping for comments, thanks. This was only posted a week ago, might be a bit too short for some people. OK, sorry for the push. A couple of weeks is more reasonable before you ping. Also

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Wei Wang
On 06/13/2017 04:54 AM, Dave Hansen wrote: On 06/12/2017 01:34 PM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: The hypervisor is going to throw away the contents of these pages, right? It should be ca

Re: [Qemu-devel] [PATCH v6 1/6] Pass generic CPUState to gen_intermediate_code()

2017-06-12 Thread David Gibson
On Mon, Jun 12, 2017 at 05:53:55PM +0300, Lluís Vilanova wrote: > Needed to implement a target-agnostic gen_intermediate_code() in the > future. > > Signed-off-by: Lluís Vilanova > Reviewed-by: David Gibson > Reviewed-by: Richard Henderson ppc parts Acked-by: David Gibson > --- > include/e

Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?

2017-06-12 Thread Qu Wenruo
At 06/12/2017 10:05 PM, Keith Busch wrote: On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote: Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben: When going through NVMe specification and hw/block/nvme.c, I found that it seems that NVMe qemu implementation only support PRP for sq entry

[Qemu-devel] 答复: Re: 答复: Re: [PATCHv2 02/04] colo-compare: Process pactkets in the IOThread ofthe primary

2017-06-12 Thread wang.yong155
>> >> From: Wang Yong <wang.yong...@zte.com.cn> >> >> >> >> >> >> Process pactkets in the IOThread which arrived over the socket. >> >> >> we use qio_channel_set_aio_fd_handler to set the handlers on the >> >> >> IOThread AioContext.then the packets from the primary and the >> secondary

Re: [Qemu-devel] [PATCHv2 1/4] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

2017-06-12 Thread Laszlo Ersek
On 06/13/17 00:27, Laszlo Ersek wrote: > In fw_cfg_init_io_dma(), you know the object type exactly -- you just > created it with TYPE_FW_CFG_IO --, so after device realization, you can > cast the type as narrowly as necessary, and refer to the fields by name. I understand that in sun4u code like

Re: [Qemu-devel] [PATCHv2 4/4] fw_cfg: move QOM type defines into fw_cfg.h

2017-06-12 Thread Laszlo Ersek
On 06/12/17 23:21, Mark Cave-Ayland wrote: > This allows the device to be instantiated externally for boards that > wish to wire up the fw_cfg device themselves. > > Signed-off-by: Mark Cave-Ayland > --- > hw/nvram/fw_cfg.c |8 > include/hw/nvram/fw_cfg.h |8 >

Re: [Qemu-devel] [PATCHv2 3/4] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

2017-06-12 Thread Laszlo Ersek
On 06/12/17 23:21, Mark Cave-Ayland wrote: > When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be > able to wire it up differently, it is much more convenient for the caller to > instantiate the device and have the fw_cfg default files already preloaded > during realize. >

Re: [Qemu-devel] [PATCHv2 2/4] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

2017-06-12 Thread Laszlo Ersek
On 06/12/17 23:21, Mark Cave-Ayland wrote: > The setting of the FW_CFG_VERSION_DMA bit is the same across both the > TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in > fw_cfg_init1(). > > Signed-off-by: Mark Cave-Ayland > --- > hw/nvram/fw_cfg.c | 16 +++- > 1 file

Re: [Qemu-devel] [PATCHv2 1/4] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

2017-06-12 Thread Laszlo Ersek
On 06/12/17 23:21, Mark Cave-Ayland wrote: > As indicated by Laszlo it is a QOM bug for the realize() method to actually > map the device. Set up the IO regions with sysbus_init_mmio() and defer > the mapping to the caller, as already done in fw_cfg_init_mem_wide(). > > Signed-off-by: Mark Cave-Ayl

[Qemu-devel] [PATCHv2 3/4] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

2017-06-12 Thread Mark Cave-Ayland
When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be able to wire it up differently, it is much more convenient for the caller to instantiate the device and have the fw_cfg default files already preloaded during realize. Move fw_cfg_init1() to the end of both the fw_cfg_mem

[Qemu-devel] [PATCHv2 2/4] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

2017-06-12 Thread Mark Cave-Ayland
The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCHv2 1/4] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

2017-06-12 Thread Mark Cave-Ayland
As indicated by Laszlo it is a QOM bug for the realize() method to actually map the device. Set up the IO regions with sysbus_init_mmio() and defer the mapping to the caller, as already done in fw_cfg_init_mem_wide(). Signed-off-by: Mark Cave-Ayland --- hw/nvram/fw_cfg.c | 10 -- 1 fil

[Qemu-devel] [PATCHv2 0/4] fw_cfg: qdev-related tidy-ups

2017-06-12 Thread Mark Cave-Ayland
As part of some ongoing sun4u work, I need to be able to wire the fw_cfg IO interface to a separate IO space by instantiating the qdev device instead of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with FW_CFG_MEM and tidies up the realize methods accordingly. Signed-off-by: Ma

[Qemu-devel] [PATCHv2 4/4] fw_cfg: move QOM type defines into fw_cfg.h

2017-06-12 Thread Mark Cave-Ayland
This allows the device to be instantiated externally for boards that wish to wire up the fw_cfg device themselves. Signed-off-by: Mark Cave-Ayland --- hw/nvram/fw_cfg.c |8 include/hw/nvram/fw_cfg.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 20:50, Mark Cave-Ayland wrote: > Now I understand this much better, let me try a v2 of this which fixes > (1) and moves fw_cfg_init1() to a QOM method in the parent as suggested > by Igor and see what you think. Experimenting with this some more, if the aim is to try and minimise code

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
On 06/12/2017 01:34 PM, Michael S. Tsirkin wrote: > On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: >> On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: >>> The hypervisor is going to throw away the contents of these pages, right? >>> It should be careful and only throw away

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-12 Thread Michael S. Tsirkin
On Mon, Jun 12, 2017 at 05:30:46PM +0800, Wei Wang wrote: > Ping for comments, thanks. This was only posted a week ago, might be a bit too short for some people. A couple of weeks is more reasonable before you ping. Also, I sent a bunch of comments on Thu, 8 Jun 2017. You should probably addres

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Michael S. Tsirkin
On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: > On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: > > > >> The hypervisor is going to throw away the contents of these pages, > >> right? > > It should be careful and only throw away contents that was there before > > report_unused_pag

Re: [Qemu-devel] [RFC PATCH] target-s390x: Implement mvcos instruction

2017-06-12 Thread David Hildenbrand
On 12.06.2017 18:44, Thomas Huth wrote: > On 01.03.2017 13:19, Miroslav Benes wrote: >> On Wed, 1 Mar 2017, Thomas Huth wrote: >> >>> On 28.02.2017 14:17, Miroslav Benes wrote: Implement MVCOS instruction, which the Linux kernel uses in user access functions. Signed-off-by: Miro

Re: [Qemu-devel] [PATCH RFC] migration: kvmclock: save and load the PVCLOCK_TSC_UNSTABLE_BIT flag when migration

2017-06-12 Thread Radim Krčmář
2017-06-12 21:30+0800, Jay Zhou: > Guest using kvmclock will be hanged when migrating from unstable > tsc host to stable tsc host occasionally. > Sometimes, the tsc timestamp saved at the source side will be > backward when the guest stopped, and this value is transferred > to the destination side.

Re: [Qemu-devel] [PATCH RFC] KVM: X86: save and load PVCLOCK_TSC_UNSTABLE_BIT when migration

2017-06-12 Thread Radim Krčmář
2017-06-12 21:23+0800, Jay Zhou: > Guest using kvmclock will be hanged when migrating from unstable > tsc host to stable tsc host occasionally. > Sometimes, the tsc timestamp saved at the source side will be > backward when the guest stopped, and this value is transferred > to the destination side.

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 20:15, Laszlo Ersek wrote: > Adding Peter > > On 06/12/17 13:54, Mark Cave-Ayland wrote: >> On 12/06/17 12:43, Igor Mammedov wrote: >> >>> On Sat, 10 Jun 2017 13:30:17 +0100 >>> Mark Cave-Ayland wrote: >>> >>> patch needs a commit message saying why it's needed. >>> maybe add somethi

Re: [Qemu-devel] [PATCH v4 8/8] tpm: Added support for TPM emulator

2017-06-12 Thread Stefan Berger
On 06/05/2017 03:25 AM, Valluri, Amarnath wrote: On Wed, 2017-05-24 at 11:15 -0400, Stefan Berger wrote: On 05/16/2017 03:58 AM, Amarnath Valluri wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. Sw

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

2017-06-12 Thread Laszlo Ersek
Adding Peter On 06/12/17 13:54, Mark Cave-Ayland wrote: > On 12/06/17 12:43, Igor Mammedov wrote: > >> On Sat, 10 Jun 2017 13:30:17 +0100 >> Mark Cave-Ayland wrote: >> >> patch needs a commit message saying why it's needed. >> maybe add something similar to: >> >> qdev_init_nofail() essentially

Re: [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access

2017-06-12 Thread Auger Eric
Hi Juan, On 12/06/2017 08:23, Juan Quintela wrote: > Eric Auger wrote: >> In some circumstances, we don't want to abort if the >> kvm_device_access fails. This will be the case during ITS >> migration, in case the ITS table save/restore fails because >> the guest did not program the vITS correctl

Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

2017-06-12 Thread Philippe Mathieu-Daudé
Hi Laurent, On 06/11/2017 08:16 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 66 ++--- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

2017-06-12 Thread Marc-André Lureau
Hi Paolo On Mon, Jun 12, 2017 at 8:06 PM Paolo Bonzini wrote: > > > On 08/06/2017 13:59, Marc-André Lureau wrote: > > Hi, > > > > The patch "char: move CharBackend handling in char-fe unit" broke > > chardev aliases. Here is a small series to fix it, and add a simple > > unit test to check the a

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 19:27, Laszlo Ersek wrote: >> Based upon this what do you think the best solution would be? > > > if you apply patch #2 without patch #1, then the above SIGSEGV will hit > on all fw_cfg using targets / machine types, not just > qemu-system-sparc64. The reason is that, after patch #2

Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

2017-06-12 Thread Richard Henderson
On 06/12/2017 10:56 AM, Laurent Vivier wrote: Le 12/06/2017 à 18:13, Richard Henderson a écrit : On 06/11/2017 04:16 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 66 ++

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Laszlo Ersek
Hi Mark, On 06/12/17 13:45, Mark Cave-Ayland wrote: > On 12/06/17 12:20, Igor Mammedov wrote: > >> On Sat, 10 Jun 2017 13:30:16 +0100 >> Mark Cave-Ayland wrote: >> >>> Signed-off-by: Mark Cave-Ayland >>> --- >>> hw/nvram/fw_cfg.c | 14 ++ >>> 1 file changed, 10 insertions(+), 4 d

Re: [Qemu-devel] [PULL v3 00/23] Docker and block patches

2017-06-12 Thread Peter Maydell
On 8 June 2017 at 12:56, Fam Zheng wrote: > The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4: > > arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07 > 17:21:44 +0100) > > are available in the git repository at: > > git://github.com/famz/qemu.gi

Re: [Qemu-devel] [PULL 0/7] ui patch queue

2017-06-12 Thread Peter Maydell
On 12 June 2017 at 19:00, Peter Maydell wrote: > This causes configure to barf warnings in my build logs on half > my build machines: > > WARNING: Support for gtk2 will be dropped in future releases. > WARNING: Please consider using gtk3 instead. > > I don't think it is yet possible to drop gtk2.

Re: [Qemu-devel] [PULL 0/7] ui patch queue

2017-06-12 Thread Peter Maydell
On 8 June 2017 at 08:07, Gerd Hoffmann wrote: > Hi, > > Here is the ui patch queue. Switches the default > to gtk3 and sdl2 and fixes some bugs. > > please pull, > Gerd > > The following changes since commit a0d4aac7467dd02e5657b79e867f067330266a24: > > Merge remote-tracking branch 'remotes

Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

2017-06-12 Thread Laurent Vivier
Le 12/06/2017 à 18:13, Richard Henderson a écrit : > On 06/11/2017 04:16 PM, Laurent Vivier wrote: >> Move code of fmove to/from control register to a function >> >> Signed-off-by: Laurent Vivier >> --- >> target/m68k/translate.c | 66 >> ++--- >> 1 f

Re: [Qemu-devel] [RFC PATCH] target-s390x: Implement mvcos instruction

2017-06-12 Thread Thomas Huth
On 01.03.2017 13:19, Miroslav Benes wrote: > On Wed, 1 Mar 2017, Thomas Huth wrote: > >> On 28.02.2017 14:17, Miroslav Benes wrote: >>> Implement MVCOS instruction, which the Linux kernel uses in user access >>> functions. >>> >>> Signed-off-by: Miroslav Benes >>> --- >>> I tried to do my best to

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: > >> The hypervisor is going to throw away the contents of these pages, >> right? > It should be careful and only throw away contents that was there before > report_unused_page_block was invoked. Hypervisor is responsible for not > corrupting gues

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Michael S. Tsirkin
On Mon, Jun 12, 2017 at 07:10:12AM -0700, Dave Hansen wrote: > Please stop cc'ing me on things also sent to closed mailing lists > (virtio-...@lists.oasis-open.org). I'm happy to review things on open > lists, but I'm not fond of the closed lists bouncing things at me. > > On 06/09/2017 03:41 AM,

Re: [Qemu-devel] [PATCH v2 2/6] migration: let MigrationState be a qdev

2017-06-12 Thread Eduardo Habkost
On Mon, Jun 12, 2017 at 12:46:09PM +0800, Peter Xu wrote: > On Fri, Jun 09, 2017 at 03:39:24PM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > Let the old man "MigrationState" join the object family. Direct benefit > > > is that we can start to use all the property features derived

Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

2017-06-12 Thread Richard Henderson
On 06/11/2017 04:16 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 66 ++--- 1 file changed, 41 insertions(+), 25 deletions(-) In that this is 100% c

Re: [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-12 Thread Paolo Bonzini
On 08/06/2017 19:44, Michael S. Tsirkin wrote: > On Tue, Jun 06, 2017 at 08:10:17PM +0200, Laszlo Ersek wrote: >> On 06/05/17 18:02, Michael S. Tsirkin wrote: >>> On Sat, Jun 03, 2017 at 09:36:23AM +0200, Laszlo Ersek wrote: On 06/02/17 17:45, Laszlo Ersek wrote: > The patches can c

Re: [Qemu-devel] [PATCH] MAINTAINERS: seccomp: change email contact for Eduardo Otubo

2017-06-12 Thread Thomas Huth
On 12.06.2017 14:18, Eduardo Otubo wrote: > Signed-off-by: Eduardo Otubo > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 120788d..0d065a0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1490,7 +1490,7 @@ F: tests

Re: [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

2017-06-12 Thread Paolo Bonzini
On 08/06/2017 13:59, Marc-André Lureau wrote: > Hi, > > The patch "char: move CharBackend handling in char-fe unit" broke > chardev aliases. Here is a small series to fix it, and add a simple > unit test to check the alias keep working. > > v2: > - move HAVE_CHARDEV_* in osdep.h (Markus Armbrus

[Qemu-devel] [PATCH 1/2] docs: create interop/ subdirectory

2017-06-12 Thread Paolo Bonzini
This is for the future interoperability & management guide. It includes the QAPI docs, including the automatically generated ones, other socket protocols (vhost-user, VNC), and the qcow2 file format. Signed-off-by: Paolo Bonzini --- .gitignore | 16 ++---

[Qemu-devel] [PATCH 2/2] qemu-doc: include version number

2017-06-12 Thread Paolo Bonzini
Note that TEXI2POD doesn't support @set/@clear, so pass the value manually on the command line. This patch partially undoes commit bd7f974796 ("qapi: Clean up build of generated documentation", 2017-03-16). Signed-off-by: Paolo Bonzini --- Makefile | 17 + qemu-doc.texi |

[Qemu-devel] [PATCH v2 0/2] docs: create docs/interop/, include version number in qemu-doc

2017-06-12 Thread Paolo Bonzini
Submitted together because of Makefile conflicts. Paolo Bonzini (2): docs: create interop/ subdirectory qemu-doc: include version number .gitignore | 16 ++--- Makefile | 72 -- configure

[Qemu-devel] [PATCH 1/2] block/rbd: enable filename option and parsing

2017-06-12 Thread Jeff Cody
When enabling option parsing and blockdev-add for rbd, we removed the 'filename' option. Unfortunately, this was a bit optimistic, as previous versions of QEMU allowed the use of the option in backing filenames via json. This means that without parsing this option, we cannot open existing images

[Qemu-devel] [PATCH 2/2] block/iscsi: enable filename option and parsing

2017-06-12 Thread Jeff Cody
When enabling option parsing and blockdev-add for iscsi, we removed the 'filename' option. Unfortunately, this was a bit optimistic, as previous versions of QEMU allowed the use of the option in backing filenames via json. This means that without parsing this option, we cannot open existing image

[Qemu-devel] [PATCH 0/2] Parse 'filename' option for RBD/iSCSI

2017-06-12 Thread Jeff Cody
We need to be able to parse the 'filename' option for rbd and iscsi, because there may exist images in the wild that have json backing files, that specify the filename argument. Jeff Cody (2): block/rbd: enable filename option and parsing block/iscsi: enable filename option and parsing block

[Qemu-devel] [PATCH v6 6/6] target: [tcg, arm] Port to generic translation framework

2017-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target/arm/translate-a64.c | 346 ++--- target/arm/translate.c | 720 ++-- target/arm/translate.h | 46 ++- 3 files changed, 560 insertions(+), 552 deletions(-) diff --git a/target/arm/translate

[Qemu-devel] [PATCH v6 1/6] Pass generic CPUState to gen_intermediate_code()

2017-06-12 Thread Lluís Vilanova
Needed to implement a target-agnostic gen_intermediate_code() in the future. Signed-off-by: Lluís Vilanova Reviewed-by: David Gibson Reviewed-by: Richard Henderson --- include/exec/exec-all.h |2 +- target/alpha/translate.c | 11 +-- target/arm/translate.c| 2

[Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

2017-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/gen-icount.h |2 include/exec/translate-all_template.h | 73 include/qom/cpu.h | 22 translate-all_template.h | 204 + 4 files changed, 300 inser

[Qemu-devel] [PATCH v6 4/6] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*)

2017-06-12 Thread Lluís Vilanova
Temporarily redefine DISAS_* values based on DJ_TARGET. They should disappear as targets get ported to the generic framework. Signed-off-by: Lluís Vilanova --- include/exec/exec-all.h | 11 +++ target/arm/translate.h | 19 ++- target/cris/translate.c |

[Qemu-devel] [PATCH v6 2/6] queue: Add macro for incremental traversal

2017-06-12 Thread Lluís Vilanova
Adds macro QTAILQ_FOREACH_CONTINUE to support incremental list traversal. Signed-off-by: Lluís Vilanova --- include/qemu/queue.h | 12 1 file changed, 12 insertions(+) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index 35292c3155..eb2bf9cb1c 100644 --- a/include/qemu/

[Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework

2017-06-12 Thread Lluís Vilanova
This series proposes a generic (target-agnostic) instruction translation framework. It basically provides a generic main loop for instruction disassembly, which calls target-specific functions when necessary. This generalization makes inserting new code in the main loop easier, and helps in keepin

Re: [Qemu-devel] [PATCH v2 1/2] spapr: disable hotplugging without OS

2017-06-12 Thread David Gibson
On Thu, Jun 08, 2017 at 07:27:42PM +0200, Laurent Vivier wrote: > If the OS is not started, QEMU sends an event to the OS > that is lost and cannot be recovered. An unplug is not > able to restore QEMU in a coherent state. > So, while the OS is not started, disable CPU and memory hotplug. > We gues

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/2] spapr: disable hotplugging without OS

2017-06-12 Thread David Gibson
On Thu, Jun 08, 2017 at 03:35:58PM -0300, Daniel Henrique Barboza wrote: > > > On 06/08/2017 02:27 PM, Laurent Vivier wrote: > > If the OS is not started, QEMU sends an event to the OS > > that is lost and cannot be recovered. An unplug is not > > able to restore QEMU in a coherent state. > > So,

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2017-06-12 Thread Peter Maydell
On 7 June 2017 at 19:55, Stefan Hajnoczi wrote: > The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07 > 11:56:00 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-12 Thread Stefan Hajnoczi
On Sun, Jun 11, 2017 at 02:37:14PM +0200, Max Reitz wrote: > qemu proper has done so for 13 years > (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have > done so for four years (526eda14a68d5b3596be715505289b541288ef2a). > Ignoring this signal is especially important in qemu-nbd b

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

2017-06-12 Thread David Gibson
On Thu, Jun 08, 2017 at 11:54:10AM +0200, Greg Kurz wrote: > On Thu, 8 Jun 2017 14:08:57 +1000 > David Gibson wrote: > > > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > > > sPAPRCPUCore") moved ICPState obje

Re: [Qemu-devel] [PATCH v3] block: change variable names in BlockDriverState

2017-06-12 Thread Stefan Hajnoczi
On Fri, Jun 09, 2017 at 01:18:08PM +0300, Manos Pitsidianakis wrote: > Change the 'int count' parameter in *pwrite_zeros, *pdiscard related > functions (and some others) to 'int bytes', as they both refer to bytes. > This helps with code legibility. > > Signed-off-by: Manos Pitsidianakis > --- P

Re: [Qemu-devel] [PATCH v4 5/6] xics: directly register ICPState objects to vmstate

2017-06-12 Thread David Gibson
On Thu, Jun 08, 2017 at 03:43:18PM +0200, Greg Kurz wrote: > The ICPState objects are currently registered to vmstate as qdev objects. > Their instance ids are hence computed automatically in the migration code, > and thus depends on the order the CPU cores were plugged. > > If the destination had

Re: [Qemu-devel] [PATCH v4 6/6] spapr: fix migration of ICPState objects from/to older QEMU

2017-06-12 Thread David Gibson
On Thu, Jun 08, 2017 at 03:43:27PM +0200, Greg Kurz wrote: > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. > This is an improvement since we no longer allocate ICPState objects > that will never be used. B

[Qemu-devel] [PATCH v4 3/4] net/socket: Convert error report message to Error

2017-06-12 Thread Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf(), perror() to report an error message. Now, convert these functions to Error. Cc: jasow...@redhat.com Cc: arm...@redhat.com Cc: berra...@redhat.com Signed-off-by: Mao Zhongy

[Qemu-devel] [PATCH v4 2/4] net/net: Convert parse_host_port() to Error

2017-06-12 Thread Mao Zhongyi
Cc: berra...@redhat.com Cc: kra...@redhat.com Cc: pbonz...@redhat.com Cc: jasow...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- include/qemu/sockets.h | 2 +- net/net.c | 21 - net/socket.c | 37 ++---

[Qemu-devel] [PATCH v4 4/4] net/socket: Improve -net socket error reporting

2017-06-12 Thread Mao Zhongyi
When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast= or udp= is required qemu-system-x86_64: -net socket: Device 'socket' could not be

Re: [Qemu-devel] Fwd: [BUG] Failed to compile using gcc7.1

2017-06-12 Thread Max Reitz
On 2017-06-12 05:19, Philippe Mathieu-Daudé wrote: > Hi Tsung-en, > > On 06/11/2017 04:08 PM, Tsung-en Hsiao wrote: >> Hi all, >> I encountered the same problem on gcc 7.1.1 and found Qu's mail in >> this list from google search. >> >> Temporarily fix it by specifying the string length in snprintf

[Qemu-devel] [PATCH v4 0/4] Improve error reporting

2017-06-12 Thread Mao Zhongyi
Daniel's patch(commit 6701e551, Revert "Change net/socket.c to use socket_*() functions" again) has been in upstream. Continue this patchset. In v2, this series convert the non-blocking connect mechanism to QIOchannel by replace the socket_connect(), and some errors also are converted to Error.

[Qemu-devel] [PATCH v4 1/4] net/socket: Drop the odd 'default' case and comment

2017-06-12 Thread Mao Zhongyi
In the net_socket_fd_init(), the 'default' case and comment is odd. If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If @fd was a socket, but neither SOCK_DGRAM nor SOCK_STREAM. It should not be treated as if it was SOCK_STREAM. If there is a genuine reason to support something like

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
Please stop cc'ing me on things also sent to closed mailing lists (virtio-...@lists.oasis-open.org). I'm happy to review things on open lists, but I'm not fond of the closed lists bouncing things at me. On 06/09/2017 03:41 AM, Wei Wang wrote: > Add a function to find a page block on the free list

Re: [Qemu-devel] [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

2017-06-12 Thread Dave Hansen
On 06/09/2017 03:41 AM, Wei Wang wrote: > + for_each_populated_zone(zone) { > + for (order = MAX_ORDER - 1; order > 0; order--) { > + for (migratetype = 0; migratetype < MIGRATE_TYPES; > + migratetype++) { > +

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote: > Users can hotplug ThrottleGroups with object-add in QMP/HMP, then > attach drives to a throttle group (ie adding a filter node in the drive path > that points to that throttle group) with an 'attach-throttle' and detach > with '

Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?

2017-06-12 Thread Keith Busch
On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote: > Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben: > > When going through NVMe specification and hw/block/nvme.c, > > I found that it seems that NVMe qemu implementation only support PRP > > for sq entry. > > And NvmeRwCmd doesn't even us

[Qemu-devel] [PATCH v5 3/9] pci: Fix the return value checking

2017-06-12 Thread Mao Zhongyi
pci_add_capability returns a strictly positive value on success, correct asserts. Cc: dmi...@daynix.com Cc: jasow...@redhat.com Cc: kra...@redhat.com Cc: alex.william...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- hw/net/e1000e.c | 2 +- hw/net/eepro100.c | 2 +- hw/usb/hcd

[Qemu-devel] [PATCH v5 9/9] i386/kvm/pci-assign: Use errp directly rather than local_err

2017-06-12 Thread Mao Zhongyi
In assigned_device_pci_cap_init(), first, error messages are filled to a local_err variable, then through error_propagate() pass to the parameter of errp. It leads to cumbersome code. In order to avoid the extra local_err and error_propagate(), drop it and use errp instead. Cc: pbonz...@redhat.com

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote: > The old interface will be retained as much as possible. I think "retained" means "reused" here but in case it doesn't: The old interface must remain 100% functional. Existing software like libvirt must continue to work withou

  1   2   >