Hi,
Thomas has pointed out that WinUAE[1] has an updated softfloat library
implementing missing operations for 680x0.
Do you think these changes can be merged in QEMU?
Thanks,
Laurent
[1] https://github.com/tonioni/WinUAE/tree/master/softfloat
Hi Eric,
> -Original Message-
> From: Auger Eric [mailto:eric.au...@redhat.com]
> Sent: Monday, June 26, 2017 1:25 PM
> To: Bharat Bhushan ;
> eric.auger@gmail.com; peter.mayd...@linaro.org;
> alex.william...@redhat.com; m...@redhat.com; qemu-...@nongnu.org;
>
v2:
- patch 1: add r-b for Eduardo/Juan
- patch 2: add r-b for Eduardo (Markus's suggestion is a todo), and
t-b for Qingfeng
- patch 3: rewrite the doc up, merging both Eduardo/Markus's
suggestion [Eduardo, Markus]
- patch 4: added a TODO [Markus]
Two breakage introduced during the migration
It's never documented, and now we have one more parameter for it (which
obsoletes this one). Document it properly.
Although now when enforce-config-section is set, it'll override the
other "-global" parameter, that is not necessarily a rule. Forbid that
usage in the document.
Suggested-by:
Currently drive_init_func() may call migrate_get_current() while the
migrate object is still not ready yet at that time. Move the migration
object init earlier, along with the global properties, right after
acceleration init.
This fixes a breakage for iotest 055, which caused an assertion
MigrateState object is not ready at that time, so we'll get an
assertion. Use qemu_global_option() instead.
Reported-by: Eduardo Habkost
Suggested-by: Eduardo Habkost
Reviewed-by: Eduardo Habkost
Reviewed-by: Juan Quintela
[Peter collected Eduardo's patch comment and formatted into patch]
Suggested-by: Eduardo Habkost
Signed-off-by: Peter Xu
---
migration/migration.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration/migration.c
Hi,
On 05.07.2017 08:57, Chao Peng wrote:
>
> Q35 has been in QEMU for quite a while. Compared to the current default
> i440FX, Q35 is probably not that mature and not widely used, however in
> some case, Q35 has advantages, for example, in supporting new features.
> For instance, we have some
From: Sameeh Jubran
Currently on Windows whenever the qemu-ga's service doesn't find the
virtio-serial
it terminates. This commit addresses this issue by adding a new listener service
which registers for notifications of the virtio-port-serial device handle the
qemu-ga's
On 05.07.2017 08:36, David Gibson wrote:
> On Tue, Jul 04, 2017 at 03:02:39PM +0200, Greg Kurz wrote:
>> On Tue, 4 Jul 2017 21:41:51 +1000
>> David Gibson wrote:
>>
>>> On Tue, Jul 04, 2017 at 01:15:00PM +0200, Greg Kurz wrote:
On Tue, 4 Jul 2017 13:01:26 +0200
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
qga/service-win32.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/qga/service-win32.c b/qga/service-win32.c
index 861f9fc..c17e0eb 100644
---
From: Sameeh Jubran
This commits adds two functions which handle service's start and stop
process in Windows.
Signed-off-by: Sameeh Jubran
---
qga/service-win32.c | 52
qga/service-win32.h | 2 ++
2
From: Sameeh Jubran
Clean exe files such as qemu-ga.exe
Signed-off-by: Sameeh Jubran
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 16a0430..22d29d6 100644
--- a/Makefile
+++ b/Makefile
@@ -487,6 +487,7 @@
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
qga/installer/qemu-ga.wxs | 24
1 file changed, 24 insertions(+)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index fa2260c..40b7a7b 100644
---
From: Sameeh Jubran
This patch series fixes qemu-ga's main service behaviour on Windows
by listening to the virtio-serial device's events.
For more info on why this series is needed checkout the commit message
of the third patch and the following bugzilla:
On Tue, Jul 04, 2017 at 03:02:39PM +0200, Greg Kurz wrote:
> On Tue, 4 Jul 2017 21:41:51 +1000
> David Gibson wrote:
>
> > On Tue, Jul 04, 2017 at 01:15:00PM +0200, Greg Kurz wrote:
> > > On Tue, 4 Jul 2017 13:01:26 +0200
> > > Laurent Vivier
From: Yang Zhong
Add the CONFIG_TCG for frontend and backend's files in the related
Makefiles.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/Makefile.objs | 10 +-
1 file changed, 5
> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com]
> Sent: Tuesday, June 27, 2017 12:13 AM
>
> On 26/06/17 09:22, Auger Eric wrote:
> > Hi Jean-Philippe,
> >
> > On 19/06/2017 12:15, Jean-Philippe Brucker wrote:
> >> On 19/06/17 08:54, Bharat Bhushan wrote:
> >>> Hi Eric,
> >>>
From: Yang Zhong
Add the CONFIG_TCG for frontend and backend's files in the related
Makefiles.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
Makefile.target | 4 ++--
accel/Makefile.objs | 2 +-
2 files
This function calls tlb_set_page_with_attrs, which is not available
when TCG is disabled. Move it to excp_helper.c.
Signed-off-by: Paolo Bonzini
---
target/i386/excp_helper.c | 343 +
target/i386/helper.c | 344
From: Yang Zhong
Add CONFIG_TCG around TLB-related functions and structure declarations.
Some of these functions are defined in ./accel/tcg/cputlb.c, which will
not be linked in if TCG is disabled, and have no stubs; therefore, their
callers will also be compiled out for
From: Yang Zhong
Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific
tcg code.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/cpu.h| 21 ++---
Hi Jean,
> -Original Message-
> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com]
> Sent: Monday, June 19, 2017 3:45 PM
> To: Bharat Bhushan ; Auger Eric
> ; eric.auger@gmail.com;
> peter.mayd...@linaro.org;
From: Yang Zhong
Move cpu_get_fp80()/cpu_set_fp80() from fpu_helper.c to
machine.c because fpu_helper.c will be disabled if tcg is
disabled in the build.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
Max Reitz writes:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> Signed-off-by: Max Reitz
I'll review this one as soon as we made up
This lets you build without TCG (hardware accelerationor qtest only). When
this flag is passed to configure, it will automatically filter out the target
list to only those that support KVM or Xen or HAX.
Signed-off-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
From: Yang Zhong
Change the tcg_enabled() and make sure user build still enable tcg
even x86 softmmu disable tcg.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
accel/tcg/cpu-exec-common.c | 2 ++
Adding assertions fixes link errors.
Signed-off-by: Paolo Bonzini
---
exec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/exec.c b/exec.c
index ee61915..a083ff8 100644
--- a/exec.c
+++ b/exec.c
@@ -2317,6 +2317,7 @@ static void notdirty_mem_write(void *opaque,
From: Yang Zhong
Add the tcg_enabled() where the x86 target needs to disable
TCG-specific code.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/cpu.c | 4 +++-
target/i386/cpu.h | 8 +++-
Signed-off-by: Paolo Bonzini
---
bsd-user/main.c | 1 -
include/exec/exec-all.h | 4
tcg/tcg.h | 4
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 04f95dd..fa9c012 100644
---
Signed-off-by: Paolo Bonzini
---
accel/tcg/translate-all.c | 5 +
hmp-commands-info.hx | 4
monitor.c | 2 ++
3 files changed, 11 insertions(+)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index f768681..dfb9f0d 100644
---
From: Fam Zheng
Not all platforms check whether a lock is initialized before used. In
particular Linux seems to be more permissive than OSX.
Check initialization state explicitly in our code to catch such bugs
earlier.
Signed-off-by: Fam Zheng
Message-Id:
From: Yang Zhong
Move cpu_sync_bndcs_hflags() function from mpx_helper.c
to helper.c because mpx_helper.c need be disabled when
tcg is disabled.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/helper.c
Signed-off-by: Paolo Bonzini
---
accel/tcg/tcg-all.c| 2 +-
include/sysemu/accel.h | 2 +-
vl.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c
index dba9931..e327d90 100644
---
Check for unsupported targets in target_list, and print an
error early in the configuration process.
Signed-off-by: Paolo Bonzini
---
configure | 70 +++
1 file changed, 48 insertions(+), 22 deletions(-)
diff
From: Yang Zhong
If tcg is disabled, the functions in tcg-stub.c file will be called.
This file is target-independent file, do not include any platform
related stub functions into this file.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
hw/i386/kvmvapic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index 82a4955..0d9ef77 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -410,7 +410,8 @@ static
This will be useful when the functions are called, early in the configure
process, to filter out targets that do not support hardware acceleration.
Signed-off-by: Paolo Bonzini
---
configure | 90 ++-
1 file
From: Yang Zhong
translate-all.c will be disabled if tcg is disabled in the build,
so page_size_init() function and related variables will be moved
to exec.c file.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
Reviewed-by: Thomas Huth
Signed-off-by: Paolo Bonzini
---
qemu-doc.texi | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 45f67f6..d2986cb 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@
From: Thomas Huth
CONFIG_SOFTMMU should never be used in common code, so mark
it as poisoned, too.
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id: <1498454578-18709-6-git-send-email-th...@redhat.com>
Signed-off-by:
From: Jason Wang
After converting to use DMA api for virtio devices, we should use
dma_as instead of address_space_memory. Otherwise it won't work if
IOMMU is enabled.
Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api")
Cc: qemu-sta...@nongnu.org
Signed-off-by:
translate-common.c will not be available anymore with --disable-tcg,
so we cannot leave cpu_interrupt_handler there.
Move the TCG-specific handler to accel/tcg/tcg-all.c, and adopt
KVM's handler as the default one, since it works just as well for
Xen and qtest.
Signed-off-by: Paolo Bonzini
From: Peter Maydell
The last users of main_loop_wait() that cared about the return value
have now been changed to no longer use it. Drop the now-useless return
value and make the function return void.
We avoid the awkwardness of ifdeffery to handle the 'ret'
variable
From: Peter Maydell
In QEMU's main_loop() we used to check whether we should do
a nonblocking call to main_loop(); this was deleted in commit e330c118f2a5,
because now that vCPUs always drop the I/O thread lock it is an unnecessary
optimization.
The loop in test-char.c
From: Yang Zhong
Need to disable the tcg related code in the vl.c if the
disable-tcg option is added into ./configure command.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
vl.c | 8 +++-
1 file changed, 7
Using signal to establish a signal handler is not portable; on
SysV systems, the signal handler would be reset to SIG_DFL after
delivery, while BSD preserves the signal handler. Daniel Berrange
reported that (to complicate matters further) the signal system call
has SysV behavior, but glibc
From: Alistair Francis
The original ready < nhandles - 1 can be re-written as ready + 1 <
nhandles. The check was actually incorrect because
WAIT_OBJECT_0 was not subtracted from ready; it worked because
WAIT_OBJECT_0 is zero. After subtracting WAIT_OBJECT_0,
the
From: Sergio Andres Gomez Del Real
This patch pulls out of kvm.c and into the new files the implementation
for the xsave and xrstor instructions. This so they can be shared by
kvm and hvf.
Signed-off-by: Sergio Andres Gomez Del Real
From: Thomas Huth
edu.c does not contain any target-specific code, so we can put
it into common-obj-y to compile it only once for all targets.
Signed-off-by: Thomas Huth
Message-Id: <1498454578-18709-8-git-send-email-th...@redhat.com>
Signed-off-by: Paolo
From: "Daniel P. Berrange"
The 'sun_path' field in the sockaddr_un struct is not required
to be NUL termianted, so when reporting an error, we must use
the separate 'path' variable which is guaranteed terminated.
Fixes a bug spotted by coverity that was introduced in
From: Thomas Huth
pc.h and sysemu/kvm.h are also included from common code (where
CONFIG_KVM is not available), so the #defines that depend on CONFIG_KVM
should not be declared here to avoid that anybody is using them in a
wrong way. Since we're also going to poison CONFIG_KVM
From: Thomas Huth
There does not seem to be any target specific code in this file, so
we can put it into "common-obj" instead of "obj" to compile it only
once for all targets.
Signed-off-by: Thomas Huth
Message-Id:
From: Thomas Huth
CONFIG_KVM is only defined for target-specific code, so nobody should
use it by accident in common code. To avoid such subtle bugs,
CONFIG_KVM is now marked as poisoned in common code. The header
include/sysemu/kvm.h is somewhat special since it is included
From: Sergio Andres Gomez Del Real
This patch simply replaces the separate boolean field in CPUState that
kvm, hax (and upcoming hvf) have for keeping track of vcpu dirtiness
with a single shared field.
Signed-off-by: Sergio Andres Gomez Del Real
From: Wu Xiang
In do_interrupt64(), when interrupt stack table(ist) is enabled
and the the target code segment is conforming(e2 & DESC_C_MASK), the
old implementation always set new CPL to 0, and SS.RPL to 0.
This is incorrect for when CPL3 code access a CPL0 conforming code
From: Thomas Huth
Commit 1f5c00cfdb8114c ("qom/cpu: move tlb_flush to cpu_common_reset")
moved the call to tlb_flush() from the target-specific reset handlers
into the common code qom/cpu.c file, and protected the call with
"#ifdef CONFIG_SOFTMMU" to avoid that it is called for
When attaching the NBD QIOChannel to an AioContext, the TLS channel should
be used, not the underlying socket channel. This is because, trivially,
the TLS channel will be the one that we read/write to and thus the one
that will get the qio_channel_yield() call.
Fixes:
Move the handling of conforming code segments before the handling
of stack switch.
Because dpl == cpl after the new "if", it's now unnecessary to check
the C bit when testing dpl < cpl. Furthermore, dpl > cpl is checked
slightly above the modified code, so the final "else" is unreachable
and we
Max Reitz writes:
> Currently, bdrv_reopen_prepare() assumes that all BDS options are
> strings. However, this is not the case if the BDS has been created
> through the json: pseudo-protocol or blockdev-add.
>
> Note that the user-invokable reopen command is an HMP command, so
The following changes since commit 0c7a8b9baa744ae4323bb46cb4fe942355beaa85:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2017-07-04 11:17:02 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch
From: Thomas Huth
The defines of some *-linux-user targets were still missing.
Suggested-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id: <1498454578-18709-2-git-send-email-th...@redhat.com>
Signed-off-by: Paolo Bonzini
From: Thomas Huth
Since commit 3f2ce724f1f1 ("Move the qemu-ga description into a
separate chapter"), the qemu.1 man page looks pretty much screwed
up, e.g. the title was "qemu-ga - QEMU Guest Agent" instead of
"qemu-doc - QEMU Emulator User Documentation". However, that
> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com]
> Sent: Monday, June 19, 2017 6:15 PM
>
> On 19/06/17 08:54, Bharat Bhushan wrote:
> > Hi Eric,
> >
> > I started added replay in virtio-iommu and came across how MSI interrupts
> with work with VFIO.
> > I understand that on
Max Reitz writes:
> This generic function (along with its implementations for different
> types) determines whether two QObjects are equal.
>
> Signed-off-by: Max Reitz
[...]
> diff --git a/qobject/qnum.c b/qobject/qnum.c
> index 476e81c..784d061 100644
>
Hi,
Q35 has been in QEMU for quite a while. Compared to the current default
i440FX, Q35 is probably not that mature and not widely used, however in
some case, Q35 has advantages, for example, in supporting new features.
For instance, we have some features require PCI-e support which is only
> From: Liu, Yi L
> Sent: Monday, July 3, 2017 6:31 PM
>
> Hi Jean,
>
>
> >
> > > 2. Define a structure in include/uapi/linux/iommu.h(newly added header
> file)
> > >
> > > struct iommu_tlb_invalidate {
> > > __u32 scope;
> > > /* pasid-selective invalidation described by @pasid */
> > >
Hi Bharat,
On 04/07/2017 11:13, Bharat Bhushan wrote:
> Hi Eric,
>
>> -Original Message-
>> From: Eric Auger [mailto:eric.au...@redhat.com]
>> Sent: Wednesday, June 07, 2017 9:31 PM
>> To: eric.auger@gmail.com; eric.au...@redhat.com;
>> peter.mayd...@linaro.org;
Thanks for the review.
>Hi>On Tue, Jul 4, 2017 at 10:51 AM ZhiPeng Lu wrote:>
>>we can get the network interface statistics inside a virtual machine by>
>>guest-network-get-interfaces command. it is very useful for us to monitor>
>>and analyze network traffic.
Hi Richard.
Thank you for finding a bug.
As for the testing
1. I have a small program that calculates fibonacci numbers. I use it to
test mainly stack operations for different CPU flavors (1, 2 or 3 bytes PC).
2. I manually verified that I can debug with gdb, that includes
a. stepping
b.
On 05/07/2017 08:23, Fam Zheng wrote:
>> req->vq = vq;
>> req->dev = s;
>> -qemu_sglist_init(>qsgl, DEVICE(s), 8, _space_memory);
>> +qemu_sglist_init(>qsgl, DEVICE(s), 8, vdev->dma_as);
> Not related to this patch, but is our vIOMMU iotlb implementation safe for
> data
>
On Tue, 07/04 20:21, Jason Wang wrote:
> After converting to use DMA api for virtio devices, we should use
> dma_as instead of address_space_memory. Otherwise it won't work if
> IOMMU is enabled.
>
> Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api")
> Cc: qemu-sta...@nongnu.org
>
301 - 372 of 372 matches
Mail list logo