Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1499955874-10954-1-git-send-email-pbonz...@redhat.com
Subject: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=ba
Hi
On Wed, Jul 12, 2017 at 8:55 AM Peter Xu wrote:
> We have merely all the stuff, but this one is missing. Add it in.
>
> Am going to use this new helper for MigrationParameters fields, since
> most of them are int64_t.
>
> CC: Markus Armbruster
> CC: Eduardo Habkost
> CC: "Marc-André Lureau"
From: "Jason J. Herne"
In QEMU, a guest VCPU always started in and never was able to leave
z/Architecture mode. Now we have an architected way of showing this
condition.
The SIGP SET ARCHITECTURE instruction is simply rejected. Linux as guest
seems to not care about the return value, which is a
From: Fan Zhang
Introduce guarded storage support for KVM guests on s390.
We need to enable the capability, extend machine check validity,
sigp store-additional-status-at-address, and migration.
The feature is fenced for older machine type versions.
Signed-off-by: Fan Zhang
Signed-off-by: Chri
From: "Jason J. Herne"
Add esop and esop2 features to z12 model where esop2 was originally introduced.
Provide a mechanism to disable features in compatibility machines and use this
method to disable esop and esop2 when using compatibility machine v2.9 or
earlier.
Signed-off-by: Jason J. Herne
From: Farhan Ali
If the host supports keyless subset (KSS) then first level
guest (G2) should enable KSS facility as well.
Signed-off-by: Farhan Ali
Reviewed-by: Eric Farman
Signed-off-by: Christian Borntraeger
---
target/s390x/kvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target
Hi
On Wed, Jul 12, 2017 at 1:47 PM Jens Freimann wrote:
> From: Jens Freimann
>
> When recvmsg() returns a message size of zero and
> errno is ENOENT end processing of vhost-user messages.
>
> Without this we run into a vubr_panic() call and get
> PANIC: Error while recvmsg: No such file o
Write the new note section of type 30b (guarded storage control block).
Signed-off-by: Christian Borntraeger
---
include/elf.h| 1 +
target/s390x/arch_dump.c | 18 ++
2 files changed, 19 insertions(+)
diff --git a/include/elf.h b/include/elf.h
index 0dbd3e9..cd51434
From: "Jason J. Herne"
Some new guest features have been introduced recently. Lets wire
them up in the CPU model.
Signed-off-by: Jason J. Herne
Acked-by: Christian Borntraeger
Signed-off-by: Christian Borntraeger
[split patch]
---
include/hw/s390x/sclp.h | 3 +--
target/s390x/cpu_fe
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>
>
> On 07/13/2017 05:11 PM, Dr. David Alan Gilbert wrote:
> > * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> >> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
> >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>
>
>
here is a bunch of patches that teaches recent HW features
to the CPU model and kvm code in QEMU. We also add the
enhanced suppression on protection facility to the z12 and later
for the 2.10 machine type.
Christian Borntraeger (2):
s390x/arch_dump: also dump guarded storage control block
s39
Let's provide the guarded storage registers via gdb server.
Signed-off-by: Christian Borntraeger
---
configure | 2 +-
gdb-xml/s390-gs.xml| 14 ++
target/s390x/gdbstub.c | 24
3 files changed, 39 insertions(+), 1 deletion(-)
create mode 100
On 12 July 2017 at 15:00, Michael Tokarev wrote:
> The same but without two patches from Eric Blake.
> Not resending all the patches, only the cover letter.
>
> The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-
Now that bdrv_is_allocated accepts non-aligned inputs, we can
remove the TODO added in commit d6a644bb.
Signed-off-by: Eric Blake
---
v3: new patch [Kevin]
---
block/io.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/block/io.c b/block/io.c
index df692d2..0e4a3e6 1
In the continuing quest to make more things byte-based, change
the internal iteration of img_compare(). We can finally drop the
TODO assertion added earlier, now that the entire algorithm is
byte-based and no longer has to shift from bytes to sectors.
Most of the change is mechanical ('total_sect
Previously, the alloc command required that input parameters be
sector-aligned and clamped to 32 bits, because the underlying
bdrv_is_allocated used a 32-bit parameter and asserted aligned
inputs. But now that we have fixed block status to report a
64-bit bytes value, and to properly round request
Any device that has request_alignment greater than 512 should be
unable to report status at a finer granularity; it may also be
simpler for such devices to be guaranteed that the block layer
has rounded things out to the granularity boundary (the way the
block layer already rounds all other I/O out
In the continuing quest to make more things byte-based, change
the internal iteration of img_rebase(). We can finally drop the
TODO assertion added earlier, now that the entire algorithm is
byte-based and no longer has to shift from bytes to sectors.
Most of the change is mechanical ('num_sectors
During 'qemu-img compare', when we are checking that an allocated
portion of one file is all zeros, we don't need to waste time
computing how many additional sectors after the first non-zero
byte are also non-zero. Create a new helper find_nonzero() to do
the check for a first non-zero sector, and
Continue on the quest to make more things byte-based instead of
sector-based.
Signed-off-by: Eric Blake
---
v3: new patch
---
qemu-img.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index c0fd773..baf20db 100644
--- a/
In the continuing quest to make more things byte-based, change
compare_sectors(), renaming it to compare_buffers() in the
process. Note that one caller (qemu-img compare) only cares
about the first difference, while the other (qemu-img rebase)
cares about how many consecutive sectors have the same
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() to make the compiler enforce that
we catch all uses. For now, we
If a read error is encountered during 'qemu-img compare', we
were printing the "Error while reading offset ..." message twice.
Update the testsuite for the improved output.
Further simplify the code by hoisting the error code conversion
into the helper function, rather than repeating it at the cal
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change).
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
---
v3: rebase to allocation/mapping sense change, simple enough to keep R-b
v2:
Compare the following images with all-zero contents:
$ truncate --size 1M A
$ qemu-img create -f qcow2 -o preallocation=off B 1G
$ qemu-img create -f qcow2 -o preallocation=metadata C 1G
On my machine, the difference is noticeable for pre-patch speeds,
with more than an order of magnitude in diffe
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
---
v3: rebase to co
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Continue by converting
an internal function (no semantic change), and simplifying its
caller accordingly.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
---
v2-v3: no change
---
qemu-i
As long as we are querying the status for a chunk smaller than
the known image size, we are guaranteed that a successful return
will have set pnum to a non-zero size (pnum is zero only for
queries beyond the end of the file). Use that to slightly
simplify the calculation of the current chunk size
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
---
v3: rebase to al
Not all callers care about which BDS owns the mapping for a given
range of the file. This patch merely simplifies the callers by
consolidating the logic in the common call point, while guaranteeing
a non-NULL file to all the driver callbacks, for no semantic change.
The only caller that does not c
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change), and rename it to is_zero() in the
process.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
---
v3: no change
v2: rename function,
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file
In the process of converting sector-based interfaces to bytes,
I'm finding it easier to represent a byte count as a 64-bit
integer at the block layer (even if we are internally capped
by SIZE_MAX or even INT_MAX for individual transactions, it's
still nicer to not have to worry about truncation/ove
Not all callers care about which BDS owns the mapping for a given
range of the file. In particular, bdrv_is_allocated() cares more
about finding the largest run of allocated data from the guest
perspective, whether or not that data is consecutive from the
host perspective. Therefore, doing subseq
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Change the internal
loop iteration of zeroing a device to track by bytes instead of
sectors (although we are still guaranteed that we iterate by steps
that are sector-aligned).
Signed-off-b
There are patches floating around to add NBD_CMD_BLOCK_STATUS,
but NBD wants to report status on byte granularity (even if the
reporting will probably be naturally aligned to sectors or even
much higher levels). I've therefore started the task of
converting our block status code to report at a byt
On 07/13/2017 05:11 PM, Dr. David Alan Gilbert wrote:
> * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
>> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
On 07/13/2017 02:27 PM, Cornelia Huck wrote:
>> +static v
Hi
On Wed, Jul 12, 2017 at 2:08 AM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Acked-by: Laszlo Ersek
>
>>
>> but I would still like a real Pythonista to review this patch. Adding
>> Janosch.
>>
>>
> sure, let's wait for his feedback
>
>
> Janosch -- can you please help review this
On 12 July 2017 at 12:22, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> In some situations it's useful to have a qdev property which doesn't
>> automatically set its default value when qdev_property_add_static is
>> called (for instance when the default value is not constant).
>>
>> Suppo
On 07/13/17 17:17, Eduardo Habkost wrote:
> On Thu, Jul 13, 2017 at 02:23:39AM +0200, Laszlo Ersek wrote:
>> On 07/13/17 00:27, Michael S. Tsirkin wrote:
>>> On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote:
On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote:
>>>
On Thu, 13 Jul 2017 17:31:59 +0200
Ladi Prosek wrote:
> On Thu, Jul 13, 2017 at 5:20 PM, Cornelia Huck wrote:
> > On Thu, 13 Jul 2017 13:02:37 +0200
> > Ladi Prosek wrote:
> >
> >> virtqueue_error includes queue index in the error output and is preferred
> >> for errors that pertain to a virt
Now that bdrv_truncate is passed to bs->file by default, remove the
callback from block/blkdebug.c and set is_filter to true. is_filter also gives
access to other callbacks that are forwarded automatically to bs->file for
filters.
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-b
On 07/13/17 14:00, gengdongjiu wrote:
> Laszlo,
> Thank you for your review and comments.
>
>
> On 2017/7/13 18:33, Laszlo Ersek wrote:
>> On 07/12/17 04:08, Dongjiu Geng wrote:
[snip]
>>> --- a/include/qemu/uuid.h
>>> +++ b/include/qemu/uuid.h
>>> @@ -44,6 +44,17 @@ typedef struct {
>>>
>>
I've seen enough QMP-related bugs that should've been caught in basic
testing to know we need to become better at testing this stuff. That
means investing into tests/.
QMP is now almost eight years old, but its test coverage has always been
spotty. We don't even really know where the holes are.
On Thu, Jul 13, 2017 at 5:20 PM, Cornelia Huck wrote:
> On Thu, 13 Jul 2017 13:02:37 +0200
> Ladi Prosek wrote:
>
>> virtqueue_error includes queue index in the error output and is preferred
>> for errors that pertain to a virtqueue rather than to the device as a whole.
>>
>> Signed-off-by: Ladi
This function is not used anywhere, so remove it.
Markus Armbruster adds:
The i82078 floppy device model used to call bdrv_media_changed() to
implement its media change bit when backed by a host floppy. This
went away in 21fcf36 "fdc: simplify media change handling".
Probably broke host floppy me
This series makes implementing some of the bdrv_* callbacks easier for block
filters by passing requests to bs->file if bs->drv doesn't implement it instead
of failing, and adding default bdrv_co_get_block_status() implementations.
This is based against commit ced1484322 of
https://github.com/Xan
bdrv_co_get_block_status_from_file() and
bdrv_co_get_block_status_from_backing() set *file to bs->file and
bs->backing respectively, so that bdrv_co_get_block_status() can recurse
to them. Future block drivers won't have to duplicate code to implement
this.
Reviewed-by: Fam Zheng
Reviewed-by: Eri
On Thu, Jul 13, 2017 at 04:21:28PM +1000, Alexey Kardashevskiy wrote:
> e6f7e110ee70 "ppc/xics: remove the XICSState classes" got rid of
> XICSState, this is just an leftover.
>
> Signed-off-by: Alexey Kardashevskiy
Applied to ppc-for-2.10, thanks.
> ---
> include/hw/ppc/pnv_psi.h | 2 --
> 1
The following functions fail if bs->drv is a filter and does not
implement them:
bdrv_probe_blocksizes
bdrv_probe_geometry
bdrv_truncate
bdrv_has_zero_init
bdrv_get_info
Instead, the call should be passed to bs->file if it exists, to allow
filter drivers to support those methods without implement
Am 13.07.2017 um 17:06 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote:
Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote:
Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange:
On Thu, Jul 13,
On Thu, 13 Jul 2017 17:05:45 +0200
Christian Borntraeger wrote:
> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
> > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> >>
> >>
> >> On 07/13/2017 02:27 PM, Cornelia Huck wrote:
> +static void kvm_flic_ais_pre_save(void *opaque)
> >>>
Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote:
Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote:
Okay, so it has to be a mix of QAPI parsing and manual parameter che
On Thu, Jul 13, 2017 at 4:42 PM, Cornelia Huck wrote:
> On Thu, 13 Jul 2017 13:02:32 +0200
> Ladi Prosek wrote:
>
>> Most virtio error output pertains to a specific virtqueue so it makes
>> sense to include the queue index in error messages. This commit makes
>> all error output in virtio.c use t
On 07/12/2017 03:15 PM, Eduardo Habkost wrote:
>
> If we use strverscmp(), it will be sorted in a more reasonable
> way. We could copy the gnulib version on systems without glibc.
> Life is too short for writing configure checks by hand, though; I
> will add this to the end of my wish-todo list.
Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote:
Okay, so it has to be a mix of QAPI parsing and manual parameter checking,
right?
Yeah. It does feel like a valid RFE for QAPI to add a permitted range to
'int' types though, which w
Am 13.07.2017 um 17:17 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 05:13:23PM +0200, Peter Lieven wrote:
Am 13.07.2017 um 17:06 schrieb Daniel P. Berrange:
On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote:
Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange:
On Thu, Jul 13,
On Thu, Jul 13, 2017 at 4:36 PM, Greg Kurz wrote:
> On Thu, 13 Jul 2017 13:02:29 +0200
> Ladi Prosek wrote:
>
>> Output like "Virtqueue size exceeded" is not much useful in identifying the
>> culprit. This series beefs up virtio_error to print the virtio device name
>> and id, and introduces virt
On Thu, 13 Jul 2017 13:02:37 +0200
Ladi Prosek wrote:
> virtqueue_error includes queue index in the error output and is preferred
> for errors that pertain to a virtqueue rather than to the device as a whole.
>
> Signed-off-by: Ladi Prosek
> ---
> hw/virtio/virtio-crypto.c | 56
>
On 07/13/2017 10:13 AM, Peter Lieven wrote:
>>
>>> I currently have the following:
>>>
>>>options = qemu_opts_to_qdict(opts, NULL);
>>>qdict_extract_subqdict(options, &compressopts, "compress.");
Can you show your .json patches as well?
> Yes, but visit_type_Qc
On 13/07/2017 16:35, Eric Blake wrote:
> On 07/13/2017 07:31 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 13.07.2017 15:09, Vladimir Sementsov-Ogievskiy wrote:
>>> 07.07.2017 23:30, Eric Blake wrote:
The NBD Protocol is introducing some additional information
about exports, such as minimum
On Thu, Jul 13, 2017 at 04:00:00AM +0300, Michael S. Tsirkin wrote:
> On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote:
> > We don't want to carry along old machine types forever. If we are able to
> > remove the pc machines up to 0.13 one day for example, this would allow
> > us to even
On Thu, Jul 13, 2017 at 05:13:23PM +0200, Peter Lieven wrote:
> Am 13.07.2017 um 17:06 schrieb Daniel P. Berrange:
> > On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote:
> > > Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange:
> > > > On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieve
On Thu, 13 Jul 2017 13:02:34 +0200
Ladi Prosek wrote:
> virtqueue_error includes queue index in the error output and is preferred
> for errors that pertain to a virtqueue rather than to the device as a whole.
>
> Signed-off-by: Ladi Prosek
> ---
> hw/block/virtio-blk.c | 6 +++---
> 1 file cha
On Thu, Jul 13, 2017 at 02:23:39AM +0200, Laszlo Ersek wrote:
> On 07/13/17 00:27, Michael S. Tsirkin wrote:
> > On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote:
> >> On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote:
> >>> On Wed, Jul 12, 2017 at 05:15:50PM -0300,
Paolo Bonzini writes:
> From: Pranith Kumar
>
> In mttcg, calling pause_all_vcpus() during execution from the
> generated TBs causes a deadlock if some vCPU is waiting for exclusive
> execution in start_exclusive(). Fix this by using the aync_safe_*
> framework instead of pausing vcpus for patc
For a very long time we have used 'uname -s' as our fallback if
we don't identify the target OS using a compiler #define. This
obviously doesn't work for cross-compilation, and we've had
a comment suggesting we fix this in configure for a long time.
Since we now have an exhaustive list of which OSe
On 07/07/2017 03:30 PM, Eric Blake wrote:
> Reply directly in nbd_negotiate_handle_export_name(), rather than
> waiting until nbd_negotiate_options() completes. This will make it
> easier to implement NBD_OPT_GO. Pass additional parameters around,
> rather than stashing things inside NBDClient.
>
On Thu, Jul 13, 2017 at 03:21:37PM +0100, Peter Maydell wrote:
> Solaris 9 was released in 2002, its successor Solaris 10 was
> released in 2005, and Solaris 9 was end-of-lifed in 2014.
> Nobody has stepped forward to express interest in supporting
> Solaris of any flavour, so removing support for
When trying to debug problems with tests it is natural to set
DEBUG=1 when starting the docker environment. Unfortunately
this has a side-effect of enabling an eth0 network interface
in the container, which changes the operating environment of
the test suite. IOW tests with fail may suddenly start
On 07/13/2017 09:21 AM, Peter Maydell wrote:
> Solaris 9 was released in 2002, its successor Solaris 10 was
> released in 2005, and Solaris 9 was end-of-lifed in 2014.
> Nobody has stepped forward to express interest in supporting
> Solaris of any flavour, so removing support for the ancient
> vers
* Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
> > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> >>
> >>
> >> On 07/13/2017 02:27 PM, Cornelia Huck wrote:
> +static void kvm_flic_ais_pre_save(void *opaque)
> +{
> +
On Thu, 13 Jul 2017 13:02:29 +0200
Ladi Prosek wrote:
> Output like "Virtqueue size exceeded" is not much useful in identifying the
> culprit. This series beefs up virtio_error to print the virtio device name
> and id, and introduces virtqueue_error which additionally includes the index
> of the
On 07/13/2017 07:31 AM, Vladimir Sementsov-Ogievskiy wrote:
> 13.07.2017 15:09, Vladimir Sementsov-Ogievskiy wrote:
>> 07.07.2017 23:30, Eric Blake wrote:
>>> The NBD Protocol is introducing some additional information
>>> about exports, such as minimum request size and alignment, as
>>> well as an
On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 07/13/2017 02:27 PM, Cornelia Huck wrote:
+static void kvm_flic_ais_pre_save(void *opaque)
+{
+KVMS390FLICStateMigTmp *tmp = opaque;
+KVMS390FLICState *fli
Hi I have recently created a new documentation page for the Nios2 target. I
would greatly appreciate any feedback you might have on it. Thank you.
Page: http://wiki.qemu.org/Documentation/Platforms/Nios2
On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote:
> Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange:
> > On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote:
> > > Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange:
> > > > On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieve
On 13 July 2017 at 15:11, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> In DEFINE_PROP_ARRAY, because we use a PropertyInfo (qdev_prop_arraylen)
>> which has a .set_default_value member we will set the field to a default
>> value. That default value will be zero, by the C rule that struct
On Thu, 13 Jul 2017 13:02:36 +0200
Ladi Prosek wrote:
> virtqueue_error includes queue index in the error output and is preferred
> for errors that pertain to a virtqueue rather than to the device as a whole.
>
> Signed-off-by: Ladi Prosek
> ---
> hw/scsi/virtio-scsi.c | 2 +-
> 1 file changed
From: "Emilio G. Cota"
Commit e7b161d573 ("vl: add tcg_enabled() for tcg related code") adds
a check to exit the program when !tcg_enabled() while parsing the -tb-size
flag.
It turns out that when the -tb-size flag is evaluated, tcg_enabled() can
only return 0, since it is set (or not) much late
On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote:
> Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange:
> > On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote:
> > > Okay, so it has to be a mix of QAPI parsing and manual parameter checking,
> > > right?
> > Yeah. It does feel l
On Thu, 13 Jul 2017 13:02:35 +0200
Ladi Prosek wrote:
> virtqueue_error includes queue index in the error output and is preferred
> for errors that pertain to a virtqueue rather than to the device as a whole.
>
> Signed-off-by: Ladi Prosek
> ---
> hw/net/virtio-net.c | 24 -
From: Alexey Kardashevskiy
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
as a parent.
This moves IOMMU-related fields from MR to IOMMU MR. However to avoid
dymanic QOM casting in fast path (address_space_translate, etc),
this adds an @is_iommu boolean flag to MR and provide
On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote:
>
> Okay, so it has to be a mix of QAPI parsing and manual parameter checking,
> right?
Yeah. It does feel like a valid RFE for QAPI to add a permitted range to
'int' types though, which would simplify the code in future.
> I currentl
From: Alexey Kardashevskiy
This finishes QOM'fication of IOMMUMemoryRegion by introducing
a IOMMUMemoryRegionClass. This also provides a fastpath analog for
IOMMU_MEMORY_REGION_GET_CLASS().
This makes IOMMUMemoryRegion an abstract class.
Signed-off-by: Alexey Kardashevskiy
Message-Id: <2017071
On 27 April 2017 at 06:46, Michael Roth wrote:
> From: Vinzenz Feenstra
>
> A command that will list all currently logged in users, and the time
> since when they are logged in.
>
> Examples:
>
> virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }'
> {"return":[{"login-time":14906222
From: Alex Bennée
This was only used by the gdbstub and even then was only being set for
subsequent threads. Rather the continue duplicating the number just
make the gdbstub get the information from TaskState structure.
Now the tid is correctly reported for all threads the bug I was seeing
with
On Thu, 13 Jul 2017 13:02:32 +0200
Ladi Prosek wrote:
> Most virtio error output pertains to a specific virtqueue so it makes
> sense to include the queue index in error messages. This commit makes
> all error output in virtio.c use the newly introduced virtqueue_error.
Split out the change intr
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>
>
> On 07/13/2017 02:27 PM, Cornelia Huck wrote:
> >> +static void kvm_flic_ais_pre_save(void *opaque)
> >> +{
> >> +KVMS390FLICStateMigTmp *tmp = opaque;
> >> +KVMS390FLICState *flic = tmp->parent;
> >> +struct kvm_s390_ais_all ais;
>
From: Pranith Kumar
Now that we have proper locking after MTTCG patches have landed, we
can revert the commit. This reverts commit
a9353fe897ca2687e5b3385ed39e3db3927a90e0.
CC: Peter Maydell
CC: Alex Bennée
Signed-off-by: Pranith Kumar
Message-Id: <20170712215143.19594-1-bobby.pr...@gmail.
On 07/13/2017 04:28 PM, Programmingkid wrote:
> Hi I have recently created a new documentation page for the Nios2 target. I
> would greatly appreciate any feedback you might have on it. Thank you.
Great, thanks !
A few nits, we also support nios2 userspace binary emulation. And Nios2
is I believ
On 2017-07-13 10:41, Kevin Wolf wrote:
> Am 12.07.2017 um 18:58 hat Max Reitz geschrieben:
>> On 2017-07-12 16:52, Kevin Wolf wrote:
>>> Am 12.07.2017 um 13:46 hat Pavel Butsykin geschrieben:
This patch add shrinking of the image file for qcow2. As a result, this
allows
us to reduce
From: Eric Blake
The upstream NBD Protocol has defined a new extension to allow
the server to advertise block sizes to the client, as well as
a way for the client to inform the server that it intends to
obey block sizes.
Thanks to a recent fix (commit df7b97ff), our real minimum
transfer size is
From: Anton Nefedov
This allows to change the port's backend runtime, e.g. change it from
file to a socket making it possible to establish a debug session with
WinDbg
> qemu-system [..] -chardev file,id=charchannel2,path=/tmp/charchannel2 \
-device isa-serial,chardev=charchannel2,id=channel2
From: Eric Blake
The NBD protocol has several constants defined in various extensions
that we are about to implement. Expose them to the code, along with
an easy way to map various constants to strings during diagnostic
messages.
Signed-off-by: Eric Blake
Message-Id: <20170707203049.534-4-ebl.
From: Eric Blake
NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure
requires the server to close the connection rather than report an
error to us. Therefore, upstream NBD recently added NBD_OPT_GO as
the improved version of the option that does what we want [1]: it
reports sane erro
On Thu, 13 Jul 2017 13:02:33 +0200
Ladi Prosek wrote:
> virtqueue_error includes queue index in the error output and is preferred
s/includes queue index/includes the queue index/
(also the other patches in this series)
> for errors that pertain to a virtqueue rather than to the device as a who
From: Anton Nefedov
qemu_chr_fe_get_driver() is unsafe, frontends with hotswap support
should not access CharDriver ptr directly as CharDriver might change.
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Marc-André Lureau
Message-Id: <1499342940-56739-5-gi
From: Eric Blake
We really don't care if our spec-compliant reply to NBD_OPT_ABORT
was received, so shave off some lines of code by not even tracing it.
Signed-off-by: Eric Blake
Message-Id: <20170707203049.534-3-ebl...@redhat.com>
Signed-off-by: Paolo Bonzini
---
nbd/server.c | 15 --
201 - 300 of 526 matches
Mail list logo
