Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

2017-07-17 Thread Richard Henderson
On 07/17/2017 06:54 PM, Emilio G. Cota wrote: What threw me off was that in lookup_tb_ptr we're not checking tb->invalid, and that biased me into thinking that it's not needed. But I should have tried harder. Also, that's a bug, and yet another reason to have tb_lookup, so that we fix these

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

[Qemu-devel] [PULL 6/8] qemu-ga: add guest-get-osinfo command

2017-07-17 Thread Michael Roth
From: Tomáš Golembiovský Add a new 'guest-get-osinfo' command for reporting basic information of the guest operating system. This includes machine architecture, version and release of the kernel and several fields from os-release file if it is present (as defined in [1]).

[Qemu-devel] [PULL 3/8] qemu-ga: check if utmpx.h is available on the system

2017-07-17 Thread Michael Roth
From: Tomáš Golembiovský Commit 161a56a9065 added command guest-get-users and requires the utmpx.h (defined by POSIX) to work. It is however not always available (e.g. on OpenBSD) therefor a check for its existence is necessary. Signed-off-by: Tomáš Golembiovský

Re: [Qemu-devel] [PATCH v2 45/45] tcg: enable multiple TCG contexts in softmmu

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: + +/* claim the first free pointer in tcg_ctxs and increment n_tcg_ctxs */ +for (i = 0; i < smp_cpus; i++) { +if (atomic_cmpxchg(_ctxs[i], NULL, s) == NULL) { +unsigned int n; + +n =

[Qemu-devel] [PULL 1/8] qga-win: fix installation on localized windows

2017-07-17 Thread Michael Roth
From: Daniel Rempel Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 Replace hardcoded user and group names ("Administrators", "SYSTEM") with the ones acquired from system. Windows uses localized strings for these names and it may cause the installation to fail.

[Qemu-devel] [PULL 7/8] test-qga: pass environemnt to qemu-ga

2017-07-17 Thread Michael Roth
From: Tomáš Golembiovský Modify fixture_setup() to pass environemnt variables to spawned qemu-ga instance. Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth

[Qemu-devel] [PULL 4/8] qga-win32: remove a redundancy code

2017-07-17 Thread Michael Roth
From: Peng Hao In the first line of run_agent,it has set ga_state = s,don't need set ga_state = s again behind. Signed-off-by: Peng Hao Signed-off-by: Michael Roth --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 0/8] qemu-ga patch queue

2017-07-17 Thread Michael Roth
The following changes since commit ca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170717-pull-request' into staging (2017-07-17 17:54:17 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2017-07

[Qemu-devel] [PULL 5/8] qga: report error on keyfile dump error

2017-07-17 Thread Michael Roth
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Cc:qemu-triv...@nongnu.org Signed-off-by: Michael Roth --- qga/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 2/8] qemu-ga: add missing libpcre to MSI build

2017-07-17 Thread Michael Roth
From: Thomas Lamprecht glib depends on libpcre which was not shipped with the MSI, thus starting of the qemu-ga.exe failed with the respective error message. Tell WIXL to ship this library with the MSI to avoid this problem. Signed-off-by: Thomas Lamprecht

[Qemu-devel] [PULL 8/8] test-qga: add test for guest-get-osinfo

2017-07-17 Thread Michael Roth
From: Tomáš Golembiovský Add test for guest-get-osinfo command. Qemu-ga was modified to accept QGA_OS_RELEASE environment variable. If the variable is defined it is interpreted as path to the os-release file and it is parsed instead of the default paths. Signed-off-by:

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: >> From: Alistair Francis >> >> Convert all uses of error_report("warning:"... to use warn_report() >> instead. This helps standardise on a single method of printing

Re: [Qemu-devel] [PATCH v2 43/45] tcg: introduce regions to split code_gen_buffer

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +#ifdef CONFIG_SOFTMMU +/* + * It is likely that some vCPUs will translate more code than others, so we + * first try to set more regions than smp_cpus, with those regions being + * larger than the minimum code_gen_buffer size. If that's not possible

[Qemu-devel] [PATCH v5 10/10] tcg/tci: enable bswap16_i64

2017-07-17 Thread Philippe Mathieu-Daudé
Altough correctly implemented, bswap16_i64() never got tested/executed so the safety TODO() statement was never removed. Since it got now tested the TODO() can be removed. while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffc00036cd04]

Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 18:26:09 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >+static int qemu_mprotect__osdep(void *addr, size_t size, int prot) > >+{ > >+void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); > >+void *end =

[Qemu-devel] [PATCH v5 06/10] target/sparc: optimize various functions using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- Richard: maybe you need to update 58daf05d07dd to your commit...

[Qemu-devel] [PATCH v5 08/10] target/sparc: optimize gen_op_mulscc() using deposit op

2017-07-17 Thread Philippe Mathieu-Daudé
Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 67a83b77cc..a425efb1f1 100644

[Qemu-devel] [PATCH v5 09/10] target/alpha: optimize gen_cvtlq() using deposit op

2017-07-17 Thread Philippe Mathieu-Daudé
Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/translate.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 232af9e177..2bffbae92f

[Qemu-devel] [PATCH v5 05/10] target/ppc: optimize various functions using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: David Gibson --- Richard: maybe you

[Qemu-devel] [PATCH v5 07/10] target/sparc: optimize gen_op_mulscc() using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé --- Richard: are you ok squashing it with previous commit? maybe you need to update 58daf05d07dd to your commit...

[Qemu-devel] [PATCH v5 02/10] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-07-17 Thread Philippe Mathieu-Daudé
The following thread was helpful while writing this script: https://github.com/coccinelle/coccinelle/issues/86 Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/tcg_gen_extract.cocci | 107 +++ 1 file changed, 107 insertions(+)

[Qemu-devel] [PATCH v5 00/10] optimize various tcg_gen() functions using extract/deposit op

2017-07-17 Thread Philippe Mathieu-Daudé
Hi Richard, Please find here the update series. Maybe you'll need to update the commit sha-1 58daf05d07dd in commits 3-8. Regards, Phil. [v5] - gitignore entries for cocci generated files - cleaned/improved cocci script, updated usage - fix output using Mersenne "number" instead of "prime"

[Qemu-devel] [PATCH v5 03/10] target/arm: optimize aarch64 rev16() using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
Aurelien Jarno denoted this function could be implemented more effectively using the aarch32 rev16() pattern. [http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg03180.html] Done with the Coccinelle semantic patch from commit 58daf05d07dd (see

[Qemu-devel] [PATCH v5 01/10] coccinelle: ignore ASTs pre-parsed cached C files

2017-07-17 Thread Philippe Mathieu-Daudé
files generated using coccinelle tool: 'spatch --use-cache' Signed-off-by: Philippe Mathieu-Daudé --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 09c2363acf..cf65316863 100644 --- a/.gitignore +++ b/.gitignore @@ -116,6 +116,8

[Qemu-devel] [PATCH v5 04/10] target/m68k: optimize bcd_flags() using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Laurent Vivier Reviewed-by: Richard Henderson --- Richard: maybe you need to

Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 17:40:29 -1000, Richard Henderson wrote: > On 07/17/2017 02:27 PM, Emilio G. Cota wrote: > >On Mon, Jul 17, 2017 at 12:55:03 -1000, Richard Henderson wrote: > >>On 07/16/2017 10:03 AM, Emilio G. Cota wrote: > >>>@@ -1073,13 +1073,17 @@ void

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread David Gibson
On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

2017-07-17 Thread Richard Henderson
On 07/17/2017 06:33 PM, Emilio G. Cota wrote: I would prefer either (1) Dynamic allocation. I know we eschew that most places during, but surely this is the exact situation for which it's handy. ... But I guess that's not what you mean with (1)? You mean to allocate every single

Re: [Qemu-devel] [PATCH v2 44/45] translate-all: do not allocate a guard page for code_gen_buffer

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: TCG regions already have a guard page. Signed-off-by: Emilio G. Cota --- accel/tcg/translate-all.c | 47 --- 1 file changed, 12 insertions(+), 35 deletions(-) This should just be

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 17:53:33 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >Groundwork for supporting multiple TCG contexts. (snip) > > struct TCGContext { > > uint8_t *pool_cur, *pool_end; > > TCGPool *pool_first, *pool_current,

Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +static int qemu_mprotect__osdep(void *addr, size_t size, int prot) +{ +void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); +void *end = QEMU_ALIGN_PTR_UP(addr + size, qemu_real_host_page_size); I'm not keen on this. Any

Re: [Qemu-devel] [PATCH v2 39/45] osdep: move qemu_real_host_page_size/mask to osdep

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: These only depend on the host and therefore belong in the common osdep, not in a target-dependent object. Signed-off-by: Emilio G. Cota --- include/exec/cpu-all.h | 2 -- include/qemu/osdep.h | 8 exec.c

Re: [Qemu-devel] [PATCH v2 37/45] tcg: introduce **tcg_ctxs to keep track of all TCGContext's

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. Note that having n_tcg_ctxs is unnecessary. However, it is convenient to have it, since it will simplify iterating over the array: we'll have just a for loop instead of having to iterate over a

[Qemu-devel] [PULL 2/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-17 Thread Jeff Cody
From: Kashyap Chamarthy This patch documents (including their QMP invocations) all the four major kinds of live block operations: - `block-stream` - `block-commit` - `drive-mirror` (& `blockdev-mirror`) - `drive-backup` (& `blockdev-backup`) Things considered while

Re: [Qemu-devel] [PATCH v2 38/45] tcg: distribute profiling counters across TCGContext's

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +#define PROF_ADD_MAX(to, from, field) \ +do {\ +typeof((from)->field) val__ = atomic_read(&((from)->field));\ +if (val__ >

[Qemu-devel] [PULL 1/2] bitmaps.md: Convert to rST; move it into 'interop' dir

2017-07-17 Thread Jeff Cody
From: Kashyap Chamarthy This is part of the on-going effort to convert QEMU upstream documentation syntax to reStructuredText (rST). The conversion to rST was done using: $ pandoc -f markdown -t rst bitmaps.md -o bitmaps.rst Then, make a couple of small syntactical

[Qemu-devel] [PULL 0/2] Block patches

2017-07-17 Thread Jeff Cody
The following changes since commit ca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170717-pull-request' into staging (2017-07-17 17:54:17 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block

Re: [Qemu-devel] [Qemu-block] [PATCH v7 0/2] Rewrite 'live-block-ops.txt'; convert 'bitmaps.md' to rST

2017-07-17 Thread Jeff Cody
On Mon, Jul 17, 2017 at 12:52:03PM +0200, Kashyap Chamarthy wrote: > v7: Address feedback from Eric; add his 'Reviewed-by' on both patches; > also retain John Snow's 'Reviewed-by' on bitmaps.rst > v6: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02188.html > v5:

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. Signed-off-by: Emilio G. Cota --- tcg/tcg.h | 12 tcg/optimize.c | 40 +++- 2 files changed, 35 insertions(+), 17

[Qemu-devel] [PATCH v3 09/10] migration: provide migrate_cap_add()

2017-07-17 Thread Peter Xu
Abstracted from migrate_set_block_enabled() to allocate MigrationCapabilityStatusList properly. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v3 08/10] migration: provide migrate_caps_check()

2017-07-17 Thread Peter Xu
Abstract helper function to check migration capabilities (from the old qmp_migrate_set_capabilities). Prepare to be used somewhere else. There is side effect on the change: when applying the capabilities, we were skipping the invalid ones, but still applying the valid ones (if they are provided

[Qemu-devel] [PATCH v3 07/10] migration: remove check against colo support

2017-07-17 Thread Peter Xu
Since commit a15215f3 ("build: remove --enable-colo/--disable-colo"), colo is always supported. We don't need any colo_supported() now since it is always true. Removing any extra code that depends on it. CC: Paolo Bonzini CC: Hailiang Zhang

[Qemu-devel] [PATCH v3 06/10] migration: check global params for validity

2017-07-17 Thread Peter Xu
Adding validity check for the migration parameters passed in via global properties. Signed-off-by: Peter Xu --- migration/migration.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/migration/migration.c

Re: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

2017-07-17 Thread Richard Henderson
On 07/17/2017 05:18 PM, Philippe Mathieu-Daudé wrote: On 05/12/2017 09:08 PM, Richard Henderson wrote: On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: [...] static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst,

[Qemu-devel] [PATCH v3 04/10] migration: introduce migrate_params_check()

2017-07-17 Thread Peter Xu
Helper to check the parameters. Abstracted from qmp_migrate_set_parameters(). Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-)

Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

2017-07-17 Thread Richard Henderson
On 07/17/2017 02:27 PM, Emilio G. Cota wrote: On Mon, Jul 17, 2017 at 12:55:03 -1000, Richard Henderson wrote: On 07/16/2017 10:03 AM, Emilio G. Cota wrote: @@ -1073,13 +1073,17 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) assert_tb_locked(); -

[Qemu-devel] [PATCH v3 03/10] migration: export capabilities to props

2017-07-17 Thread Peter Xu
Do the same thing to migration capabilities, just like what we did in previous patch for migration parameters. Reviewed-by: Juan Quintela Reviewed-by: Eduardo Habkost Signed-off-by: Peter Xu --- migration/migration.c | 17

[Qemu-devel] [PATCH v3 02/10] migration: export parameters to props

2017-07-17 Thread Peter Xu
Export migration parameters to qdev properties. Then we can use, for example: -global migration.x-cpu-throttle-initial=xxx To specify migration parameters during init. Prefix "x-" is appended for each parameter exported to show that this is not a stable interface, and only for

Re: [Qemu-devel] [PATCH v2 21/45] tcg: check CF_PARALLEL instead of parallel_cpus

2017-07-17 Thread Richard Henderson
On 07/17/2017 02:34 PM, Emilio G. Cota wrote: On Mon, Jul 17, 2017 at 13:55:42 -1000, Richard Henderson wrote: On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Thereby decoupling the resulting translated code from the current state of the system. The tb->cflags field is not passed to tcg

[Qemu-devel] Is compressed qcow2 better in read/write performance?

2017-07-17 Thread 陳培泓
qcow2 support compress option to compress image file. I try to read both files through API by libguestfs(such as pread_device) I'm confused with the performance during read or write I tried to compress A.qcow2 to A_compress.qcow2 and it changes from 16GB to 23MB I tried read on

[Qemu-devel] [PATCH v3 10/10] migration: check global caps for validity

2017-07-17 Thread Peter Xu
Checks validity for all the capabilities that we enabled with command line. Signed-off-by: Peter Xu --- migration/migration.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index

[Qemu-devel] [PATCH v3 05/10] migration: provide migrate_params_apply()

2017-07-17 Thread Peter Xu
Abstracted from qmp_migrate_set_parameters(). Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/migration/migration.c

Re: [Qemu-devel] [Qemu-ppc] [PULL 06/21] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-07-17 Thread David Gibson
On Mon, Jul 17, 2017 at 09:54:45PM +0200, Laurent Vivier wrote: > On 30/06/2017 12:46, David Gibson wrote: > > From: Bharata B Rao > > > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > stream (in the place of HPT size) when the guest doesn't

[Qemu-devel] [PATCH v3 00/10] migration: export cap/params to qdev props

2017-07-17 Thread Peter Xu
v3: - add r-b properly on each patch - patch 1: fix commit message [Eric] - patch 4: dropped since not used any more [Eduardo] - patch 7 (new patch 6): move the check from post_init() into migration_object_init() [Eduardo] - patch 10 (new patch 9): rename var "head" -> "list" [Juan] - patch 11:

[Qemu-devel] [PATCH v3 01/10] qdev: provide DEFINE_PROP_INT64()

2017-07-17 Thread Peter Xu
We have nearly all the stuff, but this one is missing. Add it in. Am going to use this new helper for MigrationParameters fields, since most of them are int64_t. CC: Markus Armbruster CC: Eduardo Habkost CC: Marc-André Lureau

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Fix obsolete comment about MSIX encoding in addr/data

2017-07-17 Thread David Gibson
On Tue, Jul 18, 2017 at 12:00:33PM +1000, Alexey Kardashevskiy wrote: > f1c2dc7c866a "spapr-pci: rework MSI/MSIX" (07/2013) changed MSIX encoding > but forgot to change the comment so this changes it. > > Signed-off-by: Alexey Kardashevskiy Applied to ppc-for-2.10, thanks. >

Re: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

2017-07-17 Thread Philippe Mathieu-Daudé
On 05/12/2017 09:08 PM, Richard Henderson wrote: On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: [...] static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, TCGv src2) // env->y = (b2 << 31) |

Re: [Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add()

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 07:14:44PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Abstracted from migrate_set_block_enabled() to allocate > > MigrationCapabilityStatusList properly. > > > > Signed-off-by: Peter Xu > > Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 3/8] target/alpha: Merge several flag bytes into ENV->FLAGS

2017-07-17 Thread Richard Henderson
On 07/17/2017 03:53 PM, Emilio G. Cota wrote: On Thu, Jul 13, 2017 at 14:18:14 -1000, Richard Henderson wrote: The flags are arranged such that we can manipulate them either a whole, or as individual bytes. The computation within cpu_get_tb_cpu_state is now reduced to a single load and mask.

[Qemu-devel] Question for iotests 188, 189 and 087

2017-07-17 Thread Jing Liu
Hi all, Do you anybody have iotests failure: 188, 189 and 087 of the latest qemu upsteam? I just wondered if it has something wrong with my test machines because I have different results with two machines. Thanks. Jing

[Qemu-devel] [PATCH v2.5 3/5] docker: add debian Ports base image

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-ports.docker | 35 1 file changed, 35 insertions(+) create mode 100644 tests/docker/dockerfiles/debian-ports.docker diff --git a/tests/docker/dockerfiles/debian-ports.docker

[Qemu-devel] [PATCH v2.5 4/5] docker: warn users to use newer debian8/debian9 base image

2017-07-17 Thread Philippe Mathieu-Daudé
to stay backward incompatible. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian.docker | 13 + 2 files changed, 14 insertions(+) create mode 100644 tests/docker/dockerfiles/debian.docker diff

[Qemu-devel] [PATCH v2.5 1/5] docker: add MXE (M cross environment) base image for MinGW-w64

2017-07-17 Thread Philippe Mathieu-Daudé
see http://mxe.cc/ Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 3 ++ tests/docker/dockerfiles/debian-win32-cross.docker | 32 ++ tests/docker/dockerfiles/debian-win64-cross.docker | 32

[Qemu-devel] [PATCH v2.5 5/5] docker: install clang since Shippable setup_ve() verify it is available

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian9.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/debian9.docker b/tests/docker/dockerfiles/debian9.docker index 056e5389cc..a4509950e6 100644 ---

[Qemu-devel] [PATCH v2.5 2/5] shippable: add win32/64 targets

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 4 1 file changed, 4 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 53b43b349f..dd4bbc84b1 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -7,6 +7,10 @@ env: matrix: -

[Qemu-devel] [PATCH v2.5 0/5] (more) Updated Travis Queue

2017-07-17 Thread Philippe Mathieu-Daudé
Sorry I messed previous series... just updated last 5 patches of v2. v2.5: - MXE replaced by s - docker9/ports: lost package 'clang' re-added - include patch keep 'debian.docker' base image backward incompatible On 07/17/2017 09:31 PM, Philippe Mathieu-Daudé wrote: > Hi, > > a bit late, but

Re: [Qemu-devel] [PATCH 2/2] vfio/ccw: fix initialization of the Object DeviceState pointer in the common base-device

2017-07-17 Thread Dong Jia Shi
* Alex Williamson [2017-07-17 20:26:53 -0600]: > On Tue, 18 Jul 2017 03:49:26 +0200 > Dong Jia Shi wrote: > > > Commit 7da624e2 ("vfio: Test realized when using VFIOGroup.device_list > > iterator") introduced a pointer to the Object

Re: [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 11:33:55PM -0300, Eduardo Habkost wrote: > On Tue, Jul 18, 2017 at 09:56:06AM +0800, Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:25:05PM -0300, Eduardo Habkost wrote: > > > On Mon, Jul 17, 2017 at 04:26:07PM +0800, Peter Xu wrote: > > > > Adding validity check for the

Re: [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity

2017-07-17 Thread Eduardo Habkost
On Tue, Jul 18, 2017 at 09:56:06AM +0800, Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:25:05PM -0300, Eduardo Habkost wrote: > > On Mon, Jul 17, 2017 at 04:26:07PM +0800, Peter Xu wrote: > > > Adding validity check for the migration parameters passed in via global > > > properties. > > > > > >

Re: [Qemu-devel] [PATCH 2/2] vfio/ccw: fix initialization of the Object DeviceState pointer in the common base-device

2017-07-17 Thread Alex Williamson
On Tue, 18 Jul 2017 03:49:26 +0200 Dong Jia Shi wrote: > Commit 7da624e2 ("vfio: Test realized when using VFIOGroup.device_list > iterator") introduced a pointer to the Object DeviceState in the VFIO > common base-device and skiped non-realized devices as we iterate

Re: [Qemu-devel] Disable image locking for snapshot drive?

2017-07-17 Thread Andrew Baumann via Qemu-devel
> From: John Snow [mailto:js...@redhat.com] > Sent: Monday, 17 July 2017 17:34 > On 07/17/2017 07:30 PM, Andrew Baumann via Qemu-devel wrote: > > Hi all, > > > > I'm running a recent Linux build of qemu on Windows Subsystem for Linux > (WSL) which doesn't appear to implement file locking: > > > >

Re: [Qemu-devel] [PATCH V2 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-17 Thread Zhang Chen
On 07/17/2017 08:24 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 07/14/2017 08:10 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: If colo-compare find out the first different packet that means the following

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-17 Thread Wei Wang
On 07/17/2017 11:24 PM, Michal Hocko wrote: On Fri 14-07-17 22:17:13, Michael S. Tsirkin wrote: On Fri, Jul 14, 2017 at 02:30:23PM +0200, Michal Hocko wrote: On Wed 12-07-17 20:40:19, Wei Wang wrote: This patch adds support for reporting blocks of pages on the free list specified by the

[Qemu-devel] [PATCH qemu] spapr_pci: Fix obsolete comment about MSIX encoding in addr/data

2017-07-17 Thread Alexey Kardashevskiy
f1c2dc7c866a "spapr-pci: rework MSI/MSIX" (07/2013) changed MSIX encoding but forgot to change the comment so this changes it. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ppc/spapr_pci.c

Re: [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 03:25:05PM -0300, Eduardo Habkost wrote: > On Mon, Jul 17, 2017 at 04:26:07PM +0800, Peter Xu wrote: > > Adding validity check for the migration parameters passed in via global > > properties. > > > > Signed-off-by: Peter Xu > > --- > >

Re: [Qemu-devel] [PATCH 3/8] target/alpha: Merge several flag bytes into ENV->FLAGS

2017-07-17 Thread Emilio G. Cota
On Thu, Jul 13, 2017 at 14:18:14 -1000, Richard Henderson wrote: > The flags are arranged such that we can manipulate them either > a whole, or as individual bytes. The computation within > cpu_get_tb_cpu_state is now reduced to a single load and mask. > > Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 2/2] vfio/ccw: fix initialization of the Object DeviceState pointer in the common base-device

2017-07-17 Thread Dong Jia Shi
Commit 7da624e2 ("vfio: Test realized when using VFIOGroup.device_list iterator") introduced a pointer to the Object DeviceState in the VFIO common base-device and skiped non-realized devices as we iterate VFIOGroup.device_list. While it missed to initialize the pointer for the vfio-ccw case.

[Qemu-devel] [PATCH 1/2] vfio/ccw: allocate irq info with the right size

2017-07-17 Thread Dong Jia Shi
From: Jing Zhang When allocating memory for the vfio_irq_info parameter of the VFIO_DEVICE_GET_IRQ_INFO ioctl, we used the wrong size. Let's fix it by using the right size. Reviewed-by: Dong Jia Shi Signed-off-by: Jing Zhang

[Qemu-devel] [PATCH 0/2] vfio-ccw bugfixs

2017-07-17 Thread Dong Jia Shi
Dear Conny, Here we got two bugfix patches for vfio-ccw: - fix commit 7da624e2 which missed to initialize a new introduced pointer for the vfio-ccw case - fix a memory allocation that used a wrong size for an irq info variable Dong Jia Shi (1): vfio/ccw: fix initialization of the Object

Re: [Qemu-devel] [PULL 00/18] target-arm queue

2017-07-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/18] target-arm queue Message-id: 1500295494-8991-1-git-send-email-peter.mayd...@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2 03/11] migration: export capabilities to props

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 06:58:44PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Do the same thing to migration capabilities, just like what we did in > > previous patch for migration parameters. > > > > Signed-off-by: Peter Xu > > Reviewed-by: Juan

Re: [Qemu-devel] [PATCH v2 01/11] qdev: provide DEFINE_PROP_INT64()

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 11:30:47AM -0500, Eric Blake wrote: > On 07/17/2017 03:26 AM, Peter Xu wrote: > > We have merely all the stuff, but this one is missing. Add it in. > > s/merely/nearly/ Will fix this without removing r-bs. Thanks, > > > > > Am going to use this new helper for

Re: [Qemu-devel] [PATCH v4 4/6] migration/rdma: Allow cancelling while waiting for wrid

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 12:09:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When waiting for a WRID, if the other side dies we end up waiting > for ever with no way to cancel the migration. > Cure this by poll()ing the fd first with a

Re: [Qemu-devel] [PATCH v4 3/6] migration/rdma: fix qemu_rdma_block_for_wrid error paths

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 12:09:33PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The two places that 'goto err_block_for_wrid' weren't setting ret > and so would end up returning 0 even though we've failed. > > Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v2 03/11] migration: export capabilities to props

2017-07-17 Thread Peter Xu
On Mon, Jul 17, 2017 at 02:52:31PM -0300, Eduardo Habkost wrote: > On Mon, Jul 17, 2017 at 04:26:03PM +0800, Peter Xu wrote: > > Do the same thing to migration capabilities, just like what we did in > > previous patch for migration parameters. > > > > Signed-off-by: Peter Xu >

Re: [Qemu-devel] [PATCH v5 0/2] qemu-img: Check for backing image if specified during create

2017-07-17 Thread John Snow
Kevin: I took a stab at this 'feature', but if there are any fixups or changes that need to occur and it's important that it happens before I'm awake, please feel free to steal these patches and do whatever you need to them, including setting them on fire. Thanks, --John post-script: I think the

Re: [Qemu-devel] [PATCH v2 21/45] tcg: check CF_PARALLEL instead of parallel_cpus

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 13:55:42 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >Thereby decoupling the resulting translated code from the current state > >of the system. > > > >The tb->cflags field is not passed to tcg generation functions. So > >we add a bit to

[Qemu-devel] [PATCH] docker: warn users to use newer debian8/debian9 base image

2017-07-17 Thread Philippe Mathieu-Daudé
to stay backward incompatible. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian.docker | 13 + 2 files changed, 14 insertions(+) create mode 100644 tests/docker/dockerfiles/debian.docker diff

[Qemu-devel] [PATCH v5 2/2] qemu-img: Check for backing image if specified during create

2017-07-17 Thread John Snow
Or, rather, force the open of a backing image if one was specified for creation. Using a similar -unsafe option as rebase, allow qemu-img to ignore the backing file validation if possible. It may not always be possible, as in the existing case when a filesize for the new image was not specified.

[Qemu-devel] [PATCH v5 0/2] qemu-img: Check for backing image if specified during create

2017-07-17 Thread John Snow
We do not currently guarantee that QEMU will or will not open a backing file when creating a new overlay file. Presently, QEMU will not open that file if you provide a filesize, because it has no reason to want to open it in that case. This series makes the contract more explicit: if '-u' is

[Qemu-devel] [PATCH v5 1/2] blockdev: move BDRV_O_NO_BACKING option forward

2017-07-17 Thread John Snow
For both external_snapshot_prepare and qmp_drive_mirror, we eventually append the option BDRV_O_NO_BACKING. However, we generally do so after we create the image. To accommodate image creation wanting to verify that a backing file exists or not, add this option prior to create to override

Re: [Qemu-devel] Disable image locking for snapshot drive?

2017-07-17 Thread John Snow
On 07/17/2017 07:30 PM, Andrew Baumann via Qemu-devel wrote: > Hi all, > > I'm running a recent Linux build of qemu on Windows Subsystem for Linux (WSL) > which doesn't appear to implement file locking: > > $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0 -device >

[Qemu-devel] [PATCH v2 27/31] docker: add debian/mips64el image

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + .../dockerfiles/debian-mips64el-cross.docker | 30 ++ 2 files changed, 31 insertions(+) create mode 100644

[Qemu-devel] [PATCH v2 31/31] docker: add debian Ports base image

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-ports.docker | 34 1 file changed, 34 insertions(+) create mode 100644 tests/docker/dockerfiles/debian-ports.docker diff --git a/tests/docker/dockerfiles/debian-ports.docker

[Qemu-devel] [PATCH v2 26/31] shippable: use debian/mips[eb] targets

2017-07-17 Thread Philippe Mathieu-Daudé
previous commit change image mips little -> big endian Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.shippable.yml b/.shippable.yml index fa54df6cff..f2a904014a 100644 --- a/.shippable.yml +++

[Qemu-devel] [PATCH v2 30/31] shippable: add win32/64 targets

2017-07-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .shippable.yml | 4 1 file changed, 4 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 53b43b349f..dd4bbc84b1 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -7,6 +7,10 @@ env: matrix: -

[Qemu-devel] [PATCH v2 20/31] util/cacheinfo: add missing include

2017-07-17 Thread Philippe Mathieu-Daudé
This include was forgotten when splitting cacheinfo.c out of tcg/ppc/tcg-target.inc.c (see commit b255b2c8). While compiling on powerpc: CC util/cacheinfo.o qemu/util/cacheinfo.c: In function 'arch_cache_info': qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared

  1   2   3   4   5   6   >