Re: [Qemu-devel] [RFC 16/29] qmp: hmp: add migrate "resume" option

On Tue, Aug 01, 2017 at 12:03:48PM +0100, Daniel P. Berrange wrote: > On Fri, Jul 28, 2017 at 04:06:25PM +0800, Peter Xu wrote: > > It will be used when we want to resume one paused migration. > > > > Signed-off-by: Peter Xu > > --- > > hmp-commands.hx | 7 --- > >

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

> > > > * Xen fix (Anthony) > > * chardev fixes (Anton, Marc-André) > > * small dead code removal (Zhongyi) > > * documentation (Dan) > > * bugfixes (David) > > * decrease migration downtime (Jay) > > * improved error output

Re: [Qemu-devel] [RFC 12/29] migration: allow dst vm pause on postcopy

On Tue, Aug 01, 2017 at 10:47:16AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: [...] > > +/* Return true if we should continue the migration, or false. */ > > +static bool postcopy_pause_incoming(MigrationIncomingState *mis) > > +{ > > +

Re: [Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast"

On Tue, Aug 01, 2017 at 09:50:02AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Jul 31, 2017 at 07:52:24PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > This provides a way to start postcopy ASAP when migration

Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert()

On Tue, Aug 01, 2017 at 09:40:09AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Jul 31, 2017 at 06:11:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > It is used to invert the whole bitmap. > > > > > > Would

[Qemu-devel] [PATCH 0/2] migration: fixes for 2.10

Two patches isolated from the postcopy recovery series, which may be good for 2.10. Peter Xu (2): migration: fix comment disorder in RAMState io: fix qio_channel_socket_accept err handling io/channel-socket.c | 3 ++- migration/ram.c | 4 ++-- 2 files changed, 4 insertions(+), 3

[Qemu-devel] [PATCH 2/2] io: fix qio_channel_socket_accept err handling

When accept failed, we should setup errp with the reason. More importantly, the caller may assume errp be non-NULL when error happens, and not setting the errp may crash QEMU. At the same time, move the trace_qio_channel_socket_accept_fail() after the if check on EINTR. Two reasons: 1. when

[Qemu-devel] [PATCH 1/2] migration: fix comment disorder in RAMState

Comments for "migration_dirty_pages" and "bitmap_mutex" are switched. Fix it. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

On Tue, Aug 01, 2017 at 09:55:08AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Aug 01, 2017 at 10:25:19AM +0800, Peter Xu wrote: > > > On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu

Re: [Qemu-devel] [for-2.11 PATCH 26/26] spapr: add hotplug hooks for PHB hotplug

On Tue, Aug 01, 2017 at 05:30:46PM +0200, Greg Kurz wrote: > On Fri, 28 Jul 2017 14:24:03 +1000 > David Gibson wrote: > > > On Thu, Jul 27, 2017 at 07:09:55PM +0200, Greg Kurz wrote: > > > On Thu, 27 Jul 2017 14:41:31 +1000 > > > Alexey Kardashevskiy

Re: [Qemu-devel] [for-2.11 PATCH 24/26] spapr: allow guest to update the XICS phandle

On Tue, Aug 01, 2017 at 01:26:15PM +0200, Greg Kurz wrote: > On Tue, 1 Aug 2017 12:20:56 +1000 > Alexey Kardashevskiy wrote: > > > On 31/07/17 14:58, David Gibson wrote: > > > On Fri, Jul 28, 2017 at 08:20:57AM +0200, Thomas Huth wrote: > > >> On 28.07.2017 06:02, David Gibson

Re: [Qemu-devel] [RFC V2 0/4] vfio: Introduce Live migration capability to vfio_mdev device

> -Original Message- > From: Tian, Kevin > Sent: Monday, July 31, 2017 2:55 PM > To: Zhang, Yulei ; qemu-devel@nongnu.org > Cc: joonas.lahti...@linux.intel.com; zhen...@linux.intel.com; Zheng, Xiao > ; Wang, Zhi A ; >

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets inthe IOThreadofthe primary

>On Tue, 08/01 12:25, Paolo Bonzini wrote: >> On 28/07/2017 02:25, Fam Zheng wrote: >> > On Thu, 07/27 15:47, Zhang Chen wrote: >> >> CC. Fam and David. >> >> >> >> Any idea about it? >> > >> > Is it possible to use g_main_context_{push,pop}_thread_default to "move" >> > chardev >> >

Re: [Qemu-devel] [PATCH v2 2/2] s390x/css: generate solicited crw for rchp completion signaling

* Halil Pasic [2017-08-01 17:16:37 +0200]: > > > On 08/01/2017 09:57 AM, Dong Jia Shi wrote: > [..] > > --- a/hw/s390x/css.c > > +++ b/hw/s390x/css.c > > @@ -1745,10 +1745,10 @@ int css_do_rchp(uint8_t cssid, uint8_t chpid) > > } > > > > /* We don't really

Re: [Qemu-devel] Does qemu guest agent support 'guest-exec'?

Best Regards, Robert Hoo > -Original Message- > From: Michael Roth [mailto:mdr...@linux.vnet.ibm.com] > Sent: Wednesday, August 2, 2017 0:44 > To: Hu, Robert ; qemu-devel@nongnu.org; qemu- > disc...@nongnu.org > Subject: Re: [Qemu-devel] Does qemu guest agent

Re: [Qemu-devel] [PATCH v2 1/2] s390x/css: use macro for event-information pending error recover code

* Halil Pasic [2017-08-01 17:24:10 +0200]: > > > On 08/01/2017 09:57 AM, Dong Jia Shi wrote: > > Let's use a macro for the ERC (error recover code) when generating a > > Channel Subsystem Event-information pending CRW (channel report word). > > > > While we are at

Re: [Qemu-devel] [RFC PATCH] booke206: fix MAS update on tlb miss

On Tue, Aug 01, 2017 at 10:44:57AM +0200, KONRAD Frederic wrote: > When a tlb instruction miss happen, rw is set to 0 at the bottom > of cpu_ppc_handle_mmu_fault which cause the MAS update function to miss > the SAS and TS bit in MAS6, MAS1 in booke206_update_mas_tlb_miss. > > Just calling

[Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

TYPE_VIRTIO_DEVICE devices are already not usable with -device and device_add, but they are reported as user-creatable on "-device help" and through monitor interfaces. Mark them as not user-creatable to avoid confusing users, and to allow automated testing (e.g. scripts/device-crash-test) to

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

On 08/01/17 23:39, Michael S. Tsirkin wrote: > On Wed, Aug 02, 2017 at 12:33:12AM +0300, Alexander Bezzubikov wrote: >> 2017-08-01 23:31 GMT+03:00 Laszlo Ersek : >>> (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) >>> >>> On 07/29/17 01:37, Aleksandr

Re: [Qemu-devel] [PATCH 1/1] qemu-iotests/109: Fix lock race condition

On 08/01/2017 05:31 PM, Cleber Rosa wrote: > A race condition is currently present between the clean up attempt of > the QEMU process and the execution of qemu-img. The actual (bad) > output is: > > -Warning: Image size mismatch! > -Images are identical. > +qemu-img: Could not open

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] qemu-iotests/109: Fix lock race condition

On Tue, Aug 01, 2017 at 05:31:27PM -0400, Cleber Rosa wrote: > A race condition is currently present between the clean up attempt of > the QEMU process and the execution of qemu-img. The actual (bad) > output is: > > -Warning: Image size mismatch! > -Images are identical. > +qemu-img: Could

Re: [Qemu-devel] [PATCH for-2.10 1/1] qemu-iotests/109: Fix lock race condition

On 08/01/2017 04:31 PM, Cleber Rosa wrote: > A race condition is currently present between the clean up attempt of > the QEMU process and the execution of qemu-img. The actual (bad) > output is: > > -Warning: Image size mismatch! > -Images are identical. > +qemu-img: Could not open

Re: [Qemu-devel] [PULL 06/10] accel: cleanup error output

On 08/01/2017 04:37 PM, Michael S. Tsirkin wrote: > From: Laurent Vivier > > Only emit "XXX accelerator not found", if there are not > further accelerators listed. eg > >accel=kvm:tcg > > doesn't print a "KVM accelerator not found" warning > when it falls back to tcg,

[Qemu-devel] [PATCH 1/1] qemu-iotests/109: Fix lock race condition

A race condition is currently present between the clean up attempt of the QEMU process and the execution of qemu-img. The actual (bad) output is: -Warning: Image size mismatch! -Images are identical. +qemu-img: Could not open '/tests/qemu-iotests/scratch/t.raw': Failed to get "consistent

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

On Wed, Aug 02, 2017 at 12:33:12AM +0300, Alexander Bezzubikov wrote: > 2017-08-01 23:31 GMT+03:00 Laszlo Ersek : > > (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) > > > > On 07/29/17 01:37, Aleksandr Bezzubikov wrote: > >> Signed-off-by: Aleksandr

[Qemu-devel] [PULL 09/10] pc: make 'pc.rom' readonly when machine has PCI enabled

From: Igor Mammedov looking at bios ROM mapping in QEMU it seems that only isapc (i.e. not PCI enabled machine) requires ROM being mapped as RW in other cases BIOS is mapped as RO. Do the same for option ROM 'pc.rom' when machine has PCI enabled. As useful side-effect

[Qemu-devel] [PULL 08/10] vhost-user: fix watcher need be removed when vhost-user hotplug

From: Yunjian Wang "nc" is freed after hotplug vhost-user, but the watcher is not removed. The QEMU crash when the watcher access the "nc" when socket disconnects. Program received signal SIGSEGV, Segmentation fault. #0 object_get_class (obj=obj@entry=0x2) at

[Qemu-devel] [PULL 10/10] pc: acpi: force FADT rev1 for 440fx based machine types

From: Igor Mammedov w2k used to boot on QEMU until revision of FADT has been bumped to rev3 (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.) Keep PC machine at rev1 to remain compatible and Q35 at rev3 where w2k isn't

Re: [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error

On Tue, Aug 01, 2017 at 08:34:01AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > Now that ./check takes care of cleaning up after each tests, it > > can also selectively not clean up. Add option to leave all output from > > tests intact if that test encountered an

[Qemu-devel] [PULL 06/10] accel: cleanup error output

From: Laurent Vivier Only emit "XXX accelerator not found", if there are not further accelerators listed. eg accel=kvm:tcg doesn't print a "KVM accelerator not found" warning when it falls back to tcg, but a accel=kvm prints a warning, since no fallback is given.

[Qemu-devel] [PULL 03/10] vhost-user: fix legacy cross-endian configurations

From: Felipe Franciosi Currently, vhost-user does not implement any means for notifying the backend about guest endianess. This commit introduces a new message called VHOST_USER_SET_VRING_ENDIAN which is analogous to the ioctl() called VHOST_SET_VRING_ENDIAN used for kernel

[Qemu-devel] [PULL 07/10] tests/bios-tables-test: Compiler warning fix

From: "Dr. David Alan Gilbert" gcc 7.1.1 in fedora 26 moans about the: tables = g_new0(uint32_t, tables_nr) because it can't convince itself that tables_nr is positive. This is fallout from g_assert_cmpint no longer necessarily being no-return; replace it with a plain

[Qemu-devel] [PULL 02/10] vhost: fix a memory leak

From: Peng Hao vhost exists a call for g_file_get_contents, but not call g_free. Signed-off-by: Peng Hao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau

[Qemu-devel] [PULL 04/10] intel_iommu: fix iova for pt

From: Peter Xu IOMMUTLBEntry.iova is returned incorrectly on one PT path (though mostly we cannot really trigger this path, even if we do, we are mostly disgarding this value, so it didn't break anything). Fix it by converting the VTD_PAGE_MASK into the correct definition

[Qemu-devel] [PULL 05/10] intel_iommu: use access_flags for iotlb

From: Peter Xu It was cached by read/write separately. Let's merge them. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 3 +--

[Qemu-devel] [PULL 01/10] tests: switch pxe and vm gen id tests to use kvm

Speed up tests on host systems with kvm support. Cc: Paolo Bonzini Cc: Thomas Huth Cc: Laurent Vivier Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini --- tests/pxe-test.c | 2 +-

[Qemu-devel] [PULL 00/10] pc, acpi, virtio: fixes, test speedup for rc1

The following changes since commit 7d48cf8102a10e4a54333811bafb5eb566509268: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-08-01 14:33:56 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PATCH 0/1] qemu-iotests/109: Fix lock race condition

A race condition is currently present between the clean up attempt of the QEMU process and the execution of qemu-img. Cleber Rosa(1): qemu-iotests/109: Fix lock/race condition tests/qemu-iotests/109 | 3 ++- tests/qemu-iotests/109.out | 56 ++

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-01 23:31 GMT+03:00 Laszlo Ersek : > (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) > > On 07/29/17 01:37, Aleksandr Bezzubikov wrote: >> Signed-off-by: Aleksandr Bezzubikov >> --- >> docs/pcie.txt| 46

Re: [Qemu-devel] [PATCH] vfio/pci-quirks: Set non-zero GMS memory size for IGD

On Fri, 28 Jul 2017 08:22:45 +0300 Dmitry Fleytman wrote: > > On 28 Jul 2017, at 07:51 AM, Zhang, Xiong Y wrote: > > > >>> On 26 Jul 2017, at 08:22 AM, Zhang, Xiong Y > >> wrote: > >>> > >>> Sorry, we indeed found

Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote: > While refactoring i386/FADT generation to build_append_int_noprefix() > > and testing it, It turned out that FADT is only tested for valid > > checksum but actual test for unintended changes isn't

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

(Whenever my comments conflict with Michael's or Marcel's, I defer to them.) On 07/29/17 01:37, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov > --- > docs/pcie.txt| 46 ++ > docs/pcie_pci_bridge.txt | 121 >

[Qemu-devel] [Bug 1473451] Re: Please support the native bios format for dec alpha

** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1473451 Title: Please support the native bios format for dec alpha Status in QEMU: Won't Fix

Re: [Qemu-devel] [PULL 02/17] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 1 August 2017 at 17:17, Paolo Bonzini wrote: > > From: "Dr. David Alan Gilbert" > > > > This code has an optimised, word aligned version, and a boring > > unaligned version. Recently 084140bd498909

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 1 August 2017 at 17:17, Paolo Bonzini wrote: > The following changes since commit 7d48cf8102a10e4a54333811bafb5eb566509268: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2017-08-01 14:33:56 +0100) > > are available in the

Re: [Qemu-devel] [PULL 02/17] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check

On 1 August 2017 at 17:17, Paolo Bonzini wrote: > From: "Dr. David Alan Gilbert" > > This code has an optimised, word aligned version, and a boring > unaligned version. Recently 084140bd498909 fixed a missing offset > addition from the core of both

Re: [Qemu-devel] [seabios PATCH for qemu 2.10 0/2] seabios: build ACPI 1.0-compatible ACPI tables

On Wed, Jul 26, 2017 at 11:42:33AM +0200, Paolo Bonzini wrote: > Old operating systems would like to have a rev1 (ACPI 1.0) FADT, but > new operating systems would like to have rev3 (ACPI 2.0). > Since old operating systems do not know about XSDTs, the > solution is to point the RSDT to a v1 FADT

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-08-01 16:38 GMT+03:00 Marcel Apfelbaum : > On 31/07/2017 22:01, Alexander Bezzubikov wrote: >> >> 2017-07-31 21:57 GMT+03:00 Michael S. Tsirkin : >>> >>> On Mon, Jul 31, 2017 at 09:54:55PM +0300, Alexander Bezzubikov wrote: 2017-07-31 17:09

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 01/08/2017 19:22, Peter Maydell wrote: > On 1 August 2017 at 18:17, Paolo Bonzini wrote: >> Ok, for this patch I kept it consistent within the file, but for 2.11 we >> can change everything to "while (0)". > > Is this a proposal to bite the bullet and fix all our > code

Re: [Qemu-devel] [PATCH v2] pc: acpi: force FADT rev1 for 440fx based machine types

On Fri, Jul 28, 2017 at 02:28:57PM +0200, Igor Mammedov wrote: > On Wed, 26 Jul 2017 23:18:01 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 26, 2017 at 04:09:37PM +0200, Igor Mammedov wrote: > > > On Tue, 25 Jul 2017 16:36:06 +0300 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 1 August 2017 at 18:17, Paolo Bonzini wrote: > Ok, for this patch I kept it consistent within the file, but for 2.11 we > can change everything to "while (0)". Is this a proposal to bite the bullet and fix all our code style issues in existing code? :-) It would be an

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 01/08/2017 19:10, Peter Maydell wrote: > On 1 August 2017 at 17:50, Paolo Bonzini wrote: >> On 01/08/2017 18:48, no-re...@patchew.org wrote: >>> ERROR: space prohibited before that '++' (ctx:WxB) >>> #78: FILE: hw/bt/sdp.c:741: >>> +data[len ++] = attribute_id >>

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 1 August 2017 at 17:50, Paolo Bonzini wrote: > On 01/08/2017 18:48, no-re...@patchew.org wrote: >> ERROR: space prohibited before that '++' (ctx:WxB) >> #78: FILE: hw/bt/sdp.c:741: >> +data[len ++] = attribute_id >> 8; >> ^ >> >> ERROR: space

Re: [Qemu-devel] [PATCH v2 2/2] build-sys: do not compile net/vhost-user.c if vhost-user is disabled

- Original Message - > On Tue, Aug 01, 2017 at 12:15:16PM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Fri, Jul 28, 2017 at 04:13:09PM +0200, Marc-André Lureau wrote: > > > > This adds two extra #ifdef that have fairly limited conflict potential.

Re: [Qemu-devel] [PULL v2 00/14] Block layer patches for 2.10.0-rc1

On 1 August 2017 at 17:12, Kevin Wolf wrote: > The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170731' into staging (2017-07-31 > 14:45:42 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM

On Tue, Aug 01, 2017 at 04:47:03PM +0100, Stefan Hajnoczi wrote: On Mon, Jul 31, 2017 at 12:54:40PM +0300, Manos Pitsidianakis wrote: ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

On 01/08/2017 18:48, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/17: vl.c/exit: pause cpus before closing block devices... > Checking PATCH 2/17: cpu_physical_memory_sync_dirty_bitmap: Fix alignment > check... > Checking PATCH 3/17: accel: cleanup error output... >

Re: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?) Message-id: 1501604245-33460-1-git-send-email-pbonz...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] Does qemu guest agent support 'guest-exec'?

Quoting Hu, Robert (2017-08-01 02:15:01) > Hi, > > qemu/scripts/qmp/qemu-ga-client seems only support "cat, fsfreeze, fstrim, > halt, ifconfig, info, ping, powerdown, reboot, shutdown, suspend". > > But from qemu/qga/commands.c seems at least Linux guest should already > support this. Despite

Re: [Qemu-devel] [PATCH v2 2/2] build-sys: do not compile net/vhost-user.c if vhost-user is disabled

On Tue, Aug 01, 2017 at 12:15:16PM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Jul 28, 2017 at 04:13:09PM +0200, Marc-André Lureau wrote: > > > This adds two extra #ifdef that have fairly limited conflict potential. > > > > > > Signed-off-by: Marc-André

[Qemu-devel] [PULL 17/17] mc146818rtc: implement UIP latching as intended

In some cases, the guest can observe the wrong ordering of UIP and interrupts. This can happen if the VCPU exit is timed like this: iothread VCPU ... wait for interrupt ... t-100ns read register A t

Re: [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM

On Mon, Jul 31, 2017 at 12:54:40PM +0300, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. > > A new QAPI struct, ThrottleLimits, is introduced to

[Qemu-devel] [PULL 12/17] hw/scsi/vmw_pvscsi: Remove the dead error handling

From: Mao Zhongyi qemu_bh_new() is a wrapper around aio_bh_new(), which returns null only when g_new() does. It doesn't. So remove the dead error handling. Reviewed-by: Dmitry Fleytman Cc: Paolo Bonzini Cc: Markus Armbruster

[Qemu-devel] [PULL 16/17] mc146818rtc: simplify check_update_timer

Move all the optimized cases together, since they all have UF=1 in common. Signed-off-by: Paolo Bonzini --- hw/timer/mc146818rtc.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c

[Qemu-devel] [PULL 07/17] target-i386: kvm_get/put_vcpu_events don't handle sipi_vector

From: Peng Hao qemu call kvm_get_vcpu_events, and kernel return sipi_vector always 0, never valid when reporting to user space. But when qemu calls kvm_put_vcpu_events will make sipi_vector in kernel be 0. This will accidently modify sipi_vector when sipi_vector in kernel

[Qemu-devel] [PULL 09/17] bt: stop the sdp memory allocation craziness

Clang static analyzer reports a memory leak. Actually, the allocated memory escapes here: record->attribute_list[record->attributes].pair = data; but clang is correct that the memory might leak if len is zero. We know it isn't; assert that it is the case. The craziness doesn't end

[Qemu-devel] [PULL 08/17] exec: Add lock parameter to qemu_ram_ptr_length

From: Anthony PERARD Commit 04bf2526ce87f21b32c9acba1c5518708c243ad0 (exec: use qemu_ram_ptr_length to access guest ram) start using qemu_ram_ptr_length instead of qemu_map_ram_ptr, but when used with Xen, the behavior of both function is different. They both call

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

On Mon, Jul 31, 2017 at 12:54:41PM +0300, Manos Pitsidianakis wrote: > +static int throttle_configure_tgm(BlockDriverState *bs, > + ThrottleGroupMember *tgm, > + QDict *options, Error **errp) > +{ > +int ret; > +

[Qemu-devel] [PULL 15/17] rtc-test: introduce more update tests

Test divider reset and UIP behavior. Signed-off-by: Paolo Bonzini --- tests/rtc-test.c | 82 +++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 798cf5e..d7a96cb

[Qemu-devel] [PULL 11/17] migration: optimize the downtime

From: Jay Zhou Qemu_savevm_state_cleanup takes about 300ms in my ram migration tests with a 8U24G vm(20G is really occupied), the main cost comes from KVM_SET_USER_MEMORY_REGION ioctl when mem.memory_size = 0 in kvm_set_user_memory_region. In kmod, the main cost is

[Qemu-devel] [PULL 10/17] qemu-options: document existance of versioned machine types

From: "Daniel P. Berrange" The -machine docs did not explain what the versioned machine types are for, nor that they'll be maintained across releases. Signed-off-by: Daniel P. Berrange Message-Id: <20170725141041.1195-1-berra...@redhat.com>

[Qemu-devel] [PULL 05/17] char: don't exit on hmp 'chardev-add help'

From: Anton Nefedov qemu_chr_new_from_opts() is used from both vl.c and hmp, and it is quite confusing to see qemu suddenly exit after receiving a help option in hmp. Do exit(0) from vl.c instead. Signed-off-by: Anton Nefedov

[Qemu-devel] [PULL 13/17] hw/scsi/vmw_pvscsi: Convert to realize

From: Mao Zhongyi Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Reviewed-by: Dmitry Fleytman Cc: Paolo Bonzini Cc: Markus Armbruster

[Qemu-devel] [PULL 03/17] accel: cleanup error output

From: Laurent Vivier Only emit "XXX accelerator not found", if there are not further accelerators listed. eg accel=kvm:tcg doesn't print a "KVM accelerator not found" warning when it falls back to tcg, but a accel=kvm prints a warning, since no fallback is given.

[Qemu-devel] [PULL 04/17] char-fd: remove useless chr pointer

From: Marc-André Lureau Apparently unused since it was introduced in commit a29753f8aa79a34a324afebe340182a51a5aef11. Now, it can be trivially accessed by CHARDEV() of self. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 06/17] docs: document deprecation policy & deprecated features in appendix

From: "Daniel P. Berrange" The deprecation of features in QEMU is totally adhoc currently, with no way for the user to get a list of what is deprecated in each release. This adds an appendix to the doc that records when each deprecation was made and provides text explaining

[Qemu-devel] [PULL 14/17] rtc-test: cleanup register_b_set_flag test

Introduce set_datetime_bcd/assert_datetime_bcd, and handle UIP correctly. Signed-off-by: Paolo Bonzini --- tests/rtc-test.c | 76 ++-- 1 file changed, 46 insertions(+), 30 deletions(-) diff --git a/tests/rtc-test.c

[Qemu-devel] [PULL 01/17] vl.c/exit: pause cpus before closing block devices

From: "Dr. David Alan Gilbert" There's a rare exit seg if the guest is accessing IO during exit. It's always hitting the atomic_inc(>in_flight) with a NULL bs. This was added recently in 99723548 but I don't see it as the cause. Flip vl.c around so we pause the cpus before

[Qemu-devel] [PULL 00/17] Misc changes for QEMU 2.10-rc1 (?)

The following changes since commit 7d48cf8102a10e4a54333811bafb5eb566509268: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-08-01 14:33:56 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[Qemu-devel] [PULL 02/17] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check

From: "Dr. David Alan Gilbert" This code has an optimised, word aligned version, and a boring unaligned version. Recently 084140bd498909 fixed a missing offset addition from the core of both versions. However, the offset isn't necessarily aligned and thus the choice

Re: [Qemu-devel] [PATCH v3 6/7] block: add BlockDevOptionsThrottle to QAPI

On Mon, Jul 31, 2017 at 12:54:42PM +0300, Manos Pitsidianakis wrote: > @@ -3095,6 +3096,22 @@ > '*tls-creds': 'str' } } > > ## > +# @BlockdevOptionsThrottle: > +# > +# Driver specific block device options for the throttle driver > +# > +# @throttle-group: the name of the

Re: [Qemu-devel] [PATCH v2 2/2] build-sys: do not compile net/vhost-user.c if vhost-user is disabled

Hi - Original Message - > On Fri, Jul 28, 2017 at 04:13:09PM +0200, Marc-André Lureau wrote: > > This adds two extra #ifdef that have fairly limited conflict potential. > > > > Signed-off-by: Marc-André Lureau > > OK but why can't we keep all ifdefs in net/

[Qemu-devel] [PATCH] migration: fix small leaks

Spotted thanks to valgrind and tests/device-introspect-test: ==11711== 1 bytes in 1 blocks are definitely lost in loss record 6 of 14,537 ==11711==at 0x4C2EB6B: malloc (vg_replace_malloc.c:299) ==11711==by 0x1E0CDBD8: g_malloc (gmem.c:94) ==11711==by 0x1E0E696E: g_strdup

[Qemu-devel] [PULL v2 00/14] Block layer patches for 2.10.0-rc1

The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170731' into staging (2017-07-31 14:45:42 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

Re: [Qemu-devel] [PULL 00/15] Block layer patches for 2.10.0-rc1

Am 01.08.2017 um 18:01 hat Peter Maydell geschrieben: > On 1 August 2017 at 15:46, Kevin Wolf wrote: > > The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20170731' into

Re: [Qemu-devel] [PATCH v2 2/2] build-sys: do not compile net/vhost-user.c if vhost-user is disabled

On Fri, Jul 28, 2017 at 04:13:09PM +0200, Marc-André Lureau wrote: > This adds two extra #ifdef that have fairly limited conflict potential. > > Signed-off-by: Marc-André Lureau OK but why can't we keep all ifdefs in net/ where all the rest of the features are

Re: [Qemu-devel] [PULL 00/15] Block layer patches for 2.10.0-rc1

On 1 August 2017 at 15:46, Kevin Wolf wrote: > The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170731' into staging (2017-07-31 > 14:45:42 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

On 01/08/2017 18:51, Michael S. Tsirkin wrote: On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +

Re: [Qemu-devel] [PATCH 07/18] nbd: Minimal structured read for client

01.08.2017 18:41, Vladimir Sementsov-Ogievskiy wrote: 07.02.2017 23:14, Eric Blake wrote: On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal implementation: always send DF flag, to not deal with fragmented replies. This works well with your minimal server implementation, but

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: > On 01/08/2017 18:32, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > > > > > +typedef struct PCIEPCIBridge { > > > > > +/*< private >*/ > > > > > +PCIBridge parent_obj;

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +PCIBridge parent_obj; + +bool msi_enable; Please rename the msi_enable property to "msi" in order to be aligned

Re: [Qemu-devel] [PATCH 07/18] nbd: Minimal structured read for client

07.02.2017 23:14, Eric Blake wrote: On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal implementation: always send DF flag, to not deal with fragmented replies. This works well with your minimal server implementation, but I worry that it will cause us to fall over when talking

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > >> +typedef struct PCIEPCIBridge { > >> +/*< private >*/ > >> +PCIBridge parent_obj; > >> + > >> +bool msi_enable; > > > > > > Please rename the msi_enable property to "msi" in order > > to be aligned with the

Re: [Qemu-devel] [for-2.11 PATCH 26/26] spapr: add hotplug hooks for PHB hotplug

On Fri, 28 Jul 2017 14:24:03 +1000 David Gibson wrote: > On Thu, Jul 27, 2017 at 07:09:55PM +0200, Greg Kurz wrote: > > On Thu, 27 Jul 2017 14:41:31 +1000 > > Alexey Kardashevskiy wrote: > > > > > On 26/07/17 18:40, Greg Kurz wrote: > > > >

Re: [Qemu-devel] [PATCH v2 1/2] s390x/css: use macro for event-information pending error recover code

On 08/01/2017 09:57 AM, Dong Jia Shi wrote: > Let's use a macro for the ERC (error recover code) when generating a > Channel Subsystem Event-information pending CRW (channel report word). > > While we are at it, let's also add all other ERCs. > > Signed-off-by: Dong Jia Shi

Re: [Qemu-devel] [PATCH v2 2/2] s390x/css: generate solicited crw for rchp completion signaling

On 08/01/2017 09:57 AM, Dong Jia Shi wrote: [..] > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -1745,10 +1745,10 @@ int css_do_rchp(uint8_t cssid, uint8_t chpid) > } > > /* We don't really use a channel path, so we're done here. */ > -css_queue_crw(CRW_RSC_CHP, CRW_ERC_INIT,

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

On Tue, 1 Aug 2017 17:35:40 +0800 Bob Chen wrote: > 2017-08-01 13:46 GMT+08:00 Alex Williamson : > > > On Tue, 1 Aug 2017 13:04:46 +0800 > > Bob Chen wrote: > > > > > Hi, > > > > > > This is a sketch of my hardware

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

On Tue, 08/01 12:25, Paolo Bonzini wrote: > On 28/07/2017 02:25, Fam Zheng wrote: > > On Thu, 07/27 15:47, Zhang Chen wrote: > >> CC. Fam and David. > >> > >> Any idea about it? > > > > Is it possible to use g_main_context_{push,pop}_thread_default to "move" > > chardev > > GSources to

Re: [Qemu-devel] [for-2.11 PATCH 26/26] spapr: add hotplug hooks for PHB hotplug

On Thu, 27 Jul 2017 13:37:24 -0500 Michael Roth wrote: > Quoting Greg Kurz (2017-07-27 12:09:55) > > On Thu, 27 Jul 2017 14:41:31 +1000 > > Alexey Kardashevskiy wrote: > > > > > On 26/07/17 18:40, Greg Kurz wrote: > > > > Hotplugging PHBs is a

[Qemu-devel] [PULL 15/15] block/qapi: Remove redundant NULL check to silence Coverity

When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is always non-NULL; initially, because it's taken from a BdrvChild and a BdrvChild never has a NULL bs, and after the first iteration because implicit nodes always have a backing file. Remove the NULL check and add an

  1   2   3   >