Re: [Qemu-devel] [PATCH for-2.11 1/6] ppc: use macros to make cpu type name from string literal

On Fri, Aug 25, 2017 at 09:28:22AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 11:30:47 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:46AM +0200, Igor Mammedov wrote: > > > Replace > > > "-" TYPE_POWERPC_CPU > > > when composing cpu type

[Qemu-devel] [PATCH v3 4/7] block: remove legacy I/O throttling

This commit removes all I/O throttling from block/block-backend.c. In order to support the existing interface, it is changed to use the block/throttle.c filter driver. The throttle filter node that is created by the legacy interface is stored in a 'throttle_node' field in the BlockBackendPublic

Re: [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

Hi John, On 08/08/2017 03:32 PM, John Snow wrote: Out with the old, in with the new. Signed-off-by: John Snow --- Makefile.objs | 1 + hw/ide/cmd646.c | 10 +++- hw/ide/core.c | 65 +++

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

On Fri, Aug 25, 2017 at 01:40:07PM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 19:45:38 +1000 > David Gibson wrote: > > > On Fri, Aug 25, 2017 at 09:27:40AM +0200, Igor Mammedov wrote: > > > On Fri, 25 Aug 2017 11:38:19 +1000 > > > David Gibson

[Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue in ccw bios. According to PoP the CCW must be doubleword aligned. Let's fix this in the bios. Cc: qemu-sta...@nongnu.org Signed-off-by: Farhan Ali Reviewed-by: Halil Pasic

[Qemu-devel] [PATCH v3 6/7] block: remove BlockBackendPublic

All BlockBackend level throttling (via the implicit throttle filter node) is done in block/block-backend.c and block/throttle-groups.c doesn't know about BlockBackends anymore. Since BlockBackendPublic is not needed anymore, remove it. Reviewed-by: Alberto Garcia

[Qemu-devel] [PATCH v3 5/7] block/throttle-groups.c: remove throttle-groups list

block/throttle-groups.c uses a list to keep track of all groups and make sure all names are unique. This patch moves all ThrottleGroup objects under the root container. While block/throttle.c requires that all throttle groups are created with object-add or -object, the legacy throttling interface

[Qemu-devel] [PATCH v3 1/7] block: skip implicit nodes in snapshots, blockjobs

Implicit filter nodes added at the top of nodes can interfere with block jobs. This is not a problem when they are added by other jobs since adding another job will issue a QERR_DEVICE_IN_USE, but it can happen in the next commit which introduces an implicitly created throttle filter node below

[Qemu-devel] [PATCH v3 0/6] block: remove legacy I/O throttling

This series depends on my other series 'add throttle block driver filter' currently on v9 Based-on: <20170825132028.6184-1-el13...@mail.ntua.gr> Replacing the current I/O interface means the user will use the same options as before and QEMU will create a hidden throttle filter node beneath the

[Qemu-devel] [PATCH v3 3/7] block: require job-id when device is a node name

With implicit filter nodes on the top of the graph it is not possible to generate job-ids with the name of the device in block_job_create() anymore, since the job's bs will not be a child_root. Instead we can require that job-id is not NULL in block_job_create(), and check that a job-id has been

[Qemu-devel] [PATCH v3 7/7] qemu-iotests: add 191 for legacy throttling interface

Check that the implicit throttle filter driver node, used for compatibility with the legacy throttling interface on the BlockBackend level, works. Reviewed-by: Alberto Garcia Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/191 | 138

[Qemu-devel] [PATCH v3 2/7] block: add options parameter to bdrv_new_open_driver()

Allow passing a QDict *options parameter to bdrv_new_open_driver() so that it can be used if a driver needs it upon creation. The previous behaviour (empty bs->options and bs->explicit_options) remains when options is NULL. Reviewed-by: Alberto Garcia Signed-off-by: Manos

[Qemu-devel] [PATCH v9 5/6] block: add throttle block filter driver

block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive

[Qemu-devel] [PATCH v9 1/6] block: move ThrottleGroup membership to ThrottleGroupMember

This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This

[Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

Reviewed-by: Alberto Garcia Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 205 +++ tests/qemu-iotests/184.out | 300 + tests/qemu-iotests/group | 1 + 3

[Qemu-devel] [PATCH v9 0/6] add throttle block driver filter

This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex

[Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM

ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP.

[Qemu-devel] [PATCH v9 2/6] block: add aio_context field in ThrottleGroupMember

timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia

[Qemu-devel] [PATCH v9 3/6] block: tidy ThrottleGroupMember initializations

Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos

Re: [Qemu-devel] [PATCH 6/9] AHCI: Replace DPRINTF with trace-events

Hi John, On 08/08/2017 03:33 PM, John Snow wrote: There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow --- hw/ide/ahci.c | 157 +++- hw/ide/trace-events | 52

Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length

On Thu, Aug 24, 2017 at 06:31:24PM +0200, Igor Mammedov wrote: > since commit ( 9262685b cpu: Factor out cpu_generic_init() ) > features parsed by it were truncated only to the 1st feature > after CPU name due to fact that > >featurestr = strtok(NULL, ","); >cc->parse_features(cpu,

Re: [Qemu-devel] [PATCH for-2.11 v3 06/25] sparc: make cpu feature parsing property based

On Thu, Aug 24, 2017 at 06:31:29PM +0200, Igor Mammedov wrote: > with features converted to properties we can use the same > approach as x86 for features parsing and drop legacy > approach that manipulated CPU instance directly. > New sparc_cpu_parse_features() will allow only +-feat > and

Re: [Qemu-devel] [PATCH v2 01/14] qdict: add qdict_put_null() helper

On Fri, Aug 25, 2017 at 12:59:00PM +0200, Marc-André Lureau wrote: > A step towards completeness. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster Now replying to the latest version: Reviewed-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

On Fri, Aug 25, 2017 at 08:02:26AM +0200, Markus Armbruster wrote: > Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on > alternate conflict". > Message-Id: <20170717180926.14924-1-ehabk...@redhat.com> > > Marc-André, could you have a look? You can rebase your fix on top of >

[Qemu-devel] Make NVME device "migratable" (savevm)

Hi all, >From what I understand, I can't "savevm" a VM that uses NVME device because it has ".unmigratable = 1" in the code. What support must be implemented in order to make it "migratable"? -- Regards, Sergei Dyshel

Re: [Qemu-devel] [PATCH 01/14] qdict: add qdict_put_null() helper

On Thu, Aug 24, 2017 at 12:33:37PM +0200, Marc-André Lureau wrote: > A step towards completeness. > > Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 1/3] qemu.py: make VM() a context manager

On Thu, Aug 24, 2017 at 08:22:00AM +0100, Stefan Hajnoczi wrote: > There are a number of ways to ensure that the QEMU process is shut down > when the test ends, including atexit.register(), try: finally:, or > unittest.teardown() methods. All of these require extra code and the > programmer must

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

On 08/25/17 11:15, Paolo Bonzini wrote: > On 25/08/2017 11:13, Peter Maydell wrote: >> On 24 August 2017 at 20:06, Laszlo Ersek wrote: >>> Has it not been the intent to include the following patch in 2.10: >>> >>> [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST

Re: [Qemu-devel] [RFC v2 04/32] qemu_ram_block_host_offset

Hi David, On 08/24/2017 04:27 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Utility to give the offset of a host pointer within a RAMBlock (assuming we already know it's in that RAMBlock) Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH qemu] pci: Initialize pci_dev->name before use

On 08/25/2017 12:21 AM, Alexey Kardashevskiy wrote: This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of empry string. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v2 1/3] vl: Clean up user-creatable objects when exiting

On 08/24/2017 04:23 PM, Eduardo Habkost wrote: Delete all user-creatable objects in /objects when exiting QEMU, so they can perform cleanup actions. Signed-off-by: Eduardo Habkost Acked-by: Philippe Mathieu-Daudé --- Changes v1 -> v2: * (none) ---

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

25.08.2017 03:55, John Snow wrote: Sorry in advance for :words: ... On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: 22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some pings

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

On 24 August 2017 at 21:28, Richard Henderson wrote: > Peter and I had a chat on IRC about this. > > While I think the background region idea is tempting, it does nothing to help > legacy boards once devices start signaling their own errors. Therefore some > sort of

Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length

On 08/25/2017 05:11 AM, Igor Mammedov wrote: Philippe Mathieu-Daudé wrote: On 08/24/2017 01:31 PM, Igor Mammedov wrote: since commit ( 9262685b cpu: Factor out cpu_generic_init() ) features parsed by it were truncated only to the 1st feature after CPU name due to fact that

Re: [Qemu-devel] [PATCH for-2.11] aux-to-i2c-bridge: don't allow user to create one

On 25.08.2017 13:46, KONRAD Frederic wrote: > This device is private and is created once per aux-bus. > So don't allow the user to create one from command-line. > > Reported-by: Thomas Huth > Signed-off-by: KONRAD Frederic > --- > hw/misc/auxbus.c

[Qemu-devel] [PATCH for-2.11] aux-to-i2c-bridge: don't allow user to create one

This device is private and is created once per aux-bus. So don't allow the user to create one from command-line. Reported-by: Thomas Huth Signed-off-by: KONRAD Frederic --- hw/misc/auxbus.c | 11 +++ 1 file changed, 11 insertions(+) diff

[Qemu-devel] wrong ioctl error handling on dirty pages sync?

Hi guys, Maybe it is just my lack of understanding, this seems like a bug to me: To get list of dirty pages, qemu calls kvm_vm_ioctl() with KVM_GET_DIRTY_LOG: https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L494 and considers the ioctl call failed when -1 is returned. But

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

On Fri, 25 Aug 2017 19:32:29 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 14:16:44 +1000 > > David Gibson wrote: > > > > > On Thu, Aug 24, 2017 at 10:21:50AM +0200,

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

On Fri, 25 Aug 2017 19:45:38 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 09:27:40AM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 11:38:19 +1000 > > David Gibson wrote: > > > > > On Thu, Aug 24, 2017 at 10:21:47AM +0200,

Re: [Qemu-devel] [PATCH v2 16/16] qapi-schema: Improve section headings

On Thu, Aug 24, 2017 at 9:14 PM Markus Armbruster wrote: > The generated QEMU QMP reference is now structured as follows: > > 1.1 Introduction > 1.2 Stability Considerations > 1.3 Common data types > 1.4 Socket data types > 1.5 VM run state > 1.6

Re: [Qemu-devel] [PATCH v2 15/16] qapi-schema: Move queries from common.json to qapi-schema.json

Hi On Thu, Aug 24, 2017 at 9:20 PM Markus Armbruster wrote: > query-version and query-commands are in common.json for no good > reason. Several similar queries are in qapi-schema.json. Move them > there. > > I suppose it was initially meant to be shared with all QMP users,

Re: [Qemu-devel] [PATCH v2 14/16] qapi-schema: Make block-core.json self-contained

On Thu, Aug 24, 2017 at 9:15 PM Markus Armbruster wrote: > Except for block-core.json, the sub-schemas are self-contained: if > they use a symbol defined in another sub-schema, they include that > sub-schema. To check, feed the sub-schema to qapi2texi (or any other > QAPI

Re: [Qemu-devel] [PATCH v2 12/16] qapi-schema: Move block events from event.json to block.json

On Thu, Aug 24, 2017 at 9:25 PM Markus Armbruster wrote: > Cc: Alberto Garcia > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau > --- > qapi/block.json | 68 >

Re: [Qemu-devel] [PATCH v2 13/16] qapi-schema: Fold event.json back into qapi-schema.json

On Thu, Aug 24, 2017 at 9:17 PM Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Looks like you tried to find a reasonable location in the file for each events. Reviewed-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH] vga: stop passing pointers to vga_draw_line* functions

Hi, > s/simliar/similar/ > s/priviledged/privileged/ Fixed. > > a segfault, when hitting the guard page after vga memory > > allocation, while reading vga memory for display updates. > > > > Fixes: CVE-2017- > > Do we have the actual number? Not yet, pjp still busy getting one, but

Re: [Qemu-devel] [PATCH v11 3/6] ACPI: build and enable APEI GHES in the Makefile and configuration

On 2017/8/24 21:04, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> Add CONFIG_ACPI_APEI configuration in the Makefile and >> enable it in the arm-softmmu.mak >> >> Signed-off-by: Dongjiu Geng >> --- >> default-configs/arm-softmmu.mak | 1 + >>

Re: [Qemu-devel] [PATCH v2 11/16] qapi-schema: Collect TPM stuff in qapi/tpm.json

On Thu, Aug 24, 2017 at 9:23 PM Markus Armbruster wrote: > Sadly, we don't have a TPM maintainer, not even a MAINTAINERS entry. > Create one, and mark it orphaned. > > This is also proposed in: http://patchew.org/QEMU/20170728053610.15770-1-f4...@amsat.org/ Stefan Berger, any

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

Hi Shannon, On 2017/8/24 21:03, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error CPER info >> to the guest via a fw_cfg_blob. After a CPER info is recorded, an >> SEA(Synchronous External Abort)/SEI(SError Interrupt)

Re: [Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json

On Thu, 2017-08-24 at 21:14 +0200, Markus Armbruster wrote: > UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, > keyboard). > > Cc: Gerd Hoffmann > Signed-off-by: Markus Armbruster Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

On Fri, Aug 25, 2017 at 09:27:40AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 11:38:19 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > > > PPC handles -cpu FOO rather incosistently, > > > i.e. it does

Re: [Qemu-devel] [PATCH v2 10/16] qapi-schema: Collect transaction stuff in qapi/transaction.json

On Thu, Aug 24, 2017 at 9:18 PM Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile | 1 + > qapi-schema.json | 151

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

On Thu, Aug 24, 2017 at 9:28 PM Markus Armbruster wrote: > Cc: Juan Quintela > Cc: Dr. David Alan Gilbert > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- >

Re: [Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json

On Thu, Aug 24, 2017 at 9:27 PM Markus Armbruster wrote: > UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, > keyboard). > > Cc: Gerd Hoffmann > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 14:16:44 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > >

Re: [Qemu-devel] [PATCH v2 07/16] qapi-schema: Collect net device stuff in qapi/net.json

On Thu, Aug 24, 2017 at 9:25 PM Markus Armbruster wrote: > Cc: Jason Wang > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile | 1 + >

Re: [Qemu-devel] RFC: qemu RISC-V

Hi Paolo, Thanks for the information. Fred On 08/23/2017 10:29 PM, Paolo Bonzini wrote: On 23/08/2017 21:25, KONRAD Frederic wrote: Hi all, I found somes slides about RISC-V at the KVM forum 2016. Seems the upstreaming process should have started in september 2016 but I didn't see

[Qemu-devel] [PATCH v2 10/14] tests: add qlit tests

Signed-off-by: Marc-André Lureau --- tests/check-qlit.c | 64 ++ tests/Makefile.include | 5 +++- 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 tests/check-qlit.c diff --git

Re: [Qemu-devel] [PATCH v2 06/16] qapi-schema: Collect char device stuff in qapi/char.json

On Thu, Aug 24, 2017 at 9:24 PM Markus Armbruster wrote: > Cc: Paolo Bonzini > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH v2 05/16] qapi-schema: Collect run state stuff in qapi/run-state.json

On Thu, Aug 24, 2017 at 9:20 PM Markus Armbruster wrote: > Cc: Paolo Bonzini > Signed-off-by: Markus Armbruster > Nice one Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 + > Makefile

[Qemu-devel] [PATCH v2 05/14] qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject()

compare_litqobj_to_qobj() lacks a qlit_ prefix. Moreover, "compare" suggests -1, 0, +1 for less than, equal and greater than. The function actually returns non-zero for equal, zero for unequal. Rename to qlit_equal_qobject(). Its return type will be cleaned up in the next patch. Signed-off-by:

[Qemu-devel] [PATCH v2 13/14] qlit: add qobject_form_qlit()

Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qlit.h | 2 ++ qobject/qlit.c | 37 + tests/check-qlit.c | 26 ++ 3 files changed, 65 insertions(+) diff --git a/include/qapi/qmp/qlit.h

Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

On Thu, Aug 24, 2017 at 10:15 PM, Manos Pitsidianakis wrote: > On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote: >> >> On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote: >>> >>> +_supported_fmt qcow2 >> >> >> What makes this test

[Qemu-devel] [PATCH v2 03/14] qlit: use QLit prefix consistently

Rename from LiteralQ to QLit. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 24 qobject/qlit.c | 4 ++-- tests/check-qjson.c | 40

Re: [Qemu-devel] [PATCH v2 04/16] qapi-schema: Collect sockets stuff in qapi/sockets.json

On Thu, Aug 24, 2017 at 9:18 PM Markus Armbruster wrote: > Cc: "Daniel P. Berrange" > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Signed-off-by: Markus Armbruster > Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 11/14] qlit: improve QLit dict vs qdict comparison

Verify that all qdict values are covered. (a previous iteration of this patch created a copy of qdict to remove all checked elements, verifying no duplicates exist in the literal qdict, however this is a programming error, and a size comparison should be enough) Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 14/14] qapi: generate a literal qobject for introspection

Replace the generated json string with a literal qobject. The later is easier to deal with, at run time as well as compile time: adding #if conditionals will be easier than in a json string. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v2 02/14] qlit: move qlit from check-qjson to qobject/

Fix code style issues while at it, to please checkpatch. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 49 + qobject/qlit.c | 89

[Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. Check that the QLit list has the same size as the qlist, this should ensure that we have an exact match when iterating over qlist for comparing the elements. Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v2 07/14] qlit: make qlit_equal_qobject() take const arguments

Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 2 +- qobject/qlit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h

[Qemu-devel] [PATCH v2 09/14] qlit: Replace open-coded qnum_get_int() by call

Bonus: rids us of a side effect in an assertion. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- qobject/qlit.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index

[Qemu-devel] [PATCH v2 01/14] qdict: add qdict_put_null() helper

A step towards completeness. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qdict.h | 4 +++- target/i386/cpu.c| 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 08/14] qlit: add QLIT_QNULL and QLIT_BOOL

As they are going to be used in the following patches. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 5 + qobject/qlit.c | 4 2 files changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH v2 06/14] qlit: make qlit_equal_qobject return a bool

Make it more obvious about the expected return values. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/qapi/qmp/qlit.h | 2 +- qobject/qlit.c | 18 +- tests/check-qjson.c | 14

[Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

They are not considered constant expressions in C, producing an error when compiling a const QLit. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qlit.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/qapi/qmp/qlit.h

[Qemu-devel] [PATCH v2 00/14] Generate a literal qobject for introspection

Hi, This series is based on patches 2-5 from "[PATCH v2 00/54] qapi: add #if pre-processor conditions to generated code". Generating a literal qobject will allow to easily introduce #if conditionals from the original series. v2: - use QLIST_FOREACH_ENTRY for list comparison - update qdict

Re: [Qemu-devel] Memory use with >100 virtio devices

On 24/08/2017 14:30, David Gibson wrote: >> >> Ideas what to tweak or what valgrind tool to try? > valgrind probably isn't that useful at this point. I think we need to > instrument bits of the code to find what the O(n^2) algo is and fix it. > > Seems to me checking if the address_spaces list

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] nbd-client: enter read_reply_co during init to avoid crash

On Thu, Aug 24, 2017 at 5:21 PM, Paolo Bonzini wrote: > On 24/08/2017 17:33, Stefan Hajnoczi wrote: >> This patch enters read_reply_co directly in >> nbd_client_attach_aio_context(). This is safe because new_context is >> acquired by the caller. This ensures that

Re: [Qemu-devel] [PATCH v11 1/6] ACPI: add APEI/HEST/CPER structures and macros

Shannon, Thanks for the review. please see my reply. On 2017/8/24 20:33, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> (1) Add related APEI/HEST table structures and macros, these >> definition refer to ACPI 6.1 and UEFI 2.6 spec. >> (2) Add generic error status

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

Hi On Fri, Aug 25, 2017 at 8:20 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > And misc code style fix. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/qapi/qmp/qlit.h | 8 > > 1

Re: [Qemu-devel] Why got no response of vnc?

No firewall, as another vm could be connect by vnc, this is the start command used by that vm, and the disk(*.img) is copied from other place. $QEMU -smp 4 -m 4096 -enable-kvm $SCRIPT_PATH/$IMG -cdrom $CD -daemonize -vnc 0.0.0.0:2520 \ -chardev

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

On 25/08/2017 11:25, Fam Zheng wrote: >> I'm no expert in ansible, but I can give it that a try if you fancy the >> idea. >> > I have no objection if you want to give it a try. However it is basically a > separate problem, and I don't think this series would depend on that. The > reason > is that

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25/08/2017 11:16, Alexey Kardashevskiy wrote: > On 25/08/17 19:01, Paolo Bonzini wrote: >> On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >>> Each address_space_init() updates topology for _every_ address space. >> >> And finally, does this patch help with the above? >> >> diff --git

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25/08/2017 11:22, Peter Maydell wrote: > On 25 August 2017 at 09:53, Paolo Bonzini wrote: >> The solution is to: 1) share the FlatView structures if they refer to >> the same root memory region; 2) have one AddressSpaceDispatch per >> FlatView instead of one per

Re: [Qemu-devel] [PATCH v8 5/6] block: add throttle block filter driver

On Thu 24 Aug 2017 02:06:00 PM CEST, Manos Pitsidianakis wrote: > +bool throttle_group_exists(const char *name) > +{ > +return throttle_group_by_name(name) != NULL; > +} I realized that you needed to add throttle_group_exists() after all because you need it in block/throttle.c > /*

Re: [Qemu-devel] Make test

On 25 August 2017 at 10:33, Fam Zheng wrote: > On Fri, 08/25 10:10, Peter Maydell wrote: >> The problem is that we don't have a good framework for building >> guest binaries to run under TCG. We should sort out one of those >> so that it's easy for a new test to say "this is the

Re: [Qemu-devel] [PATCH v8 4/6] block: convert ThrottleGroup to object with QOM

On Thu 24 Aug 2017 02:05:59 PM CEST, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. Stefan pointed out a couple of important things in a reply to v7

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 07:01:35PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Now at least migrate_incoming can be run in parallel. Let's provide a > > > migration lock to protect it. > > > > > > Signed-off-by:

Re: [Qemu-devel] [Qemu-arm] [PATCH 05/20] target/arm: Add MMU indexes for secure v8M

On 22 August 2017 at 16:08, Peter Maydell wrote: > Now that MPU lookups can return different results for v8M > when the CPU is in secure vs non-secure state, we need to > have separate MMU indexes; add the secure counterparts > to the existing three M profile MMU

Re: [Qemu-devel] Make test

On Fri, 08/25 10:10, Peter Maydell wrote: > On 25 August 2017 at 06:49, Thomas Huth wrote: > > On 25.08.2017 00:16, Cleber Rosa wrote: > >> > >> On 08/24/2017 05:50 PM, Programmingkid wrote: > >>> > >>> Thank you for the patches. I will test them. I was wondering what is the >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > > using non-mux typed backend chardev. We only do this for

Re: [Qemu-devel] [PATCH v2 12/16] qapi-schema: Move block events from event.json to block.json

On Thu 24 Aug 2017 09:14:04 PM CEST, Markus Armbruster wrote: > Cc: Alberto Garcia > Signed-off-by: Markus Armbruster I'm not even sure about the difference between block.json and block-core.json :) but I'm fine with the move anyway. Reviewed-by: Alberto

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

On Fri, 08/25 09:52, Stefan Hajnoczi wrote: > On Fri, Aug 25, 2017 at 03:32:29PM +0800, Fam Zheng wrote: > > On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > > > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > > > Tests should

Re: [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h

On 24.08.2017 14:30, Cornelia Huck wrote: > On Fri, 18 Aug 2017 13:43:35 +0200 > David Hildenbrand wrote: > >> ... now featuring even more cleanups. >> >> cpu.h is accessed outside of target/s390x. It should only contain >> what is expected to be accessed outside of this

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

On Thu, 08/24 11:06, Cleber Rosa wrote: > I replayed manually the FreeBSD VM setup, just to get a sense of how it > could be automated. Taking a few steps back, I realized that: > > * describing how to prepare a given OS to build QEMU is a generic task, > not really bound to this VM setup > *

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25 August 2017 at 09:53, Paolo Bonzini wrote: > The solution is to: 1) share the FlatView structures if they refer to > the same root memory region; 2) have one AddressSpaceDispatch per > FlatView instead of one per AddressSpace, so that FlatView reference > counting takes

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25/08/17 19:01, Paolo Bonzini wrote: > On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >> Each address_space_init() updates topology for _every_ address space. > > And finally, does this patch help with the above? > > diff --git a/memory.c b/memory.c > index c0adc35..97c16cc 100644 > ---

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

On 25/08/2017 11:13, Peter Maydell wrote: > On 24 August 2017 at 20:06, Laszlo Ersek wrote: >> Has it not been the intent to include the following patch in 2.10: >> >> [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE >>

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

* Peter Xu (pet...@redhat.com) wrote: > On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Introducing this new parameter for QMP commands in general to mark out > > > > when the

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

On 24 August 2017 at 20:06, Laszlo Ersek wrote: > Has it not been the intent to include the following patch in 2.10: > > [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE > http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03351.html > Message-Id:

Re: [Qemu-devel] Make test

On 25 August 2017 at 06:49, Thomas Huth wrote: > On 25.08.2017 00:16, Cleber Rosa wrote: >> >> On 08/24/2017 05:50 PM, Programmingkid wrote: >>> >>> Thank you for the patches. I will test them. I was wondering what is the >>> point to having both 'make check' and 'make test'.

<    1   2   3   >