On Fri, Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote:
> This series implements the emulation code for ARM SMMUv3.
Can you add some code to block using vfio with this
until patches 19+20 are ready?
Then 1-18 could be applied.
> Changes since v6:
> - DPDK testpmd now running on guest with 2
On Fri, Sep 08, 2017 at 12:22:01PM +0800, Longpeng (Mike) wrote:
>
>
> On 2017/9/8 11:49, Michael S. Tsirkin wrote:
>
> > On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote:
> >> Ping...
> >>
> >> Stefan, Halil, do you have any suggestion ?
> >
> > I do not see this patchset in
On 2017/9/8 11:49, Michael S. Tsirkin wrote:
> On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote:
>> Ping...
>>
>> Stefan, Halil, do you have any suggestion ?
>
> I do not see this patchset in the virtio list archives.
> It could be that youa re posting from an email that is
>
On 07.09.2017 22:13, David Hildenbrand wrote:
> Implemented in sclp.c, so let's move it to the right include file.
> Fix up one include. Do a forward declaration of CPUS390XState to fix the
> two sclp consoles complaining.
>
> Signed-off-by: David Hildenbrand
> ---
>
On 2017/9/6 21:52, Michael S. Tsirkin wrote:
> On Fri, Sep 01, 2017 at 01:45:45PM +0200, Halil Pasic wrote:
>>
>>
>> On 09/01/2017 02:47 AM, Longpeng (Mike) wrote:
>>> Ping...
>>>
>>> Stefan, Halil, do you have any suggestion ?
>>>
>>
>> Hi Longpeng,
>>
>> I've ran trough your patch, and it
On Wed, Sep 06, 2017 at 01:07:47PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Tue, Aug 08, 2017 at 06:26:11PM +0200, Juan Quintela wrote:
> >
> > [...]
> >
> >> void migration_fd_process_incoming(QEMUFile *f)
> >> {
> >> -Coroutine *co =
On 08/09/17 12:08, Alexey Kardashevskiy wrote:
> On 08/09/17 00:54, Dr. David Alan Gilbert wrote:
>> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
>>> On 07/09/17 19:51, Dr. David Alan Gilbert wrote:
* Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
> This was inspired by
On 07.09.2017 22:13, David Hildenbrand wrote:
> Implemented in s390-virtio-ccw.c, so move it to the right header.
> We can also drop the extern. Fix up one include.
>
> Signed-off-by: David Hildenbrand
> ---
> include/hw/s390x/s390-virtio-ccw.h | 2 ++
> target/s390x/cpu.h
On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote:
> Ping...
>
> Stefan, Halil, do you have any suggestion ?
I do not see this patchset in the virtio list archives.
It could be that youa re posting from an email that is
not a subscriber.
Please subscribe and repost.
We'll then
* Cornelia Huck [2017-09-07 13:41:34 +0200]:
> On Thu, 7 Sep 2017 13:32:41 +0200
> Halil Pasic wrote:
>
> > On 09/07/2017 12:24 PM, Cornelia Huck wrote:
>
> > > So we would do an equipment check for the first two ("equipment", i.e.
> > > the
[gangyewei-3@yf-mos-test-net07 tests]$ telnet 127.0.0.1 55919
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
QEMU 2.6.2 monitor - type 'help' for more information
(qemu) chardev-add
socket,id=char-test_intf1,path=/usr/local/var/run/openvswitch/test_intf1,server=on
On Tue, Aug 29, 2017 at 11:09:18AM +0800, Wei Wang wrote:
> On 08/29/2017 02:03 AM, Michael S. Tsirkin wrote:
> > On Mon, Aug 28, 2017 at 06:08:31PM +0800, Wei Wang wrote:
> > > Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer
> > > of balloon (i.e. inflated/deflated) pages using
BTW, same result while using `telnet 127.0.0.1 55919`, which means also
have the two problem in the email before.
2017-09-08 11:23 GMT+08:00 Sam :
> Hi all,
>
> I'm using HMP socket to send command to add netdev, my command like this:
>
> [gangyewei-3@yf-mos-test-net07
Hi all,
I'm using HMP socket to send command to add netdev, my command like this:
[gangyewei-3@yf-mos-test-net07 tests]$ sudo python monitor.py 55919
> (qemu):
> Connected to qemu monitor ...
> on_monitor_open
> ds
> (qemu):
> {'return': ["unknown command: 'ds'"]}
> chardev-add
>
From: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
net/colo-compare.c | 59 --
1 file changed, 31 insertions(+), 28 deletions(-)
diff
From: Wang Yong
IOThread uses AioContext event loop and does not run a GMainContext.
Therefore,chardev cannot work in IOThread,such as the chardev is
used for colo-compare packets reception.
This patch makes the IOThread run the GMainContext event loop,
chardev and
From: Zhang Chen
The packet_enqueue() use g_queue_push_tail() to
enqueue net packet, so it is more efficent way use
g_queue_pop_head() to get packet for compare.
That will improve the success rate of comparison.
In my test the performance of ftp put 1000M file
will
From: Wang Yong
Remove the task which check old packet in the comparing thread,
then use IOthread context timer to handle it.
Process pactkets in the IOThread which arrived over the socket.
we use iothread_get_g_main_context to create a new g_main_loop in
the
From: Mao Zhongyi
When -net socket fails, it first reports a specific error, then
a generic one, like this:
$ ./x86_64-softmmu/qemu-system-x86_64 -net
socket,mcast=230.0.0.1:1234,listen
qemu-system-x86_64: -net socket,mcast=230.0.0.1:1234,listen: exactly one
On 08/09/17 00:54, Dr. David Alan Gilbert wrote:
> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
>> On 07/09/17 19:51, Dr. David Alan Gilbert wrote:
>>> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
This was inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1481593
What
From: Zhang Chen
When network is busy, some tcp options(like sack) will unpredictable
occur in primary side or secondary side. it will make packet size
not same, but the two packet's payload is identical. colo just
care about packet payload, so we skip the option
From: Kamil Rytarowski
SunOS defines SEC in as 1 (commonly used time symbols).
This fixes build on SmartOS (Joyent).
Patch cherry-picked from pkgsrc by jperkin (Joyent).
Signed-off-by: Kamil Rytarowski
Reviewed-by: Dmitry Fleytman
From: Matt Parker
Both io and memory use the same mmio functions in the rtl8139 device.
This patch removes the separate MemoryRegionOps and old_mmio accessors
for memory, and replaces it with an alias to the io memory region.
Signed-off-by: Matt Parker
From: Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and
net_socket_fd_init() use the function such as fprintf(), perror() to
report an error message.
Now, convert these functions to Error.
Cc: jasow...@redhat.com
Cc: arm...@redhat.com
From: Wang Yong
Update colo-proxy.txt,add IOThread configuration.
Later we have to configure IOThread,if not COLO can not work.
Reviewed-by: Zhang Chen
Signed-off-by: Wang Yong
Signed-off-by: Wang Guang
From: Zhang Chen
My Fujitsu mail account will be disabled soon, update the mail info
to my private mail.
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
MAINTAINERS | 2 +-
1 file changed, 1
From: Mao Zhongyi
In net_socket_fd_init(), the 'default' case is odd: it warns,
then continues as if the socket type was SOCK_STREAM. The
comment explains "this could be a eg. a pty", but that makes
no sense. If @fd really was a pty, getsockopt() would fail
with
From: Mao Zhongyi
pci_rocker_init() leaks a World when the name more than 9 chars,
then return a negative value directly, doesn't make a correct
cleanup. So add a new goto label to fix it.
Cc: jasow...@redhat.com
Cc: j...@resnulli.us
Cc: arm...@redhat.com
Cc:
From: Mao Zhongyi
Cc: berra...@redhat.com
Cc: kra...@redhat.com
Cc: pbonz...@redhat.com
Cc: jasow...@redhat.com
Cc: arm...@redhat.com
Cc: ebl...@redhat.com
Signed-off-by: Mao Zhongyi
Reviewed-by: Markus Armbruster
From: Mao Zhongyi
Cc: jasow...@redhat.com
Cc: j...@resnulli.us
Cc: arm...@redhat.com
Cc: f4...@amsat.org
Suggested-by: Markus Armbruster
Signed-off-by: Mao Zhongyi
Reviewed-by: Markus Armbruster
From: Mao Zhongyi
The rocker device still implements the old PCIDeviceClass .init()
instead of the new .realize(). All devices need to be converted to
.realize().
.init() reports errors with fprintf() and return 0 on success, negative
number on failure. Meanwhile,
From: Mao Zhongyi
Memory allocation functions like world_alloc, desc_ring_alloc etc,
they are all wrappers around g_malloc, g_new etc. But g_malloc and
similar functions doesn't return null. Because they ignore the fact
that g_malloc() of 0 bytes returns null. So error
From: Zhang Chen
Because vnet_hdr have a offset to net packet, we must add it when use
virtio-net.
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
net/filter-rewriter.c | 6 --
1 file changed, 4
The following changes since commit cda4a338c4243fa3bff4498b935340ac7121cc76:
tcg/tci: Add TCG_TARGET_DEFAULT_MO (2017-09-07 18:57:34 +0100)
are available in the git repository at:
https://github.com/jasowang/qemu.git tags/net-pull-request
for you to fetch changes up to
* Cornelia Huck [2017-09-07 12:52:20 +0200]:
> On Thu, 7 Sep 2017 12:21:50 +0200
> Halil Pasic wrote:
>
> > On 09/07/2017 10:08 AM, Cornelia Huck wrote:
> > > On Thu, 7 Sep 2017 15:31:09 +0800
> > > Dong Jia Shi wrote:
On 2017年09月07日 16:35, Fam Zheng wrote:
Hi Jason,
this is the net/ part of the conversion of library cflags/libs from global
QEMU_CFLAGS and libs_softmmu to per object variables. Please review.
Fam Zheng (2):
vl: Don't include vde header
buildsys: Move vde libs to per object
On 2017年08月29日 15:22, Wang yong wrote:
From: Wang Yong
It's a good idea to use IOThread instead of COLO comparing thread.
comparing thread can be completely replaced by IOThread, so this idea came.
This series of updates mainly include IOThread supports the
We're purchasing some new hardware, once we get it set up we'll setup a
x86_64 Haiku machine to build qemu.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1715203
Title:
Maintain Haiku support
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.inc.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index 2736022d5a..db46aea38c 100644
---
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/ppc/tcg-target.inc.c | 58 +++-
1 file changed, 48 insertions(+), 10 deletions(-)
diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c
From: Richard Henderson
We'll want this for tcg_out_nop_fill.
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.inc.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/tcg/arm/tcg-target.inc.c
From: Richard Henderson
At this point the conversion is a wash. Loading of TB+ofs is
smaller, but the actual return address from exit_tb is larger.
There are a few more insns required to transition between TBs.
But the expectation is that accesses to the constant pool will
on
From: Richard Henderson
We are not going to use ldrd for loading the comparator
for 32-bit guests, so don't limit cmp_off to 8 bits then.
This eliminates one insn in the tlb load for some guests.
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.inc.c
From: Richard Henderson
Use UBFX to avoid limitation on CPU_TLB_BITS. Since we're dropping
the initial shift, we need to replace the page masking. We can use
MOVW+BIC to do this without shifting. The result is the same size
as the armv6 path with one less conditional
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/ppc/tcg-target.h | 1 +
tcg/ppc/tcg-target.inc.c | 34 ++
2 files changed, 31 insertions(+), 4 deletions(-)
diff --git a/tcg/ppc/tcg-target.h
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.inc.c | 74 ++-
1 file changed, 34 insertions(+), 40 deletions(-)
diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.inc.c | 170 +
1 file changed, 140 insertions(+), 30 deletions(-)
diff --git a/tcg/sparc/tcg-target.inc.c
From: Richard Henderson
Move constants before all of the functions.
Move tcg_out_ functions before all
of the others. No functional change.
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.inc.c | 599 +++
From: Richard Henderson
We were passing in -2 instead of +2, but then ignoring
the actual contents of addend in the calculation.
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.inc.c | 25 +
1 file changed, 13 insertions(+),
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.h | 2 ++
tcg/sparc/tcg-target.inc.c | 77 +-
2 files changed, 58 insertions(+), 21 deletions(-)
diff --git
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.h | 1 +
tcg/aarch64/tcg-target.inc.c | 62 +++-
2 files changed, 33 insertions(+), 30 deletions(-)
diff --git
From: Richard Henderson
Already it saves 2 bytes per call, but also the constant pool
entry may well be shared across multiple calls.
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.h | 1 +
tcg/i386/tcg-target.inc.c | 18 +++---
2
From: Richard Henderson
Also use CHI/CGHI for 16-bit signed constants.
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.inc.c | 136 +++---
1 file changed, 67 insertions(+), 69 deletions(-)
diff --git
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.inc.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c
index
From: Richard Henderson
A new shared header tcg-pool.inc.c adds new_pool_label,
for registering a tcg_target_ulong to be emitted after
the generated code, plus relocation data to install a
pointer to the data.
A new pointer is added to the TCGContext, so that we
dump the
From: Richard Henderson
Split out maybe_out_small_movi for use with other operations
that want to add to the constant pool.
Signed-off-by: Richard Henderson
---
include/elf.h | 3 +-
tcg/s390/tcg-target.h | 1 +
tcg/s390/tcg-target.inc.c
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.h | 1 +
tcg/arm/tcg-target.inc.c | 92 ++--
2 files changed, 75 insertions(+), 18 deletions(-)
diff --git
From: Richard Henderson
Dispense with TCGBackendData, as it has never been used for more than
holding a single pointer. Use a define in the cpu/tcg-target.h to
signal requirement for TCGLabelQemuLdst, so that we can drop the no-op
tcg-be-null.h stubs. Rename tcg-be-ldst.h to
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.inc.c | 77 ---
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c
From: Richard Henderson
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.h | 2 +-
tcg/s390/tcg-target.inc.c | 71 +++
2 files changed, 61 insertions(+), 12 deletions(-)
diff --git
From: Richard Henderson
Replace the USE_DIRECT_JUMP ifdef with a TCG_TARGET_HAS_direct_jump
boolean test. Replace the tb_set_jmp_target1 ifdef with an unconditional
function tb_target_set_jmp_target.
While we're touching all backends, add a parameter for tb->tc_ptr;
we're
:57:34 +0100)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-tcg-20170907
for you to fetch changes up to 53c89efd02cef626040165cc8f06b5cf2c15355d:
tcg/ppc: Use constant pool for movi (2017-09-07 11:57:35 -0700
On 08/09/17 06:53, Philippe Mathieu-Daudé wrote:
> On 09/07/2017 06:20 AM, Alexey Kardashevskiy wrote:
>> This allows sharing flat views between address spaces when the same root
>> memory region is used when creating a new address space.
>>
>> This adds a global list of flat views and a list of
This patch adds a description of the current TPM support in QEMU
to the specs.
Several public specs are referenced via their landing page on the
trustedcomputinggroup.org website.
Signed-off-by: Stefan Berger
Reviewed-by: Laszlo Ersek
---
Hi Subbaraya,
very good work!
On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote:
Hi Qemu-devel,
I am trying to add Smartfusion2 SoC.
SoC is from Microsemi and System on Module(SOM)
board is from Emcraft systems. Smartfusion2 has hardened
Microcontroller(Cortex-M3)based Sub System and FPGA
On Thu, Sep 7, 2017 at 2:35 PM, Edgar E. Iglesias
wrote:
> On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote:
>>
>> The EL2 and EL3 work is working well now and interanlly we now have
>> tests that expect to start in EL3 and transition through EL2 to EL1.
- Original Message -
> baum.o already receives the sdl cflags in its per object variable, do
> the same for brlapi libs to avoid cluttering libs_softmmu.
>
> Signed-off-by: Fam Zheng
Reviewed-by: Marc-André Lureau
> ---
>
On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote:
Smartfusion2 SoC has hardened Microcontroller subsystem
and flash based FPGA fabric. This patch adds support for
Microcontroller subsystem in the SoC.
Signed-off-by: Subbaraya Sundeep
Reviewed-by: Alistair Francis
On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote:
>
> The EL2 and EL3 work is working well now and interanlly we now have
> tests that expect to start in EL3 and transition through EL2 to EL1. To
> make this easy to run let's expose the secure property to the machine
> and also
On 09/05/2017 05:59 AM, Thomas Huth wrote:
> On 01.09.2017 20:03, Eric Blake wrote:
>> As a general rule, we prefer avoiding implicit global state
>> because it makes code harder to safely copy and paste without
>> thinking about the global state. Although bios-tables-test does
>> not maintain
On Thu, Sep 7, 2017 at 10:21 PM Stefan Berger
wrote:
> Also add backends/tpm.c to the list of files.
>
> Signed-off-by: Stefan Berger
>
Acked-by: Marc-André Lureau
thanks
---
> MAINTAINERS | 4 +++-
> 1
On 09/07/2017 06:20 AM, Alexey Kardashevskiy wrote:
This allows sharing flat views between address spaces when the same root
memory region is used when creating a new address space.
This adds a global list of flat views and a list of attached address
spaces per a flat view. Each address space
vhost registers a MemoryListener where it adds and removes references
to MemoryRegions as the MemoryRegionSections pass through. The
region_add callback is invoked for each existing section when the
MemoryListener is registered, but unregistering the MemoryListener
performs no reciprocal
On 09/05/2017 05:32 AM, Thomas Huth wrote:
> On 01.09.2017 20:03, Eric Blake wrote:
>> Managing parallel connections to two different monitors via
>> the implicit global_qtest makes it hard to copy-and-paste code
>> to tests that are not aware of the implicit state; the
>> management of
SCLP correctly indicates the core-id aka. CPU address for each available
CPU.
As the core-id corresponds to cpu_index, also a newly created kvm vcpu
gets assigned this core-id as vcpu id. So SIGP in the kernel works
correctly (it uses the vcpu id to lookup the correct CPU).
So there should be
Now that there is only one user of cpu_s390x_create() left, make cpu
creation look like on x86.
- Perform the model/properties split and checks in s390_init_cpus()
- Parse features only once without having to remember if already parsed
- Pass only the typename to s390x_new_cpu()
- Use the typename
CPU hotplug is only possible on a per core basis on s390x.
As we now have ms->possible_cpus, we can get rid of the global variable
cpu_states.
While rewriting s390_cpu_addr2state() completely to be based on
possible_cpus, move it to cpu.c, as it is independent of the virtio-ccw
machine.
device_del on a CPU will currently do nothing. Let's emmit an error
telling that this is will currently not work (there is no architecture
support on s390x). Error message copied from ppc.
(qemu) device_del cpu1
device_del cpu1
CPU hot unplug not supported on this machine
Reviewed-by: Matthew
E.g. the following now works:
device_add host-s390-cpu,id=cpu1,core-id=1
The system will perform the same checks as when using cpu_add:
- If the core_id is already in use
- If the next sequential core_id isn't used
- If core-id >= max_cpu is specified
In addition, mixed CPU models are
scc->next_cpu_id is updated when realizing. Setting it just before that
point looks cleaner.
Reviewed-by: Matthew Rosato
Signed-off-by: David Hildenbrand
---
target/s390x/cpu.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
This is the first step to allow hot plugging of CPUs in a non-sequential
order. If a cpu is available ("plugged") can directly be decided by
looking at the cpu state pointer.
This makes sure, that really only cpus attached to the machine are
reported.
Signed-off-by: David Hildenbrand
Other architectures provide nicely sorted lists, let's do it similarly on
s390x.
While at it, clean up the code we have to touch either way.
Signed-off-by: David Hildenbrand
---
target/s390x/cpu_models.c | 56 ++-
1 file changed, 41
Implemented in sclp.c, so let's move it to the right include file.
Fix up one include. Do a forward declaration of CPUS390XState to fix the
two sclp consoles complaining.
Signed-off-by: David Hildenbrand
---
include/hw/s390x/sclp.h| 2 ++
target/s390x/cpu.h | 1 -
Adapt to the new term "core_id". While at it, fix the type and drop the
initialization to 0 (which is superfluous).
Reviewed-by: Matthew Rosato
Signed-off-by: David Hildenbrand
---
target/s390x/cpu-qom.h | 2 +-
target/s390x/cpu.c | 11
Some time ago we discussed that using "id" as property name is not the
right thing to do, as it is a reserved property for other devices and
will not work with device_add.
Switch to the term "core-id" instead, and use it as an equivalent to
"CPU address" mentioned in the PoP. There is no such
Implemented in hw/s390x/s390-virtio-hcall.c, so let's move it to the
right header file.
Reviewed-by: Thomas Huth
Signed-off-by: David Hildenbrand
---
hw/s390x/s390-virtio-hcall.h | 1 +
target/s390x/cpu.h | 1 -
target/s390x/kvm.c | 1 +
Also add backends/tpm.c to the list of files.
Signed-off-by: Stefan Berger
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index caf7e8a..c434a09 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1487,12
Clean it up by reusing program_interrupt(). Add a concern regarding
ilen.
Signed-off-by: David Hildenbrand
---
target/s390x/misc_helper.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
Implemented in s390-virtio-ccw.c, so move it to the right header.
We can also drop the extern. Fix up one include.
Signed-off-by: David Hildenbrand
---
include/hw/s390x/s390-virtio-ccw.h | 2 ++
target/s390x/cpu.h | 1 -
target/s390x/diag.c| 1 +
It is a leftover from the days where we had still the !ccw virtio
machine. As this one is long gone, let's move everything to
s390-virtio-ccw.c.
Suggested-by: Cornelia Huck
Reviewed-by: Thomas Huth
Acked-by: Christian Borntraeger
>> +CPUListState *s = user_data;
>> +const S390CPUClass *scc = S390_CPU_CLASS((ObjectClass *)data);
>> +char *name = g_strdup(object_class_get_name((ObjectClass *)data));
>>
>> /* strip off the -s390-cpu */
>> g_strrstr(name, "-" TYPE_S390_CPU)[0] = 0;
>> -
These comments are obviously stale.
Acked-by: Cornelia Huck
Signed-off-by: David Hildenbrand
---
include/qom/cpu.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 995a7beeb5..0dc767a753
The only interface left, so let's properly rename it.
Reviewed-by: Thomas Huth
Acked-by: Christian Borntraeger
Signed-off-by: David Hildenbrand
---
hw/s390x/s390-virtio-ccw.c | 2 +-
hw/s390x/s390-virtio-hcall.c
This looks cleaner. linux-user will not use the ilen field, so setting
it doesn't do any harm.
Reviewed-by: Thomas Huth
Signed-off-by: David Hildenbrand
---
target/s390x/excp_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
The first patches are a bunch of cleanups. I decided to go the
extra mile and implement CPU hotplug via "device_add", as well as
"query-hotpluggable-cpus".
On s390x, only complete cores can be plugged. CPU hot unplug is currently
not supported by the architecture.
In contrast to v2, this series
All but a handful of files include exec/cpu-all.h via cpu.h only.
As these files already include cpu.h, let's just drop the additional
include.
Reviewed-by: Thomas Huth
Signed-off-by: David Hildenbrand
---
dump.c| 1 -
exec.c
Let's move it to the place where struct S390CPU is defined.
Suggested-by: Thomas Huth
Tested-by: Thomas Huth
Signed-off-by: David Hildenbrand
---
target/s390x/cpu-qom.h | 2 --
target/s390x/cpu.h | 4 ++--
2 files changed, 2
Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the
guest tries to bring these CPUs up but fails), because we don't support
multiple CPUs on s390x under TCG.
Let's bail out if more than 1 is specified, so we don't raise people's
hope. Make it a define, so we can easily bump it up
That code has been remove with this commit:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=745549c8d0273d3a3d9c3701
... so I think we can close this ticket nowadays.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
Triaging old bug tickets... Which version of QEMU have you been using
here? Can you still reproduce this issue with the latest version of
QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a
1 - 100 of 376 matches
Mail list logo