Re: [Qemu-devel] [RFC PATCH qemu 3/4] memory: Share flat views and dispatch trees between address spaces

On 12/09/17 01:30, Paolo Bonzini wrote: > On 11/09/2017 14:08, Alexey Kardashevskiy wrote: >>> Ok, this makes sense. Maybe it should be a flatview rather than an >>> AddressSpaceDispatch (a FlatView is essentially a list of >>> MemoryRegionSections; attaching the ASD to the FlatView is more or

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 04/21] ppc/xive: provide a link to the sPAPR ICS object under XIVE

On 09/12/2017 12:04 AM, Greg Kurz wrote: > On Mon, 11 Sep 2017 19:12:18 +0200 > Cédric Le Goater wrote: > >> The sPAPR machine first starts with a XICS interrupt model and >> depending on the guest capabilities, the XIVE exploitation mode is >> negotiated during CAS. A reset

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

On 12.09.2017 06:52, Miroslav Rezanina wrote: > > > - Original Message - >> From: "Thomas Huth" >> To: "Laurent Vivier" , qemu-devel@nongnu.org >> Cc: "David Gibson" , qemu-...@nongnu.org, "Dr . >> David Alan Gilbert"

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

- Original Message - > From: "Thomas Huth" > To: "Laurent Vivier" , qemu-devel@nongnu.org > Cc: "David Gibson" , qemu-...@nongnu.org, "Dr . > David Alan Gilbert" > , "Miroslav Rezanina"

Re: [Qemu-devel] [PATCH v2] spapr_cpu_core: cleaning up qdev_get_machine() calls

On Tue, Sep 12, 2017 at 01:27:53PM +1000, David Gibson wrote: > On Mon, Sep 11, 2017 at 11:10:57PM +0200, Greg Kurz wrote: > > This patch removes the qdev_get_machine() calls that are made > > in spapr_cpu_core.c in situations where we can get an existing > > pointer for the MachineState by either

Re: [Qemu-devel] [PATCH] xics: fix several error leaks

On Tue, Sep 12, 2017 at 12:04:40AM +0200, Greg Kurz wrote: > If object_property_get_link() fails then it allocates an error, which > must be freed before returning. The error_get_pretty() function is > merely an accessor to the error message and doesn't free anything. > > The error.h header

Re: [Qemu-devel] [PATCH qemu] vfio, spapr: Fix levels calculation

On Tue, Sep 12, 2017 at 12:53:07PM +1000, Alexey Kardashevskiy wrote: > The existing tries to round up the number of pages but @pages is always > calculated as the rounded up value minus one which makes ctz64() always > return 0 and have create.levels always set 1. > > This removes wrong "-1"

Re: [Qemu-devel] [PATCH] spapr_cpu_core: fail gracefully with non-pseries machine types

On Mon, Sep 11, 2017 at 10:52:06PM +0200, Greg Kurz wrote: > Since commit 7cca3e466eb0 ("ppc: spapr: Move VCPU ID calculation into > sPAPR"), QEMU aborts when started with a *-spapr-cpu-core device and > a non-pseries machine. > > Let's rely on the already existing call to object_dynamic_cast()

Re: [Qemu-devel] [PATCH v2] spapr_cpu_core: cleaning up qdev_get_machine() calls

On Mon, Sep 11, 2017 at 11:10:57PM +0200, Greg Kurz wrote: > This patch removes the qdev_get_machine() calls that are made > in spapr_cpu_core.c in situations where we can get an existing > pointer for the MachineState by either passing it as an argument > to the function or by using other already

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

On 09/11/2017 02:37 PM, Peter Maydell wrote: > On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote: >> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >> >> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': >>

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote: > this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): > > qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': > qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not > expecting:

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu)

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

On 09/11/17 11:52 -0700, Stefano Stabellini wrote: > CC'ing xen-devel, and the Xen tools and x86 maintainers. > > On Mon, 11 Sep 2017, Igor Mammedov wrote: > > On Mon, 11 Sep 2017 12:41:47 +0800 > > Haozhong Zhang wrote: > > > > > This is the QEMU part patches that

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu)

[Qemu-devel] [PATCH qemu] vfio, spapr: Fix levels calculation

The existing tries to round up the number of pages but @pages is always calculated as the rounded up value minus one which makes ctz64() always return 0 and have create.levels always set 1. This removes wrong "-1" and allows having more than 1 levels. This becomes handy for >128GB guests with

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

Kevin, Thanks for the suggestion of share-rw=on. I figured I'd try to change our 'xkvm' wrapper around qemu to use that. Unfortunately, it looks like , at least in our version of qemu (QEMU emulator version 2.10.0(Debian 1:2.10+dfsg-0ubuntu1)), that this does not work with the -drive path. $

Re: [Qemu-devel] [PATCH] tcg: Fix tci build

Good to know, and thanks for your review and remind. Regards, Jincheng Miao On Tue, Sep 12, 2017 at 1:29 AM, Alistair Francis wrote: > On Mon, Sep 11, 2017 at 5:17 PM, wrote: >> From: Jincheng Miao >> >> The previous

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, September 12, 2017 2:38 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; > r...@twiddle.net; mtosa...@redhat.com; vroze...@redhat.com; > Huangweidong (C) >

Re: [Qemu-devel] [PATCH 00/27] vhost-user-scsi: code clean-up

Hi Marcandre, Of course, I agree your cleanup patch set should go first, just re-post the patch set after the new Qemu release, I think the first 3 patches don't have dependency on your patch set. From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com] Sent: Monday, September 11, 2017

Re: [Qemu-devel] [PATCH] x86/acpi: build SRAT when memory hotplug is enabled

Hi Igor, At 09/11/2017 06:58 PM, Igor Mammedov wrote: > > > > Igor's suggestion to enable NUMA implicitly sounds safer to me. > > > > I agree with Igor too. > > Is anybody doing this? If not, may I make a patch to enable adding NUMA > node implicitly first. let's see what it looks like. As

Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit()

On 09/11/2017 01:20 PM, Eric Blake wrote: > Rather than have two similar shutdown functions, where one requires > the use of global_qtest in the header, it is better to have a single > shutdown function that still takes care of cleaning up global_qtest > if it is set. All callers are updated. >

Re: [Qemu-devel] [PATCH v7 18/38] ahci-test: Drop dependence on global_qtest

On 09/11/2017 08:20 PM, John Snow wrote: > > > On 09/11/2017 01:20 PM, Eric Blake wrote: >> Managing parallel connections to two different monitors via >> the implicit global_qtest makes it hard to copy-and-paste code >> to tests that are not aware of the implicit state; the >> management of

Re: [Qemu-devel] [PATCH v7 18/38] ahci-test: Drop dependence on global_qtest

On 09/11/2017 01:20 PM, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state; the > management of global_qtest is even harder to follow because > it was

Re: [Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

On Mon, 09/11 11:44, Alex Bennée wrote: > > Fam Zheng writes: > > > On Fri, 09/08 16:22, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > This is the common code to implement a "VM test" to > >> > > >> > 1) Download and initialize a pre-defined VM

Re: [Qemu-devel] [PATCH v6 03/12] scripts: Add archive-source.sh

On Mon, 09/11 14:43, Alex Bennée wrote: > > Fam Zheng writes: > > > On Fri, 09/08 15:42, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > Signed-off-by: Fam Zheng > >> > --- > >> > scripts/archive-source.sh | 31

Re: [Qemu-devel] [PATCH v7 17/38] libqos: Use explicit QTestState for remaining libqos operations

On 09/11/2017 01:20 PM, Eric Blake wrote: > Drop one more client of global_qtest by teaching all remaining > libqos stragglers to pass in an explicit QTestState. Change the > setting of global_qtest from being implicit in libqos' call to > qtest_start() to instead be explicit in all clients

Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState for ahci operations

On 09/11/2017 01:20 PM, Eric Blake wrote: > Drop one more client of global_qtest by teaching all ahci test > functionality to pass in an explicit QTestState. The state was > already available, so no callers had to be adjusted. > > Signed-off-by: Eric Blake I should admit

Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState for fw_cfg operations

On 09/11/2017 01:19 PM, Eric Blake wrote: > Drop one more client of global_qtest by teaching all fw_cfg test > functionality (invoked through alloc-pc) to pass in an explicit > QTestState, adjusting all callers. In particular, fw_cfg-test > had to reorder things to create the test state prior

Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus

On 09/11/2017 01:19 PM, Eric Blake wrote: > When initializing a QPCIBus, track which QTestState the bus is > associated with (so that a later patch can then explicitly use > that test state for all communication on the bus, rather than > blindly relying on global_qtest). Update the

Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions

On 12.09.2017 00:13, Philippe Mathieu-Daudé wrote: > On 09/11/2017 06:44 PM, Kamil Rytarowski wrote: >> On 11.09.2017 23:33, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> cleaning while here :) >>> >>>   accel/tcg/user-exec.c | 18

Re: [Qemu-devel] [Qemu-block] [PATCH 00/12] cleanup qemu-iotests

- Original Message - > From: "John Snow" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: kw...@redhat.com, qemu-bl...@nongnu.org > Sent: Tuesday, September 12, 2017 12:22:26 AM > Subject: Re: [Qemu-block] [PATCH 00/12] cleanup qemu-iotests > >

Re: [Qemu-devel] [Qemu-block] [PATCH 00/12] cleanup qemu-iotests

On 08/09/2017 05:54 PM, Paolo Bonzini wrote: > The purpose of this series is to separate the "check" sources from > the tests. After these patches, common.config is reduced to simple > shell initialization, and common.rc is only included by the tests. > > Along the way, a lot of dead code is

Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions

On 09/11/2017 06:44 PM, Kamil Rytarowski wrote: On 11.09.2017 23:33, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- cleaning while here :) accel/tcg/user-exec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [Bug 1716510] [NEW] qemu 2.10.0 cannot boot Windows 10 familly

Public bug reported: On qemu 2.10.0 Windows 10 and Windows Server 2016 hangs during boot. Below is setup of Windows Server 2016. Downgrading to 2.9 fixes the problem. /usr/bin/qemu-system-x86_64 -name guest=,debug-threads=on -S -object

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 04/21] ppc/xive: provide a link to the sPAPR ICS object under XIVE

On Mon, 11 Sep 2017 19:12:18 +0200 Cédric Le Goater wrote: > The sPAPR machine first starts with a XICS interrupt model and > depending on the guest capabilities, the XIVE exploitation mode is > negotiated during CAS. A reset should then be performed to rebuild the > device tree

[Qemu-devel] [PATCH] xics: fix several error leaks

If object_property_get_link() fails then it allocates an error, which must be freed before returning. The error_get_pretty() function is merely an accessor to the error message and doesn't free anything. The error.h header indicates how to do it right: * Pass an existing error to the caller

Re: [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency

On Mon, Sep 11, 2017 at 11:02 PM Philippe Mathieu-Daudé wrote: > this fixes running 'make check-unit' without running 'make all' beforehand: > > $ make check-unit > ... > GTESTER tests/test-qga > ** > ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL):

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

On 08/03/2017 08:25 PM, Eric Blake wrote: > qobject_from_jsonv() was unusual in that it took a va_list*, instead > of the more typical va_list; this was so that callers could pass > NULL to avoid % interpolation. While this works under the hood, it > is awkward for callers, so move the magic into

Re: [Qemu-devel] [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/

- Original Message - > From: "Philippe Mathieu-Daudé" > To: "Paolo Bonzini" , "Richard Henderson" > , "Peter Crosthwaite" > , "Thomas Huth" > Cc: "Philippe Mathieu-Daudé"

Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report

(Cc'ing Yongbok and Aurelien from get_maintainer.pl) On 09/11/2017 04:52 PM, Alistair Francis wrote: Convert the fprintf() messages in kvm_mips_update_state() to use warn_report() as they aren't errors, but are just warnings. Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report

On Mon, Sep 11, 2017 at 12:52:59PM -0700, Alistair Francis wrote: > Convert the fprintf() messages in kvm_mips_update_state() to use > warn_report() as they aren't errors, but are just warnings. > > Signed-off-by: Alistair Francis > Cc: James Hogan

Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions

On 11.09.2017 23:33, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > cleaning while here :) > > accel/tcg/user-exec.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/accel/tcg/user-exec.c

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote: > this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): > > qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': > qemu/include/qemu/compiler.h:86:30: error: static assertion failed:

[Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions

Signed-off-by: Philippe Mathieu-Daudé --- cleaning while here :) accel/tcg/user-exec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 2a975eaf69..484a3f5f8f 100644 ---

[Qemu-devel] [PATCH v2 4/5] tcg: move atomic_template.h to accel/tcg/

Signed-off-by: Philippe Mathieu-Daudé Tested-by: Thomas Huth --- atomic_template.h => accel/tcg/atomic_template.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename atomic_template.h => accel/tcg/atomic_template.h (100%) diff --git

[Qemu-devel] [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/

Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- Makefile.target | 2 +- {tcg => accel/tcg}/tcg-runtime.h | 0 {tcg => accel/tcg}/tcg-runtime.c | 0 accel/tcg/Makefile.objs | 1 + 4 files changed, 2

Re: [Qemu-devel] [PATCH v7 35/38] libqtest: Merge qtest_{mem, buf}{read, write}() with {mem, buf}{read, write}()

On Mon, 11 Sep 2017 12:20:19 -0500 Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and

[Qemu-devel] [PATCH v2 0/5] move user-exec, tcg-runtime, atomic_template.h to accel/tcg/

As suggested by Paolo: That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, and user-exec.c should in turn be in accel/tcg. in http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg03657.html also update MAINTAINERS accordingly. Regards, Phil. Philippe

[Qemu-devel] [PATCH v2 2/5] tcg: move user-exec to accel/tcg/

Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- Makefile.target| 4 ++-- user-exec-stub.c => accel/tcg/user-exec-stub.c | 0 user-exec.c => accel/tcg/user-exec.c | 0 MAINTAINERS

[Qemu-devel] [PATCH v2 1/5] tcg: Move softmmu_template.h to the accel/tcg/ folder

From: Thomas Huth The header is only used by accel/tcg/cputlb.c so we can move it to the accel/tcg/ folder, too. Signed-off-by: Thomas Huth [PMD: reword commit title to match series] Signed-off-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v7 17/38] libqos: Use explicit QTestState for remaining libqos operations

On Mon, 11 Sep 2017 12:20:01 -0500 Eric Blake wrote: > Drop one more client of global_qtest by teaching all remaining > libqos stragglers to pass in an explicit QTestState. Change the > setting of global_qtest from being implicit in libqos' call to > qtest_start() to instead

[Qemu-devel] [PATCH v2] osdep.h: Prohibit disabling assert() in supported builds

We already have several files that knowingly require assert() to work, sometimes because refactoring the code for proper error handling has not been tackled yet; there are probably other files that have a similar situation but with no comments documenting the same. In fact, we have places in

[Qemu-devel] [PATCH v2] spapr_cpu_core: cleaning up qdev_get_machine() calls

This patch removes the qdev_get_machine() calls that are made in spapr_cpu_core.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. Credits to Daniel Henrique Barboza for the

Re: [Qemu-devel] [PATCH] spapr_cpu_core: cleaning up qdev_get_machine() calls

On Mon, 11 Sep 2017 22:52:52 +0200 Greg Kurz wrote: > This patch removes the qdev_get_machine() calls that are made > in spapr_cpu_core.c in situations where we can get an existing > pointer for the MachineState by either passing it as an argument > to the function or by using

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Hi Stefan, On 09/11/2017 05:26 PM, Stefan Weil wrote:> I had an assertion because of a missing qemu-ga when I‌ only had run "make check", so there is a dependency (perhaps check: tools) missing. Now "make check" is running fine with all targets (at least until check-qtest-ppc64). Sorry, I

[Qemu-devel] [PATCH] Drop gld linker usage on SunOS

This is required to be removed on SmartOS (Illumos). As of now there are no alternative supported SunOS distributions. Signed-off-by: Kamil Rytarowski --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index fd7e3a5e81..3dc0a71984 100755 ---

[Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency

this fixes running 'make check-unit' without running 'make all' beforehand: $ make check-unit ... GTESTER tests/test-qga ** ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/build/qemu/qemu-ga" (No such file or directory)

[Qemu-devel] [PATCH] spapr_cpu_core: fail gracefully with non-pseries machine types

Since commit 7cca3e466eb0 ("ppc: spapr: Move VCPU ID calculation into sPAPR"), QEMU aborts when started with a *-spapr-cpu-core device and a non-pseries machine. Let's rely on the already existing call to object_dynamic_cast() instead of using the SPAPR_MACHINE() macro. Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH] spapr_cpu_core: cleaning up qdev_get_machine() calls

This patch removes the qdev_get_machine() calls that are made in spapr_cpu_core.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. Credits to Daniel Henrique Barboza for the

[Qemu-devel] [Bug 1715700] Re: Windows 7 guest won't boot on qemu 2.10 (works on 2.9)

Bisected. Good thing Igor is already here :) 208fa0e43645edd0b0d8f838857dfc79daff40a8 is the first bad commit commit 208fa0e43645edd0b0d8f838857dfc79daff40a8 Author: Igor Mammedov Date: Fri Jul 28 11:09:05 2017 +0200 pc: make 'pc.rom' readonly when machine has PCI

[Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE"

[Qemu-devel] [Bug 1615823] Re: Windows 10 reports no compatible TPM found yet device manager shows it?

My laptop has a TPM 1.2 chip made by IFX (dmesg: tpm_tis 00:07: 1.2 TPM (device-id 0x1B, rev-id 16)) I couldn't get it to work in libvirt (I am running ubuntu 17.04) until I upgraded my Windows 10 to version 1607. I needed to change the CPU to "core2duo" first before I could apply the version

[Qemu-devel] [PATCH v2] Replace round_page() with TARGET_PAGE_ALIGN()

This change fixes conflict with the DragonFly BSD headers. Signed-off-by: Kamil Rytarowski --- hw/ppc/mac_newworld.c | 11 +++ hw/ppc/mac_oldworld.c | 11 +++ 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/hw/ppc/mac_newworld.c

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Am 11.09.2017 um 20:24 schrieb Peter Maydell: > I've also turned on a tci compile check on my pre-merge tests. > (It doesn't pass "make check" for me, though...) Did you run "make" before running "make check"? I had an assertion because of a missing qemu-ga when I‌ only had run "make check", so

Re: [Qemu-devel] [PATCH] Rename round_page() to round_pageq()

On 11.09.2017 22:16, Peter Maydell wrote: > On 11 September 2017 at 21:00, Kamil Rytarowski wrote: >> This change fixes conflict with the DragonFly BSD headers. >> >> Signed-off-by: Kamil Rytarowski > > What's the rationale for calling it round_pageq() > in

Re: [Qemu-devel] [PATCH] Rename round_page() to round_pageq()

On 11 September 2017 at 21:00, Kamil Rytarowski wrote: > This change fixes conflict with the DragonFly BSD headers. > > Signed-off-by: Kamil Rytarowski What's the rationale for calling it round_pageq() in particular? thanks -- PMM

[Qemu-devel] [PATCH] Rename round_page() to round_pageq()

This change fixes conflict with the DragonFly BSD headers. Signed-off-by: Kamil Rytarowski --- hw/ppc/mac_newworld.c | 8 hw/ppc/mac_oldworld.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index

Re: [Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error

On Mon, Sep 11, 2017 at 9:36 AM, Alistair Francis wrote: > On Mon, Sep 11, 2017 at 2:57 AM, Paolo Bonzini wrote: >> On 18/08/2017 20:47, Alistair Francis wrote: >>> As discussed with Paolo and Markus let's combine libqemustub.a into >>>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Discover openpty(3) dynamically in configure

On 11.09.2017 19:16, Kamil Rytarowski wrote: > openpty(3) might: > - exists in libc (OSX) > - exists in libutil (GNU, BSD) > - does not exist (SmartOS) > > Add a function to discover this function in the ./configure script. > Add new config types: CONFIG_OPENPTY_LIBC and

[Qemu-devel] [PATCH v4 7/8] Makefile: Remove libqemustub.a

Using two libraries (libqemuutil.a and libqemustub.a) would sometimes result in circular dependencies. To avoid these issues let's just combine both into a single library that functions as both. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v4 4/8] Convert multi-line fprintf() to warn_report()

Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands: find ./* -type f -exec sed -i \ 'N;

[Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report

Convert the fprintf() messages in kvm_mips_update_state() to use warn_report() as they aren't errors, but are just warnings. Signed-off-by: Alistair Francis Cc: James Hogan --- target/mips/kvm.c | 6 +++--- 1 file changed, 3 insertions(+),

[Qemu-devel] [PATCH v4 3/8] Convert single line fprintf(.../n) to warn_report()

Convert all the single line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i \ 's|fprintf(.*".*warning[,:]

[Qemu-devel] [PATCH v4 5/8] General warn report fixups

Tidy up some of the warn_report() messages after having converted them to use warn_report(). Signed-off-by: Alistair Francis Reviewed-by: Markus Armbruster --- V4: - Small fixes block/vvfat.c | 3 +-- hw/arm/vexpress.c

[Qemu-devel] [PATCH v4 8/8] Convert remaining single line fprintf() to warn_report()

Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i 's|fprintf(.*".*warning[,:] |warn_report("|Ig'

[Qemu-devel] [PATCH v4 2/8] Convert remaining error_report() to warn_report()

In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we converted uses of error_report("warning:"... to use warn_report() instead. This was to help standardise on a single method of printing warnings to the user. There appears to have been some cases that slipped through in patch sets

[Qemu-devel] [PATCH v4 1/8] hw/i386: Improve some of the warning messages

Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost Cc: Eduardo Habkost --- V4: - Fixup pc_q35.c message V3: - Improve the messages hw/i386/acpi-build.c | 15 ++- hw/i386/pc.c | 7 +++

[Qemu-devel] [PATCH v4 0/8] More warning reporting fixed

This series expands on my previous series by converting more existing prints to use warn_report() instead of error_report() or fprintf(). As discussed with Paolo and Markus this series combines libqemustub.a into libqemuutil.a to avoid circular dependencies. V4: - Improve some extra MIPs

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Am 11.09.2017 um 21:47 schrieb Philippe Mathieu-Daudé: [...]> Stefan are you testing no-X86 targets? I only tested x86_64: ./configure --enable-debug --enable-tcg-interpreter \ --target-list=x86_64-linux-user,x86_64-softmmu If other targets fail, I'll have a look to find the cause. Stefan

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Hi Peter, Stefan, Am 11.09.2017 um 20:24 schrieb Peter Maydell: I've also turned on a tci compile check on my pre-merge tests. (It doesn't pass "make check" for me, though...) Peter you might want to restrict it to X86... --target-list=subdir-i386-softmmu,x86_64-softmmu,x86_64-linux-user

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Am 11.09.2017 um 20:24 schrieb Peter Maydell: > On 11 September 2017 at 19:01, Richard Henderson > wrote: >> On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote: >>> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: >>> >>>

Re: [Qemu-devel] [Patch 0/3] vfio: reusing address space for the same iommu group devices

On Tue, 12 Sep 2017 02:56:29 +0800 w...@redhat.com wrote: > From: Wei Xu > > Recently I have been testing passing through 2 ixgbe(82599ES) nics which > belong to the same iommu group to a guest with virtual iommu(vIOMMU) on > my desktop, while vfio failed to realize the second

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

On Mon, Sep 11, 2017 at 10:10 AM, Daniel P. Berrange wrote: It feels like this is still dangerous - the client simply has to interleave each "ping" with a 1 byte binary frame to get around this limit. We need to make sure we have an absolute cap on the output buffer size.

Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error

* Eric Blake (ebl...@redhat.com) wrote: > On 09/06/2017 06:51 AM, Juan Quintela wrote: > > So far, we had to free the error after each caller, so just do it > > here. Once there, tls.c was leaking the error. > > You mention tls.c, > > > > > Signed-off-by: Juan Quintela >

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

CC'ing xen-devel, and the Xen tools and x86 maintainers. On Mon, 11 Sep 2017, Igor Mammedov wrote: > On Mon, 11 Sep 2017 12:41:47 +0800 > Haozhong Zhang wrote: > > > This is the QEMU part patches that works with the associated Xen > > patches to enable vNVDIMM support

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

Hello On Thu, Aug 17, 2017 at 1:54 PM, Anatol Pomozov wrote: > Hi > > On Tue, Aug 8, 2017 at 8:04 AM, Kevin Wolf wrote: >> Am 04.08.2017 um 06:53 hat Anatol Pomozov geschrieben: >>> Hi Kevin >>> >>> Thanks for the information. >>> >>> So I sounds like

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

Hello I have these changes ready now http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03265.html It added ELF parser functionality as discussed above. Are there any open questions? What is the best way to proceed forward with these patches? I also have interest in adding Multiboot2

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

On Mon, Sep 11, 2017 at 11:20:27PM +0800, Gonglei wrote: > Starting with Windows Server 2012 and Windows 8, if > CPUID.4005.EAX contains a value of -1, Windows assumes specific > limit to the number of VPs. In this case, Windows Server 2012 > guest VMs may use more than 64 VPs, up to the

[Qemu-devel] [Patch 3/3] vfio: remove checking duplicated vfio device

From: Wei Xu This has been done when introducing 'vfio_lookup_as()' patch as a side work to reuse the loop. Signed-off-by: Wei Xu --- hw/vfio/pci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index

[Qemu-devel] [Patch 2/3] vfio: invoke looking up address space.

From: Wei Xu Invoke looking up correct address space before getting an IOMMU group. Signed-off-by: Wei Xu --- hw/vfio/pci.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 31e1edf..856cefd 100644

[Qemu-devel] [Patch 0/3] vfio: reusing address space for the same iommu group devices

From: Wei Xu Recently I have been testing passing through 2 ixgbe(82599ES) nics which belong to the same iommu group to a guest with virtual iommu(vIOMMU) on my desktop, while vfio failed to realize the second device and prompted error message as 'group xxx used in multiple

[Qemu-devel] [Patch 1/3] vfio: reusing address space for the same IOMMU group devices

From: Wei Xu Currently address space of a vfio device is selected by directly looking up pci device IOMMU address space during realizing, this usually works for most none separate address space targeted cases since they are using the system address space, i.e. a q35 machine

Re: [Qemu-devel] [PATCH 4/5] s390x/css: support ccw IDA

On 09/06/2017 03:10 PM, Cornelia Huck wrote: > On Tue, 5 Sep 2017 13:16:44 +0200 > Halil Pasic wrote: > >> Let's add indirect data addressing support for our virtual channel >> subsystem. This implementation does no prefetching, but steps >> trough the idal as we go.

Re: [Qemu-devel] [PATCH v3 08/21] s390x: move sclp_service_call() to sclp.h

On Mon, Sep 11, 2017 at 07:56:19PM +0200, David Hildenbrand wrote: > > > #endif > >>> > >>> Why not use typedefs.h? > >> > >> See Markus's reply. But, maybe it's even better to use S390CPU* and > >> include target/s390x/cpu-qom.h, which by design provides as little > >> definitions as

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

On 11 September 2017 at 19:01, Richard Henderson wrote: > On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote: >> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: >> >> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: >>

Re: [Qemu-devel] [PATCH v3 08/21] s390x: move sclp_service_call() to sclp.h

On Mon, Sep 11, 2017 at 12:23:10PM +0200, Paolo Bonzini wrote: > On 10/09/2017 00:07, Eduardo Habkost wrote: > > On Fri, Sep 08, 2017 at 02:46:36PM +0200, David Hildenbrand wrote: > >> On 08.09.2017 06:21, Thomas Huth wrote: > >>> On 07.09.2017 22:13, David Hildenbrand wrote: > Implemented in

Re: [Qemu-devel] [PATCH v3 08/21] s390x: move sclp_service_call() to sclp.h

On Mon, Sep 11, 2017 at 04:23:09AM +0200, Thomas Huth wrote: > On 10.09.2017 00:07, Eduardo Habkost wrote: > > On Fri, Sep 08, 2017 at 02:46:36PM +0200, David Hildenbrand wrote: > >> On 08.09.2017 06:21, Thomas Huth wrote: > >>> On 07.09.2017 22:13, David Hildenbrand wrote: > Implemented in

[Qemu-devel] [PATCH v1 4/6] kvm: we never have overlapping slots in kvm_set_phys_mem()

The way flatview handles memory sections, we will never have overlapping memory sections in kvm. address_space_update_topology_pass() will make sure that we will only get called for a) an existing memory section for which we only update parameters (log_start, log_stop). b) an existing memory

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

On 11 September 2017 at 19:13, Philippe Mathieu-Daudé wrote: > On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote: >> >> changed in 659ef5cbb893, this fixes building with >> --enable-tcg-interpreter: >> >> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: >>

[Qemu-devel] [PATCH v1 1/6] kvm: require JOIN_MEMORY_REGIONS_WORKS

We already require DESTROY_MEMORY_REGION_WORKS, JOIN_MEMORY_REGIONS_WORKS was added just half a year later. In addition, with flatview overlapping memory regions are first removed before adding the changed one. So we can't really detect joining memory regions this way. Let's just get rid of this

  1   2   3   4   5   >