On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote:
> On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote:
> > On Thu, Sep 14, 2017 at 01:15:09PM +0200, Marc-André Lureau wrote:
> > > There should be a limit in the number of requests the thread can
> > > queue. Before the patch, t
Richard Henderson writes:
> Signed-off-by: Richard Henderson
This breaks the mips cross build:
In file included from /tmp/qemu-test/src/tcg/tcg.c:254:0:
/tmp/qemu-test/src/tcg/mips/tcg-target.inc.c: In function
'target_parse_constraint':
/tmp/qemu-test/src/tcg/mips/tcg-target.inc.c:198:9: er
On 15/09/2017 11:06, Eduardo Otubo wrote:
> QEMU fails when used with the following command line:
>
> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion
> `!bus->dma[0] && !bus->dma[1]' failed.
> Abort
d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made
registering the s390 pci host bridge conditional on presense
of the zpci facility bit. Sadly, that breaks migration from
some old machines.
Create the s390 phb if we need it for compat reasons, even if
we don't provide the zpci facility.
While playing around with compat machines a bit, I noticed that my
zpci detanglement patches broke migration from 2.7 to current master
(2.8 or newer are fine, which is why I did not notice that before.)
qemu 2.7 seems to create a savevm that a s390-next (or master) build
without the s390 phb chok
If we switch between read-only and read-write, the permissions that
image format drivers need on bs->file change, too. Make sure to update
the permissions during bdrv_reopen().
Signed-off-by: Kevin Wolf
---
include/block/block.h | 1 +
block.c | 64
We will calculate the required new permissions in the prepare stage of a
reopen. Required permissions of children can be influenced by the
changes made to their parents, but parents are independent from their
children. This means that permissions need to be calculated top-down. In
order to achieve
In the context of bdrv_reopen(), we'll have to look at the state of the
graph as it will be after the reopen. This interface addition is in
preparation for the change.
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 7 +++
block.c | 19 ---
block/
When new permissions are calculated during bdrv_reopen(), they need to
be based on the state of the graph as it will be after the reopen has
completed, not on the current state of the involved nodes.
This patch makes bdrv_is_writable() optionally accept a BlockReopenQueue
from which the new flags
In the context of bdrv_reopen(), we'll have to look at the state of the
graph as it will be after the reopen. This interface addition is in
preparation for the change.
Signed-off-by: Kevin Wolf
---
block.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
qemu-io provides a 'reopen' command that allows switching from writable
to read-only access. We need to make sure that we don't try to keep
write permissions to a BlockBackend that becomes read-only, otherwise
things are going to fail.
command() already makes sure to request any additional permiss
bdrv_reopen() can switch nodes between read-only and read-write modes.
This has implications for the required permissions on their child nodes.
For example, a qcow2 node requests write permissions on bs->file only if
it is writable itself.
This means that during bdrv_reopen(), the permissions need
Hi Daniel,
At 09/15/2017 04:40 PM, Daniel P. Berrange wrote:
On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote:
In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table
for transfering NUMA configuration to the guest. So, the maximum memory in
SRAT can be used to dete
On Fri, 2017-09-15 at 10:07 +0800, Peter Xu wrote:
> On Thu, Sep 14, 2017 at 05:31:38PM -0300, Eduardo Habkost wrote:
> > On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote:
> > > On 14.09.2017 22:18, Mohammed Gamal wrote:
> > > > Starting the following command line causes a segfault
> > >
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH qemu v2 00/13] memory: Reduce memory use
Message-id: 20170915084030.40988-1-...@ozlabs.ru
Type: s
On 15/09/2017 10:40, Alexey Kardashevskiy wrote:
> +
> +static bool flatview_can_share(FlatView *old_view, FlatView *new_view)
> +{
> +MemoryRegion *old_root = memory_region_unalias_entire(old_view->root);
> +MemoryRegion *new_root = memory_region_unalias_entire(new_view->root);
> +
> +
(oups, forgot the v2 on Subject)
On Fri, Sep 15, 2017 at 11:06:43AM +0200, Eduardo Otubo wrote:
> QEMU fails when used with the following command line:
>
> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assert
On 17.07.2017 16:56, Pavel Butsykin wrote:
On 07.07.2017 17:21, Pavel Butsykin wrote:
We should guarantee that RAM will not be modified while VM has a stopped
state, otherwise it can lead to negative consequences during post-copy
migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RA
On 17.08.2017 12:15, Pavel Butsykin wrote:
This patch add shrinking of the image file for qcow2. As a result, this allows
us to reduce the virtual image size and free up space on the disk without
copying the image. Image can be fragmented and shrink is done by punching holes
in the image file.
#
* Fam Zheng (f...@redhat.com) wrote:
> On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote:
> > * Fam Zheng (f...@redhat.com) wrote:
> > > On Fri, 09/15 16:03, Peter Xu wrote:
> > > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote:
> > > > > bdrv_close_all() would abort() due to op blocker
The fix has apparently been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a703d3aef5991b72a5a45880e7491232b8032f09
... and has been released with QEMU v2.9 already.
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-13-f...@redhat.com>
---
tests/vm/README | 63 +
1 file changed, 63 insertions(+)
create mode 100644 tests/vm/README
diff --git a/tests/vm/README b/tests/vm/README
new file mode 1006
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-14-f...@redhat.com>
---
tests/docker/Makefile.include | 15 ++-
tests/docker/run | 8 +---
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
Reviewed-by: Kamil Rytarowski
Message-Id: <20170913030119.3957-9-f...@redhat.com>
---
tests/vm/netbsd | 42 ++
1 file changed, 42 insertions(+)
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-11-f...@redhat.com>
---
Makefile | 2 ++
configure | 2 +-
tests/vm/Makefile.include | 42 ++
3 files changed, 45 insertions(+), 1 deletion(-)
create mode 100644 t
On 15/09/2017 10:40, Alexey Kardashevskiy wrote:
> This renames some helper to reflect better what they do.
>
> This drops AS in address_space_update_flatview() as it is not used anymore
> and renames to flatview_render_new().
>
> Signed-off-by: Alexey Kardashevskiy
> ---
> include/exec/memory-
This is the common code to implement a "VM test" to
1) Download and initialize a pre-defined VM that has necessary
dependencies to build QEMU and SSH access.
2) Archive $SRC_PATH to a .tar file.
3) Boot the VM, and pass the source tar file to the guest.
4) SSH into the VM, untar the s
David Gibson writes:
> On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote:
>> David Gibson writes:
>>
>> >>
>> >> I thought, I am doing the same here for PowerNV, number of online cores
>> >> is equal to initial online vcpus / threads per core
>> >>
>> >>int boot_cores_nr =
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-10-f...@redhat.com>
---
tests/vm/openbsd | 43 +++
1 file changed, 43 insertions(+)
create mode 100755 tests/vm/
The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188:
tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 +0100)
are available in the git repository at:
git://github.com/famz/qemu.git tags/test-and-build-pull-request
for you to fetch changes up to
This adds a 32bit guest.
The official LTS cloud image is downloaded and initialized with
cloud-init.
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-7-f...@redhat.com>
---
tests/vm/ubuntu.i386 | 88
1 file changed, 88 insertions(+)
On 15/09/2017 10:40, Alexey Kardashevskiy wrote:
> -static void flatview_init(FlatView *view)
> +static FlatView *flatview_alloc(void)
> {
> +FlatView *view;
> +
> +view = g_new0(FlatView, 1);
> view->ref = 1;
> -view->ranges = NULL;
> -view->nr = 0;
> -view->nr_allocated
QEMU fails when used with the following command line:
./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0]
&& !bus->dma[1]' failed.
Aborted (core dumped)
The 40p machine type already creates
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Message-Id: <20170913030119.3957-12-f...@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36eeb42d19..42f5454311 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1891,6 +1891,7 @@ S
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-4-f...@redhat.com>
---
scripts/archive-source.sh | 33 +
1 file changed, 33 insertions(+)
create mode 100755 scripts/archive-source.sh
diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh
new
This will be used by setup test user ssh.
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-5-f...@redhat.com>
---
tests/keys/id_rsa | 27 +++
tests/keys/id_rsa.pub | 1 +
2 files changed, 28 insertions(+)
create mode 100644 tests/keys/id_rsa
create mode 10
This patch introduces the new argument
[,elevateprivileges=allow|deny|children] to the `-sandbox on'. It allows
or denies Qemu process to elevate its privileges by blacklisting all
set*uid|gid system calls. The 'children' option will let forks and
execves run unprivileged.
Signed-off-by: Eduardo O
On 15/09/2017 10:40, Alexey Kardashevskiy wrote:
> +/*
> + * FIXME: this is cut-n-paste from address_space_update_topology_pass,
> + * simplify it
> + */
> +iold = inew = 0;
> +while (iold < old_view->nr || inew < new_view->nr) {
> +if (iold < old_view->nr) {
> +
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
Message-Id: <20170913030119.3957-8-f...@redhat.com>
---
tests/vm/freebsd | 42 ++
1 file changed, 42 insertions(+)
create mode 100755 tests/vm/fr
This patch introduces the argument [,obsolete=allow] to the `-sandbox on'
option. It allows Qemu to run safely on old system that still relies on
old system calls.
Signed-off-by: Eduardo Otubo
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrange
---
include/sysemu/seccomp.h | 3 ++-
qemu-
On Wed, Sep 13, 2017 at 01:15:32PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote:
> > > * Peter Xu (pet...@redhat.com) wrote:
> > > > On Thu, Aug 24, 2017 at 08:27:14PM +0100, Dr. David Alan Gi
On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote:
> David Gibson writes:
>
> >>
> >> I thought, I am doing the same here for PowerNV, number of online cores
> >> is equal to initial online vcpus / threads per core
> >>
> >>int boot_cores_nr = smp_cpus / smp_threads;
> >>
>
This patch changes the default behavior of the seccomp filter from
whitelist to blacklist. By default now all system calls are allowed and
a small black list of definitely forbidden ones was created.
Signed-off-by: Eduardo Otubo
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrange
---
incl
* Fam Zheng (f...@redhat.com) wrote:
> On Fri, 09/15 16:03, Peter Xu wrote:
> > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote:
> > > bdrv_close_all() would abort() due to op blockers added by BMDS, clean
> > > up migration states when main loop quits to avoid that.
> > >
> > > Signed-o
The virtio-gpu-pci device is already in the display category, so the
virtio-gpu-device should be there, too.
Signed-off-by: Thomas Huth
---
hw/display/virtio-gpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f0761cf..cc9385d 100644
Most devices use at least one address space and every time a new address
space is added, flat views and dispatch trees are rebuild for all address
spaces. This is not a problem for a relatively small amount of devices but
even 50 virtio-pci devices use more than 8GB of RAM.
What happens that on ev
On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote:
> * Fam Zheng (f...@redhat.com) wrote:
> > On Fri, 09/15 16:03, Peter Xu wrote:
> > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote:
> > > > bdrv_close_all() would abort() due to op blockers added by BMDS, clean
> > > > up migration sta
This patch adds [,resourcecontrol=deny] to `-sandbox on' option. It
blacklists all process affinity and scheduler priority system calls to
avoid any bigger of the process.
Signed-off-by: Eduardo Otubo
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrange
---
include/sysemu/seccomp.h | 1 +
On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote:
> In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table
> for transfering NUMA configuration to the guest. So, the maximum memory in
> SRAT can be used to determine whether to use the swiotlb for IOMMU or not.
>
> How
On Fri, 15 Sep 2017 07:15:41 +0200
Thomas Huth wrote:
> On 14.09.2017 21:25, Greg Kurz wrote:
> > The following capabilities are VM specific:
> > - KVM_CAP_PPC_SMT_POSSIBLE
> > - KVM_CAP_PPC_HTAB_FD
>
> BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we
> either remove it or c
On 15.09.2017 10:43, Greg Kurz wrote:
> On Fri, 15 Sep 2017 07:15:41 +0200
> Thomas Huth wrote:
>
>> On 14.09.2017 21:25, Greg Kurz wrote:
>>> The following capabilities are VM specific:
>>> - KVM_CAP_PPC_SMT_POSSIBLE
>>> - KVM_CAP_PPC_HTAB_FD
>>
>> BTW, looks like kvmppc_has_cap_htab_fd() is d
As we are going to share FlatView's between AddressSpace's,
and AddressSpaceDispatch is a structure to perform quick lookup
in FlatView, this moves ASD to FlatView.
After previosly open coded ASD rendering, we can also remove
as->next_dispatch as the new FlatView pointer is stored
on a stack and s
This patch adds [,spawn=deny] argument to `-sandbox on' option. It
blacklists fork and execve system calls, avoiding Qemu to spawn new
threads or processes.
Signed-off-by: Eduardo Otubo
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrange
---
include/sysemu/seccomp.h | 1 +
qemu-options.h
FlatView's will be shared between AddressSpace's and subpage_t
and MemoryRegionSection cannot store AS anymore, hence this change.
In particular, for:
typedef struct subpage_t {
MemoryRegion iomem;
-AddressSpace *as;
+FlatView *fv;
hwaddr base;
uint16_t sub_section[];
} s
This was inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1481593
Previous spin:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01559.html
This patchset tries to reduce amount of memory used by FlatViews
and tries share as many FVs between address spaces as possible.
Changelog:
This allows sharing flat views between address spaces when the same root
memory region is used when creating a new address space.
This adds a global list of flat views and a list of attached address
spaces per a flat view. Each address space references a flat view.
Signed-off-by: Alexey Kardashev
This is not so mechanical change in order to move to shared FlatViews
so make it a separate patch. The first argument of
address_space_do_translate() will become a FlatView, however since
address_space_get_iotlb_entry() still wants AS, hence this change.
Signed-off-by: Alexey Kardashevskiy
---
e
Since FlatViews are shared now and ASes not, this gets rid of
address_space_init_shareable().
Signed-off-by: Alexey Kardashevskiy
---
Squash to the previous one? It is a separate patch to make review easier,
mostly.
---
include/exec/memory.h | 17 -
include/hw/arm/armv7m.h |
From: Fam Zheng
Like many other libraries, libseccomp cflags and libs should only apply
to the building of necessary objects. Do so in the usual way with the
help of per object variables.
Signed-off-by: Fam Zheng
Acked-by: Eduardo Otubo
---
Makefile.objs | 2 ++
configure | 6 --
2 fi
Signed-off-by: Alexey Kardashevskiy
---
include/exec/memory.h | 2 +-
hw/pci/pci.c | 3 ++-
memory.c | 30 --
3 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 7816e5d655..be8cc1
This adds a new switch to "info mtree" to print dispatch tree internals.
Signed-off-by: Alexey Kardashevskiy
---
Example:
aik@fstn1-p1:~$ echo "info mtree -f -d" | nc localhost 3
QEMU 2.9.94 monitor - type 'help' for more information
(qemu) info mtree -f -d
FlatView #0
AS "memory"
AS "cpu
The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into
staging (2017-09-14 16:33:02 +0100)
are available in the git repository at:
https://github.com/otubo/qemu.git tags/pull-seccom
This renames some helper to reflect better what they do.
This drops AS in address_space_update_flatview() as it is not used anymore
and renames to flatview_render_new().
Signed-off-by: Alexey Kardashevskiy
---
include/exec/memory-internal.h | 6 +++---
exec.c | 7 +++--
AS in ASD is only used to pass AS from mem_begin() to register_subpage()
to store it in MemoryRegionSection, we can do this directly now.
Signed-off-by: Alexey Kardashevskiy
---
exec.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/exec.c b/exec.c
index 6b021
We are going to share FlatView's between AddressSpace's and per-AS
memory listeners won't suite the purpose anymore so open code
the dispatch tree rendering.
Signed-off-by: Alexey Kardashevskiy
---
include/exec/memory-internal.h | 6 +++--
include/exec/memory.h | 1 -
exec.c
We store AddressSpaceDispatch* in FlatView anyway so there is no need
to carry it from mem_add() to register_subpage/register_multipage.
Signed-off-by: Alexey Kardashevskiy
---
exec.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/exec.c b/exec.c
index b5610
This moves a FlatView allocation and initialization to a helper.
While we are nere, replace g_new with g_new0 to not to bother if we add
new fields in the future.
Signed-off-by: Alexey Kardashevskiy
---
memory.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a
On Fri, Sep 15, 2017 at 10:18:49AM +0200, Thomas Huth wrote:
> On 15.09.2017 08:35, David Gibson wrote:
> > On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote:
> >> On 14.09.2017 21:25, Greg Kurz wrote:
> >>> The following capabilities are VM specific:
> >>> - KVM_CAP_PPC_SMT_POSSIBLE
> >>
On Fri, Sep 15, 2017 at 04:20:26PM +0800, Fam Zheng wrote:
[...]
> > > void qmp_migrate_set_cache_size(int64_t value, Error **errp)
> > > {
> > > MigrationState *s = migrate_get_current();
> > > diff --git a/vl.c b/vl.c
> > > index fb1f05b937..abbe61f40b 100644
> > > --- a/vl.c
> > > +++ b
In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table
for transfering NUMA configuration to the guest. So, the maximum memory in
SRAT can be used to determine whether to use the swiotlb for IOMMU or not.
However, if QEmu doesn't enable NUMA explicitly on CLI, The SRAT will
nev
David Gibson writes:
>>
>> I thought, I am doing the same here for PowerNV, number of online cores
>> is equal to initial online vcpus / threads per core
>>
>>int boot_cores_nr = smp_cpus / smp_threads;
>>
>> Only difference that I see in PowerNV is that we have multiple chips
>> (max 2, a
On Fri, 09/15 16:03, Peter Xu wrote:
> On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote:
> > bdrv_close_all() would abort() due to op blockers added by BMDS, clean
> > up migration states when main loop quits to avoid that.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > include/migration/
On 15.09.2017 08:35, David Gibson wrote:
> On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote:
>> On 14.09.2017 21:25, Greg Kurz wrote:
>>> The following capabilities are VM specific:
>>> - KVM_CAP_PPC_SMT_POSSIBLE
>>> - KVM_CAP_PPC_HTAB_FD
>>
>> BTW, looks like kvmppc_has_cap_htab_fd() is
On Thu, Sep 14, 2017 at 04:14:33PM +0200, Greg Kurz wrote:
> The script doesn't know about all possible types and learn them as
> it parses the code. If it reaches a line with a type cast but the
> type isn't known yet, it is misinterpreted as an identifier.
>
> For example the following line:
>
On Thu, Sep 14, 2017 at 09:25:43PM +0200, Greg Kurz wrote:
> The following capabilities are VM specific:
> - KVM_CAP_PPC_SMT_POSSIBLE
> - KVM_CAP_PPC_HTAB_FD
> - KVM_CAP_PPC_ALLOC_HTAB
>
> If both KVM HV and KVM PR are present, checking them always return
> the HV value, even if we explicitely req
On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote:
> On 14.09.2017 21:25, Greg Kurz wrote:
> > The following capabilities are VM specific:
> > - KVM_CAP_PPC_SMT_POSSIBLE
> > - KVM_CAP_PPC_HTAB_FD
>
> BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we
> either remove it o
On Thu, Sep 14, 2017 at 10:42:52AM +0530, Nikunj A Dadhania wrote:
> David Gibson writes:
>
> > On Mon, Sep 11, 2017 at 10:40:10AM +0530, Nikunj A Dadhania wrote:
> >> David Gibson writes:
> >>
> >> > On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote:
> >> >> When the user does
On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote:
> bdrv_close_all() would abort() due to op blockers added by BMDS, clean
> up migration states when main loop quits to avoid that.
>
> Signed-off-by: Fam Zheng
> ---
> include/migration/misc.h | 1 +
> migration/migration.c| 7 ++
From: Eric Blake
Prior to commit 063c23d9, we were tracking a list of parallel
qtest objects, in order to safely clean up a SIGABRT handler
only after the last connection quits. But when we switched to
more of glib's infrastructure, the list became dead code that
is never assigned to.
Signed-of
From: Eric Blake
hmp() passes its string argument through the sprintf() family;
with a proper attribute, gcc -Wformat warns us when we do something
dangerous like passing a non-constant format string. Fortunately,
all our strings were safe, but checking whether the string can
contain an unintend
On 14/09/2017 11:12, Greg Kurz wrote:
> The script doesn't know about all possible types and learn them as
> it parses the code. If it reaches a line with a type cast but the
> type isn't known yet, it is misinterpreted as an identifier.
>
> For example the following line:
>
> foo = (hwaddr)
From: Eric Blake
Don't open-code something that has a convenient helper available.
Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/numa-test.c | 21 +++--
1 file chang
From: Eric Blake
Back when the test was introduced, in commit 62c39b307, the
test was set up to run qemu-ga directly on the host performing
the test, and defaults to limiting itself to safe commands. At
the time, it was envisioned that setting QGA_TEST_SIDE_EFFECTING
in the environment could cov
The user can currently still cause an abort() if running certain tests
(like the prom-env-test) without setting the QTEST_QEMU_BINARY first.
A similar problem has been fixed with commit 7c933ad61b8f3f51337
already, but forgot to also take care of the qtest_get_arch() function,
so let's introduce a
From: Eric Blake
Assertions should be separate from the side effects, since in
theory, g_assert() can be disabled (in practice, we can't really
ever do that).
Signed-off-by: Eric Blake
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
qtest.c | 82 ++
Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take
opaque BAR handle") a while ago, but nobody noticed since the tests are
not run by default: The msix_pba_bar is not correctly initialized
anymore if bir_pba has the same value as bir_table. With this fix,
"make check SPEED=slow
The problem with puv3 has been fixed with 0ac241bcf9f9d99a252a352a162f
('unicore32: abort when entering "x 0" on the monitor') and the problem
with tricore_testboard has been fixed with b190f477e29c7cd03a8fee49c96d
('qemu-system-tricore: segfault when entering "x 0" on the monitor').
Reviewed-by:
The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into
staging (2017-09-14 16:33:02 +0100)
are available in the git repository at:
git://github.com/huth/qemu.git tags/check-2017091
A lot of tests provide code for adding and removing a device via the
device_add and device_del QMP commands. Maintaining this code in so many
places is cumbersome and error-prone (some of the code parts check the
responses for device deletion in an incorrect way, for example, we've got
to deal with
On Fri, Sep 15, 2017 at 03:02:32PM +0800, Fam Zheng wrote:
> On Fri, 09/15 14:56, Peter Xu wrote:
> > On Fri, Sep 15, 2017 at 02:49:07PM +0800, Fam Zheng wrote:
> > > On Fri, 09/15 14:41, Peter Xu wrote:
> > > > On Fri, Sep 15, 2017 at 01:44:02PM +0800, Fam Zheng wrote:
> > > > > So that we can do
On Thu, Sep 14, 2017 at 20:48:49 +0800, Paul Schlacter wrote:
> this is my stackoverflow question:
> https://stackoverflow.com/questions/46219552/host-doesnt-support-requested-feature-cpuid-01hedx-ds-bit-21-does-this-warn
>
>
> I found a lot of warning from the VM qemu log, Does this warn affect
On 15/09/2017 09:30, Auger Eric wrote:
> Hi Tomasz,
>
> On 14/09/2017 16:43, Tomasz Nowicki wrote:
>> On 14.09.2017 16:31, Tomasz Nowicki wrote:
>>> Hi Eric,
>>>
>>> On 14.09.2017 11:27, Linu Cherian wrote:
Hi Eric,
On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote:
>
On 14.09.2017 17:55, Farhan Ali wrote:
> Wire up the virtio-gpu device for the CCW bus. The virtio-gpu
> is a virtio-1 device, so disable revision 0.
>
> Signed-off-by: Farhan Ali
> Acked-by: Christian Borntraeger
> Reviewed-by: Halil Pasic
> ---
> hw/s390x/virtio-ccw.c | 49 ++
On Thu, 14 Sep 2017 20:13:49 +0200
David Hildenbrand wrote:
> FWIW, I started factoring out today KVM SIGP code to make it usable by TCG.
>
> I also started adding the missing SIGP instructions the kernel handles
> for KVM. I dropped the old TCG SIGP handling code and completely reuse
> the new
Hi,
> +static void
> +virtio_gpu_ctrl_hdr_bswap_cpu(struct virtio_gpu_ctrl_hdr *hdr)
> +{
> +hdr->type = le32_to_cpu(hdr->type);
> +hdr->flags = le32_to_cpu(hdr->flags);
> +hdr->fence_id = le64_to_cpu(hdr->fence_id);
> +hdr->ctx_id = le32_to_cpu(hdr->ctx_id);
> +hdr->padding
Hi Tomasz,
On 14/09/2017 16:43, Tomasz Nowicki wrote:
> On 14.09.2017 16:31, Tomasz Nowicki wrote:
>> Hi Eric,
>>
>> On 14.09.2017 11:27, Linu Cherian wrote:
>>> Hi Eric,
>>>
>>> On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote:
memory_region_iommu_replay() is used for VFIO integrati
On Thu, 14 Sep 2017 18:50:29 +0200
Halil Pasic wrote:
> On 09/14/2017 04:26 PM, Cornelia Huck wrote:
> > On Wed, 13 Sep 2017 15:27:51 +0200
> > Halil Pasic wrote:
> >> +static Property ccw_tester_properties[] = {
> >> +DEFINE_PROP_UINT16("cu_type", CcwTesterDevice, cu_type,
> >> +
Le 15/09/2017 à 08:58, James Clarke a écrit :
> Fixes: https://bugs.launchpad.net/qemu/+bug/1716767
> Signed-off-by: James Clarke
> ---
> linux-user/syscall.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9b6364a266..24
Hi Linu,
On 14/09/2017 11:27, Linu Cherian wrote:
> Hi Eric,
>
> On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote:
>> memory_region_iommu_replay() is used for VFIO integration.
>>
>> However its default implementation is not adapted to SMMUv3
>> IOMMU memory region. Indeed the input addr
On 15/09/2017 02:21, Michael Roth wrote:
> Quoting Paolo Bonzini (2017-08-22 08:20:23)
>> On 19/08/2017 00:55, Laszlo Ersek wrote:
>>> Reported-by: Laszlo Ersek
>>> Fixes: ded6ddc5a7b95217557fa360913d1213e12d4a6d
>>
>> And also:
>>
>> Cc: qemu-sta...@nongnu.org
>
> FYI patch freeze for v2.10.1 is
201 - 300 of 303 matches
Mail list logo
