Re: [Qemu-devel] What is the best commit for record-replay?

2017-10-31 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Aleksandr Bezzubikov writes: > >> > >> > 2017-09-19 12:30 GMT+03:00 Alex Bennée : > >> >> >

Re: [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue

2017-10-31 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue Type: series Message-id:

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-10-31 Thread Dan Williams
On Tue, Oct 31, 2017 at 8:43 PM, Xiao Guangrong wrote: > > > On 10/31/2017 10:20 PM, Dan Williams wrote: >> >> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong >> wrote: >>> >>> >>> >>> On 07/27/2017 08:54 AM, Dan Williams wrote: >>>

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-10-31 Thread Xiao Guangrong
On 10/31/2017 10:20 PM, Dan Williams wrote: On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong wrote: On 07/27/2017 08:54 AM, Dan Williams wrote: At that point, would it make sense to expose these special virtio-pmem areas to the guest in a slightly different

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 18:51, Stefano Stabellini > wrote: > > On Tue, 31 Oct 2017, Peter Maydell wrote: > >> On 31 October 2017 at 17:01, Stefano Stabellini > >> wrote: > >> > Fixing QEMU is harder than

Re: [Qemu-devel] [RFC PATCH 00/26] replay additions

2017-10-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 00/26] replay additions Type: series Message-id: 20171031112457.10516.8971.stgit@pasha-VirtualBox === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PULL 1/2] hw/ide/ahci: Move allwinner code into a separate file

2017-10-31 Thread John Snow
From: Thomas Huth The allwinner code is only needed for the allwinner board (for which we also have a separate CONFIG_ALLWINNER_A10 config switch), so it does not make sense that we compile this for all the other boards that need AHCI, too. Let's move it to a separate file that

[Qemu-devel] [PULL 2/2] ide: avoid referencing NULL dev in rotational rate setting

2017-10-31 Thread John Snow
From: "Daniel P. Berrange" The 'dev' variable can be NULL when the guest OS calls identify on an IDE unit that does not have a drive attached to it. Signed-off-by: Daniel P. Berrange Reviewed-by: Stefan Hajnoczi Message-id:

[Qemu-devel] [PULL 0/2] Ide patches

2017-10-31 Thread John Snow
The following changes since commit 7fa00e204902cee0b33a0c60de87e87319d1809f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20171031' into staging (2017-10-31 14:28:25 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-31 Thread dann frazier
Thanks Christian - I've now verified this. I took a stepwise approach: 1) We originally observed this issue w/ the ocata cloud archive on xenial, so I redeployed that. I verified that I was still seeing the problem. I then created a PPA[*] w/ an arm64 build of QEMU from the ocata-staging PPA,

[Qemu-devel] [PATCH v4] arm: implement cache/shareability attribute bits for PAR registers

2017-10-31 Thread Andrew Baumann via Qemu-devel
On a successful address translation instruction, PAR is supposed to contain cacheability and shareability attributes determined by the translation. We previously returned 0 for these bits (in line with the general strategy of ignoring caches and memory attributes), but some guest OSes may depend

[Qemu-devel] [PATCH v2 4/4] tests/rtas-test.c: fix Apple endian.h include

2017-10-31 Thread Daniel Henrique Barboza
Recent rtas-test.c changes added a call to 'be32toh', a function from the header 'endian.h' in Linux. This caused QEMU Travis build to break because be32toh is undefined in Mac OS (even using the machine/endian.h header). This patch makes a conditional code to include the proper header file if

[Qemu-devel] [PATCH v2 3/4] tests: ibm, configure-connector RTAS call implementation

2017-10-31 Thread Daniel Henrique Barboza
'ibm,configure-connector' hypercall is used by the guest OS to start the configuration of a given device, where the machine configures the said device and all its sub-devices, giving back FDTs to the caller for each sub-device. This hypercall is supposed to be called multiple times by the guest

[Qemu-devel] [PATCH v2 1/4] tests: adding 'check_exception' RTAS implementation

2017-10-31 Thread Daniel Henrique Barboza
In the sPAPR guest, events such as device hotplug/unplug are retrieved by the check_exception RTAS call after the guest receives an IRQ pulse. For both hotplug and unplug operations, guest intervention is required to transit the DRC state of the attached device to the configured state. Without

[Qemu-devel] [PATCH v2 0/4] ppc: adding some RTAS calls in tests/libqos

2017-10-31 Thread Daniel Henrique Barboza
v2: - added a new patch to fix a Travis build issue with Mac OS This series implements a few RTAS hypercalls in tests/libqos that, used together, implement the DRC state transition described in PAPR 2.7+, 13.4. This started as an attempt of implementing hot unplug qtests for the sPAPR machine

[Qemu-devel] [PATCH v2 2/4] tests: adding 'set_indicator' RTAS call

2017-10-31 Thread Daniel Henrique Barboza
'set_indicator' is a RTAS hypercall that is used to change the state of both physical and logical devices DRCs by setting allocation-state, isolation-state and dr-indicator. This patch implements the set_indicator RTAS call in tests/libqos/rtas.c, adding its test in tests/rtas-test.c.

Re: [Qemu-devel] Block format 'raw' does not support the option 'locking' when disable image locking with option locking=off

2017-10-31 Thread John Snow
On 10/26/2017 03:18 AM, Changlimin wrote: > If the qcow2 file is created with preallocation=full, I think metadata will > not corrupt when it is shared between two vms? Snapshot is not required. > > Is this right? > You can only share images read-only in this way. If you are asking to share

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 18:51, Stefano Stabellini wrote: > On Tue, 31 Oct 2017, Peter Maydell wrote: >> On 31 October 2017 at 17:01, Stefano Stabellini >> wrote: >> > Fixing QEMU is harder than I expected. Would it be possible to update >> >

Re: [Qemu-devel] [RFC v2 10/33] migration: allow dst vm pause on postcopy

2017-10-31 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Oct 10, 2017 at 05:38:01PM +0800, Peter Xu wrote: > > [...] > > > > > But I agree about the reasoning. How > > > > about one more patch to postpone the "active" to "postcopy-active" > > > > state change after the package is handled correctly?

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 17:01, Stefano Stabellini > wrote: > > Fixing QEMU is harder than I expected. Would it be possible to update > > id_aa64pfr0 at CPU reset time? Like cpu->id_aa64pfr0 |= 0x0100; ? > > At that point

Re: [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

2017-10-31 Thread Anatol Pomozov
Hi On Thu, Oct 19, 2017 at 2:36 AM, Kevin Wolf wrote: > Am 18.10.2017 um 19:22 hat Anatol Pomozov geschrieben: >> Hello qemu-devs, >> >> This patchset has been posted a while ago. I would like to move >> forward with it and look at the next task (e.g. multiboot2 support in >>

[Qemu-devel] we allow passing -machine type=foo more than once but are confused about which to use...

2017-10-31 Thread Peter Maydell
(cc Markus because I know how much he likes weirdnesses in our command line parsing :-)) https://stackoverflow.com/questions/46955244/qemu-run-arm-ubuntu-unsupported-machine-type/47042282 has a user who's run into a confusing error message, because we allow the user to pass "-machine type=foo"

[Qemu-devel] [Bug 1719196] Please test proposed package

2017-10-31 Thread Corey Bryant
Hello Sean, or anyone else affected, Accepted qemu into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 18:08, Stefano Stabellini wrote: > On Tue, 31 Oct 2017, Peter Maydell wrote: >> On 31 October 2017 at 17:07, Stefano Stabellini >> wrote: >> > Sorry Peter, I copy/pasted the values from arm32/page.h instead of >> >

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 17:07, Stefano Stabellini > wrote: > > Sorry Peter, I copy/pasted the values from arm32/page.h instead of > > arm64/page.h in Xen :-/ > > > > Xen is running at EL2, 64-bit (aarch64). The ATS instruction is

[Qemu-devel] [PULL] qemu-sparc update

2017-10-31 Thread Mark Cave-Ayland
: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20171031' into staging (2017-10-31 14:28:25 +) are available in the git repository at: https://github.com/mcayland/qemu.git tags/qemu-sparc-signed for you to fetch changes up to badd3d62c619d24a5af62198374f42b7c510ee41

Re: [Qemu-devel] [PATCH 2/2] Add i82559a eepro100 interface

2017-10-31 Thread Dr. David Alan Gilbert
* Mike Nawrocki (michael.nawro...@gtri.gatech.edu) wrote: > Signed-off-by: Mike Nawrocki > --- > hw/net/eepro100.c| 2 +- > hw/pci/pci.c | 2 ++ > include/hw/pci/pci.h | 1 + > qemu-options.hx | 2 +- > 4 files changed, 5 insertions(+), 2

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 17:07, Stefano Stabellini wrote: > Sorry Peter, I copy/pasted the values from arm32/page.h instead of > arm64/page.h in Xen :-/ > > Xen is running at EL2, 64-bit (aarch64). The ATS instruction is "at > s1e2r", used to translate Xen virtual addresses

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 17:01, Stefano Stabellini wrote: > Fixing QEMU is harder than I expected. Would it be possible to update > id_aa64pfr0 at CPU reset time? Like cpu->id_aa64pfr0 |= 0x0100; ? At that point we've already called register_cp_regs_for_features(), which

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 30 October 2017 at 22:57, Stefano Stabellini > wrote: > > On Mon, 30 Oct 2017, Peter Maydell wrote: > >> What's the specific situation/bug that you're trying to fix with > >> this patch? You don't say in the commit message. >

Re: [Qemu-devel] [PATCH v3 5/5] RFC: fw_cfg: add DMA write operation in sysfs

2017-10-31 Thread Michael S. Tsirkin
On Tue, Oct 31, 2017 at 09:55:39AM +, Hatayama, Daisuke wrote: > > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Michael S. Tsirkin > > Sent: Tuesday, October 31, 2017 1:19 AM > > To: Hatayama, Daisuke

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 19 October 2017 at 15:46, Peter Maydell wrote: > > On 18 October 2017 at 01:10, Stefano Stabellini > > wrote: > >> Advertise the presence of the GIC system register interface (1<<24) > >> according

Re: [Qemu-devel] [PATCH 0/2] Add 8-byte wide AMD flash support, partial interleaving

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 15:44, Mike Nawrocki wrote: > This patch set does a few things. First, it switches the AMD CFI flash MMIO > operations from the old MMIO API to the new one. Second, it enables 8-byte > wide flash arrays. Finally, it supports rudimentary

Re: [Qemu-devel] [PATCH] io: Fix QIOChannelFile when creating and opening read-write

2017-10-31 Thread Marc-André Lureau
Hi (adding the maintainer in cc, scripts/get_maintainer.pl -f io/channel-file.c) On Tue, Oct 31, 2017 at 5:09 PM, Ross Lagerwall wrote: > The code wrongly passes the mode to open() only if O_WRONLY is set. > Instead, the mode should be passed when O_CREAT is set (or

Re: [Qemu-devel] unfaithful emulation of system calls

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 16:18, John Reiser wrote: > On real Linux on PowerPC64, a system call trashes registers {r0, r4-r12, > ctr}; > qemu-ppc64 preserves them. [Both preserve: r13-r31, r1 (sp), r2 (TOC), r3 > (set to > return value), lr (link register).] Looking at the

[Qemu-devel] [Bug 1318091] Re: Perfctr MSRs not available to Guest OS on AMD Phenom II

2017-10-31 Thread Barret
Hi - I don't have the hardware readily available anymore, so I can't test it. Might as well close the bug. Regarding Oliver's question, it doesn't sound like the same issue I had. I do recall that processor and qemu not supporting rdtscp (which is fine), so that problem might be some qemu

Re: [Qemu-devel] [PATCH] Make scrolling work again

2017-10-31 Thread Peter Maydell
On 5 October 2017 at 19:43, John Arbuckle wrote: > Make scrolling in the monitor work. > > Signed-off-by: John Arbuckle Sorry this took me a while to get to reviewing. > --- > ui/cocoa.m | 88 >

[Qemu-devel] unfaithful emulation of system calls

2017-10-31 Thread John Reiser
I was surprised that my user-mode applications ran successfully under qemu-ppc64 2.10.1 running on Linux on x86_64, but crashed when run directly under Linux on 64-bit PowerPC. Investigation showed that qemu-ppc64 does not emulate system calls faithfully. On real Linux on PowerPC64, a system

Re: [Qemu-devel] [PATCH v2 1/1] virtio_balloon: include buffers and cached memory statistics

2017-10-31 Thread Michael S. Tsirkin
On Tue, Oct 31, 2017 at 01:20:19PM +0100, Tomáš Golembiovský wrote: > ping > > +Gil, +Amnon... could you maybe aid in reviewing the patch, please? > > > Tomas > > On Sun, 22 Oct 2017 20:05:57 +0200 > Tomáš Golembiovský wrote: > > > On Thu, 19 Oct 2017 16:12:20 +0300

[Qemu-devel] [PATCH] io: Fix QIOChannelFile when creating and opening read-write

2017-10-31 Thread Ross Lagerwall
The code wrongly passes the mode to open() only if O_WRONLY is set. Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on Linux). Fix this by always passing the mode since open() will correctly ignore the mode if it is not needed. Add a testcase which exercises this bug. While

Re: [Qemu-devel] [RFC PATCH] vl: only display available accelerators

2017-10-31 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [RFC PATCH] vl: only display available accelerators Type: series Message-id:

[Qemu-devel] [PATCH 2/2] Add i82559a eepro100 interface

2017-10-31 Thread Mike Nawrocki
Signed-off-by: Mike Nawrocki --- hw/net/eepro100.c| 2 +- hw/pci/pci.c | 2 ++ include/hw/pci/pci.h | 1 + qemu-options.hx | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index

[Qemu-devel] [PATCH 1/2] Fix eepro100 simple transmission mode

2017-10-31 Thread Mike Nawrocki
The simple transmission mode was treating the area immediately after the transmit command block (TCB) as if it were a transmit buffer descriptor, when in reality it is simply the packet data. This change simply copies the data following the TCB into the packet buffer. Signed-off-by: Mike Nawrocki

[Qemu-devel] [PATCH 0/2] Fix eepro100 simple transmission, add i82559 chipset

2017-10-31 Thread Mike Nawrocki
This patch set does two things. First, it fixes the simple transmission mode for the eepro100 chipset. Second, it adds and uses the PCI ID for the i82559 chipset, and enables selection of this chipset. Mike Nawrocki (2): Fix eepro100 simple transmission mode Add i82559a eepro100 interface

[Qemu-devel] [PATCH 1/2] Add 8-byte access to AMD CFI devices

2017-10-31 Thread Mike Nawrocki
This adds 8-byte wide access support to AMD CFI flash devices. Additionally, it migrates the MMIO operations from old_mmio to the new API. Signed-off-by: Mike Nawrocki --- hw/block/pflash_cfi02.c | 172 +++- 1 file

[Qemu-devel] [PATCH 2/2] Add support for flash interleaving of AMD chips

2017-10-31 Thread Mike Nawrocki
Flash interleaving is partially supported using the new interleave_num parameter, which indicates how many "devices" comprise the flash array. The supported flash access pattern is one where commands are sent to all devices simultaneously and the read result is duplicated according to the

[Qemu-devel] [PATCH 0/2] Add 8-byte wide AMD flash support, partial interleaving

2017-10-31 Thread Mike Nawrocki
This patch set does a few things. First, it switches the AMD CFI flash MMIO operations from the old MMIO API to the new one. Second, it enables 8-byte wide flash arrays. Finally, it supports rudimentary interleaving of notional flash "chips". It is expected that commands will be sent to all

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2017-10-31 Thread Peter Maydell
0x-20171030' into > staging (2017-10-30 13:02:45 +) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20171031 > > for you to fetch changes up to 168df2dea701bbf3118bdfea7794369dfa694d3d: > > hw/pc

[Qemu-devel] [PATCH] Enable 8-byte wide MMIO for 16550 serial devices

2017-10-31 Thread Mike Nawrocki
Some drivers for the PPMC7400 PowerPC evaluation board accesses the serial registers through the floating point unit (stfd/ldfd), which is an 8-byte wide access. This patch enables that behavior. Signed-off-by: Mike Nawrocki --- hw/char/serial.c | 8 +++- 1

[Qemu-devel] [PATCH v4 5/5] fw_cfg: write vmcoreinfo details

2017-10-31 Thread Marc-André Lureau
If the "etc/vmcoreinfo" fw_cfg file is present and we are not running the kdump kernel, write the addr/size of the vmcoreinfo ELF note. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 87 +- 1 file

[Qemu-devel] [PATCH v4 4/5] crash: export paddr_vmcoreinfo_note()

2017-10-31 Thread Marc-André Lureau
The following patch is going to use the symbol from the fw_cfg module. Signed-off-by: Marc-André Lureau --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 6db80fc0810b..47541c891810 100644 ---

[Qemu-devel] [PATCH v4 2/5] fw_cfg: add DMA register

2017-10-31 Thread Marc-André Lureau
Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v4 3/5] fw_cfg: do DMA read operation

2017-10-31 Thread Marc-André Lureau
Modify fw_cfg_read_blob() to use DMA if the device supports it. Return errors, because the operation may fail. To avoid polling with unbound amount of time, the DMA operation is expected to complete within 200ms, or will return ETIME error. We may want to switch all the *buf addresses to use

[Qemu-devel] [PATCH v4 1/5] fw_cfg: fix the command line module name

2017-10-31 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 0e2011636fbb..5cfe39f7a45f 100644 ---

[Qemu-devel] [PATCH v4 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support

2017-10-31 Thread Marc-André Lureau
Hi, This series adds DMA operations support to the qemu fw_cfg kernel module and populates "etc/vmcoreinfo" with vmcoreinfo location details. Note: the support for this entry handling has been merged for next qemu release (2.11) v4: - export paddr_vmcoreinfo_note() to fix fw_cfg.ko build - fix

[Qemu-devel] [RISU PATCH 0/7] Add @Group support and some aarch64.risu cleanups

2017-10-31 Thread Alex Bennée
Hi Peter, My RISU patch queue was running a little long so I thought I should push up stuff that was ready. The first few patches are simply clean-ups to the aarch64.risu file, mostly removing duplicate blocks that have crept in. There is a prerequisite clean-up patch which moves the filtering

[Qemu-devel] [RISU PATCH 7/7] aarch64.risu: clean-up and annotate with groups

2017-10-31 Thread Alex Bennée
Clean-up the risu definitions by: - removing out-dated section numbers - fixing section titles to match ASL encoding groups - add @Section markers Signed-off-by: Alex Bennée --- aarch64.risu | 200 +-- 1 file

[Qemu-devel] [RISU PATCH 1/7] aarch64.risu: document naming conventions

2017-10-31 Thread Alex Bennée
Signed-off-by: Alex Bennée --- aarch64.risu | 8 1 file changed, 8 insertions(+) diff --git a/aarch64.risu b/aarch64.risu index 2f3341c..5e7ec59 100644 --- a/aarch64.risu +++ b/aarch64.risu @@ -19,6 +19,14 @@ # XXX NIY: SP-related instructions # XXX NIY:

[Qemu-devel] [RISU PATCH 2/7] aarch64.risu: remove duplicate AdvSIMD Scalar 3 same block

2017-10-31 Thread Alex Bennée
A chunk of the AArch64 definitions repeat themselves. Clean that up. Signed-off-by: Alex Bennée --- aarch64.risu | 22 -- 1 file changed, 22 deletions(-) diff --git a/aarch64.risu b/aarch64.risu index 5e7ec59..c9f24cd 100644 --- a/aarch64.risu +++

[Qemu-devel] [RISU PATCH 5/7] risugen/risugen_$arch: factor out instruction selection

2017-10-31 Thread Alex Bennée
This moves the instruction selection to the common code and passes a list of selection keys to write_test_code instead. This will allow us to add selection features to the common code later. Signed-off-by: Alex Bennée --- risugen | 29

[Qemu-devel] [RISU PATCH 3/7] aarch64.risu: remove duplicate AdvSIMD scalar 2 reg misc block

2017-10-31 Thread Alex Bennée
While at that also sort alphabetically and nicely align for eye-balling the patterns. Signed-off-by: Alex Bennée --- aarch64.risu | 110 +++ 1 file changed, 35 insertions(+), 75 deletions(-) diff --git

[Qemu-devel] [RISU PATCH 6/7] risugen: support @GroupName in risu files

2017-10-31 Thread Alex Bennée
The existing pattern support is useful but it does get a little tedious when faced with large groups of instructions. This introduces the concept of a @GroupName which can be sprinkled in the risu definition and is attached to all instructions following its definition until the next group or an

[Qemu-devel] [RISU PATCH 4/7] aarch64.risu: update AdvancedSIMD across lanes

2017-10-31 Thread Alex Bennée
- sorted alphabetically - aligned the instructions patterns Signed-off-by: Alex Bennée --- aarch64.risu | 81 ++-- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/aarch64.risu b/aarch64.risu index

Re: [Qemu-devel] [PATCH v2 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 14:38, Peter Maydell wrote: > On 5 October 2017 at 15:55, John Arbuckle wrote: >> Send control-alt key combinations to the guest if not used by the user >> interface. >> >> --- >> v2 changes: >> - changed logic to use

Re: [Qemu-devel] [PATCH v2 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-10-31 Thread Peter Maydell
On 5 October 2017 at 15:55, John Arbuckle wrote: > Send control-alt key combinations to the guest if not used by the user > interface. > > --- > v2 changes: > - changed logic to use existing if case > This patch is missing your signed-off-by line, can you provide it,

Re: [Qemu-devel] 'make help' generate unrelated files

2017-10-31 Thread Philippe Mathieu-Daudé
On 07/29/2017 06:30 AM, Peter Maydell wrote: > This happens because we have a rule that says > "Makefile: $(GENERATED_FILES)" > which is how we ensure that the autogenerated header > files are always built before any .c file is compiled. > The unfortunate side effect is that we rebuild the >

Re: [Qemu-devel] [PULL 00/12] NBD patches prior to 2.11 soft freeze

2017-10-31 Thread Peter Maydell
On 30 October 2017 at 20:56, Eric Blake wrote: > The following changes since commit abf6e752e55b2f5afb48303429dea2db7c3a62de: > > Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20171030' into > staging (2017-10-30 13:02:45 +) > > are available in the git

Re: [Qemu-devel] What is the best commit for record-replay?

2017-10-31 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Aleksandr Bezzubikov writes: >> >> > 2017-09-19 12:30 GMT+03:00 Alex Bennée : >> >> >> >>> As I know, RR is still broken in the current version. >>

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-10-31 Thread Dan Williams
On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong wrote: > > > On 07/27/2017 08:54 AM, Dan Williams wrote: > >>> At that point, would it make sense to expose these special >>> virtio-pmem areas to the guest in a slightly different way, >>> so the regions that need

Re: [Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

2017-10-31 Thread Igor Mammedov
On Thu, 19 Oct 2017 17:31:51 +1100 David Gibson wrote: > On Wed, Oct 18, 2017 at 01:12:12PM +0200, Igor Mammedov wrote: > > For enabling early cpu to numa node configuration at runtime > > qmp_query_hotpluggable_cpus() should provide a list of available > > cpu slots

Re: [Qemu-devel] [PATCH v6 15/25] block: Use bdrv_dirname() for relative filenames

2017-10-31 Thread Alberto Garcia
On Fri 29 Sep 2017 06:53:37 PM CEST, Max Reitz wrote: > bdrv_get_full_backing_filename_from_filename() breaks down when it comes > to JSON filenames. Using bdrv_dirname() as the basis is better because > since we have BDS, we can descend through the BDS tree to the protocol > layer, which gives us

Re: [Qemu-devel] [PATCH] docker: add python stdlib dependency (required by keycodemapdb)

2017-10-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since 927128222b0a QEMU depends of keycodemapdb, which uses the python 'csv' > module from stdlib to parse keymaps.csv. > > Without this package the build fails: > > GEN ui/input-keymap-linux-to-qcode.c > Traceback (most recent call

Re: [Qemu-devel] [PATCH v3] arm: implement cache/shareability attribute bits for PAR registers

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 13:02, Andrew Baumann wrote: > On a successful address translation instruction, PAR is supposed to > contain cacheability and shareability attributes determined by the > translation. We previously returned 0 for these bits (in line with the >

[Qemu-devel] [PULL 2/5] xlnx-zcu102: Specify the max number of CPUs

2017-10-31 Thread Peter Maydell
From: Alistair Francis Specify the number of CPUs that can run on ZynqMP. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Peter

[Qemu-devel] [PULL 1/5] fix WFI/WFE length in syndrome register

2017-10-31 Thread Peter Maydell
From: Stefano Stabellini WFI/E are often, but not always, 4 bytes long. When they are, we need to set ARM_EL_IL_SHIFT in the syndrome register. Pass the instruction length to HELPER(wfi), use it to decrement pc appropriately and to pass an is_16bit flag to syn_wfx, which

Re: [Qemu-devel] [PATCH v2 3/4] fw_cfg: write vmcoreinfo details

2017-10-31 Thread Marc-André Lureau
On Mon, Oct 30, 2017 at 10:44 AM, Hatayama, Daisuke < d.hatay...@jp.fujitsu.com> wrote: > Resend because the mail address for LKML was wrong in the previous mail... > > Marc-Andre, > > Sorry, I missed your original mails from my local data, so I'm replying > this mail as a new thread... > > >

[Qemu-devel] [PULL 0/5] target-arm queue

2017-10-31 Thread Peter Maydell
ull-target-arm-20171031 for you to fetch changes up to 168df2dea701bbf3118bdfea7794369dfa694d3d: hw/pci-host/gpex: Improve INTX to gsi routing error checking (2017-10-31 11:50:52 +) target-arm queue: * fix instruction-

Re: [Qemu-devel] [PULL 0/2] hmp queue

2017-10-31 Thread Peter Maydell
On 30 October 2017 at 20:23, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit abf6e752e55b2f5afb48303429dea2db7c3a62de: > > Merge remote-tracking branch

[Qemu-devel] [PULL 4/5] msf2: Wire up SYSRESETREQ in SoC for system reset

2017-10-31 Thread Peter Maydell
From: Subbaraya Sundeep Implemented system reset by creating SYSRESETREQ gpio out from nvic. Signed-off-by: Subbaraya Sundeep Message-id: 1509253165-7434-1-git-send-email-sundeep.l...@gmail.com Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 3/5] msf2: Remove dead code reported by Coverity

2017-10-31 Thread Peter Maydell
From: Subbaraya Sundeep Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep Reviewed-by: Darren Kenny Reviewed-by: Alistair Francis

[Qemu-devel] [PULL 5/5] hw/pci-host/gpex: Improve INTX to gsi routing error checking

2017-10-31 Thread Peter Maydell
From: Eric Auger We exposed gpex_set_irq_num() for machines to set the INTx to GSI routing. However if the machine forgets to call that function we currently do not check the association was properly done. Let's initialize gsi values to -1 and if this value is found in

Re: [Qemu-devel] [PATCH v3] arm: implement cache/shareability attribute bits for PAR registers

2017-10-31 Thread Andrew Baumann via Qemu-devel
> From: Andrew Baumann > Sent: Tuesday, 31 October 2017 21:02 [...] > +static uint8_t convert_stage2_attrs(CPUARMState *env, uint8_t s2attrs) > +{ > +uint8_t hiattr = extract32(s2attrs, 2, 2); > +uint8_t loattr = extract32(s2attrs, 0, 2); > +uint8_t hihint = 0, lohint = 0; > + > +

Re: [Qemu-devel] [RFC PATCH 00/26] replay additions

2017-10-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 00/26] replay additions Type: series Message-id: 20171031110641.5836.43266.stgit@pasha-VirtualBox === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH v3] arm: implement cache/shareability attribute bits for PAR registers

2017-10-31 Thread Andrew Baumann via Qemu-devel
On a successful address translation instruction, PAR is supposed to contain cacheability and shareability attributes determined by the translation. We previously returned 0 for these bits (in line with the general strategy of ignoring caches and memory attributes), but some guest OSes may depend

[Qemu-devel] [PATCH 2/7] linux-user/hppa: Fix TARGET_SA_* defines

2017-10-31 Thread Richard Henderson
From: Helge Deller Reviewed-by: Laurent Vivier Signed-off-by: Helge Deller Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 8 1 file changed, 8 insertions(+) diff --git a/linux-user/syscall_defs.h

[Qemu-devel] [PATCH 7/7] linux-user: Handle TARGET_MAP_STACK and TARGET_MAP_HUGETLB

2017-10-31 Thread Richard Henderson
From: Helge Deller Add the missing defines and for TARGET_MAP_STACK and TARGET_MAP_HUGETLB for alpha, mips, ppc, x86, hppa. Fix the mmap_flags translation table to translate MAP_HUGETLB between host and target architecture, and to drop MAP_STACK. Signed-off-by: Helge Deller

[Qemu-devel] [PATCH 6/7] linux-user/hppa: Fix TARGET_F_RDLCK, TARGET_F_WRLCK, TARGET_F_UNLCK

2017-10-31 Thread Richard Henderson
From: Helge Deller Signed-off-by: Helge Deller Signed-off-by: Richard Henderson Message-ID: <20170311175019.ga7...@ls3530.fritz.box> --- linux-user/syscall_defs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall_defs.h

[Qemu-devel] [PATCH 0/7] linux-user fixes, mostly for hppa

2017-10-31 Thread Richard Henderson
I believe these were last posted back in March. I must claim responsibility for not pinging earlier. r~ Helge Deller (5): linux-user/hppa: Fix TARGET_SA_* defines linux-user/hppa: Fix typo for TARGET_NR_epoll_wait linux-user/hppa: Fix TARGET_MAP_TYPE linux-user/hppa: Fix

[Qemu-devel] [PATCH 3/7] linux-user/hppa: Fix cpu_clone_regs

2017-10-31 Thread Richard Henderson
From: Richard Henderson By failing to return from the syscall in the child, the child issues another clone syscall and hilarity ensues. Signed-off-by: Richard Henderson --- linux-user/hppa/target_cpu.h | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PATCH 5/7] linux-user/hppa: Fix TARGET_MAP_TYPE

2017-10-31 Thread Richard Henderson
From: Helge Deller TARGET_MAP_TYPE needs to be 0x03 instead of 0x0f on the hppa architecture, otherwise it conflicts with MAP_FIXED which is 0x04. Signed-off-by: Helge Deller Signed-off-by: Richard Henderson Message-ID:

[Qemu-devel] [PATCH 4/7] linux-user/hppa: Fix typo for TARGET_NR_epoll_wait

2017-10-31 Thread Richard Henderson
From: Helge Deller Reviewed-by: Laurent Vivier Signed-off-by: Helge Deller Message-Id: <20170311100543.ga29...@ls3530.fritz.box> Signed-off-by: Richard Henderson --- linux-user/hppa/syscall_nr.h | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 1/7] linux-user: Restrict usage of sa_restorer

2017-10-31 Thread Richard Henderson
From: Richard Henderson Reading and writing to an sa_restorer member that isn't supposed to exist corrupts user memory. Introduce TARGET_ARCH_HAS_SA_RESTORER, similar to the kernel's __ARCH_HAS_SA_RESTORER. Reported-by: Helge Deller Signed-off-by: Richard

[Qemu-devel] [PATCH] docker: add python stdlib dependency (required by keycodemapdb)

2017-10-31 Thread Philippe Mathieu-Daudé
Since 927128222b0a QEMU depends of keycodemapdb, which uses the python 'csv' module from stdlib to parse keymaps.csv. Without this package the build fails: GEN ui/input-keymap-linux-to-qcode.c Traceback (most recent call last): File "ui/keycodemapdb/tools/keymap-gen", line 15, in

Re: [Qemu-devel] [PATCH v6 14/25] block/nfs: Implement bdrv_dirname()

2017-10-31 Thread Alberto Garcia
On Fri 29 Sep 2017 06:53:36 PM CEST, Max Reitz wrote: > While the basic idea is obvious and could be handled by the default > bdrv_dirname() implementation, we cannot generate a directory name if > the gid or uid are set, so we have to explicitly return NULL in those > cases. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/1] virtio_balloon: include buffers and cached memory statistics

2017-10-31 Thread Tomáš Golembiovský
ping +Gil, +Amnon... could you maybe aid in reviewing the patch, please? Tomas On Sun, 22 Oct 2017 20:05:57 +0200 Tomáš Golembiovský wrote: > On Thu, 19 Oct 2017 16:12:20 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Sep 21, 2017 at 02:55:41PM

Re: [Qemu-devel] [PATCH v6 12/25] quorum: Make bdrv_dirname() return NULL

2017-10-31 Thread Alberto Garcia
On Fri 29 Sep 2017 06:53:34 PM CEST, Max Reitz wrote: > While the common implementation for bdrv_dirname() should return NULL > for quorum BDSs already (because they do not have a file node and their > exact_filename field should be empty), there is no reason not to make > that explicit. > >

Re: [Qemu-devel] [PATCH v5 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-10-31 Thread mar.krzeminski
W dniu 31.10.2017 o 12:26, francisco iglesias pisze: Hi Marcin, Huge thank you once again for reviewing and your time! I'll update above i next version of the patch series. I'll remove the Acks so the patch can be revisited (if it is ok for you that keep it just let me know and I'll do

Re: [Qemu-devel] [PATCH v6 11/25] blkverify: Make bdrv_dirname() return NULL

2017-10-31 Thread Alberto Garcia
On Fri 29 Sep 2017 06:53:33 PM CEST, Max Reitz wrote: > blkverify's BDSs have a file BDS, but we do not want this to be > preferred over the raw node. There is no way to decide between the two > (and not really a reason to, either), so just return NULL in blkverify's > implementation of

[Qemu-devel] [RFC PATCH 25/26] scripts/replay-dump.py: replay log dumper

2017-10-31 Thread Pavel Dovgalyuk
From: Alex Bennée This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand. It currently understands two different log formats as the audio record/replay support was

[Qemu-devel] [RFC PATCH 20/26] replay: don't destroy mutex at exit

2017-10-31 Thread Pavel Dovgalyuk
Replay mutex is held by vCPU thread and destroy function is called from atexit of the main thread. Therefore we cannot destroy it safely. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |1 - 1 file changed, 1 deletion(-) diff --git a/replay/replay.c

  1   2   >