Re: [Qemu-devel] [PATCH v1 1/1] Makefile: Capstone: Add support for cross compile ranlib

2017-11-08 Thread Richard Henderson
On 11/08/2017 02:10 AM, Alistair Francis wrote: > When cross compiling QEMU for Windows we need to specify the cross > version of ranlib to avoid build errors when buildling capstone. This > patch ensures we use the same cross prefix on ranlib as other toolchain > components. > > Signed-off-by:

[Qemu-devel] [PULL 1/2] disas: Dump insn bytes along with capstone disassembly

2017-11-08 Thread Richard Henderson
This feature is present for some targets in the bfd disassembler(s). Implement it generically for all capstone users. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- include/disas/bfd.h | 2 ++ disas.c | 96

[Qemu-devel] [PULL 2/2] Makefile: Capstone: Add support for cross compile ranlib

2017-11-08 Thread Richard Henderson
From: Alistair Francis When cross compiling QEMU for Windows we need to specify the cross version of ranlib to avoid build errors when building capstone. This patch ensures we use the same cross prefix on ranlib as other toolchain components. - Fedora23 mingw -

[Qemu-devel] [PULL for-2.11 0/2] Capstone updates

2017-11-08 Thread Richard Henderson
One build fix for mingw cross-compiling, one feature regression fix. r~ The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at:

Re: [Qemu-devel] [qemu-s390x] [PATCH] target/s390x: Finish implementing RISBGN

2017-11-08 Thread Richard Henderson
On 11/08/2017 12:50 PM, Cornelia Huck wrote: > I can queue this to s390-fixes (unless there are other takers). Please do. Thanks, r~

[Qemu-devel] [PATCH] ui: fix dcl unregister

2017-11-08 Thread Gerd Hoffmann
register checks for dcl->ds being NULL, to avoid registering the same dcl twice. Therefore dcl->ds must be cleared on unregister, otherwise un-registering and re-registering doesn't work. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1510809 Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

2017-11-08 Thread David Gibson
On Mon, Nov 06, 2017 at 04:02:16PM -0200, Eduardo Habkost wrote: > On Tue, Oct 31, 2017 at 03:01:14PM +0100, Igor Mammedov wrote: > > On Thu, 19 Oct 2017 17:31:51 +1100 > > David Gibson wrote: > > > > > On Wed, Oct 18, 2017 at 01:12:12PM +0200, Igor Mammedov wrote: >

Re: [Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

2017-11-08 Thread David Gibson
On Tue, Nov 07, 2017 at 04:04:04PM +0100, Cornelia Huck wrote: > On Mon, 6 Nov 2017 16:02:16 -0200 > Eduardo Habkost wrote: > > > On Tue, Oct 31, 2017 at 03:01:14PM +0100, Igor Mammedov wrote: > > > On Thu, 19 Oct 2017 17:31:51 +1100 > > > David Gibson

Re: [Qemu-devel] [PATCH] Makefile: simpler/faster "make help"

2017-11-08 Thread Fam Zheng
On Wed, 11/08 00:20, Philippe Mathieu-Daudé wrote: > Using obscure black magic introduced in eaa2ddbb767 :) That is a pretty boring one compared to the rest of our build system. > > In an out-of-tree directory, running "../configure && make help" will generate > some required files (.mak), then

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2017-11-08 Thread David Gibson
On Tue, Nov 07, 2017 at 06:14:04PM +1100, Alexey Kardashevskiy wrote: > On 20/10/17 11:46, Alexey Kardashevskiy wrote: > > On 19/10/17 17:24, David Gibson wrote: > >> On Tue, Oct 17, 2017 at 04:55:03PM +1100, Alexey Kardashevskiy wrote: > >>> On 16/10/17 20:36, David Gibson wrote: > On Mon,

Re: [Qemu-devel] [PATCH V3] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2017 at 04:48:09PM +0200, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with

Re: [Qemu-devel] [PATCH v2] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Fam Zheng
On Wed, 11/08 10:55, Eric Blake wrote: > co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a > stale comment. Update the documentation to match the current > usage of this function. > > Suggested-by: Paolo Bonzini > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-08 Thread Fam Zheng
On Wed, 11/08 18:50, Anton Nefedov wrote: > > > On 8/11/2017 5:45 PM, Alberto Garcia wrote: > > On Tue 07 Nov 2017 05:19:41 PM CET, Anton Nefedov wrote: > > > BlockBackend gets deleted by another job's stream_complete(), deferred > > > to the main loop, so the fact that the job is put to sleep

Re: [Qemu-devel] [PATCH v4 23/45] hw/mips: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Hervé Poussineau
Le 08/11/2017 à 23:57, Alistair Francis a écrit : Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v2 0/7] various NBD fixes for 2.11

2017-11-08 Thread Fam Zheng
On Wed, 11/08 17:05, Eric Blake wrote: > But I'm not sure if there is an easy way to tell patchew to include a > fixup patch and re-test the series, short of sending a v3. Yeah, I don't know a way either. Fam

[Qemu-devel] [PATCH v2 2/2] e1000e: Add e1000-ng devices

2017-11-08 Thread Ed Swierk via Qemu-devel
Implement e1000-compatible devices using the reworked e1000e code: - e1000-ng: Intel 82540EM - e1000-82544gc-ng: Intel 82544GC - e1000-82545em-ng: Intel 82545EM >From a guest's perspective, these should be drop-in replacements for the existing e1000 devices. This version has undergone minimal

[Qemu-devel] [PATCH v2 0/2] e1000e: Reimplement e1000 as a variant of e1000e

2017-11-08 Thread Ed Swierk via Qemu-devel
>From a hardware functionality and register perspective, the Intel 8254x Gigabit Ethernet Controller[1] is roughly a subset of the Intel 82574[2], making it practical to implement e1000 device emulation as an extension of e1000e. That would be a step towards eliminating the existing e1000

[Qemu-devel] [PATCH v2 1/2] e1000e: Infrastructure for e1000-ng

2017-11-08 Thread Ed Swierk via Qemu-devel
Generalize e1000e to support e1000 and other devices with a similar register spec: - plain PCI instead of PCIe, skipping setup of MSI-X, AER, etc. - model-specific PHY ID2, register values and access permissions - model-specific EEPROM template and read/write methods This is just infrastructure,

Re: [Qemu-devel] [PATCH qemu v3] pci: Initialize pci_dev->name before use

2017-11-08 Thread Alexey Kardashevskiy
On 26/10/17 13:21, Alexey Kardashevskiy wrote: > On 19/10/17 13:15, Alexey Kardashevskiy wrote: >> This moves pci_dev->name initialization earlier so >> pci_dev->bus_master_as could get a name instead of an empty string. >> >> Reviewed-by: Philippe Mathieu-Daudé >> Reviewed-by:

Re: [Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

2017-11-08 Thread Fam Zheng
On Thu, 11/09 01:48, Max Reitz wrote: > Hi, > > More exciting news from the bdrv_drain() front! > > I've noticed in the past that iotest 194 sometimes hangs. I usually run > the tests on tmpfs, but I've just now verified that it happens on my SSD > just as well. > > So the reproducer is a

Re: [Qemu-devel] [PATCH v4 00/45] Remove some of the fprintf(stderr, "*

2017-11-08 Thread Philippe Mathieu-Daudé
Hi Alistair, On 11/08/2017 07:56 PM, Alistair Francis wrote: > Continue on improving QEMUs logging/error messages by removing more > fprintf()'s. > > Unfortunatley my Coccinelle skills aren't that great so it's all done in > some nasty regex and a little bit of manual work. > > V4: > - Reorder

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Alexey Kardashevskiy
On 08/11/17 20:57, Thomas Huth wrote: > > That automatic git submodule stuff now broke my workflow again. I > usually keep the git repository on my laptop and then simply rsync the > sources (without .git directories) to my target machine to compile it > there. Used to work great for years. Now

Re: [Qemu-devel] [PATCH v4 06/45] hw/block: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:56 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > [...] > diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c > index

Re: [Qemu-devel] [PATCH v4 08/45] hw/char: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:56 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v4 18/45] hw/intc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:57 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v4 29/45] hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:58 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v4 31/45] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
Cc'ing Alexander to ask him about the mpc8544ds. On 11/08/2017 07:58 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > [...] > diff --git

Re: [Qemu-devel] [U-Boot] Support of latest qemux86-64

2017-11-08 Thread Bin Meng
On Wed, Nov 8, 2017 at 9:05 PM, Anton Gerasimov wrote: > Adding Igor Mammedov to the loop. > Really add Igor Mammedov. Igor, can you help look at this? > On 11/08/2017 01:59 PM, Anton Gerasimov wrote: >> To whoever might be interested: I've bisected qemu and the

[Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky

2017-11-08 Thread Max Reitz
136 executes some AIO requests without a final aio_flush; then it advances the virtual clock and thus expects the last access time of the device to be less than the current time when queried (i.e. idle_time_ns to be greater than 0). However, without the aio_flush, some requests may be settled

[Qemu-devel] [PATCH 4/5] iotests: Make 083 less flaky

2017-11-08 Thread Max Reitz
083 has (at least) two issues: 1. By launching the nbd-fault-injector in background, it may not be scheduled until the first grep on its output file is executed. However, until then, that file may not have been created yet -- so it either does not exist yet (thus making the grep emit an

[Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040

2017-11-08 Thread Max Reitz
040 tries to invoke pause_drive() on a drive that does not use blkdebug. Good idea, but let's use blkdebug to make it actually work. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/040

[Qemu-devel] [PATCH 3/5] iotests: Make 055 less flaky

2017-11-08 Thread Max Reitz
First of all, test 055 does a valiant job of invoking pause_drive() sometimes, but that is worth nothing without blkdebug. So the first thing to do is to sprinkle a couple of "blkdebug::" in there -- with the exception of the transaction tests, because the blkdebug break points make the

[Qemu-devel] [PATCH 0/5] iotests: Make some tests less flaky

2017-11-08 Thread Max Reitz
There are a couple of tests that fail (on my machine) from time to time (and by that I mean that recently I've rarely ever had a test run with both 083 and 136 working on first try). This series should fix most (at least the issues I am aware of). Notes: - 083 might have another issue, but if so

[Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky

2017-11-08 Thread Max Reitz
This patch fixes two race conditions in 030: 1. The first is in TestENSPC.test_enospc(). After resuming the job, querying it to confirm it is no longer paused may fail because in the meantime it might have completed already. The same was fixed in TestEIO.test_ignore() already (in

[Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

2017-11-08 Thread Max Reitz
Hi, More exciting news from the bdrv_drain() front! I've noticed in the past that iotest 194 sometimes hangs. I usually run the tests on tmpfs, but I've just now verified that it happens on my SSD just as well. So the reproducer is a plain: while ./check -raw 194; do; done (No difference

Re: [Qemu-devel] [PATCH v4 40/45] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:58 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v4 13/45] hw/gpio: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:57 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v4 28/45] hw/nvram: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:58 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v2 0/7] various NBD fixes for 2.11

2017-11-08 Thread Eric Blake
On 11/08/2017 04:24 PM, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > 140 - output mismatch (see 140.out.bad) > ---

[Qemu-devel] [PATCH v4 44/45] tcg: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 45/45] target: Use qemu_log() instead of fprintf(stderr, ...)

2017-11-08 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/cris/translate.c | 2 +- target/ppc/translate.c | 22 +++--- target/sh4/translate.c | 4 ++-- target/unicore32/translate.c | 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff

[Qemu-devel] [PATCH v4 41/45] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 42/45] util: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 43/45] ui: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 38/45] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 35/45] hw/sh4: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 31/45] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 33/45] hw/scsi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

Re: [Qemu-devel] [PATCH v4 12/45] hw/dma: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 07:57 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v4 34/45] hw/sd: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 27/45] hw/nios2: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 30/45] hw/pci*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 32/45] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 21/45] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 28/45] hw/nvram: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 23/45] hw/mips: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 24/45] hw/misc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 40/45] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 20/45] hw/isa: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 26/45] hw/net: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 37/45] hw/ssi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 19/45] hw/ipmi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 25/45] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 02/45] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Alistair Francis
Replace all occurs of __FUNCTION__ except for the check in checkpatch with the non GCC specific __func__. One line in hcd-musb.c was manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: Gerd Hoffmann Cc: Andrzej Zaborowski

[Qemu-devel] [PATCH v4 17/45] hw/input: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 39/45] hw/usb: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 22/45] hw/microblaze: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 18/45] hw/intc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 14/45] hw/i2c: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 36/45] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 16/45] hw/ide: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 12/45] hw/dma: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 13/45] hw/gpio: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 09/45] hw/core: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 10/45] hw/cris: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 08/45] hw/char: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 29/45] hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 07/45] hw/bt: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 11/45] hw/display: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 05/45] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 04/45] tests: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 06/45] hw/block: Replace fprintf(stderr, "*\n" with error_report()

2017-11-08 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v4 01/45] audio: Replace AUDIO_FUNC with __func__

2017-11-08 Thread Alistair Francis
Apparently we don't use __MSC_VER as a compiler anymore and we always require a C99 compiler (which means we always have __func__) so we don't need a special AUDIO_FUNC macro. We can just replace AUDIO_FUNC with __func__ instead. Checkpatch failures were manually fixed. Signed-off-by: Alistair

[Qemu-devel] [PATCH v4 03/45] Fixes after renaming __FUNCTION__ to __func__

2017-11-08 Thread Alistair Francis
Signed-off-by: Alistair Francis Cc: Eric Blake Reviewed-by: Eric Blake --- V3: - Squash onto single lines - Don't fix indentation of case in omap_prcm_apll_update() hw/arm/omap1.c | 8 +++- hw/block/onenand.c | 2 +-

[Qemu-devel] [PATCH v4 00/45] Remove some of the fprintf(stderr, "*

2017-11-08 Thread Alistair Francis
Continue on improving QEMUs logging/error messages by removing more fprintf()'s. Unfortunatley my Coccinelle skills aren't that great so it's all done in some nasty regex and a little bit of manual work. V4: - Reorder patch 3 (the audio func patch) - Add all tags - Small fixes V3: - Rebase

[Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

2017-11-08 Thread Tao Wu via Qemu-devel
The current code looks buggy, we zero ti_i while we access ti_dst/ti_src later. Signed-off-by: Tao Wu --- slirp/tcp_subr.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index dc8b4bbb50..da0d53743f 100644

[Qemu-devel] [PATCH v2 2.5/7] fixup! nbd-client: Refuse read-only client with BDRV_O_RDWR

2017-11-08 Thread Eric Blake
... Fix several iotests to comply with the new behavior (since qemu-nbd of an internal snapshot, as well as nbd-server-add over QMP, default to a read-only export, we must tell blockdev-add/qemu-io to set up a read-only client). Signed-off-by: Eric Blake --- Will squash when

[Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-08 Thread Tao Wu via Qemu-devel
The old code treats bits as bytes when calculating host memory usage. Change it to be consistent with allocation logic in pixman library. Signed-off-by: Tao Wu --- hw/display/virtio-gpu.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-08 Thread Alistair Francis
On Wed, Nov 8, 2017 at 1:52 PM, Eduardo Habkost wrote: > On Wed, Nov 08, 2017 at 10:29:43PM +0100, Richard Henderson wrote: >> On 11/06/2017 09:13 PM, Emilio G. Cota wrote: >> > Subject: [PATCH] qom: move CPUClass.tcg_initialize to a global >> > >> > 55c3cee ("qom: Introduce

Re: [Qemu-devel] Moving release tarballs to a CDN

2017-11-08 Thread Jeff Cody
On Wed, Nov 08, 2017 at 05:11:20PM +, Stefan Hajnoczi wrote: > On Wed, Nov 08, 2017 at 05:19:25PM +0100, Stefan Weil wrote: > > Am 08.11.2017 um 16:33 schrieb Stefan Hajnoczi: > > > Hi Mike and Jeff, > > > qemu.org's bandwidth usage is dominated by release tarball downloads. > > > This puts

Re: [Qemu-devel] [PATCH v2 2/7] nbd-client: Refuse read-only client with BDRV_O_RDWR

2017-11-08 Thread Eric Blake
On 11/08/2017 03:56 PM, Eric Blake wrote: > Fix iotest 147 to comply with the new behavior (since nbd-server-add > defaults to a read-only export, we must tell blockdev-add to set up a > read-only client). My bad for testing only './check -nbd' and not also './check -qcow2'; iotest 58 and 140

[Qemu-devel] [PATCH v2 0/7] various NBD fixes for 2.11

2017-11-08 Thread Eric Blake
Sparked by my question on whether we were handling zero-length reads correctly according to the NBD spec, but grew to fix other things as well such as some typos, tracing weaknesses, and better handling of read-only exports. The order these patches are listed here is bisection-friendly, but

[Qemu-devel] [PATCH v2 6/7] nbd-client: Stricter enforcing of structured reply spec

2017-11-08 Thread Eric Blake
Ensure that the server is not sending unexpected chunk lengths for either the NONE or the OFFSET_DATA chunk, nor unexpected hole length for OFFSET_HOLE. This will flag any server that responds to a zero-length read with an OFFSET_DATA as broken, even though we previously fixed our client to never

[Qemu-devel] [PATCH v2 2/7] nbd-client: Refuse read-only client with BDRV_O_RDWR

2017-11-08 Thread Eric Blake
The NBD spec says that clients should not try to write/trim to an export advertised as read-only by the server. But we failed to check that, and would allow the block layer to use NBD with BDRV_O_RDWR even when the server is read-only, which meant we were depending on the server sending a proper

[Qemu-devel] [PATCH v2 5/7] nbd-client: Short-circuit 0-length operations

2017-11-08 Thread Eric Blake
The NBD spec was recently clarified to state that clients should not send 0-length requests to the server, as the server behavior is undefined [1]. We know that qemu-nbd's behavior is a successful no-op (once it has filtered for read-only exports), but other NBD implementations might return an

[Qemu-devel] [PATCH v2 7/7] nbd/server: Fix structured read of length 0

2017-11-08 Thread Eric Blake
The NBD spec was recently clarified to state that a read of length 0 should not be attempted by a compliant client; but that a server must still handle it correctly in an unspecified manner (that is, either a successful no-op or an error reply, but not a crash) [1]. However, it also implies that

[Qemu-devel] [PATCH v2 1/7] nbd-client: Fix error message typos

2017-11-08 Thread Eric Blake
Provide missing spaces that are required when using string concatenation to break error messages across source lines. Signed-off-by: Eric Blake --- block/nbd-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/nbd-client.c

[Qemu-devel] [PATCH v2 3/7] nbd/client: Nicer trace of structured reply

2017-11-08 Thread Eric Blake
It's useful to know which structured reply chunk is being processed. Signed-off-by: Eric Blake --- nbd/client.c | 4 +++- nbd/trace-events | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index 3d680e63e1..1880103d2a

[Qemu-devel] [PATCH v2 4/7] nbd: Fix struct name for structured reads

2017-11-08 Thread Eric Blake
A closer read of the NBD spec shows that a structured reply chunk for a hole is not quite identical to the prefix of a data chunk, because the hole has to also send a 32-bit size field. Although we do not yet send holes, we should fix the misleading information in our header and make it easier

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-08 Thread Eduardo Habkost
On Wed, Nov 08, 2017 at 10:29:43PM +0100, Richard Henderson wrote: > On 11/06/2017 09:13 PM, Emilio G. Cota wrote: > > Subject: [PATCH] qom: move CPUClass.tcg_initialize to a global > > > > 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24) > > introduces a per-CPUClass bool that we

  1   2   3   4   >