[Qemu-devel] [PATCH 1/1] main loop: remove useless code

2017-12-01 Thread FelixYao
hi Paolo Bonzini: Those codes seem useless, Could it be removed? Signed-off-by: FelixYao --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c index 1ad1c04..5bed4c2 100644 --- a/vl.c +++ b/vl.c @@ -2995,10 +2995,6 @@ static void

Re: [Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Hailiang Zhang
On 2017/12/2 2:37, Paolo Bonzini wrote: On 01/12/2017 18:45, Gonglei (Arei) wrote: I also think it's windows bug, the problem is that it doesn't occur on xen platform. It's a race, it may just be that RTC PIO is faster in Xen because it's implemented in the hypervisor. No, In Xen, it does

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-01 Thread David Gibson
On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > > On 29/11/2017 10:46, David Gibson wrote: > > > > include/hw/pci/pci_bus.h is now very

Re: [Qemu-devel] [PATCH v1] spapr.c: Update qemu's maxcpus for pseries machine.

2017-12-01 Thread David Gibson
On Fri, Dec 01, 2017 at 04:54:09PM +0530, Seeteena Thoufeek wrote: > Need to adjust the max cpus supported number from error message since > it was conflicting with KVM's. > > Steps to Reproduce: > 1.boot up with > "-smp 64,maxcpus=102464,cores=8,threads=1,sockets=8" > > qemu-kvm: Number of SMP

[Qemu-devel] [PATCH v3] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
Now, if you type something like qemu-img create disk.qcow2 1G or qemu-img dd if=/dev/sda of=disk.qcow2 it creates a raw image and if you need you should manually specify an image format with -f qcow2. It would be more convenient if it could be assumed from an extension. This patch adds a simple

[Qemu-devel] [PATCH v2 2/7] mips: Tweak location of ';' in macros

2017-12-01 Thread Eric Blake
It is more typical to provide the ';' by the caller of a macro than to embed it in the macro itself; this is because syntax highlight engines can get confused if a macro is called without a semicolon before the closing '}'. Signed-off-by: Eric Blake Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH v2] qemu-img: add the simplest format recognition

2017-12-01 Thread Eric Blake
On 12/01/2017 04:49 PM, Klim Kireev wrote: > Now, if you type something like > > qemu-img create disk.qcow2 1G > or > qemu-img dd if=/dev/sda of=disk.qcow2 > > it creates a raw image and if you need you should > manually specify an image format with -f qcow2. It would > be more convenient if it

[Qemu-devel] [PATCH v2 1/7] net: Drop unusual use of do { } while (0);

2017-12-01 Thread Eric Blake
For a couple of macros in pcnet.c, we have to provide a new scope to avoid compiler warnings about declarations in the middle of a switch statement that aren't in a sub-scope. But use of 'do { ... } while (0);' merely to provide that new scope is arcane overkill, compared to just using '{ ... }'.

[Qemu-devel] [PATCH v2 7/7] checkpatch: Enforce proper do/while (0) style

2017-12-01 Thread Eric Blake
Use of a loop construct for code that is not intended to repeat does not make much idiomatic sense, except in one place: it is a common usage in macros in order to wrap arbitrary code with single-statement semantics. But when used in a macro, it is more typical for the caller to supply the

[Qemu-devel] [PATCH v2 5/7] tests: Avoid 'do/while(false); ' in vhost-user-bridge

2017-12-01 Thread Eric Blake
Use of a do/while(0) loop as a way to allow break statements in the middle of execute-once code is unusual. More typical is the use of goto for early exits, with a label at the end of the execute-once code, rather than nesting code in a scope; however, the comment at the end of the existing code

[Qemu-devel] [PATCH v2 6/7] maint: Fix macros with broken 'do/while(0); ' usage

2017-12-01 Thread Eric Blake
The point of writing a macro embedded in a 'do { ... } while (0)' loop (particularly if the macro has multiple statements or would otherwise end with an 'if' statement) is so that the macro can be used as a drop-in statement with the caller supplying the trailing ';'. Although our coding style

[Qemu-devel] [PATCH v2 0/7] macro do/while (0) cleanup

2017-12-01 Thread Eric Blake
Noticed this by chance in the tests/ directory, so I broadened it to a grep of the entire code base. I suspect^wKNOW many of the bad macros were the victims of copy-and-paste from some other bad location (particularly given how many bit-rotten debug print macros were involved).

[Qemu-devel] [PATCH v2 3/7] chardev: Use goto/label instead of do/break/while(0)

2017-12-01 Thread Eric Blake
Use of a do/while(0) control flow in order to permit an early break is an unusual paradigm, and triggers a false positive with a planned future syntax check against 'while (0);'. Rewrite the code to use a goto instead. This patch temporarily keeps an extra level of indentation to highlight the

[Qemu-devel] [PATCH v2 4/7] chardev: Clean up previous patch indentation

2017-12-01 Thread Eric Blake
The previous patch left in an extra scope layer for ease of review; time to remove it. No semantic change. Signed-off-by: Eric Blake --- chardev/char-serial.c | 66 +-- 1 file changed, 32 insertions(+), 34 deletions(-) diff

[Qemu-devel] [PATCH v2] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
Now, if you type something like qemu-img create disk.qcow2 1G or qemu-img dd if=/dev/sda of=disk.qcow2 it creates a raw image and if you need you should manually specify an image format with -f qcow2. It would be more convenient if it could be detected from an extension. This patch adds a

Re: [Qemu-devel] [PULL v2 11/11] disas: Add capstone as submodule

2017-12-01 Thread Eric Blake
On 10/26/2017 05:00 AM, Richard Henderson wrote: > Do not require the submodule, but use it if present. Allow the > command-line to override system or git submodule either way. > > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PATCH] qemu-img: add the simplest format recognition

2017-12-01 Thread Eric Blake
On 12/01/2017 02:05 PM, Klim Kireev wrote: Now, if you type something like qemu-img create disk.qcow2 1G or qemu-img dd if=/dev/sda of=disk.qcow2 it creates a raw image and if you need you should manually specify an image format with -f qcow2. It would be more convenient if it could be

[Qemu-devel] [PATCH] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
Now, if you type something like qemu-img create disk.qcow2 1G or qemu-img dd if=/dev/sda of=disk.qcow2 it creates a raw image and if you need you should manually specify an image format with -f qcow2. It would be more convenient if it could be detected from an extension. This patch adds a

[Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-01 Thread Michael McConville
Signed-off-by: Michael McConville --- hw/i386/xen/xen-mapcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index baab93b614..efa35dc6e0 100644 --- a/hw/i386/xen/xen-mapcache.c +++

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests: add section on how to write a new I/O test

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > This adds some basic information on how to write a new test. I'm > aware that some of the information in the wiki (Testing/QemuIoTests) > could also belong here. > > Since copying content over won't generate much interesting feedback, > the goal here is

Re: [Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use

2017-12-01 Thread Eric Blake
On 11/16/2017 11:38 AM, Cleber Rosa wrote: The functions used in _cleanup() come from common.rc, which currently gets sourced after _cleanup() is defined and registered as a signal handler. When _cleanup() is executed, it has no valid references to those functions, as BASH won't resolve the

Re: [Qemu-devel] [PATCH 08/10] qemu-iotests: clean up double comment characters

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > This is a syntactic only change, just to make it consistent with > the style used on all other tests. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/048 | 37 ++--- > tests/qemu-iotests/074 |

Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > Another legacy variable that did not convince me it has any > purpose whatsoever. > > Signed-off-by: Cleber Rosa > --- Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code)

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > The $seq.full file, in theory, should contain the full output of a > test error. In practice, it's only used on a single test, and the > boiler plate code to clean it up plagues all other tests. > > Let's remove the concept altogether, and record the

[Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-01 Thread Halil Pasic
With the cssids unrestricted (commit "s390x/css: unrestrict cssids") the s390-squash-mcss machine property should not be used. Actually libvirt never supported this, so the expectation is that removing it should be pretty painless. But let's play nice and deprecate it first. Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

2017-12-01 Thread Max Reitz
On 2017-11-17 14:15, Cleber Rosa wrote: > > > On 11/17/2017 02:25 AM, Paolo Bonzini wrote: >> On 16/11/2017 18:38, Cleber Rosa wrote: >>> check makes a distinction on how it runs Python based tests. The >>> current approach is inconsistent because: >>> >>> 1) a large number of Python tests are

Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices

2017-12-01 Thread Halil Pasic
On 11/28/2017 04:21 PM, Halil Pasic wrote: [..] >>> Otherwise at first glance both patches seem sane. >> >> Can I count this as an ack, or do you plan to do more review? >> > > Yes I was planning to give it another look. And I do already > have questions. Isn't the QOM composition tree API? I

Re: [Qemu-devel] [PATCH v3 2/2] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2017-12-01 Thread Max Reitz
On 2017-11-16 23:35, Daniel Henrique Barboza wrote: > This patch implements a test case for the scenario that was failing > prior to the patch "migration/ram.c: do not set 'postcopy_running' in > POSTCOPY_INCOMING_END". > > This new test file 198 was derived from the test file 181 authored > by

Re: [Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > The functions used in _cleanup() come from common.rc, which currently > gets sourced after _cleanup() is defined and registered as a signal > handler. When _cleanup() is executed, it has no valid references to > those functions, as BASH won't resolve the

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Eric Blake
On 12/01/2017 11:03 AM, Paolo Bonzini wrote: Just my 2 cents on the language topic, as in general I agree completely with Stefan. Luckily, several benefits don't require a full rewrite or language switch: - readability from RAII-style code. If this is important enough, we could actually

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Peter Maydell
On 1 December 2017 at 17:03, Paolo Bonzini wrote: > Same here. Just like fixing the C code provides a good foundation for a > language switch, some more battle-tested code could be converted from > QEMU to Rust, in order to get familiar with it and probe whether the >

Re: [Qemu-devel] [PATCH 2/2] qmp: add nbd-server-remove

2017-12-01 Thread Max Reitz
On 2017-11-09 16:40, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should

[Qemu-devel] [PATCH 2/2] nvic: Make systick banked

2017-12-01 Thread Peter Maydell
For the v8M security extension, there should be two systick devices, which use separate banked systick exceptions. The register interface is banked in the same way as for other banked registers, including the existence of an NS alias region for secure code to access the nonsecure timer.

Re: [Qemu-devel] [PATCH 04/10] qemu-iotests: include (source) filters from common.rc

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > There's an explicit dependency from common.rc on common.filters, that > is, it consumes functions defined there. Just like common.config is > included in common.rc, it makes sense to also sense common.filter. > > This drops the requirement on individual

Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: be strict with expected output

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > The contract between runner (check) and test is one that accepts some > minor differences in the expcted output, as the comparison method > employed is a "diff -w". > > This is an exception to a clearer and more straightforward rule of > just requiring

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Eric Blake
On 12/01/2017 12:38 PM, Laurent Vivier wrote: On 01/12/2017 19:30, Eric Blake wrote: On 12/01/2017 06:58 AM, Juan Quintela wrote: Hi This is on top of my info_migrate series. Let patchew know about it: Based-on: <20171201125750.1372-1-quint...@redhat.com> ([PATCH v3 0/2] Improve info

Re: [Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks

2017-12-01 Thread Max Reitz
On 2017-11-16 18:38, Cleber Rosa wrote: > Commit cce293a2945 moved some functions from common.config to > common.rc, but the error messages still reference the old file > location. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/common.rc | 4 ++-- > 1 file changed,

Re: [Qemu-devel] [PATCH v12 3/6] migration: calculate vCPU blocktime on dst side

2017-12-01 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch provides blocktime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach was suggested by Peter Xu, as an improvements of > previous approch where QEMU kept tree with faulted page address

[Qemu-devel] [PATCH 4/7] target/arm: Split M profile MNegPri mmu index into user and priv

2017-12-01 Thread Peter Maydell
For M profile, we currently have an mmu index MNegPri for "requested execution priority negative". This fails to distinguish "requested execution priority negative, privileged" from "requested execution priority negative, usermode", but the two can return different results for MPU lookups. Fix

Re: [Qemu-devel] [PATCH] qemu-pr-helper: miscellaneous fixes

2017-12-01 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > 1) Return a generic sense if TEST UNIT READY does not provide one; > > 2) Fix two mistakes in copying from the spec. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Paolo Bonzini Reviewed-by: Dr.

[Qemu-devel] [PATCH 3/7] target/arm: Add missing M profile case to regime_is_user()

2017-12-01 Thread Peter Maydell
When we added the ARMMMUIdx_MSUser MMU index we forgot to add it to the case statement in regime_is_user(), so we weren't treating it as unprivileged when doing MPU lookups. Correct the omission. Signed-off-by: Peter Maydell --- target/arm/helper.c | 1 + 1 file

Re: [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-01 Thread Max Reitz
On 2017-11-09 15:16, Vladimir Sementsov-Ogievskiy wrote: > This is needed to implement image-fleecing scheme, when we create > a temporary node, mark our active node to be backing for the temp, > and start backup(sync=none) from active node to the temp node. > Temp node then represents a kind of

[Qemu-devel] [PATCH 0/7] armv8m: Implement TT, and other bugfixes

2017-12-01 Thread Peter Maydell
The main aim of this patchseries is to implement the new-for-v8M TT/TTT/TTA/TTAT instructions (which take an address and do an MPU/SAU lookup and tell you the security state and access permissions for the address). The first part of the series is some smaller bugfixes that I noticed along the

[Qemu-devel] [PATCH for 2.11 0/1] Fix guest boot with vhost-scsi

2017-12-01 Thread Eric Farman
(Apologies for not noticing this earlier in the development cycle; I have been on leave and am just getting back.) A colleague of mine noticed an inability to start a guest with the 2.11 RC's, when a vhost-scsi device is defined in the guest. The symptoms on s390 are an exception loop in the

Re: [Qemu-devel] [PATCH 1/2] nbd/server: add additional assert to nbd_export_put

2017-12-01 Thread Max Reitz
On 2017-11-09 16:40, Vladimir Sementsov-Ogievskiy wrote: > This place is not obvious, nbd_export_close may theoretically reduce > refcount to 0. It may happen if someone calls nbd_export_put on named > export not through nbd_export_set_name when refcount is 1. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

2017-12-01 Thread Eric Blake
On 12/01/2017 06:57 AM, Juan Quintela wrote: It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- @@ -2422,6 +2430,8 @@ static Property

[Qemu-devel] [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Zhanghailiang
Hi, We hit a bug in our test while run PCMark 10 in a windows 7 VM, The VM got stuck and the wallclock was hang after several minutes running PCMark 10 in it. It is quite easily to reproduce the bug with the upstream KVM and Qemu. We found that KVM can not inject any RTC irq to VM after it was

[Qemu-devel] [PATCH 0/2] v8m: make systick banked

2017-12-01 Thread Peter Maydell
This patchset makes the systick device be banked between security states for ARM v8M. It is perhaps not the absolute cleanest way to implement this banking, but the alternative (which I had an irc discussion with Paolo about some weeks back) would involve adding a feature to our IOMMU abstraction

[Qemu-devel] [PATCH 1/7] target/arm: Handle SPSEL and current stack being out of sync in MSP/PSP reads

2017-12-01 Thread Peter Maydell
For v8M it is possible for the CONTROL.SPSEL bit value and the current stack to be out of sync. This means we need to update the checks used in reads and writes of the PSP and MSP special registers to use v7m_using_psp() rather than directly checking the SPSEL bit in the control register.

Re: [Qemu-devel] [PATCH v1 1/2] intel-iommu: Redefine macros to enable supporting 48 bit address width

2017-12-01 Thread Prasad Singamsetty
On 12/1/2017 3:23 AM, Liu, Yi L wrote: On Tue, Nov 14, 2017 at 06:13:49PM -0500, prasad.singamse...@oracle.com wrote: From: Prasad Singamsetty The current implementation of Intel IOMMU code only supports 39 bits host/iova address width so number of macros use

[Qemu-devel] [PATCH 1/2] nvic: Make nvic_sysreg_ns_ops work with any MemoryRegion

2017-12-01 Thread Peter Maydell
Generalize nvic_sysreg_ns_ops so that we can pass it an arbitrary MemoryRegion which it will use as the underlying register implementation to apply the NS-alias behaviour to. We'll want this so we can do the same with systick. Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-01 Thread Peter Maydell
On 1 December 2017 at 17:08, Michael S. Tsirkin wrote: > The following changes since commit c11d61271b9e6e7a1f0479ef1ca8fb55fa457a62: > > Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-01 Thread Eric Farman
Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing virtqueue size to be set.") introduced a new parameter to virtio-scsi. Later, commit 920036106044 ("vhost-user-scsi: add missing virtqueue_size param") added that parameter to the new vhost-user-scsi interface but neglected

[Qemu-devel] [PATCH 2/7] target/arm: Allow explicit writes to CONTROL.SPSEL in Handler mode

2017-12-01 Thread Peter Maydell
In ARMv7M the CPU ignores explicit writes to CONTROL.SPSEL in Handler mode. In v8M the behaviour is slightly different: writes to the bit are permitted but will have no effect. We've already done the hard work to handle the value in CONTROL.SPSEL being out of sync with what stack pointer is

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/9] block: Remove unused bdrv_requests_pending

2017-12-01 Thread Alberto Garcia
On Wed 29 Nov 2017 03:49:48 PM CET, Fam Zheng wrote: > Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH 7/7] target/arm: Implement TT instruction

2017-12-01 Thread Peter Maydell
Implement the TT instruction which queries the security state and access permissions of a memory location. Signed-off-by: Peter Maydell --- target/arm/helper.h| 2 + target/arm/helper.c| 108 +

Re: [Qemu-devel] [PATCH 2/2] qcow2: fix indentation after previous patch

2017-12-01 Thread Eric Blake
On 11/30/2017 10:47 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 34 +- block/qcow2.c | 16 2 files changed, 25 insertions(+), 25 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Laurent Vivier
On 01/12/2017 19:30, Eric Blake wrote: > On 12/01/2017 06:58 AM, Juan Quintela wrote: >> Hi >> >> This is on top of my info_migrate series. > > Let patchew know about it: > > Based-on: <20171201125750.1372-1-quint...@redhat.com> > ([PATCH v3 0/2] Improve info migrate output on destination) Is

[Qemu-devel] [PATCH] qemu-pr-helper: miscellaneous fixes

2017-12-01 Thread Paolo Bonzini
1) Return a generic sense if TEST UNIT READY does not provide one; 2) Fix two mistakes in copying from the spec. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- include/scsi/utils.h | 6 +- scsi/qemu-pr-helper.c | 30

Re: [Qemu-devel] [PATCH 19/25] spapr: add hcalls support for the XIVE interrupt mode

2017-12-01 Thread Cédric Le Goater
On 12/01/2017 05:01 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:49PM +0100, Cédric Le Goater wrote: >> A set of Hypervisor's call are used to configure the interrupt sources >> and the event/notification queues of the guest: >> >> - H_INT_GET_SOURCE_INFO >> >>used to obtain the

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2017-12-01 Thread Eric Blake
[adding Dan in cc] On 11/30/2017 10:47 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 7 +-- block/qcow2-refcount.c | 12 block/qcow2.c | 6 ++ 3 files changed, 23

Re: [Qemu-devel] [PATCH v18 05/10] xbitmap: add more operations

2017-12-01 Thread Matthew Wilcox
On Fri, Dec 01, 2017 at 03:09:08PM +, Wang, Wei W wrote: > On Friday, December 1, 2017 9:02 PM, Tetsuo Handa wrote: > > If start == end is legal, > > > >for (; start < end; start = (start | (IDA_BITMAP_BITS - 1)) + 1) { > > > > makes this loop do nothing because 10 < 10 is false. > >

Re: [Qemu-devel] [PATCH v7 for-2.12 04/25] iotests: Drop explicit base blockdev in 191

2017-12-01 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:43 PM CET, Max Reitz wrote: > Overriding the backing image should result in a json:{} pseudo-filename. > Then, you can no longer use the commit block job with filename > parameters. Therefore, do not explicitly add the base and override the > middle image in iotest 191,

[Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Gonglei (Arei)
I also think it's windows bug, the problem is that it doesn't occur on xen platform. And there are some other works need to be done while reading REG_C. So I wrote that patch. Thanks, Gonglei 发件人:Paolo Bonzini 收件人:龚磊,张海亮,qemu-devel,Michael S. Tsirkin 抄送:黄伟栋,王欣,谢祥有 时间:2017-12-02 01:10:08 主题:Re:

Re: [Qemu-devel] [PATCH v7 for-2.12 03/25] block: Add BDS.backing_overridden

2017-12-01 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:42 PM CET, Max Reitz wrote: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this in > bdrv_refresh_filename(). > > Adding a new field to the BDS is not nice, but it is very simple

Re: [Qemu-devel] [PATCH qemu v5 1/2] memory/iommu/vfio: Define add_vfio_group() callback

2017-12-01 Thread Alexey Kardashevskiy
On 01/12/17 10:09, Alex Williamson wrote: > On Fri, 1 Dec 2017 08:56:42 +1100 > Alexey Kardashevskiy wrote: > >> On 05/10/17 16:50, Alexey Kardashevskiy wrote: >>> The new callback will be called when a new VFIO IOMMU group is added. >>> >>> This should cause no behavioral

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-12-01 Thread John Paul Adrian Glaubitz
I have verified that this patch [1] in glibc_2.25 and glibc_2.26 fixes the assert. > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=22273 ** Bug watch added: Sourceware.org Bugzilla #22273 https://sourceware.org/bugzilla/show_bug.cgi?id=22273 -- You received this bug notification

[Qemu-devel] [PATCH 2/3] s390x/css: advertise unrestricted cssids

2017-12-01 Thread Halil Pasic
Let us advertise the changes introduced by "s390x/css: unrestrict cssids" to the management software (so it can tell are cssids unrestricted or restricted). Signed-off-by: Halil Pasic --- Boris says having the property on the virtual-css-bridge is good form Libvirt

[Qemu-devel] [Bug 1735576] Re: Support more than 4G memory for guest with Intel HAXM acceleration

2017-12-01 Thread Hu Jun
update: according to haxm dev, they will submit a patch for qemu side of work; -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1735576 Title: Support more than 4G memory for guest with Intel HAXM

[Qemu-devel] [PATCH 5/7] target/arm: Create new arm_v7m_mmu_idx_for_secstate_and_priv()

2017-12-01 Thread Peter Maydell
The TT instruction is going to need to look up the MMU index for a specified security and privilege state. Refactor the existing arm_v7m_mmu_idx_for_secstate() into a version that lets you specify the privilege state and one that uses the current state of the CPU. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 6/7] target/arm: Factor MPU lookup code out of get_phys_addr_pmsav8()

2017-12-01 Thread Peter Maydell
For the TT instruction we're going to need to do an MPU lookup that also tells us which MPU region the access hit. This requires us to do the MPU lookup without first doing the SAU security access check, so pull the MPU lookup parts of get_phys_addr_pmsav8() out into their own function. The TT

Re: [Qemu-devel] [PATCH v4 28/32] migration: allow migrate_incoming for paused VM

2017-12-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > migrate_incoming command is previously only used when we were providing > "-incoming defer" in the command line, to defer the incoming migration > channel creation. > > However there is similar requirement when we are paused during postcopy > migration. The

Re: [Qemu-devel] [Bug 1735384] Re: OpenJDK JVM segfaults on qemu-sh4 (regression)

2017-12-01 Thread John Paul Adrian Glaubitz
The offending commit is: d25f2a72272b9ffe0d06710d6217d1169bc2cc7d is the first bad commit commit d25f2a72272b9ffe0d06710d6217d1169bc2cc7d Author: Alex Bennée Date: Mon Nov 13 13:55:27 2017 + accel/tcg/translate-all: expand cpu_restore_state addr check We

Re: [Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Paolo Bonzini
On 01/12/2017 18:45, Gonglei (Arei) wrote: > I also think it's windows bug, the problem is that it doesn't occur on > xen platform. It's a race, it may just be that RTC PIO is faster in Xen because it's implemented in the hypervisor. I will try reporting it to Microsoft. Thanks, Paolo >

[Qemu-devel] [Bug 1735653] [NEW] qemu aarch64 cannot boot linux kernel v4.6+

2017-12-01 Thread Joey Jiao
Public bug reported: Hi, I tested the latest qemu-system-aarch64 cannot boot linux mainline kernel since v4.6 from https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. Environment info: # host ubuntu 16.04 # qemu Master branch from git://git.qemu.org/qemu.git, and now the HEAD

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: fix 197 for vpc

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 05:44:21PM -0500, John Snow wrote: > VPC has some difficulty creating geometries of particular size. > However, we can indeed force it to use a literal one, so let's > do that for the sake of test 197, which is testing some specific > offsets. > > Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Eric Blake
On 12/01/2017 06:58 AM, Juan Quintela wrote: Hi This is on top of my info_migrate series. Let patchew know about it: Based-on: <20171201125750.1372-1-quint...@redhat.com> ([PATCH v3 0/2] Improve info migrate output on destination) -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] /usr/bin/m4: internal error detected

2017-12-01 Thread Andreas Schwab
On Dez 01 2017, John Paul Adrian Glaubitz wrote: > This isn't a bug in m4 or anything architecture-specific, it's a regression > that was introduced by an upstream change in glibc [1] and mainly affects > qemu-user which we are using for m68k and sh4 [2]. It's a

Re: [Qemu-devel] [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Paolo Bonzini
On 01/12/2017 08:08, Gonglei (Arei) wrote: > First write to 0x70, cmos_index = 0xc & 0x7f = 0xc >    CPU 0/KVM-15566 kvm_pio: pio_write at 0x70 size 1 count 1 val 0xc> > Second write to 0x70, cmos_index = 0x86 & 0x7f = 0x6>    CPU 1/KVM-15567 > kvm_pio: pio_write at 0x70 size 1 count 1

Re: [Qemu-devel] [PATCH-2.12 v1 2/3] xilinx_spis: Set all of the reset values

2017-12-01 Thread Alistair Francis
On Wed, Nov 29, 2017 at 2:03 PM, francisco iglesias wrote: > > > On 28 November 2017 at 23:31, Alistair Francis > wrote: > > Dear Alistair, > > There is a typo in the commit message: > s/xilinx_spis/xilinx_spips/ > >> Following the ZynqMP

Re: [Qemu-devel] RFC: Let NBD client request read-only mode

2017-12-01 Thread Wouter Verhelst
On Thu, Nov 30, 2017 at 10:00:46AM -0600, Eric Blake wrote: > On 11/30/2017 09:32 AM, Wouter Verhelst wrote: > > > A client that wants to be read-only, but which does not see server support > > > (in idea 1, the server did not advertise the bit; in idea 2, the server > > > replies with

[Qemu-devel] [PULL 7/7] pc: fix crash on attempted cpu unplug

2017-12-01 Thread Michael S. Tsirkin
From: Igor Mammedov when qemu is started with '-no-acpi' CLI option, an attempt to unplug a CPU using device_del results in null pointer dereference at: #0 object_get_class #1 pc_machine_device_unplug_request_cb #2 qmp_marshal_device_del which is caused by

[Qemu-devel] [PULL 1/7] i386/msi: Correct mask of destination ID in MSI address

2017-12-01 Thread Michael S. Tsirkin
From: Chao Gao According to SDM 10.11.1, only [19:12] bits of MSI address are Destination ID, change the mask to avoid ambiguity for VT-d spec has used the bit 4 to indicate a remappable interrupt request. Signed-off-by: Chao Gao Signed-off-by: Lan

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] spapr.c: Update qemu's maxcpus for pseries machine.

2017-12-01 Thread Greg Kurz
On Fri, 1 Dec 2017 16:54:09 +0530 Seeteena Thoufeek wrote: > Need to adjust the max cpus supported number from error message since > it was conflicting with KVM's. > > Steps to Reproduce: > 1.boot up with > "-smp 64,maxcpus=102464,cores=8,threads=1,sockets=8" > >

[Qemu-devel] [PULL 6/7] virtio: check VirtQueue Vring object is set

2017-12-01 Thread Michael S. Tsirkin
From: Prasad J Pandit A guest could attempt to use an uninitialised VirtQueue object or unset Vring.align leading to a arithmetic exception. Add check to avoid it. Reported-by: Zhangboxian Signed-off-by: Prasad J Pandit

[Qemu-devel] [Bug 1735576] [NEW] Support more than 4G memory for guest with Intel HAXM acceleration

2017-12-01 Thread Hu Jun
Public bug reported: setup: host: windows 7 professional 64bit guest: centos 7 qemu 2.10.92 haxm 6.2.1 issue: when assign 4096M or more memory to the guest, I got following error message: E:\qemuvm\vm-svr>qemu-system-x86_64 -accel hax -hda centos-1.vdi -m 4096 HAX is working and emulator runs

Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()

2017-12-01 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > >

[Qemu-devel] [PULL 2/7] virtio: Add queue interface to restore avail index from vring used index

2017-12-01 Thread Michael S. Tsirkin
From: Maxime Coquelin In case of backend crash, it is not possible to restore internal avail index from the backend value as vhost_get_vring_base callback fails. This patch provides a new interface to restore internal avail index from the vring used index, as done by

[Qemu-devel] [PULL 4/7] dump-guest-memory.py: fix No symbol "vmcoreinfo_find"

2017-12-01 Thread Michael S. Tsirkin
From: Marc-André Lureau When qemu is compiled without debug, the dump gdb python script can fail with: Error occurred in Python command: No symbol "vmcoreinfo_find" in current context. Because vmcoreinfo_find() is inlined and not exported. Use the underlying

[Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-01 Thread Michael S. Tsirkin
The following changes since commit c11d61271b9e6e7a1f0479ef1ca8fb55fa457a62: Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH v4 16/20] vdi: Switch to .bdrv_co_block_status()

2017-12-01 Thread Eric Blake
On 11/30/2017 05:26 AM, Vladimir Sementsov-Ogievskiy wrote: 12.10.2017 21:59, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the vdi driver accordingly.  Note that the TODO is already covered (the block layer guarantees bounds of its

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Prasad Singamsetty
On 11/30/2017 8:43 PM, Peter Xu wrote: On Thu, Nov 30, 2017 at 11:12:48AM -0800, Prasad Singamsetty wrote: On 11/30/2017 10:56 AM, Michael S. Tsirkin wrote: On Thu, Nov 30, 2017 at 10:33:50AM -0800, Prasad Singamsetty wrote: On 11/29/2017 7:25 PM, Peter Xu wrote: On Wed, Nov 29, 2017

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Paolo Bonzini
Just my 2 cents on the language topic, as in general I agree completely with Stefan. On 01/12/2017 15:08, Stefan Hajnoczi wrote: > Rust's threading model is 1:1. Besides mutexes it also has channels > (looks similar to Go and communicating sequential processes-style > channels). > > It is

Re: [Qemu-devel] [PATCH v4 08/32] migration: allow send_rq to fail

2017-12-01 Thread Peter Xu
On Thu, Nov 30, 2017 at 12:13:57PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We will not allow failures to happen when sending data from destination > > to source via the return path. However it is possible that there can be > > errors along the way. This

Re: [Qemu-devel] [PATCH 1/2] hmp: block qemu-io command for device without media

2017-12-01 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 03:10:54PM +0300, Denis V. Lunev wrote: > In this case blk->bs == NULL and the code will just crash. Emulate error > on that path. > > Signed-off-by: Denis V. Lunev > CC: "Dr. David Alan Gilbert" > CC: Kevin Wolf >

Re: [Qemu-devel] [PATCH v4 31/32] migration, qmp: new command "migrate-pause"

2017-12-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It is used to manually trigger the postcopy pause state. It works just > like when we found the migration stream failed during postcopy, but > provide an explicit way for user in case of misterious socket hangs. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-12-01 Thread Deepa Srinivasan
Kevin, Paolo, Stefan, Are there any further comments on this patch? Can this patch be committed? Thanks Deepa > On Nov 23, 2017, at 8:55 AM, Deepa Srinivasan > wrote: > > Starting qemu with the following arguments causes qemu to segfault: > ... -device

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Prasad Singamsetty
On 11/29/2017 7:25 PM, Peter Xu wrote: On Wed, Nov 29, 2017 at 01:05:22PM -0800, Prasad Singamsetty wrote: Thanks Michael. Some comments below. On 11/28/2017 9:32 AM, Michael S. Tsirkin wrote: On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com wrote: From: Prasad

Re: [Qemu-devel] [PATCH for-2.12] iotests: Make 200 run on tmpfs

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 04:59:42PM +0100, Max Reitz wrote: > 200 currently fails on tmpfs because it sets cache=none. However, > without that (and aio=native), the test still works now and it fails > before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So > we can probably remove

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-12-01 Thread Halil Pasic
On 11/30/2017 02:32 PM, Cornelia Huck wrote: > On Thu, 30 Nov 2017 13:32:12 +0100 > Halil Pasic wrote: > > (...) > > Before I spend way too much time on this: > > Is the proposed machine-property interface usable from a libvirt POV? > IOW, can we go with this now

  1   2   3   >