[Qemu-devel] [Bug 1740364] Re: qemu-img: fails to get shared 'write' lock

2018-01-04 Thread Yaniv Kaul
Thanks for the explanation, I thought it might be related, but: 1. The command executed is: qemu-img create -f qcow2 -o backing_file=/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-1_root.qcow2 /tmp/libguestfsWrA7Dh/overlay1.qcow2 And the

Re: [Qemu-devel] [virtio-dev] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

2018-01-04 Thread Liang, Cunming
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, January 4, 2018 3:22 PM > To: Bie, Tiwei > Cc: Tan, Jianfeng ; virtio-...@lists.oasis-open.org; > m...@redhat.com; Liang, Cunming

[Qemu-devel] [PATCH 2/2] qemu-img: info: try -U automatically

2018-01-04 Thread Fam Zheng
The error message we had didn't have a hint about "-U" when locking the image failed, which is not friendly. Also it is imaginable that the reaction to that error by the user would be a retry with '-U'. So the reason we require "-U" for "qemu-img info" if the image is used is to raise the

[Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-04 Thread Fam Zheng
Management and users are accustomed to "qemu-img info" to query status of images even when they are used by guests. Since image locking was added, the -U (--force-share) option is needed for that to work. The reason has been that due to possible race with image header update, the output can be

[Qemu-devel] [PATCH 1/2] qemu-img: Move img_open error reporting to callers

2018-01-04 Thread Fam Zheng
In the next patch one caller will have a special error handling logic than reporting it, add "Error **" parameters to functions and give control back to callers, to make that possible. Update iotests output accordingly. Signed-off-by: Fam Zheng --- qemu-img.c |

Re: [Qemu-devel] [PATCH v1 10/21] RISC-V Linux User Emulation

2018-01-04 Thread Michael Clark
On Thu, Jan 4, 2018 at 12:47 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 01/02/2018 04:44 PM, Michael Clark wrote: > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > > index 20f3d8c..178af56 100644 > > --- a/linux-user/elfload.c > > +++ b/linux-user/elfload.c > >

Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure

2018-01-04 Thread Michael Clark
On Thu, Jan 4, 2018 at 12:23 PM, Eric Blake wrote: > On 01/02/2018 06:44 PM, Michael Clark wrote: > > This adds RISC-V into the build system enabling the following targets: > > > > - riscv32-softmmu > > - riscv64-softmmu > > - riscv32-linux-user > > - riscv64-linux-user > > >

Re: [Qemu-devel] [PATCH v1 17/21] SiFive RISC-V UART Device

2018-01-04 Thread Michael Clark
On Thu, Jan 4, 2018 at 3:57 AM, KONRAD Frederic wrote: > Hi all, > > > On 01/03/2018 01:44 AM, Michael Clark wrote: > >> QEMU model of the UART on the SiFive E300 and U500 series SOCs. >> BBL supports the SiFive UART for early console access via the SBI >>

Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure

2018-01-04 Thread Michael Clark
On Fri, 5 Jan 2018 at 5:55 AM, Antony Pavlov wrote: > On Wed, 3 Jan 2018 13:44:25 +1300 > Michael Clark wrote: > > > This adds RISC-V into the build system enabling the following targets: > > > > - riscv32-softmmu > > - riscv64-softmmu > > -

Re: [Qemu-devel] [PATCH v3 07/16] piix4: add a i8259 interrupt controller as specified in datasheet

2018-01-04 Thread Hervé Poussineau
Le 05/01/2018 à 00:21, Michael S. Tsirkin a écrit : On Fri, Dec 29, 2017 at 03:29:13PM +0100, Hervé Poussineau wrote: Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also remove the now unused

Re: [Qemu-devel] [PATCH v1 17/21] SiFive RISC-V UART Device

2018-01-04 Thread Michael Clark
On Fri, 5 Jan 2018 at 9:53 AM, Antony Pavlov wrote: > On Wed, 3 Jan 2018 13:44:21 +1300 > Michael Clark wrote: > > > QEMU model of the UART on the SiFive E300 and U500 series SOCs. > > BBL supports the SiFive UART for early console access via the SBI >

Re: [Qemu-devel] [PATCH v1 03/21] RISC-V CPU Core Definition

2018-01-04 Thread Michael Clark
On Fri, 5 Jan 2018 at 6:39 AM, Antony Pavlov wrote: > On Thu, 4 Jan 2018 20:33:57 +1300 > Michael Clark wrote: > > > On Thu, Jan 4, 2018 at 7:47 PM, Antony Pavlov > > wrote: > > > > > On Wed, 3 Jan 2018 13:44:07 +1300 > > >

[Qemu-devel] [PATCHv2] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread David Gibson
Currently the pseries machine sets the compatibility mode for the guest's cpus in two places: 1) at machine reset and 2) after CAS negotiation. This means that if we set or negotiate a compatiblity mode, then hotplug a cpu, the hotplugged cpu doesn't get the right mode set and will incorrectly

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread David Gibson
On Thu, Jan 04, 2018 at 03:11:03PM -0600, Michael Roth wrote: > Quoting Greg Kurz (2018-01-04 11:47:18) > > On Thu, 4 Jan 2018 15:24:05 +1100 > > David Gibson wrote: > > > > > Currently the pseries machine sets the compatibility mode for the > > > guest's cpus in

Re: [Qemu-devel] [PATCH v2] Update dtc to fix compilation problem on Mac OS 10.6

2018-01-04 Thread David Gibson
On Thu, Jan 04, 2018 at 02:49:52PM -0500, John Arbuckle wrote: > Currently QEMU does not build on Mac OS 10.6 > because of a missing patch in the dtc > subproject. Updating dtc to make the patch > available fixes this problem. > > Signed-off-by: John Arbuckle Applied,

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread David Gibson
On Thu, Jan 04, 2018 at 06:47:18PM +0100, Greg Kurz wrote: > On Thu, 4 Jan 2018 15:24:05 +1100 > David Gibson wrote: > > > Currently the pseries machine sets the compatibility mode for the > > guest's cpus in two places: 1) at machine reset and 2) after CAS > >

[Qemu-devel] [Bug 1740364] Re: qemu-img: fails to get shared 'write' lock

2018-01-04 Thread Ping Li
The behaviour should be expected. Since qemu 2.10, image locking is enabled which make multiple QEMU processes cannot write to the same image, even if boot snapshot and backing file at the same time are not allowed. You could get image info with the option "-U" as below: $qemu-img info -U

Re: [Qemu-devel] [PATCH] qga: unset frozen state if no mount points are frozen

2018-01-04 Thread Chen Hanxiao
At 2017-12-16 15:34:17, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >If we set mountpoints to qmp_guest_fsfreeze_freeze_list, >we may got nothing to freeze as all mountpoints are >not valid. >Call ga_unset_frozen in this senario. > >Cc: Michael

Re: [Qemu-devel] [PATCH] scsi: Don't deference in_buf if NULL

2018-01-04 Thread Fam Zheng
On Thu, 01/04 11:41, Eric Blake wrote: > On 01/03/2018 08:42 PM, Fam Zheng wrote: > > scsi_disk_emulate_command passes in_buf=NULL and in_len=0 in the > > REQUEST_SENSE branch. Inline the fixed_in evaluation and put it after > > the in_len test. > > > > Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-04 Thread Eric Blake
On 01/03/2018 03:38 AM, Juan Quintela wrote: > Hi > > This are the changes for migration that are already reviewed. > > Please, apply. > > Alexey Perevalov (6): > migration: introduce postcopy-blocktime capability > migration: add postcopy blocktime ctx into MigrationIncomingState

Re: [Qemu-devel] [PATCH v3 00/16] piix4: cleanup and improvements

2018-01-04 Thread Michael S. Tsirkin
On Fri, Dec 29, 2017 at 03:29:06PM +0100, Hervé Poussineau wrote: > Hi, > > This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices > are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices > belong. This lets us reuse PIIX4 in other machines, while not loosing

Re: [Qemu-devel] [PATCH v3 07/16] piix4: add a i8259 interrupt controller as specified in datasheet

2018-01-04 Thread Michael S. Tsirkin
On Fri, Dec 29, 2017 at 03:29:13PM +0100, Hervé Poussineau wrote: > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() function. > > Signed-off-by: Hervé

[Qemu-devel] [PATCH] isa/piix: move to mips

2018-01-04 Thread Michael S. Tsirkin
This device is only used on mips, move to the correct maintainer section. Cc: Aurelien Jarno Cc: Yongbok Kim Cc: Hervé Poussineau Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v10 0/4] Introduce a new vhost-user-blk host device to QEMU

2018-01-04 Thread Michael S. Tsirkin
On Thu, Jan 04, 2018 at 12:07:39PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Jan 4, 2018 at 2:53 AM, Changpeng Liu wrote: > > Although virtio scsi specification was designed as a replacement for > > virtio_blk, > > there are still many users using virtio_blk.

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Programmingkid
> On Jan 4, 2018, at 2:52 PM, Laurent Vivier wrote: > > Le 04/01/2018 à 20:26, Programmingkid a écrit : >> >>> On Jan 4, 2018, at 12:32 PM, Laurent Vivier wrote: >>> >>> Le 04/01/2018 à 18:09, Programmingkid a écrit : What operating systems boot

Re: [Qemu-devel] [PATCH v3 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-04 Thread Daniel Henrique Barboza
On 01/04/2018 08:00 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2018-01-03 05:54:54) When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the

[Qemu-devel] Some linux kernel with KAISER/KPTI patch can't work under qemu + haxm.

2018-01-04 Thread lepton
It seems for some reason, some linux kernel with KAISER/KPTI patch can't work with qemu + haxm. The mainline kernel from Linus is fine. But the patch to 4.4/4.10 doesn't work. I am not familiar with HAXM and KPTI either. so not sure if this is a qemu bug or KPTI bug or haxm bug. The same kernel

Re: [Qemu-devel] [PATCH v3 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-04 Thread Michael Roth
Quoting Daniel Henrique Barboza (2018-01-03 05:54:54) > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system

Re: [Qemu-devel] [PATCH v3 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-01-04 Thread Michael Roth
Quoting Daniel Henrique Barboza (2018-01-03 05:54:55) > This patch updates the descriptions of 'guest-suspend-ram' and > 'guest-suspend-hybrid' to mention that both commands relies now > on the existence of 'system_wakeup' and also on the proper support > for wake up from suspend, retrieved by the

Re: [Qemu-devel] [PATCH] TPM: add CRB device

2018-01-04 Thread Stefan Berger
On 01/04/2018 11:02 AM, Marc-André Lureau wrote: Hi - Original Message - On 12/22/2017 09:55 AM, Marc-André Lureau wrote: tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread Michael Roth
Quoting Greg Kurz (2018-01-04 11:47:18) > On Thu, 4 Jan 2018 15:24:05 +1100 > David Gibson wrote: > > > Currently the pseries machine sets the compatibility mode for the > > guest's cpus in two places: 1) at machine reset and 2) after CAS > > negotiation. > > > >

Re: [Qemu-devel] [PATCH v1 17/21] SiFive RISC-V UART Device

2018-01-04 Thread Antony Pavlov
On Wed, 3 Jan 2018 13:44:21 +1300 Michael Clark wrote: > QEMU model of the UART on the SiFive E300 and U500 series SOCs. > BBL supports the SiFive UART for early console access via the SBI > (Supervisor Binary Interface) and the linux kernel SBI console. > > The SiFive UART

Re: [Qemu-devel] [PATCH v3 06/16] piix4: add Reset Control Register

2018-01-04 Thread Hervé Poussineau
Le 04/01/2018 à 16:50, Marcel Apfelbaum a écrit : On 29/12/2017 16:29, Hervé Poussineau wrote: The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. Signed-off-by: Hervé Poussineau ---   hw/isa/piix4.c | 35 +++   1

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Stefan Hajnoczi
Thanks Paolo and Eduardo. I have posted the link on QEMU's Google+ page. Stefan

Re: [Qemu-devel] [PATCH v3 05/16] piix4: rename some variables in realize function

2018-01-04 Thread Hervé Poussineau
Le 04/01/2018 à 15:33, Marcel Apfelbaum a écrit : On 29/12/2017 16:29, Hervé Poussineau wrote: PIIX4 structure is now 's' PCI device is now 'pci' Please don't use 'pci'. Use pci_dev', the former is too wide, OK, will do. Thanks, Marcel DeviceState is now 'dev' Signed-off-by: Hervé

Re: [Qemu-devel] [PATCH v3 04/16] mc146818rtc: always register rtc to rtc list

2018-01-04 Thread Hervé Poussineau
Le 04/01/2018 à 15:30, Marcel Apfelbaum a écrit : On 29/12/2017 16:29, Hervé Poussineau wrote: We are not required anymore to use rtc_init() function. Signed-off-by: Hervé Poussineau ---   hw/timer/mc146818rtc.c | 13 -   1 file changed, 8 insertions(+), 5

Re: [Qemu-devel] [PATCH v3 01/16] fdc: move object structures to header file

2018-01-04 Thread Hervé Poussineau
Le 04/01/2018 à 14:11, Marcel Apfelbaum a écrit : On 29/12/2017 16:29, Hervé Poussineau wrote: We are now able to embed floppy controllers in another object. Hi Hervé, Are you sure we need to move all the struct definitions to the header file? I looked at patch 11/16 and it seems only

[Qemu-devel] [Bug 1727259] Re: qemu-io-test 58 segfaults when configured with gcov

2018-01-04 Thread Murilo Opsfelder Araújo
I'll work on this. ** Changed in: qemu Assignee: (unassigned) => Murilo Opsfelder Araújo (mopsfelder) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1727259 Title: qemu-io-test 58 segfaults

Re: [Qemu-devel] CVE-2017-5715: relevant qemu patches

2018-01-04 Thread Stefan Priebe - Profihost AG
attached the relevant patch for everybody who needs it. Greets, Stefan Am 04.01.2018 um 16:53 schrieb Paolo Bonzini: > On 04/01/2018 09:35, Alexandre DERUMIER wrote: So you need: 1.) intel / amd cpu microcode update 2.) qemu update to pass the new MSR and CPU flags from the

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Programmingkid
> On Jan 4, 2018, at 2:52 PM, Laurent Vivier wrote: > > Le 04/01/2018 à 20:26, Programmingkid a écrit : >> >>> On Jan 4, 2018, at 12:32 PM, Laurent Vivier wrote: >>> >>> Le 04/01/2018 à 18:09, Programmingkid a écrit : What operating systems boot

Re: [Qemu-devel] [PATCH RFC 1/1] tests: Add migration test for aarch64

2018-01-04 Thread Juan Quintela
Wei Huang wrote: > This patch adds the migration test support for aarch64. The test code, > which implements the same functionality as x86, is compiled into a binary > and booted as a kernel to qemu. Here are the design ideas: > > * We choose this -kernel design because aarch64

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Laurent Vivier
Le 04/01/2018 à 20:26, Programmingkid a écrit : > >> On Jan 4, 2018, at 12:32 PM, Laurent Vivier wrote: >> >> Le 04/01/2018 à 18:09, Programmingkid a écrit : >>> What operating systems boot with this patch set? Does any version of the >>> Mac OS run in this 68k emulator? >>>

[Qemu-devel] [PATCH v2] Update dtc to fix compilation problem on Mac OS 10.6

2018-01-04 Thread John Arbuckle
Currently QEMU does not build on Mac OS 10.6 because of a missing patch in the dtc subproject. Updating dtc to make the patch available fixes this problem. Signed-off-by: John Arbuckle --- v2 changes: Updated the commit to point to version 1.4.6. dtc | 2 +- 1 file

Re: [Qemu-devel] [PATCH v2 00/25] SDCard: housekeeping, improve SPI, introduce new Specs

2018-01-04 Thread Philippe Mathieu-Daudé
>> As noted by Kevin here: >> http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02765.html >> >> If your machine has a PCI bus you can plug it there: >> http://pcidb.net/view/1b36/0007 >> >> Linux kmod 'sdhci-pci' recognize it well. >> >> I don't know if OSX/Win guests have a such driver.

Re: [Qemu-devel] [PATCH v2 00/25] SDCard: housekeeping, improve SPI, introduce new Specs

2018-01-04 Thread Programmingkid
> On Jan 4, 2018, at 12:57 PM, Philippe Mathieu-Daudé wrote: > > Hi John, > >> Is there a way to make this SD card reader work with Mac OS X or Windows >> guests? > > As noted by Kevin here: > http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02765.html > > If your

Re: [Qemu-devel] [PATCH v4 01/25] sdhci: add a spec_version property

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 02:51 PM, Alistair Francis wrote: > On Wed, Jan 3, 2018 at 10:33 AM, Philippe Mathieu-Daudé > wrote: >> default to Spec v2.00 >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/sdhci-internal.h | 4 ++-- >> include/hw/sd/sdhci.h | 3

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Jason Baron via Qemu-devel
On 01/04/2018 01:22 PM, Michael S. Tsirkin wrote: > On Thu, Jan 04, 2018 at 01:12:30PM -0500, Jason Baron wrote: >> >> >> On 01/04/2018 12:05 PM, Michael S. Tsirkin wrote: >>> On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: The ability to set speed and duplex for virtio_net is

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Programmingkid
> On Jan 4, 2018, at 12:32 PM, Laurent Vivier wrote: > > Le 04/01/2018 à 18:09, Programmingkid a écrit : >> What operating systems boot with this patch set? Does any version of the Mac >> OS run in this 68k emulator? >> > > For the moment you can't boot anything more than

Re: [Qemu-devel] [RFC PATCH 0/6] qom: introduce TypeInfo name aliases

2018-01-04 Thread Eduardo Habkost
On Thu, Jan 04, 2018 at 11:40:40AM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > This RFC series is intended to simplify Flattened Device Tree support, > in particular the 'compatible' FDT entry, when Linux names mismatches > QEMU ones, but this is the same device modelled. > > Eventually this

Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-04 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 03/01/2018 19:33, Dr. David Alan Gilbert (git) wrote: > > The optimised version operates on 'longs' dealing with (typically) 64 > > pages at a time, replacing the whole long by a 0 and counting the bits. > > If the Ramblock is less than 64bits in

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Michael S. Tsirkin
On Thu, Jan 04, 2018 at 08:22:08PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 04, 2018 at 01:12:30PM -0500, Jason Baron wrote: > > > > > > On 01/04/2018 12:05 PM, Michael S. Tsirkin wrote: > > > On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: > > >> The ability to set speed and

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Alexandre DERUMIER
Thanks Paolo ! Do we need to update guest kernel too, if qemu use cpumodel=qemu64 ? (For example, I have some very old guests where kernel update is not possible) Regards, Alexandre - Mail original - De: "pbonzini" À: "qemu-devel" Cc:

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Michael S. Tsirkin
On Thu, Jan 04, 2018 at 01:12:30PM -0500, Jason Baron wrote: > > > On 01/04/2018 12:05 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: > >> The ability to set speed and duplex for virtio_net is useful in various > >> scenarios as described here: >

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-04 Thread Keith Busch
On Mon, Dec 18, 2017 at 02:00:43PM +0900, Hikaru Nishida wrote: > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_pulse(). Looks good. Thanks

Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

2018-01-04 Thread Juan Quintela
Peter Xu wrote: >> @@ -1659,6 +1662,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const >> QDict *qdict) >> } >> p->xbzrle_cache_size = cache_size; >> break; >> +case MIGRATION_PARAMETER_TCP_PORT: >> +p->has_tcp_port = true; >> +

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 19:13, Alexandre DERUMIER wrote: > Thanks Paolo ! > > Do we need to update guest kernel too, if qemu use cpumodel=qemu64 ? > > (For example, I have some very old guests where kernel update is not > possible) If you want to be protected against the other two CVEs (one of which is

Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

2018-01-04 Thread Juan Quintela
Eric Blake wrote: > On 12/01/2017 06:57 AM, Juan Quintela wrote: >> It will be used to store the uri tcp_port parameter. This is the only >> parameter than can change and we can need to be able to connect to it. >> >> Signed-off-by: Juan Quintela >> >> --

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Jason Baron via Qemu-devel
On 01/04/2018 12:05 PM, Michael S. Tsirkin wrote: > On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: >> The ability to set speed and duplex for virtio_net is useful in various >> scenarios as described here: >> >> 16032be virtio_net: add ethtool support for set and get of settings >>

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-04 Thread Hikaru Nishida
ping... 2017-12-22 16:31 GMT+09:00 Hikaru Nishida : > ping > http://patchwork.ozlabs.org/patch/849786/ > > 2017-12-18 14:00 GMT+09:00 Hikaru Nishida : >> Pin-based interrupt of NVMe controller did not work properly >> because using an obsolated function

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 18:57:18 +0100, wrote: > On 04/01/2018 18:45, Samuel Thibault wrote: > > Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: > >> On 04/01/2018 16:56, Samuel Thibault wrote: > However, adding magic to "-device usb-braille" that creates both a >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread Daniel Henrique Barboza
On 01/04/2018 02:24 AM, David Gibson wrote: Currently the pseries machine sets the compatibility mode for the guest's cpus in two places: 1) at machine reset and 2) after CAS negotiation. This means that if we set or negotiate a compatiblity mode, then s/compatiblity/compatibility hotplug

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 18:56, Paolo Bonzini wrote: > --- > _posts/2018-01-04-spectre.md | 60 > > 1 file changed, 60 insertions(+) > create mode 100644 _posts/2018-01-04-spectre.md Something on TCG ("it is not considered a security boundary, so it's

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Eduardo Habkost
On Thu, Jan 04, 2018 at 06:56:09PM +0100, Paolo Bonzini wrote: > --- > _posts/2018-01-04-spectre.md | 60 > > 1 file changed, 60 insertions(+) > create mode 100644 _posts/2018-01-04-spectre.md Thanks for writing it up! Reviewed-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v2 00/25] SDCard: housekeeping, improve SPI, introduce new Specs

2018-01-04 Thread Philippe Mathieu-Daudé
Hi John, > Is there a way to make this SD card reader work with Mac OS X or Windows > guests? As noted by Kevin here: http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02765.html If your machine has a PCI bus you can plug it there: http://pcidb.net/view/1b36/0007 Linux kmod

Re: [Qemu-devel] [PATCH v5 07/17] sdhci: refactor common sysbus/pci unrealize() into sdhci_common_unrealize()

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:07 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c >

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 18:45, Samuel Thibault wrote: > Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: >> On 04/01/2018 16:56, Samuel Thibault wrote: However, adding magic to "-device usb-braille" that creates both a front-end and a back-end is completely the opposite of sane... >>>

Re: [Qemu-devel] [PATCH v5 05/17] sdhci: refactor common sysbus/pci class_init() into sdhci_common_class_init()

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:07 AM, Philippe Mathieu-Daudé wrote: > Now both inherited classes appear as DEVICE_CATEGORY_STORAGE. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [Qemu-devel] [PATCH v5 04/17] sdhci: refactor same sysbus/pci properties into a common one

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:07 AM, Philippe Mathieu-Daudé wrote: > Now both sysbus/pci classes inherit of the 'pending-insert-quirk' property, > which is a HCI dependent property (regardless if accessed through a MMIO > sysbus or a PCI bus). > So far only the BCM implementation has

[Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-01-04 Thread Andreas Gustafsson
slirp: disable Nagle in outgoing connections When setting up an outgoing user mode networking TCP connection, disable the Nagle algorithm in the host-side connection. Either the guest is already doing Nagle, in which case there is no point in doing it twice, or it has chosen to disable it, in

[Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-04 Thread Paolo Bonzini
--- _posts/2018-01-04-spectre.md | 60 1 file changed, 60 insertions(+) create mode 100644 _posts/2018-01-04-spectre.md diff --git a/_posts/2018-01-04-spectre.md b/_posts/2018-01-04-spectre.md new file mode 100644 index 000..1be86d0 --- /dev/null

Re: [Qemu-devel] [PATCH v5 12/17] sdhci: use FIELD_DP32() macro for the WRITE_PROTECT flag

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:08 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci-internal.h | 6 -- > hw/sd/sdhci.c | 8 ++-- > 2

Re: [Qemu-devel] [PATCH v5 06/17] sdhci: refactor common sysbus/pci realize() into sdhci_common_realize()

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:07 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > Since previous series failed, I dropped: > > Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH v4 01/25] sdhci: add a spec_version property

2018-01-04 Thread Alistair Francis
On Wed, Jan 3, 2018 at 10:33 AM, Philippe Mathieu-Daudé wrote: > default to Spec v2.00 > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci-internal.h | 4 ++-- > include/hw/sd/sdhci.h | 3 +++ > hw/sd/sdhci.c | 19 +-- > 3

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread Greg Kurz
On Thu, 4 Jan 2018 15:24:05 +1100 David Gibson wrote: > Currently the pseries machine sets the compatibility mode for the > guest's cpus in two places: 1) at machine reset and 2) after CAS > negotiation. > > This means that if we set or negotiate a compatiblity

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: > On 04/01/2018 16:56, Samuel Thibault wrote: > >> However, adding magic to "-device usb-braille" that creates both a > >> front-end and a back-end is completely the opposite of sane... > > Well, this is also what happens with -device

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Eric Blake
On 01/04/2018 06:44 AM, Thomas Huth wrote: > On 04.01.2018 13:33, Peter Maydell wrote: >> On 4 January 2018 at 12:27, Thomas Huth wrote: >>> The option has been marked as deprecated since QEMU 2.10, and so far >>> nobody complained that it is urgently required anymore. So let's

Re: [Qemu-devel] [PATCH] scsi: fix scsi_convert_sense crash when in_buf == NULL && in_len == 0

2018-01-04 Thread Eric Blake
On 12/22/2017 09:55 AM, Paolo Bonzini wrote: > scsi_disk_emulate_command passes in_buf == NULL when sent a REQUEST > SENSE command. Check for in_len == 0 before dereferencing in_buf. > > Fixes: f68d98b21fa74155dc7c1fd212474379ac3c7531 > Reported-by: Roman Kagan >

Re: [Qemu-devel] [PATCH] scsi: Don't deference in_buf if NULL

2018-01-04 Thread Eric Blake
On 01/03/2018 08:42 PM, Fam Zheng wrote: > scsi_disk_emulate_command passes in_buf=NULL and in_len=0 in the > REQUEST_SENSE branch. Inline the fixed_in evaluation and put it after > the in_len test. > > Signed-off-by: Fam Zheng > --- > scsi/utils.c | 4 +--- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v1 03/21] RISC-V CPU Core Definition

2018-01-04 Thread Antony Pavlov
On Thu, 4 Jan 2018 20:33:57 +1300 Michael Clark wrote: > On Thu, Jan 4, 2018 at 7:47 PM, Antony Pavlov > wrote: > > > On Wed, 3 Jan 2018 13:44:07 +1300 > > Michael Clark wrote: > > > > > Add CPU state header, CPU definitions and

[Qemu-devel] [PATCH] oslib-posix: check for posix_memalign in configure script

2018-01-04 Thread Andreas Gustafsson
Check for the presence of posix_memalign() in the configure script, not using "defined(_POSIX_C_SOURCE) && !defined(__sun__)". This lets qemu use posix_memalign() on NetBSD versions that have it, instead of falling back to valloc() which is wasteful when the required alignment is smaller than a

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Laurent Vivier
Le 04/01/2018 à 18:09, Programmingkid a écrit : > What operating systems boot with this patch set? Does any version of the Mac > OS run in this 68k emulator? > For the moment you can't boot anything more than the coldfire linux kernel with the semi-hosting patch. The remaining patches I have

Re: [Qemu-devel] [PATCH v3 11/18] tests: fix migration-test leak

2018-01-04 Thread Juan Quintela
Marc-Andre Lureau wrote: > Direct leak of 12 byte(s) in 2 object(s) allocated from: > #0 0x7f50d403c850 in malloc (/lib64/libasan.so.4+0xde850) > #1 0x7f50d1ddf98f in vasprintf (/lib64/libc.so.6+0x8098f) > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PULL v3 05/35] test-bdrv-drain: Test BlockDriver callbacks for drain

2018-01-04 Thread Eric Blake
On 12/22/2017 09:18 AM, Kevin Wolf wrote: > This adds a test case that the BlockDriver callbacks for drain are > called in bdrv_drained_all_begin/end(), and that both of them are called > exactly once. > > Signed-off-by: Kevin Wolf > Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 06/18] tests/docker: add test-debug

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > Add a new test with --enable-debug using clang/asan/ubsan, remove > --enable-debug from test-clang & test-mingw. > > Signed-off-by: Marc-André Lureau > --- > tests/docker/test-clang | 2 +- >

Re: [Qemu-devel] [PATCH v3 00/18] Various build-sys and sanitizer related fixes

2018-01-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180104160523.22995-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/18] Various build-sys and sanitizer related fixes === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:59, Thomas Huth wrote: > > But instead of introducing a new "-braille" parameter, maybe we should > rather keep some of the convenience "-usbdevice" possibilities around? > E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but remove > things like "-usbdevice serial" and

Re: [Qemu-devel] [PATCH v3 04/18] build-sys: compile with -Og or -O1 when --enable-debug

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > When --enable-debug is turned on, configure doesn't set -O level, and > uses default compiler -O0 level, which is slow. > > Instead, use -Og if supported by the compiler (optimize debugging > experience), or -O1 (keeps code somewhat debuggable

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:56, Samuel Thibault wrote: >> However, adding magic to "-device usb-braille" that creates both a >> front-end and a back-end is completely the opposite of sane... > Well, this is also what happens with -device usb-mouse, usb-kbd etc.: > they also plug with keyboard & mouse pipes

Re: [Qemu-devel] [PATCH v3 05/18] tests/docker: add some sanitizers to fedora dockerfile

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > Build fedora image with ASAN/UBSan support. > > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH RESEND V3 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-01-04 Thread Eric Blake
On 01/04/2018 12:01 AM, Zhang Chen wrote: > From: zhanghailiang > > If some errors happen during VM's COLO FT stage, it's important to > notify the users of this event. Together with 'x_colo_lost_heartbeat', Isn't that spelled x-colo-lost-heartbeat in QMP? >

Re: [Qemu-devel] [PATCH v3 12/18] crypto: fix stack-buffer-overflow error

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 01:40 PM, Thomas Huth wrote: > On 04.01.2018 17:05, Marc-André Lureau wrote: >> ASAN complains about: >> >> ==8856==ERROR: AddressSanitizer: stack-buffer-overflow on address >> 0x7ffd8a1fe168 at pc 0x561136cb4451 bp 0x7ffd8a1fe130 sp 0x7ffd8a1fd8e0 >> READ of size 16 at

Re: [Qemu-devel] [PATCH] scsi: Don't deference in_buf if NULL

2018-01-04 Thread Eric Blake
On 01/03/2018 08:42 PM, Fam Zheng wrote: > scsi_disk_emulate_command passes in_buf=NULL and in_len=0 in the > REQUEST_SENSE branch. Inline the fixed_in evaluation and put it after > the in_len test. > > Signed-off-by: Fam Zheng > --- > scsi/utils.c | 4 +--- > 1 file changed, 1

Re: [Qemu-devel] [PULL 00/17] M68k for 2.12 patches

2018-01-04 Thread Programmingkid
What operating systems boot with this patch set? Does any version of the Mac OS run in this 68k emulator?

Re: [Qemu-devel] [PATCH v3 07/18] build-sys: add some sanitizers when --enable-debug if possible

2018-01-04 Thread Philippe Mathieu-Daudé
On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > Enable ASAN/UBSan by default if the compiler supports it. > > Typical slowdown introduced by AddressSanitizer is 2x. > UBSan shouldn't have much impact on runtime cost. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Jason Baron via Qemu-devel
On 01/04/2018 11:27 AM, Michael S. Tsirkin wrote: > On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: >> The ability to set speed and duplex for virtio_net is useful in various >> scenarios as described here: >> >> 16032be virtio_net: add ethtool support for set and get of settings >>

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Michael S. Tsirkin
On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: > The ability to set speed and duplex for virtio_net is useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able to set this from

Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure

2018-01-04 Thread Antony Pavlov
On Wed, 3 Jan 2018 13:44:25 +1300 Michael Clark wrote: > This adds RISC-V into the build system enabling the following targets: > > - riscv32-softmmu > - riscv64-softmmu > - riscv32-linux-user > - riscv64-linux-user > ... > diff --git a/default-configs/riscv32-softmmu.mak

Re: [Qemu-devel] vhost-user graceful connect/disconnect

2018-01-04 Thread Michael S. Tsirkin
On Tue, Dec 19, 2017 at 04:21:51PM +, Stefan Hajnoczi wrote: > Hi, > Vhost-user implementations assume the slave is already running before > the master starts. The slave is required during virtio device > initialization (e.g. feature bit negotiation) and so it is simplest to > assume that the

Re: [Qemu-devel] [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Michael S. Tsirkin
On Thu, Jan 04, 2018 at 11:57:44AM -0500, Jason Baron wrote: > > > On 01/04/2018 11:27 AM, Michael S. Tsirkin wrote: > > On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: > >> The ability to set speed and duplex for virtio_net is useful in various > >> scenarios as described here: >

[Qemu-devel] [PULL 12/17] target/m68k: implement fsave/frestore

2018-01-04 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180104012913.30763-13-laur...@vivier.eu> --- target/m68k/translate.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git

  1   2   3   >