[Qemu-devel] [Bug 1173490] Re: virtio net adapter driver with kvm slow on winxp

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 939027] Re: Combining direct_io and non-direct_io leads to hang

2018-01-10 Thread Avleen Vig
Unfortunately I don't have access to a qemu instance to test this any more :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/939027 Title: Combining direct_io and non-direct_io leads to hang

[Qemu-devel] [Bug 1151986] Re: buffer overflow after block-stream via QMP

2018-01-10 Thread Thomas Huth
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1151986 Title: buffer overflow after block-stream via QMP Status in QEMU: Fix Released Bug

[Qemu-devel] [Bug 1162644] Re: qemu-system-x86_64 crashed with SIGABRT in __assert_fail_base()

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1156632] Re: not receiving RESET event after system_reset command causes QMP connection to die

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1122492] Re: qemu and grub2 rescue floppy don't get along

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1129957] Re: Performance issue running quest image on qemu compiled for Win32 platform

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU and the latest version of MinGW? Do you also see the problem with the builds from https://qemu.weilnetz.de/ ? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete

[Qemu-devel] [Bug 1090726] Re: qemu does not generate guest cpu topology properly

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v4 0/5] Add a valid_cpu_types property

2018-01-10 Thread Eduardo Habkost
On Wed, Jan 10, 2018 at 01:30:29PM -0800, Alistair Francis wrote: > On Thu, Dec 28, 2017 at 6:59 AM, Eduardo Habkost wrote: > > On Thu, Dec 28, 2017 at 02:39:31PM +0100, Igor Mammedov wrote: > >> On Fri, 22 Dec 2017 11:47:00 -0800 > >> Alistair Francis

[Qemu-devel] [Bug 1086745] Re: serial port data THRE comes too early

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 939027] Re: Combining direct_io and non-direct_io leads to hang

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2018-01-10 Thread Thomas Huth
The fix had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e1f7b4812eab992de46c98b ... so closing this bug now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1055090] Re: esp error: NetBSD/sparc on qemu-system-sparc

2018-01-10 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU (and NetBSD)? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v4 0/5] Add a valid_cpu_types property

2018-01-10 Thread Alistair Francis
On Thu, Dec 28, 2017 at 6:59 AM, Eduardo Habkost wrote: > On Thu, Dec 28, 2017 at 02:39:31PM +0100, Igor Mammedov wrote: >> On Fri, 22 Dec 2017 11:47:00 -0800 >> Alistair Francis wrote: >> >> > On Fri, Dec 22, 2017 at 10:45 AM, Alistair Francis

Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2018-01-10 Thread Jack Schwartz
Hi Kevin. Thanks for your feedback. Looks like my team's project plans have changed, and there is no need to pursue this further.  We can work with the existing reason string.     Thanks,     Jack On 01/09/18 02:24, Kevin Wolf wrote: Am 08.01.2018 um 20:57 hat Jack Schwartz

Re: [Qemu-devel] [PATCH 6/6] target/m68k: add HMP command "info tlb"

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > Dump MMU state and address mappings. > > Signed-off-by: Laurent Vivier > --- Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 5/6] target/m68k: add pflush/ptest

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > target/m68k/cpu.h | 3 +++ > target/m68k/helper.c| 72 > + > target/m68k/helper.h| 2 ++ > target/m68k/monitor.c | 1 + >

Re: [Qemu-devel] [PATCH 4/6] target/m68k: add moves

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > and introduce SFC and DFC control registers. > > Signed-off-by: Laurent Vivier The patch is correct, so Reviewed-by: Richard Henderson However... > +void HELPER(moves_store)(CPUM68KState *env,

Re: [Qemu-devel] [PATCH 3/6] target/m68k: add Transparent Translation

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > Add ittr0, ittr1, dttr0, dttr1 and manage Transparent Translations > > Signed-off-by: Laurent Vivier > --- > target/m68k/cpu.h | 18 +++ > target/m68k/helper.c| 79 >

Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

2018-01-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180110202553.31889-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

2018-01-10 Thread Eric Blake
On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote: > This series improves the tracetool error messages to make them more > user-friendly. > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" > tracetool: report

Re: [Qemu-devel] [PATCH 1/3] tracetool: prefix parse errors with line numbers

2018-01-10 Thread Eric Blake
On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote: > Include the file line number in the message that is printed when > trace-events parse errors are raised. > > Suggested-by: Dr. David Alan Gilbert > Signed-off-by: Stefan Hajnoczi > --- >

[Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

2018-01-10 Thread Jean-Christophe Dubois
With the LEON3 IRQ controller IRQs can be acknoledged 2 ways: * Explicitely by software writing to the CLEAR_OFFSET register * Implicitely when the procesor is done running the trap handler attached to the IRQ. The actual IRQMP code only allows the implicit processor triggered IRQ ack. If

[Qemu-devel] [PATCH] i.MX: Fix FEC/ENET receive funtions

2018-01-10 Thread Jean-Christophe Dubois
The actual imx_eth_enable_rx() function is buggy. It updates s->regs[ENET_RDAR] after calling qemu_flush_queued_packets(). qemu_flush_queued_packets() is going to call imx_XXX_receive() which itself is going to call imx_eth_enable_rx(). By updating s->regs[ENET_RDAR] after calling

[Qemu-devel] [PATCH 2/3] tracetool: clarify that "formats" means "format strings"

2018-01-10 Thread Stefan Hajnoczi
The terminology used by tracetool is not consistent with C sprintf or docs/devel/tracing.txt. The word "formats" is sometimes used to mean "format strings". This patch clarifies comments and error messages that contain this word. Note that the error message lines are longer than 80 characters

[Qemu-devel] [PATCH 3/3] tracetool: report error on foo() instead of foo(void)

2018-01-10 Thread Stefan Hajnoczi
C functions with no arguments must be declared foo(void) instead of foo(). The tracetool argument list parser has never accepted an empty argument list. This patch adds a clear error message for this error case. Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 1/3] tracetool: prefix parse errors with line numbers

2018-01-10 Thread Stefan Hajnoczi
Include the file line number in the message that is printed when trace-events parse errors are raised. Suggested-by: Dr. David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 9 +++-- 1 file changed, 7 insertions(+),

[Qemu-devel] [PATCH 0/3] tracetool: improve error messages

2018-01-10 Thread Stefan Hajnoczi
This series improves the tracetool error messages to make them more user-friendly. Stefan Hajnoczi (3): tracetool: prefix parse errors with line numbers tracetool: clarify that "formats" means "format strings" tracetool: report error on foo() instead of foo(void)

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 8:15 PM, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: >> On Tue, Jan 9, 2018 at 7:55 PM, Dr. David Alan Gilbert >> wrote: >> >> Certain guest operations like rebooting or zeroing memory will defeat

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

2018-01-10 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Tue, Jan 9, 2018 at 7:55 PM, Dr. David Alan Gilbert > wrote: > >> Certain guest operations like rebooting or zeroing memory will defeat > >> the incremental guest RAM snapshot feature. It's worth thinking about > >> these

Re: [Qemu-devel] [PATCH 2/6] target/m68k: add MC68040 MMU

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > +static int get_physical_address(CPUM68KState *env, hwaddr *physical, > +int *prot, target_ulong address, > +int access_type, target_ulong *page_size) > +{ > +M68kCPU *cpu =

Re: [Qemu-devel] [PATCH v4 2/9] util: Introduce vfio helpers

2018-01-10 Thread Alex Williamson
On Wed, 10 Jan 2018 17:18:39 +0800 Fam Zheng wrote: > This is a library to manage the host vfio interface, which could be used > to implement userspace device driver code in QEMU such as NVMe or net > controllers. > > Signed-off-by: Fam Zheng > --- >

[Qemu-devel] [PATCH v2 3/3] target/i386: hax: Move x86_update_hflags.

2018-01-10 Thread Tao Wu via Qemu-devel
x86_update_hflags reference env->efer which is updated in hax_get_msrs, so it has to be called after hax_get_msrs. This fix the bug that sometimes dump_state show 32 bits regs even in 64 bits mode. Signed-off-by: Tao Wu --- target/i386/hax-all.c | 4 +--- 1 file changed, 1

[Qemu-devel] [PATCH v2 2/3] target/i386: hax: change to use x86_update_hflags

2018-01-10 Thread Tao Wu via Qemu-devel
Change to use x86_update_hflags instead of keeping another copy at hax side. This also fix bug like HF_CPL_MASK should be SS.DPL, not CS.DPL. Signed-off-by: Tao Wu --- target/i386/hax-all.c | 53 ++- 1 file changed, 2

[Qemu-devel] [PATCH v2 1/3] target/i386: move hflags update code to a function

2018-01-10 Thread Tao Wu via Qemu-devel
We will share the same code for hax/kvm. Signed-off-by: Tao Wu --- target/i386/Makefile.objs | 2 +- target/i386/common_i386.c | 50 +++ target/i386/common_i386.h | 14 + target/i386/kvm.c | 41

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

2018-01-10 Thread Michael Roth
Quoting Richard Henderson (2018-01-09 23:39:08) > The code sequence we were generating was only good for unsigned > comparisons. For signed comparisions, use the sequence from gcc. > > Fixes booting of ppc64 firmware, with a patch changing the code > sequence for ppc comparisons. > >

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

2018-01-10 Thread Stefan Hajnoczi
On Tue, Jan 9, 2018 at 7:55 PM, Dr. David Alan Gilbert wrote: >> Certain guest operations like rebooting or zeroing memory will defeat >> the incremental guest RAM snapshot feature. It's worth thinking about >> these cases to make sure this feature would be worth it in real

[Qemu-devel] [PATCH] hw/pci-bridge: fix QEMU crash because of pcie-root-port

2018-01-10 Thread Marcel Apfelbaum
If we try to use more pcie_root_ports then available slots and an IO hint is passed to the port, QEMU crashes because we try to init the "IO hint" capability even if the device is not created. Fix it by checking for error before adding the capability, so QEMU can fail gracefully. Signed-off-by:

Re: [Qemu-devel] [PATCH v4 8/9] docs: Add section for NVMe VFIO driver

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:45PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > docs/qemu-block-drivers.texi | 32 > 1 file changed, 32 insertions(+) > > diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi >

Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:46PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP

[Qemu-devel] [PATCH v2 3/5] vfio/pci: Emulate BARs

2018-01-10 Thread Alex Williamson
The kernel provides similar emulation of PCI BAR register access to QEMU, so up until now we've used that for things like BAR sizing and storing the BAR address. However, if we intend to resize BARs or add BARs that don't exist on the physical device, we need to switch to the pure QEMU emulation

[Qemu-devel] [PATCH v2 5/5] vfio/pci: Allow relocating MSI-X MMIO

2018-01-10 Thread Alex Williamson
Recently proposed vfio-pci kernel changes (v4.16) remove the restriction preventing userspace from mmap'ing PCI BARs in areas overlapping the MSI-X vector table. This change is primarily intended to benefit host platforms which make use of system page sizes larger than the PCI spec recommendation

[Qemu-devel] [PATCH v2 0/5] vfio/pci: MSI-X MMIO relocation

2018-01-10 Thread Alex Williamson
v1: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03350.html See patch 5/5 for a thorough description. v2 changes the 'auto' behavior as we've determined that there's no algorithm which has even a likely chance of success. Instead, auto is now a placeholder for a device/platform

[Qemu-devel] [PATCH v2 4/5] qapi: Create DEFINE_PROP_OFF_AUTO_PCIBAR

2018-01-10 Thread Alex Williamson
Add an option which allows the user to specify a PCI BAR number, including an 'off' and 'auto' selection. Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Alex Williamson --- hw/core/qdev-properties.c| 11 +++

[Qemu-devel] [PATCH v2 1/5] vfio/pci: Fixup VFIOMSIXInfo comment

2018-01-10 Thread Alex Williamson
The fields were removed in the referenced commit, but the comment still mentions them. Fixes: 2fb9636ebf24 ("vfio-pci: Remove unused fields from VFIOMSIXInfo") Signed-off-by: Alex Williamson --- hw/vfio/pci.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 2/5] vfio/pci: Add base BAR MemoryRegion

2018-01-10 Thread Alex Williamson
Add one more layer to our stack of MemoryRegions, this base region allows us to register BARs independently of the vfio region or to extend the size of BARs which do map to a region. This will be useful when we want hypervisor defined BARs or sections of BARs, for purposes such as relocating

Re: [Qemu-devel] [PATCH v4 5/9] block/nvme: Implement .bdrv_(un)register_buf

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:42PM +0800, Fam Zheng wrote: > Forward these two calls to the IOVA manager. > > Signed-off-by: Fam Zheng > --- > block/nvme.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-10 Thread Richard Palethorpe
Hello Eric & Peter, Eric Blake writes: > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: >> Add QAPI wrapper functions for the existing snapshot functionality. These >> functions behave the same way as the HMP savevm, loadvm and delvm >> commands. This will allow applications, such as OpenQA,

Re: [Qemu-devel] [PATCH v4 7/9] block: Move NVMe constants to a separate header

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:44PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/nvme.c | 7 +- > hw/block/nvme.h | 698 +- > include/block/nvme.h | 700 >

Re: [Qemu-devel] [PATCH v4 6/9] qemu-img: Map bench buffer

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:43PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qemu-img.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v4 4/9] block: Introduce buf register API

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:41PM +0800, Fam Zheng wrote: > Allow block driver to map and unmap a buffer for later I/O, as a performance > hint. > > Signed-off-by: Fam Zheng > --- > block/block-backend.c | 10 ++ > block/io.c | 24

Re: [Qemu-devel] [RFC PATCH 3/3] acpi: Build TPM Physical Presence interface

2018-01-10 Thread Stefan Berger
On 01/10/2018 01:35 PM, Stefan Berger wrote: The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/6] accel/tcg: add size paremeter in tlb_fill()

2018-01-10 Thread Richard Henderson
On 01/10/2018 05:42 AM, Laurent Vivier wrote: > Le 10/01/2018 à 09:43, David Hildenbrand a écrit : >> On 09.01.2018 00:10, Laurent Vivier wrote: >>> The MC68040 MMU provides the size of the access that >>> triggers the page fault. >>> >>> This size is set in the Special Status Word which >>> is

[Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI

2018-01-10 Thread Stefan Berger
Implement a virtual memory device for the TPM physical presence interface. The memory is located at 0x and used by ACPI to send messages to the firmware (BIOS). This device should be used by all TPM interfaces on x86 and can be added through by calling tpm_ppi_init_io(). Signed-off-by:

[Qemu-devel] [RFC PATCH 2/3] acpi: implement aml_lless_equal

2018-01-10 Thread Stefan Berger
LLessEqualOp = LNotOp LGreaterOp Signed-off-by: Stefan Berger --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 36a6cc4..597a58d 100644

[Qemu-devel] [RFC PATCH 0/3] Implement Pysical Presence Interface for TPM 1.2 and 2

2018-01-10 Thread Stefan Berger
The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware (BIOS, UEFI) looks for an acts upon by sending sequences of commands to the TPM 1.2 or 2. My first goal is to get the

[Qemu-devel] [RFC PATCH 3/3] acpi: Build TPM Physical Presence interface

2018-01-10 Thread Stefan Berger
The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code and acts on it by

Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:40PM +0800, Fam Zheng wrote: There are several memory and lock leaks in this patch. Please work with Paolo to get the __attribute__((cleanup(...))) patch series merged so this class of bugs can be eliminated:

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 17:49, Richard Henderson wrote: > On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: >> Flushing TB cache is required because TBs key in the cache may match >> different code which existed in the previous state. >> >> Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Stefan Berger
On 01/10/2018 06:29 AM, Michael S. Tsirkin wrote: On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: On Tue, 9 Jan 2018 15:58:11 +0200 "Michael S. Tsirkin" wrote: We prefer not changing table sizes depending on parameters, that's why we create a dummy table

Re: [Qemu-devel] [PATCH 5/5] nbd/server: structurize option reply sending

2018-01-10 Thread Eric Blake
On 11/22/2017 04:02 PM, Eric Blake wrote: > On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> nbd/server.c | 40 +--- >> 1 file changed, 13 insertions(+), 27

Re: [Qemu-devel] [PATCH 4/5] nbd: rename nbd_option and nbd_opt_reply

2018-01-10 Thread Eric Blake
On 11/22/2017 03:56 PM, Eric Blake wrote: > On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: >> Rename nbd_optino and nbd_opt_reply to NBDOption and NBDOptionReply > > s/optino/option/ > >> to correspond to Qemu coding style and other structures here. >> >> Signed-off-by: Vladimir

[Qemu-devel] [PATCH] ui/sdl2: Ignore key repeats for shortcut keys

2018-01-10 Thread Thomas Huth
Holding down a shortcut key currently continuesly triggers the shortcut event, e.g. holding CTRL-ALT-f continuesly switches between windowed and fullscreen mode, or holding CTRL-ALT-u even crashes QEMU with a segfault. This is ugly, we should rather ignore automatic key repeats when handling the

Re: [Qemu-devel] [PATCH] target/i386: hax: Move hax_setup_qemu_emulator.

2018-01-10 Thread 吴涛@Eng
Thanks. Then it seems I should put this piece of code in a common function first and then update this CL. On Wed, Jan 10, 2018 at 5:27 AM, Paolo Bonzini wrote: > On 10/01/2018 07:47, Tao Wu wrote: >> hax_setup_qemu_emulator reference env->efer which is updated in >>

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Dr. David Alan Gilbert
* Richard Henderson (richard.hender...@linaro.org) wrote: > On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: > > Flushing TB cache is required because TBs key in the cache may match > > different code which existed in the previous state. > > > > Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Richard Henderson
On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: > Flushing TB cache is required because TBs key in the cache may match > different code which existed in the previous state. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Maria Klimushenkova

[Qemu-devel] [PATCH 4/5] block/parallels: replace some magic numbers

2018-01-10 Thread Klim Kireev
Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.c | 5 +++-- block/parallels.h | 2 ++ 2 files changed, 5

[Qemu-devel] [PATCH 2/5] configure: add dependency

2018-01-10 Thread Klim Kireev
This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. The patch also adds clause to checkpatch.pl to

[Qemu-devel] [PATCH 5/5] block/parallels: add backing support to readv/writev

2018-01-10 Thread Klim Kireev
From: Edgar Kaziakhmedov Since parallels format supports backing files, refine readv/writev (allocate_clusters) to redirect read/write requests to a backing file (if cluster is not available in the current bs). Signed-off-by: Edgar Kaziakhmedov

[Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2018-01-10 Thread Klim Kireev
This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH 3/5] block/parallels: move some structures into header

2018-01-10 Thread Klim Kireev
To implement xml format, some defines and structures from parallels.c are required. Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi

[Qemu-devel] [PATCH 0/5 v2] preparation for Parallels Disk xml driver

2018-01-10 Thread Klim Kireev
Parallels Desktop and Parallels Cloud Server uses images glued with the bundle description in XML format. This series contains very basic description of this XML files and makes preparations for actual implementation to be followed. Signed-off-by: Edgar Kaziakhmedov

Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-10 Thread Patrick Tseng
Hi Daniel, thanks for responding. > This should really be part of the commit message for the patch itself, so it > gets recorded in git history. Next patch version I'll separate this out to another commit. > I wonder if it is reasonable for ui/input-linux.c to honour the same > global '-ungrab'

Re: [Qemu-devel] [PATCH v1 05/21] RISC-V CPU Helpers

2018-01-10 Thread Richard Henderson
On 01/10/2018 02:35 AM, Stefan O'Rear wrote: > On Tue, Jan 2, 2018 at 11:12 PM, Richard Henderson > wrote: >>> +case CSR_MISA: { >>> +if (!(val_to_write & (1L << ('F' - 'A' { >>> +val_to_write &= ~(1L << ('D' - 'A')); >>> +} >>> +

Re: [Qemu-devel] [PATCH v4 1/9] stubs: Add stubs for ram block API

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:38PM +0800, Fam Zheng wrote: > These functions will be wanted by block-obj-y but the actual definition > is in obj-y, so stub them to keep the linker happy. > > Signed-off-by: Fam Zheng > Acked-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [PATCH v4 2/9] util: Introduce vfio helpers

2018-01-10 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 05:18:39PM +0800, Fam Zheng wrote: > +/* Map [host, host + size) area into a contiguous IOVA address space, and > store > + * the result in @iova if not NULL. The caller need to make sure the area is > + * aligned to page size, and mustn't overlap with existing mapping

Re: [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-10 Thread Eric Blake
On 01/10/2018 10:19 AM, Richard Palethorpe wrote: > Hello Eric & Peter, > > Eric Blake writes: > >> On 01/07/2018 06:23 AM, Richard Palethorpe wrote: >>> Add QAPI wrapper functions for the existing snapshot functionality. These >>> functions behave the same way as the HMP savevm, loadvm and

Re: [Qemu-devel] [PATCH v3] possible_cpus: add CPUArchId::type field

2018-01-10 Thread Eduardo Habkost
On Wed, Jan 10, 2018 at 04:22:50PM +0100, Igor Mammedov wrote: > Remove dependency of possible_cpus on 1st CPU instance, > which decouples configuration data from CPU instances that > are created using that data. > > Also later it would be used for enabling early cpu to numa node > configuration

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Nir Soffer
On Wed, Jan 10, 2018 at 4:04 PM Kashyap Chamarthy wrote: > On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > Management and users are accustomed to "qemu-img info" to query status > of > > > images even

Re: [Qemu-devel] [PATCH] ui: deprecate use of GTK 2.x in favour of 3.x series

2018-01-10 Thread Daniel P. Berrange
ping. Gerd, do you have any opinions on this, and also deprecating SDL-1 ? On Tue, Dec 12, 2017 at 11:34:40AM +, Daniel P. Berrange wrote: > The GTK 3.0 release was made in Feb, 2011: > > https://blog.gtk.org/2011/02/10/gtk-3-0-released/ > > That will soon be 7 years ago, which is enough

Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-10 Thread Daniel P. Berrange
On Sun, Jan 07, 2018 at 02:14:54PM -0800, byxk wrote: > Added some functionality to change the key combo for evdev toggle. > example: > -object input-linux,rhotkey=29,lhotkey=56,evdev=[etc...] > > Set the defaults to LCTRL and RCTRL if not provided. This should really be part of the commit

Re: [Qemu-devel] [PATCH v2 1/6] nbd/server: add additional assert to nbd_export_put

2018-01-10 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > This place is not obvious, nbd_export_close may theoretically reduce > refcount to 0. It may happen if someone calls nbd_export_put on named > export not through nbd_export_set_name when refcount is 1. > > Signed-off-by: Vladimir

[Qemu-devel] [PATCH] net: Remove the deprecated way of dumping network packets

2018-01-10 Thread Thomas Huth
"-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter. Network dumping should be done with "-object filter-dump" nowadays instead. So let's finally get rid of "-net dump" now. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2018-01-10 Thread klim
On 01/04/2018 02:34 PM, Stefan Hajnoczi wrote: On Mon, Dec 18, 2017 at 02:09:07PM +0300, Denis V. Lunev wrote: From: Klim Kireev This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar

Re: [Qemu-devel] [PATCH v4] Add ability for user to specify mouse ungrab key

2018-01-10 Thread Daniel P. Berrange
On Tue, Dec 26, 2017 at 08:14:28PM -0500, John Arbuckle wrote: > Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. > This combination may not be very fun for the user to have to enter, so we > now enable the user to specify their own key(s) as the ungrab key(s). The >

[Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-10 Thread Stefan Hajnoczi
Hi Wei, I wanted to summarize the differences between the vhost-pci and virtio-vhost-user approaches because previous discussions may have been confusing. vhost-pci defines a new virtio device type for each vhost device type (net, scsi, blk). It therefore requires a virtio device driver for each

Re: [Qemu-devel] [PATCH] linux-user: Add getcpu() support

2018-01-10 Thread Samuel Thibault
Laurent Vivier, on mer. 10 janv. 2018 16:53:47 +0100, wrote: > Le 28/12/2017 à 18:39, Laurent Vivier a écrit : > > Le 28/12/2017 à 16:00, Samuel Thibault a écrit : > >> Signed-off-by: Samuel Thibault > >> --- > >> linux-user/syscall.c | 16 > >> 1

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-10 Thread luigi burdo
Hi Peter, thanks for reply. I will check the ram banks and will try again to build it . but i have more fear about gcc now because the issue come exactly in the same point every time i try to rebuild everyting. Thankyou Luigi This means that gcc

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-10 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: > > >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict > >> *qdict) > >> bool writable = qdict_get_try_bool(qdict, "writable", false); > >> Error *local_err = NULL; >

Re: [Qemu-devel] [PATCH] linux-user: Add getcpu() support

2018-01-10 Thread Laurent Vivier
Le 28/12/2017 à 18:39, Laurent Vivier a écrit : > Le 28/12/2017 à 16:00, Samuel Thibault a écrit : >> Signed-off-by: Samuel Thibault >> --- >> linux-user/syscall.c | 16 >> 1 file changed, 16 insertions(+) >> >> diff --git a/linux-user/syscall.c

Re: [Qemu-devel] [Qemu-block] [PATCH 2/5] configure: add dependency

2018-01-10 Thread Daniel P. Berrange
On Fri, Dec 22, 2017 at 03:38:02PM +0300, Roman Kagan wrote: > On Mon, Dec 18, 2017 at 02:09:08PM +0300, Denis V. Lunev wrote: > > From: Klim Kireev > > > > This dependency is required for adequate Parallels images support. > > Typically the disk consists of several

Re: [Qemu-devel] qemu 2.9.0 qcow2 file failed to open after hard server reset

2018-01-10 Thread John Snow
On 12/27/2017 04:47 PM, Vasiliy Tolstov wrote: > 2017-12-22 1:58 GMT+03:00 John Snow : >> >> >> On 12/21/2017 05:13 PM, Vasiliy Tolstov wrote: >>> Hi! Today my server have forced reboot and one of my vm can't start >>> with message: >>> qcow2: Marking image as corrupt: L2 table

Re: [Qemu-devel] [PATCH v3 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 06:39:24PM +0300, Edgar Kaziakhmedov wrote: > According to the current implementation of websocket protocol in QEMU, > qio_channel_websock_handshake_io tries to read handshake from the > channel to start communication over socket. But this approach > doesn't cover scenario

[Qemu-devel] [PATCH v3 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Edgar Kaziakhmedov
According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start communication over socket. But this approach doesn't cover scenario when socket was closed while handshaking. Therefore, if G_IO_IN is caught

Re: [Qemu-devel] [Qemu-block] [PATCH 2/5] configure: add dependency

2018-01-10 Thread klim
On 12/22/2017 03:38 PM, Roman Kagan wrote: On Mon, Dec 18, 2017 at 02:09:08PM +0300, Denis V. Lunev wrote: From: Klim Kireev This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk

Re: [Qemu-devel] [PATCH v2 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 06:24:25PM +0300, Edgar Kaziakhmedov wrote: > > > On 01/10/2018 06:22 PM, Daniel P. Berrange wrote: > > On Wed, Jan 10, 2018 at 06:13:22PM +0300, Edgar Kaziakhmedov wrote: > > > According to the current implementation of websocket protocol in QEMU, > > >

Re: [Qemu-devel] [PATCH v2 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Edgar Kaziakhmedov
On 01/10/2018 06:22 PM, Daniel P. Berrange wrote: On Wed, Jan 10, 2018 at 06:13:22PM +0300, Edgar Kaziakhmedov wrote: According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start communication over

[Qemu-devel] [PATCH v3] possible_cpus: add CPUArchId::type field

2018-01-10 Thread Igor Mammedov
Remove dependency of possible_cpus on 1st CPU instance, which decouples configuration data from CPU instances that are created using that data. Also later it would be used for enabling early cpu to numa node configuration at runtime qmp_query_hotpluggable_cpus() should provide a list of available

Re: [Qemu-devel] [PATCH v2 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 06:13:22PM +0300, Edgar Kaziakhmedov wrote: > According to the current implementation of websocket protocol in QEMU, > qio_channel_websock_handshake_io tries to read handshake from the > channel to start communication over socket. But this approach > doesn't cover scenario

<    1   2   3   4   >