Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

On 09/01/2018 18:44, Peter Maydell wrote: > On 8 January 2018 at 17:49, Max Filippov wrote: >> Hi Peter, >> >> please pull the following batch of updates for the target/xtensa. >> Changes v1->v2: >> - Drop no longer used function option_bits_enabled. >> >> The following

[Qemu-devel] [PATCH v2 1/1] io/channel-websock: handle continuous reads without any data

According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start communication over socket. But this approach doesn't cover scenario when socket was closed while handshaking. Therefore, if G_IO_IN is caught

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

On 01/10/2018 09:04 AM, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>> These are basically David's patches, with a couple changes for clarity >>> and robustness. >> >> Yes, those look fine to me. >> (Patchew

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

On 10.01.2018 15:47, Paolo Bonzini wrote: > On 10/01/2018 15:32, Thomas Huth wrote: >> QEMU can emulate hubs to connect NICs and netdevs. This is currently >> primarily used for the mis-named 'vlan' feature of the networking >> subsystem. Now the 'vlan' feature has been marked as deprecated, since

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > These are basically David's patches, with a couple changes for clarity > > and robustness. > > Yes, those look fine to me. > (Patchew seems to be annoyed at the Tracing - I can't see why)

Re: [Qemu-devel] [RFC 00/14] Multifd

Juan Quintela wrote: > Hi > > For V10: > - It is a request for comments > > - I changed as suggested from Paolo on KVM forum to send page metadata > over the channels > > - I simplified lots of things > - Added reviews > - it is not finished, in no-particular order: > *

Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

On 09/01/2018 21:16, Haozhong Zhang wrote: > On 01/09/18 17:37 -0200, Marcelo Tosatti wrote: >> >> Improve hugepage allocation failure message, indicating >> whats happening to the user. >> >> Signed-off-by: Marcelo Tosatti >> >> diff --git a/exec.c b/exec.c >> index

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

"Dr. David Alan Gilbert" wrote: > * Peter Xu (pet...@redhat.com) wrote: >> On Wed, Jan 10, 2018 at 09:43:48AM +0100, Juan Quintela wrote: >> > Peter Xu wrote: >> > > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: >> > >> Signed-off-by: Juan

Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

On 10/01/2018 15:43, Eric Blake wrote: > On 01/10/2018 03:18 AM, Fam Zheng wrote: >> This is a new protocol driver that exclusively opens a host NVMe >> controller through VFIO. It achieves better latency than linux-aio by >> completely bypassing host kernel vfs/block layer. >> >>

Re: [Qemu-devel] [PULL 04/46] contrib: add systemd unit files

On Wed, Dec 20, 2017 at 06:14:16PM +0100, Paolo Bonzini wrote: > This lets distros standardize on how QEMU should install systemd > services for qemu-ga and qemu-pr-helper. > > The qemu-ga unit file comes from Fedora, but I checked that > Debian is using the same path for the virtio-serisal port.

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

On 10/01/2018 15:32, Thomas Huth wrote: > QEMU can emulate hubs to connect NICs and netdevs. This is currently > primarily used for the mis-named 'vlan' feature of the networking > subsystem. Now the 'vlan' feature has been marked as deprecated, since > its name is rather confusing and the users

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

Hi, This series failed build test on ppc host. Please find the details below. Type: series Message-id: 20180110142515.13242-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

On 01/10/2018 03:18 AM, Fam Zheng wrote: > This is a new protocol driver that exclusively opens a host NVMe > controller through VFIO. It achieves better latency than linux-aio by > completely bypassing host kernel vfs/block layer. > > +static BlockDriver bdrv_nvme = { > +.format_name

Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

On 01/10/2018 03:18 AM, Fam Zheng wrote: > This is a new protocol driver that exclusively opens a host NVMe > controller through VFIO. It achieves better latency than linux-aio by > completely bypassing host kernel vfs/block layer. > > $rw-$bs-$iodepth linux-aio nvme:// >

Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

On 01/10/2018 03:18 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index e94a6881b2..fd6c94454d 100644 > ---

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

* Paolo Bonzini (pbonz...@redhat.com) wrote: > These are basically David's patches, with a couple changes for clarity > and robustness. Yes, those look fine to me. (Patchew seems to be annoyed at the Tracing - I can't see why) Dave > Dr. David Alan Gilbert (2): > find_ram_offset: Add comments

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20180110142515.13242-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] find_ram_offset

[Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

QEMU can emulate hubs to connect NICs and netdevs. This is currently primarily used for the mis-named 'vlan' feature of the networking subsystem. Now the 'vlan' feature has been marked as deprecated, since its name is rather confusing and the users often rather mis-configure their network when

Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180110142515.13242-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

[Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries

From: "Dr. David Alan Gilbert" The dirty bitmaps are built from 'long's and there is fast-path code for synchronising the case where the RAMBlock is aligned to the start of a long boundary. Align the allocation to this boundary to cause the fast path to be used. Offsets

Re: [Qemu-devel] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

On 08/01/2018 16:27, Peter Lieven wrote: > in case of unaligned requests or on a target that does not support > block provisioning we leave iTask uninitialized and check iTask.task > for NULL later. > > Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 > Cc: qemu-sta...@nongnu.org > Signed-off-by:

[Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing

From: "Dr. David Alan Gilbert" Add some comments and rename the "end" variable so I can understand the various nested loops. Add some tracing so I can see what they're doing. Signed-off-by: Dr. David Alan Gilbert Message-Id:

[Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

These are basically David's patches, with a couple changes for clarity and robustness. Dr. David Alan Gilbert (2): find_ram_offset: Add comments and tracing find_ram_offset: Align ram_addr_t allocation on long boundaries exec.c | 33 ++--- trace-events | 4

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Wed, Jan 10, 2018 at 03:07:12PM +0100, Kevin Wolf wrote: > Am 10.01.2018 um 13:49 hat Daniel P. Berrange geschrieben: > > On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > > Management and users are accustomed to "qemu-img

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

Am 10.01.2018 um 13:49 hat Daniel P. Berrange geschrieben: > On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > Management and users are accustomed to "qemu-img info" to query status of > > > images even when they are used by

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > Management and users are accustomed to "qemu-img info" to query status of > > images even when they are used by guests. Since image locking was added, > > the -U > > (--force-share)

Re: [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries

On 05/01/2018 18:01, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The dirty bitmaps are built from 'long'sand there is fast-path code > for synchronising the case where the RAMBlock is aligned to the start > of a long boundary. Align the

Re: [Qemu-devel] [PATCH v1 01/13] ui: remove 'sync' parametr from vnc_update_client

On Mon, Jan 08, 2018 at 12:08:49PM +0100, Gerd Hoffmann wrote: > On Mon, Dec 18, 2017 at 07:12:16PM +, Daniel P. Berrange wrote: > > There is only one caller of vnc_update_client and that always passes false > > for the 'sync' parameter. > > Unused since commit

Re: [Qemu-devel] [PATCH v2 0/7] macro do/while (0) cleanup

On 09/01/2018 21:52, Eric Blake wrote: > ping Hmm, the actual posting of the patches wasn't CCed to qemu-trivial. Queued now, thanks. Paolo > On 12/01/2017 05:24 PM, Eric Blake wrote: >> Noticed this by chance in the tests/ directory, so I broadened >> it to a grep of the entire code base. I

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

On 10/01/2018 14:48, Pavel Dovgalyuk wrote: > Flushing TB cache is required because TBs key in the cache may match > different code which existed in the previous state. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Maria Klimushenkova

[Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

Flushing TB cache is required because TBs key in the cache may match different code which existed in the previous state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Maria Klimushenkova --- exec.c |1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Wed, Jan 10, 2018 at 01:31:09PM +0100, Igor Mammedov wrote: > On Wed, 10 Jan 2018 13:55:37 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > > > On Wed, 10 Jan 2018 13:29:09 +0200 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/6] accel/tcg: add size paremeter in tlb_fill()

Le 10/01/2018 à 09:43, David Hildenbrand a écrit : > On 09.01.2018 00:10, Laurent Vivier wrote: >> The MC68040 MMU provides the size of the access that >> triggers the page fault. >> >> This size is set in the Special Status Word which >> is written in the stack frame of the access fault >>

Re: [Qemu-devel] [PATCH v5 1/4] vhost: remove assertion to prevent crash

On Wed, 10 Jan 2018 00:39:35 +0800 Jay Zhou wrote: > Start QEMU with more DIMM devices than limit but without any > vhost backends and then hotplug a vhost user backend, the VM > will be crashed. > Instead of asserting in vhost_user_set_mem_table(), error number > is

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

On Wed, Jan 10, 2018 at 04:31:21PM +0300, Edgar Kaziakhmedov wrote: > > > On 01/10/2018 03:33 PM, Daniel P. Berrange wrote: > > On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: > > > From: Edgar Kaziakhmedov > > > > > > According to the current

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

On 10/01/2018 02:55, David Gibson wrote: > On Tue, Jan 09, 2018 at 03:15:25PM +, Peter Maydell wrote: >> On 9 January 2018 at 12:16, David Gibson wrote: >>> Thanks. Even if you can identify which patch it is and we can >>> postpone that one would be a bug help.

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

On 01/10/2018 03:33 PM, Daniel P. Berrange wrote: On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: From: Edgar Kaziakhmedov According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read

Re: [Qemu-devel] [PATCH] target/i386: hax: Move hax_setup_qemu_emulator.

On 10/01/2018 07:47, Tao Wu wrote: > hax_setup_qemu_emulator reference env->efer which is updated in > hax_get_msrs, so it has to be called after hax_get_msrs. This fix > the bug that sometimes dump_state show 32 bits regs even in 64 bits > mode. > > Signed-off-by: Tao Wu >

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

On 10 January 2018 at 13:08, Paolo Bonzini wrote: > On 10/01/2018 09:40, Pavel Dovgalyuk wrote: >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >>> On 22/12/2017 14:21, Pavel Dovgalyuk wrote: Paolo, Ladi finished the review. What about merging these into

[Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first connect to listen character device socket the listen socket is removed from poll just after

Re: [Qemu-devel] [PATCH v5 3/4] vhost: fix memslot limit check

On Wed, 10 Jan 2018 00:40:12 +0800 Jay Zhou wrote: > Since used_memslots will be updated to the actual value after > registering memory listener for the first time, move the > memslots limit checking to the right place. > > Signed-off-by: Jay Zhou

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

On 10/01/2018 09:40, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 22/12/2017 14:21, Pavel Dovgalyuk wrote: >>> Paolo, Ladi finished the review. >>> What about merging these into upstream? >> Sure, in the new year though. > Now? Ok, will do. Paolo

Re: [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API

On 01/10/2018 01:57 AM, Peter Xu wrote: > On Tue, Jan 09, 2018 at 04:53:40PM -0600, Eric Blake wrote: >> On 12/19/2017 02:45 AM, Peter Xu wrote: >>> We can simplify object_property_get_str() using the new >>> qobject_get_try_str(). >>> >>> Reviewed-by: Fam Zheng >>> Reviewed-by:

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

On Tue, Jan 9, 2018 at 9:45 PM, Alistair Francis wrote: > Can anyone who has done this before chime in. > > What do you think about getting someone to cleanup and improve the GDB > support in QEMU? Would that be the right difficulty of task for a GSoC > project? There is

Re: [Qemu-devel] how to pass pcid to guest?

On Mon, Jan 08, 2018 at 04:07:53PM -0600, Eric Blake wrote: > On 01/08/2018 02:03 PM, Stefan Priebe - Profihost AG wrote: > > Hello, > > > > for meltdown mitigation and performance it's important to have the pcid > > flag passed down to the guest (f.e. > >

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > Management and users are accustomed to "qemu-img info" to query status of > > images even when they are used by guests. Since image locking was added, > > the -U > > (--force-share)

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Mon, Jan 08, 2018 at 06:57:29PM +0100, Kevin Wolf wrote: > Am 08.01.2018 um 18:07 hat Nir Soffer geschrieben: > > On Mon, Jan 8, 2018 at 4:48 PM Kevin Wolf wrote: > > > > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > > Management and users are accustomed to

Re: [Qemu-devel] [PATCH v2 2/3] qcow2: handle reopening bitmaps on bdrv_invalidate_cache

22.12.2017 19:28, Kevin Wolf wrote: Am 22.12.2017 um 17:12 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.12.2017 18:43, Kevin Wolf wrote: Am 22.12.2017 um 15:25 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.12.2017 16:39, Kevin Wolf wrote: Am 12.12.2017 um 17:04 hat Vladimir

[Qemu-devel] [PATCH v10 13/14] migration: Add multifd_send_packet trace

I need the block name, so I can't do that sooner. Signed-off-by: Juan Quintela --- migration/ram.c| 2 ++ migration/trace-events | 1 + 2 files changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index f636c7da0a..6e45f668d1 100644 ---

Re: [Qemu-devel] [PATCH v4 1/2] migration: Create tcp_port parameter

On Fri, Jan 05, 2018 at 09:51:08PM +0100, Juan Quintela wrote: > It will be used to store the uri tcp_port parameter. This is the only > parameter than can change and we can need to be able to connect to it. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri

[Qemu-devel] [PATCH v10 14/14] all works

Signed-off-by: Juan Quintela --- migration/ram.c | 69 - 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 6e45f668d1..a689d4a218 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH v10 12/14] migration: Sent the page list over the normal thread

Signed-off-by: Juan Quintela --- migration/ram.c | 69 + 1 file changed, 60 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b1ad7b2730..f636c7da0a 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH v10 10/14] migration: Add multifd test

We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela --- tests/migration-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PATCH v10 09/14] migration: Flush receive queue

Each time that we sync the bitmap, it is a possiblity that we receive a page that is being processed by a different thread. We fix this problem just making sure that we wait for all receiving threads to finish its work before we procedeed with the next stage. We are low on page flags, so we use

Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init

On 01/10/2018 02:26 AM, Peter Xu wrote: >> The later initialization of the monitor_lock mutex is a potential >> semantic change. Please beef up the commit message to document why it >> is safe. In fact, I requested this back on my review of v1, but it >> still hasn't been done. :( >> >>

[Qemu-devel] [PATCH v10 04/14] migration: Start of multiple fd work

We create new channels for each new thread created. We send through them in a packed struct. This way we can check we connect the right channels in both sides. Signed-off-by: Juan Quintela -- Split SocketArgs into incoming and outgoing args Use UUID's on the initial

[Qemu-devel] [PATCH v10 11/14] LOCAL: use trace events for migration-test

Signed-off-by: Juan Quintela --- tests/migration-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 488ae89f34..d0b0c1b64b 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -457,11 +457,13 @@

[Qemu-devel] [PATCH v10 06/14] migration: Send the fd number which we are going to use for this page

We are still sending the page through the main channel, that would change later in the series Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v10 07/14] migration: Create thread infrastructure for multifd recv side

We make the locking and the transfer of information specific, even if we are still receiving things through the main thread. Signed-off-by: Juan Quintela -- We split when we create the main channel and where we start the main migration thread, so we wait for the creation

[Qemu-devel] [RFC 00/14] Multifd

Hi For V10: - It is a request for comments - I changed as suggested from Paolo on KVM forum to send page metadata over the channels - I simplified lots of things - Added reviews - it is not finished, in no-particular order: * old code is not removed for comparison for the people that looked

[Qemu-devel] [PATCH v10 08/14] migration: Transfer pages over new channels

We switch for sending the page number to send real pages. Signed-off-by: Juan Quintela -- Remove the HACK bit, now we have the function that calculates the size of a page exported. Rename multifd_pages{_now}, to sent pages Remove multifd pages field, it is the same than

[Qemu-devel] [PATCH v10 01/14] migration: Make migrate_fd_error() the owner of the Error

So far, we had to free the error after each caller, so just do it here. Once there, tls.c was leaking the error. Signed-off-by: Juan Quintela --- migration/channel.c | 1 - migration/migration.c | 10 -- migration/migration.h | 4 ++-- migration/socket.c|

[Qemu-devel] [PATCH v10 03/14] migration: Drop current address parameter from save_zero_page()

It already has RAMBlock and offset, it can calculate it itself. Signed-off-by: Juan Quintela --- migration/ram.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cb1950f3eb..5a109efeda 100644 ---

[Qemu-devel] [PATCH v10 05/14] migration: Create ram_multifd_page

The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter and a new flag for this type of pages. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove

[Qemu-devel] [PATCH v10 02/14] migration: Rename initial_bytes

Now it is called qemu_file_bytes that reflects better what it does, and we create qemu_file_bytes_now to not have to call qemu_ftell() twice. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 9 + 1

Re: [Qemu-devel] [PATCH] crypto/ivgen-essiv: Fix problem with address sanitizer of Clang

On Tue, Jan 02, 2018 at 04:37:45PM +0100, Thomas Huth wrote: > When compiling QEMU with clang and -fsanitize=address, I get the > following error: > > ==9185==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x7ffc7e9adf2f at pc 0x564cba001d88 bp 0x7ffc7e9adeb0 sp 0x7ffc7e9adea8 >

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: > From: Edgar Kaziakhmedov > > According to the current implementation of websocket protocol in QEMU, > qio_channel_websock_handshake_io tries to read handshake from the > channel to start

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Wed, 10 Jan 2018 13:55:37 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > > On Wed, 10 Jan 2018 13:29:09 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor

Re: [Qemu-devel] [PATCH v14 4/9] ACPI: enable APEI GHES in the configure file

On 2018/1/10 1:16, Peter Maydell wrote: > On 28 December 2017 at 05:54, Dongjiu Geng wrote: >> Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak >> and add build choice in the Makefile.objs. >> >> Signed-off-by: Dongjiu Geng >> --- >>

Re: [Qemu-devel] [PATCH v14 9/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

Hi Peter, Thanks for the mail and comments. On 2018/1/10 1:14, Peter Maydell wrote: > On 28 December 2017 at 05:54, Dongjiu Geng wrote: >> Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, >> translates the host VA which is delivered by host to

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > On Wed, 10 Jan 2018 13:29:09 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > > > On Tue, 9 Jan 2018 15:58:11 +0200 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jan 10, 2018 at 09:43:48AM +0100, Juan Quintela wrote: > > Peter Xu wrote: > > > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela > > >> --- > > >>

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index d81f22118b..f469235d0b

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Wed, 10 Jan 2018 13:29:09 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > > On Tue, 9 Jan 2018 15:58:11 +0200 > > "Michael S. Tsirkin" wrote: > > > > > We prefer not changing table sizes depending on

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > On Tue, 9 Jan 2018 15:58:11 +0200 > "Michael S. Tsirkin" wrote: > > > We prefer not changing table sizes depending on parameters, > > that's why we create a dummy table rather than just drop > > the MCFG table. > >

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

On Tue, 9 Jan 2018 15:58:11 +0200 "Michael S. Tsirkin" wrote: > We prefer not changing table sizes depending on parameters, > that's why we create a dummy table rather than just drop > the MCFG table. > > However, a table named "QEMU" could be put to a better > use than just a

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

On 10/01/2018 11:43, Juan Quintela wrote: > Laurent Vivier wrote: >> On 10/01/2018 10:21, Laurent Vivier wrote: >>> On 10/01/2018 09:47, Juan Quintela wrote: Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: >>

Re: [Qemu-devel] [PATCH v3] hpet: recover timer offset correctly

Pavel Dovgalyuk wrote: > HPET saves its state by calculating the current time and recovers timer > offset using this calculated value. But these calculations include > divisions and multiplications. Therefore the timer state cannot be recovered > precise enough. > This

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > > The failure cause is in incorrect interrupt processing. > > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > > it executes cs->exception_index

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

Laurent Vivier wrote: > On 10/01/2018 10:21, Laurent Vivier wrote: >> On 10/01/2018 09:47, Juan Quintela wrote: >>> Peter Xu wrote: On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: > Argument file is also needed there. > >

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180108

On 10 January 2018 at 10:37, luigi burdo wrote: > Hi devs sorry if i enter in the discussion about. > > gcc gave errors in building this queue. > > here i paste my build log. > > https://pastebin.com/fXw2Whrq Thanks. This is the relevant bit of the log:

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180108

Hi devs sorry if i enter in the discussion about. gcc gave errors in building this queue. here i paste my build log. https://pastebin.com/fXw2Whrq This is my machine infos and so and so Architecture:ppc64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Big Endian CPU(s):

Re: [Qemu-devel] [PATCH v1 05/21] RISC-V CPU Helpers

On Tue, Jan 2, 2018 at 11:12 PM, Richard Henderson wrote: >> +case CSR_MISA: { >> +if (!(val_to_write & (1L << ('F' - 'A' { >> +val_to_write &= ~(1L << ('D' - 'A')); >> +} >> + >> +/* allow MAFDC bits in MISA to be modified

Re: [Qemu-devel] [Qemu-discuss] ppc and icount

On 10 January 2018 at 08:57, Steven Seeger wrote: > Sorry for another post. I did a bisect and found what is the bad commit for > me: > > 044897ef4a22af89aecb8df509477beba0a2e0ce is the first bad commit > commit 044897ef4a22af89aecb8df509477beba0a2e0ce > Author:

Re: [Qemu-devel] [PATCH v21 2/5 RESEND] virtio-balloon: VIRTIO_BALLOON_F_SG

On 01/09/2018 10:42 PM, Tetsuo Handa wrote: Wei Wang wrote: - enable OOM to free inflated pages maintained in the local temporary list. I do want to see it before applying this patch. Fine, then what do you think of the method I shared in your post here:

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > The failure cause is in incorrect interrupt processing. > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > it executes cs->exception_index = excp_idx; > > This assumes, that the exception will be

Re: [Qemu-devel] [PATCH v5 3/7] vhost: Simplify ring verification checks

On Mon, 8 Jan 2018 17:54:50 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Mon, 18 Dec 2017 20:13:36 + > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

On 10/01/2018 10:21, Laurent Vivier wrote: > On 10/01/2018 09:47, Juan Quintela wrote: >> Peter Xu wrote: >>> On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: Argument file is also needed there. Signed-off-by: Juan Quintela >>>

Re: [Qemu-devel] [PATCH 0/2] target/arm: split out vfp_expand_imm

Richard Henderson writes: > One more piece of target/arm prep work from my SVE branch. > > I saw that Alex was touching the same bit of code in his ARMv8.2 > fp16 patch set and thought we should coordinate on this. Thanks, I'll roll them into my series. > > > r~

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

> -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Wednesday, January 10, 2018 12:51 PM > To: Pavel Dovgalyuk > Cc: 'Pavel Dovgalyuk'; qemu-devel@nongnu.org; m...@redhat.com; > dgilb...@redhat.com; > maria.klimushenk...@ispras.ru; pbonz...@redhat.com >

[Qemu-devel] [PATCH v3] hpet: recover timer offset correctly

HPET saves its state by calculating the current time and recovers timer offset using this calculated value. But these calculations include divisions and multiplications. Therefore the timer state cannot be recovered precise enough. This patch introduces saving of the original value of the offset

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

ping On 12/28/2017 12:36 PM, Denis V. Lunev wrote: From: Edgar Kaziakhmedov According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start communication over tcp

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

"Pavel Dovgalyuk" wrote: >> From: Juan Quintela [mailto:quint...@redhat.com] >> "Pavel Dovgalyuk" wrote: >> >> From: Juan Quintela [mailto:quint...@redhat.com] >> If you *don't* use a needed function then please just increase the >> version. You are just

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

Hi Philippe, Am 2018-01-09 19:16, schrieb Philippe Mathieu-Daudé: Hi Michael, Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: Create the SDCard in the realize() function. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 24

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

On Wed, 10 Jan 2018 11:28:59 +0200 Marcel Apfelbaum wrote: > On 09/01/2018 14:51, Cornelia Huck wrote: > > On Tue, 9 Jan 2018 13:08:33 +0200 > > Yuval Shaia wrote: > > > >> On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: > >>> On

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

> From: Juan Quintela [mailto:quint...@redhat.com] > "Pavel Dovgalyuk" wrote: > >> From: Juan Quintela [mailto:quint...@redhat.com] > If you *don't* use a needed function then please just increase the > version. You are just breaking compatibility anyways. The whole point >

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

On 09/01/2018 14:51, Cornelia Huck wrote: On Tue, 9 Jan 2018 13:08:33 +0200 Yuval Shaia wrote: On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: On Sun, 7 Jan 2018 14:32:23 +0200 Marcel Apfelbaum wrote: diff --git

[Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

Signed-off-by: Fam Zheng --- qapi/block-core.json | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e94a6881b2..fd6c94454d 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2237,7

[Qemu-devel] [PATCH v4 7/9] block: Move NVMe constants to a separate header

Signed-off-by: Fam Zheng --- block/nvme.c | 7 +- hw/block/nvme.h | 698 +- include/block/nvme.h | 700 +++ 3 files changed, 702 insertions(+), 703 deletions(-) create

[Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

This is a new protocol driver that exclusively opens a host NVMe controller through VFIO. It achieves better latency than linux-aio by completely bypassing host kernel vfs/block layer. $rw-$bs-$iodepth linux-aio nvme:// randread-4k-1

<    1   2   3   4   >