[Qemu-devel] [PATCH] allow to build with older sed

2018-01-18 Thread Jan Beulich
sed's -E option may not be supported by older distros. As there's no point using sed here at all, use just shell mechanisms to establish the variable values, starting from the stem instead of the full target. Signed-off-by: Jan Beulich --- a/Makefile +++ b/Makefile @@ -242,8

Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions

2018-01-18 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2018 07:35, Pavel Dovgalyuk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 12/01/2018 13:07, Pavel Dovgalyuk wrote: > >>> > >>> I can't build current version of qemu on Windows. > >>> For the first time this

Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions

2018-01-18 Thread Paolo Bonzini
On 19/01/2018 07:35, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 12/01/2018 13:07, Pavel Dovgalyuk wrote: >>> >>> I can't build current version of qemu on Windows. >>> For the first time this happened when capstone was included into the build. >> >> I've fixed

Re: [Qemu-devel] [PATCH v5 0/4] cryptodev: add vhost support

2018-01-18 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1516329752.git.arei.gong...@huawei.com Subject: [Qemu-devel] [PATCH v5 0/4]

Re: [Qemu-devel] [PATCH v5 0/4] cryptodev: add vhost support

2018-01-18 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1516329752.git.arei.gong...@huawei.com Subject: [Qemu-devel] [PATCH v5 0/4]

Re: [Qemu-devel] [PATCH v2 00/16] target/arm: Prepatory work for SVE

2018-01-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180119045438.28582-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/16] target/arm: Prepatory work for SVE === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v5 1/4] cryptodev: add vhost-user as a new cryptodev backend

2018-01-18 Thread Jay Zhou
From: Gonglei Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by:

[Qemu-devel] [PATCH v5 2/4] cryptodev: add vhost support

2018-01-18 Thread Jay Zhou
From: Gonglei Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the

[Qemu-devel] [PATCH v5 3/4] cryptodev-vhost-user: add crypto session handler

2018-01-18 Thread Jay Zhou
From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by:

[Qemu-devel] [PATCH v5 0/4] cryptodev: add vhost support

2018-01-18 Thread Jay Zhou
From: Gonglei I posted the RFC verion a few months ago for DPDK vhost-crypto implmention, and now it's time to send the formal version. Because we need an user space scheme for better performance. The vhost user crypto server side patches had been sent to DPDK

[Qemu-devel] [PATCH v5 4/4] cryptodev-vhost-user: set the key length

2018-01-18 Thread Jay Zhou
From: Gonglei Signed-off-by: Gonglei --- backends/cryptodev-vhost-user.c | 4 include/sysemu/cryptodev-vhost-user.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/backends/cryptodev-vhost-user.c

Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions

2018-01-18 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 12/01/2018 13:07, Pavel Dovgalyuk wrote: > > > > I can't build current version of qemu on Windows. > > For the first time this happened when capstone was included into the build. > > I've fixed it now. Is upstream version ok? I still

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 17:15, Alexey Kardashevskiy wrote: > On 19/01/18 16:19, David Gibson wrote: >> On Fri, Jan 19, 2018 at 04:09:06PM +1100, Alexey Kardashevskiy wrote: >>> There is already 'device-list-properties' which does most of the job, >>> however it does not handle everything returned by

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 16:19, David Gibson wrote: > On Fri, Jan 19, 2018 at 04:09:06PM +1100, Alexey Kardashevskiy wrote: >> There is already 'device-list-properties' which does most of the job, >> however it does not handle everything returned by qom-list-types such >> as machines as they inherit directly

Re: [Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-01-18 Thread David Gibson
On Tue, Dec 19, 2017 at 03:59:59PM +0100, Paolo Bonzini wrote: > On 19/12/2017 15:09, Alex Williamson wrote: > > On Tue, 19 Dec 2017 12:12:35 +0100 > > Paolo Bonzini wrote: > > > >> On 12/12/2017 06:46, Alex Williamson wrote: > +enum IOMMUMemoryRegionAttr { > +

Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps

2018-01-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180119050005.29392-1-sjitindarsi...@gmail.com Subject: [Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v4 5/7] target/m68k: add moves

2018-01-18 Thread Richard Henderson
On 01/18/2018 11:38 AM, Laurent Vivier wrote: > and introduce SFC and DFC control registers. > > Signed-off-by: Laurent Vivier > --- > v4: remove QEMU_SFC and QEMU_DFC > use directly tb->flags > v2: copy bit 2 of SFC and DFC to tb->flags to > inline memory access in

Re: [Qemu-devel] [PATCH v4 2/7] target/m68k: add MC68040 MMU

2018-01-18 Thread Richard Henderson
On 01/18/2018 11:38 AM, Laurent Vivier wrote: > Only add MC68040 MMU page table processing and related > registers (Special Status Word, Translation Control Register, > User Root Pointer and Supervisor Root Pointer). > > Transparent Translation Registers, DFC/SFC and pflush/ptest > will be added

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-01-18 Thread David Gibson
On Fri, Jan 19, 2018 at 04:09:06PM +1100, Alexey Kardashevskiy wrote: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 2/7] target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 16:00, Suraj Jitindar Singh wrote: > The vmstate description and the contained needed function for migration > of spapr_caps is the same for each cap, with the name of the cap > substituted. As such introduce a macro to allow for easier generation of > these. > > Convert the three

[Qemu-devel] [QEMU-PPC] [PATCH V5 7/7] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-18 Thread Suraj Jitindar Singh
The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query behaviours and available characteristics of the cpu. Implement the handler for this new H-Call which formulates its response based on the setting of the spapr_caps cap-cfpc, cap-sbbc and cap-ibs. Signed-off-by: Suraj Jitindar

Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 2/7] target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate

2018-01-18 Thread David Gibson
On Fri, Jan 19, 2018 at 04:00:00PM +1100, Suraj Jitindar Singh wrote: > The vmstate description and the contained needed function for migration > of spapr_caps is the same for each cap, with the name of the cap > substituted. As such introduce a macro to allow for easier generation of > these. >

[Qemu-devel] [PATCH v2 15/16] target/arm: Simplify fp_exception_el for user-only

2018-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index c0e5f321c5..44814af99b 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@

[Qemu-devel] [PATCH v2 12/16] target/arm: Add ZCR_ELx

2018-01-18 Thread Richard Henderson
Define ZCR_EL[1-3]. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 target/arm/helper.c | 80 + 2 files changed, 85 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index

[Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-01-18 Thread Alexey Kardashevskiy
There is already 'device-list-properties' which does most of the job, however it does not handle everything returned by qom-list-types such as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. This adds a new qom-list-properties command which prints properties of a specific

[Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-18 Thread Richard Henderson
Save the high parts of the Zregs and all of the Pregs. The ZCR_ELx registers are migrated via the CP mechanism. Signed-off-by: Richard Henderson --- target/arm/machine.c | 53 1 file changed, 53 insertions(+)

[Qemu-devel] [QEMU-PPC] [PATCH V5 3/7] target/ppc/spapr_caps: Add support for tristate spapr_capabilities

2018-01-18 Thread Suraj Jitindar Singh
spapr_caps are used to represent the level of support for various capabilities related to the spapr machine type. Currently there is only support for boolean capabilities. Add support for tristate capabilities by implementing their get/set functions. These capabilities can have the values 0, 1 or

[Qemu-devel] [QEMU-PPC] [PATCH V5 6/7] target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch

2018-01-18 Thread Suraj Jitindar Singh
Add new tristate cap cap-ibs to represent the indirect branch serialisation capability. Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson --- V4 -> V5: - Use macro to generate migration state --- hw/ppc/spapr.c | 2

[Qemu-devel] [PATCH v2 06/16] target/arm: Add aa{32, 64}_vfp_{dreg, qreg} helpers

2018-01-18 Thread Richard Henderson
Helpers that return a pointer into env->vfp.regs so that we isolate the logic of how to index the regs array for different cpu modes. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 27 +++ linux-user/signal.c| 22

[Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps

2018-01-18 Thread Suraj Jitindar Singh
The following patch series adds 3 new tristate capabilities and their associated handling. A new H-Call is implemented which a guest will use to query the requirement for and availability of workarounds for certain cpu behaviours. Applies on top of David's tree: ppc-for-2.12 The main changes

[Qemu-devel] [QEMU-PPC] [PATCH V5 5/7] target/ppc/spapr_caps: Add new tristate cap safe_bounds_check

2018-01-18 Thread Suraj Jitindar Singh
Add new tristate cap cap-sbbc to represent the speculation barrier bounds checking capability. Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson --- V4 -> V5: - Use macro to generate migration state --- hw/ppc/spapr.c

[Qemu-devel] [PATCH v2 10/16] target/arm: Add ARM_FEATURE_SVE

2018-01-18 Thread Richard Henderson
Not enabled anywhere so far. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 132da359b5..0a923e42d8 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1371,6

[Qemu-devel] [PATCH v2 08/16] target/arm: Expand vector registers for SVE

2018-01-18 Thread Richard Henderson
Change vfp.regs as a uint64_t to vfp.zregs as an ARMVectorReg. The previous patches have made the change in representation relatively painless. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 57 ++

[Qemu-devel] [QEMU-PPC] [PATCH V5 2/7] target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate

2018-01-18 Thread Suraj Jitindar Singh
The vmstate description and the contained needed function for migration of spapr_caps is the same for each cap, with the name of the cap substituted. As such introduce a macro to allow for easier generation of these. Convert the three existing spapr_caps (htm, vsx, and dfp) to use this macro.

[Qemu-devel] [QEMU-PPC] [PATCH V5 4/7] target/ppc/spapr_caps: Add new tristate cap safe_cache

2018-01-18 Thread Suraj Jitindar Singh
Add new tristate cap cap-cfpc to represent the cache flush on privilege change capability. Signed-off-by: Suraj Jitindar Singh Reviewed-by: David Gibson --- V4 -> V5: - Use macro to generate migration state --- hw/ppc/spapr.c |

[Qemu-devel] [PATCH v2 14/16] target/arm: Hoist store to flags output in cpu_get_tb_cpu_state

2018-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 9e673bb672..c0e5f321c5 100644 --- a/target/arm/helper.c

[Qemu-devel] [PATCH v2 05/16] target/arm: Change the type of vfp.regs

2018-01-18 Thread Richard Henderson
All direct users of this field want an integral value. Drop all of the extra casting between uint64_t and float64. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- target/arm/arch_dump.c | 4 ++-- target/arm/helper.c| 20

[Qemu-devel] [QEMU-PPC] [PATCH V5 1/7] target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch]

2018-01-18 Thread Suraj Jitindar Singh
Add three new kvm capabilities used to represent the level of host support for three corresponding workarounds. Host support for each of the capabilities is queried through the new ioctl KVM_PPC_GET_CPU_CHAR which returns four uint64 quantities. The first two, character and behaviour, represent

[Qemu-devel] [PATCH v2 02/16] target/arm: Use pointers in crypto helpers

2018-01-18 Thread Richard Henderson
Rather than passing regnos to the helpers, pass pointers to the vector registers directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH v2 13/16] target/arm: Move cpu_get_tb_cpu_state out of line

2018-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h| 127 +--- target/arm/helper.c | 126 +++ 2 files changed, 128 insertions(+), 125 deletions(-) diff --git

[Qemu-devel] [PATCH v2 16/16] target/arm: Add SVE state to TB->FLAGS

2018-01-18 Thread Richard Henderson
Add both SVE exception state and vector length. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 4 target/arm/helper.c | 23 ++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h

[Qemu-devel] [PATCH v2 03/16] target/arm: Use pointers in neon zip/uzp helpers

2018-01-18 Thread Richard Henderson
Rather than passing regnos to the helpers, pass pointers to the vector registers directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH v2 04/16] target/arm: Use pointers in neon tbl helper

2018-01-18 Thread Richard Henderson
Rather than passing a regno to the helper, pass pointers to the vector register directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH v2 09/16] target/arm: Add predicate registers for SVE

2018-01-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 57d805b5d8..132da359b5 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -186,6 +186,15 @@ typedef

[Qemu-devel] [PATCH v2 07/16] vmstate: Add VMSTATE_UINT64_SUB_ARRAY

2018-01-18 Thread Richard Henderson
At the same time, move VMSTATE_UINT32_SUB_ARRAY beside the other UINT32 definitions. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/migration/vmstate.h | 9

[Qemu-devel] [PATCH v2 01/16] target/arm: Mark disas_set_insn_syndrome inline

2018-01-18 Thread Richard Henderson
If it isn't used when translate.h is included, we'll get a compiler Werror. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 2 +- 1 file

[Qemu-devel] [PATCH v2 00/16] target/arm: Prepatory work for SVE

2018-01-18 Thread Richard Henderson
I believe that this addresses all of the comments Peter had with respect to v1. I did go ahead and add the system registers, so that I could figure out how they're supposed to work. This has been rebased to master so that it has no dependencies. r~ Richard Henderson (16): target/arm: Mark

Re: [Qemu-devel] [PATCH qemu 0/3] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 09:13:34AM +0100, Paolo Bonzini wrote: > On 16/01/2018 21:46, Alex Williamson wrote: > > On Mon, 15 Jan 2018 15:12:07 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 03/01/18 04:51, Paolo Bonzini wrote: > >>> On 02/01/2018 06:28, Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 14:25, Alex Williamson wrote: > On Fri, 19 Jan 2018 13:41:41 +1100 > Alexey Kardashevskiy wrote: > >> On 19/01/18 08:59, Alex Williamson wrote: >>> On Tue, 16 Jan 2018 16:17:58 +1100 >>> Alexey Kardashevskiy wrote: >>> On 06/01/18 02:29, Alex

Re: [Qemu-devel] [PATCH v2] target/ppc: add support for hypervisor doorbells on book3s CPUs

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 03:54:03PM +0100, Cédric Le Goater wrote: > The hypervisor doorbells are used by skiboot and Linux on POWER9 > processors to wake up secondaries. > > This adds processor control support to the Server architecture by > reusing the Embedded support. They are very similar,

Re: [Qemu-devel] [PATCH] sii3112: Add explicit type casts to avoid unintended sign extension

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 07:18:59PM +0100, BALATON Zoltan wrote: > Noticed by Coverity > > Reported-by: Peter Maydell > Signed-off-by: BALATON Zoltan Applied to ppc-for-2.12, thanks. > --- > hw/ide/sii3112.c | 10 +- > 1 file changed, 5

Re: [Qemu-devel] [PATCH] sm501: Add missing break to case

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 07:01:19PM +0100, BALATON Zoltan wrote: > Noticed by Coverity, forgotten in 5690d9ece > > Reported-by: Peter Maydell > Signed-off-by: BALATON Zoltan Applied to ppc-for-2.12, thanks. > --- > hw/display/sm501.c | 1 + > 1

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 13:22, David Gibson wrote: > On Thu, Jan 18, 2018 at 04:55:39PM +0100, Andrea Bolognani wrote: >> On Thu, 2018-01-18 at 15:27 +1100, David Gibson wrote: I looked further and device-list-properties looks like it would do the trick; however it doesn't seem to work for machines:

Re: [Qemu-devel] [PATCH v1 1/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-18 Thread Wei Wang
On 01/17/2018 08:31 PM, Juan Quintela wrote: Wei Wang wrote: The new feature enables the virtio-balloon device to receive the hint of guest free pages from the free page vq, and clears the corresponding bits of the free page from the dirty bitmap, so that those free pages

Re: [Qemu-devel] [PULL v4 12/29] intel-iommu: Extend address width to 48 bits

2018-01-18 Thread Michael S. Tsirkin
On Fri, Jan 19, 2018 at 11:34:57AM +0800, Jason Wang wrote: > > > On 2018年01月19日 04:45, Michael S. Tsirkin wrote: > > From: Prasad Singamsetty > > > > The current implementation of Intel IOMMU code only supports 39 bits > > iova address width. This patch provides

Re: [Qemu-devel] [PULL v4 12/29] intel-iommu: Extend address width to 48 bits

2018-01-18 Thread Jason Wang
On 2018年01月19日 04:45, Michael S. Tsirkin wrote: From: Prasad Singamsetty The current implementation of Intel IOMMU code only supports 39 bits iova address width. This patch provides a new parameter (x-aw-bits) for intel-iommu to extend its address width to 48

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-18 Thread Alex Williamson
On Fri, 19 Jan 2018 13:41:41 +1100 Alexey Kardashevskiy wrote: > On 19/01/18 08:59, Alex Williamson wrote: > > On Tue, 16 Jan 2018 16:17:58 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 06/01/18 02:29, Alex Williamson wrote: > >>> On Fri, 5 Jan 2018

Re: [Qemu-devel] [PATCH] Revert "smbus: do not immediately complete commands"

2018-01-18 Thread Michael S. Tsirkin
On Thu, Jan 18, 2018 at 07:55:41PM -0600, miny...@acm.org wrote: > From: Corey Minyard > > This reverts commit 880b1ffe6ec2f0ae25cc4175716227ad275e8b8a. > > The commit being reverted says: > > PIIX4 errata says that "immediate polling of the Host Status Register BUSY >

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 04:55:39PM +0100, Andrea Bolognani wrote: > On Thu, 2018-01-18 at 15:27 +1100, David Gibson wrote: > > > I looked further and device-list-properties looks like it would > > > do the trick; however it doesn't seem to work for machines: > > > > > > {"execute":

Re: [Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-18 Thread Richard Henderson
On 01/18/2018 04:08 PM, Alistair Francis wrote: > Ok, this is not going to be straightforward at all. > > The webkitgtk cmake command hangs when targeting i686 without this > patch. Somewhere in the Yocto build flow this causing some change > resulting in that hang. I don't know how to find out

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 08:59, Alex Williamson wrote: > On Tue, 16 Jan 2018 16:17:58 +1100 > Alexey Kardashevskiy wrote: > >> On 06/01/18 02:29, Alex Williamson wrote: >>> On Fri, 5 Jan 2018 10:48:07 +0100 >>> Auger Eric wrote: >>> Hi Alexey, On

[Qemu-devel] [PATCH] Revert "smbus: do not immediately complete commands"

2018-01-18 Thread minyard
From: Corey Minyard This reverts commit 880b1ffe6ec2f0ae25cc4175716227ad275e8b8a. The commit being reverted says: PIIX4 errata says that "immediate polling of the Host Status Register BUSY bit may indicate that the SMBus is NOT busy." Due to this, some code

Re: [Qemu-devel] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller

2018-01-18 Thread BALATON Zoltan
On Thu, 18 Jan 2018, Peter Maydell wrote: On 11 January 2018 at 04:59, David Gibson wrote: From: BALATON Zoltan This is a common generic PCI SATA controller that is also used in PCs but more importantly guests running on the Sam460ex board

Re: [Qemu-devel] [PULL 03/11] sm501: Add some more unimplemented registers

2018-01-18 Thread BALATON Zoltan
On Thu, 18 Jan 2018, Peter Maydell wrote: On 11 January 2018 at 04:59, David Gibson wrote: From: BALATON Zoltan These are not really implemented (just return zero or default values) but add these so guests accessing them can run.

[Qemu-devel] [PATCH] sm501: Add missing break to case

2018-01-18 Thread BALATON Zoltan
Noticed by Coverity, forgotten in 5690d9ece Reported-by: Peter Maydell Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 4f7dc59b2..134cbed 100644

[Qemu-devel] [PATCH] sii3112: Add explicit type casts to avoid unintended sign extension

2018-01-18 Thread BALATON Zoltan
Noticed by Coverity Reported-by: Peter Maydell Signed-off-by: BALATON Zoltan --- hw/ide/sii3112.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index e2f5562..17aa930 100644 ---

Re: [Qemu-devel] [PULL 00/19] machine queue, 2018-01-18

2018-01-18 Thread Haozhong Zhang
On 01/18/18 19:20 -0200, Eduardo Habkost wrote: > On Thu, Jan 18, 2018 at 03:22:05PM +, Peter Maydell wrote: > > On 18 January 2018 at 02:09, Eduardo Habkost wrote: > > > The following changes since commit > > > 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: > > > > > >

Re: [Qemu-devel] [PATCH for-2.11] vfio: Fix vfio-kvm group registration

2018-01-18 Thread Alexey Kardashevskiy
On 19/01/18 09:15, Alex Williamson wrote: > On Thu, 18 Jan 2018 20:29:48 +1100 > Alexey Kardashevskiy wrote: > >> On 06/12/17 12:30, Alex Williamson wrote: >>> On Wed, 6 Dec 2017 12:02:01 +1100 >>> Alexey Kardashevskiy wrote: >>> On 06/12/17 08:09, Alex

Re: [Qemu-devel] [PATCH v1 1/1] linux-user: Fix webkitgtk hangs on 32-bit x86 target

2018-01-18 Thread Alistair Francis
On Wed, Jan 17, 2018 at 9:46 PM, Alistair Francis wrote: > On Wed, Jan 17, 2018 at 4:57 PM, Richard Henderson wrote: >> On 01/17/2018 12:39 PM, Alistair Francis wrote: >>> Since commit "linux-user: Tidy and enforce reserved_va initialization" >>>

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 02:30:27PM -0600, Eric Blake wrote: > On 01/18/2018 02:11 AM, Alexey Kardashevskiy wrote: > > I think you just assert() for this. The only way these could get a > different value is if there's a bug elsewhere. > >>> > >>> > >>> Why not return H_HARDWARE or other

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 07:11:41PM +1100, Alexey Kardashevskiy wrote: > On 18/01/18 16:53, David Gibson wrote: > > On Thu, Jan 18, 2018 at 04:44:28PM +1100, Alexey Kardashevskiy wrote: > >> On 18/01/18 16:20, David Gibson wrote: > >>> On Mon, Jan 15, 2018 at 05:32:35PM +1100, Suraj Jitindar Singh

Re: [Qemu-devel] [PULL 01/12] target-ppc: optimize cmp translation

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 05:36:40PM +0100, Paolo Bonzini wrote: > On 08/01/2018 06:53, David Gibson wrote: > > From: "pbonz...@redhat.com" > > > > We know that only one bit (in addition to SO) is going to be set in > > the condition register, so do two movconds instead of

Re: [Qemu-devel] [PATCH 2/3] spapr_cpu_core: don't reset CPUs during realization

2018-01-18 Thread David Gibson
On Thu, Jan 18, 2018 at 04:39:30PM +0100, Greg Kurz wrote: > On Thu, 18 Jan 2018 14:43:40 +1100 > David Gibson wrote: > > > On Wed, Jan 17, 2018 at 10:20:35AM +0100, Greg Kurz wrote: > > > When QEMU is started, all cold-plugged CPUs are reset twice: first > > >

Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface

2018-01-18 Thread Eric Blake
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > v2: > 01: tweak comment > add Eric's r-b > 02: new patch > 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter > 04: add Eric's r-b > 05: improve commit message > tweak comment > 06: rebase on 03 changes >

Re: [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove

2018-01-18 Thread Eric Blake
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/201 | 159 > + > tests/qemu-iotests/201.out | 5 ++ > tests/qemu-iotests/group | 1

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 05:19:56PM -0500, Paolo Bonzini wrote: > > - Eduardo Habkost ha scritto: > > We can do some effort to document the preferred convention to > > return success/failure, but I don't think we will be able to > > convert the existing void/ret/bool

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Paolo Bonzini
- Eduardo Habkost ha scritto: > We can do some effort to document the preferred convention to > return success/failure, but I don't think we will be able to > convert the existing void/ret/bool functions to a single style > (whatever it is) in a reasonable time. > >

Re: [Qemu-devel] [PATCH for-2.11] vfio: Fix vfio-kvm group registration

2018-01-18 Thread Alex Williamson
On Thu, 18 Jan 2018 20:29:48 +1100 Alexey Kardashevskiy wrote: > On 06/12/17 12:30, Alex Williamson wrote: > > On Wed, 6 Dec 2017 12:02:01 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 06/12/17 08:09, Alex Williamson wrote: > >>> Commit 8c37faa475f3

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-18 Thread Eric Blake
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we s/export removing/removing an export/ > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-18 Thread Alex Williamson
On Tue, 16 Jan 2018 16:17:58 +1100 Alexey Kardashevskiy wrote: > On 06/01/18 02:29, Alex Williamson wrote: > > On Fri, 5 Jan 2018 10:48:07 +0100 > > Auger Eric wrote: > > > >> Hi Alexey, > >> > >> On 15/12/17 07:29, Alexey Kardashevskiy wrote: > >>>

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-18 Thread Shaun Reitan
Would that make everyone happy? I dont want to work on this feature if it's going to be denied still :) -- Shaun Reitan NDCHost.com -- Original Message -- From: "Jason Wang" To: "Shaun Reitan" ; "Eric Blake" ;

Re: [Qemu-devel] [PULL v4 09/29] pci/shpc: Move function to generic header file

2018-01-18 Thread Eric Blake
On 01/18/2018 02:44 PM, Michael S. Tsirkin wrote: > From: Yuval Shaia > > This function should be declared in generic header file so we can > utilize it. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Yuval Shaia >

Re: [Qemu-devel] [PATCH v7 11/14] sdhci: implement the Host Control 2 register for the tunning sequence

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 06:40 PM, Eric Blake wrote: > On 01/18/2018 02:40 PM, Philippe Mathieu-Daudé wrote: >> [based on a patch from Alistair Francis >> from qemu/xilinx tag xilinx-v2015.2] > > In the subject, did you mean s/tunning/tuning/? I did the same mistake in the

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 8/9] xlnx-zynqmp-pmu: Connect the IPI device to the PMU

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 03:38 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Reviewed-by: Edgar E. Iglesias > --- > V4: > - Move the IPI to the machine instead of the SoC > > hw/microblaze/xlnx-zynqmp-pmu.c | 31

Re: [Qemu-devel] [PATCH v7 11/14] sdhci: implement the Host Control 2 register for the tunning sequence

2018-01-18 Thread Eric Blake
On 01/18/2018 02:40 PM, Philippe Mathieu-Daudé wrote: > [based on a patch from Alistair Francis > from qemu/xilinx tag xilinx-v2015.2] In the subject, did you mean s/tunning/tuning/? -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2018-01-18 Thread bzt bzt
Dear All, Since you still haven't merged Alistair's patch, I decided to include it in my own. I've shrinked the number of modified files to two, that's the bare minimum to support "-M raspi3" switch. Bcm2836.c modified minimally, the rest is in raspi.c. I've renamed raspi2_init() to raspi_init()

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 02:34:39PM -0600, Eric Blake wrote: > On 01/18/2018 09:55 AM, Philippe Mathieu-Daudé wrote: > > On Thu, Jan 18, 2018 at 9:03 AM, Paolo Bonzini wrote: > >> On 18/01/2018 12:21, Philippe Mathieu-Daudé wrote: > I'm not a fan of bool return types, in

Re: [Qemu-devel] [PATCH v6 6/9] xlnx-zynqmp-pmu: Connect the PMU interrupt controller

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 03:38 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé > --- > > hw/microblaze/xlnx-zynqmp-pmu.c | 24

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 5/9] xlnx-pmu-iomod-intc: Add the PMU Interrupt controller

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 03:38 PM, Alistair Francis wrote: > Add the PMU IO Module Interrupt controller device. > > Signed-off-by: Alistair Francis > Reviewed-by: Edgar E. Iglesias > --- > > default-configs/microblaze-softmmu.mak | 1 + >

Re: [Qemu-devel] [PATCH v6 1/9] microblaze: boot.c: Don't try to find NULL pointer

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 03:37 PM, Alistair Francis wrote: > Previously if no device tree was passed to microblaze_load_kernel() then > qemu_find_file() would try to find a NULL pointer. To avoid this put a > check around qemu_find_file(). > > Signed-off-by: Alistair Francis >

Re: [Qemu-devel] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add

2018-01-18 Thread Eric Blake
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > Support name parameter for HMP too. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hmp.c | 3 ++- > hmp-commands.hx | 9 + > 2 files changed, 7 insertions(+), 5 deletions(-) > >

[Qemu-devel] [PULL v4 29/29] vhost: remove assertion to prevent crash

2018-01-18 Thread Michael S. Tsirkin
From: Jay Zhou QEMU will assert on vhost-user backed virtio device hotplug if QEMU is using more RAM regions than VHOST_MEMORY_MAX_NREGIONS (for example if it were started with a lot of DIMM devices). Fix it by returning error instead of asserting and let callers of

Re: [Qemu-devel] [PULL 00/19] machine queue, 2018-01-18

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 03:22:05PM +, Peter Maydell wrote: > On 18 January 2018 at 02:09, Eduardo Habkost wrote: > > The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: > > > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116'

Re: [Qemu-devel] [PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO and CONFIG_VHOST_USER

2018-01-18 Thread Michael S. Tsirkin
On Thu, Jan 18, 2018 at 08:25:36PM +0800, Jay Zhou wrote: > From: Gonglei > > Signed-off-by: Jay Zhou Pls squash with the previous patch. > --- > backends/Makefile.objs | 4 +++- > backends/cryptodev-vhost.c | 57 >

[Qemu-devel] [PULL v4 23/29] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table()

2018-01-18 Thread Michael S. Tsirkin
From: Igor Mammedov at best it's confusing that array for list of tables to be tested against reference tables is allocated within test_acpi_dsdt_table() and at worst it would just overwrite list of tables if they were added before test_acpi_dsdt_table(). Move array

[Qemu-devel] [PULL v4 24/29] tests: acpi: init table descriptor in test_dst_table()

2018-01-18 Thread Michael S. Tsirkin
From: Igor Mammedov remove code duplication and make sure that table descriptor passed in for initialization is in expected state. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v4 28/29] vhost-user: fix misaligned access to payload

2018-01-18 Thread Michael S. Tsirkin
We currently take a pointer to a misaligned field of a packed structure. clang reports this as a build warning. A fix is to keep payload in a separate structure, and access is it from there using a vectored write. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c |

[Qemu-devel] [PULL v4 20/29] vhost-user-test: use init_virtio_dev in multiqueue test

2018-01-18 Thread Michael S. Tsirkin
From: Maxime Coquelin Now that init_virtio_dev() has been generalized to all cases, use it in test_multiqueue() to avoid code duplication. Signed-off-by: Maxime Coquelin Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v4 27/29] vhost-user: factor out msg head and payload

2018-01-18 Thread Michael S. Tsirkin
split header and payload into separate structures, to enable easier handling of alignment issues. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 198 + 1 file changed, 101 insertions(+), 97 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-01-18 Thread Benjamin Herrenschmidt
On Thu, 2018-01-18 at 14:27 +0100, Cédric Le Goater wrote: > The source and the target machines should have the same realized > objects. I think this is the simplest solution to keep the migration > framework maintainable. Yeah well, it all boils down to qemu migration being completely brain

  1   2   3   4   5   >