Re: [Qemu-devel] [PATCH v2 0/5] tpm: CRB device and cleanups

2018-01-19 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180119141105.29095-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/5] tp

Re: [Qemu-devel] [PATCH] build: fix typo in error message

2018-01-19 Thread Eric Blake
On 01/19/2018 04:32 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Duplicate of: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04178.html https://lists.gnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [PULL 0/1] Dump patches

2018-01-19 Thread Marc-Andre Lureau
Hi On Fri, Jan 19, 2018 at 3:29 PM, Peter Maydell wrote: > On 17 January 2018 at 15:02, Eric Blake wrote: >> On 01/17/2018 08:47 AM, Marc-André Lureau wrote: >>> The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: >>> >>> Merge remote-tracking branch 'remotes/rth/tags/

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-01-19 Thread Andrea Bolognani
On Fri, 2018-01-19 at 17:15 +1100, Alexey Kardashevskiy wrote: > > I think the existing qom-list interface does this already. > > Nope, it does not. It takes path, not a type, so running with "-machine > none" won't help. > > > This won't solve the libvirt problem we were discussing, because it >

Re: [Qemu-devel] [PATCH v3 0/4] linux-user: select CPU type according ELF header values

2018-01-19 Thread Igor Mammedov
On Fri, 19 Jan 2018 14:56:53 +0100 Laurent Vivier wrote: > Le 17/01/2018 à 16:49, Igor Mammedov a écrit : > > On Tue, 16 Jan 2018 23:22:08 +0100 > > Laurent Vivier wrote: > > > >> This idea has been suggested to me before by Philippe > >> Mathieu-Daudé, and recently YunQiang Su has proposed a >

Re: [Qemu-devel] [PATCH v2 1/5] tpm: lookup cancel path under tpm device class

2018-01-19 Thread Stefan Berger
On 01/19/2018 09:11 AM, Marc-André Lureau wrote: Since Linux commit 313d21eeab9282e, tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger --- hw/t

Re: [Qemu-devel] [PULL 0/1] Dump patches

2018-01-19 Thread Peter Maydell
On 17 January 2018 at 15:02, Eric Blake wrote: > On 01/17/2018 08:47 AM, Marc-André Lureau wrote: >> The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into >> staging (2018-01-16 17:36:39 +) >

Re: [Qemu-devel] [PULL 00/13] ppc-for-2.12 queue 20180119

2018-01-19 Thread Peter Maydell
ble in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180119 > > for you to fetch changes up to 040cb0a2badf9e265cdbb78380048cd1624dd434: > > target/ppc/spapr_caps: Add macro to generate spapr_caps m

[Qemu-devel] [PATCH v3 4/4] target/arm: enable user-mode SHA-3, SM3 and SHA-512 instruction support

2018-01-19 Thread Ard Biesheuvel
Add support for the new ARMv8.2 SHA-3, SM3 and SHA-512 instructions to AArch64 user mode emulation. Signed-off-by: Ard Biesheuvel --- linux-user/elfload.c | 18 ++ target/arm/cpu64.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elf

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Eduardo Habkost
On Fri, Jan 19, 2018 at 02:39:49PM +0100, Igor Mammedov wrote: > On Fri, 19 Jan 2018 11:14:30 -0200 > Eduardo Habkost wrote: > > > On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > > > On Thu, 18 Jan 2018 17:18:09 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Jan 18, 2

[Qemu-devel] [PATCH v2 0/5] tpm: CRB device and cleanups

2018-01-19 Thread Marc-André Lureau
Hi, This series cleans up a bit the TPM IO thread handling, allows to report backend error to hw/frontend, and implements the CRB device. I adapted a previously sent patch "tpm: extend TPM CRB with state migration support" from Stefan, and included an old pending patch "lookup cancel path" in the

[Qemu-devel] [PATCH v3 0/4] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-01-19 Thread Ard Biesheuvel
This v3 is a follow-up to the single patch 'target/arm: implement SHA-512 instructions' sent out on the 9th of January. Changes since v2: - fix thinko in big-endian aware handling of 64-bit quantities: this is not needed given that the NEON registers are represented as arrays of uint64_t so th

[Qemu-devel] [PATCH v3 3/4] target/arm: implement SM3 instructions

2018-01-19 Thread Ard Biesheuvel
This implements emulation of the new SM3 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 143 target/arm/helper.h

[Qemu-devel] [PATCH v3 2/4] target/arm: implement SHA-3 instructions

2018-01-19 Thread Ard Biesheuvel
This implements emulation of the new SHA-3 instructions that have been added as an optional extensions to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 69 + target/arm/helper.h|

[Qemu-devel] [PATCH v3 1/5] qapi: add name parameter to nbd-server-add

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
Allow user to specify name for new export, to not reuse internal node name and to not show it to clients. This also allows creating several exports per device. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- qapi/block.json | 9 +++-- blockdev-nbd.c | 14 +

[Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

2018-01-19 Thread Marc-André Lureau
tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and CRB model at run time, but given that CRB is a simpl

[Qemu-devel] [PATCH v3 1/4] target/arm: implement SHA-512 instructions

2018-01-19 Thread Ard Biesheuvel
This implements emulation of the new SHA-512 instructions that have been added as an optional extensions to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 99 +++- target/arm/helper.h

[Qemu-devel] [PATCH v3 4/5] iotests: implement QemuIoInteractive class

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
Implement QemuIoInteractive to test nbd-server-remove command when there are active connections. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/qemu-iotests/iotests.py

[Qemu-devel] [PATCH v2 2/5] tpm: replace GThreadPool with AIO threadpool

2018-01-19 Thread Marc-André Lureau
The TPM backend uses a GThreadPool to handle IO in a seperate thread. However, GThreadPool isn't integrated with Qemu main loops, making it unnecessarily complicated to deal with. Qemu has a AIO threadpool, that is better integrated with loops and various IO functions, provides completion BH by de

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
18.01.2018 13:09, Paolo Bonzini wrote: On 18/01/2018 10:55, Vladimir Sementsov-Ogievskiy wrote: Most functions that looks at the list are "called with BQL taken". Functions that write to the list are "called with BQL taken" and call bdrv_dirty_bitmaps_lock/bdrv_dirty_bitmaps_unlock themselves.

Re: [Qemu-devel] [PATCH] scripts/qemu-gdb/timers.py: define encoding in header comment

2018-01-19 Thread Alex Bennée
Greg Kurz writes: > This is required otherwise python complains because of the > accentuated letter in Alex's last name: > > Traceback (most recent call last): > File "scripts/qemu-gdb.py", line 29, in > from qemugdb import aio, mtree, coroutine, tcg, timers > File "scripts/qemugdb/time

[Qemu-devel] [PATCH v2 3/5] tpm: report backend request error

2018-01-19 Thread Marc-André Lureau
Use an Error** for request to let the caller handle error reporting. This will also allow to inform the frontend of a backend error. Signed-off-by: Marc-André Lureau --- include/sysemu/tpm.h | 2 +- include/sysemu/tpm_backend.h | 3 ++- backends/tpm.c | 9 +++-- hw/

[Qemu-devel] [PATCH v2 1/5] tpm: lookup cancel path under tpm device class

2018-01-19 Thread Marc-André Lureau
Since Linux commit 313d21eeab9282e, tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau --- hw/tpm/tpm_passthrough.c | 34 ++ 1 file changed, 22 ins

[Qemu-devel] [PATCH v2 5/5] tpm: extend TPM CRB with state migration support

2018-01-19 Thread Marc-André Lureau
From: Stefan Berger We need to synchronize with the backend thread to make sure that a command being processed by the external TPM emulator has completed and its response been received. In case the bottom half did not run, we run the function it is supposed to run. Signed-off-by: Stefan Berger

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-19 Thread Stefan Hajnoczi
The DPDK patch series is here: http://dpdk.org/ml/archives/dev/2018-January/088155.html

[Qemu-devel] [PATCH v3 5/5] iotest 201: new test for qmp nbd-server-remove

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/201 | 156 + tests/qemu-iotests/201.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 162 insertions(+) create mode 100644 tests/qemu-iotests/201 create mode 10064

Re: [Qemu-devel] [PATCH] Revert "smbus: do not immediately complete commands"

2018-01-19 Thread Corey Minyard
On 01/18/2018 09:17 PM, Michael S. Tsirkin wrote: On Thu, Jan 18, 2018 at 07:55:41PM -0600, miny...@acm.org wrote: From: Corey Minyard This reverts commit 880b1ffe6ec2f0ae25cc4175716227ad275e8b8a. The commit being reverted says: PIIX4 errata says that "immediate polling of the Host Stat

[Qemu-devel] [PATCH v3 3/5] iotest 147: add cases to test new @name parameter of nbd-server-add

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/147 | 68 +- tests/qemu-iotests/147.out | 4 +-- 2 files changed, 57 insertions(+), 15 deletions(-) diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotest

[Qemu-devel] [PATCH v3 0/5] nbd export qmp interface

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
v3: hmp patch deleted 02: tweak commit message and comments tweak error message 05: use unix socket instead of tcp (more common practice in iotests, and we do not need port) rebase on new error message in 02 v2: 01: tweak comment add Eric's r-b 02: new patch 03: rewritten, to move

[Qemu-devel] [PATCH V4 16/16] COLO: quick failover process by kick COLO thread

2018-01-19 Thread Zhang Chen
From: zhanghailiang COLO thread may sleep at qemu_sem_wait(&s->colo_checkpoint_sem), while failover works begin, It's better to wakeup it to quick the process. Signed-off-by: zhanghailiang --- migration/colo.c | 8 1 file changed, 8 insertions(+) diff --git a/migration/colo.c b/migra

[Qemu-devel] [PATCH V4 15/16] COLO: notify net filters about checkpoint/failover event

2018-01-19 Thread Zhang Chen
From: zhanghailiang Notify all net filters about the checkpoint and failover event. Signed-off-by: zhanghailiang --- migration/colo.c | 12 1 file changed, 12 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 9eab4a3..10bc80c 100644 --- a/migration/colo.c +++ b

[Qemu-devel] [PATCH v3 2/5] qapi: add nbd-server-remove

2018-01-19 Thread Vladimir Sementsov-Ogievskiy
Add command for removing an export. It is needed for cases when we don't want to keep export after the operation on it was completed. The other example is temporary node, created with blockdev-add. If we want to delete it we should firstly remove corresponding NBD export. Signed-off-by: Vladimir S

[Qemu-devel] [PATCH V4 11/16] savevm: split the process of different stages for loadvm/savevm

2018-01-19 Thread Zhang Chen
From: zhanghailiang There are several stages during loadvm/savevm process. In different stage, migration incoming processes different types of sections. We want to control these stages more accuracy, it will benefit COLO performance, we don't have to save type of QEMU_VM_SECTION_START sections ev

[Qemu-devel] [PATCH V4 13/16] filter: Add handle_event method for NetFilterClass

2018-01-19 Thread Zhang Chen
Filter needs to process the event of checkpoint/failover or other event passed by COLO frame. Signed-off-by: zhanghailiang --- include/net/filter.h | 5 + net/filter.c | 17 + net/net.c| 28 3 files changed, 50 insertions(+)

Re: [Qemu-devel] [PATCH v3 0/4] linux-user: select CPU type according ELF header values

2018-01-19 Thread Laurent Vivier
Le 17/01/2018 à 16:49, Igor Mammedov a écrit : > On Tue, 16 Jan 2018 23:22:08 +0100 > Laurent Vivier wrote: > >> This idea has been suggested to me before by Philippe >> Mathieu-Daudé, and recently YunQiang Su has proposed a >> patch to manage the MIPS r6 case. >> >> Based on this, this series tr

[Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-01-19 Thread Zhang Chen
From: zhanghailiang If some errors happen during VM's COLO FT stage, it's important to notify the users of this event. Together with 'x-colo-lost-heartbeat', Users can intervene in COLO's failover work immediately. If users don't want to get involved in COLO's failover verdict, it is still necess

[Qemu-devel] [PATCH V4 12/16] COLO: flush host dirty ram from cache

2018-01-19 Thread Zhang Chen
From: zhanghailiang Don't need to flush all VM's ram from cache, only flush the dirty pages since last checkpoint Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- migration/ram.c | 12 1 file changed, 12 insertions(+) diff --git a/migration/r

Re: [Qemu-devel] [PATCH v2 01/16] target/arm: Mark disas_set_insn_syndrome inline

2018-01-19 Thread Alex Bennée
Richard Henderson writes: > If it isn't used when translate.h is included, > we'll get a compiler Werror. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate.h | 2 +- > 1 file change

[Qemu-devel] [PATCH V4 09/16] COLO: Flush memory data from ram cache

2018-01-19 Thread Zhang Chen
From: zhanghailiang During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be same with PVM's memory after checkpoint. Instead of flushing all

[Qemu-devel] [PATCH V4 07/16] COLO: Load dirty pages into SVM's RAM cache firstly

2018-01-19 Thread Zhang Chen
From: zhanghailiang We should not load PVM's state directly into SVM, because there maybe some errors happen when SVM is receving data, which will break SVM. We need to ensure receving all data before load the state into SVM. We use an extra memory to cache these data (PVM's ram). The ram cache

[Qemu-devel] [PATCH V4 14/16] filter-rewriter: handle checkpoint and failover event

2018-01-19 Thread Zhang Chen
After one round of checkpoint, the states between PVM and SVM become consistent, so it is unnecessary to adjust the sequence of net packets for old connections, besides, while failover happens, filter-rewriter needs to check if it still needs to adjust sequence of net packets. Signed-off-by: zhang

[Qemu-devel] [PATCH V4 08/16] ram/COLO: Record the dirty pages that SVM received

2018-01-19 Thread Zhang Chen
We record the address of the dirty pages that received, it will help flushing pages that cached into SVM. Here, it is a trick, we record dirty pages by re-using migration dirty bitmap. In the later patch, we will start the dirty log for SVM, just like migration, in this way, we can record both the

[Qemu-devel] [PATCH V4 04/16] COLO: integrate colo compare with colo frame

2018-01-19 Thread Zhang Chen
For COLO FT, both the PVM and SVM run at the same time, only sync the state while it needs. So here, let SVM runs while not doing checkpoint, change DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100. Besides, we forgot to release colo_checkpoint_semd and colo_delay_timer, fix them here. Signed-off-b

[Qemu-devel] [PATCH V4 05/16] COLO: Add block replication into colo process

2018-01-19 Thread Zhang Chen
Make sure master start block replication after slave's block replication started. Besides, we need to activate VM's blocks before goes into COLO state. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen --- migration/colo.c | 46 +

[Qemu-devel] [PATCH V4 06/16] COLO: Remove colo_state migration struct

2018-01-19 Thread Zhang Chen
From: zhanghailiang We need to know if migration is going into COLO state for incoming side before start normal migration. Instead by using the VMStateDescription to send colo_state from source side to destination side, we use MIG_CMD_ENABLE_COLO to indicate whether COLO is enabled or not. Sign

[Qemu-devel] [PATCH V4 03/16] colo-compare: use notifier to notify packets comparing result

2018-01-19 Thread Zhang Chen
It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 32 +--- net/colo-compare.h | 2 ++ 2 files changed, 27 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH V4 01/16] filter-rewriter: fix memory leak for connection in connection_track_table

2018-01-19 Thread Zhang Chen
After a net connection is closed, we didn't clear its releated resources in connection_track_table, which will lead to memory leak. Let't track the state of net connection, if it is closed, its related resources will be cleared up. Signed-off-by: zhanghailiang Signed-off-by: Zhang Chen --- net

[Qemu-devel] [PATCH V4 02/16] colo-compare: implement the process of checkpoint

2018-01-19 Thread Zhang Chen
While do checkpoint, we need to flush all the unhandled packets, By using the filter notifier mechanism, we can easily to notify every compare object to do this process, which runs inside of compare threads as a coroutine. Signed-off-by: zhanghailiang Signed-off-by: Zhang Chen --- include/migra

[Qemu-devel] [PATCH V4 00/16] COLO: integrate colo frame with block replication and COLO proxy

2018-01-19 Thread Zhang Chen
From: Zhang Chen Hi~ COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror, filter-redirector,filter-rewriter) have been exist in qemu for long time, it's time to integrate these three parts to make COLO really works. In this series, we have some optimizations for COLO frame,

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Igor Mammedov
On Fri, 19 Jan 2018 11:14:30 -0200 Eduardo Habkost wrote: > On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > > On Thu, 18 Jan 2018 17:18:09 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > > > > On Wed, 17 Jan 2018 23:48

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 09:12:09PM -0300, Philippe Mathieu-Daudé wrote: > On 01/15/2018 06:29 PM, Pavel Pisa wrote: > >>> +/* open socket */ > >>> +s = socket(PF_CAN, SOCK_RAW, CAN_RAW); > >> > >> I never used it, but I think QEMU uses his socket API: "qemu/sockets.h" > > > > The SocketCAN

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 05:51 AM, Pavel Pisa wrote: > Hello Philippe, > > On Tuesday 16 of January 2018 01:12:09 Philippe Mathieu-Daudé wrote: >> On 01/15/2018 06:29 PM, Pavel Pisa wrote: >>> Hello Philippe, >>> >>> thanks for review. >>> >>> I have updated patch series in can-pci branch in >>> >>> https:

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Paolo Bonzini
On 19/01/2018 13:36, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: Friday, January 19, 2018 3:26 PM >> To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; qemu-devel@nongnu.org >> Cc: kw...@redhat.com; peter.mayd...@linaro.org; boost.li...@gmail.com; >> quint...@redhat.co

Re: [Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-19 Thread Pavel Pisa
Hello Philippe, On Friday 19 of January 2018 13:38:11 Philippe Mathieu-Daudé wrote: > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa > > > > +extern int (*can_bus_connect_to_host_variant)(CanBusState *bus, > > + const char *n

Re: [Qemu-devel] [PATCH v2 18/32] qcow2: Update qcow2_get_cluster_offset() to support L2 slices

2018-01-19 Thread Alberto Garcia
On Tue 16 Jan 2018 11:42:45 PM CET, Eric Blake wrote: > Callers like 'qemu-img map' will potentially have to iterate in more > steps over an entire image; but that's not a severe limitation. The > block_status() functions already document that as long as drivers make > progress, callers must be pr

[Qemu-devel] [PATCH v2] hw/char: remove legacy interface escc_init()

2018-01-19 Thread Laurent Vivier
Move necessary stuff in escc.h and update type names. Remove slavio_serial_ms_kbd_init(). Fix code style problems reported by checkpatch.pl Update mac_newworld, mac_oldworld and sun4m to use directly the QDEV interface. Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- v2: in

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Pavel Dovgalyuk
Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > Sent: Friday, January 19, 2018 3:37 PM > To: 'Paolo Bonzini'; 'Pavel Dovgalyuk'; qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; boost.li...@gmail.com; > quint...@redhat.com

Re: [Qemu-devel] [PULL 00/19] machine queue, 2018-01-18

2018-01-19 Thread Eduardo Habkost
On Fri, Jan 19, 2018 at 08:47:28AM +0800, Haozhong Zhang wrote: > On 01/18/18 19:20 -0200, Eduardo Habkost wrote: > > On Thu, Jan 18, 2018 at 03:22:05PM +, Peter Maydell wrote: > > > On 18 January 2018 at 02:09, Eduardo Habkost wrote: > > > > The following changes since commit > > > > 8e5dc9b

Re: [Qemu-devel] [PATCH V4 6/7] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Deniz Eren > > Signed-off-by: Deniz Eren > Signed-off-by: Pavel Pisa > --- > hw/can/Makefile.objs | 1 + > hw/can/can_pcm3680_pci.c | 336 > +++ > 2 files changed, 337 insertions(+)

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-19 Thread Auger Eric
Hi, On 19/01/18 04:25, Alex Williamson wrote: > On Fri, 19 Jan 2018 13:41:41 +1100 > Alexey Kardashevskiy wrote: > >> On 19/01/18 08:59, Alex Williamson wrote: >>> On Tue, 16 Jan 2018 16:17:58 +1100 >>> Alexey Kardashevskiy wrote: >>> On 06/01/18 02:29, Alex Williamson wrote: > On

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Eduardo Habkost
On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > On Thu, 18 Jan 2018 17:18:09 -0200 > Eduardo Habkost wrote: > > > On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > > > On Wed, 17 Jan 2018 23:48:46 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Jan 17,

Re: [Qemu-devel] [PATCH V4 7/7] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Deniz Eren > > Signed-off-by: Deniz Eren > Signed-off-by: Pavel Pisa > --- > hw/can/Makefile.objs | 1 + > hw/can/can_mioe3680_pci.c | 336 > ++ > 2 files changed, 337 insertions(+)

[Qemu-devel] [RFC 1/2] vhost-user: share the vhost-user protocol related structures

2018-01-19 Thread Stefan Hajnoczi
From: Wei Wang Put the vhost-user protocol related data structures to vhost-user.h, so that they can be used in other implementations (e.g. a slave implementation). Signed-off-by: Wei Wang --- include/hw/virtio/vhost-user.h | 106 + hw/virtio/vhost-user.

[Qemu-devel] [RFC 2/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-19 Thread Stefan Hajnoczi
The virtio-vhost-user device lets a guest act as a vhost device backend. It works by tunneling vhost-user protocol messages into a guest. The new device syntax is as follows: -chardev socket,id=chardev0,path=vhost-user.sock,server,nowait \ -device virtio-vhost-user-pci,chardev=chardev0 The V

[Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-19 Thread Stefan Hajnoczi
These patches implement the virtio-vhost-user device design that I have described here: https://stefanha.github.io/virtio/vhost-user-slave.html#x1-2830007 The goal is to let the guest act as the vhost device backend for other guests. This allows virtual networking and storage appliances to run ins

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 09:57 AM, Philippe Mathieu-Daudé wrote: > Cc'ing Paolo and Marc-André, the "Character device backends" maintainers. > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: >> From: Pavel Pisa >> >> Connection to the real host CAN bus network through >> SocketCAN network interface i

[Qemu-devel] [PATCH v2 7/8] file-posix: account discard operations

2018-01-19 Thread Anton Nefedov
This will help to identify how many of the user-issued discard operations (accounted on a device level) have actually suceeded down on the host file (even though the numbers will not be exactly the same if non-raw format driver is used (e.g. qcow2 sending metadata discards)). Signed-off-by: Anton

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Philippe Mathieu-Daudé
Cc'ing Paolo and Marc-André, the "Character device backends" maintainers. On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > Connection to the real host CAN bus network through > SocketCAN network interface is available only for Linux > host system. Mechanism is generic,

[Qemu-devel] [PATCH v2 3/8] ide: account UNMAP (TRIM) operations

2018-01-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- hw/ide/core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5be72d4..6fdc936 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -443,6 +443,14 @@ static void ide_issue_trim_cb(void *opaque, int ret) Trim

[Qemu-devel] [PATCH v2 6/8] scsi: account unmap operations

2018-01-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/scsi/scsi-disk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 693a754..6881664 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @

[Qemu-devel] [PATCH v2 5/8] scsi: move unmap error checking to the complete callback

2018-01-19 Thread Anton Nefedov
This will help to account the operation in the following commit. The difference is that we don't call scsi_disk_req_check_error() before the 1st discard iteration anymore. That function also checks if the request is cancelled, however it shouldn't get canceled until it yields in blk_aio() function

[Qemu-devel] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats

2018-01-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- qapi/block-core.json | 29 +++-- include/block/accounting.h | 1 + block/qapi.c | 6 ++ 3 files changed, 30 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PATCH v2 4/8] scsi: store unmap offset and nb_sectors in request struct

2018-01-19 Thread Anton Nefedov
it allows to report it in the error handler Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c inde

[Qemu-devel] [PATCH v2 8/8] qapi: query-blockstat: add driver specific file-posix stats

2018-01-19 Thread Anton Nefedov
A block driver can provide a callback to report driver-specific statistics. file-posix driver now reports discard statistics Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 37 + include/block/block.h

[Qemu-devel] [PATCH v2 1/8] qapi: group BlockDeviceStats fields

2018-01-19 Thread Anton Nefedov
Make the stat fields definition slightly more readable. Cosmetic change only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e94a688..2e0665e 100

[Qemu-devel] [PATCH v2 0/8] discard blockstats

2018-01-19 Thread Anton Nefedov
v2: - rebased on top of series 'ide: abort TRIM operation for invalid range' (http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01432.html) Now invalid trim requests are properly accounted - patches 1/2 - qapi fields regrouped together v1: http://lists.nongnu.org/archive/

[Qemu-devel] [RFC virtio-dev v2] vhost-user: add vhost-user device type

2018-01-19 Thread Stefan Hajnoczi
The vhost-user device backend facilitates vhost-user device emulation through vhost-user protocol exchanges and access to shared memory. Software-defined networking, storage, and other I/O appliances can provide services through this device. For more information about virtio-vhost-user, see https:

Re: [Qemu-devel] [PATCH] hw/char: remove legacy interface escc_init()

2018-01-19 Thread Mark Cave-Ayland
On 18/01/18 08:53, Laurent Vivier wrote: Move necessary stuff in escc.h and update type names. Remove slavio_serial_ms_kbd_init(). Fix code style problems reported by checkpatch.pl Update mac_newworld, mac_oldworld and sun4m to use directly the QDEV interface. Signed-off-by: Laurent Vivier ---

[Qemu-devel] [PATCH] ide-test: test trim requests

2018-01-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- tests/ide-test.c | 71 1 file changed, 71 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index aa9de06..259f39f 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -52,6 +52,7 @@ enum {

Re: [Qemu-devel] [PULL v4 00/29] pc, pci, virtio: features, fixes, cleanups

2018-01-19 Thread Peter Maydell
On 18 January 2018 at 20:44, Michael S. Tsirkin wrote: > changes since v3: > - dropped vhost memory rework due to clang warnings > - dropped vhost memslot rework due to merge conflicts > > > The following changes since commit b4d6ed1c5ae519d3efb5297be3ef6625ca2a20f4: > > Merge remote-tracking br

Re: [Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > The CanBusState state structure is created for each > emulated CAN channel. Individual clients/emulated > CAN interfaces or host interface connection registers > to the bus by CanBusClientState structure. > > The CAN cor

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, January 19, 2018 3:26 PM > To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; boost.li...@gmail.com; > quint...@redhat.com; > jasow...@redhat.com; m...@redhat.com; zuban.

Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests

2018-01-19 Thread Cornelia Huck
On Fri, 19 Jan 2018 13:17:29 +0100 Christian Borntraeger wrote: > On 01/18/2018 06:51 PM, Claudio Imbrenda wrote: > > Fix storage attribute migration so that it does not fail for guests > > with more than a few GB of RAM. > > With such guests, the index in the buffer would go out of bounds, > > u

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Paolo Bonzini
On 19/01/2018 13:25, Pavel Dovgalyuk wrote: >>> It means, that I'll have to fix all the has_work function to avoid races, >>> because x86_cpu_has_work may have them? >> Why only x86_cpu_has_work? >> >> Even reading cs->interrupt_request outside the mutex is unsafe. > All the vcpu function that acce

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Pavel Dovgalyuk
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, January 19, 2018 3:20 PM > To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; boost.li...@gmail.com; > quint...@redhat.com; > jasow...@redh

Re: [Qemu-devel] [PATCH] hw/char: remove legacy interface escc_init()

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/18/2018 05:53 AM, Laurent Vivier wrote: > Move necessary stuff in escc.h and update type names. > Remove slavio_serial_ms_kbd_init(). > Fix code style problems reported by checkpatch.pl > Update mac_newworld, mac_oldworld and sun4m to use directly the > QDEV interface. > > Signed-off-by: Lau

Re: [Qemu-devel] [PATCH v7 3/4] ui: fix alphabetical ordering of keymaps

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/17/2018 01:41 PM, Daniel P. Berrange wrote: > The qcode-to-linux keymaps was accidentally added in the wrong place > by > > commit de80d78594b4c3767a12d8d42debcf12cbf85a5b > Author: Owen Smith > Date: Fri Nov 3 11:56:28 2017 + > > ui: generate qcode to linux mappings > > b

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Paolo Bonzini
On 19/01/2018 13:05, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 19/01/2018 09:44, Pavel Dovgalyuk wrote: >>> while (all_cpu_threads_idle()) { >>> +qemu_mutex_lock_iothread(); >>> stop_tcg_kick_timer(); >>> qemu_cond_wait(cpu->halt

Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests

2018-01-19 Thread Christian Borntraeger
On 01/18/2018 06:51 PM, Claudio Imbrenda wrote: > Fix storage attribute migration so that it does not fail for guests > with more than a few GB of RAM. > With such guests, the index in the buffer would go out of bounds, > usually by large amounts, thus receiving -EFAULT from the kernel. > Migrati

Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free

2018-01-19 Thread Thomas Huth
On 19.01.2018 12:44, Laurent Vivier wrote: > t64 is also unconditionally freed after the switch () { ... } > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/m68k/translate.c b/target/m68k/translate.c > index f0e86a73

Re: [Qemu-devel] [PATCH] allow to build with older sed

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 06:28 AM, Daniel P. Berrange wrote: > On Fri, Jan 19, 2018 at 12:52:27AM -0700, Jan Beulich wrote: >> sed's -E option may not be supported by older distros. As there's no >> point using sed here at all, use just shell mechanisms to establish the >> variable values, starting from the s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] build: fix typo in error message

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 07:32 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh > index bc7224a27f..8

Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads

2018-01-19 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2018 09:44, Pavel Dovgalyuk wrote: > > while (all_cpu_threads_idle()) { > > +qemu_mutex_lock_iothread(); > > stop_tcg_kick_timer(); > > qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex); > > +qemu_

Re: [Qemu-devel] [PATCH] s390x/tcg: fixup TEST PROTECTION

2018-01-19 Thread Cornelia Huck
On Fri, 12 Jan 2018 13:54:52 +0100 David Hildenbrand wrote: > CC == 2 can only happen due to a protection exception, not if memory is > not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to > be forwarded to the guest. > > Since the initial definition of TEST PROTECTION, we no

Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests

2018-01-19 Thread Cornelia Huck
On Thu, 18 Jan 2018 18:51:44 +0100 Claudio Imbrenda wrote: > Fix storage attribute migration so that it does not fail for guests > with more than a few GB of RAM. > With such guests, the index in the buffer would go out of bounds, > usually by large amounts, thus receiving -EFAULT from the kernel

Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event

2018-01-19 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2018 09:44, Pavel Dovgalyuk wrote: > > static void qemu_wait_io_event(CPUState *cpu) > > { > > +qemu_mutex_lock_iothread(); > > + > > while (cpu_thread_is_idle(cpu)) { > > qemu_cond_wait(cpu->halt_cond, &qemu_global_m

[Qemu-devel] [PATCH] target/m68k: fix TCG variable double free

2018-01-19 Thread Laurent Vivier
t64 is also unconditionally freed after the switch () { ... } Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index f0e86a73d4..ea18df940a 100644 --- a/target/m68k/translate.c +++ b/tar

Re: [Qemu-devel] [RFC 0/2] memory/vfio: notify region_del() when unregister listeners

2018-01-19 Thread Paolo Bonzini
On 19/01/2018 09:42, Peter Xu wrote: > I encountered an event loss problem during unplugging vfio devices: > > https://bugzilla.redhat.com/show_bug.cgi?id=1531393 > > I thought it should be a simple VT-d issue but I was wrong. The whole > debugging leads me to these patches. > > Basically I t

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2018-01-19 Thread Paolo Bonzini
On 28/07/2017 14:54, Kevin Wolf wrote: > Am 09.07.2017 um 19:06 hat Peter Maydell geschrieben: >> The function vmdk_read_cid() can fail if the read on the underlying >> block device fails, or if there's a format error in the VMDK file. >> However its API doesn't provide a mechanism to report these

Re: [Qemu-devel] [PATCH v3] chardev/char-socket: add POLLHUP handler

2018-01-19 Thread Marc-Andre Lureau
Hi On Fri, Jan 19, 2018 at 11:47 AM, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen character

<    1   2   3   4   >