Re: [Qemu-devel] [PATCH v7 12/15] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

Philippe Mathieu-Daudé writes: > On 02/02/2018 03:37 PM, Markus Armbruster wrote: >> From: Alistair Francis >> >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and

Re: [Qemu-devel] [PATCH v7 15/15] target: Use qemu_log() instead of fprintf(stderr, ...)

Eric Blake writes: > On 02/02/2018 12:37 PM, Markus Armbruster wrote: >> From: Alistair Francis >> >> Convert fprintf(stderr, ...) to use qemu_log(). Double prints in >> target/ppc/translate.c were manually remove. A fprintf() in >>

[Qemu-devel] [PATCH v2 1/3] block/iscsi: drop unused IscsiAIOCB->buf field

The IscsiAIOCB->buf field has not been used since commit e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi requirement to 1.9.0"). It used to be a linear buffer for old libiscsi versions that didn't support scatter-gather. The minimum libiscsi version supports scatter-gather

[Qemu-devel] [PATCH v2 0/3] block/iscsi: fix ioctl cancel use-after-free

v2: * It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this function already protects against duplicate calls internally [Stefan] Patches 1 & 2 are cleanups. Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb is cancelled and then completes

[Qemu-devel] [PATCH v2 2/3] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()

Commit d045c466d9e62b4321fadf586d024d54ddfd8bd4 ("iscsi: do not use aio_context_acquire/release") introduced iscsilun->mutex but appears to have overlooked iscsi_timed_check_events() when introducing the mutex. iscsi_service() and iscsi_set_events() must be called with iscsilun->mutex held.

[Qemu-devel] [PATCH v2 3/3] block/iscsi: fix ioctl cancel use-after-free

iscsi_aio_cancel() does not increment the request's reference count, causing a use-after-free when ABORT TASK finishes after the request has already completed. There are some additional issues with iscsi_aio_cancel(): 1. Several ABORT TASKs may be sent for the same task if iscsi_aio_cancel()

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH RFC 00/21]

Re: [Qemu-devel] [Bug 1703795] Re: Unable to release mouse in SDL2 mode

The patch works for me too. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1703795 Title: Unable to release mouse in SDL2 mode Status in QEMU: New Bug description: Starting with

Re: [Qemu-devel] [PATCH v1 1/1] hw: register: Run post_write hook on reset

On Fri, Feb 2, 2018 at 12:24 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 02/02/2018 04:38 PM, Alistair Francis wrote: >> Ensure that the post write hook is called during reset. This allows us >> to rely on the post write functions instead of having to call them from

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/1]

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/1]

Re: [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi/common.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [Qemu-devel] MTTCG External Halt

On Fri, Feb 2, 2018 at 1:49 PM, Alistair Francis wrote: > On Fri, Feb 2, 2018 at 12:37 PM, Alex Bennée wrote: >> >> Alistair Francis writes: >> >>> On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis >>>

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] block/iscsi: fix ioctl cancel use-after-free

On Fri, Feb 2, 2018 at 10:16 PM, Stefan Hajnoczi wrote: > The ioctl request cancellation code assumes that requests do not > complete once TASK ABORT has been sent to the iSCSI target. The request > completion callback is unconditionally invoked when TASK ABORT finishes. >

Re: [Qemu-devel] rate limiting issues

CCing qemu-block and Berto On 02/02/2018 06:10 AM, Wolfgang Bumiller wrote: > Summary: > Rate limit is effectively halved when the size of written chunks adds up to > exceeding the quota of a slice only slightly. This is surprisingly reliable. > > Explanation: > The ratelimiting code in

Re: [Qemu-devel] MTTCG External Halt

On Fri, Feb 2, 2018 at 12:37 PM, Alex Bennée wrote: > > Alistair Francis writes: > >> On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis >> wrote: >>> On Thu, Feb 1, 2018 at 4:01 AM, Alex Bennée

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

Hi, This series failed build test on ppc host. Please find the details below. Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

[Qemu-devel] [PATCH 2/3] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()

Commit d045c466d9e62b4321fadf586d024d54ddfd8bd4 ("iscsi: do not use aio_context_acquire/release") introduced iscsilun->mutex but appears to have overlooked iscsi_timed_check_events() when introducing the mutex. iscsi_service() and iscsi_set_events() must be called with iscsilun->mutex held.

[Qemu-devel] [PATCH 3/3] block/iscsi: fix ioctl cancel use-after-free

The ioctl request cancellation code assumes that requests do not complete once TASK ABORT has been sent to the iSCSI target. The request completion callback is unconditionally invoked when TASK ABORT finishes. Therefore the request completion callback is invoked twice if the request does happen

[Qemu-devel] [PATCH 0/3] block/iscsi: fix ioctl cancel use-after-free

Patches 1 & 2 are cleanups. Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb is cancelled and then completes twice. The second time around crashes QEMU. Compile-tested only. Felipe: Please let us know if this fixes the issue you are seeing. Thanks! Stefan Hajnoczi

[Qemu-devel] [PATCH 1/3] block/iscsi: drop unused IscsiAIOCB->buf field

The IscsiAIOCB->buf field has not been used since commit e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi requirement to 1.9.0"). It used to be a linear buffer for old libiscsi versions that didn't support scatter-gather. The minimum libiscsi version supports scatter-gather

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/1]

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH RFC 00/21]

Re: [Qemu-devel] MTTCG External Halt

Alistair Francis writes: > On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis > wrote: >> On Thu, Feb 1, 2018 at 4:01 AM, Alex Bennée wrote: >>> >>> Alistair Francis writes: >>>

Re: [Qemu-devel] [PATCH] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

Hi Thomas, On 02/02/2018 05:15 AM, Thomas Huth wrote: > When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: > > CC hw/timer/m48t59.o > CC hw/timer/m48t59-isa.o > hw/timer/m48t59.c: In function ‘NVRAM_writeb’: > hw/timer/m48t59.c:460:5: error: format ‘%x’ expects

Re: [Qemu-devel] [PATCH v1 1/1] hw: register: Run post_write hook on reset

Hi Alistair, On 02/02/2018 04:38 PM, Alistair Francis wrote: > Ensure that the post write hook is called during reset. This allows us > to rely on the post write functions instead of having to call them from > the reset() function. This makes sens. Can you add a comment about this new behavior

Re: [Qemu-devel] [PATCH v7 12/15] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

On 02/02/2018 03:37 PM, Markus Armbruster wrote: > From: Alistair Francis > > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Error messages print absolute filenames of included files even gave a s/even gave/even when given/ > relative one on the command line: > > PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py > tests/qapi-schema/include-cycle.json

Re: [Qemu-devel] [PATCH v7 00/15] Remove some of the fprintf(stderr, "*

On 02/02/2018 03:37 PM, Markus Armbruster wrote: > This is my attempt to salvage a good part of Alistair's error > reporting cleanup series > > [PATCH v6 00/29] Remove some of the fprintf(stderr, "* > > Continue on improving QEMUs logging/error messages by removing more >

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

Re: [Qemu-devel] [PATCH v7 15/15] target: Use qemu_log() instead of fprintf(stderr, ...)

On 02/02/2018 12:37 PM, Markus Armbruster wrote: > From: Alistair Francis > > Convert fprintf(stderr, ...) to use qemu_log(). Double prints in > target/ppc/translate.c were manually remove. A fprintf() in > target/sh4/translate.c was kept as it's inside a #if 0. The

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

Hi, This series failed build test on ppc host. Please find the details below. Subject: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

Re: [Qemu-devel] [PATCH v7 00/15] Remove some of the fprintf(stderr, "*

On Fri, Feb 2, 2018 at 10:37 AM, Markus Armbruster wrote: > This is my attempt to salvage a good part of Alistair's error > reporting cleanup series > > [PATCH v6 00/29] Remove some of the fprintf(stderr, "* > > Continue on improving QEMUs logging/error messages by

[Qemu-devel] [PATCH v1 1/1] hw: register: Run post_write hook on reset

Ensure that the post write hook is called during reset. This allows us to rely on the post write functions instead of having to call them from the reset() function. Signed-off-by: Alistair Francis --- hw/core/register.c | 8 1 file changed, 8 insertions(+)

Re: [Qemu-devel] [PATCH RFC 08/21] qapi: Touch generated files only when they change

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > A massive number of objects depends on QAPI-generated headers. In my > "build everything" tree, it's roughly 4500 out of 4800. This is > particularly annoying when only some of the generated files change, > say for a doc fix. > > Improve

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wang wrote: > On 01/26/2018 10:44 PM, Stefan Hajnoczi wrote: > > On Thu, Jan 25, 2018 at 06:19:13PM +0800, Wei Wang wrote: > > > On 01/24/2018 07:40 PM, Stefan Hajnoczi wrote: > > > > On Tue, Jan 23, 2018 at 09:06:49PM +0800, Wei Wang wrote: > > > > >

Re: [Qemu-devel] [PATCH] kvm: check dev parameter when updating msi route

This should primarily go to the qemu devel list. I've Cc'd it, but reposting would be safer, thanks. 2018-02-02 10:21+0530, P J P: > From: Prasad J Pandit > > When updating message signalled interrupt(MSI) route in routine > kvm_irqchip_update_msi_route, device

Re: [Qemu-devel] [PATCH v7 02/15] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

On 02/02/2018 12:37 PM, Markus Armbruster wrote: > From: Alistair Francis > > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > >

[Qemu-devel] [Bug 1703795] Re: Unable to release mouse in SDL2 mode

I can confirm that the patch from comment #9 appears to fix the original problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1703795 Title: Unable to release mouse in SDL2 mode Status in QEMU:

Re: [Qemu-devel] [PATCH RFC 07/21] qapi: Move parse_command_line() next to its only use

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-gen.py| 52 +++- > scripts/qapi/common.py | 54 > -- > 2 files changed, 51

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Whenever qapi-schema.json changes, we run six programs eleven times to > update eleven files. This is silly. Replace the six programs by a > single program that spits out all eleven files. Yay, about time! One program, but still invoked

[Qemu-devel] [PATCH v7 02/15] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 03/15] hw/dma: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 13/15] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 10/15] hw/sd: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 11/15] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 09/15] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH] mailmap: set preferred spelling for Daniel Berrangé

Signed-off-by: Daniel P. Berrangé --- .mailmap | 4 1 file changed, 4 insertions(+) diff --git a/.mailmap b/.mailmap index ee81ac801e..cf689b9ec9 100644 --- a/.mailmap +++ b/.mailmap @@ -18,3 +18,7 @@ malc malc

Re: [Qemu-devel] [PULL 0/1] Vga 20180202 patches

are available in the git repository at: > > git://git.kraxel.org/qemu tags/vga-20180202-pull-request > > for you to fetch changes up to 34e304e97576a9e17680c868c00ff524a981007b: > > virtio-gpu: disallow vIOMMU (2018-02-02 08:53:22 +0100) > > -

[Qemu-devel] [PATCH v7 15/15] target: Use qemu_log() instead of fprintf(stderr, ...)

From: Alistair Francis Convert fprintf(stderr, ...) to use qemu_log(). Double prints in target/ppc/translate.c were manually remove. A fprintf() in target/sh4/translate.c was kept as it's inside a #if 0. The #if 0 and fflush() was removed around the unimplemented log

[Qemu-devel] [PATCH v7 08/15] hw/pci*: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PULL 0/3] Ui 20180202 patches

the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180202-pull-request > > for you to fetch changes up to 627ebec208a8809818589e17f4fce55a59420ad2: > > ui: correctly advance output buffer when writing SAS

[Qemu-devel] [PATCH v7 07/15] hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 05/15] hw/mips: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 01/15] audio: Replace AUDIO_FUNC with __func__

From: Alistair Francis Apparently we don't use __MSC_VER as a compiler anymore and we always require a C99 compiler (which means we always have __func__) so we don't need a special AUDIO_FUNC macro. We can just replace AUDIO_FUNC with __func__ instead. Checkpatch

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

On Fri, Feb 02, 2018 at 05:23:59PM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > (CCing qemu-devel) > > > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > > On Fri, 2 Feb 2018 14:19:38 + > > > Daniel P. Berrangé

[Qemu-devel] [PATCH v7 12/15] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 14/15] tcg: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH RFC 00/21]

[Qemu-devel] [PATCH v7 04/15] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] [PATCH v7 00/15] Remove some of the fprintf(stderr, "*

This is my attempt to salvage a good part of Alistair's error reporting cleanup series [PATCH v6 00/29] Remove some of the fprintf(stderr, "* Continue on improving QEMUs logging/error messages by removing more fprintf()'s. Unfortunatley my Coccinelle skills aren't that great so

[Qemu-devel] [Bug 1747056] [NEW] FreeDOS / MS-Dos / Windows 3.11 cannot perform reboot with 'isapc' machine

Public bug reported: I was installing MS-Dos 6.22 + Windows 3.11 in preparation for running Microsoft Bob, and noticed that when they try to perform a reboot, they just get stuck. The console cursor stays flashing on/off, but the DOS prompt no longer responds to input. It is fairly easy to

[Qemu-devel] [PATCH v7 06/15] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PULL 0/3] Ui 20180202 patches

gt; > into staging (2018-01-30 09:47:51 +) > > > > are available in the git repository at: > > > > git://git.kraxel.org/qemu tags/ui-20180202-pull-request > > > > for you to fetch changes up to 627ebec208a8809818589e17f4fce55a59420ad2: > > > &g

[Qemu-devel] [PULL v2 05/10] tests: virtio-9p: use the synth backend

The purpose of virtio-9p-test is to test the virtio-9p device, especially the 9p server state machine. We don't really care what fsdev backend we're using. Moreover, if we want to be able to test the flush request or a device reset with in-flights I/O, it is close to impossible to achieve with a

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

On Thu, Feb 01, 2018 at 04:42:05PM -0800, Alistair Francis wrote: > As cpu_type is not a user visible string let's convert the > valid_cpu_types to compare against cpu_model instead. This way we have a > user friendly string to report back. > > Once we have a cpu_type to cpu_model conversion this

[Qemu-devel] rate limiting issues

Summary: Rate limit is effectively halved when the size of written chunks adds up to exceeding the quota of a slice only slightly. This is surprisingly reliable. Explanation: The ratelimiting code in include/qemu/ratelimit.h currently uses slices with quotas. Finishing up the quota for one slice

Re: [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support

On 26 January 2018 at 15:44, Philippe Mathieu-Daudé wrote: > On 01/26/2018 11:33 AM, Peter Maydell wrote: >> On 26 January 2018 at 14:29, Philippe Mathieu-Daudé wrote: >>> Why not use arm_any_initfn() here? >> >> That function (and the 'any' cpu) are

[Qemu-devel] [PULL v2 03/10] tests: virtio-9p: move request tag to the test functions

It doesn't really makes sense to hide the request tag from the test functions. It prevents to test the 9p server behavior when passed a wrong tag (ie, still in use or different from P9_NOTAG for a version request). Also the spec says that a tag is reusable as soon as the corresponding request was

[Qemu-devel] [PATCH v3] tap: close fd conditionally when error occured

If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=net0 will fail too, prints: TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLOAD ioctl() failed: Bad file descriptor The reason is that the fd of tap is closed

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

On Wed, Jan 31, 2018 at 6:06 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: >> git-publish [1] is a convenient tool to send patches and has been >> popular among QEMU developers. Recently it has been made

Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

On 2017-12-04 19:25, Max Reitz wrote: > On 2017-12-04 17:37, Alberto Garcia wrote: >> On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: >>> -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) >>> +static void blkdebug_refresh_filename(BlockDriverState *bs) >>> { >>>

Re: [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > The next commit will introduce a common driver program for all > generators. The generators need to be modules for that. qapi2texi.py > already is. Make the other generators follow suit. > > The changes are actually trivial. Obvious in the

[Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used by all s390

Re: [Qemu-devel] [PATCH] tests/migration: Add source to PC boot block

On 01/31/2018 02:16 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The boot block used in the migration test is currently only > shipped as a hex (with the source in the git commit message), > change this to actually include the source. > > A

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

On Fri, Feb 02, 2018 at 02:03:15PM +0100, Markus Armbruster wrote: > Our qapi-schema.json is composed of modules connected by include > directives, but the generated code is monolithic all the same: one > qapi-types.h with all the types, one qapi-visit.h with all the > visitors, and so forth.

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

* Eduardo Habkost (ehabk...@redhat.com) wrote: > (CCing qemu-devel) > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > On Fri, 2 Feb 2018 14:19:38 + > > Daniel P. Berrangé wrote: > > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote:

[Qemu-devel] [PULL v2 00/10] 9p patches for 2.12 20180202

The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to

Re: [Qemu-devel] [PULL v2 00/10] 9p patches for 2.12 20180202

On 2 February 2018 at 16:19, Greg Kurz wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the git repository

Re: [Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input

On Thu, Feb 01, 2018 at 06:46:46PM -0200, Eduardo Habkost wrote: > On Tue, Jan 16, 2018 at 01:42:14PM +, Daniel P. Berrange wrote: > > From: Miika S > > > > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > > > Signed-off-by: Miika S

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

On 2018-02-02 17:18, Eric Blake wrote: > On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> To maintain load/store disabled bitmap there is new approach: >> >> - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored >> - store enabled bitmaps as "auto" to qcow2 >> -

[Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

This patch - originally from Jing Liu - was still on my disk and somehow dropped of my attention. Here is a fixed up version. It probably still needs some review and polish. One open aspect is migration. Right now QEMU switches from crashed back into running state after migration (even without

[Qemu-devel] [PULL v2 01/10] 9pfs: drop v9fs_register_transport()

No good reasons to do this outside of v9fs_device_realize_common(). Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini --- hw/9pfs/9p.c | 6 +- hw/9pfs/9p.h | 10 ++ hw/9pfs/virtio-9p-device.c | 8 ++--

[Qemu-devel] [PULL 1/1] virtio-gpu: disallow vIOMMU

From: Peter Xu virtio-gpu has special code path that bypassed vIOMMU protection. So for now let's disable iommu_platform for the device until we fully support that (if needed). After the patch, both virtio-vga and virtio-gpu won't allow to boot with iommu_platform parameter

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

On 02/02/2018 09:25 AM, Eduardo Habkost wrote: >>> Markus, Eric: from the QAPI point of view, is it OK to remove >>> fields between QEMU versions, as long as we follow our >>> deprecation policy? >> >> I would expect that to not be OK. A fully backwards compatible way to >> deal with this would

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

02.02.2018 19:18, Eric Blake wrote: On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: To maintain load/store disabled bitmap there is new approach: - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored - store enabled bitmaps as "auto" to qcow2 - store disabled

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

On Thu, Feb 1, 2018 at 6:46 PM, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote: >> Hi >> >> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: >> > git-publish [1] is a convenient tool to send patches and has been

[Qemu-devel] [PULL v2 10/10] tests/virtio-9p: explicitly handle potential integer overflows

Signed-off-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- tests/virtio-9p-test.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/virtio-9p-test.c

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

On 2018-02-02 14:48, Vladimir Sementsov-Ogievskiy wrote: > 02.02.2018 16:00, Max Reitz wrote: >> On 2018-02-02 13:07, Vladimir Sementsov-Ogievskiy wrote: >>> 29.01.2018 18:34, Max Reitz wrote: On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir

Re: [Qemu-devel] [PULL 0/2] Audio 20180202 patches

are available in the git repository at: > > git://git.kraxel.org/qemu tags/audio-20180202-pull-request > > for you to fetch changes up to 8ec660b80ed511fa333679e38bf0cf714799d6fa: > > hw/audio/sb16.c: change dolog() to qem

Re: [Qemu-devel] [PATCH v3 10/12] vl: drop full_screen variable

On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Not used any more, delete it. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: > To maintain load/store disabled bitmap there is new approach: > > - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored > - store enabled bitmaps as "auto" to qcow2 > - store disabled bitmaps without "auto" flag to

Re: [Qemu-devel] [PATCH RFC 04/21] qapi: Reduce use of global variables in generators some

On 02/02/2018 07:03 AM, Markus Armbruster wrote: > In preparation of the next commit, which will turn the generators into > modules. These global variables will become local to main() then. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake

Re: [Qemu-devel] [PULL 17/51] readline: add a free function

On Thu, 1 Feb 2018 19:10:06 -0500 Paolo Bonzini wrote: > On 01/02/2018 19:00, Alex Williamson wrote: > > On Tue, 16 Jan 2018 15:16:59 +0100 > > Paolo Bonzini wrote: > > > >> From: Marc-André Lureau > >> > >> Fixes leaks

[Qemu-devel] [PULL v2 04/10] tests: virtio-9p: wait for completion in the test code

In order to test request cancellation, we will need to send multiple requests and wait for the associated replies. Since we poll the ISR to know if a request completed, we may have several replies to parse when we detect ISR was set to 1. This patch moves the waiting out of the reply parsing

[Qemu-devel] [PULL v2 08/10] libqos/virtio: return length written into used descriptor

When a 9p request is flushed (ie, cancelled) by the guest, the device is expected to simply mark the request as used, without sending a 9p reply (ie, without writing anything into the used buffer). To be able to test this, we need access to the length written by the device into the used

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

22.01.2018 22:56, John Snow wrote: On 01/22/2018 02:51 PM, Eric Blake wrote: On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote: I have to admit exposing this interface still makes me nervous, but :) Mechanically correct, and with suggesting phrasing changes: Reviewed-by: John Snow

[Qemu-devel] [Bug 1746943] [NEW] qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

Public bug reported: In a docker container created from an aarch64 image, injects qemu-aarch64-static (in /usr/bin) run ps/top cmd inside this container reports "qemu: uncaught target signal 11 (Segmentation fault)" Tried qemu-aarch64-static from fedora 27 / ubuntu artful / debian

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > Hi Peter, > > On 01/02/2018 13:20, Peter Xu wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and

  1   2   3   >