Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-20 Thread Gerd Hoffmann
Hi, > Sneak preview at https://www.kraxel.org/cgit/qemu/log/?h=work/intel-vgpu > Note: branch is a moving target ;) > > State: > spice: Partly working (no mouse ptr yet). Working now, in case anyone wants play. Must turn on opengl and use a unix socket, i.e. this: qemu -spice disable-tic

[Qemu-devel] Limiting coroutine stack usage

2018-02-20 Thread Peter Lieven
Hi, I remember we discussed a long time ago to limit the stack usage of all functions that are executed in a coroutine context to a very low value to be able to safely limit the coroutine stack size as well. I checked through all functions in block/, migration/ and nbd/ and there are only ver

Re: [Qemu-devel] [PULL 0/5] Usb 20180220 patches

2018-02-20 Thread Peter Maydell
git repository at: > > git://git.kraxel.org/qemu tags/usb-20180220-pull-request > > for you to fetch changes up to 18c7310e9982b71d17e76648acfec0be42a57aea: > > usb-mtp: Advertise SendObjectInfo for write support (2018-02-20 16:06:56 > +0100) > >

[Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Alberto Garcia
The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. That can be easily seen in qcow2_decompress_cluster(), that adds one to the value stored in that field: nb_c

Re: [Qemu-devel] [virtio-dev] [PATCH] docs: document virtio-balloon stats

2018-02-20 Thread Stefan Hajnoczi
On Mon, Feb 19, 2018 at 01:43:44PM +0100, Tomáš Golembiovský wrote: > Document statistics added in commits > > commit a0d06486b445985b8d128df172daefbae205bffd > Author: Denis V. Lunev > Date: Wed Feb 24 10:50:48 2016 +0300 > > virtio-balloon: add 'available' counter > > an

Re: [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations

2018-02-20 Thread Max Reitz
On 2018-02-07 23:55, Richard Henderson wrote: > The x86 vector instruction set is extremely irregular. With newer > editions, Intel has filled in some of the blanks. However, we don't > get many 64-bit operations until SSE4.2, introduced in 2009. > > The subsequent edition was for AVX1, introduc

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Halil Pasic
On 02/20/2018 05:08 PM, David Hildenbrand wrote: > On 20.02.2018 17:07, Cornelia Huck wrote: >> On Tue, 20 Feb 2018 17:04:19 +0100 >> Christian Borntraeger wrote: >> >>> On 02/20/2018 04:55 PM, David Hildenbrand wrote: On 20.02.2018 16:53, Cornelia Huck wrote: > On Tue, 20 Feb 2018 16

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 17:08:52 +0100 David Hildenbrand wrote: > On 20.02.2018 17:07, Cornelia Huck wrote: > > On Tue, 20 Feb 2018 17:04:19 +0100 > > Christian Borntraeger wrote: > > > >> On 02/20/2018 04:55 PM, David Hildenbrand wrote: > >>> On 20.02.2018 16:53, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Halil Pasic
On 02/20/2018 04:53 PM, Cornelia Huck wrote: > On Tue, 20 Feb 2018 16:07:13 +0100 > Halil Pasic wrote: > >> The 'bit' field of the 'S390FeatDef' structure is not applicable to all >> it's instances. Currently a this field is not applicable, and remains > > s/it's/its/ > > s/a this/this/ Will

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 17:04:19 +0100 Christian Borntraeger wrote: > On 02/20/2018 04:55 PM, David Hildenbrand wrote: > > On 20.02.2018 16:53, Cornelia Huck wrote: > >> On Tue, 20 Feb 2018 16:07:13 +0100 > >> Halil Pasic wrote: > >> > >>> The 'bit' field of the 'S390FeatDef' structure is not ap

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread David Hildenbrand
On 20.02.2018 17:07, Cornelia Huck wrote: > On Tue, 20 Feb 2018 17:04:19 +0100 > Christian Borntraeger wrote: > >> On 02/20/2018 04:55 PM, David Hildenbrand wrote: >>> On 20.02.2018 16:53, Cornelia Huck wrote: On Tue, 20 Feb 2018 16:07:13 +0100 Halil Pasic wrote: > The 'bi

Re: [Qemu-devel] [PATCH 17/30] hw/tricore: use the BYTE-based definitions

2018-02-20 Thread Bastian Koppelmann
On 02/15/2018 05:28 AM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/tricore/tricore_testboard.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Bastian Koppelmann Cheers, Bastian

Re: [Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE

2018-02-20 Thread Bastian Koppelmann
On 02/19/2018 07:18 AM, David Brenken wrote: > From: David Brenken > > Signed-off-by: David Brenken > Signed-off-by: Georg Hofstetter > Signed-off-by: Florian Artmeier > --- > target/tricore/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/tricore/cpu.h b

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Christian Borntraeger
On 02/20/2018 04:55 PM, David Hildenbrand wrote: > On 20.02.2018 16:53, Cornelia Huck wrote: >> On Tue, 20 Feb 2018 16:07:13 +0100 >> Halil Pasic wrote: >> >>> The 'bit' field of the 'S390FeatDef' structure is not applicable to all >>> it's instances. Currently a this field is not applicable, an

[Qemu-devel] make error

2018-02-20 Thread Ronald Delobel
Hello, This is the error I get when building qemu-2.11.[0-1] with gcc-7.3.0/glibc-2.27, removing the static attribute suffice to finnish the build using the glibc provided memfd_create and qemu don't crash, but I miss some knowledge here about what a static function really is, a kind of private on

Re: [Qemu-devel] [PATCH 3/5] tricore: fixed wrong masking of IE

2018-02-20 Thread Bastian Koppelmann
On 02/19/2018 07:18 AM, David Brenken wrote: > From: David Brenken > > Signed-off-by: David Brenken > Signed-off-by: Georg Hofstetter > Signed-off-by: Florian Artmeier > --- > target/tricore/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/tricore/cpu.h b

Re: [Qemu-devel] [PATCH 2/5] tricore: added CORE_ID

2018-02-20 Thread Bastian Koppelmann
On 02/19/2018 07:18 AM, David Brenken wrote: > From: David Brenken > > Signed-off-by: David Brenken > Signed-off-by: Georg Hofstetter > Signed-off-by: Florian Artmeier > --- > target/tricore/cpu.h| 1 + > target/tricore/csfr.def | 1 + > 2 files changed, 2 insertions(+) > Reviewed-by: B

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread David Hildenbrand
On 20.02.2018 16:53, Cornelia Huck wrote: > On Tue, 20 Feb 2018 16:07:13 +0100 > Halil Pasic wrote: > >> The 'bit' field of the 'S390FeatDef' structure is not applicable to all >> it's instances. Currently a this field is not applicable, and remains > > s/it's/its/ > > s/a this/this/ > >> unus

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 16:07:13 +0100 Halil Pasic wrote: > The 'bit' field of the 'S390FeatDef' structure is not applicable to all > it's instances. Currently a this field is not applicable, and remains s/it's/its/ s/a this/this/ > unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having th

Re: [Qemu-devel] [PATCH 1/5] tricore: added some missing cpu instructions

2018-02-20 Thread Bastian Koppelmann
On 02/19/2018 07:18 AM, David Brenken wrote: > From: David Brenken > > +case OPC1_16_SBR_JEQ2: > +gen_branch_cond(ctx, TCG_COND_EQ, cpu_gpr_d[r1], cpu_gpr_d[15], > +offset + 16); > +break; This is a 1.6+ instruction and you need to add a check, like wi

Re: [Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks

2018-02-20 Thread Bastian Koppelmann
Hi David, On 02/19/2018 07:18 AM, David Brenken wrote: > From: David Brenken > > Hello, > > this is my first commit of a patch set for QEMU. welcome aboard and thanks for your first patchset. So far it looks good to me and I will definitively accept it. However, I still have some comments reg

Re: [Qemu-devel] [PULL 0/2] 9p patches for 2.12 20180220

2018-02-20 Thread Peter Maydell
On 20 February 2018 at 10:49, Greg Kurz wrote: > The following changes since commit 299a2e6fac397be9b82c66583d53d1daaa3ffe6c: > > Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into > staging (2018-02-19 12:51:11 +) > > are available in the git repository at: > > htt

Re: [Qemu-devel] [PULL 00/12] Ui 20180220 patches

2018-02-20 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180220-pull-request > > for you to fetch changes up to 63ad932567df012ff4bf820a9ed0e2affd9dc5af: > > ui: Reorder vte terminal packing to avo

[Qemu-devel] [PULL 1/5] usb-mtp: Add one more argument when building results

2018-02-20 Thread Gerd Hoffmann
From: Bandan Das The response to a SendObjectInfo consists of the storageid, parent obejct handle and the handle reserved for the new incoming object Signed-off-by: Bandan Das Message-id: 20180215231129.14710-2-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 50

[Qemu-devel] [PULL 0/5] Usb 20180220 patches

2018-02-20 Thread Gerd Hoffmann
The following changes since commit b487e2b2ff6e9fff8a45a9600d6de3a7bf82666a: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2018-02-20 11:52:24 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180220-pull-request

[Qemu-devel] [PULL 3/5] usb-mtp: Support delete of mtp objects

2018-02-20 Thread Gerd Hoffmann
From: Bandan Das Write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Also, add a "readonly" property which needs to be set to false for deletion to work. Signed-off-by: Ba

[Qemu-devel] [PULL 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

2018-02-20 Thread Gerd Hoffmann
From: Bandan Das Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das Message-id: 20180215231129.14710-3-...@redhat.com Signed-of

[Qemu-devel] [PULL 5/5] usb-mtp: Advertise SendObjectInfo for write support

2018-02-20 Thread Gerd Hoffmann
From: Bandan Das This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple function to get the f

[Qemu-devel] [PULL 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-20 Thread Gerd Hoffmann
From: Bandan Das Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a previous SendObjectInfo op

Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-20 Thread Eric Blake
On 02/20/2018 08:51 AM, Max Reitz wrote: On 2018-02-06 20:43, Eric Blake wrote: On 02/05/2018 09:18 AM, Max Reitz wrote: This new field can be set by block drivers to list the runtime options they accept that may influence the contents of the respective BDS. As of a follow-up patch, this list w

Re: [Qemu-devel] [PATCH] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes

2018-02-20 Thread Peter Lieven
Am 15.02.2018 um 18:27 schrieb Stefan Hajnoczi: On Thu, Feb 15, 2018 at 03:24:54PM +0100, Peter Lieven wrote: Am 15.02.2018 um 12:15 schrieb Stefan Hajnoczi: The libiscsi iscsi_task_mgmt_async() API documentation says: abort_task will also cancel the scsi task. The callback for the scsi

[Qemu-devel] [PATCH] sdl2: fix hotkey keyup

2018-02-20 Thread Gerd Hoffmann
After some hotkey was pressed sdl2 doesn't forward the first modifier keyup event to the guest, resulting in stuck modifier keys. Fix the logic in handle_keyup(). Also gui_key_modifier_pressed doesn't need to be a global variable. Reported-by: Howard Spoelstra Tested-by: Howard Spoelstra Signe

Re: [Qemu-devel] [PATCH 0/5] Enable TOPOEXT to support hyperthreading on AMD CPU

2018-02-20 Thread Moger, Babu
Ping.. Looks like these patches got lost in the mix. Any comments on these patches? Thanks Babu > -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] > On Behalf Of Babu Moger > Sent: Friday, January 26, 2018 3:40 PM > To: pbonz...@redhat.com; r...@twidd

[Qemu-devel] [PATCH] migration: do not transfer ram during bulk storage migration

2018-02-20 Thread Peter Lieven
this patch makes the bulk phase of a block migration to take place before we start transferring ram. As the bulk block migration can take a long time its pointless to transfer ram during that phase. Signed-off-by: Peter Lieven --- migration/ram.c | 8 1 file changed, 8 insertions(+) di

Re: [Qemu-devel] [PATCH] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 08:15 AM, Alberto Garcia wrote: The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. That can be easily seen in qcow2_decompress_cluster(), that add

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 16:05, Paolo Bonzini wrote: > On 20/02/2018 16:01, Thomas Huth wrote: >> These options have been marked in a comment in qemu-options.hx as >> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we >> never informed the users about these deprecations. Let's catch up >> on t

[Qemu-devel] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Halil Pasic
The 'bit' field of the 'S390FeatDef' structure is not applicable to all it's instances. Currently a this field is not applicable, and remains unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 specified for multiple such feature definition was a little confusing, as it's a

[Qemu-devel] [PATCH v2 5/5] keymap: consider modifier state when picking a mapping

2018-02-20 Thread Gerd Hoffmann
Pass the modifier state to the keymap lookup function. In case multiple keysym -> keycode mappings exist look at the modifier state and prefer the mapping where the modifier state matches. Signed-off-by: Gerd Hoffmann --- ui/keymaps.h | 3 ++- ui/curses.c | 3 ++- ui/keymaps.c | 33 +

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 15:57, Cornelia Huck wrote: > On Tue, 20 Feb 2018 13:16:37 +0100 > David Hildenbrand wrote: > >> On 20.02.2018 13:05, Christian Borntraeger wrote: >>> >>> >>> On 02/19/2018 06:42 PM, David Hildenbrand wrote: From an architecture point of view, nothing can be mapped into the a

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 04:01:32PM +0100, Thomas Huth wrote: > These options have been marked in a comment in qemu-options.hx as > deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we > never informed the users about these deprecations. Let's catch up > on that omission now. > > Sign

[Qemu-devel] [PATCH v2 1/5] keymap: make struct kbd_layout_t private to ui/keymaps.c

2018-02-20 Thread Gerd Hoffmann
Also use kbd_layout_t pointers instead of void pointers. Signed-off-by: Gerd Hoffmann --- ui/keymaps.h | 29 ++--- ui/keymaps.c | 32 +--- 2 files changed, 31 insertions(+), 30 deletions(-) diff --git a/ui/keymaps.h b/ui/keymaps.h index 875746

[Qemu-devel] [PATCH v2 3/5] keymap: numpad keysyms and keycodes are fixed

2018-02-20 Thread Gerd Hoffmann
No need to figure them at runtime from the keymap. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c | 61 +--- 1 file changed, 9 insertions(+), 52 deletions(-) diff --git a/ui/keymaps.c b/ui/keymaps.c index bef1405576..d71ae389e0 100644 --- a

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 16:01, Thomas Huth wrote: > These options have been marked in a comment in qemu-options.hx as > deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we > never informed the users about these deprecations. Let's catch up > on that omission now. > > Signed-off-by: Thomas Hut

[Qemu-devel] [PATCH v2 2/5] keymap: use glib hash for kbd_layout_t

2018-02-20 Thread Gerd Hoffmann
Drop home-grown lookup code, which is a strange mix of a lookup table and a list. Use standard glib hash instead. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c| 79 +++-- ui/trace-events | 2 +- 2 files changed, 38 insertions(+), 43 delet

[Qemu-devel] [PATCH v2 4/5] keymap: record multiple keysym -> keycode mappings

2018-02-20 Thread Gerd Hoffmann
Sometimes the same keysym can be created using different key combinations. Record them all in the reverse keymap, not only the first one. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/ui/keymaps.c b/ui/keymaps.c

[Qemu-devel] [PATCH v2 0/5] keymap: support kbd layouts with multiple mappings for the same key.

2018-02-20 Thread Gerd Hoffmann
The reverse keymap (-k $map) code has problems dealing with keymaps where multiple key combinations can create the same keysym, because it can store a single keycode per keysym only. This series fixes it and does some cleanups along the way. v2: rebase, codestyle fixes. Gerd Hoffmann (5): keym

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 13:16:37 +0100 David Hildenbrand wrote: > On 20.02.2018 13:05, Christian Borntraeger wrote: > > > > > > On 02/19/2018 06:42 PM, David Hildenbrand wrote: > >> From an architecture point of view, nothing can be mapped into the address > >> space on s390x. All there is is mem

[Qemu-devel] KVM call for agenda for 2018-02-27

2018-02-20 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. There hasn't been a call in a while, it is a good time to send your topics. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going

Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-20 Thread Max Reitz
On 2018-02-06 20:43, Eric Blake wrote: > On 02/05/2018 09:18 AM, Max Reitz wrote: >> This new field can be set by block drivers to list the runtime options >> they accept that may influence the contents of the respective BDS. As of >> a follow-up patch, this list will be used by the common >> bdrv_

Re: [Qemu-devel] qemu warnings and errors

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 08:45:00AM -0600, Eric Blake wrote: > On 02/20/2018 02:38 AM, Gerd Hoffmann wrote: > >Hi, > > > > > What version of QEMU? > > > > > > > unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org > > > > > > This part is the only part that urges you to report

Re: [Qemu-devel] qemu warnings and errors

2018-02-20 Thread Eric Blake
On 02/20/2018 02:38 AM, Gerd Hoffmann wrote: Hi, What version of QEMU? unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org This part is the only part that urges you to report the error, but I don't know much about what's going on here. Maybe Gerd knows? We had lots of

Re: [Qemu-devel] [RFC PATCH v0 1/2] pc-dimm: Make pc_dimm_built_list() global

2018-02-20 Thread Igor Mammedov
On Mon, 19 Feb 2018 12:12:53 +0530 Bharata B Rao wrote: > Making pc_dimm_built_list() global allows other parts of QEMU code > to build and walk through the DIMM list in address-sorted order. > > This is needed in the next patch for sPAPR code to create > ibm,dynamic-memory-v2 device tree proper

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
> I also gave it a test on an OpenBMC romulus image. Looks fine, but that's > an old custom U-Boot. Which defconfig did you use for U-Boot HEAD ? evb-ast2500_defconfig. FYI, these changes are necessary, but not sufficient to get u-boot HEAD (or for that matter u-boot 2017.11, another version tes

[Qemu-devel] [PATCH] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Alberto Garcia
The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. That can be easily seen in qcow2_decompress_cluster(), that adds one to the value stored in that field: nb_c

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

2018-02-20 Thread Igor Mammedov
On Sat, 17 Feb 2018 14:31:35 +0800 Haozhong Zhang wrote: > ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity > domain of a NVDIMM SPA range must match with corresponding entry in > SRAT table. > > The address ranges of vNVDIMM in QEMU are allocated from the > hot-pluggable addre

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Cédric Le Goater
On 02/20/2018 02:26 PM, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct magic v

[Qemu-devel] [PULL 12/12] ui: Reorder vte terminal packing to avoid gtk3 warnings

2018-02-20 Thread Gerd Hoffmann
From: Jan Kiszka Fill the terminal box from right to left to avoid Gtk-WARNING **: Allocating size to GtkScrollbar 0x55f6d54b0200 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? Signed-off-by: Jan Kiszka Message-id: 902aaef8-d20e-05

[Qemu-devel] [PULL 03/12] gtk: add and use DisplayOptions + DisplayGTK

2018-02-20 Thread Gerd Hoffmann
Add QAPI DisplayType enum, DisplayOptions union and DisplayGTK struct. Switch gtk configuration to use the qapi type. Some bookkeeping (fullscreen for example) is done twice now, this is temporary until more/all UIs are switched over to qapi configuration. Signed-off-by: Gerd Hoffmann Reviewed-b

[Qemu-devel] [PULL 02/12] vl: rename DisplayType to LegacyDisplayType

2018-02-20 Thread Gerd Hoffmann
qapi DisplayType will replace the current enum. For the transition both will coexist though, so rename it so we don't have a name clash. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-4-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 10 +--

[Qemu-devel] [PULL 04/12] sdl: use DisplayOptions

2018-02-20 Thread Gerd Hoffmann
Switch sdl ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-6-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 8 ui/sdl.c | 19 +-- ui/sdl2.c

[Qemu-devel] [PULL 06/12] egl-headless: use DisplayOptions

2018-02-20 Thread Gerd Hoffmann
Switch egl-headless ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-8-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- ui/egl-headless.c| 2 +- vl.c | 3 ++-

[Qemu-devel] [PULL 01/12] vl: deprecate -no-frame

2018-02-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180202111022.19269-2-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 4 qemu-doc.texi | 7 +++ 2 files changed, 11 insertions(+) diff --git a/vl.c b/vl.c index 81724f5f17..c1f763f3e1 100644 --- a/vl.c +++ b/vl.c @@ -2105,6 +

[Qemu-devel] [PULL 00/12] Ui 20180220 patches

2018-02-20 Thread Gerd Hoffmann
The following changes since commit afd3397a8149d8b645004e459bf2002d78f5e267: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2018-02-19 16:44:12 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180220-pu

[Qemu-devel] [PULL 07/12] curses: use DisplayOptions

2018-02-20 Thread Gerd Hoffmann
Switch curses ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-9-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- ui/curses.c | 2 +- vl.c | 4 +++- q

[Qemu-devel] [PULL 10/12] vl: drop request_opengl variable

2018-02-20 Thread Gerd Hoffmann
Switch over the one leftover user to qapi DisplayType. The delete the unused request_opengl variable. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-12-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 8 +--- 1 file changed, 1 insertion(+), 7

[Qemu-devel] [PULL 08/12] cocoa: use DisplayOptions

2018-02-20 Thread Gerd Hoffmann
Switch cocoa ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-10-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- vl.c | 3 ++- qapi/ui.json | 6 --

[Qemu-devel] [PULL 11/12] vl: drop display_type variable

2018-02-20 Thread Gerd Hoffmann
Switch over all leftover users to qapi DisplayType. Then delete the unused display_type variable. Add 'default' DisplayType, which isn't an actual display type but a placeholder for "user didn't specify a display". It will be replaced by the DisplayType actually used, which in turn depends on the

[Qemu-devel] [PULL 09/12] vl: drop full_screen variable

2018-02-20 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-11-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index 2dd00e00d9..6271ad0634 100644 --- a/vl.c +++ b/v

[Qemu-devel] [PULL 05/12] vl: drop no_quit variable

2018-02-20 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann Message-id: 20180202111022.19269-7-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 61b72758a8..f52bc3b879 100644 --- a/vl.c +++ b/vl.c

[Qemu-devel] [Bug 1187529] Re: Devices on PCI bridge stop working when live-migrated

2018-02-20 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Assignee: Don Koch (dkoch-r) => (unassigned) ** Changed in: qemu Status: New => Incomplete -- You received this bug notificati

[Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
Some register blocks of the ast2500 are protected by protection key registers which require the right magic value to be written to those registers to allow those registers to be mutated. Register manuals indicate that writing the correct magic value to these registers should cause subsequent reads

Re: [Qemu-devel] [PATCH 2/2] tests/migration: Add test for migration to bad destination

2018-02-20 Thread Juan Quintela
Thomas Huth wrote: > On 12.02.2018 17:03, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Check the source survives. >> >> Signed-off-by: Dr. David Alan Gilbert >> --- >> tests/migration-test.c | 65 >> ++ >> 1 file

Re: [Qemu-devel] [PATCH 1/2] hw/sysbus.h: New sysbus_init_child() helper function

2018-02-20 Thread Igor Mammedov
On Tue, 20 Feb 2018 13:13:49 +0100 Paolo Bonzini wrote: > On 16/02/2018 18:40, Philippe Mathieu-Daudé wrote: > > we can keep object_initialize() when no parent, > > and add object_initialize_child(, const char *childname, Object *parent) > > 'parent' last because all previous args are child-relat

Re: [Qemu-devel] [PATCH v1 0/3] cpus: single-threaded TCG CPU creation improvements

2018-02-20 Thread Paolo Bonzini
On 09/02/2018 20:52, David Hildenbrand wrote: > While looking into CPU hotplug for s390x TCG, I noticed that > single-threaded TCG does not properly inititalize CPUs > 1. Fix this > and cleanup the code a bit. > > David Hildenbrand (3): > cpus: properly inititalize CPU > 1 under single-threaded

[Qemu-devel] [PATCH] vl: introduce vm_shutdown()

2018-02-20 Thread Stefan Hajnoczi
Commit 00d09fdbbae5f7864ce754913efc84c12fdf9f1a ("vl: pause vcpus before stopping iothreads") and commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") tried to work around the fact that emulation was still active during termination by stopping iothreads. T

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-20 Thread Corey Minyard
On 02/19/2018 09:25 AM, Peter Maydell wrote: On 19 February 2018 at 15:20, wrote: From: Corey Minyard Some devices need access to it. Signed-off-by: Corey Minyard --- hw/i2c/core.c| 17 - include/hw/i2c/i2c.h | 17 + 2 files changed, 17 insertion

Re: [Qemu-devel] [PULL 09/23] gdbstub: Fix vCont behaviour

2018-02-20 Thread Jan Kiszka
On 2018-02-19 19:15, Claudio Imbrenda wrote: > On Sat, 17 Feb 2018 10:07:38 +0100 > Jan Kiszka wrote: > > [...] > >>> Seems like no one is doing guest debugging with kvm on x86 except >>> me, and I'm only doing it too infrequently now: This one broke that >>> use case for SMP guests long ago. Ho

Re: [Qemu-devel] [Bug 1750229] Re: virtio-blk-pci regression: softlock in guest kernel at module loading

2018-02-20 Thread Matwey V. Kornilov
virtqueue_pop() returns NULL due to virtio_queue_empty_rcu() returns true all the time. 2018-02-20 14:47 GMT+03:00 Matwey V. Kornilov : > Well, I've found that on qemu side VirtQueue for virtio_blk device > infinitely calls virtio_blk_handle_vq() where virtio_blk_get_request() > (virtqueue_pop() i

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-20 Thread Alex Bennée
Laurent Vivier writes: > Le 13/02/2018 à 16:51, Peter Maydell a écrit: >> On 6 February 2018 at 16:47, Alex Bennée wrote: >>> Hi, >>> >>> The main change is applying the __attribute__((flatten)) to some of >>> the public functions that show up in Emilio's dbt-benchmark. This >>> seems to be a c

Re: [Qemu-devel] [PATCHv5 0/5] add query-cpu-fast and related s390 changes

2018-02-20 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:36 +0100 Viktor Mihajlovski wrote: > v5 synopsis: Split out HMP changes from Patch 2 into Patch 5. Please >re-review, as I've removed the a-b/r-b from Patch 2 >as well. > > This series consolidates patches around a performance issue > caused by t

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 13:05, Christian Borntraeger wrote: > > > On 02/19/2018 06:42 PM, David Hildenbrand wrote: >> From an architecture point of view, nothing can be mapped into the address >> space on s390x. All there is is memory. Therefore there is also not really >> an interface to communicate such

Re: [Qemu-devel] [PATCH] RAMList: replace QemuMutex with CompatGMutex

2018-02-20 Thread Paolo Bonzini
On 16/02/2018 10:13, Peter Maydell wrote: > On 14 February 2018 at 12:11, Paolo Bonzini wrote: >> On 14/02/2018 12:43, Zihan Yang wrote: >>> I'm not sure what is the advantage of this change. QEMU is more or less uniformly using QemuMutex and QemuCond. >>> >>> I see. QEMU uses some glib

Re: [Qemu-devel] [PATCH 1/2] hw/sysbus.h: New sysbus_init_child() helper function

2018-02-20 Thread Paolo Bonzini
On 16/02/2018 18:40, Philippe Mathieu-Daudé wrote: > we can keep object_initialize() when no parent, > and add object_initialize_child(, const char *childname, Object *parent) > 'parent' last because all previous args are child-related. > >> >>> +qdev_set_parent_bus(DEVICE(child), sysbus_get_d

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread Alexander Graf
On 02/20/2018 12:31 PM, Thomas Huth wrote: On 20.02.2018 12:16, BALATON Zoltan wrote: On Tue, 20 Feb 2018, Alexander Graf wrote: On 02/20/2018 11:09 AM, BALATON Zoltan wrote: On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Ad

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/19/2018 06:42 PM, David Hildenbrand wrote: > From an architecture point of view, nothing can be mapped into the address > space on s390x. All there is is memory. Therefore there is also not really > an interface to communicate such information to the guest. All we can do is > specify the ma

Re: [Qemu-devel] [Bug 1750229] Re: virtio-blk-pci regression: softlock in guest kernel at module loading

2018-02-20 Thread Matwey V. Kornilov
Well, I've found that on qemu side VirtQueue for virtio_blk device infinitely calls virtio_blk_handle_vq() where virtio_blk_get_request() (virtqueue_pop() in essens) always returns NULL. 2018-02-18 15:26 GMT+03:00 Matwey V. Kornilov : > ** Attachment added: ".build.kernel.kvm" > > https://bugs

Re: [Qemu-devel] [PATCH 2/2] tests/migration: Add test for migration to bad destination

2018-02-20 Thread Thomas Huth
On 12.02.2018 17:03, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check the source survives. > > Signed-off-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 65 > ++ > 1 file changed, 50 insertions(+), 15 d

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 12:18, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different interface

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread Thomas Huth
On 20.02.2018 12:16, BALATON Zoltan wrote: > On Tue, 20 Feb 2018, Alexander Graf wrote: >> On 02/20/2018 11:09 AM, BALATON Zoltan wrote: >>> On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/20/2018 12:18 PM, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different inte

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
Given that we have trouble modeling this properly I somewhat like the idea. We should have never folded this into the common code memory hotplug infrastructure as it is different. Instead we really should have provided a different interface and we should have build it with migration support. If

Re: [Qemu-devel] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Alexander Graf wrote: On 02/20/2018 11:09 AM, BALATON Zoltan wrote: On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a co

Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches

2018-02-20 Thread Tomáš Golembiovský
On Mon, 19 Feb 2018 21:11:27 -0800 Jonathan Helman wrote: > > On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský wrote: > > > > On Wed, 14 Feb 2018 00:07:53 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote: > >>> > >>> > >>> On

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 11:36, Stefan Hajnoczi wrote: > === Multi-CPU cluster support for GDB server in QEMU === > > There are many examples in modern computing where multiple CPU > clusters are grouped together in a single SoC. This is common in the > ARM world especially. There are numerous examples such

Re: [Qemu-devel] [PATCH] scsi: Remove automatic creation of SCSI controllers with -drive if=scsi

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 11:42, Thomas Huth wrote: > Automatic creation of SCSI controllers for "-drive if=scsi" for x86 > machines was quite a bad idea (see description of commit f778a82f0c179 > for details). This is marked as deprecated since QEMU v2.9.0, and as > far as I know, nobody complained that this

[Qemu-devel] [PATCH 2/3] egl-headless: cursor_dmabuf: handle NULL cursor

2018-02-20 Thread Gerd Hoffmann
The cursor dmabuf can be NULL, in case no cursor defined by the guest. Happens for example when linux guests show the framebuffer console. Signed-off-by: Gerd Hoffmann --- ui/egl-headless.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/ui/egl-headless.c b/ui

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-20 Thread Howard Spoelstra
On Tue, Feb 20, 2018 at 10:52 AM, Gerd Hoffmann wrote: >> Hi, >> >> I went on to compile dgibson's rep which includes that commit. But the >> issue remains. >> I normally use -usb-mouse -usb-kbd in the command line, as these work >> for Mac OS 9.x up to 10.5. Using -usb-tablet allows the mouse to

[Qemu-devel] [PATCH 0/3] opengl: some dmabuf support updates

2018-02-20 Thread Gerd Hoffmann
This series updates the UI interface for dmabug cursors. Splits the callback into two, so we have a separate call for cursor moves. Also adds hotspot information. Series also includes two small fixes in egl code. Gerd Hoffmann (3): console/opengl: split up dpy_gl_cursor ops egl-headless: cu

[Qemu-devel] [PATCH 3/3] egl-helpers: add alpha channel to texture format

2018-02-20 Thread Gerd Hoffmann
Needed when rendering cursers which (unlike framebuffers) actually are transparent. Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 5fa60ef4e8..16dc3ded36 100644 --- a/ui/egl-helpers.c

[Qemu-devel] [PATCH 1/3] console/opengl: split up dpy_gl_cursor ops

2018-02-20 Thread Gerd Hoffmann
Split the cursor callback into two, one for setting the dmabuf, one for setting the position. Also add hotspot information. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 13 - ui/console.c | 18 ++ ui/egl-headless.c| 17 - 3 file

<    1   2   3   >