[Qemu-devel] [PULL 1/4] nbd: Honor server's advertised minimum block size

2018-03-01 Thread Eric Blake
Commit 79ba8c98 (v2.7) changed the setting of request_alignment to occur only during bdrv_refresh_limits(), rather than at at bdrv_open() time; but at the time, NBD was unaffected, because it still used sector-based callbacks, so the block layer defaulted NBD to use 512 request_alignment. Later,

[Qemu-devel] [PULL 2/4] nbd: change indenting in nbd.h

2018-03-01 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Prepared indenting for the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <1518702707-7077-3-git-send-email-vsement...@virtuozzo.com> Signed-off-by: Eric Blake

[Qemu-devel] [PULL 0/4] nbd patches for 2018-03-01

2018-03-01 Thread Eric Blake
The following changes since commit 0dc8ae5e8e693737dfe65ba02d0c6eccb58a9c67: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180301-v2' into staging (2018-03-01 17:08:16 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-03-01

[Qemu-devel] [PULL 3/4] nbd: BLOCK_STATUS constants

2018-03-01 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Expose the new constants and structs that will be used by both server and client implementations of NBD_CMD_BLOCK_STATUS (the command is currently experimental at

Re: [Qemu-devel] [PULL 00/30] QAPI patches for 2018-03-01

2018-03-01 Thread Eric Blake
On 03/01/2018 02:54 PM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180301194245.29854-1-ebl...@redhat.com Subject: [Qemu-devel] [PULL 00/30] QAPI patches for 2018-03-01 CC

Re: [Qemu-devel] [PATCH v4 0/2] tpm: Extend TPM with state migration support

2018-03-01 Thread Stefan Berger
On 03/01/2018 02:59 PM, Stefan Berger wrote: This series of patches implements support for migrating the state of the external 'swtpm' TPM emulator as well as that of the TIS interface. For testing of TPM 2 (migration) please use the following git repos and branches: libtpms: - repo:

Re: [Qemu-devel] [PATCH qemu v2] qmp: Add qom-list-properties to list QOM object properties

2018-03-01 Thread Eric Blake
On 03/01/2018 05:47 AM, Alexey Kardashevskiy wrote: +## +{ 'struct': 'QOMPropertyInfo', + 'data': { 'name': 'str', 'type': 'str', '*description': 'str' } } So, this has identical contents to DevicePropertyInfo, and is very similar to ObjectPropertyInfo. Is there any way we could consolidate

Re: [Qemu-devel] [PATCH v10 23/28] qmp: add query-sev-launch-measure command

2018-03-01 Thread Eric Blake
On 02/28/2018 03:10 PM, Brijesh Singh wrote: The command can be used by libvirt to retrieve the measurement of SEV guest. This measurement is a signature of the memory contents that was encrypted through the LAUNCH_UPDATE_DATA. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan

Re: [Qemu-devel] [PATCH v10 09/28] qmp: add query-sev command

2018-03-01 Thread Eric Blake
On 02/28/2018 03:10 PM, Brijesh Singh wrote: The QMP query command can used to retrieve the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc:

Re: [Qemu-devel] [PATCH] iotests: Skip test for ENOMEM error

2018-03-01 Thread Eric Blake
On 02/28/2018 07:14 PM, Fam Zheng wrote: The AFL image is to exercise the code validating image size, which doesn't work on 32 bit or when out of memory (there is a large allocation before the interesting point). So check that and skip the test, instead of faking the result. Signed-off-by: Fam

Re: [Qemu-devel] [PATCH v10 26/28] qmp: add query-sev-capabilities command

2018-03-01 Thread Eric Blake
On 02/28/2018 03:10 PM, Brijesh Singh wrote: The command can be used by libvirt to query the SEV capabilities. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh

[Qemu-devel] [PULL 28/30] qapi: Move qapi-schema.json to qapi/, rename generated files

2018-03-01 Thread Eric Blake
From: Markus Armbruster Move qapi-schema.json to qapi/, so it's next to its modules, and all files get generated to qapi/, not just the ones generated for modules. Consistently name the generated files qapi-MODULE.EXT: qmp-commands.[ch] become qapi-commands.[ch],

[Qemu-devel] [PATCH v4 2/2] tpm: extend TPM TIS with state migration support

2018-03-01 Thread Stefan Berger
Extend the TPM TIS interface with state migration support. We need to synchronize with the backend thread to make sure that a command being processed by the external TPM emulator has completed and its response been received. Signed-off-by: Stefan Berger ---

[Qemu-devel] [PATCH v4 0/2] tpm: Extend TPM with state migration support

2018-03-01 Thread Stefan Berger
This series of patches implements support for migrating the state of the external 'swtpm' TPM emulator as well as that of the TIS interface. For testing of TPM 2 (migration) please use the following git repos and branches: libtpms: - repo: https://github.com/stefanberger/libtpms -

[Qemu-devel] [PULL 23/30] Include less of the generated modular QAPI headers

2018-03-01 Thread Eric Blake
From: Markus Armbruster In my "build everything" tree, a change to the types in qapi-schema.json triggers a recompile of about 4800 out of 5100 objects. The previous commit split up qmp-commands.h, qmp-event.h, qmp-visit.h, qapi-types.h. Each of these headers still includes

[Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-01 Thread Stefan Berger
Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a protocol over its control channel to retrieve its state blobs. We implement functions for getting and setting the different state blobs. In case the setting of the state blobs fails,

Re: [Qemu-devel] [PATCH v2 3/5] target/i386: Add support for CPUID_8000_001E for AMD

2018-03-01 Thread Radim Krčmář
2018-02-28 22:18+, Moger, Babu: > > -Original Message- > > From: Radim Krčmář [mailto:rkrc...@redhat.com] > > Sent: Wednesday, February 28, 2018 12:24 PM > > To: Moger, Babu > > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; > >

[Qemu-devel] [PULL 30/30] qapi: Don't create useless directory qapi-generated

2018-03-01 Thread Eric Blake
From: Markus Armbruster We used to generate first test and later QGA QAPI code into qapi-generated/. Commit b93b63f574 moved the test code to tests/. Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The directory has been unused since. Signed-off-by: Markus

[Qemu-devel] [PULL 27/30] docs: Correct outdated information on QAPI

2018-03-01 Thread Eric Blake
From: Markus Armbruster * Fix guidance on error classes * Point to generated documentation * Drop plea for documentation, because the QAPI code generator enforces it since commit 3313b6124b * Minor tweaks here and there Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 2/5] target/i386: Populate AMD Processor Cache Information

2018-03-01 Thread Radim Krčmář
2018-03-01 15:55+, Moger, Babu: > Radim, Thanks for your comments. I am working on the changes. > But, I need few clarifications on your comments. Please see inline. > > > -Original Message- > > From: Radim Krčmář [mailto:rkrc...@redhat.com] > > Sent: Wednesday, February 28, 2018

[Qemu-devel] [PULL 21/30] qapi/common: Fix guardname() for funny filenames

2018-03-01 Thread Eric Blake
From: Markus Armbruster guardname() fails to return a valid C identifier for arguments containing anything but [A-Za-z0-9_.-']. Fix that. Don't bother protecting ticklish identifiers; header guards are all-caps, and no ticklish identifiers are. Signed-off-by: Markus

[Qemu-devel] [PULL 24/30] watchdog: Consolidate QAPI into single file

2018-03-01 Thread Eric Blake
Commit f0df84c6 added watchdog-set-action in the main qapi-schema.json, but it belongs better in qapi/run-state.json alongside the definition of WatchdogAction. The command was written prior to commit 0e201d34 creating the latter file, even though it was merged after. Signed-off-by: Eric Blake

[Qemu-devel] [PULL 17/30] qapi: Record 'include' directives in intermediate representation

2018-03-01 Thread Eric Blake
From: Markus Armbruster The include directive permits modular QAPI schemata, but the generated code is monolithic all the same. To permit generating modular code, the front end needs to pass more information on inclusions to the back ends. The commit before last added the

[Qemu-devel] [PULL 16/30] qapi: Generate in source order

2018-03-01 Thread Eric Blake
From: Markus Armbruster The generators' conversion to visitors (merge commit 9e72681d16) changed the processing order of entities from source order to alphabetical order. The next commit needs source order, so change it back. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 09/30] qapi-gen: Convert from getopt to argparse

2018-03-01 Thread Eric Blake
From: Markus Armbruster argparse is nicer to use than getopt, and gives us --help almost for free. Signed-off-by: Markus Armbruster Message-Id: <20180211093607.27351-10-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Marc-André

[Qemu-devel] [PULL 26/30] docs/devel/writing-qmp-commands: Update for modular QAPI

2018-03-01 Thread Eric Blake
From: Markus Armbruster With modular code generation, putting stuff right into qapi-schema.json is a bad idea. Update writing-qmp-commands.txt accordingly. Signed-off-by: Markus Armbruster Message-Id: <20180211093607.27351-26-arm...@redhat.com>

[Qemu-devel] [PULL 29/30] Fix up dangling references to qmp-commands.* in comment and doc

2018-03-01 Thread Eric Blake
From: Markus Armbruster Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit 5032a16d1d. Fix up the reference to qmp-commands.txt in docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [PULL 06/30] qapi: Reduce use of global variables in generators some

2018-03-01 Thread Eric Blake
From: Markus Armbruster In preparation of the next commit, which will turn the generators into modules. These global variables will become local to main() then. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by:

[Qemu-devel] [PULL 22/30] qapi: Generate separate .h, .c for each module

2018-03-01 Thread Eric Blake
From: Markus Armbruster Our qapi-schema.json is composed of modules connected by include directives, but the generated code is monolithic all the same: one qapi-types.h with all the types, one qapi-visit.h with all the visitors, and so forth. These monolithic headers get

[Qemu-devel] [PULL 08/30] qapi-gen: New common driver for code and doc generators

2018-03-01 Thread Eric Blake
From: Markus Armbruster Whenever qapi-schema.json changes, we run six programs eleven times to update eleven files. Similar for qga/qapi-schema.json. This is silly. Replace the six programs by a single program that spits out all eleven files. The programs become modules in

[Qemu-devel] [PULL 20/30] qapi/types qapi/visit: Generate built-in stuff into separate files

2018-03-01 Thread Eric Blake
From: Markus Armbruster Linking code from multiple separate QAPI schemata into the same program is possible, but involves some weirdness around built-in types: * We generate code for built-in types into .c only with option --builtins. The user is responsible for generating

[Qemu-devel] [PULL 19/30] qapi: Make code-generating visitors use QAPIGen more

2018-03-01 Thread Eric Blake
From: Markus Armbruster The use of QAPIGen is rather shallow so far: most of the output accumulation is not converted. Take the next step: convert output accumulation in the code-generating visitor classes. Helper functions outside these classes are not converted.

[Qemu-devel] [PULL 05/30] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc

2018-03-01 Thread Eric Blake
From: Markus Armbruster These classes encapsulate accumulating and writing output. Convert C code generation to QAPIGenC and QAPIGenH. The conversion is rather shallow: most of the output accumulation is not converted. Left for later. The indentation machinery uses a single

[Qemu-devel] [PULL 13/30] qapi: Lift error reporting from QAPISchema.__init__() to callers

2018-03-01 Thread Eric Blake
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <20180211093607.27351-14-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Michael Roth

[Qemu-devel] [PULL 11/30] qapi: Improve include file name reporting in error messages

2018-03-01 Thread Eric Blake
From: Markus Armbruster Error messages print absolute file names of included files even if the user gave a relative one on the command line: $ PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py tests/qapi-schema/include-cycle.json In file included from

[Qemu-devel] [PULL 18/30] qapi: Rename generated qmp-marshal.c to qmp-commands.c

2018-03-01 Thread Eric Blake
From: Markus Armbruster All generated .c are named like their .h, except for qmp-marshal.c and qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely matches generated test-qmp-commands.h. Get rid of this unnecessary complication. Signed-off-by: Markus

[Qemu-devel] [PULL 15/30] qapi: Record 'include' directives in parse tree

2018-03-01 Thread Eric Blake
From: Markus Armbruster The parse tree is a list of expressions. Except include expressions currently get replaced by the included file's parse tree. Instead of throwing away the include expression, keep it with the file name expanded so you don't have to track the including

[Qemu-devel] [PULL 03/30] qapi: Generate up-to-date copyright notice

2018-03-01 Thread Eric Blake
From: Markus Armbruster Each generator carries a copyright notice for the generator itself, and another one for the files it generates. Only the former have been updated along the way, the latter have not, and are all out of date. Fix by copying the generator's copyright

[Qemu-devel] [PULL 10/30] qapi: Touch generated files only when they change

2018-03-01 Thread Eric Blake
From: Markus Armbruster A massive number of objects depends on QAPI-generated headers. In my "build everything" tree, it's roughly 4800 out of 5100. This is particularly annoying when only some of the generated files change, say for a doc fix. Improve qapi-gen.py to touch

[Qemu-devel] [PULL 02/30] qapi: Streamline boilerplate comment generation

2018-03-01 Thread Eric Blake
From: Markus Armbruster Every generator has separate boilerplate for .h and .c, and their differences are boring. All of them repeat the license note. Reduce the repetition as follows. Move common text like the license note to common open_output(), next to the existing

[Qemu-devel] [PULL 14/30] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__()

2018-03-01 Thread Eric Blake
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <20180211093607.27351-15-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Michael Roth

[Qemu-devel] [PULL 12/30] qapi/common: Eliminate QAPISchema.exprs

2018-03-01 Thread Eric Blake
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Message-Id: <20180211093607.27351-13-arm...@redhat.com> Reviewed-by: Michael Roth

[Qemu-devel] [PULL 00/30] QAPI patches for 2018-03-01

2018-03-01 Thread Eric Blake
The following changes since commit 0dc8ae5e8e693737dfe65ba02d0c6eccb58a9c67: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180301-v2' into staging (2018-03-01 17:08:16 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-qapi-2018-03-01

[Qemu-devel] [PULL 04/30] qapi: Rename variable holding the QAPISchemaGenFOOVisitor

2018-03-01 Thread Eric Blake
From: Markus Armbruster Rename the variable holding the QAPISchemaGenFOOVisitor from gen to vis, to avoid confusion in the next commit. Signed-off-by: Markus Armbruster Message-Id: <20180211093607.27351-5-arm...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL 07/30] qapi: Turn generators into modules

2018-03-01 Thread Eric Blake
From: Markus Armbruster The next commit will introduce a common driver program for all generators. The generators need to be modules for that. qapi2texi.py already is. Make the other generators follow suit. The changes are actually trivial. Obvious in the diffs once you

[Qemu-devel] [PULL 01/30] Include qapi/qmp/qerror.h exactly where needed

2018-03-01 Thread Eric Blake
From: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20180211093607.27351-2-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Signed-off-by: Eric Blake

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-03-01 Thread John Snow
On 03/01/2018 05:01 AM, Kevin Wolf wrote: > Am 28.02.2018 um 20:14 hat John Snow geschrieben: >> >> >> On 02/28/2018 01:15 PM, Kevin Wolf wrote: >>> Is it because you want to avoid that the user picks an automatic job for >>> completing the mixed transaction? >> >> I wanted to avoid the case

Re: [Qemu-devel] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts()

2018-03-01 Thread Eric Blake
On 03/01/2018 10:36 AM, Paolo Bonzini wrote: From: Stefan Hajnoczi BlockDriver->bdrv_create() has been called from coroutine context since commit 5b7e1542cfa41a281af9629d31cef03704d976e6 ("block: make bdrv_create adopt coroutine"). Make this explicit by renaming to

Re: [Qemu-devel] [PATCH 1/7] qcow2: Generalize validate_table_offset() into qcow2_validate_table()

2018-03-01 Thread Eric Blake
On 03/01/2018 10:27 AM, Alberto Garcia wrote: This function checks that the offset and size of a table are valid. While the offset checks are fine, the size check is too generic, since it only verifies that the total size in bytes fits in a 64-bit integer. In practice all tables used in qcow2

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-01 Thread Peter Ogden
This appears to be a problem in all PIE-compiled executables that use sbrk in qemu-user due to the way that position-independent code gets mmapped into adjacent ranges meaning there is no room for expansion. I've hacked my version of QEMU to force the program binary to mmap in a different range

Re: [Qemu-devel] [PULL v2 00/27] s390x updates (and friends)

2018-03-01 Thread Peter Maydell
gt; > git://github.com/cohuck/qemu tags/s390x-20180301-v2 > > for you to fetch changes up to be8b49de2491145a7aad3201803327b6f568cbd3: > > s390x/tcg: fix loading 31bit PSWs with the highest bit set (2018-03-01 > 13:23:09 +0100) > >

Re: [Qemu-devel] [PATCH v2 2/2] nbd/client: fix error messages in nbd_handle_reply_err

2018-03-01 Thread Eric Blake
On 03/01/2018 06:10 AM, Vladimir Sementsov-Ogievskiy wrote: 26.02.2018 19:57, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy 1. NBD_REP_ERR_INVALID is not only about length, so, make message more     general 2. hex format is not very good: it's hard to read

Re: [Qemu-devel] [PATCH 9/9] iotests: new test 206 for NBD BLOCK_STATUS

2018-03-01 Thread Eric Blake
On 03/01/2018 05:51 AM, Vladimir Sementsov-Ogievskiy wrote: 17.02.2018 00:02, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   tests/qemu-iotests/206 | 34

Re: [Qemu-devel] [PATCH v2 1/5] timer: Initial commit of xlnx-pmu-iomod-pit device

2018-03-01 Thread Philippe Mathieu-Daudé
On 02/28/2018 07:31 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > V2: > - Use UINT32_MAX and uint64_t in xlnx_iomod_pit_ctr_pr() > - Name frequency varaible frequency_hz > - Shorten R_MAX #define > > include/hw/timer/xlnx-pmu-iomod-pit.h |

Re: [Qemu-devel] [PATCH v2 2/5] xlnx-zynqmp-pmu: Connect the PMU IOMOD PIT devices

2018-03-01 Thread Philippe Mathieu-Daudé
On 02/28/2018 07:32 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé > --- > > hw/microblaze/xlnx-zynqmp-pmu.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff

Re: [Qemu-devel] QEMU GSoC 2018 Project Idea (Apply polling to QEMU NVMe)

2018-03-01 Thread Huaicheng Li
Hi Stefan, Paolo and I have filled the template. And Paolo has helped update the wiki with this proposed project idea. Thanks. Best, Huaicheng On Tue, Feb 27, 2018 at 10:35 AM, Stefan Hajnoczi wrote: > On Tue, Feb 27, 2018 at 12:04:48PM +0100, Paolo Bonzini wrote: > > On

Re: [Qemu-devel] [PATCH v2 5/5] xlnx-zynqmp-pmu: Connect the IOMOD GPI/GPO devices

2018-03-01 Thread Philippe Mathieu-Daudé
On 02/28/2018 07:32 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > hw/microblaze/xlnx-zynqmp-pmu.c | 77 > +++-- > 1 file changed, 75 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 14/15] chardev: tcp: postpone async connection setup

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > This patch allows the socket chardev async connection be setup with > non-default gcontext. We do it by postponing the setup to machine done, > since until then we can know which context we should run the async > operation on. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 13/15] char: use chardev's gcontext for async connect

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > Generalize the function to create the async QIO task connection. Also, > fix the context pointer to use the chardev's gcontext. > > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 25 ++--- > 1 file changed,

Re: [Qemu-devel] [PATCH v2 01/15] chardev: fix leak in tcp_chr_telnet_init_io()

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > Need to free TCPChardevTelnetInit when session established. > > Since at it, switch to use G_SOURCE_* macros. > > Reviewed-by: Daniel P. Berrange > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 10

Re: [Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > Introduce ChardevClass.chr_machine_done() hook so that chardevs can run > customized procedures after machine init. > > There was an existing mux user already that did similar thing but used a > raw machine done notifier. Generalize it into a framework, and

Re: [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > +static bool tcp_chr_machine_done; > + > static void tcp_chr_reconn_timer_cancel(SocketChardev *s) > { > if (s->reconnect_timer) { > @@ -719,6 +721,11 @@ static void tcp_chr_tls_init(Chardev *chr) > Error *err = NULL; > gchar *name; > > +

[Qemu-devel] [PATCH v3 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

2018-03-01 Thread Max Filippov
In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when mmap, munmap, mprotect, mremap or shmat is called for an address outside the guest address space. mmap and mprotect should return ENOMEM in such case.

Re: [Qemu-devel] [PATCH v7 3/9] xlnx-zynqmp-pmu: Add the CPU and memory

2018-03-01 Thread Philippe Mathieu-Daudé
Hi Alistair, Edgar, On 01/22/2018 04:43 PM, Alistair Francis wrote: > Connect the MicroBlaze CPU and the ROM and RAM memory regions. > > Signed-off-by: Alistair Francis > Reviewed-by: Edgar E. Iglesias > --- > > V6: > - Pass initrd

Re: [Qemu-devel] [RFC PATCH 2/2] migrate: Tests for migrating to an already used QEMU

2018-03-01 Thread Dr. David Alan Gilbert
* Richard Palethorpe (rpaletho...@suse.com) wrote: > Currently this appears to work for X86_64, but PPC64 fails due to some > unexpected data on the serial port after migration. This probably requires > quite a bit more work. I think the challenge is you need to drain the serial output to make

Re: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

2018-03-01 Thread no-reply
Hi, This series failed build test on ppcle host. Please find the details below. Message-id: 20180301135856.22698-1-rjo...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt. Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will

Re: [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 16:46, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:31PM +0800, Peter Xu wrote: >> It was originally created by qio_channel_add_watch() so it's always >> assigning the task to main context. Now we use the new API called >> qio_channel_add_watch_source() so that we get

Re: [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > +/** > + * qio_channel_tls_handshake_full: > + * @ioc: the TLS channel object > + * @func: the callback to invoke when completed > + * @opaque: opaque data to pass to @func > + * @destroy: optional callback to free @opaque > + * @context: the context that TLS

Re: [Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source}

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > + * qio_channel_add_watch_source: > + * @ioc: the channel object > + * @condition: the I/O condition to monitor > + * @func: callback to invoke when the source becomes ready > + * @user_data: opaque data to pass to @func > + * @notify: callback to free

Re: [Qemu-devel] [PATCH v2 5/5] xlnx-zynqmp-pmu: Connect the IOMOD GPI/GPO devices

2018-03-01 Thread Philippe Mathieu-Daudé
On 02/28/2018 07:32 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > hw/microblaze/xlnx-zynqmp-pmu.c | 77 > +++-- > 1 file changed, 75 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 06/15] qio: store gsources for net listeners

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > Originally we were storing the GSources tag IDs. That'll be not enough > if we are going to support non-default gcontext for QIO code. Switch to > GSources without changing anything real. Now we still always pass in > NULL, which means the default

Re: [Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 09:44, Peter Xu wrote: > + * @context: the context to run the complete hook Please note the behavior for NULL context here, too. Paolo > * Run a task in a background thread. When @worker > * returns it will call qio_task_complete() in > - * the main event thread context. > + *

Re: [Qemu-devel] [PULL 00/13] virtio, vhost, pci, pc: features, fixes and cleanups

2018-03-01 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1519922735-29054-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 00/13]

Re: [Qemu-devel] [PATCH v2 4/5] hw/gpio: Add support for the xlnx-pmu-iomod-gpi device

2018-03-01 Thread Philippe Mathieu-Daudé
Hi Alistair, On 02/28/2018 07:32 PM, Alistair Francis wrote: > Add support for setting the device and either input or output. > > Signed-off-by: Alistair Francis > --- > > include/hw/gpio/xlnx-pmu-iomod-gp.h | 7 - > hw/gpio/xlnx-pmu-iomod-gp.c | 55

Re: [Qemu-devel] [PATCH v2 3/5] hw/gpio: Add the xlnx-pmu-iomod-gpo device

2018-03-01 Thread Philippe Mathieu-Daudé
Hi Alistair, On 02/28/2018 07:32 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > include/hw/gpio/xlnx-pmu-iomod-gp.h | 52 + > hw/gpio/xlnx-pmu-iomod-gp.c | 150 > >

Re: [Qemu-devel] [PULL 00/42] target-arm queue

2018-03-01 Thread Peter Maydell
following changes since commit 6697439794f72b3501ee16bb95d16854f9981421: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180227-pull-request' into staging (2018-02-27 > 17:50:46 +) > > are available in the Git repository at: > > git://git.linaro.org/people/

Re: [Qemu-devel] [edk2] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module

2018-03-01 Thread Stefan Berger
On 02/26/2018 04:58 AM, Laszlo Ersek wrote: On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The module allows to tweak and interact with the TPM. Note that many actions are broken due to implementation of qemu TPM (providing it's own

[Qemu-devel] [PULL 10/13] cryptodev: add vhost-user as a new cryptodev backend

2018-03-01 Thread Michael S. Tsirkin
From: Gonglei Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by:

Re: [Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

2018-03-01 Thread Peter Maydell
On 28 February 2018 at 11:01, Abdallah Bouassida wrote: > Generate an XML description for the cp-regs. > Register these regs with the gdb_register_coprocessor(). > Add arm_gdb_get_sysreg() to use it as a callback to read those regs. > > Signed-off-by: Abdallah

[Qemu-devel] [PULL 11/13] cryptodev: add vhost support

2018-03-01 Thread Michael S. Tsirkin
From: Gonglei Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the

Re: [Qemu-devel] [PATCH] decodetree: Propagate return value from translate subroutines

2018-03-01 Thread Richard Henderson
On 03/01/2018 03:59 AM, Peter Maydell wrote: > On 28 February 2018 at 16:48, Richard Henderson > wrote: >> Allow the translate subroutines to return false for invalid insns. >> >> At present we can of course invoke an invalid insn exception from within >> the

[Qemu-devel] [PULL 12/13] cryptodev-vhost-user: add crypto session handler

2018-03-01 Thread Michael S. Tsirkin
From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 1/2] migrate: Allow incoming migration without defer

2018-03-01 Thread Dr. David Alan Gilbert
* Richard Palethorpe (rpaletho...@suse.com) wrote: > Allow a QEMU instance which has been started and used without the "-incoming" > flag to accept an incoming migration with the "migrate-incoming" QMP > command. This allows the user to dump the VM state to an external file then > revert to that

[Qemu-devel] [PULL 09/13] docs/vmcoreinfo: detail unsupported host format behaviour

2018-03-01 Thread Michael S. Tsirkin
From: Marc-André Lureau Suggested-by: Michael S. Tsirkin Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 13/13] cryptodev-vhost-user: set the key length

2018-03-01 Thread Michael S. Tsirkin
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/cryptodev-vhost-user.h | 3 +++ backends/cryptodev-vhost-user.c | 4 2

Re: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

2018-03-01 Thread no-reply
Hi, This series failed build test on ppcbe host. Please find the details below. Type: series Message-id: 20180301135856.22698-1-rjo...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm: Use more CONFIG switches to decide which object files should be linked

2018-03-01 Thread Philippe Mathieu-Daudé
Hi Thomas, On 03/01/2018 11:13 AM, Thomas Huth wrote: > On 01.03.2018 14:03, Peter Maydell wrote: >> On 1 March 2018 at 05:46, Thomas Huth wrote: >>> A lot of ARM object files are linked into the executable unconditionally, >>> even though we have corresponding CONFIG switches

[Qemu-devel] [PULL 00/13] virtio, vhost, pci, pc: features, fixes and cleanups

2018-03-01 Thread Michael S. Tsirkin
The following changes since commit 8cb340c613ee3e626b070e0429c589f8a60ac657: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-03-01 12:32:31 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 08/13] vhost: fix incorrect check in vhost_verify_ring_mappings

2018-03-01 Thread Michael S. Tsirkin
From: Jia He In commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks"), it checks the virtqueue desc mapping for 3 times. Fixed: commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks") Signed-off-by: Jia He Reviewed-by: Michael S.

[Qemu-devel] [PULL 05/13] docs: pcie: Spell out machine type needs for PCIe features

2018-03-01 Thread Michael S. Tsirkin
From: Kashyap Chamarthy PCIe features are available only via the 'q35' machine type for x86 and the 'virt' machine type for AArch64 architecture. Mention that explicitly. Thanks: Daniel Berrangé Signed-off-by: Kashyap Chamarthy Reviewed-by: Daniel P.

[Qemu-devel] [PULL 07/13] vhost: avoid to start/stop virtqueue which is not ready

2018-03-01 Thread Michael S. Tsirkin
From: Jia He In our Armv8a server, we try to configure the vhost scsi but fail to boot up the guest (-machine virt-2.10). The guest's boot failure is very early, even earlier than grub. There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but ovmf and seabios

Re: [Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

2018-03-01 Thread Peter Maydell
On 28 February 2018 at 11:01, Abdallah Bouassida wrote: > Generate an XML description for the cp-regs. > Register these regs with the gdb_register_coprocessor(). > Add arm_gdb_get_sysreg() to use it as a callback to read those regs. > > Signed-off-by: Abdallah

[Qemu-devel] [PULL 02/13] virtio-pci: trivial fixes in error message

2018-03-01 Thread Michael S. Tsirkin
From: Greg Kurz Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c

[Qemu-devel] [PULL 06/13] vhost: fix memslot limit check

2018-03-01 Thread Michael S. Tsirkin
From: Jay Zhou Since used_memslots will be updated to the actual value after registering memory listener for the first time, move the memslots limit checking to the right place. Reviewed-by: Igor Mammedov Signed-off-by: Jay Zhou

Re: [Qemu-devel] [edk2] [PATCH 0/7] RFC: ovmf: preliminary TPM2 support

2018-03-01 Thread Stefan Berger
On 02/23/2018 10:55 AM, Laszlo Ersek wrote: On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The following series adds basic TPM2 support for OVMF-on-QEMU (I haven't tested TPM1, for lack of interest). It links with the modules to

[Qemu-devel] [PULL 03/13] intel-iommu: Accept 64-bit writes to FEADDR

2018-03-01 Thread Michael S. Tsirkin
From: Jan Kiszka Xen is doing this [1] and currently triggers an abort. [1] http://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=xen/drivers/passthrough/vtd/iommu.c;h=daaed0abbdd06b6ba3d948ea103aadf02651e83c;hb=refs/heads/master#l1108 Reported-by: Luis Lloret

[Qemu-devel] [PULL 01/13] vhost-user: fix memory leak

2018-03-01 Thread Michael S. Tsirkin
From: linzhecheng g_free() was moved from vhost_net_cleanup in commit e6bcb1b, so we should free net after vhost_net_cleanup Signed-off-by: linzhecheng Reviewed-by: Marc-André Lureau < marcandre.lur...@redhat.com> Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 04/13] docs: document virtio-balloon stats

2018-03-01 Thread Michael S. Tsirkin
From: Tomáš Golembiovský Document statistics added in commits commit a0d06486b445985b8d128df172daefbae205bffd Author: Denis V. Lunev Date: Wed Feb 24 10:50:48 2016 +0300 virtio-balloon: add 'available' counter and commit

[Qemu-devel] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes

2018-03-01 Thread Paolo Bonzini
update_header_sync itself does not need to flush the caches to disk. The only paths that allocate clusters are: - bitmap_list_store with in_place=false, called by update_ext_header_and_dir - store_bitmap_data, called by store_bitmap - store_bitmap, called by qcow2_store_persistent_dirty_bitmaps

[Qemu-devel] [PATCH 8/8] block: convert bdrv_check callback to coroutine_fn

2018-03-01 Thread Paolo Bonzini
Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-8-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- block.c | 43 ---

<    1   2   3   4   5   6   >