Re: [Qemu-devel] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt()

On Thu, 1 Mar 2018 10:38:52 +0100 Auger Eric wrote: [...] > >>> { > >>> @@ -1755,7 +1755,14 @@ void build_fadt(GArray *tbl, BIOSLinker *linker, > >>> const AcpiFadtData *f, > >>> > >>> build_append_gas_from_struct(tbl, >reset_reg); /* RESET_REG */ > >>>

[Qemu-devel] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts()

From: Stefan Hajnoczi BlockDriver->bdrv_create() has been called from coroutine context since commit 5b7e1542cfa41a281af9629d31cef03704d976e6 ("block: make bdrv_create adopt coroutine"). Make this explicit by renaming to .bdrv_co_create_opts() and add the coroutine_fn

[Qemu-devel] [Bug 1752646] [NEW] Freezing VNC screen on some the UEFI framebuffer applications

Public bug reported: Hi folks! I use TianCore (UEFI) formware on the qemu (master version last commit a6e0344). When kernel/linux is start, it using UEFI Framebuffer. Then I run UEFI application (which writes directly to the framebuffer) my VNS screen is freezing. Then I restart vnclient I see

[Qemu-devel] [PATCH 6/8] qed: make bdrv_qed_do_open a coroutine_fn

It is called from qed_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-5-git-send-email-pbonz...@redhat.com>

[Qemu-devel] [PATCH 7/8] block: convert bdrv_invalidate_cache callback to coroutine_fn

QED's bdrv_invalidate_cache implementation would like to reuse functions that acquire/release the metadata locks. Call it from coroutine context to simplify the logic. Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-6-git-send-email-pbonz...@redhat.com>

[Qemu-devel] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

This function iterates over all snapshots of a qcow2 file in order to expand all zero clusters, but it does not validate the snapshots' L1 tables first. We now have a function to take care of this, so let's use it. We can also take the opportunity to replace the sector-based bdrv_read() with

[Qemu-devel] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches

They will be used to avoid recursively taking s->lock during bdrv_open or bdrv_check. Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-7-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- block/qcow2-refcount.c | 28

[Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context

Check and invalidate_cache share some parts of the implementation with the regular I/O path. This is sometimes complicated because the I/O path wants to use a CoMutex but that is not possible outside coroutine context. By moving things to coroutine context, we can remove special cases. In fact,

[Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn

From: Stefan Hajnoczi qcow2_create2() calls qemu_co_mutex_lock(). Only a coroutine_fn may call another coroutine_fn. In fact, qcow2_create2 is always called from coroutine context. Rename the function to add the "co" moniker and add coroutine_fn. Reported-by: Marc-André

[Qemu-devel] [PATCH 5/8] qcow2: make qcow2_do_open a coroutine_fn

It is called from qcow2_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-4-git-send-email-pbonz...@redhat.com>

[Qemu-devel] [PATCH 7/7] qcow2: Make qemu-img check detect corrupted L1 tables in snapshots

'qemu-img check' cannot detect if a snapshot's L1 table is corrupted. This patch checks the table's offset and size and reports corruption if the values are not valid. This patch doesn't add code to fix that corruption yet, only to detect and report it. Signed-off-by: Alberto Garcia

[Qemu-devel] [PATCH 6/7] qcow2: Check snapshot L1 table in qcow2_snapshot_delete()

This function deletes a snapshot from disk, removing its entry from the snapshot table, freeing its L1 table and decreasing the refcounts of all clusters. The L1 table offset and size are however not validated. If we use invalid values in this function we'll probably corrupt the image even more,

Re: [Qemu-devel] [PATCH 1/2] block: curl: Allow arbitrary HTTP request headers to be set.

On Thu, Mar 01, 2018 at 04:11:18PM +, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 01:58:55PM +, Richard W.M. Jones wrote: > > Allow arbitrary HTTP request headers to be set, like this: > > > > qemu-img create -f qcow2 \ > > -b 'json:{ "file.driver":"http", > >

[Qemu-devel] [PATCH 5/7] qcow2: Check snapshot L1 table in qcow2_snapshot_goto()

This function copies a snapshot's L1 table into the active one without validating it first. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia --- block/qcow2-snapshot.c | 6 ++ tests/qemu-iotests/080 | 2 ++

[Qemu-devel] [PATCH 2/7] qcow2: Check L1 table offset in qcow2_snapshot_load_tmp()

This function checks that the size of a snapshot's L1 table is not too large, but it doesn't validate the offset. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia --- block/qcow2-snapshot.c | 8 +--- tests/qemu-iotests/080

Re: [Qemu-devel] [PATCH v3 2/4] target/arm: Add "_S" suffix to the secure version of a sysreg

On 28 February 2018 at 11:01, Abdallah Bouassida wrote: > This is a preparation for the coming feature of creating dynamically an XML > description for the ARM sysregs. > Add "_S" suffix to the secure version of sysregs that have both S and NS views > Replace

[Qemu-devel] [PATCH 1/7] qcow2: Generalize validate_table_offset() into qcow2_validate_table()

This function checks that the offset and size of a table are valid. While the offset checks are fine, the size check is too generic, since it only verifies that the total size in bytes fits in a 64-bit integer. In practice all tables used in qcow2 have much smaller size limits, so the size needs

[Qemu-devel] [PATCH 4/7] qcow2: Check snapshot L1 tables in qcow2_check_metadata_overlap()

The inactive-l2 overlap check iterates uses the L1 tables from all snapshots, but it does not validate them first. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia --- block/qcow2-refcount.c | 10 +-

[Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

Hey ho! As we have already discussed in the mailing list, the offset and size values of snapshots' L1 tables are almost never validated in the QEMU code. One way to deal with this is to validate them when the image is being opened (in qcow2_read_snapshots()) and return an error if there's

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

On Thu, 1 Mar 2018 10:08:06 +0300 Julia Suvorova via Qemu-devel wrote: > basename(3) and dirname(3) modify their argument and may return > pointers to statically allocated memory which may be overwritten by > subsequent calls. > g_path_get_basename and g_path_get_dirname

Re: [Qemu-devel] [PATCH v8 2/2] vhost: used_memslots refactoring

On Tue, Feb 27, 2018 at 03:10:05PM +0800, Jay Zhou wrote: > Used_memslots is shared by vhost kernel and user, it is equal to > dev->mem->nregions, which is correct for vhost kernel, but not for > vhost user, the latter one uses memory regions that have file > descriptor. E.g. a VM has a vhost-user

Re: [Qemu-devel] [PATCH v3 1/4] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

On 28 February 2018 at 11:01, Abdallah Bouassida wrote: > This is a preparation for the coming feature of creating dynamically an XML > description for the ARM sysregs. > A register has ARM_CP_NO_GDB enabled will not be shown in the dynamic XML. > This bit is

Re: [Qemu-devel] [PATCH 1/2] block: curl: Allow arbitrary HTTP request headers to be set.

On Thu, Mar 01, 2018 at 01:58:55PM +, Richard W.M. Jones wrote: > Allow arbitrary HTTP request headers to be set, like this: > > qemu-img create -f qcow2 \ > -b 'json:{ "file.driver":"http", > "file.url":"http://192.168.0.249/scratch/test.img;, >

Re: [Qemu-devel] [RFC PATCH] sparc: fix leon3 casa instruction when MMU is disabled

On 03/01/2018 06:22 AM, KONRAD Frederic wrote: > There is an other way to do that: emiting the instruction with a > MMU_PHYS_IDX when the MMU is disabled. I can switch to that if it's a > prefered method. Yes, that would be preferred. r~

Re: [Qemu-devel] [PATCH v2 00/15] qio: general non-default GMainContext support

On Thu, Mar 01, 2018 at 04:44:23PM +0800, Peter Xu wrote: > This is another preparation work for monitor OOB seires. > > V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html > > V2 rewrote the bottom half of the code. The first 8 patches are > mostly the same, but I rewrote

Re: [Qemu-devel] [PATCH v2 1/3] hw/acpi-build: build SRAT memory affinity structures for DIMM devices

On Thu, 1 Mar 2018 21:12:37 +0800 Haozhong Zhang wrote: > On 03/01/18 14:01 +0100, Igor Mammedov wrote: > > On Thu, 1 Mar 2018 19:56:51 +0800 > > Haozhong Zhang wrote: > > > > > On 03/01/18 11:42 +0100, Igor Mammedov wrote: > > > > On

Re: [Qemu-devel] [PATCH v2 14/15] chardev: tcp: postpone async connection setup

On Thu, Mar 01, 2018 at 04:44:37PM +0800, Peter Xu wrote: > This patch allows the socket chardev async connection be setup with > non-default gcontext. We do it by postponing the setup to machine done, > since until then we can know which context we should run the async > operation on. > >

Re: [Qemu-devel] [PATCH v2 04/15] migration: let incoming side use thread context

On Thu, Mar 01, 2018 at 04:44:27PM +0800, Peter Xu wrote: > The old incoming migration is running in main thread and default > gcontext. With the new qio_channel_add_watch_full() we can now let it > run in the thread's own gcontext (if there is one). > > Currently this patch does nothing alone.

Re: [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done

On Thu, Mar 01, 2018 at 04:44:38PM +0800, Peter Xu wrote: > TLS handshake may create background GSource tasks, while we won't know > the correct GMainContext until the whole chardev (including frontend) > inited. Let's postpone the initial TLS handshake until machine done. > > If we dynamically

Re: [Qemu-devel] [Qemu-arm] [PATCH 05/19] armv7m: Forward idau property to CPU object

On 20 February 2018 at 18:03, Peter Maydell wrote: > Create an "idau" property on the armv7m container object which > we can forward to the CPU object. Annoyingly, we can't use > object_property_add_alias() because the CPU object we want to > forward to doesn't exist

[Qemu-devel] [PATCH v2 4/4] tricore: renamed masking of PIE

From: David Brenken Signed-off-by: David Brenken Signed-off-by: Florian Artmeier Signed-off-by: Georg Hofstetter --- target/tricore/cpu.h | 3 ++-

[Qemu-devel] [PATCH v2 3/4] tricore: renamed masking of IE

From: David Brenken Signed-off-by: David Brenken Signed-off-by: Florian Artmeier Signed-off-by: Georg Hofstetter --- target/tricore/cpu.h | 3 ++-

[Qemu-devel] [PATCH v2 2/4] tricore: added CORE_ID

From: David Brenken Signed-off-by: David Brenken Signed-off-by: Florian Artmeier Signed-off-by: Georg Hofstetter --- target/tricore/cpu.h| 1 + target/tricore/csfr.def | 1 +

[Qemu-devel] [PATCH v2 0/4] tricore: added small features + fixed wrong masks

From: David Brenken Hi Bastian, thank you for your feedback and sorry for the late reply. Changes from v1: * Removed OPC1_16_SB_JNE instruction. * Added CPU feature checks to new instructions. * Renamed ICR.IE and PCXI.PIE masks and added corresponding TC 1.6

[Qemu-devel] [PATCH v2 1/4] tricore: added some missing cpu instructions

From: David Brenken Signed-off-by: David Brenken Signed-off-by: Florian Artmeier Signed-off-by: Georg Hofstetter --- target/tricore/translate.c | 27

Re: [Qemu-devel] [PATCH v2 2/5] target/i386: Populate AMD Processor Cache Information

Radim, Thanks for your comments. I am working on the changes. But, I need few clarifications on your comments. Please see inline. > -Original Message- > From: Radim Krčmář [mailto:rkrc...@redhat.com] > Sent: Wednesday, February 28, 2018 12:09 PM > To: Moger, Babu >

Re: [Qemu-devel] [RFC PATCH 0/2] Increase usability of external snapshots

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180227115651.30762-1-rpaletho...@suse.com Subject: [Qemu-devel] [RFC PATCH 0/2] Increase usability of external snapshots === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 03/01/2018 03:36 PM, David Hildenbrand wrote: >> I have a concern with this proposition and with the original code: > Very good, this is exactly what I talked to Conny about yesterday. > > Short version: CPU model is guest ABI, everything else is configuration. > Nod. > > So I think for

Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

On Thu, Mar 01, 2018 at 04:44:30PM +0800, Peter Xu wrote: > TCP chardevs can be using QIO network listeners working in the > background when in listening mode. However the network listeners are > always running in main context. This can race with chardevs that are > running in non-main contexts.

Re: [Qemu-devel] [PATCH 2/2] block: curl: Allow Certificate Authority bundle to be passed in.

On Thu, Mar 01, 2018 at 03:34:38PM +, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 01:58:56PM +, Richard W.M. Jones wrote: > > This allows a Certificate Authority bundle to be passed to the curl > > driver, allowing authentication against servers that check > > certificates. For

Re: [Qemu-devel] [PATCH v2 06/15] qio: store gsources for net listeners

On Thu, Mar 01, 2018 at 04:44:29PM +0800, Peter Xu wrote: > Originally we were storing the GSources tag IDs. That'll be not enough > if we are going to support non-default gcontext for QIO code. Switch to > GSources without changing anything real. Now we still always pass in > NULL, which means

Re: [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn

On Thu, Mar 01, 2018 at 04:44:33PM +0800, Peter Xu wrote: > We have worked on qio_task_run_in_thread() already. Further, let > qio_channel_socket_connect_async() pass that context to it. > > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 4 ++-- >

Re: [Qemu-devel] [PATCH v3 12/16] target/arm: Decode aa64 armv8.3 fcmla

On 1 March 2018 at 15:28, Peter Maydell wrote: > On 1 March 2018 at 13:33, Peter Maydell wrote: >> On 28 February 2018 at 19:31, Richard Henderson >> wrote: >>> Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake

On Thu, Mar 01, 2018 at 04:44:34PM +0800, Peter Xu wrote: > qio_channel_tls_handshake_full() is introduced to allow the TLS to be > run on a non-default context. Still, no functional change. > > Signed-off-by: Peter Xu > --- > include/io/channel-tls.h | 17 >

Re: [Qemu-devel] [PATCH 1/2] block: curl: Allow arbitrary HTTP request headers to be set.

On Thu, Mar 01, 2018 at 03:24:48PM +, Nir Soffer wrote: > Other issue that you need to consider is that you cannot > create images via the http. Images are created only via > engine API/UI. We've got a separate bit of Python creating the image so I think we're ok here. > What ovirt-imageio

Re: [Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask

On Thu, Mar 01, 2018 at 04:44:32PM +0800, Peter Xu wrote: > qio_task_run_in_thread() allows main thread to run blocking operations > in the background. However it has an assumption on that it's always > working with the default context. This patch tries to allow the threaded > QIO task framework

Re: [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext

On Thu, Mar 01, 2018 at 04:44:31PM +0800, Peter Xu wrote: > It was originally created by qio_channel_add_watch() so it's always > assigning the task to main context. Now we use the new API called > qio_channel_add_watch_source() so that we get the GSource handle rather > than the tag ID. > >

Re: [Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source}

On Thu, Mar 01, 2018 at 04:44:26PM +0800, Peter Xu wrote: > Firstly, introduce an internal qio_channel_add_watch_full(), which > enhances qio_channel_add_watch() that context can be specified. > > Then add a new API wrapper qio_channel_add_watch_source() to return a > GSource pointer rather than

Re: [Qemu-devel] [PATCH 2/2] block: curl: Allow Certificate Authority bundle to be passed in.

On Thu, Mar 01, 2018 at 01:58:56PM +, Richard W.M. Jones wrote: > This allows a Certificate Authority bundle to be passed to the curl > driver, allowing authentication against servers that check > certificates. For example this allows you to access a disk on an > oVirt node: > > qemu-img

Re: [Qemu-devel] [PATCH] migration: Fix block failure cases

* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 28, 2018 at 04:49:37PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This fixes a couple of cases where the block migration capability > > doesn't get cleared when a migration failed.

Re: [Qemu-devel] [PATCH V7 0/4] tests: Add migration test for aarch64

* Wei Huang (w...@redhat.com) wrote: > This patchset adds a migration test for aarch64. It leverages > Dave Gilbert's recent patch "tests/migration: Add source to PC boot block" > to create a new test case for aarch64. Other than Drew's comment about the ppc comment; I'm happy with this. Dave >

Re: [Qemu-devel] [PATCH v3 12/16] target/arm: Decode aa64 armv8.3 fcmla

On 1 March 2018 at 13:33, Peter Maydell wrote: > On 28 February 2018 at 19:31, Richard Henderson > wrote: >> Signed-off-by: Richard Henderson >> --- >> target/arm/helper.h| 11 >>

Re: [Qemu-devel] [PATCH 2/2] block: curl: Allow Certificate Authority bundle to be passed in.

On Thu, Mar 1, 2018 at 4:02 PM Richard W.M. Jones wrote: > This allows a Certificate Authority bundle to be passed to the curl > driver, allowing authentication against servers that check > certificates. For example this allows you to access a disk on an > oVirt node: > >

Re: [Qemu-devel] [PATCH V7 3/4] tests/migration: Add migration-test header file

* Andrew Jones (drjo...@redhat.com) wrote: > On Wed, Feb 28, 2018 at 12:02:14PM -0600, Wei Huang wrote: > > This patch moves the settings related migration-test from the > > migration-test.c file to a seperate header file. It also renames the > > x86-a-b-bootblock.s file extension from .s to .S,

Re: [Qemu-devel] [PATCH 1/2] block: curl: Allow arbitrary HTTP request headers to be set.

On Thu, Mar 1, 2018 at 4:00 PM Richard W.M. Jones wrote: > Allow arbitrary HTTP request headers to be set, like this: > > qemu-img create -f qcow2 \ > -b 'json:{ "file.driver":"http", > "file.url":"http://192.168.0.249/scratch/test.img;, >

Re: [Qemu-devel] [PATCH v3 0/5] block: fix blk_aio_*() segfault when blk->root == NULL

Am 16.02.2018 um 17:50 hat Stefan Hajnoczi geschrieben: > v3: > * Add Patch 1 to rename aio_context_in_iothread() to >in_aio_context_home_thread() [Eric] > v2: > * Introduce AIO_WAIT_WHILE() since aio_poll(ctx, true) is not allowed [Paolo] > > Using bdrv_inc_in_flight(blk_bs(blk)) doesn't

Re: [Qemu-devel] [edk2] [PATCH 4/7] ovmf: link with Tcg2Pei module

Hi On Mon, Feb 26, 2018 at 10:38 AM, Laszlo Ersek wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> This module will initialize TPM device, measure reported FVs and BIOS >> version. >> >> CC: Laszlo

Re: [Qemu-devel] [edk2] [PATCH 2/7] ovmf: link with Tcg2ConfigPei module

Hi On Fri, Feb 23, 2018 at 6:31 PM, Laszlo Ersek wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> This module initializes TPM device type based on variable and >> detection. > > (1) I suggest we say

Re: [Qemu-devel] [PATCH v2 0/4] vl: introduce vm_shutdown()

On Thu, Mar 01, 2018 at 09:15:17AM +0800, Fam Zheng wrote: > On Wed, 02/28 18:19, Stefan Hajnoczi wrote: > > v2: > > * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd > >from a BH in the IOThread [Fam] > > > > There are several race conditions in

Re: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180301135856.22698-1-rjo...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will

Re: [Qemu-devel] [PULL 00/42] target-arm queue

On 1 March 2018 at 13:00, wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180301112403.12487-1-peter.mayd...@linaro.org > Subject: [Qemu-devel] [PULL 00/42] target-arm queue

Re: [Qemu-devel] [PULL 0/1] Block patches 2018-03-01

On 1 March 2018 at 07:54, Fam Zheng wrote: > The following changes since commit 6697439794f72b3501ee16bb95d16854f9981421: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180227-pull-request' into staging (2018-02-27 > 17:50:46 +) > > are available in the Git

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 01.03.2018 15:12, Pierre Morel wrote: > On 28/02/2018 12:40, Cornelia Huck wrote: >> On Wed, 28 Feb 2018 11:26:30 +0100 >> David Hildenbrand wrote: >> >>> Then I request the following change in KVM: >>> >>> If KVM_S390_VM_CPU_FEAT_AP is enabled in KVM, ECA.28 is _always_ set

[Qemu-devel] [BUG] I/O thread segfault for QEMU on s390x

Hi, I have been noticing some segfaults for QEMU on s390x, and I have been hitting this issue quite reliably (at least once in 10 runs of a test case). The qemu version is 2.11.50, and I have systemd created coredumps when this happens. Here is a back trace of the segfaulting thread: #0

Re: [Qemu-devel] [Qemu-trivial] [PATCH] grlib_apbuart: always enable tx and rx

Hi Phil, I see your point. But I tend to prefer modifying the uart than having a bunch of hand assembled code in the machine. Note that the result is the same. Thanks, Fred On 03/01/2018 11:49 AM, Philippe Mathieu-Daudé wrote: Hi Frederic, On 03/01/2018 07:02 AM, KONRAD Frederic wrote: We

Re: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

On Thu, Mar 01, 2018 at 06:21:15AM -0800, no-re...@patchew.org wrote: > /tmp/qemu-test/src/block/curl.c: In function 'curl_open': > /tmp/qemu-test/src/block/curl.c:770:15: error: assignment discards 'const' > qualifier from pointer target type [-Werror=discarded-qualifiers] > s->cainfo =

Re: [Qemu-devel] [PATCH v3 12/16] target/arm: Decode aa64 armv8.3 fcmla

On 1 March 2018 at 13:33, Peter Maydell wrote: > Shouldn't there be a feature check on ARM_FEATURE_V8_FCMA somewhere > in the three_reg_same_extra code path? Oh, there is, because FCADD are also (feature bit name notwithstanding) under that feature bit. thanks -- PMM

[Qemu-devel] [RFC PATCH] sparc: fix leon3 casa instruction when MMU is disabled

Since the commit af7a06bac7d3abb2da48ef3277d2a415772d2ae8: `casa [..](10), .., ..` triggers a data access exception when the MMU is disabled. This fixes this wrong behavior. Signed-off-by: KONRAD Frederic --- Notes: There is an other way to do that: emiting the

Re: [Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180301135856.22698-1-rjo...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] block: curl:

Re: [Qemu-devel] [PATCH v2 10/11] qemu-binfmt-conf.sh: add qemu-xtensa

Le 28/02/2018 à 23:16, Max Filippov a écrit : > Register qemu-xtensa and qemu-xtensaeb for transparent linux userspace > emulation. > > Cc: Riku Voipio > Cc: Laurent Vivier > Signed-off-by: Max Filippov > --- >

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 14/16] target/arm: Decode aa32 armv8.3 2-reg-index

On 28 February 2018 at 19:31, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 61 > ++ > 1 file changed, 61 insertions(+) > > @@ -8492,6

Re: [Qemu-devel] [PATCH] hw/arm: Use more CONFIG switches to decide which object files should be linked

On 01.03.2018 14:03, Peter Maydell wrote: > On 1 March 2018 at 05:46, Thomas Huth wrote: >> A lot of ARM object files are linked into the executable unconditionally, >> even though we have corresponding CONFIG switches like CONFIG_PXA2XX or >> CONFIG_OMAP. We should make sure to

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is enabled in KVM, ECA.28 is _always_ set (not just if an AP device is configured). This especially

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 16/16] target/arm: Enable ARM_FEATURE_V8_FCMA

On 1 March 2018 at 13:20, Peter Maydell wrote: > On 28 February 2018 at 19:31, Richard Henderson > wrote: >> Enable it for the "any" CPU used by *-linux-user. > We should be setting some hwcap bits in linux-user for these new feature >

Re: [Qemu-devel] [PATCH v3 13/16] target/arm: Decode aa32 armv8.3 3-same

On 28 February 2018 at 19:31, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 68 > ++ > 1 file changed, 68 insertions(+) > @@ -8424,6

Re: [Qemu-devel] [PATCH v1] s390x/tcg: fix loading 31bit PSWs with the highest bit set

On 01.03.2018 14:53, Thomas Huth wrote: > On 01.03.2018 13:08, David Hildenbrand wrote: >> Let's also put the 31-bit hack in front of the REAL MMU, otherwise right >> now we get errors when loading a PSW where the highest bit is set (e.g. >> via s390-netboot.img). The highest bit is not masked

[Qemu-devel] [PATCH RESEND v8 1/4] cryptodev: add vhost-user as a new cryptodev backend

From: Gonglei Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by:

Re: [Qemu-devel] [PATCH v3 15/16] target/arm: Decode t32 simd 3reg and 2reg_scalar extension

On 28 February 2018 at 19:31, Richard Henderson wrote: > Happily, the bits are in the same places compared to a32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 14 +- > 1 file changed, 13

[Qemu-devel] [PATCH RESEND v8 0/4] cryptodev: add vhost support

From: Gonglei I posted the RFC verion a few months ago for DPDK vhost-crypto implmention, and now it's time to send the formal version. Because we need an user space scheme for better performance. The vhost user crypto server side patches had been sent to DPDK

Re: [Qemu-devel] [PATCH v3 12/16] target/arm: Decode aa64 armv8.3 fcmla

On 28 February 2018 at 19:31, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 11 > target/arm/translate-a64.c | 94 +--- > target/arm/vec_helper.c|

Re: [Qemu-devel] [Qemu-arm] VCPU hotplug on KVM/ARM

On 01.03.2018 11:05, Peter Maydell wrote: > On 1 March 2018 at 09:50, Igor Mammedov wrote: >> In QEMU on x86 (and I think ppc, s390 as well), we create vCPUs on demand.>> >> It would be nice if ARM would be able to do that too, >> so that it could take advantage of the same

[Qemu-devel] [PATCH 2/2] block: curl: Allow Certificate Authority bundle to be passed in.

This allows a Certificate Authority bundle to be passed to the curl driver, allowing authentication against servers that check certificates. For example this allows you to access a disk on an oVirt node: qemu-img create -f qcow2 \ -b 'json:{ "file.driver": "https",

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 16/16] target/arm: Enable ARM_FEATURE_V8_FCMA

On 28 February 2018 at 19:31, Richard Henderson wrote: > Enable it for the "any" CPU used by *-linux-user. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 1 + > target/arm/cpu64.c | 1 + > 2 files changed, 2

[Qemu-devel] [PATCH 1/2] block: curl: Allow arbitrary HTTP request headers to be set.

Allow arbitrary HTTP request headers to be set, like this: qemu-img create -f qcow2 \ -b 'json:{ "file.driver":"http", "file.url":"http://192.168.0.249/scratch/test.img;, "file.header": ["Authorization: letmein"] }' \ test.qcow2 which adds the

[Qemu-devel] [PATCH 0/2] block: curl: Proof of concept for connecting to oVirt.

This is a proof of concept patch which needs a bunch more testing. I'm just posting it to get feedback. It's almost possible to connect qemu to an oVirt / RHV server and upload or download or otherwise modify disk images. However the curl driver is missing a couple of features to satisfy oVirt's

Re: [Qemu-devel] [PULL 00/42] target-arm queue

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180301112403.12487-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PULL 00/42] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v8 0/4] cryptodev: add vhost support

The Intel guy Fan Zhang(CCed) reported a config issue when enabling and testing vhost_crypto, so I resend this version, thanks! Regards, Jay > -Original Message- > From: Zhoujian (jay) > Sent: Tuesday, February 27, 2018 2:33 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com;

Re: [Qemu-devel] [PATCH v3 13/16] target/arm: Decode aa32 armv8.3 3-same

On 28 February 2018 at 19:31, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 68 > ++ > 1 file changed, 68 insertions(+) > > diff --git

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 02/16] target/arm: Refactor disas_simd_indexed decode

On 28 February 2018 at 19:31, Richard Henderson wrote: > Include the U bit in the switches rather than testing separately. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 129 >

Re: [Qemu-devel] [PATCH v1] s390x/tcg: fix loading 31bit PSWs with the highest bit set

On 01.03.2018 13:08, David Hildenbrand wrote: > Let's also put the 31-bit hack in front of the REAL MMU, otherwise right > now we get errors when loading a PSW where the highest bit is set (e.g. > via s390-netboot.img). The highest bit is not masked away, therefore we > inject addressing

[Qemu-devel] [PATCH qemu v3 0/2] qmp: Add qom-list-properties to list QOM object properties

This adds a new QMP command to list any class/object properties, not just devices. Now comes in 2 patches. Please comment. Thanks. Alexey Kardashevskiy (2): qmp: Merge ObjectPropertyInfo and DevicePropertyInfo qmp: Add qom-list-properties to list QOM object properties qapi-schema.json

[Qemu-devel] [PATCH qemu v3 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

ObjectPropertyInfo is more generic and only missing @description. This adds a description to ObjectPropertyInfo and removes DevicePropertyInfo so the resulting ObjectPropertyInfo can be used elsewhere. Signed-off-by: Alexey Kardashevskiy --- qapi-schema.json | 23

[Qemu-devel] [PATCH qemu v3 2/2] qmp: Add qom-list-properties to list QOM object properties

There is already 'device-list-properties' which does most of the job, however it does not handle everything returned by qom-list-types such as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. It does not handle abstract classes either. This adds a new qom-list-properties

[Qemu-devel] [PATCH RESEND v8 3/4] cryptodev-vhost-user: add crypto session handler

From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by:

[Qemu-devel] [PATCH RESEND v8 2/4] cryptodev: add vhost support

From: Gonglei Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the

[Qemu-devel] [PULL v2 27/27] s390x/tcg: fix loading 31bit PSWs with the highest bit set

From: David Hildenbrand Let's also put the 31-bit hack in front of the REAL MMU, otherwise right now we get errors when loading a PSW where the highest bit is set (e.g. via s390-netboot.img). The highest bit is not masked away, therefore we inject addressing exceptions into the

[Qemu-devel] [PATCH RESEND v8 4/4] cryptodev-vhost-user: set the key length

From: Gonglei Signed-off-by: Gonglei --- backends/cryptodev-vhost-user.c | 4 include/sysemu/cryptodev-vhost-user.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/backends/cryptodev-vhost-user.c

[Qemu-devel] [PULL v2 22/27] qemu-doc: deprecate query-cpus

From: Viktor Mihajlovski Start the deprecation period for QAPI query-cpus (replaced by query-cpus-fast) beginning with 2.12.0. Signed-off-by: Viktor Mihajlovski Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL v2 15/27] s390x/cpu: expose the guest crash information

From: Christian Borntraeger This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the

[Qemu-devel] [PULL v2 16/27] s390/stattrib: Make SaveVMHandlers data static

From: "Dr. David Alan Gilbert" There's no need for this to be dynamic, make it static. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20180212154903.8859-1-dgilb...@redhat.com> Reviewed-by: David Hildenbrand Reviewed-by: Thomas

<    1   2   3   4   5   6   >