Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if

On 21/03/2018 04:25, Peter Xu wrote: > On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote: >> This trips Coverity, which believes the subsequent qio_channel_create_watch >> can dereference a NULL pointer. In reality, tcp_chr_connect's callers >> all have s->ioc properly initialized,

Re: [Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

On 21/03/2018 01:35, John Snow wrote: >> The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the >> AHCI case ide_set_irq was actually called at the end of a mutual recursion. >> Move it early, with the side effect that ide_transfer_start becomes a tail >> call in

Re: [Qemu-devel] [PATCH 2/5] ide: push end_transfer callback to ide_transfer_halt

On 20/03/2018 23:11, John Snow wrote: > Seems sane, with some lingering questions about what the PIO Setup FIS > is supposed to do to begin with still remaining. I agree here too. Smashing the ATA and controller in the same device makes things tricky, so I tried to make these patches pure code

Re: [Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

On 20/03/2018 22:46, John Snow wrote: >> } >> -if (s->bus->dma->ops->start_transfer) { >> -s->bus->dma->ops->start_transfer(s->bus->dma); >> +if (!s->bus->dma->ops->start_transfer) { >> +s->end_transfer_func = end_transfer_func; >> +return; >> } >> +

Re: [Qemu-devel] Partial NUMA config

On 20/3/18 5:46 pm, Igor Mammedov wrote: > On Mon, 19 Mar 2018 15:28:50 +1100 > Alexey Kardashevskiy wrote: > >> On 13/3/18 1:26 pm, Alexey Kardashevskiy wrote: >>> Hi Igor, >>> >>> ec78f8114bc4c1 "numa: use possible_cpus for not mapped CPUs check" added a >>> warning about "All

[Qemu-devel] [Bug 1757323] [NEW] blue screen running windows 10 install DVD on qemu

Public bug reported: i get a blue screen at the first screen of the windows 10 DVD setup (Win10_1709_English_x64.iso, available from MS). The DVD boots fine, and gets to the first dialog: http://codewithoutborders.com/posted/qemu1.png and then if i just wait a minute of so it blue screen's.

[Qemu-devel] [Bug 1757323] Re: blue screen running windows 10 install DVD on qemu

i should add: i do NOT get these crashes if I boot the same image on the host bare-metal. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1757323 Title: blue screen running windows 10 install DVD on

Re: [Qemu-devel] [PATCH 19/19] mac_newworld: move wiring of macio IRQs to macio_newworld_realize()

On Tue, Mar 06, 2018 at 08:31:03PM +, Mark Cave-Ayland wrote: > Since the macio device has a link to the PIC device, we can now wire up the > IRQs directly via qdev GPIOs rather than having to use an intermediate array. > > Signed-off-by: Mark Cave-Ayland

Re: [Qemu-devel] [PATCH 18/19] mac_newworld: remove pics IRQ array and wire up macio to OpenPIC directly

On Tue, Mar 06, 2018 at 08:31:02PM +, Mark Cave-Ayland wrote: > Introduce constants for the pre-defined New World IRQs to help keep things > readable. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [PATCH v3 3/4] cryptodev-vhost-user: add crypto session handler

Hi Jay, Excellent work! The patch, although need some minor rework, has improved the performance. Some comments: 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost_user_init() definition), I

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target/ppc: export external HPT via virtual hypervisor

On Sat, Mar 17, 2018 at 09:55:28AM +0100, Cédric Le Goater wrote: > On 03/17/2018 05:15 AM, David Gibson wrote: > > On Thu, Mar 15, 2018 at 01:33:59PM +, Cédric Le Goater wrote: > >> commit e57ca75ce3b2 ("target/ppc: Manage external HPT via virtual > >> hypervisor") exported a set of methods

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: > Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO > which was to convert the uninorth registers hack to a proper device. Move > these registers to a new uninorth device, removing the old hacks from >

Re: [Qemu-devel] [PATCH v3 2/4] target/ppc: add basic support for PTCR on POWER9

On Thu, Mar 15, 2018 at 01:34:00PM +, Cédric Le Goater wrote: > The Partition Table Control Register (PTCR) is a hypervisor privileged > SPR. It contains the host real address of the Partition Table and its > size. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if

On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote: > This trips Coverity, which believes the subsequent qio_channel_create_watch > can dereference a NULL pointer. In reality, tcp_chr_connect's callers > all have s->ioc properly initialized, since they are all rooted at >

[Qemu-devel] [PATCH] vhost: add trace for IOTLB miss

Add some trace points for IOTLB translation for vhost. After vhost-user is setup, the only IO path that QEMU will participate should be the IOMMU translation, so it'll be good we can track this with explicit timestamps when needed to see how long time we take to do the translation, and whether

Re: [Qemu-devel] [Qemu-block] [PATCH v1 1/1] iotests: fix test case 185

在 2018/3/21 11:12, QingFeng Hao 写道: 在 2018/3/20 22:31, Stefan Hajnoczi 写道: On Tue, Mar 20, 2018 at 11:11:01AM +0100, Kevin Wolf wrote: Am 19.03.2018 um 18:53 hat Christian Borntraeger geschrieben: On 03/19/2018 05:10 PM, Stefan Hajnoczi wrote: On Mon, Mar 19, 2018 at 9:35 AM, QingFeng

Re: [Qemu-devel] [Qemu-block] [PATCH v1 1/1] iotests: fix test case 185

在 2018/3/20 22:31, Stefan Hajnoczi 写道: On Tue, Mar 20, 2018 at 11:11:01AM +0100, Kevin Wolf wrote: Am 19.03.2018 um 18:53 hat Christian Borntraeger geschrieben: On 03/19/2018 05:10 PM, Stefan Hajnoczi wrote: On Mon, Mar 19, 2018 at 9:35 AM, QingFeng Hao wrote:

Re: [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page

On Wed, 03/21 04:03, Michael S. Tsirkin wrote: > On Wed, Mar 21, 2018 at 09:25:30AM +0800, Fam Zheng wrote: > > On Tue, 03/20 12:34, no-re...@patchew.org wrote: > > > /tmp/qemu-test/src/migration/postcopy-ram.c:787:41: error: 'struct > > > PostCopyFD' declared inside parameter list will not be

Re: [Qemu-devel] [PATCH for-2.12] rdma: Fix 32-bit compilation

On Tue, 03/20 12:30, Marcel Apfelbaum wrote: > Hi Eric, > > On 19/03/2018 23:53, Eric Blake wrote: > > Use the correct printf formats, so that a 32-bit compile doesn't > > spit out lots of warnings about %lx being incompatible with uint64_t. > > Broken since initial commit ef6d4ccd. > > > >

Re: [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page

On Wed, Mar 21, 2018 at 09:25:30AM +0800, Fam Zheng wrote: > On Tue, 03/20 12:34, no-re...@patchew.org wrote: > > /tmp/qemu-test/src/migration/postcopy-ram.c:787:41: error: 'struct > > PostCopyFD' declared inside parameter list will not be visible outside of > > this definition or declaration

Re: [Qemu-devel] [PATCH for-2.12] rdma: Fix 32-bit compilation

On Tue, 03/20 12:30, Marcel Apfelbaum wrote: > Hi Eric, > > On 19/03/2018 23:53, Eric Blake wrote: > > Use the correct printf formats, so that a 32-bit compile doesn't > > spit out lots of warnings about %lx being incompatible with uint64_t. > > Broken since initial commit ef6d4ccd. > > > >

Re: [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page

On Tue, 03/20 12:34, no-re...@patchew.org wrote: > /tmp/qemu-test/src/migration/postcopy-ram.c:787:41: error: 'struct > PostCopyFD' declared inside parameter list will not be visible outside of > this definition or declaration [-Werror] > int postcopy_request_shared_page(struct PostCopyFD

Re: [Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the > AHCI case ide_set_irq was actually called at the end of a mutual recursion. > Move it early, with the side effect that ide_transfer_start becomes a tail > call in

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

I had the branch all set up and ready for a PR, including the tag message, but after dropping the riscv_isa_string fix I noticed it was still in the tag blurb for the series. I don't think it is worth re-tagging the PR to add a note that we dropped the change from the series. These are pretty

[Qemu-devel] Monitor and serial output window broken with SDL2

Hello, With SDL2 the monitor and serial output windows behave differently than they used to with SDL1.2 in that they are opening in separate windows. This is an unexpected change we've discussed before but other than this there are actual bugs with SDL2: 1. Scrollback does not work. With

[Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) are available in the git repository at: https://github.com/riscv/riscv-qemu.git

Re: [Qemu-devel] [PATCH 3/5] ide: do not set s->end_transfer_func to ide_transfer_cancel

On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > There is code checking s->end_transfer_func and it was not taught > about ide_transfer_cancel. We can just use ide_transfer_stop because > s->end_transfer_func is only ever called in the DRQ phase: after > ide_transfer_cancel, the value of

Re: [Qemu-devel] [PATCH 2/5] ide: push end_transfer callback to ide_transfer_halt

On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > The callback must be invoked once we get out of the DRQ phase; because > all end_transfer_funcs end up invoking ide_transfer_stop, call it there. > While at it, remove the "notify" argument from ide_transfer_halt; the > code can simply be moved to

Re: [Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > Split the PIO transfer across two callbacks, thus pushing the (possibly > recursive) call to end_transfer_func up one level and out of the > AHCI-specific code. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/ahci.c

Re: [Qemu-devel] [patches] Re: [PATCH v4 26/26] RISC-V: Fix riscv_isa_string memory size bug

On Tue, Mar 20, 2018 at 1:51 PM, Philippe Mathieu-Daudé wrote: > Le mar. 20 mars 2018 12:52, Peter Maydell a > écrit : > >> On 19 March 2018 at 21:18, Michael Clark wrote: >> > This version uses a constant size memory buffer sized for

[Qemu-devel] [PATCH v4 2/3] linux-headers: add unistd.h on all arches

This adds unistd.h on ARM64 and MIPS and their dependencies. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-arm/bitsperlong.h | 1 + linux-headers/asm-arm64/bitsperlong.h | 24 + linux-headers/asm-generic/bitsperlong.h | 16 +

[Qemu-devel] [PATCH v4 0/3] linux-headers: arch fixups

It turns out that we have unistd.h and kvm headers for some architectures but not others. We are thus unable to use e.g. usefaultfd on these systems unless system headers have been updated. Fix up update-linux-headers.sh to make sure we auto-updates all architectures which have linux-headers/

[Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: add unistd.h and kvm on MIPS

Rework the update script slightly, add the unistd.h header and its dependencies on all architectures. This also removes the IA64 and MIPS from a KVM blacklist: Linux dropped IA64, and there was never a reason to exclude MIPS from kvm specifically - it was excluded due to dependency of its

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 08/22] target/arm: Support multiple EL change hooks

Le 20 mars 2018 9:45 PM, "Aaron Lindsay" a écrit : On Mar 18 23:41, Philippe Mathieu-Daudé wrote: > On 03/16/2018 09:31 PM, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/cpu.c | 15 ++- > >

[Qemu-devel] [PATCH v4 3/3] linux-headers: add kvm header for mips

kvm header for MIPS was manually excluded from auto-updates. Update it now to 4.16-rc5. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-mips/kvm.h | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 4/4] tpm: CRB: query backend for TPM established flag

Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c index e8c42f6..ef8b80e 100644 --- a/hw/tpm/tpm_crb.c +++ b/hw/tpm/tpm_crb.c @@ -84,6 +84,12 @@ static uint64_t

[Qemu-devel] [PATCH v2 3/4] tpm: CRB: reset locAssigned upon relinquishing locality

Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c index 4bd76b5..e8c42f6 100644 --- a/hw/tpm/tpm_crb.c +++ b/hw/tpm/tpm_crb.c @@ -137,6 +137,8 @@ static void

[Qemu-devel] [PATCH v2 0/4] tpm: Fix initialization of a few flags of CRB interface

Fix the initialization of a few flags of the CRB interface. I tested the changes with UEFI and it works fine. SeaBIOS needs to have the latest patches applied. Stefan Stefan Berger (4): tpm: CRB: Set tpmRegValidSts flag to '1' in device reset tpm: CRB: set registers to 0 by default tpm:

[Qemu-devel] [PATCH v2 2/4] tpm: CRB: set registers to 0 by default

Initialize all registers of the CRB device to 0. This clears a few flags upon a reset. Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c index 114b66e..4bd76b5 100644 ---

[Qemu-devel] [PATCH v2 1/4] tpm: CRB: Set tpmRegValidSts flag to '1' in device reset

Fix the initialization of the tpmRegValidSts flag and set it to '1' during device reset without expecting a write to another register. This seems to also be the default behavior of real hardware. Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH v4 26/26] RISC-V: Fix riscv_isa_string memory size bug

Le mar. 20 mars 2018 12:52, Peter Maydell a écrit : > On 19 March 2018 at 21:18, Michael Clark wrote: > > This version uses a constant size memory buffer sized for > > the maximum possible ISA string length. It also uses g_new > > instead of g_new0,

Re: [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error *

Le 20 mars 2018 4:14 PM, "Paolo Bonzini" a écrit : Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err was unused, and this made the static analyzer unhappy Oops, thanks Paolo! Signed-off-by: Paolo Bonzini --- hw/sd/sdhci.c |

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 08/22] target/arm: Support multiple EL change hooks

On Mar 18 23:41, Philippe Mathieu-Daudé wrote: > On 03/16/2018 09:31 PM, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/cpu.c | 15 ++- > > target/arm/cpu.h | 23 --- > > target/arm/internals.h |

[Qemu-devel] [PULL 1/1] linux-user: init_guest_space: Try to make ARM space+commpage continuous

From: Luke Shumaker At a fixed distance after the usable memory that init_guest_space maps, for 32-bit ARM targets we also need to map a commpage. The normal init_guest_space logic doesn't keep this in mind when searching for an address range. If !host_start, then try to

[Qemu-devel] [PULL 0/1] Linux user for 2.12 patches

The following changes since commit 036793aebfc1dd0ce124fa278d7668d89b5da936: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-03-20 12:56:20 +) are available in the Git repository at: git://github.com/vivier/qemu.git

[Qemu-devel] [ANNOUNCE] QEMU 2.12.0-rc0 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.12 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.12.0-rc0.tar.xz

Re: [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1521556695-35907-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PATCH v4 2/5] target/i386: Populate AMD Processor Cache Information

> -Original Message- > From: Eduardo Habkost > Sent: Tuesday, March 20, 2018 12:54 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com; > Lendacky, Thomas ; Singh, Brijesh >

[Qemu-devel] [PATCH] hw/rdma: Implementation of Query QP command

Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 12 hw/rdma/rdma_backend.h | 2 ++ hw/rdma/rdma_rm.c| 18 ++ hw/rdma/rdma_rm.h| 3 +++ hw/rdma/vmw/pvrdma_cmd.c | 24 +++- 5 files changed, 58

Re: [Qemu-devel] [PULL 0/2] hmp queue

motes/ericb/tags/pull-qapi-2018-03-12-v4' > into staging (2018-03-20 09:51:49 +) > > are available in the Git repository at: > > git://github.com/dagrh/qemu.git tags/pull-hmp-20180320 > > for you to fetch changes up to 95372184b7acdfd82ee748b6f0c6df1d839

[Qemu-devel] [PATCH v1 2/2] hw/rdma: Add support for Query QP verb to pvrdma device

This IB verb is needed by some applications - implement it. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index

[Qemu-devel] [PATCH v1 1/2] hw/rdma: Add Query QP operation

This operation is needed by rdma devices - implement it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 12 hw/rdma/rdma_backend.h | 2 ++ hw/rdma/rdma_rm.c | 18 ++ hw/rdma/rdma_rm.h | 3 +++ 4 files changed, 35

[Qemu-devel] ihw/rdma: Implementation of Query QP verb

Please review implementation of Query QP verb which is needed by some RDMA applications. Patch #1: Implementation in rdma backend layer Patch #2: Add support to pvrdma device v0 -> v1: * Split to two patches, one for rdma and one for pvrdma [PATCH v1 1/2] hw/rdma: Add Query QP operation

Re: [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make ARM space+commpage continuous

On 20 March 2018 at 18:49, Luke Shumaker wrote: > On Fri, 02 Mar 2018 09:13:12 -0500, > Peter Maydell wrote: >> On 28 December 2017 at 18:08, Luke Shumaker wrote: >> > +guest_full_size = >> > +(0x0f00 & qemu_host_page_mask) +

Re: [Qemu-devel] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/213 | 349 + tests/qemu-iotests/213.out | 121 tests/qemu-iotests/group | 1 + 3 files changed, 471

Re: [Qemu-devel] [PATCH v3] os: truncate pidfile on creation

On 03/20/2018 01:11 PM, Florian Larysch wrote: On Tue, Mar 20, 2018 at 01:00:40PM -0500, Eric Blake wrote: Here after the --- is a nice place to summarize how v3 differs from v2, to save reviewers some time. The triviality of the change didn't seem to warrant that, but in retrospect, I

Re: [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make ARM space+commpage continuous

Le 20/03/2018 à 19:49, Luke Shumaker a écrit : > On Fri, 02 Mar 2018 09:13:12 -0500, > Peter Maydell wrote: >> On 28 December 2017 at 18:08, Luke Shumaker wrote: >>> +guest_full_size = >>> +(0x0f00 & qemu_host_page_mask) + qemu_host_page_size; >

Re: [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make ARM space+commpage continuous

On Fri, 02 Mar 2018 09:13:12 -0500, Peter Maydell wrote: > On 28 December 2017 at 18:08, Luke Shumaker wrote: > > +guest_full_size = > > +(0x0f00 & qemu_host_page_mask) + qemu_host_page_size; ^ > I think this is probably more

Re: [Qemu-devel] [PATCH for-2.12 11/12] vhdx: Check for 4 GB maximum log size on creation

On 03/20/2018 12:36 PM, Kevin Wolf wrote: It's unclear what the real maximum is, but we use an uint32_t to store the log size in vhdx_co_create(), so we should check that the given value fits in 32 bits. Signed-off-by: Kevin Wolf --- block/vhdx.c | 4 1 file changed,

Re: [Qemu-devel] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno

On 03/20/2018 12:36 PM, Kevin Wolf wrote: error_setg_errno() is meant for cases where we got an errno from the OS that can add useful extra information to an error message. It's pointless if we pass a constant errno, these cases should use plain error_setg(). Well, it DOES let you get the

Re: [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Images with a non-power-of-two block size are invalid and cannot be opened. Reject such block sizes when creating an image. Signed-off-by: Kevin Wolf --- block/vhdx.c | 4 1 file changed, 4 insertions(+) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/212 | 326 + tests/qemu-iotests/212.out | 111 +++ tests/qemu-iotests/group | 1 + 3 files changed, 438 insertions(+)

Re: [Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create

On 03/20/2018 12:36 PM, Kevin Wolf wrote: It's unclear what the real maximum cluster size is for the Parallels format, but let's at least make sure that we don't get integer overflows in our .bdrv_co_create implementation. Signed-off-by: Kevin Wolf --- block/parallels.c | 5

Re: [Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks

On 03/20/2018 12:36 PM, Kevin Wolf wrote: This tests that the .bdrv_truncate implementation for luks doesn't crash for invalid image sizes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/210 | 37 + 1 file changed, 37 insertions(+)

Re: [Qemu-devel] [PATCH v3 1/2] i386/kvm: add support for Hyper-V reenlightenment MSRs

On Tue, Mar 20, 2018 at 06:34:59PM +0100, Vitaly Kuznetsov wrote: > KVM recently gained support for Hyper-V Reenlightenment MSRs which are > required to make KVM-on-Hyper-V enable TSC page clocksource to its guests > when INVTSC is not passed to it (and it is not passed by default in Qemu > as it

[Qemu-devel] [Bug 1740219] Re: static linux-user ARM emulation has several-second startup time

Everything except for the final patch (which has the actual fix) is now applied on the master branch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1740219 Title: static linux-user ARM emulation

Re: [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Commit e39e959e fixed an invalid assertion in the .bdrv_length implementation, but left a similar assertion in place for .bdrv_truncate. Instead of crashing when the user requests a too large image size, fail gracefully. A file size of exactly INT64_MAX

Re: [Qemu-devel] [PATCH for-2.12 04/12] qemu-iotests: Enable 025 for luks

On 03/20/2018 12:36 PM, Kevin Wolf wrote: We want to test resizing even for luks. The only change that is needed is to explicitly zero out new space for luks because it's undefined. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/025 | 9 - 1 file changed, 8

Re: [Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/211 | 256 + tests/qemu-iotests/211.out | 98 + tests/qemu-iotests/group | 1 + 3 files changed, 355

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

Lidong Chen wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen Reviewed-by: Juan

Re: [Qemu-devel] [PATCH for-2.12 02/12] vdi: Fix build with CONFIG_VDI_DEBUG

On 03/20/2018 12:36 PM, Kevin Wolf wrote: Use qemu_uuid_unparse() instead of uuid_unparse() to make vdi.c compile again when CONFIG_VDI_DEBUG is set. In order to prevent future bitrot, replace '#ifdef CONFIG_VDI_DEBUG' by 'if (VDI_DEBUG)' so that the compiler always sees the code.

Re: [Qemu-devel] [PATCH v2 1/2] i386/kvm: add support for Hyper-V reenlightenment MSRs

On Mon, Mar 19, 2018 at 06:29:08PM +0100, Vitaly Kuznetsov wrote: > Roman Kagan writes: > > > On Fri, Mar 16, 2018 at 06:00:19PM +0100, Vitaly Kuznetsov wrote: > >> KVM recently gained support for Hyper-V Reenlightenment MSRs which are > >> required to make KVM-on-Hyper-V

Re: [Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups

On 20 March 2018 at 18:05, Michael S. Tsirkin wrote: > Cc MIPS maintainers. > Can we drop the MIPS blacklist for kvm? > Could you guys pls check? My guess is that MIPS got blacklisted in 1842bdfdbac2ec4 because Marc-André didn't want to deal with the fact that the mips unistd.h

Re: [Qemu-devel] [PATCH v3] os: truncate pidfile on creation

On Tue, Mar 20, 2018 at 01:00:40PM -0500, Eric Blake wrote: > Here after the --- is a nice place to summarize how v3 differs from > v2, to save reviewers some time. The triviality of the change didn't seem to warrant that, but in retrospect, I realize that searching for the sole trivial change

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

On Mon, Mar 19, 2018 at 9:43 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 03/20/2018 02:35 AM, Michael Clark wrote: > > FYI - I also have an experimental branch containing a RISC-V TCG back-end > > that I started on during the RISC-V Hackathon in Portland last week: > > > > -

Re: [Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups

Cc MIPS maintainers. Can we drop the MIPS blacklist for kvm? Could you guys pls check? On Tue, Mar 20, 2018 at 07:52:51PM +0200, Michael S. Tsirkin wrote: > It turns out that we have unistd.h for some architectures but not > others. We are thus unable to use e.g. usefaultfd on these systems. >

Re: [Qemu-devel] [PATCH for-2.12 01/12] vdi: Change 'static' create option to 'preallocation' in QMP

On 03/20/2018 12:36 PM, Kevin Wolf wrote: What static=on really does is what we call metadata preallocation for other block drivers. While we can still change the QMP interface, make it more consistent by using 'preallocation' for VDI, too. The x- naming of the command means we don't HAVE to

Re: [Qemu-devel] [PULL v3 00/51] virtio, vhost, pci, pc: features, cleanups

On 20 March 2018 at 14:42, Michael S. Tsirkin wrote: > Note: only patch 39/51 is attached. > The rest are unchanged from v2. > > The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d: > > Merge remote-tracking branch >

Re: [Qemu-devel] [PATCH v2 1/3] update-linux-headers.sh: add unistd.h

On 20/03/2018 18:29, Michael S. Tsirkin wrote: >> For MIPS, KVM is supposed to be properly supported these days, right? >> That sounds like we should not be blacklisting them either, but instead >> sorting out whatever issues it was that made us exclude them. > > I agree but I'd rather someone

Re: [Qemu-devel] [PATCH 4/5] migration/block: limit the number of parallel I/O requests

Peter Lieven wrote: > the current implementation submits up to 512 I/O requests in parallel > which is much to high especially for a background task. > This patch adds a maximum limit of 16 I/O requests that can > be submitted in parallel to avoid monopolizing the I/O device. > >

Re: [Qemu-devel] [PATCH 5/5] migration/block: compare only read blocks against the rate limiter

Peter Lieven wrote: > only read_done blocks are in the queued to be flushed to the migration > stream. submitted blocks are still in flight. > > Signed-off-by: Peter Lieven Reviewed-by: Juan Quintela > --- > migration/block.c | 3 +-- > 1

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

On 03/15/2018 07:24 PM, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c |

Re: [Qemu-devel] [PATCH v3] os: truncate pidfile on creation

On 03/20/2018 12:33 PM, Florian Larysch wrote: qemu_create_pidfile does not truncate the pidfile when it creates it, but rather overwrites its contents with the new pid. This works fine as long as the length of the pid doesn't decrease, but this might happen in case of wraparounds, causing

Re: [Qemu-devel] [PATCH v4 2/5] target/i386: Populate AMD Processor Cache Information

On Tue, Mar 20, 2018 at 05:25:52PM +, Moger, Babu wrote: > Hi Eduardo, Thanks for the comments. Please see the response inline. > > > -Original Message- > > From: Eduardo Habkost > > Sent: Friday, March 16, 2018 1:00 PM > > To: Moger, Babu >

Re: [Qemu-devel] [PATCH v2 3/3] postcopy: drop unnecessary conditions

On Tue, Mar 20, 2018 at 07:17:35PM +0200, Michael S. Tsirkin wrote: > We have our own copy of unistd so there is no > need to check for symbols present there. > > Signed-off-by: Michael S. Tsirkin Self-Nack pls ignore - we do not have unistd.h on all systems unfortunately.

Re: [Qemu-devel] [PATCH for-2.12] qcow2: Reset free_cluster_index when allocating a new refcount block

On 03/20/2018 08:55 AM, Alberto Garcia wrote: When we try to allocate new clusters we first look for available ones starting from s->free_cluster_index and once we find them we increase their reference counts. Before we get to call update_refcount() to do this last step s->free_cluster_index is

[Qemu-devel] [PATCH v3 2/2] linux-headers: add asm-generic/unistd.h

ARM64 and MIPS depend on asm-generic/unistd.h for syscall numbers. This adds asm-generic/unistd.h and it's dependencies. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-arm/bitsperlong.h | 1 + linux-headers/asm-arm64/bitsperlong.h | 24 +

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

On 19/03/2018 20:06, Jeff Cody wrote: > On Mon, Mar 19, 2018 at 01:19:36PM +, Peter Maydell wrote: >> On 21 February 2018 at 05:27, Jeff Cody wrote: >>> On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: I just noticed that we seem to have acquired another

[Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups

It turns out that we have unistd.h for some architectures but not others. We are thus unable to use e.g. usefaultfd on these systems. Fix up update-linux-headers.sh to make sure we get it for all architectures which have linux-headers/ (unfortunately this still does not mean "all linux

[Qemu-devel] [PATCH v3 1/2] update-linux-headers.sh: add unistd.h

Rework the update script slightly, add the unistd.h header and its dependencies on all architectures. This also removes the IA64 from a KVM blacklist (Linux dropped this architecture for KVM), and adds a comment so we remember to try and un-blacklist KVM on MIPS. Signed-off-by: Michael S.

[Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/212 | 326 + tests/qemu-iotests/212.out | 111 +++ tests/qemu-iotests/group | 1 + 3 files changed, 438 insertions(+) create mode 100755 tests/qemu-iotests/212

[Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create

Images with a non-power-of-two block size are invalid and cannot be opened. Reject such block sizes when creating an image. Signed-off-by: Kevin Wolf --- block/vhdx.c | 4 1 file changed, 4 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index

Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""

On Tue, Mar 20, 2018 at 05:34:01PM +, Daniel P. Berrangé wrote: > On Tue, Mar 20, 2018 at 07:10:42PM +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 20, 2018 at 05:33:42PM +0100, Stefan Weil wrote: > > > Using <> for system include files and "" for local include files is a > > > convention,

[Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks

This tests that the .bdrv_truncate implementation for luks doesn't crash for invalid image sizes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/210 | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/qemu-iotests/210

[Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/211 | 256 + tests/qemu-iotests/211.out | 98 + tests/qemu-iotests/group | 1 + 3 files changed, 355 insertions(+) create mode 100755 tests/qemu-iotests/211

Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""

On Tue, Mar 20, 2018 at 05:33:42PM +0100, Stefan Weil wrote: > > Very large projects often split in sub projects, maybe one of them > describing the API. Then that API headers are similar to system headers > and can be included using <>, although they still belong to the same > larger project. Do

[Qemu-devel] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno

error_setg_errno() is meant for cases where we got an errno from the OS that can add useful extra information to an error message. It's pointless if we pass a constant errno, these cases should use plain error_setg(). Signed-off-by: Kevin Wolf --- block/vhdx.c | 9 - 1

[Qemu-devel] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/213 | 349 + tests/qemu-iotests/213.out | 121 tests/qemu-iotests/group | 1 + 3 files changed, 471 insertions(+) create mode 100755 tests/qemu-iotests/213

[Qemu-devel] [PATCH for-2.12 00/12] block: Follow-up for .bdrv_co_create (part 1)

This series adds qemu-iotests for a few more block drivers (yet more to come in another series) and fixes a few things that previous review and these tests brought up. The only major design change is that I converted the vdi block driver from a boolean 'static' create option to the standard

[Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create

It's unclear what the real maximum cluster size is for the Parallels format, but let's at least make sure that we don't get integer overflows in our .bdrv_co_create implementation. Signed-off-by: Kevin Wolf --- block/parallels.c | 5 + 1 file changed, 5 insertions(+) diff

  1   2   3   >