Re: [Qemu-devel] qemu-io read do not dump buffer when in quiet mode

2018-04-20 Thread Junpeng . Li
Eric Blake writes: > On 04/20/2018 11:14 AM, Junpeng.Li wrote: >> >> Hi, everyone. I found a question or maybe a bug during use qemu-io to read >> a range file and take the params -vq to dump buffer and do not show >> I/O statistics. I use the params -vq what i want is just

Re: [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Following commit 12051d82f004024, UART devices should handle > being passed a NULL pointer chardev, so we don't need to > create "null" backends in board code. Remove the code that > does this and updates serial_hds[]. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] qga/schema: fix documentation for GuestOSInfo

2018-04-20 Thread Marc-André Lureau
On Fri, Apr 20, 2018 at 8:12 PM, Tomáš Golembiovský wrote: > The documentation for kernel-version and kernel-release on Windows was > swapped. > > Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH] qemu-ga: make get-fsinfo work over pci bridges

2018-04-20 Thread Laszlo Ersek
Hi Marc-André, On 04/20/18 17:25, Marc-André Lureau wrote: > Iterate over the PCI bridges to lookup the PCI device associated with > the block device. > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1567041 > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-20 Thread Laszlo Ersek
On 04/20/18 18:37, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 04/20/18 14:53, Markus Armbruster wrote: >>> Laszlo Ersek writes: >> >> [snip] >> The targets with softmmu are: aarch64, alpha, arm, cris, hppa, i386, lm32, m68k,

[Qemu-devel] [qemu RFC v3 1/3] qapi: add SysEmuTarget to "common.json"

2018-04-20 Thread Laszlo Ersek
We'll soon need an enumeration type that lists all the softmmu targets that QEMU (the project) supports. Introduce @SysEmuTarget to "common.json". Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann

[Qemu-devel] [qemu RFC v3 2/3] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

2018-04-20 Thread Laszlo Ersek
Now that we have @SysEmuTarget, it makes sense to restict @TargetInfo.@arch to valid sysemu targets at the schema level. Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Kashyap

[Qemu-devel] [qemu RFC v3 3/3] qapi: add "firmware.json"

2018-04-20 Thread Laszlo Ersek
Add a schema that describes the different uses and properties of virtual machine firmware. Each firmware executable installed on a host system should come with at least one JSON file that conforms to this schema. Each file informs the management applications about - the firmware's properties and

[Qemu-devel] [qemu RFC v3 0/3] qapi: add "firmware.json"

2018-04-20 Thread Laszlo Ersek
This version seeks to address the RFCv2 feedback. Changes are noted per patch. Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Kashyap Chamarthy Cc: Markus

[Qemu-devel] [PATCH] qemu-img: Check post-truncation size

2018-04-20 Thread Max Reitz
Some block drivers (iscsi and file-posix when dealing with device files) do not actually support truncation, even though they provide a .bdrv_truncate() method and will happily return success when providing a new size that does not exceed the current size. This is because these drivers expect the

[Qemu-devel] [PATCH 2/3] block/file-posix: File locking during creation

2018-04-20 Thread Max Reitz
When creating a file, we should take the WRITE and RESIZE permissions. We do not need either for the creation itself, but we do need them for clearing and resizing it. So we can take the proper permissions by replacing O_TRUNC with an explicit truncation to 0, and by taking the appropriate file

[Qemu-devel] [PATCH 0/3] block/file-posix: File locking during creation

2018-04-20 Thread Max Reitz
Currently we do not take permissions on a file while it is being created. That is a bit sad. The simplest way to test this is the following: $ qemu-img create -f qcow2 foo.qcow2 64M Formatting 'foo.qcow2', fmt=qcow2 size=67108864 cluster_size=65536 lazy_refcounts=off refcount_bits=16

[Qemu-devel] [PATCH 3/3] iotests: Add creation test to 153

2018-04-20 Thread Max Reitz
This patch adds a test case to 153 which tries to overwrite an image (using qemu-img create) while it is in use. Without the original user explicitly sharing the necessary permissions (writing and truncation), this should not be allowed. Signed-off-by: Max Reitz ---

[Qemu-devel] [PATCH 1/3] block/file-posix: Pass FD to locking helpers

2018-04-20 Thread Max Reitz
raw_apply_lock_bytes() and raw_check_lock_bytes() currently take a BDRVRawState *, but they only use the lock_fd field. During image creation, we do not have a BDRVRawState, but we do have an FD; so if we want to reuse the functions there, we should modify them to receive only the FD.

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-20 Thread Richard Henderson
On 04/19/2018 08:42 PM, Alex Bennée wrote: >> It seems I can't even build fp-test for x86_64. >> >> CROSS-BUILD x86_64 guest-tests with cc >> In file included from /home/rth/work/qemu/qemu/tests/fp/fp-test.c:14:0: >> /home/rth/work/qemu/qemu/include/qemu/osdep.h:30:10: fatal error: >>

Re: [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and remove softmmu_template

2018-04-20 Thread Richard Henderson
On 04/20/2018 05:50 AM, Alex Bennée wrote: > +tcg_target_ulong __attribute__((flatten)) helper_le_ldq_mmu(CPUArchState > *env, > +target_ulong > addr, > +TCGMemOpIdx oi, > +

Re: [Qemu-devel] [PATCH v2 26/43] tests/tcg/arm: fix up test-arm-iwmmxt test

2018-04-20 Thread Richard Henderson
On 04/19/2018 10:18 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 04/19/2018 03:58 AM, Alex Bennée wrote: >>> +test-arm-iwmmxt: CFLAGS+=-marm -march=iwmmxt -mabi=aapcs >>> +test-arm-iwmmxt: test-arm-iwmmxt.S >> >> This appears to be insufficient. >>

[Qemu-devel] [PATCH] ccid: Fix dwProtocols advertisement of T=0

2018-04-20 Thread Jason Andryuk
Commit d7d218ef02d87c637d20d64da8f575d434ff6f78 attempted to change dwProtocols to only advertise support for T=0 and not T=1. The change was incorrect as it changed 0x0003 to 0x0001. lsusb -v in a linux guest shows: "dwProtocols 65536 (Invalid values detected)", though the

Re: [Qemu-devel] [RFC 20/24] avocado_qemu: Set QMP log level to INFO

2018-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2018 at 03:19:47PM -0300, Eduardo Habkost wrote: > From: Amador Pahim > > Otherwise we will see the debug messages in our test logs. Why don't we want to see the QMP debug messages when debugging is enabled? > > Signed-off-by: Amador Pahim

Re: [Qemu-devel] [RFC 01/24] qemu.py: Introduce _create_console() method

2018-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2018 at 03:19:28PM -0300, Eduardo Habkost wrote: > From: Amador Pahim > > This patch adds the QEMUMachine._create_console() method, which > returns a list with the chardev console device arguments to be > used in the qemu command line. > > Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 16:11:35 -0300, Philippe Mathieu-Daudé wrote: > On 04/20/2018 03:35 PM, Emilio G. Cota wrote: > > I also changed the patches to make the series simpler: one patch > > to add softmmu.c (without compiling it yet), one patch to > > actually use softmmu.c, and a final patch to

Re: [Qemu-devel] [RFC 02/24] Introduce the basic framework to run Avocado tests

2018-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2018 at 03:19:29PM -0300, Eduardo Habkost wrote: > From: Amador Pahim > > Avocado Testing Framework can help with functional tests in > qemu development process. This patch creates the basic infrastructure > to use with Avocado tests. It contains: > > - A

Re: [Qemu-devel] [PATCH] migration: update docs

2018-04-20 Thread Eric Blake
On 04/20/2018 12:57 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Update the migration docs: > > Among other changes: > * Added a general list of advice for device authors > * Reordered the section on conditional state (subsections etc) >

Re: [Qemu-devel] [PATCH 14/18] target/openrisc: convert to DisasContextBase

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 03:55 PM, Emilio G. Cota wrote: > While at it, set is_jmp to DISAS_NORETURN when generating > an exception. > > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > Cc: Stafford Horne >

Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

2018-04-20 Thread Max Reitz
On 2018-04-06 17:17, Max Reitz wrote: > My non-Fedora testing system does not have a kernel with userfaultfd > support which causes 181 and 201 to fail. That is annoying. This > series makes those tests recognize the issue and convert it into a > _notrun. > > > Max Reitz (2): > iotests: Add

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: >> Any questions/thoughts/comments? > > Very nice! > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by having > foo __attribute__((flatten)) >

[Qemu-devel] [PATCH 11/18] target/s390x: convert to DisasJumpType

2018-04-20 Thread Emilio G. Cota
The only non-trivial modification is the use of DISAS_TOO_MANY in the same way is used by the generic translation loop. Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Cc: David Hildenbrand

[Qemu-devel] [PATCH 08/18] target/mips: convert to DisasContextBase

2018-04-20 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 346

[Qemu-devel] [PATCH 07/18] target/mips: convert to DisasJumpType

2018-04-20 Thread Emilio G. Cota
Notes: - BS_EXCP in generate_exception_err becomes DISAS_NORETURN, because we do not return after raising an exception. - Some uses of BS_EXCP are misleading in that they're used only as a "not BS_STOP" exit condition, i.e. they have nothing to do with an actual exception. For those cases,

[Qemu-devel] [PATCH 12/18] target/s390x: convert to DisasContextBase

2018-04-20 Thread Emilio G. Cota
Notes: - Did not convert {num,max}_insns and is_jmp, since the corresponding code will go away in the next patch. - Avoided a checkpatch error in use_exit_tb. - As suggested by David, (1) Drop ctx.pc and use ctx.base.pc_next instead, and (2) Rename ctx.next_pc to ctx.pc_tmp and add a

Re: [Qemu-devel] qemu-io read do not dump buffer when in quiet mode

2018-04-20 Thread Eric Blake
On 04/20/2018 11:14 AM, Junpeng.Li wrote: > > Hi, everyone. I found a question or maybe a bug during use qemu-io to read > a range file and take the params -vq to dump buffer and do not show > I/O statistics. I use the params -vq what i want is just dump buffer > but do not show I/O statistics,

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 03:35 PM, Emilio G. Cota wrote: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: >> Any questions/thoughts/comments? > > Very nice! Yep :) > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by having > foo

[Qemu-devel] [PATCH 17/18] target/riscv: convert to DisasContextBase

2018-04-20 Thread Emilio G. Cota
Notes: - Did not convert {num,max}_insns, since the corresponding code will go away in the next patch. - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_succ_insn. While at it, convert the remaining tb->cflags readers to tb_cflags(). Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 07:42:14 +0100, Alex Bennée wrote: > > Richard Henderson writes: (snip) > >> Finally the end of the series has me adding Emilio's fp-test to the > >> per-target builds. Unfortunately although some osdep.h and softfloat.c > >> fiddling allows

[Qemu-devel] [PATCH 16/18] target/riscv: convert to DisasJumpType

2018-04-20 Thread Emilio G. Cota
Reviewed-by: Bastian Koppelmann Reviewed-by: Richard Henderson Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann

[Qemu-devel] [PATCH 09/18] target/mips: use *ctx for DisasContext

2018-04-20 Thread Emilio G. Cota
No changes to the logic here; this is just to make the diff that follows easier to read. While at it, remove the unnecessary 'struct' in 'struct TranslationBlock'. Note that checkpatch complains with a false positive: ERROR: space prohibited after that '&' (ctx:WxW) #75: FILE:

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > So. AFAICT the estimate of page dirty rate is based on the assumption > that page dirties are independent of each other - one page is as > likely to be dirtied as any other. If we don't make that assumption, > I don't see how we can really

[Qemu-devel] [PATCH 15/18] target/openrisc: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Notes: - Changed the num_insns test in insn_start to check for dc->base.num_insns > 1, since when tb_start is first called in a TB, base.num_insns is already set to 1. - Removed DISAS_NEXT from the switch in tb_stop; use DISAS_TOO_MANY instead. - Added an assert_not_reached on tb_stop for

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 12:31:42 +1200, Michael Clark wrote: (snip) > In any case it seems we need some pretty major changes to translate.c > before we can make misa writable in qemu-riscv. Almost every gen routine > with the exception of RVI will need predication based on extensions. It > makes

[Qemu-devel] [PATCH 10/18] target/mips: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Notes: - DISAS_TOO_MANY replaces the former "break" in the translation loop. However, care must be taken not to overwrite a previous condition in is_jmp; that's why in translate_insn we first check is_jmp and return if it's != DISAS_NEXT. - Added an assert in translate_insn, before exiting

[Qemu-devel] [PATCH 18/18] target/riscv: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Emilio G. Cota ---

[Qemu-devel] [PATCH 13/18] target/s390x: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Note: I looked into dropping dc->do_debug. However, I don't see an easy way to do it given that TOO_MANY is also valid when we just translate more than max_insns. Thus, the check for do_debug in "case DISAS_PC_CC_UPDATED" would still need additional state to know whether or not we came from

[Qemu-devel] [PATCH 01/18] translator: merge max_insns into DisasContextBase

2018-04-20 Thread Emilio G. Cota
While at it, use int for both num_insns and max_insns to make sure we have same-type comparisons. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- accel/tcg/translator.c | 21 ++--- include/exec/translator.h |

[Qemu-devel] [PATCH 14/18] target/openrisc: convert to DisasContextBase

2018-04-20 Thread Emilio G. Cota
While at it, set is_jmp to DISAS_NORETURN when generating an exception. Reviewed-by: Richard Henderson Cc: Stafford Horne Signed-off-by: Emilio G. Cota --- target/openrisc/translate.c | 93

[Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP

2018-04-20 Thread Emilio G. Cota
The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena changes hflags, which ends up changing the TB flags via cpu_get_tb_cpu_state). This requires a full lookup (i.e. with flags) via lookup_and_goto_ptr instead of gen_goto_tb, since the latter only looks at the PC for in-page goto's. Fix it.

[Qemu-devel] [PATCH 02/18] target/sh4: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
This was fairly straightforward since it had already been converted to DisasContextBase; just had to add TARGET_TOO_MANY to the switch in tb_stop. Reviewed-by: Richard Henderson Cc: Aurelien Jarno Signed-off-by: Emilio G. Cota

[Qemu-devel] [PATCH 03/18] target/sparc: convert to DisasJumpType

2018-04-20 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota --- target/sparc/translate.c | 27 +++ 1 file changed, 15

[Qemu-devel] [PATCH 04/18] target/sparc: convert to DisasContextBase

2018-04-20 Thread Emilio G. Cota
Notes: - pc and npc are left unmodified, since they can point to out-of-TB jump targets. - Got rid of last_pc in gen_intermediate_code(), using base.pc_next instead. Only update pc_next (1) on a breakpoint (so that tb->size includes the insn), and (2) after reading the current instruction

[Qemu-devel] [PATCH 05/18] target/sparc: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Notes: - Moved the cross-page check from the end of translate_insn to init_disas_context. Reviewed-by: Richard Henderson Tested-by: Mark Cave-Ayland Cc: Mark Cave-Ayland Cc: Artyom Tarasenko

Re: [Qemu-devel] [PATCH] hw/arm/raspi: Don't bother setting default_cpu_type

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 12:55 PM, Peter Maydell wrote: > In commit 210f47840dd62, we changed the bcm2836 SoC object to > always create a CPU of the correct type for that SoC model. This > makes the default_cpu_type settings in the MachineClass structs > for the raspi2 and raspi3 boards redundant. We didn't

[Qemu-devel] [PATCH v3 00/18] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-20 Thread Emilio G. Cota
v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00837.html Changes from v2: - Rebase onto v2.12.0-rc4 - Add R-b's - mips: + Fix comment typo s/intetrupt/interrupt/ + Fixes suggested by Richard: - use lookup_and_goto_ptr for BS_STOP (add a separate patch for this) -

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Alex Bennée
Awesome, thanks! On Fri, 20 Apr 2018, 19:35 Emilio G. Cota, wrote: > On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: > > Any questions/thoughts/comments? > > Very nice! > > I modified the style a little bit, namely to pass checkpatch and to > improve grepability by

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 16:50:39 +0100, Alex Bennée wrote: > Any questions/thoughts/comments? Very nice! I modified the style a little bit, namely to pass checkpatch and to improve grepability by having foo __attribute__((flatten)) function(arg1, arg2, ...) as opposed to foo

[Qemu-devel] [RFC 23/24] avocado_qemu: Force vmimage distro

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Not all distros will support cloudinit. Let's use Fedora, which is proven to work. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/test_nec-usb-xhci.py | 2 +-

[Qemu-devel] [RFC 19/24] avocado_qemu: Clean unneeded 'pass'

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim The docstrings are enough. Let's remove the 'pass' instructions. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 6 -- 1 file changed, 6 deletions(-) diff

[Qemu-devel] [RFC 17/24] avocado_qemu: Remove duplicate PortTracker implementation

2018-04-20 Thread Eduardo Habkost
From: Cleber Rosa The PortTracker class was introduced on Avocado's own utility libraries, starting with version 54.0, and it actually received fixes after that. Let's avoid this duplicate implementation and rely on the standard one. Signed-off-by: Cleber Rosa

[Qemu-devel] [RFC 21/24] avocado_qemu: Introduce the add_image() VM API

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Uses can not add an image to the virtual machine with the option to configure the user/password using cloudinit. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/README.rst |

[Qemu-devel] [RFC 15/24] avocado_qemu: Functional test for RHBZ#1436616

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Fixed in commit 243afe858b95765b98d16a1f0dd50dca262858ad. According to the RHBZ1436616, the issue is: usb-storage device under pci-bridge is unusable after migration. Test consists in create a VM with an usb-storage device and check whether it's still

[Qemu-devel] [RFC 22/24] avocado_qemu: Tests fixes

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim - Using acell=KVM when we have a guest. - Better resilience for the cases where live-migration fails. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/test_nec-usb-xhci.py | 6 +-

[Qemu-devel] [RFC 10/24] avocado_qemu: Add support to request image for testing

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor Some of the tests require (usually bootable) image to be executed, let's add a helper function which uses the default params to define the image or provides useful default and explains what's going on in case the image is not available. Signed-off-by:

[Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431939

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim This issue was fixed in commit d81d857. According to the RHBZ1431939, the issue is 'host nodes' returning '128'. It should return empty value when using default policy or 0 when using bind policy. Test consists in inspect the result of the 'info memdev'

[Qemu-devel] [RFC 20/24] avocado_qemu: Set QMP log level to INFO

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Otherwise we will see the debug messages in our test logs. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [RFC 24/24] avocado_qemu: Add a few VNC related tests

2018-04-20 Thread Eduardo Habkost
From: Cleber Rosa These exercise the basics of firing up QEMU with and without a VNC device, and attempting to set the password when a VNC device and password is given (or not). Signed-off-by: Cleber Rosa Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 08/24] avocado_qemu: Provide defaults for user and pass

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor For conveniency let's set default user to root and password to 123456 to avoid the need to always input those. This password is inspired by the default password of JeOS available from avocado-vt. Signed-off-by: Lukáš Doktor

[Qemu-devel] [RFC 11/24] avocado_qemu: Fix exception name in caller

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim There's a exception name mismatch when callin `QEMUMigrationError`. Fixing. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 6 +++--- 1 file changed, 3

[Qemu-devel] [RFC 18/24] avocado_qemu: Simplify the installation instructions

2018-04-20 Thread Eduardo Habkost
From: Cleber Rosa Let's just give a single command line that can be reliably executed to install avocado and the dependencies we're aware for the existing tests. The installation approach chosen is the most universal one (pip) and one that impacts the least the developer's

[Qemu-devel] [RFC 14/24] avocado_qemu: Functional test for RHBZ#1447027

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Fixed in commit e85c0d1. According to the RHBZ1447027, the issue is: guest cannot boot with 240 or above vcpus when using ovmf. Test consists in set the VM with 240 vcpus and the OVMF device to then check whether the VM can be started. A parameters.yaml

[Qemu-devel] [RFC 07/24] avocado_qemu: Store "arch" in VM

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor The "arch" is quite important info regarding the current VM, let's store it so tests can query for it. Signed-off-by: Lukáš Doktor Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 1 + 1

[Qemu-devel] [RFC 16/24] avocado_qemu: Functional test for RHBZ1473203

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor Adds regresion test for RHBZ1473203 which runs VM with 16 numa nodes and then verifies memory allocation is accurate before and after hotplugging memory into default and 13th node. Signed-off-by: Lukáš Doktor Signed-off-by: Eduardo

[Qemu-devel] [RFC 09/24] avocado_qemu: Ignore kernel messages on get_console

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor The get_console (and _handle_prompt) uses the last non-empty line to check what is going on, but when debug is enabled, kernel produces lots of lines spoiling the output. Let's also ignore the messages that looks like kernel debugs ([ $float] $msg). This

[Qemu-devel] [RFC 06/24] avocado_qemu: Add " " after the default prompt regexp

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor The prompt regexp is quite basic one (# or $), let's require at least one additional space afterwards, which is the case in most modern systems and decreases the probability of false-positives. Signed-off-by: Lukáš Doktor

[Qemu-devel] [RFC 03/24] avocado_qemu: Improve handle_prompts to allow login after booted vm

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor When the VM is booted before calling "vm.get_console" this command fails to login as there is no new output in the console. Let's just press enter (which should be relatively harmless as login asks for the user again and when already logged in we might

[Qemu-devel] [RFC 05/24] avocado_qemu: Increase the login timeout to 60s

2018-04-20 Thread Eduardo Habkost
From: Lukáš Doktor The 10s login is quite short, let's use 60s and see whether it fits. Signed-off-by: Lukáš Doktor Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [RFC 04/24] avocado_qemu: Be lenient towards poluted serial console

2018-04-20 Thread Eduardo Habkost 
From: Lukáš Doktor 

The serial console is frequently spammed kernel messages, let's not be
so strict and match lines also containing other parts.

There is still possibility of failure in case kernel injects message on
a new line after the expected output producing

[Qemu-devel] [RFC 12/24] avocado_qemu: Improve migration error message

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim Expose the QMP result on migration error. Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/avocado_qemu/test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [RFC 02/24] Introduce the basic framework to run Avocado tests

2018-04-20 Thread Eduardo Habkost 
From: Amador Pahim 

Avocado Testing Framework can help with functional tests in
qemu development process. This patch creates the basic infrastructure
to use with Avocado tests. It contains:

- A README file with the initial documentation.
- The test module which inherits

[Qemu-devel] [RFC 01/24] qemu.py: Introduce _create_console() method

2018-04-20 Thread Eduardo Habkost
From: Amador Pahim This patch adds the QEMUMachine._create_console() method, which returns a list with the chardev console device arguments to be used in the qemu command line. Signed-off-by: Amador Pahim [ehabkost: reword commit message] Signed-off-by:

Re: [Qemu-devel] race between tb_gen_code() and qemu_ram_free()

2018-04-20 Thread Paolo Bonzini
On 20/04/2018 19:55, Peter Maydell wrote: > There seems to be a race between tb_gen_code() and qemu_ram_free(), > which results in an abort() in Edgar's test case that exercises the > xilinx-spips mmio-exec functionality. > > Here's what happens: > (1) memory_region_invalidate_mmio_ptr() is

[Qemu-devel] [RFC 00/24] Avocado-based functional tests

2018-04-20 Thread Eduardo Habkost
Background == A few months ago, Cleber started a thread[1] about the system for Avocado-based tests. He invited people to take a look at it, we got some interesting feedback. However, I saw no feedback on the actual code itself, and I don't know what needs to be done to get this merged.

[Qemu-devel] [PATCH] qga/schema: fix documentation for GuestOSInfo

2018-04-20 Thread Tomáš Golembiovský
The documentation for kernel-version and kernel-release on Windows was swapped. Signed-off-by: Tomáš Golembiovský --- qga/qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index

[Qemu-devel] [PATCH] migration: update docs

2018-04-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Update the migration docs: Among other changes: * Added a general list of advice for device authors * Reordered the section on conditional state (subsections etc) into the order we prefer. * Add a note about firmware Signed-off-by:

[Qemu-devel] race between tb_gen_code() and qemu_ram_free()

2018-04-20 Thread Peter Maydell
There seems to be a race between tb_gen_code() and qemu_ram_free(), which results in an abort() in Edgar's test case that exercises the xilinx-spips mmio-exec functionality. Here's what happens: (1) memory_region_invalidate_mmio_ptr() is called, and it deletes the temporary ram MemoryRegion.

Re: [Qemu-devel] [PATCH 11/13] superio: Don't use MAX_SERIAL_PORTS for serial port limit

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > The superio device has a limit on the number of serial > ports it supports which is really only there because > it has a fixed-size array serial[]. This limit isn't > related particularly to the global MAX_SERIAL_PORTS limit, > so use a different

Re: [Qemu-devel] [PATCH 12/13] vl.c: Remove compile time limit on number of serial ports

2018-04-20 Thread Paolo Bonzini
On 20/04/2018 19:06, Peter Maydell wrote: > On 20 April 2018 at 17:58, Paolo Bonzini wrote: >> On 20/04/2018 16:52, Peter Maydell wrote: >>> Instead of having a fixed sized global serial_hds[] array, >>> use a local dynamically reallocated one, so we don't have >>> a compile

[Qemu-devel] [Bug 1520730] Re: 32-bit editors vim/rhide broken keyboard handling in freedos 1.1 and ms-dos 6.22

2018-04-20 Thread Jason Wagner
I'm seeing this issue in version 2.12.0-rc4. I wasn't seeing this as much in earlier 2.11, but its a major pain in the current version. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1520730 Title:

Re: [Qemu-devel] [PATCH 13/13] vl.c: new function max_serial_hds()

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Create a new function max_serial_hds() which returns the number of > serial ports defined by the user. This is needed only by spapr. > This allows us to remove the MAX_SERIAL_PORTS define. > > Signed-off-by: Peter Maydell >

[Qemu-devel] [PATCH] test-qga: add trivial tests for some commands

2018-04-20 Thread Tomáš Golembiovský
These commands did not get their tests in the original commits: - guest-get-host-name - guest-get-timezone - guest-get-users Trivial tests that mostly only call the commands were added. Signed-off-by: Tomáš Golembiovský --- tests/test-qga.c | 54

Re: [Qemu-devel] [SPDK] qemu process hung at boot-up, no explicit errors or warnings

2018-04-20 Thread John Snow
On 04/20/2018 07:13 AM, Bob Chen wrote: > 2.11.1 could work, qemu is no longer occupying 100% CPU. That's > interesting... > Does 2.12 use 100% even at the firmware menu? Maybe we're not giving this VM long enough to hit the spot that causes it to use 100%. > Now I can see the starting screen

Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo

2018-04-20 Thread francisco iglesias
On 19 April 2018 at 08:27, Sai Pavan Boddu wrote: > SNOOP_NONE state handle is moved above in the if ladder, as it's same > as SNOOP_STRIPPING during data cycles. > > Signed-off-by: Sai Pavan Boddu > Reviewed-by: Francisco Iglesias

Re: [Qemu-devel] [RFC 0/2] block/file-posix: allow -drive cache.direct=off live migration

2018-04-20 Thread Eric Blake
On 04/19/2018 10:05 PM, Stefan Hajnoczi wrote: >>> This patch series implements .bdrv_co_invalidate_cache() for >>> block/file-posix.c >>> on Linux so that shared storage live migration works. I have sent it as an >>> RFC >>> because cache consistency is not binary, there are corner cases

Re: [Qemu-devel] [PATCH v3 1/3] qemu-thread: introduce qemu-thread-common.[ch]

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 12:42:10 +0800, Peter Xu wrote: > Put all the shared qemu-thread implementations into these files. The > header should be internal to qemu-thread but not for qemu-thread users. > > Introduce some hooks correspondingly for the shared part. Note that in >

Re: [Qemu-devel] [PATCH 12/13] vl.c: Remove compile time limit on number of serial ports

2018-04-20 Thread Peter Maydell
On 20 April 2018 at 17:58, Paolo Bonzini wrote: > On 20/04/2018 16:52, Peter Maydell wrote: >> Instead of having a fixed sized global serial_hds[] array, >> use a local dynamically reallocated one, so we don't have >> a compile time limit on how many serial ports a system

Re: [Qemu-devel] [PATCH 12/13] vl.c: Remove compile time limit on number of serial ports

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Instead of having a fixed sized global serial_hds[] array, > use a local dynamically reallocated one, so we don't have > a compile time limit on how many serial ports a system has. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [PATCH 12/13] vl.c: Remove compile time limit on number of serial ports

2018-04-20 Thread Paolo Bonzini
On 20/04/2018 16:52, Peter Maydell wrote: > Instead of having a fixed sized global serial_hds[] array, > use a local dynamically reallocated one, so we don't have > a compile time limit on how many serial ports a system has. > > Signed-off-by: Peter Maydell Just one

Re: [Qemu-devel] [PATCH 10/13] serial-isa: Use MAX_ISA_SERIAL_PORTS instead of MAX_SERIAL_PORTS

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > The ISA serial port handling in serial-isa.c imposes a limit > of 4 serial ports. This is because we only know of 4 IO port > and IRQ settings for them, and is unrelated to the generic > MAX_SERIAL_PORTS limit, though they happen to both be set at > 4

Re: [Qemu-devel] [PATCH v2 00/17] tcg: tb_lock_removal redux v2

2018-04-20 Thread Emilio G. Cota
On Fri, Apr 20, 2018 at 17:17:15 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > v1: http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg06499.html > > > > Changes since v1: > > > > > I was just catching up on reviews but there are a fair few conflicts in > the

Re: [Qemu-devel] [PATCH 02/13] hw/arm/fsl-imx*: Don't create "null" chardevs for serial devices

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Following commit 12051d82f004024, UART devices should handle > being passed a NULL pointer chardev, so we don't need to > create "null" backends in board code. Remove the code that > does this and updates serial_hds[]. > > (fsl-imx7.c was already

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-20 Thread Markus Armbruster
Laszlo Ersek writes: > On 04/20/18 14:53, Markus Armbruster wrote: >> Laszlo Ersek writes: > > [snip] > >>> The targets with softmmu are: aarch64, alpha, arm, cris, hppa, i386, >>> lm32, m68k, microblaze, microblazeel, mips, mips64, mips64el, mipsel, >>>

Re: [Qemu-devel] [PATCH 04/13] hw/mips/mips_malta: Don't create "null" chardevs for serial devices

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Following commit 12051d82f004024, UART devices should handle > being passed a NULL pointer chardev, so we don't need to > create "null" backends in board code. Remove the code that > does this and updates serial_hds[]. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Currently the serial.c realize code has an explicit check that it is not > connected to a disconnected backend (ie one with a NULL chardev). > This isn't what we want -- you should be able to create a serial device > even if it isn't attached to

  1   2   3   >