Re: [Qemu-devel] [PATCH v3 29/46] tests/tcg/aarch64: add fcvt test cases for AArch64

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/24/2018 12:23 PM, Alex Bennée wrote: > This runs through the usual float to float conversions and crucially > also runs with ARM Alternative Half Precision Format. > > Signed-off-by: Alex Bennée tested with "tests/tcg/aarch64/Makefile.include" containing:

[Qemu-devel] [PATCH v12 17/17] hw/arm/smmuv3: Add notifications on invalidation

2018-04-25 Thread Eric Auger
On TLB invalidation commands, let's call registered IOMMU notifiers. Those can only be UNMAP notifiers. SMMUv3 does not support notification on MAP (VFIO). This patch allows vhost use case where IOTLB API is notified on each guest IOTLB invalidation. Signed-off-by: Eric Auger

Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device

2018-04-25 Thread Eric Blake
On 04/25/2018 06:58 AM, Pankaj Gupta wrote: > > Hi, > > Compile failures are because Qemu 'Memory-Device changes' are not yet > in qemu master. As mentioned in Qemu patch message patch is > dependent on 'Memeory-device' patches by 'David Hildenbrand'. On 04/25/2018 06:24 AM, Pankaj Gupta

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

2018-04-25 Thread Dan Williams
On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM > guest. Minor nit, please expand your changelog line wrapping to 72 columns. > > Guest reads the persistent memory range > information from Qemu over VIRTIO and registers > it

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 03:49:38PM +0200, Igor Mammedov wrote: > On Tue, 24 Apr 2018 21:06:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > > > > -Original Message- > > > > From: Michael S.

[Qemu-devel] [PATCH v12 15/17] hw/arm/smmuv3: Cache/invalidate config data

2018-04-25 Thread Eric Auger
Let's cache config data to avoid fetching and parsing STE/CD structures on each translation. We invalidate them on data structure invalidation commands. Signed-off-by: Eric Auger --- v11 -> v12: - only insert the new config if decode_cfg succeeds - use smmu_get_sid for

Re: [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/25/2018 05:43 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 04/24/2018 12:23 PM, Alex Bennée wrote: >>> Nothing much here yet. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> tests/tcg/aarch64/Makefile.target | 5 + >>> 1 file

[Qemu-devel] [PATCH v12 13/17] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

2018-04-25 Thread Eric Auger
From: Prem Mallappa This patch builds the smmuv3 node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in smmuv3, which in turn maps to deviceid space 0x0-0x1 in the ITS group. The guest must

[Qemu-devel] [PATCH v12 14/17] hw/arm/virt: Introduce the iommu option

2018-04-25 Thread Eric Auger
ARM virt machine now exposes a new "iommu" option. The SMMUv3 IOMMU is instantiated using -machine virt,iommu=smmuv3. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa Reviewed-by: Peter Maydell --- v11 -> v12:

[Qemu-devel] [PATCH v12 07/17] hw/arm/smmuv3: Implement MMIO write operations

2018-04-25 Thread Eric Auger
Now we have relevant helpers for queue and irq management, let's implement MMIO write operations. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa Reviewed-by: Peter Maydell --- v11 -> v12: - s/value/data in

[Qemu-devel] [PATCH v12 11/17] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2018-04-25 Thread Eric Auger
In case the MSI is translated by an IOMMU we need to fixup the MSI route with the translated address. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- v11 -> v12: - fix rcu_read_lock and mr ref leaks - check mrs.mr v9 -> v10: - use

[Qemu-devel] [PATCH v12 09/17] hw/arm/smmuv3: Implement translate callback

2018-04-25 Thread Eric Auger
This patch implements the IOMMU Memory Region translate() callback. Most of the code relates to the translation configuration decoding and check (STE, CD). Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v11 -> v12: - check fixes in

[Qemu-devel] [PATCH v12 12/17] hw/arm/virt: Add SMMUv3 to the virt board

2018-04-25 Thread Eric Auger
From: Prem Mallappa Add code to instantiate an smmuv3 in virt machine. A new iommu integer member is introduced in VirtMachineState to store the type of the iommu in use. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v12 10/17] hw/arm/smmuv3: Abort on vfio or vhost case

2018-04-25 Thread Eric Auger
At the moment, the SMMUv3 does not support notification on TLB invalidation. So let's log an error as soon as such notifier gets enabled. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v11 -> v12: - Added Peter's R-b ---

[Qemu-devel] [PATCH v12 05/17] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-04-25 Thread Eric Auger
We introduce some helpers to handle wired IRQs and especially GERROR interrupt. SMMU writes GERROR register on GERROR event and SW acks GERROR interrupts by setting GERRORn. The Wired interrupts are edge sensitive hence the pulse usage. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v12 01/17] hw/arm/smmu-common: smmu base device and datatypes

2018-04-25 Thread Eric Auger
The patch introduces the smmu base device and class for the ARM smmu. Devices for specific versions will be derived from this base device. We also introduce some important datatypes. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa

[Qemu-devel] [PATCH v12 08/17] hw/arm/smmuv3: Event queue recording helper

2018-04-25 Thread Eric Auger
Let's introduce a helper function aiming at recording an event in the event queue. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v11 -> v12: - use do { ... } while (0) - check cmd parameter in smmu_event_string - camelcase struct

[Qemu-devel] [PATCH v12 06/17] hw/arm/smmuv3: Queue helpers

2018-04-25 Thread Eric Auger
We introduce helpers to read/write into the command and event circular queues. smmuv3_write_eventq and smmuv3_cmq_consume will become static in subsequent patches. Invalidation commands are not yet dealt with. We do not cache data that need to be invalidated. This will change with vhost

[Qemu-devel] [PATCH v12 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-04-25 Thread Eric Auger
This patch implements the page table walk for VMSAv8-64. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v11 -> v12: - typo fixes and added Peter's R-b - closer match with get_phys_addr_lpae() - take into account the input size when

[Qemu-devel] [PATCH v12 02/17] hw/arm/smmu-common: IOMMU memory region and address space setup

2018-04-25 Thread Eric Auger
We set up the infrastructure to enumerate all the PCI devices attached to the SMMU and create an associated IOMMU memory region and address space. Those info are stored in SMMUDevice objects. The devices are grouped according to the PCIBus they belong to. A hash table indexed by the PCIBus

[Qemu-devel] [PATCH v12 04/17] hw/arm/smmuv3: Skeleton

2018-04-25 Thread Eric Auger
From: Prem Mallappa This patch implements a skeleton for the smmuv3 device. Datatypes and register definitions are introduced. The MMIO region, the interrupts and the queue are initialized. Only the MMIO read operation is implemented here. Signed-off-by: Prem

[Qemu-devel] [PATCH v12 00/17] ARM SMMUv3 Emulation Support

2018-04-25 Thread Eric Auger
This series implements the emulation code for ARM SMMUv3. SMMUv3 gets instantiated by adding ",iommu=smmuv3" to the virt machine option. Only stage 1 and AArch64 PTW are supported. [1 - 14] bring the core emulation code. [15, 16] bring optimizations and 17 brings the vhost integration.

Re: [Qemu-devel] [PATCH v3 45/46] tests/Makefile.include: add [build|clean|check]-tcg targets

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/24/2018 08:13 PM, Philippe Mathieu-Daudé wrote: > On 04/24/2018 12:24 PM, Alex Bennée wrote: >> This will ensure all linux-user targets build their guest test >> programs and ensure check-tcg will run the respective tests. >> >> Signed-off-by: Alex Bennée >>

Re: [Qemu-devel] [PATCH v3 40/46] tests/tcg: enable building for sh4

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/24/2018 12:23 PM, Alex Bennée wrote: > As before, using Debian SID compilers. While the compiler can be > coerced into generating big-endian code it seems the linker can't deal > with it so we only enable the building for little endian SH4. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v3 38/46] tests/tcg: enable building for HPPA

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/24/2018 12:23 PM, Alex Bennée wrote: > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 1 + >

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

2018-04-25 Thread Gerd Hoffmann
Hi, > > We should make sure that any device model that combines ramfb with > > another PCI display device is not matched by the OVMF driver for that > > PCI display device. IOW, we should use separate PCI IDs or subsystem > > IDs (I don't recall the details off-hand). I'd like to avoid messing

Re: [Qemu-devel] [PATCH v3 25/46] tests/tcg/i386/test-i386: fix printf format

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/24/2018 12:23 PM, Alex Bennée wrote: > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/tcg/i386/test-i386.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-25 Thread Max Reitz
On 2018-04-25 15:42, Alberto Garcia wrote: > On Wed 25 Apr 2018 03:06:34 PM CEST, Max Reitz wrote: > One other way is to have a more generic replace-node command > which would call bdrv_replace_node(), but I don't know if we > want to expose that and I don't have any other

Re: [Qemu-devel] [PATCH v3 23/46] tests/tcg/x86_64: add Makefile.target

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/25/2018 05:43 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/24/2018 12:23 PM, Alex Bennée wrote: >>> The sources for x86_64 are shared in the i386 directory which will be >>> included thanks to TARGET_BASE_ARCH. However not all sources build so

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Thomas Huth
On 25.04.2018 14:31, Peter Maydell wrote: > On 25 April 2018 at 11:17, Thomas Huth wrote: >> On 25.04.2018 11:50, David Hildenbrand wrote: >>> On 25.04.2018 07:21, Thomas Huth wrote: The consoles ("sclpconsole" and "sclplmconsole") can only be configured with "-device"

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Thomas Huth
On 25.04.2018 07:21, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-25 Thread Pankaj Gupta
> > > > > > > > > >> + > > > > >> +memory_region_add_subregion(>mr, addr - hpms->base, mr); > > > > > missing vmstate registration? > > > > > > > > Missed this one: To be called by the caller. Important because e.g. for > > > > virtio-pmem we don't want this (I assume :) ). > > > if

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Igor Mammedov
On Wed, 25 Apr 2018 15:49:38 +0200 Igor Mammedov wrote: > On Tue, 24 Apr 2018 21:06:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > > > > -Original Message- > > > >

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Igor Mammedov
On Tue, 24 Apr 2018 21:06:37 +0300 "Michael S. Tsirkin" wrote: > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Tuesday, April 24, 2018 10:43 AM > >

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.12.0

2018-04-25 Thread Thomas Huth
On 25.04.2018 15:20, Paolo Bonzini wrote: > On 25/04/2018 05:45, Thomas Huth wrote: >> Based on the contents of Michael Roth's announce e-mail for 2.12.0. [...] > Go ahead and push it! Done. > Do you have time to write a blog post about -net, > -nic and all that? Likely not this week, but I've

Re: [Qemu-devel] [PATCH 6/6] qapi: discriminate CpuInfo[Fast] on SysEmuTarget, not CpuInfoArch

2018-04-25 Thread Laszlo Ersek
On 04/25/18 09:33, Markus Armbruster wrote: > Laszlo Ersek writes: [snip] >> +static CpuInfoArch sysemu_target_to_cpuinfo_arch(SysEmuTarget target) >> +{ >> +/* >> + * The @SysEmuTarget -> @CpuInfoArch mapping below is based on the >> + * TARGET_ARCH ->

[Qemu-devel] [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration

2018-04-25 Thread Igor Druzhinin
When global_log_dirty is enabled VRAM modification tracking never worked correctly. The address that is passed to xen_hvm_modified_memory() is not the effective PFN but RAM block address which is not the same for VRAM. We need to make a translation for this address into PFN using physmap. Since

Re: [Qemu-devel] [PATCH v3 16/46] tests/tcg: move i386 specific tests into subdir

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/25/2018 06:08 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 04/24/2018 12:23 PM, Alex Bennée wrote: >>> These only need to be built for i386 guests. This includes a stub >>> tests/tcg/i386/Makfile.target which absorbs some of what was in >>>

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-25 Thread Alberto Garcia
On Wed 25 Apr 2018 03:06:34 PM CEST, Max Reitz wrote: One other way is to have a more generic replace-node command which would call bdrv_replace_node(), but I don't know if we want to expose that and I don't have any other use case for it at the moment. >>>

Re: [Qemu-devel] [PATCH v2] linux-user: set minimum uname for RISC-V

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/25/2018 07:02 AM, Alex Bennée wrote: > As support for RISC-V was only merged into the mainline kernel at 4.15 > it is unlikely that glibc will be happy with a reported kernel version > of 3.8.0. Indeed when I testing binaries created by the current Debian > Sid compiler the tests failed

Re: [Qemu-devel] ridiculously slow VM memory performance on Ryzen CPU

2018-04-25 Thread Qu Wenruo
On 2018年04月25日 21:18, Daniel P. Berrangé wrote: > On Wed, Apr 25, 2018 at 05:48:42PM +0800, Qu Wenruo wrote: >> Hi, >> >> When testing IO heavy work on my VM backed by Ryzen 1700 CPU, I turned >> to brd modules, but surprisingly, the speed is even slower than some HDD: >> >> --- >> $ sudo

Re: [Qemu-devel] [PATCH] cpus: tcg: fix never exiting loop on unplug

2018-04-25 Thread Paolo Bonzini
On 25/04/2018 15:18, Cédric Le Goater wrote: > Commit 9b0605f9837b ("cpus: tcg: unregister thread with RCU, fix > exiting of loop on unplug") changed the exit condition of the loop in > the vCPU thread function but forgot to remove the beginning 'while (1)' > statement. The resulting code : > >

Re: [Qemu-devel] [Qemu-block] [PATCH] blockjob: drop block_job_pause/resume_all()

2018-04-25 Thread Alberto Garcia
On Tue 24 Apr 2018 10:52:40 AM CEST, Stefan Hajnoczi wrote: > Commit 8119334918e86f45877cfc139192d54f2449a239 ("block: Don't > block_job_pause_all() in bdrv_drain_all()") removed the only callers of > block_job_pause/resume_all(). > > Pausing and resuming now happens in

Re: [Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2018-04-25 Thread Shameerali Kolothum Thodi
Hi Drew, > -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Tuesday, April 24, 2018 4:30 PM > To: Shameerali Kolothum Thodi > Cc: peter.mayd...@linaro.org; qemu-devel@nongnu.org; Linuxarm > ;

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-25 Thread Igor Mammedov
On Wed, 25 Apr 2018 01:45:12 -0400 (EDT) Pankaj Gupta wrote: > > > > > > > > > >> +/* we will need a new memory slot for kvm and vhost */ > > > >> +if (kvm_enabled() && !kvm_has_free_slot(machine)) { > > > >> +error_setg(errp, "hypervisor has no free

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.12.0

2018-04-25 Thread Paolo Bonzini
On 25/04/2018 05:45, Thomas Huth wrote: > Based on the contents of Michael Roth's announce e-mail for 2.12.0. > > Signed-off-by: Thomas Huth > --- > _posts/2018-04-25-qemu-2-12-0.md | 58 > > 1 file changed, 58 insertions(+) > create

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

2018-04-25 Thread Laszlo Ersek
On 04/25/18 09:06, Markus Armbruster wrote: > Laszlo Ersek writes: > >> @CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, >> @thread-id, @props and @arch. From these, extract the first three to a >> common structure called @CpuInfoCommon. (More on @arch

[Qemu-devel] [PATCH] cpus: tcg: fix never exiting loop on unplug

2018-04-25 Thread Cédric Le Goater
Commit 9b0605f9837b ("cpus: tcg: unregister thread with RCU, fix exiting of loop on unplug") changed the exit condition of the loop in the vCPU thread function but forgot to remove the beginning 'while (1)' statement. The resulting code : while (1) { ... } while

Re: [Qemu-devel] ridiculously slow VM memory performance on Ryzen CPU

2018-04-25 Thread Daniel P . Berrangé
On Wed, Apr 25, 2018 at 05:48:42PM +0800, Qu Wenruo wrote: > Hi, > > When testing IO heavy work on my VM backed by Ryzen 1700 CPU, I turned > to brd modules, but surprisingly, the speed is even slower than some HDD: > > --- > $ sudo modprobe brd rd_nr=1 rd_size=1048576 > $ dd if=/dev/zero

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-25 Thread David Hildenbrand
>>> So this happens before any hotplug handler is called. Everything works >>> just fine. What you don't like about this is the qdev_get_machine(). I >>> also don't like it but in the short term I don't see any problem with >>> it. It is resource allocation and not a "device plug" in the typical

[Qemu-devel] ridiculously slow VM memory performance on Ryzen CPU

2018-04-25 Thread Qu Wenruo
Hi, When testing IO heavy work on my VM backed by Ryzen 1700 CPU, I turned to brd modules, but surprisingly, the speed is even slower than some HDD: --- $ sudo modprobe brd rd_nr=1 rd_size=1048576 $ dd if=/dev/zero of=/dev/ram0 bs=1M count=1024 1024+0 records in 1024+0 records out 1073741824

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread David Hildenbrand
>>> int ret; >>> @@ -346,6 +355,14 @@ static void ccw_init(MachineState *machine) >>> /* Create VirtIO network adapters */ >>> s390_create_virtio_net(BUS(css_bus), "virtio-net-ccw"); >>> >>> +/* init consoles */ >>> +if (serial_hds[0]) { >>> +

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-25 Thread Max Reitz
On 2018-04-25 14:58, Alberto Garcia wrote: > On Fri 20 Apr 2018 03:13:49 PM CEST, Max Reitz wrote: >>> One other way is to have a more generic replace-node command >>> which would call bdrv_replace_node(), but I don't know if we want >>> to expose that and I don't have any other use

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/6] rbd: Switch to byte-based callbacks

2018-04-25 Thread Eric Blake
On 04/24/2018 02:25 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based callbacks > in the rbd driver. > > Note that the driver was already using byte-based calls for > performing actual I/O, so

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-25 Thread Alberto Garcia
On Fri 20 Apr 2018 03:13:49 PM CEST, Max Reitz wrote: >> One other way is to have a more generic replace-node command >> which would call bdrv_replace_node(), but I don't know if we want >> to expose that and I don't have any other use case for it at the >> moment. > > I

Re: [Qemu-devel] [PATCH 4/4] audio/hda: detect output buffer overruns and underruns

2018-04-25 Thread Gerd Hoffmann
On Mon, Apr 23, 2018 at 11:31:34AM +0200, KONRAD Frederic wrote: > > > On 04/19/2018 03:10 PM, Gerd Hoffmann wrote: > > If some event caused some larger playback hickup the fine-grained timer > > adjust isn't able to recover. Use a buffer overruns and underruns as > > indicator for that. Reset

[Qemu-devel] [RFC PATCH 17/17] gdbstub: add reverse continue support in replay mode

2018-04-25 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were

Re: [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json"

2018-04-25 Thread Daniel P . Berrangé
On Tue, Apr 24, 2018 at 06:11:05PM -0500, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: > > We'll soon need an enumeration type that lists all the softmmu targets > > that QEMU (the project) supports. Introduce @SysEmuTarget to > > "common.json". > > > > Cc: "Daniel P. Berrange"

[Qemu-devel] [RFC PATCH 16/17] gdbstub: add reverse step support in replay mode

2018-04-25 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

Re: [Qemu-devel] [PATCH 4/6] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

2018-04-25 Thread Laszlo Ersek
On 04/25/18 08:48, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Now that we have @SysEmuTarget, it makes sense to restict >> @TargetInfo.@arch to valid sysemu targets at the schema level. >> >> Cc: "Daniel P. Berrange" >> Cc: David Gibson

Re: [Qemu-devel] [PATCH 00/10] intel-iommu: nested vIOMMU, cleanups, bug fixes

2018-04-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180425045129.17449-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH 00/10] intel-iommu: nested vIOMMU, cleanups, bug fixes === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [RFC PATCH 00/17] reverse debugging

2018-04-25 Thread Pavel Dovgalyuk
> From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > The patches are available in the repository: > https://github.com/ispras/qemu/tree/rr-180207 This should be https://github.com/ispras/qemu/tree/rr-180425 Pavel Dovgalyuk

[Qemu-devel] [RFC PATCH 10/17] replay: implement replay_seek command to proceed to the desired step

2018-04-25 Thread Pavel Dovgalyuk
This patch adds hmp/qmp command replay_seek which proceeds the execution to the specified step. It automatically loads nearest snapshot and replays the execution to find the desired step. Signed-off-by: Pavel Dovgalyuk --- hmp-commands.hx | 15

[Qemu-devel] [RFC PATCH 14/17] translator: fix breakpoint processing

2018-04-25 Thread Pavel Dovgalyuk
QEMU cannot pass through the breakpoints when 'si' command is used in remote gdb. This patch disables inserting the breakpoints when we are already single stepping though the gdb remote protocol. This patch also fixes icount calculation for the blocks that include breakpoints - instruction with

[Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command

2018-04-25 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the execution step (number or recorded/replayed instructions). Signed-off-by: Pavel Dovgalyuk ---

Re: [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json"

2018-04-25 Thread Eric Blake
On 04/24/2018 04:45 PM, Laszlo Ersek wrote: > We'll soon need an enumeration type that lists all the softmmu targets > that QEMU (the project) supports. Introduce @SysEmuTarget to > "common.json". > > Cc: "Daniel P. Berrange" > Cc: David Gibson > Cc:

[Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module

2018-04-25 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/replay/replay-time.c

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-25 Thread David Hildenbrand
For first phase we are using 'virtio-pmem' as cold added devices. AFAIU 'VirtioDeviceClass' being parent class and 'hotplug/unplug' methods implemented for virtio-pmem device. So, pci bus hotplug/unplug should call the corresponding functions? >>> the problem is

[Qemu-devel] [RFC PATCH 09/17] replay: introduce breakpoint at the specified step

2018-04-25 Thread Pavel Dovgalyuk
This patch introduces replay_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. The commands have one argument - number of instructions executed since the start of the

[Qemu-devel] [RFC PATCH 11/17] replay: flush events when exitting

2018-04-25 Thread Pavel Dovgalyuk
This patch adds events processing when emulation finishes instead of just cleaning the queue. Now the bdrv coroutines will be in consistent state when emulator closes. It allows correct polling of the block layer at exit. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [RFC PATCH 15/17] replay: flush rr queue before loading the vmstate

2018-04-25 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing

[Qemu-devel] [RFC PATCH 07/17] qcow2: introduce icount field for snapshots

2018-04-25 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk --- block/qcow2-snapshot.c |9 + block/qcow2.h |2 ++ 2 files

[Qemu-devel] [RFC PATCH 05/17] replay: finish record/replay before closing the disks

2018-04-25 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |

[Qemu-devel] [RFC PATCH 06/17] migration: introduce icount field for snapshots

2018-04-25 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for rewinding the recorded execution to the specific moment of the time. E.g., 'reverse step' action needs to load the nearest

[Qemu-devel] [RFC PATCH 12/17] timer: remove replay clock probe in deadline calculation

2018-04-25 Thread Pavel Dovgalyuk
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. However, this probing was made in replay mode for the timer lists that are empty. This patch removes clock probing in

[Qemu-devel] [RFC PATCH 04/17] replay: don't drain/flush bdrv queue while RR is working

2018-04-25 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode.

[Qemu-devel] [RFC PATCH 00/17] reverse debugging

2018-04-25 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed

[Qemu-devel] [RFC PATCH 03/17] replay: update docs for record/replay with block devices

2018-04-25 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt

[Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for record/replay

2018-04-25 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file

[Qemu-devel] [RFC PATCH 01/17] block: implement bdrv_snapshot_goto for blkreplay

2018-04-25 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk ---

Re: [Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 02:41 PM, Christian Borntraeger wrote: > You load from address 0. > > On 04/25/2018 02:34 PM, Thomas Huth wrote: >> On 25.04.2018 14:18, Christian Borntraeger wrote: >>> >>> On 04/25/2018 11:08 AM, Thomas Huth wrote: >>> --- a/pc-bios/s390-ccw/netmain.c +++

Re: [Qemu-devel] [PATCH v3 0/3] pc-bios/s390-ccw: Some few network boot improvements

2018-04-25 Thread Viktor VM Mihajlovski
On 25.04.2018 11:08, Thomas Huth wrote: > Note: I've decided to removed the pxelinux.cfg patches from this series > for now, since full pxelinux support requires to parse some additional > DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the > SLOF libnet code needs to be

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 09:48, Cornelia Huck wrote: > On Wed, 25 Apr 2018 08:44:15 +0200 > Markus Armbruster wrote: > >> Laszlo Ersek writes: >> >>> Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used >>> in both @CpuInfo and @CpuInfoFast -- the

Re: [Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Christian Borntraeger
You load from address 0. On 04/25/2018 02:34 PM, Thomas Huth wrote: > On 25.04.2018 14:18, Christian Borntraeger wrote: >> >> On 04/25/2018 11:08 AM, Thomas Huth wrote: >> >>> --- a/pc-bios/s390-ccw/netmain.c >>> +++ b/pc-bios/s390-ccw/netmain.c >>> @@ -283,6 +283,15 @@ void panic(const char

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Viktor VM Mihajlovski
On 25.04.2018 09:48, Cornelia Huck wrote: > On Wed, 25 Apr 2018 08:44:15 +0200 > Markus Armbruster wrote: > >> Laszlo Ersek writes: >> >>> Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used >>> in both @CpuInfo and @CpuInfoFast -- the

Re: [Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Thomas Huth
On 25.04.2018 14:18, Christian Borntraeger wrote: > > On 04/25/2018 11:08 AM, Thomas Huth wrote: > >> --- a/pc-bios/s390-ccw/netmain.c >> +++ b/pc-bios/s390-ccw/netmain.c >> @@ -283,6 +283,15 @@ void panic(const char *string) >> } >> } >> >> +void write_subsystem_identification(void) >>

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:32, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: >> Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used >> in both @CpuInfo and @CpuInfoFast -- the return types of the @query-cpus >> and @query-cpus-fast commands, respectively), and assigned,

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Peter Maydell
On 25 April 2018 at 11:17, Thomas Huth wrote: > On 25.04.2018 11:50, David Hildenbrand wrote: >> On 25.04.2018 07:21, Thomas Huth wrote: >>> The consoles ("sclpconsole" and "sclplmconsole") can only be configured >>> with "-device" and "-chardev" so far. Other machines use the

Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:30, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: >> Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it > > s/added added/added/ The more I edit commit messages, the more I mess them up :) Thanks! Laszlo

Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 08:39, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it >> failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X >> was not defined. The updated @query-cpus-fast example

Re: [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:03, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. [snip] > qapi/qapi-types-misc.h:654:20: error:

Re: [Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 11:08 AM, Thomas Huth wrote: > --- a/pc-bios/s390-ccw/netmain.c > +++ b/pc-bios/s390-ccw/netmain.c > @@ -283,6 +283,15 @@ void panic(const char *string) > } > } > > +void write_subsystem_identification(void) > +{ > +uint32_t *schid = (uint32_t *) 184; > +uint32_t

Re: [Qemu-devel] [PATCH v2 0/9] block: Add COR filter driver

2018-04-25 Thread Max Reitz
On 2018-04-21 15:29, Max Reitz wrote: > This series adds a copy-on-read block filter driver which works by > simply setting the BDRV_REQ_COPY_ON_READ flag on write requests (and > otherwise just passing everything through). > > Cover letter of v1: >

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-25 Thread Igor Mammedov
On Tue, 24 Apr 2018 17:42:44 +0200 David Hildenbrand wrote: > On 24.04.2018 16:00, Igor Mammedov wrote: > > On Mon, 23 Apr 2018 11:32:25 -0400 (EDT) > > Pankaj Gupta wrote: > > > >> Hi Igor, > >> > >>> > Right now we can only map

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 07:21 AM, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the

Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device

2018-04-25 Thread Pankaj Gupta
Hi, Compile failures are because Qemu 'Memory-Device changes' are not yet in qemu master. As mentioned in Qemu patch message patch is dependent on 'Memeory-device' patches by 'David Hildenbrand'. Already picked up by maintainer. > Hi, > > This series failed build test on s390x host. Please

Re: [Qemu-devel] [PATCH v2 2/2] ui: introduce vfio_display_reset

2018-04-25 Thread Gerd Hoffmann
> /* -- */ > +void vfio_display_reset(VFIOPCIDevice *vdev) > +{ > +if (!vdev || !vdev->dpy || !vdev->dpy->con) { > +return; > +} > + > +dpy_gl_scanout_disable(vdev->dpy->con); This should not be called with a

Re: [Qemu-devel] [PATCH v12 00/21] Multifd

2018-04-25 Thread Juan Quintela
Juan Quintela wrote: > Hi > > > [v12] > > Big news, it is not RFC anymore, it works reliabely for me. > > Changes: > - Locknig changed completely (several times) > - We now send all pages through the channels. In a 2GB guest with 1 disk > and a network card, the amount of

Re: [Qemu-devel] [PATCH for 2.13 v4 00/20] linux-user: move arch specific parts to arch directories

2018-04-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180424192635.6027-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v4 00/20] linux-user: move arch specific parts to arch directories === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v12 17/21] migration: Create ram_multifd_page

2018-04-25 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal

<    1   2   3   4   >