Re: [Qemu-devel] [PATCH] spapr/vio: deprecate the "irq" property

2018-06-05 Thread Greg Kurz
On Wed, 6 Jun 2018 10:18:52 +1000 David Gibson wrote: > On Tue, Jun 05, 2018 at 08:56:26AM +0200, Cédric Le Goater wrote: > > VIO devices have an "irq" property that can be used by the sPAPR IRQ > > allocator as an IRQ number hint. But it is not set in QEMU nor in > > libvirt. It brings

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-05 Thread Peter Xu
On Tue, Jun 05, 2018 at 09:22:51PM +0800, Wei Wang wrote: > On 06/05/2018 02:58 PM, Peter Xu wrote: > > On Mon, Jun 04, 2018 at 04:04:51PM +0800, Wei Wang wrote: > > > On 05/30/2018 08:47 PM, Michael S. Tsirkin wrote: > > > > On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote: > > > > > On

[Qemu-devel] [Bug 855800] Re: KVM crashes when attempting to restart migration

2018-06-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/855800 Title: KVM crashes

[Qemu-devel] [Bug 855800] Re: KVM crashes when attempting to restart migration

2018-06-05 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] About cpu_physical_memory_map()

2018-06-05 Thread Huaicheng Li
Hi Peter, Just a follow up on my previous question. I have figured it out by trying it out with QEMU. I'm writing to thank you again for your help! I really appreciate that. Thank you! Best, Huaicheng On Fri, Jun 1, 2018 at 1:00 AM Huaicheng Li wrote: > Hi Peter, > > Thank you a lot for the

Re: [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu Todo: - address Rx slow performance - event index interrupt suppression test And there's something more need to test: - vIOMMU support - migration Thanks

Re: [Qemu-devel] [RFC v2 8/8] virtio: guest driver reload for vhost-net

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:08, w...@redhat.com wrote: From: Wei Xu last_avail, avail_wrap_count, used_idx and used_wrap_count are needed to support vhost-net backend, all these are either 16 or bool variables, since state.num is 64bit wide, so here it is possible to put them to the 'num' without

Re: [Qemu-devel] [RFC v2 7/8] virtio: event suppression for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:08, w...@redhat.com wrote: From: Wei Xu Signed-off-by: Wei Xu Signed-off-by: Wei Xu Duplicated. --- hw/virtio/virtio.c | 115 +++-- include/standard-headers/linux/virtio_config.h | 13 +++ 2 files changed, 119

Re: [Qemu-devel] [PATCH] vhost-user-blk: start vhost when guest kicks

2018-06-05 Thread Yongji Xie
On 5 June 2018 at 22:23, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 09:56:10PM +0800, Yongji Xie wrote: >> Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early") >> kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK. This would cause >> that those old guests fail

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 11:38, Wei Xu wrote: + +head = vq->last_avail_idx; +i = head; + +caches = vring_get_region_caches(vq); +cache = >desc; +vring_packed_desc_read(vdev, , cache, i); I think we'd better find a way to avoid reading descriptor twice. Do you mean here and the

Re: [Qemu-devel] [RFC v2 6/8] virtio: flush/push for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:08, w...@redhat.com wrote: From: Wei Xu Signed-off-by: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 109 ++--- 1 file changed, 96 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH 1/2] migration: Fixes for non-migratable RAMBlocks

2018-06-05 Thread Peter Xu
On Tue, Jun 05, 2018 at 05:25:44PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There are still a few cases where migration code is using the macros > and functions that do all RAMBlocks rather than just the migratable > blocks; fix those up. > >

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:29:54AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Signed-off-by: Wei Xu > >--- > > hw/virtio/virtio.c | 145 > > - > > 1 file changed, 144 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-05 Thread Peter Xu
On Wed, Jun 06, 2018 at 11:36:00AM +0800, Peter Xu wrote: > On Tue, Jun 05, 2018 at 05:25:45PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The migration code should be using the > > RAMBLOCK_FOREACH_MIGRATABLE and qemu_ram_foreach_block_migratable > >

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:08, w...@redhat.com wrote: From: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 145 - 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

Re: [Qemu-devel] [RFC v2 4/8] virtio: get avail bytes check for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu mostly as same as 1.0 except traversing all desc to feed headcount, need a refactor. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 148 +++-- 1 file changed, 145 insertions(+), 3

Re: [Qemu-devel] [RFC v2 3/8] virtio: empty check and desc read for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu helper for ring empty check and descriptor read. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 62 +++--- 1 file changed, 59 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [RFC v2 2/8] virtio: memory cache for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu Mostly reuse memory cache with 1.0 except for the offset calculation. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [RFC v2 1/8] virtio: feature bit, data structure, init for 1.1

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu New feature bit and members for packed ring. Signed-off-by: Wei Xu --- hw/net/vhost_net.c | 2 ++ hw/virtio/virtio.c | 27 --

Re: [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:07, w...@redhat.com wrote: From: Wei Xu Todo: - address Rx slow performance - event index interrupt suppression test Tiwei's code support event index, you can try with that. Actually, unless you disable event_idx explicitly, it work by default. v1->v2 - sync to

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Jason Wang
On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after

Re: [Qemu-devel] [PATCH] spapr: don't call KVM_PPC_CONFIGURE_V3_MMU if HPT is in userspace

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 11:14:53AM +0200, Greg Kurz wrote: > On Tue, 5 Jun 2018 09:42:11 +1000 > David Gibson wrote: > > > On Fri, May 25, 2018 at 02:54:12PM +0200, Greg Kurz wrote: > > > Since the kernel commit "dbfcf3cb9c68 powerpc/64: Call H_REGISTER_PROC_TBL > > > when running as a HPT guest

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

2018-06-05 Thread Yasunori Goto
> Hi, > > > > > > I'm investigating status of vNVDIMM on qemu/KVM, > > > and I have some questions about it. I'm glad if anyone answer them. > > > > > > In my understanding, qemu/KVM has a feature to show NFIT for guest, > > > and it will be still updated about platform capability with this

Re: [Qemu-devel] [PATCH v3] target/ppc: Allow PIR read in privileged mode

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 06:46:12PM +0200, Greg Kurz wrote: > On Mon, 4 Jun 2018 10:53:22 +1000 > David Gibson wrote: > > > On Mon, May 07, 2018 at 01:52:42PM -0300, luporl wrote: > > > According to PowerISA, the PIR register should be readable in privileged > > > mode also, not only in

Re: [Qemu-devel] [RFC 1/3] memory: add MemTxAttrs to translate function

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 02:38:31PM +0100, Peter Maydell wrote: > On 5 June 2018 at 14:19, Peter Xu wrote: > > Add a new MemTxAttrs parameter to the IOMMUMemoryRegionClass.translate() > > function, which takes some extra context of the translation request. > > > > Signed-off-by: Peter Xu > > ---

Re: [Qemu-devel] [RFC PATCH] target/ppc: extend eieio for POWER9

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 10:14:13AM +0200, Cédric Le Goater wrote: > On 06/05/2018 01:10 AM, David Gibson wrote: > > On Mon, Jun 04, 2018 at 07:20:39PM +0200, Cédric Le Goater wrote: > >> POWER9 introduced a new variant of the eieio instruction using bit 6 > >> as a hint to tell the CPU it is a

Re: [Qemu-devel] [PATCH] spapr/vio: deprecate the "irq" property

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 08:56:26AM +0200, Cédric Le Goater wrote: > VIO devices have an "irq" property that can be used by the sPAPR IRQ > allocator as an IRQ number hint. But it is not set in QEMU nor in > libvirt. It brings unnecessary complexity to the underlying layers > managing the IRQ

Re: [Qemu-devel] [PATCH] hw/arm: Remove the deprecated xlnx-ep108 machine

2018-06-05 Thread Alistair Francis
On Tue, Jun 5, 2018 at 2:18 PM, Thomas Huth wrote: > It has been marked as deprecated since QEMU v2.11, so it is time to > remove this now. The xlnx-zcu102 machine is very much the same and > can be used as a replacement instead. > > Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Siwei Liu
On Tue, Jun 5, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:16:44PM -0700, Siwei Liu wrote: >> Good to see this discussion going. I share the same feeling that the >> decision of plugging the primary (passthrough) should only be made >> until guest driver acknowledges

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Siwei Liu
Good to see this discussion going. I share the same feeling that the decision of plugging the primary (passthrough) should only be made until guest driver acknowledges DRIVER_OK and _F_STANDBY. Architecturally this intelligence should be baken to QEMU itself rather than moving up to management

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: >> > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler >> > wrote: >> > > On Tue, Jun 05, 2018 at 06:25:27PM

[Qemu-devel] [PATCH 1/2] WHPX workaround bug in OSVW handling

2018-06-05 Thread Justin Terry (VM) via Qemu-devel
Adds a workaround to an incorrect value setting CPUID Fn8000_0001_ECX[bit 9 OSVW] = 1. This can cause a guest linux kernel to panic when an issue to rdmsr C001_0140h returns 0. Disabling this feature correctly allows the guest to boot without accessing the osv workarounds. Signed-off-by: Justin

[Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits

2018-06-05 Thread Justin Terry (VM) via Qemu-devel
Some variations of Linux kernels end up accessing MSR's that the Windows Hypervisor doesn't implement which causes a GP to be returned to the guest. This fix registers QEMU for unimplemented MSR access and globally returns 0 on reads and ignores writes. This behavior is allows the Linux kernel to

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler > > wrote: > > > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > > >> On Mon, May 21, 2018 at

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-05 Thread Michal Suchánek
On Wed, 23 May 2018 18:35:31 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, May 23, 2018 at 01:19:46PM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Mon, May 21, 2018 at 07:44:40PM +0100, Daniel P. Berrangé > >> > wrote: > >> >> On

Re: [Qemu-devel] [Qemu-block] [PATCH 4/5] qapi: add x-block-dirty-bitmap-merge

2018-06-05 Thread John Snow
On 06/05/2018 05:13 PM, Jeff Cody wrote: > On Tue, Jun 05, 2018 at 02:59:04PM -0400, John Snow wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: John Snow >> --- >> block/dirty-bitmap.c | 18 ++ >>

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-05 Thread Konrad Rzeszutek Wilk
On Mon, Jun 04, 2018 at 06:15:09PM -0300, Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > > > AMD

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:16:44PM -0700, Siwei Liu wrote: > Good to see this discussion going. I share the same feeling that the > decision of plugging the primary (passthrough) should only be made > until guest driver acknowledges DRIVER_OK and _F_STANDBY. > Architecturally this intelligence

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 03:46:45PM -0500, Eric Blake wrote: > On 06/05/2018 03:28 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 05, 2018 at 03:09:17PM -0500, Eric Blake wrote: > > > On 06/05/2018 02:58 PM, Richard W.M. Jones wrote: > > > > > Binary blobs can always be base64 encoded for

[Qemu-devel] [PATCH] hw/arm: Remove the deprecated xlnx-ep108 machine

2018-06-05 Thread Thomas Huth
It has been marked as deprecated since QEMU v2.11, so it is time to remove this now. The xlnx-zcu102 machine is very much the same and can be used as a replacement instead. Signed-off-by: Thomas Huth --- hw/arm/xlnx-zcu102.c | 62 ++--

Re: [Qemu-devel] [Qemu-block] [PATCH 4/5] qapi: add x-block-dirty-bitmap-merge

2018-06-05 Thread Jeff Cody
On Tue, Jun 05, 2018 at 02:59:04PM -0400, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: John Snow > --- > block/dirty-bitmap.c | 18 ++ > blockdev.c | 30

Re: [Qemu-devel] [PULL v1 27/38] target-microblaze: mmu: Add a configurable output address mask

2018-06-05 Thread Edgar Iglesias
Hi, Sorry for top post. This was my fuck up. The second assignment should go away. I'll send out a fix later. Thanks, Edgar --- Sent from my phone Original Message Subject: Re: [PULL v1 27/38] target-microblaze: mmu: Add a configurable output address mask From: Peter

Re: [Qemu-devel] [PULL v1 16/38] target-microblaze: Break out trap_illegal()

2018-06-05 Thread Edgar Iglesias
Yeah, I think we should perhaps remove the nop insn counting hack all together... Cheers, Edgar --- Sent from my phone Original Message Subject: Re: [PULL v1 16/38] target-microblaze: Break out trap_illegal() From: Peter Maydell Date: Jun 4, 2018, 20:12 To: "Edgar E.

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Eric Blake
On 06/05/2018 03:28 PM, Michael S. Tsirkin wrote: On Tue, Jun 05, 2018 at 03:09:17PM -0500, Eric Blake wrote: On 06/05/2018 02:58 PM, Richard W.M. Jones wrote: Binary blobs can always be base64 encoded for representation within a valid JSON UTF-8 string (and we already have several QMP

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 01:20:33PM -0700, Samudrala, Sridhar wrote: > > On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: > > I don't think this is sufficient. > > Sure. This is not sufficient for a complete solution, but is Qemu the right > place > to manage primary/standby interfaces? > > I

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 03:09:17PM -0500, Eric Blake wrote: > On 06/05/2018 02:58 PM, Richard W.M. Jones wrote: > > > Binary blobs can always be base64 encoded for representation within > > > a valid JSON UTF-8 string (and we already have several QMP > > > interfaces that utilize base64 encoding

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: I don't think this is sufficient. Sure. This is not sufficient for a complete solution, but is Qemu the right place to manage primary/standby interfaces? I think the other steps including plugging/unplugging the primary interface needs to

[Qemu-devel] [PULL 5/6] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-06-05 Thread Alex Williamson
With vfio ioeventfd support, we can program vfio-pci to perform a specified BAR write when an eventfd is triggered. This allows the KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding userspace handling for these events. On the same micro-benchmark where the ioeventfd got us to

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Eric Blake
On 06/05/2018 02:58 PM, Richard W.M. Jones wrote: Binary blobs can always be base64 encoded for representation within a valid JSON UTF-8 string (and we already have several QMP interfaces that utilize base64 encoding to pass through what is otherwise invalid UTF-8). It does inflate things

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:54:07PM -0500, Eric Blake wrote: > On 06/05/2018 02:47 PM, Michael S. Tsirkin wrote: > > > > > Layer 1: > > > > The string shall always be a JSON 'object'; i.e. of the form > > > > { "something": ... , "more": ... } > > > > > > > > The key strings shall be

[Qemu-devel] [PULL 4/6] vfio/quirks: ioeventfd quirk acceleration

2018-06-05 Thread Alex Williamson
The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found in device MMIO space. Normally PCI config space is considered a slow path and further optimization is unnecessary, however NVIDIA uses a register here to enable the MSI interrupt to re-trigger. Exiting to QEMU for this MSI-ACK

[Qemu-devel] [PULL 1/6] vfio: remove DPRINTF() definition from vfio-common.h

2018-06-05 Thread Alex Williamson
From: Tiwei Bie This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts. Signed-off-by: Tiwei Bie Reviewed-by: Michael S. Tsirkin Reviewed-by: Eric Auger Signed-off-by:

[Qemu-devel] [PULL 6/6] vfio/pci: Default display option to "off"

2018-06-05 Thread Alex Williamson
Commit a9994687cb9b ("vfio/display: core & wireup") added display support to vfio-pci with the default being "auto", which breaks existing VMs when the vGPU requires GL support but had no previous requirement for a GL compatible configuration. "Off" is the safer default as we impose no new

[Qemu-devel] [PULL 3/6] vfio/quirks: Add quirk reset callback

2018-06-05 Thread Alex Williamson
Quirks can be self modifying, provide a hook to allow them to cleanup on device reset if desired. Reviewed-by: Eric Auger Reviewed-by: Peter Xu Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c|2 ++ hw/vfio/pci.h|2 ++ 3

[Qemu-devel] [PULL 2/6] vfio/quirks: Add common quirk alloc helper

2018-06-05 Thread Alex Williamson
This will later be used to include list initialization. Reviewed-by: Eric Auger Reviewed-by: Peter Xu Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 48 +--- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git

[Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05

2018-06-05 Thread Alex Williamson
The following changes since commit 41feb5b955f0d7c9d071b2c5adbc404ae2895c7a: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging (2018-06-05 10:38:33 +0100) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Richard W.M. Jones
On Tue, Jun 05, 2018 at 02:54:07PM -0500, Eric Blake wrote: > On 06/05/2018 02:47 PM, Michael S. Tsirkin wrote: > > >>>Layer 1: > >>>The string shall always be a JSON 'object'; i.e. of the form > >>> { "something": ... , "more": ... } > >>> > >>>The key strings shall be non-null and

Re: [Qemu-devel] [Qemu-block] storing machine data in qcow images?

2018-06-05 Thread Eric Blake
On 06/05/2018 02:47 PM, Michael S. Tsirkin wrote: Layer 1: The string shall always be a JSON 'object'; i.e. of the form { "something": ... , "more": ... } The key strings shall be non-null and non-empty and shall be unique. I think it would be simpler if layer 0 simply

[Qemu-devel] [PATCH] qemu-binfmt-conf.sh: ignore the OS/ABI field

2018-06-05 Thread Laurent Vivier
Most of the binaries have a value of "UNIX - System V" for the OS/ABI. But cc1 has a value of "UNIX - GNU", and if we don't update the binfmt mask to ignore the OS/ABI field, gcc fails to execute it: gcc: error trying to exec '/usr/lib/gcc/m68k-linux-gnu/7/cc1': execv: Exec format error

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 04:03:24PM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 10:21:59AM +0100, Dr. David Alan Gilbert wrote: > > > > > > This seems to have fizzled out because of a lack of a concrete proposal; > > so here is one based on a reply to Max's post: > > > > * Max Reitz

[Qemu-devel] [RFC v2 8/8] virtio: guest driver reload for vhost-net

2018-06-05 Thread wexu
From: Wei Xu last_avail, avail_wrap_count, used_idx and used_wrap_count are needed to support vhost-net backend, all these are either 16 or bool variables, since state.num is 64bit wide, so here it is possible to put them to the 'num' without introducing a new case while handling ioctl.

[Qemu-devel] [RFC v2 4/8] virtio: get avail bytes check for packed ring

2018-06-05 Thread wexu
From: Wei Xu mostly as same as 1.0 except traversing all desc to feed headcount, need a refactor. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 148 +++-- 1 file changed, 145 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c

[Qemu-devel] [RFC v2 3/8] virtio: empty check and desc read for packed ring

2018-06-05 Thread wexu
From: Wei Xu helper for ring empty check and descriptor read. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 62 +++--- 1 file changed, 59 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index f6c0689..bd669a2

[Qemu-devel] [RFC v2 6/8] virtio: flush/push for packed ring

2018-06-05 Thread wexu
From: Wei Xu Signed-off-by: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 109 ++--- 1 file changed, 96 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 0160d03..6f2da83 100644 ---

[Qemu-devel] [RFC v2 7/8] virtio: event suppression for packed ring

2018-06-05 Thread wexu
From: Wei Xu Signed-off-by: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 115 +++-- include/standard-headers/linux/virtio_config.h | 13 +++ 2 files changed, 119 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio.c

[Qemu-devel] [RFC v2 2/8] virtio: memory cache for packed ring

2018-06-05 Thread wexu
From: Wei Xu Mostly reuse memory cache with 1.0 except for the offset calculation. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index e192a9a..f6c0689

[Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread wexu
From: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 145 - 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index cdbb5af..0160d03 100644 --- a/hw/virtio/virtio.c +++

[Qemu-devel] [RFC v2 1/8] virtio: feature bit, data structure, init for 1.1

2018-06-05 Thread wexu
From: Wei Xu New feature bit and members for packed ring. Signed-off-by: Wei Xu --- hw/net/vhost_net.c | 2 ++ hw/virtio/virtio.c | 27 -- include/hw/virtio/virtio.h | 4 +++-

[Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support

2018-06-05 Thread wexu
From: Wei Xu Todo: - address Rx slow performance - event index interrupt suppression test v1->v2 - sync to tiwei's v5 - reuse memory cache function with 1.0 - dropped detach patch and notification helper(04 & 05 in v1) - guest virtio-net driver unload/reload support - event suppression

[Qemu-devel] [PATCH 0/5] block dirty bitmaps: support libvirt API

2018-06-05 Thread John Snow
This is largely the same series that Vladimir sent in January, but at the time I was unsure of if we'd want these commands or not in QEMU. After discussing with Virtuozzo their plans for a checkpoint-like API implemented primarily in libvirt, I agree that these commands are at least tentatively

Re: [Qemu-devel] The side effect of changing Processor Brand string?

2018-06-05 Thread Chris Friesen
On 06/04/2018 10:09 PM, You, Lizhen wrote: Hi All, I'd like to change the Processor Brand String(CPUID[0x8002|0x8003|0x8004]) of my guest OSS cpu model to a string that won't be standard Intel or AMD related processor brand string. Would this change have any side effect on the

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 10:21:59AM +0100, Dr. David Alan Gilbert wrote: > > > This seems to have fizzled out because of a lack of a concrete proposal; > so here is one based on a reply to Max's post: > > * Max Reitz (mre...@redhat.com) wrote: > > > > > The original problem was that you need

[Qemu-devel] [PATCH 2/5] qapi: add x-block-dirty-bitmap-enable/disable

2018-06-05 Thread John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy [Added x- prefix. --js] Signed-off-by: John Snow --- blockdev.c | 42 ++ qapi/block-core.json | 42 ++ 2 files changed, 84 insertions(+) diff --git a/blockdev.c

[Qemu-devel] [PATCH 4/5] qapi: add x-block-dirty-bitmap-merge

2018-06-05 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- block/dirty-bitmap.c | 18 ++ blockdev.c | 30 ++ include/block/dirty-bitmap.h | 3 ++- qapi/block-core.json

[Qemu-devel] [PATCH 3/5] qmp: transaction support for x-block-dirty-bitmap-enable/disable

2018-06-05 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy [Added x- prefix. --js] Signed-off-by: John Snow --- blockdev.c| 81 ++- qapi/transaction.json | 4 +++ 2 files changed, 84 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 1/5] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

2018-06-05 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Add locks and remove comments about BQL accordingly to dirty_bitmap_mutex definition in block_int.h. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- block/dirty-bitmap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 5/5] qapi: add disabled parameter to block-dirty-bitmap-add

2018-06-05 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This is needed, for example, to create a new bitmap and merge several disabled bitmaps into a new one. Without this flag we will have to put block-dirty-bitmap-add and block-dirty-bitmap-disable into one transaction. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler > wrote: > > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > >> > Add a machine command line option

Re: [Qemu-devel] [PATCH v3 2/2] vl: fix use of --daemonize with --preconfig

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 04:00:43PM +0200, Igor Mammedov wrote: > When using --daemonize, the initial lead process will fork a child and > then wait to be notified that setup is complete via a pipe, before it > exits. When using --preconfig there is an extra call to main_loop() > before the

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: >> > Add a machine command line option to allow the user to control the Platform >> > Capabilities Structure

Re: [Qemu-devel] [PATCH v3 1/2] cli: Don't run early event loop if no --preconfig was specified

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 04:00:42PM +0200, Igor Mammedov wrote: [...] > Based on > From: Michal Privoznik > Subject: [PATCH] cli: Don't run early event loop if no --preconfig was > specified > Message-Id: > Michal's patch is already queued on machine-next. It should be dropped if this

[Qemu-devel] [PATCH 1/2] slirp: correct size computation while concatenating mbuf

2018-06-05 Thread P J P
From: Prasad J Pandit While reassembling incoming fragmented datagrams, 'm_cat' routine extends the 'mbuf' buffer, if it has insufficient room. It computes a wrong buffer size, which leads to overwriting adjacent heap buffer area. Correct this size computation in m_cat. Reported-by: ZDI

[Qemu-devel] [PATCH 0/2] correct size computation in m_cat

2018-06-05 Thread P J P
From: Prasad J Pandit Hello, While reassembling incoming fragmented datagrams, 'm_cat' routine extends the 'mbuf' buffer if it has insufficient room. It computes a wrong buffer size, which leads to overwriting adjacent heap buffer area. This patch set fixes this issue and formats m_cat()

[Qemu-devel] [PATCH 2/2] slirp: reformat m_cat routine

2018-06-05 Thread P J P
From: Prasad J Pandit Coding style changes to the m_cat routine and minor refactoring. Signed-off-by: Prasad J Pandit --- slirp/mbuf.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/slirp/mbuf.c b/slirp/mbuf.c index

Re: [Qemu-devel] [PATCH v3b 16/18] target/arm: Implement FDUP/DUP

2018-06-05 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 37 + > target/arm/sve.decode | 8 > 2 files changed, 45 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3b 15/18] target/arm: Implement SVE Integer Compare - Scalars Group

2018-06-05 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 31 +++ > target/arm/translate-sve.c | 102 + > target/arm/sve.decode | 8 +++ > 4

Re: [Qemu-devel] [PATCH v3b 14/18] target/arm: Implement SVE Predicate Count Group

2018-06-05 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 14 > target/arm/translate-sve.c | 132 + > target/arm/sve.decode | 27 > 4

Re: [Qemu-devel] [PATCH v11 3/5] i386: Add support for CPUID_8000_001E for AMD

2018-06-05 Thread Moger, Babu
> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] > On Behalf Of Moger, Babu > Sent: Tuesday, June 5, 2018 10:49 AM > To: Eduardo Habkost > Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com; > r...@twiddle.net;

Re: [Qemu-devel] [PATCH v3b 13/18] target/arm: Implement SVE Partition Break Group

2018-06-05 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 18 +++ > target/arm/sve_helper.c| 247 + > target/arm/translate-sve.c | 106 > target/arm/sve.decode | 19

Re: [Qemu-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-05 Thread Anthony PERARD
On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: > The xen pci_assign_dev_load_option_rom() currently creates a RAM > memory region with memory_region_init_ram_nomigrate(), and then > manually registers it with vmstate_register_ram(). In fact for > its only callsite, the 'owner'

Re: [Qemu-devel] [PATCH v3] target/ppc: Allow PIR read in privileged mode

2018-06-05 Thread Greg Kurz
On Mon, 4 Jun 2018 10:53:22 +1000 David Gibson wrote: > On Mon, May 07, 2018 at 01:52:42PM -0300, luporl wrote: > > According to PowerISA, the PIR register should be readable in privileged > > mode also, not only in hypervisor privileged mode. > > > > PowerISA 3.0 - 4.3.3 Processor

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > > Add a machine command line option to allow the user to control the Platform > > Capabilities Structure in the virtualized NFIT. This Platform Capabilities > >

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 05:23:59PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 07:20:24PM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 05, 2018 at 02:29:48PM +0100, Daniel P. Berrangé wrote: > > > Existing domains wasn't the case I was concerned about. Consider you have > > >

[Qemu-devel] [PATCH 0/2] Fixups for non-migratable RAMBlocks

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, Cédric's b895de50 got merged at about the same time as some of Peter's changes and there's a rdma case as well; so tidy up those cases that were looping over all (rather than just migratable) RAMBlocks and poison it so we don't end up doing the same thing

[Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The migration code should be using the RAMBLOCK_FOREACH_MIGRATABLE and qemu_ram_foreach_block_migratable not the all-block versions; poison them so that we can't accidentally use them. Signed-off-by: Dr. David Alan Gilbert --- include/exec/ramlist.h | 4 +++-

[Qemu-devel] [PATCH 1/2] migration: Fixes for non-migratable RAMBlocks

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There are still a few cases where migration code is using the macros and functions that do all RAMBlocks rather than just the migratable blocks; fix those up. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 4 ++-- migration/rdma.c | 2 +- 2 files

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 07:20:24PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:29:48PM +0100, Daniel P. Berrangé wrote: > > Existing domains wasn't the case I was concerned about. Consider you have > > libvirt 4.4.0 intsalled and you deploy a *new* domain from a prebuilt > > disk

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:51:52PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 03:44:14PM +0200, Laszlo Ersek wrote: > > On 06/05/18 15:29, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 04:20:46PM +0300, Marcel Apfelbaum wrote: > > >> > > >> > > >> On 06/05/2018 11:43 AM,

Re: [Qemu-devel] libvirt default machine-type guarantees? (was Re: [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 07:16:56PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > eg old OS versions that only work with PC, or more commonly pre-existing > > cloud disk images that were built against PC can't be assumed to just > > work

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:29:48PM +0100, Daniel P. Berrangé wrote: > Existing domains wasn't the case I was concerned about. Consider you have > libvirt 4.4.0 intsalled and you deploy a *new* domain from a prebuilt > disk image "foo". I see. How about q35 as default for new domains only? --

  1   2   3   4   >